claude-flow-novice 2.14.13 → 2.14.15

package/claude-assets/skills/cfn-multi-coordinator-planning/validate-task-planning.sh

@@ -0,0 +1,189 @@
+#!/bin/bash
+
+set -euo pipefail
+
+SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+source "$SCRIPT_DIR/../cfn-redis-coordination/redis-utils.sh"
+
+# Configuration
+MIN_DELIVERABLES=3
+MIN_AGENT_TYPES=2
+MIN_CONTEXT_SCORE=0.8
+TIMEOUT_SECONDS=30
+
+# Colors
+RED='\033[0;31m'
+GREEN='\033[0;32m'
+YELLOW='\033[1;33m'
+NC='\033[0m'
+
+log() {
+    echo -e "${GREEN}[$(date '+%Y-%m-%d %H:%M:%S')] $1${NC}"
+}
+
+warn() {
+    echo -e "${YELLOW}[$(date '+%Y-%m-%d %H:%M:%S')] WARNING: $1${NC}"
+}
+
+error() {
+    echo -e "${RED}[$(date '+%Y-%m-%d %H:%M:%S')] ERROR: $1${NC}"
+    exit 1
+}
+
+validate_deliverables() {
+    local task_data="$1"
+    local deliverables
+    deliverables=$(echo "$task_data" | jq -r '.deliverables[]? // empty' 2>/dev/null || echo "")
+
+    if [[ -z "$deliverables" ]]; then
+        error "No deliverables found in task configuration"
+    fi
+
+    local deliverable_count
+    deliverable_count=$(echo "$deliverables" | wc -l)
+
+    if [[ $deliverable_count -lt $MIN_DELIVERABLES ]]; then
+        error "Insufficient deliverables: $deliverable_count (minimum: $MIN_DELIVERABLES)"
+    fi
+
+    # Check for generic/deliverable anti-patterns
+    while IFS= read -r deliverable; do
+        if [[ "$deliverable" =~ ^(implementation|code|development|fix)$ ]]; then
+            error "Generic deliverable detected: '$deliverable'. Be specific about file names and locations."
+        fi
+    done <<< "$deliverables"
+
+    log "✓ Deliverables validation passed: $deliverable_count specific deliverables"
+}
+
+validate_agent_types() {
+    local task_data="$1"
+    local agent_types
+    agent_types=$(echo "$task_data" | jq -r '.agent_types[]? // empty' 2>/dev/null || echo "")
+
+    if [[ -z "$agent_types" ]]; then
+        error "No agent types specified in task configuration"
+    fi
+
+    local agent_count
+    agent_count=$(echo "$agent_types" | wc -l)
+
+    if [[ $agent_count -lt $MIN_AGENT_TYPES ]]; then
+        error "Insufficient agent types: $agent_count (minimum: $MIN_AGENT_TYPES for software tasks)"
+    fi
+
+    # Check for single-agent anti-patterns
+    if [[ $agent_count -eq 1 ]]; then
+        warn "Single agent type detected: ${agent_types}. Consider adding reviewer/tester agents."
+    fi
+
+    log "✓ Agent types validation passed: $agent_count agent types"
+}
+
+validate_context_completeness() {
+    local task_data="$1"
+    local score=0.0
+
+    # Check for deliverables (0.3 points)
+    if echo "$task_data" | jq -e '.deliverables and (.deliverables | length) > 0' >/dev/null 2>&1; then
+        score=$(echo "$score + 0.3" | bc -l)
+    fi
+
+    # Check for acceptance criteria (0.3 points)
+    if echo "$task_data" | jq -e '.acceptance_criteria and (.acceptance_criteria | length) > 0' >/dev/null 2>&1; then
+        score=$(echo "$score + 0.3" | bc -l)
+    fi
+
+    # Check for in_scope/out_of_scope (0.2 points)
+    if echo "$task_data" | jq -e '.in_scope and (.in_scope | length) > 0' >/dev/null 2>&1; then
+        score=$(echo "$score + 0.1" | bc -l)
+    fi
+
+    if echo "$task_data" | jq -e '.out_of_scope and (.out_of_scope | length) > 0' >/dev/null 2>&1; then
+        score=$(echo "$score + 0.1" | bc -l)
+    fi
+
+    # Check for directory specification (0.2 points)
+    if echo "$task_data" | jq -e '.directory and (.directory | length) > 0' >/dev/null 2>&1; then
+        score=$(echo "$score + 0.2" | bc -l)
+    fi
+
+    if (( $(echo "$score < $MIN_CONTEXT_SCORE" | bc -l) )); then
+        error "Context completeness score: $score (minimum: $MIN_CONTEXT_SCORE)"
+    fi
+
+    log "✓ Context completeness validation passed: score $score"
+}
+
+validate_task_specificity() {
+    local task_data="$1"
+    local task_description
+    task_description=$(echo "$task_data" | jq -r '.task_description // ""' 2>/dev/null || echo "")
+
+    # Check for generic task descriptions
+    local generic_patterns=("CFN Loop implementation" "implement feature" "fix bug" "create code")
+    for pattern in "${generic_patterns[@]}"; do
+        if [[ "$task_description" =~ $pattern ]]; then
+            error "Generic task description detected: '$task_description'. Provide specific implementation details."
+        fi
+    done
+
+    if [[ ${#task_description} -lt 20 ]]; then
+        error "Task description too short: ${#task_description} characters (minimum: 20)"
+    fi
+
+    log "✓ Task specificity validation passed"
+}
+
+validate_namespace_requirements() {
+    local task_data="$1"
+    local zone_name
+    zone_name=$(echo "$task_data" | jq -r '.zone_name // empty' 2>/dev/null || echo "")
+
+    if [[ -z "$zone_name" ]]; then
+        error "Zone name not specified in task configuration"
+    fi
+
+    # Validate zone name format
+    if [[ ! "$zone_name" =~ ^[a-z0-9-]+$ ]]; then
+        error "Invalid zone name format: '$zone_name'. Use lowercase letters, numbers, and hyphens only."
+    fi
+
+    log "✓ Namespace requirements validation passed: zone '$zone_name'"
+}
+
+main() {
+    local config_file="$1"
+
+    if [[ -z "$config_file" ]]; then
+        error "Usage: $0 <task-config-file>"
+    fi
+
+    if [[ ! -f "$config_file" ]]; then
+        error "Configuration file not found: $config_file"
+    fi
+
+    log "Starting task planning validation for: $config_file"
+
+    # Read and validate JSON
+    local task_data
+    if ! task_data=$(jq . "$config_file" 2>/dev/null); then
+        error "Invalid JSON in configuration file: $config_file"
+    fi
+
+    # Run all validations
+    validate_deliverables "$task_data"
+    validate_agent_types "$task_data"
+    validate_context_completeness "$task_data"
+    validate_task_specificity "$task_data"
+    validate_namespace_requirements "$task_data"
+
+    log "✅ Task planning validation completed successfully"
+
+    # Output validated task data for next stage
+    echo "$task_data" > "/tmp/validated-task-$(basename "$config_file")"
+    log "Validated task data saved to: /tmp/validated-task-$(basename "$config_file")"
+}
+
+# Execute main function with all arguments
+main "$@"

package/dist/agents/agent-loader.js

@@ -1,12 +1,145 @@
+"use strict";
 /**
  * Dynamic Agent Loader - Reads agent definitions from .claude/agents/ directory
  * Single source of truth for agent types in the system
- */ import { readFileSync, existsSync } from 'node:fs';
-import { glob } from 'glob';
-import { resolve, dirname } from 'node:path';
-import { parse as parseYaml } from 'yaml';
+ */ var __awaiter = this && this.__awaiter || function(thisArg, _arguments, P, generator) {
+    function adopt(value) {
+        return value instanceof P ? value : new P(function(resolve) {
+            resolve(value);
+        });
+    }
+    return new (P || (P = Promise))(function(resolve, reject) {
+        function fulfilled(value) {
+            try {
+                step(generator.next(value));
+            } catch (e) {
+                reject(e);
+            }
+        }
+        function rejected(value) {
+            try {
+                step(generator["throw"](value));
+            } catch (e) {
+                reject(e);
+            }
+        }
+        function step(result) {
+            result.done ? resolve(result.value) : adopt(result.value).then(fulfilled, rejected);
+        }
+        step((generator = generator.apply(thisArg, _arguments || [])).next());
+    });
+};
+var __generator = this && this.__generator || function(thisArg, body) {
+    var _ = {
+        label: 0,
+        sent: function() {
+            if (t[0] & 1) throw t[1];
+            return t[1];
+        },
+        trys: [],
+        ops: []
+    }, f, y, t, g = Object.create((typeof Iterator === "function" ? Iterator : Object).prototype);
+    return g.next = verb(0), g["throw"] = verb(1), g["return"] = verb(2), typeof Symbol === "function" && (g[Symbol.iterator] = function() {
+        return this;
+    }), g;
+    function verb(n) {
+        return function(v) {
+            return step([
+                n,
+                v
+            ]);
+        };
+    }
+    function step(op) {
+        if (f) throw new TypeError("Generator is already executing.");
+        while(g && (g = 0, op[0] && (_ = 0)), _)try {
+            if (f = 1, y && (t = op[0] & 2 ? y["return"] : op[0] ? y["throw"] || ((t = y["return"]) && t.call(y), 0) : y.next) && !(t = t.call(y, op[1])).done) return t;
+            if (y = 0, t) op = [
+                op[0] & 2,
+                t.value
+            ];
+            switch(op[0]){
+                case 0:
+                case 1:
+                    t = op;
+                    break;
+                case 4:
+                    _.label++;
+                    return {
+                        value: op[1],
+                        done: false
+                    };
+                case 5:
+                    _.label++;
+                    y = op[1];
+                    op = [
+                        0
+                    ];
+                    continue;
+                case 7:
+                    op = _.ops.pop();
+                    _.trys.pop();
+                    continue;
+                default:
+                    if (!(t = _.trys, t = t.length > 0 && t[t.length - 1]) && (op[0] === 6 || op[0] === 2)) {
+                        _ = 0;
+                        continue;
+                    }
+                    if (op[0] === 3 && (!t || op[1] > t[0] && op[1] < t[3])) {
+                        _.label = op[1];
+                        break;
+                    }
+                    if (op[0] === 6 && _.label < t[1]) {
+                        _.label = t[1];
+                        t = op;
+                        break;
+                    }
+                    if (t && _.label < t[2]) {
+                        _.label = t[2];
+                        _.ops.push(op);
+                        break;
+                    }
+                    if (t[2]) _.ops.pop();
+                    _.trys.pop();
+                    continue;
+            }
+            op = body.call(thisArg, _);
+        } catch (e) {
+            op = [
+                6,
+                e
+            ];
+            y = 0;
+        } finally{
+            f = t = 0;
+        }
+        if (op[0] & 5) throw op[1];
+        return {
+            value: op[0] ? op[1] : void 0,
+            done: true
+        };
+    }
+};
+var __spreadArray = this && this.__spreadArray || function(to, from, pack) {
+    if (pack || arguments.length === 2) for(var i = 0, l = from.length, ar; i < l; i++){
+        if (ar || !(i in from)) {
+            if (!ar) ar = Array.prototype.slice.call(from, 0, i);
+            ar[i] = from[i];
+        }
+    }
+    return to.concat(ar || Array.prototype.slice.call(from));
+};
+Object.defineProperty(exports, "__esModule", {
+    value: true
+});
+exports.refreshAgents = exports.getAgentsByCategory = exports.isValidAgentType = exports.searchAgents = exports.getAgentCategories = exports.getAllAgents = exports.getAgent = exports.getAvailableAgentTypes = exports.agentLoader = exports.AgentLoader = void 0;
+exports.resolveLegacyAgentType = resolveLegacyAgentType;
+var node_fs_1 = require("node:fs");
+var glob_1 = require("glob");
+var node_path_1 = require("node:path");
+var yaml_1 = require("yaml");
 // Legacy agent type mapping for backward compatibility
-const LEGACY_AGENT_MAPPING = {
+var LEGACY_AGENT_MAPPING = {
     analyst: 'code-analyzer',
     coordinator: 'hierarchical-coordinator',
     optimizer: 'perf-analyzer',
@@ -17,38 +150,40 @@ const LEGACY_AGENT_MAPPING = {
 };
 /**
  * Resolve legacy agent types to current equivalents
- */ export function resolveLegacyAgentType(legacyType) {
+ */ function resolveLegacyAgentType(legacyType) {
     return LEGACY_AGENT_MAPPING[legacyType] || legacyType;
 }
-export class AgentLoader {
-    agentCache = new Map();
-    categoriesCache = [];
-    lastLoadTime = 0;
-    CACHE_EXPIRY = 60_000;
-    getAgentsDirectory() {
-        let currentDir = process.cwd();
+var AgentLoader = /** @class */ function() {
+    function AgentLoader() {
+        this.agentCache = new Map();
+        this.categoriesCache = [];
+        this.lastLoadTime = 0;
+        this.CACHE_EXPIRY = 60000; // 1 minute cache
+    }
+    AgentLoader.prototype.getAgentsDirectory = function() {
+        var currentDir = process.cwd();
         while(currentDir !== '/'){
-            const claudeAgentsPath = resolve(currentDir, '.claude', 'agents');
-            if (existsSync(claudeAgentsPath)) {
+            var claudeAgentsPath = (0, node_path_1.resolve)(currentDir, '.claude', 'agents');
+            if ((0, node_fs_1.existsSync)(claudeAgentsPath)) {
                 return claudeAgentsPath;
             }
-            currentDir = dirname(currentDir);
+            currentDir = (0, node_path_1.dirname)(currentDir);
         }
-        return resolve(process.cwd(), '.claude', 'agents');
-    }
-    parseAgentFile(filePath) {
+        return (0, node_path_1.resolve)(process.cwd(), '.claude', 'agents');
+    };
+    AgentLoader.prototype.parseAgentFile = function(filePath) {
         try {
-            const content = readFileSync(filePath, 'utf-8');
-            const frontmatterMatch = content.match(/^---\r?\n([\s\S]*?)\r?\n---\r?\n([\s\S]*)$/);
+            var content = (0, node_fs_1.readFileSync)(filePath, 'utf-8');
+            var frontmatterMatch = content.match(/^---\r?\n([\s\S]*?)\r?\n---\r?\n([\s\S]*)$/);
             if (!frontmatterMatch) {
-                console.warn(`No frontmatter found in ${filePath}`);
+                console.warn("No frontmatter found in ".concat(filePath));
                 return null;
             }
-            const [, yamlContent, markdownContent] = frontmatterMatch;
-            const frontmatter = parseYaml(yamlContent);
-            const description = frontmatter.description;
+            var yamlContent = frontmatterMatch[1], markdownContent = frontmatterMatch[2];
+            var frontmatter = (0, yaml_1.parse)(yamlContent);
+            var description = frontmatter.description;
             if (!frontmatter.name || !description) {
-                console.warn(`Missing required fields (name, description) in ${filePath}`);
+                console.warn("Missing required fields (name, description) in ".concat(filePath));
                 return null;
             }
             return {
@@ -69,129 +204,13 @@ export class AgentLoader {
                 content: markdownContent.trim()
             };
         } catch (error) {
-            console.error(`Error parsing agent file ${filePath}:`, error);
+            console.error("Error parsing agent file ".concat(filePath, ":"), error);
             return null;
         }
-    }
-    parseTools(frontmatter) {
-        const extractTools = (input)=>{
+    };
+    AgentLoader.prototype.parseTools = function(frontmatter) {
+        var extractTools = function(input) {
             if (Array.isArray(input)) return input.map(String);
-            if (typeof input === 'string') {
-                return input.split(/[,\s]+/).map((t)=>t.trim()).filter((t)=>t.length > 0);
-            }
-            return [];
-        };
-        // Safely handle tools and capabilities.tools
-        const toolsFromFrontmatter = frontmatter.tools ? extractTools(frontmatter.tools) : [];
-        const toolsFromCapabilities = frontmatter.capabilities && typeof frontmatter.capabilities === 'object' ? extractTools(Object(frontmatter.capabilities).tools) : [];
-        return [
-            ...toolsFromFrontmatter,
-            ...toolsFromCapabilities
-        ];
-    }
-    async loadAgents() {
-        const agentsDir = this.getAgentsDirectory();
-        if (!existsSync(agentsDir)) {
-            console.warn(`Agents directory not found: ${agentsDir}`);
-            return;
-        }
-        const agentFiles = await new Promise((resolve, reject)=>{
-            glob('**/*.md', {
-                cwd: agentsDir,
-                ignore: [
-                    '**/README.md',
-                    '**/MIGRATION_SUMMARY.md'
-                ],
-                absolute: true
-            }, (err, matches)=>{
-                if (err) reject(err);
-                else resolve(matches);
-            });
-        });
-        this.agentCache.clear();
-        this.categoriesCache = [];
-        const categoryMap = new Map();
-        for (const filePath of agentFiles){
-            const agent = this.parseAgentFile(filePath);
-            if (agent) {
-                this.agentCache.set(agent.name, agent);
-                const relativePath = filePath.replace(agentsDir, '');
-                const pathParts = relativePath.split('/');
-                const category = pathParts[1] || 'uncategorized';
-                if (!categoryMap.has(category)) {
-                    categoryMap.set(category, []);
-                }
-                categoryMap.get(category).push(agent);
-            }
-        }
-        this.categoriesCache = Array.from(categoryMap.entries()).map(([name, agents])=>({
-                name,
-                agents: agents.sort((a, b)=>a.name.localeCompare(b.name))
-            }));
-        this.lastLoadTime = Date.now();
-    }
-    // Rest of the methods remain similar to the original implementation
-    needsRefresh() {
-        return Date.now() - this.lastLoadTime > this.CACHE_EXPIRY;
-    }
-    async ensureLoaded() {
-        if (this.agentCache.size === 0 || this.needsRefresh()) {
-            await this.loadAgents();
-        }
-    }
-    async getAvailableAgentTypes() {
-        await this.ensureLoaded();
-        const currentTypes = Array.from(this.agentCache.keys());
-        const legacyTypes = Object.keys(LEGACY_AGENT_MAPPING);
-        return Array.from(new Set([
-            ...currentTypes,
-            ...legacyTypes
-        ])).sort();
-    }
-    async getAgent(name) {
-        await this.ensureLoaded();
-        return this.agentCache.get(name) || this.agentCache.get(resolveLegacyAgentType(name)) || null;
-    }
-    async getAllAgents() {
-        await this.ensureLoaded();
-        return Array.from(this.agentCache.values()).sort((a, b)=>a.name.localeCompare(b.name));
-    }
-    async getAgentCategories() {
-        await this.ensureLoaded();
-        return this.categoriesCache;
-    }
-    async searchAgents(query) {
-        await this.ensureLoaded();
-        const lowerQuery = query.toLowerCase();
-        return Array.from(this.agentCache.values()).filter((agent)=>agent.name.toLowerCase().includes(lowerQuery) || agent.description.toLowerCase().includes(lowerQuery) || agent.capabilities?.some((cap)=>cap.toLowerCase().includes(lowerQuery)));
-    }
-    async isValidAgentType(name) {
-        await this.ensureLoaded();
-        return this.agentCache.has(name) || this.agentCache.has(resolveLegacyAgentType(name));
-    }
-    async getAgentsByCategory(category) {
-        const categories = await this.getAgentCategories();
-        const found = categories.find((cat)=>cat.name === category);
-        return found?.agents || [];
-    }
-    async refresh() {
-        this.lastLoadTime = 0;
-        await this.loadAgents();
-    }
-}
-// Singleton instance
-export const agentLoader = new AgentLoader();
-// Convenience exports for use in other modules
-export const getAvailableAgentTypes = ()=>agentLoader.getAvailableAgentTypes();
-export const getAgent = (name)=>agentLoader.getAgent(name);
-export const getAllAgents = ()=>agentLoader.getAllAgents();
-export const getAgentCategories = ()=>agentLoader.getAgentCategories();
-export const searchAgents = (query)=>agentLoader.searchAgents(query);
-export const isValidAgentType = (name)=>agentLoader.isValidAgentType(name);
-export const getAgentsByCategory = (category)=>agentLoader.getAgentsByCategory(category);
-export const refreshAgents = ()=>agentLoader.refresh();
-
-//# sourceMappingURL=agent-loader.js.map.isArray(input)) return input.map(String);
             if (typeof input === 'string') {
                 return input.split(/[,\s]+/).map(function(t) {
                     return t.trim();