claude-flow-novice 2.14.13 → 2.14.15

package/claude-assets/agents/cfn-dev-team/documentation/agent-type-guidelines.md.backup_before_replace

@@ -1,465 +0,0 @@
-# Agent Type Guidelines
-
-**Version:** 2.0.0
-**Last Updated:** 2025-09-30
-
-## Overview
-
-This document provides specific guidance for creating different types of agents based on their primary function.
-
----
-
-## 1. Coder Agents
-
-### For Rust (VALIDATED)
-
-**Basic Tasks:** Use CODE-HEAVY
-
-```yaml
-Tasks:
-  - String processing
-  - Basic error handling
-  - Simple data structures
-  - CRUD operations
-  - Configuration parsing
-
-Expected Improvement: +43% quality vs Minimal
-
-Validation Hooks:
-  - agent-template-validator (validates SQLite lifecycle, ACL declarations)
-  - cfn-loop-memory-validator (validates ACL levels for memory operations)
-  - test-coverage-validator (validates ≥80% line, ≥75% branch coverage)
-
-ACL Level: 1 (Private - agent-scoped data)
-SQLite: Persist confidence scores, implementation notes
-```
-
-**Complex Tasks:** Use MINIMAL
-
-```yaml
-Tasks:
-  - Lock-free algorithms
-  - Lifetime-complex generics
-  - Unsafe code design
-  - Embedded HAL
-  - Async runtime design
-
-Expected Improvement: +31% quality vs Code-Heavy
-
-Validation Hooks:
-  - agent-template-validator (validates SQLite lifecycle, ACL declarations)
-  - cfn-loop-memory-validator (validates ACL levels for memory operations)
-  - test-coverage-validator (validates ≥80% line, ≥75% branch coverage)
-
-ACL Level: 1 (Private - agent-scoped data)
-SQLite: Persist confidence scores, implementation notes
-```
-
-**Example Agents:**
-- `benchmarking-tests/test-agent-code-heavy.md` - Basic tasks
-- `benchmarking-tests/test-agent-minimal.md` - Complex tasks
-
-### For JavaScript/TypeScript (HYPOTHESIS)
-
-Apply same principles but validate with testing:
-
-**Basic Tasks:** Code-Heavy
-- Simple React components
-- Express route handlers
-- Utility functions
-- Basic async/await
-
-**Complex Tasks:** Minimal
-- State management architecture
-- Complex React patterns (render props, HOCs)
-- Performance optimization
-- TypeScript advanced types
-
----
-
-## 2. Reviewer Agents
-
-**Recommended Format:** MINIMAL
-
-**Rationale:**
-- Reviews require contextual reasoning
-- Over-specification creates checklist mentality
-- Need flexibility to identify novel issues
-- Trust AI's pattern recognition
-
-**Validation Hooks:**
-- `agent-template-validator` (validates SQLite lifecycle, ACL declarations)
-- `cfn-loop-memory-validator` (validates ACL levels for memory operations)
-
-**ACL Level:** 3 (Swarm - shared across validation team)
-
-**SQLite Requirements:**
-- Persist review feedback, validation consensus
-- Store findings with appropriate ACL for team access
-
-**Key Responsibilities:**
-- Assess code quality, readability, and maintainability
-- Identify bugs, security issues, and performance problems
-- Suggest architectural improvements
-- Ensure adherence to best practices
-
-**Review Approach:**
-
-### 1. Initial Assessment
-- Understand the change's purpose
-- Review related context (issues, documentation)
-- Identify the scope and impact
-
-### 2. Deep Analysis
-- **Correctness**: Does it work as intended?
-- **Security**: Any vulnerabilities?
-- **Performance**: Efficiency concerns?
-- **Maintainability**: Easy to understand and modify?
-- **Testing**: Adequate test coverage?
-
-### 3. Provide Feedback
-- Be specific and actionable
-- Explain the "why" behind suggestions
-- Offer alternatives when critiquing
-- Acknowledge good patterns
-
-**Example:** `quality/reviewer.md`
-
----
-
-## 3. Architect Agents
-
-**Recommended Format:** MINIMAL
-
-**Rationale:**
-- Architecture requires strategic thinking
-- Solutions must be context-specific
-- Over-constraining limits creative solutions
-- Need to consider trade-offs dynamically
-
-**Validation Hooks:**
-- `agent-template-validator` (validates SQLite lifecycle, ACL declarations)
-- `cfn-loop-memory-validator` (validates ACL levels for memory operations)
-
-**ACL Level:** 3 (Swarm - coordinate multiple agents)
-
-**SQLite Requirements:**
-- Persist ADRs (Architecture Decision Records) with 1 year retention
-- Store design decisions with appropriate ACL for team access
-- All architectural decisions MUST persist to SQLite for audit trail
-
-**Core Responsibilities:**
-- Design system architectures from requirements
-- Make strategic technical decisions
-- Evaluate technology trade-offs
-- Create architectural documentation
-
-**Approach:**
-
-### Requirements Analysis
-Extract functional and non-functional requirements, identify constraints and quality attributes, understand stakeholder needs.
-
-### Architecture Design
-Apply appropriate patterns (microservices, event-driven, CQRS), consider trade-offs, document decisions with ADRs.
-
-### Decision Making
-Framework for evaluating options with explicit trade-off documentation.
-
-**Collaboration:**
-- Work with Coder agents for implementation guidance
-- Coordinate with Reviewer agents for design validation
-- Provide specifications to DevOps for infrastructure
-- Share ADRs via memory system
-
-**Example:** `architecture/system-architect.md`
-
----
-
-## 4. Tester Agents
-
-**Recommended Format:** CODE-HEAVY for unit tests, METADATA for test strategy
-
-**Rationale:**
-- Unit tests benefit from concrete patterns
-- Test structure is often formulaic
-- Examples show proper assertion style
-- But test strategy needs metadata structure
-
-**Validation Hooks:**
-- `agent-template-validator` (validates SQLite lifecycle, ACL declarations)
-- `test-coverage-validator` (validates ≥80% line, ≥75% branch coverage)
-
-**ACL Level:** 3 (Swarm - shared across validation team)
-
-**SQLite Requirements:**
-- Persist test results, coverage metrics
-- Store test strategy with appropriate ACL for team access
-
-**Test Patterns:**
-
-### Rust Testing Pattern
-
-```rust
-#[cfg(test)]
-mod tests {
-    use super::*;
-
-    #[test]
-    fn test_success_case() {
-        let result = function_under_test(valid_input);
-        assert_eq!(result, expected_output);
-    }
-
-    #[test]
-    fn test_error_case() {
-        let result = function_under_test(invalid_input);
-        assert!(result.is_err());
-    }
-
-    #[test]
-    #[should_panic(expected = "error message")]
-    fn test_panic_case() {
-        function_that_should_panic();
-    }
-}
-```
-
-### JavaScript Testing Pattern
-
-```javascript
-describe('ModuleName', () => {
-  beforeEach(() => {
-    // Setup
-  });
-
-  afterEach(() => {
-    // Cleanup
-  });
-
-  test('should handle success case', () => {
-    const result = functionUnderTest(validInput);
-    expect(result).toEqual(expectedOutput);
-  });
-
-  test('should handle error case', async () => {
-    await expect(asyncFunction(invalidInput))
-      .rejects.toThrow('error message');
-  });
-});
-```
-
-**Test Strategy:**
-
-```yaml
-Coverage Requirements:
-  unit_tests: 85%
-  integration_tests: 70%
-  e2e_tests: 30%
-
-Test Categories:
-  - Happy path tests
-  - Error condition tests
-  - Edge case tests
-  - Performance tests (if applicable)
-```
-
-**Example:** `testing/unit/tdd-london-swarm.md`
-
----
-
-## 5. Researcher Agents
-
-**Recommended Format:** MINIMAL
-
-**Rationale:**
-- Research requires open-ended exploration
-- Avoid bias from excessive structure
-- Let evidence guide conclusions
-- Need flexibility in methodology
-
-**Validation Hooks:**
-- `agent-template-validator` (validates SQLite lifecycle, ACL declarations)
-
-**ACL Level:** 1 (Private) or 3 (Swarm) depending on context
-
-**SQLite Requirements:**
-- Persist research findings, competitive analysis
-- Store with appropriate ACL based on sharing requirements
-
-**Core Responsibilities:**
-- Research technologies, patterns, and best practices
-- Analyze trade-offs and alternatives
-- Provide evidence-based recommendations
-- Stay current with industry trends
-
-**Research Approach:**
-
-1. **Define Scope**: Clarify what needs research
-2. **Gather Information**: Use multiple sources
-3. **Analyze Findings**: Evaluate objectively
-4. **Synthesize**: Draw actionable conclusions
-5. **Document**: Clear, referenced reports
-
-**Success Metrics:**
-- Recommendations are actionable
-- Research is thorough and unbiased
-- Sources are credible and current
-
-**Example:** `researcher.md`
-
----
-
-## 6. DevOps Agents
-
-**Recommended Format:** METADATA
-
-**Rationale:**
-- DevOps involves structured workflows
-- Clear requirements for CI/CD pipelines
-- Deployment checklists are essential
-- Balance structure with flexibility
-
-**Validation Hooks:**
-- `agent-template-validator` (validates SQLite lifecycle, ACL declarations)
-- `cfn-loop-memory-validator` (validates ACL levels for memory operations)
-
-**ACL Level:** 3 (Swarm - coordinate with team)
-
-**SQLite Requirements:**
-- Persist deployment logs, infrastructure state
-- Store pipeline configurations with appropriate ACL
-
-**Pipeline Structure:**
-
-```yaml
-CI Pipeline Stages:
-  1_build:
-    steps: [checkout, dependencies, compile]
-    failure_action: fail_fast
-
-  2_test:
-    steps: [unit_tests, integration_tests, e2e_tests]
-    coverage_threshold: 80%
-
-  3_quality:
-    steps: [lint, security_scan, dependency_audit]
-    blocking: true
-
-  4_deploy:
-    environments: [staging, production]
-    strategy: blue_green
-    rollback_enabled: true
-```
-
-**Deployment Strategy:**
-
-```yaml
-Deployment Process:
-  pre_deployment:
-    - backup_database
-    - notify_team
-    - create_deployment_tag
-
-  deployment:
-    - deploy_to_staging
-    - run_smoke_tests
-    - await_approval
-    - deploy_to_production
-
-  post_deployment:
-    - verify_health_checks
-    - monitor_metrics
-    - notify_completion
-
-  rollback_triggers:
-    - error_rate > 5%
-    - response_time > 2s
-    - health_check_failures > 3
-```
-
-**Example:** `devops/ci-cd/ops-cicd-github.md`
-
----
-
-## 7. Coordinator Agents
-
-**Recommended Format:** METADATA
-
-**Rationale:**
-- Coordination involves structured workflows
-- Multi-agent orchestration requires clear patterns
-- Blocking coordination needs explicit signal handling
-- Balance structure with flexibility for agent management
-
-**Validation Hooks:**
-- `agent-template-validator` (validates SQLite lifecycle, ACL declarations)
-- `cfn-loop-memory-validator` (validates ACL levels for memory operations)
-- `blocking-coordination-validator` (validates HMAC secrets, signal ACK patterns, state machine logic)
-
-**ACL Level:** 3 (Swarm - coordinate multiple agents)
-
-**SQLite Requirements:**
-- Persist coordination signals, agent assignments
-- Store task delegation and progress tracking
-- All coordination state MUST persist for recovery
-
-**Blocking Coordination Requirements:**
-- Import `BlockingCoordinationSignals` and `CoordinatorTimeoutHandler`
-- Use HMAC secret from `process.env.BLOCKING_COORDINATION_SECRET`
-- Implement signal sending and ACK waiting patterns
-- Handle timeout scenarios with graceful degradation
-
-**Core Responsibilities:**
-- Orchestrate multi-agent workflows
-- Manage task delegation and dependencies
-- Handle blocking coordination with signal ACK protocol
-- Monitor agent progress and handle failures
-
-**Example:** Coordinator agents in CFN Loop phases
-
----
-
-## 8. Product Owner Agent (CFN Loop 4 Only)
-
-**Recommended Format:** MINIMAL
-
-**Rationale:**
-- Strategic GOAP decisions require high-level reasoning
-- Must evaluate complex trade-offs
-- Context-sensitive decision making
-- No over-specification to allow flexible analysis
-
-**Validation Hooks:**
-- `agent-template-validator` (validates SQLite lifecycle, ACL declarations)
-- `cfn-loop-memory-validator` (validates ACL levels for memory operations)
-
-**ACL Level:** 4 (Project - strategic decisions)
-
-**SQLite Requirements:**
-- Persist GOAP decisions (PROCEED/DEFER/ESCALATE) with 365 day retention for compliance
-- Store backlog items with appropriate ACL for project access
-- All strategic decisions MUST persist to SQLite for audit trail
-
-**Core Responsibilities:**
-- Make autonomous GOAP decisions after Loop 2 consensus validation
-- Evaluate PROCEED (relaunch Loop 3) vs DEFER (approve, backlog issues) vs ESCALATE (human review)
-- Manage backlog items and prioritization
-- Ensure compliance with retention policies
-
-**Example:** Product Owner agent in CFN Loop 4 decision gate
-
----
-
-## Agent Selection Guide
-
-**Core Development**: coder, tester, reviewer
-**Backend**: backend-dev, api-docs, system-architect
-**Frontend**: coder (specialized), mobile-dev
-**Quality**: tester, reviewer, security-specialist, perf-analyzer
-**Planning**: researcher, planner, architect
-**Coordination**: coordinator (with blocking-coordination-validator)
-**Operations**: devops-engineer, cicd-engineer
-**Documentation**: api-docs, researcher
-**Strategic**: product-owner (CFN Loop 4 only)
-
-**Select agents based on actual task needs, not predefined patterns.**

package/claude-assets/agents/cfn-dev-team/test-agent.md.backup_before_replace

@@ -1,141 +0,0 @@
-# Epic Creator Deletion Issue - Complete Summary
-
-**Date:** 2025-11-03
-**Status:** RESOLVED
-**Versions:** v2.14.5 (epic-creator added), v2.14.6 (init bug fixed)
-
----
-
-## Problem
-
-The `epic-creator.md` coordinator agent kept getting deleted from `.claude/agents/cfn-dev-team/coordinators/` after being created and committed.
-
----
-
-## Root Cause
-
-**Every `npx claude-flow-novice` command triggered `cfn-init`**, which overwrote the entire `.claude/agents/cfn-dev-team/` directory from the npm package.
-
-### Why It Happened
-
-1. `package.json` has `"postinstall": "node scripts/init-project.js"`
-2. Running `npx claude-flow-novice agent backend-dev` triggers postinstall
-3. `init-project.js` ran `cfn-init` unconditionally
-4. cfn-init copied package version of cfn-dev-team/, overwriting local files
-5. epic-creator.md (and other local customizations) got deleted
-
-### Trigger Pattern
-
-```bash
-# Each of these triggered cfn-init:
-npx claude-flow-novice agent backend-dev
-npx claude-flow-novice agent reviewer
-npx claude-flow-novice agent epic-creator
-
-# In test sessions running hundreds of npx commands:
-# = hundreds of cfn-init runs = constant file deletion
-```
-
----
-
-## Solution
-
-### Phase 1: Add epic-creator to Package (v2.14.5)
-
-```bash
-# Copy epic-creator to package assets
-cp .claude/agents/cfn-dev-team/coordinators/epic-creator.md \
-   claude-assets/agents/cfn-dev-team/coordinators/
-
-# Publish to npm
-npm version patch
-npm publish
-```
-
-**Result:** Users can now get epic-creator via normal installation.
-
----
-
-### Phase 2: Fix Init-on-Every-NPX Bug (v2.14.6)
-
-**Changes to `scripts/init-project.js`:**
-
-```javascript
-async function initializeCfnProject() {
-  // Skip initialization if already initialized
-  const markerPath = '.claude/.cfn-initialized';
-  if (fs.existsSync(markerPath)) {
-    // Silently skip - already initialized
-    return;
-  }
-
-  // ... existing init logic ...
-
-  // Create marker file after successful init
-  fs.writeFileSync('.claude/.cfn-initialized', new Date().toISOString());
-}
-```
-
-**How It Works:**
-1. First `npx claude-flow-novice` command → runs full init → creates marker
-2. Subsequent commands → sees marker → skips init → files preserved
-3. Force reinit: `rm .claude/.cfn-initialized && npx cfn-init`
-
----
-
-## Epic Creator Agent
-
-**Purpose:** Transforms natural language epic descriptions into structured JSON configs for CFN Loop execution.
-
-**Three Personas:**
-- **CTO:** Technical architecture, dependencies, risk assessment
-- **Product Owner:** Value prioritization, scope boundaries
-- **Project Manager:** Phase decomposition, deliverables, estimates
-
-**Key Features:**
-- Decomposes epics into 3-7 focused phases
-- Selects appropriate Loop 3/Loop 2 agents per phase
-- Defines concrete deliverables with file paths
-- Sets mode-appropriate thresholds (MVP/Standard/Enterprise)
-- Validates configuration completeness
-
-**Location:** `.claude/agents/cfn-dev-team/coordinators/epic-creator.md` (3.7KB)
-
-**Usage:**
-```bash
-npx claude-flow-novice agent epic-creator \
-  --prompt "Create epic for user authentication system with JWT and OAuth2"
-```
-
----
-
-## Published Versions
-
-**v2.14.5** (Published 2025-11-03)
-- Includes epic-creator in package distribution
-- Users get it automatically on install
-
-**v2.14.6** (Published 2025-11-03)
-- Fixes init-on-every-npx bug
-- Preserves local customizations
-- Faster CLI performance
-
-**Install Latest:**
-```bash
-npm install claude-flow-novice@latest
-npx cfn-init  # Only runs once, creates marker
-```
-
----
-
-## Current Status
-
-**RESOLVED:** Both epic-creator availability and init-on-every-npx bug are fixed.
-
-**Users on v2.14.6+ will:**
-- Get epic-creator automatically
-- Experience fast npx startup
-- Keep local customizations safe
-- Have stable cfn-dev-team directory
-
-**No further action required.**