claude-dev-env 4.3.0 → 7.1.0

package/.agents/skills/review-router/scripts/review_router.py

@@ -1,50 +0,0 @@
-"""Thin route orchestrator for review-tier decisions."""
-
-from __future__ import annotations
-
-import json
-from pathlib import Path
-
-from review_router_constants.config.constants import UNSUPPORTED_ROUTE, UNSUPPORTED_TIER
-
-
-def load_route_policy() -> dict:
-    """Load versioned route policy data.
-
-    Args:
-    Returns:
-        Route policy mapping.
-    Raises:
-        ValueError: If the policy schema is invalid.
-    """
-    policy_path = Path(__file__).parent.parent / "reference" / "route-policy.json"
-    policy = json.loads(policy_path.read_text(encoding="utf-8"))
-    if policy.get("version") != 1 or not isinstance(policy.get("routes"), dict):
-        raise ValueError("malformed route policy")
-    return policy
-
-
-def resolve_route(route: str, tier: str, policy: dict | None = None) -> dict:
-    """Resolve one route or return a stable unsupported result.
-
-    Args:
-        route: Requested route name.
-        tier: Effective tier.
-        policy: Optional route policy.
-    Returns:
-        Dispatch record or unsupported status.
-    """
-    selected_policy = policy or load_route_policy()
-    route_record = selected_policy["routes"].get(route)
-    if route_record is None or route_record["status"] != "SUPPORTED":
-        return {"status": UNSUPPORTED_ROUTE, "route": route, "tier": tier}
-    if tier not in route_record["tiers"]:
-        return {"status": UNSUPPORTED_TIER, "route": route, "tier": tier}
-    dispatch = route_record["models"][tier]
-    return {
-        "status": "SUPPORTED",
-        "route": route,
-        "tier": tier,
-        "skill": route_record["skill"],
-        "dispatch": dispatch,
-    }

package/.agents/skills/review-router/scripts/review_router_cli.py

@@ -1,211 +0,0 @@
-"""CLI for signed review decisions and one-time spawn permits."""
-
-from __future__ import annotations
-
-import argparse
-import hashlib
-import hmac
-import json
-import os
-import shlex
-import secrets
-import sys
-from pathlib import Path
-
-tier_script = Path(__file__).resolve().parents[1].parent / "review-tier" / "scripts"
-if str(tier_script) not in sys.path:
-    sys.path.insert(0, str(tier_script))
-from review_router_constants.config.constants import (  # noqa: E402
-    ALL_OVERRIDE_VALUES,
-    CLEANUP_CONTRACT,
-    DECISION_ID_BYTES,
-    INTEGRITY_KEY_BYTES,
-    INVALID_ROUTE_ARM,
-    INVALID_ROUTE_RECORD,
-    MALFORMED_TIER_OVERRIDE,
-    ROUTE_SPAWN_ARMED,
-    UNKNOWN_ROUTE_SLOT,
-    UNSUPPORTED_ROUTE,
-)
-from review_tier import (  # noqa: E402
-    build_generation,
-    canonical_json_hash,
-    inventory_generation,
-    policy_hash,
-    router_state_directory,
-    router_state_root,
-    router_state_root_id,
-)
-from review_router import load_route_policy, resolve_route  # noqa: E402
-
-
-def _write_signed(directory: Path, name: str, record: dict, secret: bytes) -> None:
-    encoded = _encode_record(record)
-    temporary = directory / f".{name}.tmp"
-    temporary.write_bytes(encoded)
-    temporary.replace(directory / name)
-    (directory / f"{name}.hmac").write_text(hmac.new(secret, encoded, hashlib.sha256).hexdigest(), encoding="ascii")
-
-
-def _read_signed(directory: Path, name: str) -> dict:
-    secret = (directory / "integrity.key").read_bytes()
-    record_path = directory / name
-    encoded = record_path.read_bytes()
-    expected = hmac.new(secret, encoded, hashlib.sha256).hexdigest()
-    if not hmac.compare_digest(expected, (directory / f"{name}.hmac").read_text(encoding="ascii")):
-        raise ValueError(INVALID_ROUTE_RECORD)
-    return json.loads(encoded)
-
-
-def _encode_record(record: dict) -> bytes:
-    return json.dumps(record, sort_keys=True, separators=(",", ":")).encode()
-
-
-def _override(arguments: str) -> str | None:
-    tokens = shlex.split(arguments)
-    matches = [token for token in tokens if token == "--tier" or token.startswith("--tier=")]
-    if len(matches) > 1:
-        raise ValueError(MALFORMED_TIER_OVERRIDE)
-    if not matches:
-        return None
-    if matches[0] == "--tier":
-        index = tokens.index("--tier")
-        if index + 1 >= len(tokens) or tokens[index + 1] not in ALL_OVERRIDE_VALUES:
-            raise ValueError(MALFORMED_TIER_OVERRIDE)
-        return f"T{tokens[index + 1]}"
-    override = matches[0].split("=", 1)[1]
-    if override not in ALL_OVERRIDE_VALUES:
-        raise ValueError(MALFORMED_TIER_OVERRIDE)
-    return f"T{override}"
-
-
-def resolve(cwd: str, review_kind: str, arguments: str, base_ref: str | None) -> dict:
-    """Create a signed review decision.
-
-    Args:
-        cwd: Repository path.
-        review_kind: Requested review route.
-        arguments: Review command arguments.
-        base_ref: Optional base reference.
-    Returns:
-        Decision summary.
-    Raises:
-        ValueError: If the override or base reference is invalid.
-    """
-    route_policy = load_route_policy()
-    route_record = route_policy["routes"].get(review_kind)
-    if route_record is None or route_record.get("status") != "SUPPORTED":
-        return {"status": UNSUPPORTED_ROUTE}
-    override = _override(arguments)
-    directory = router_state_directory(cwd)
-    if (directory / "armed-spawn.json").exists():
-        raise ValueError(ROUTE_SPAWN_ARMED)
-    directory.mkdir(parents=True, exist_ok=True)
-    key_path = directory / "integrity.key"
-    if not key_path.exists():
-        key_path.write_bytes(secrets.token_bytes(INTEGRITY_KEY_BYTES))
-    secret = key_path.read_bytes()
-    state_root = router_state_root(cwd)
-    generation = build_generation(cwd, requested_override=override, base_ref=base_ref, state_root=state_root)
-    route = resolve_route(review_kind, generation["effective_tier"], route_policy)
-    decision_id = secrets.token_hex(DECISION_ID_BYTES)
-    dispatch = route["dispatch"]
-    slots = [{"slot_id": each_slot_id, "model": dispatch["model"], "effort": dispatch["effort"]} for each_slot_id in dispatch["pass_ids"]]
-    decision = {**generation, "decision_id": decision_id, "review_kind": review_kind, "route_policy_hash": policy_hash(route_policy), "state_root_id": router_state_root_id(state_root), "slots": slots}
-    _write_signed(directory, "decision.json", decision, secret)
-    return {"status": "SUPPORTED", "decision_id": decision_id, "effective_tier": decision["effective_tier"], "automatic_tier": decision["calculated_tier"], "slot_ids": [slot["slot_id"] for slot in slots]}
-
-
-def arm(cwd: str, decision_id: str, slot_id: str) -> dict:
-    """Create a one-time spawn permit.
-
-    Args:
-        cwd: Repository path.
-        decision_id: Decision identifier.
-        slot_id: Selected dispatch slot.
-    Returns:
-        Agent tool payload.
-    Raises:
-        OSError: If signed state is unavailable.
-        ValueError: If the decision or slot is invalid.
-    """
-    directory = router_state_directory(cwd)
-    secret = (directory / "integrity.key").read_bytes()
-    decision = _read_signed(directory, "decision.json")
-    if decision["decision_id"] != decision_id or (directory / "armed-spawn.json").exists():
-        raise ValueError(INVALID_ROUTE_ARM)
-    consumed_prefix = f"{decision_id}--{slot_id}"
-    if any(path.name.startswith(consumed_prefix) for path in (directory / "consumed").glob(f"{consumed_prefix}*")):
-        raise ValueError(INVALID_ROUTE_ARM)
-    slot = next((each_slot for each_slot in decision["slots"] if each_slot["slot_id"] == slot_id), None)
-    if slot is None:
-        raise ValueError(UNKNOWN_ROUTE_SLOT)
-    consumed_slots = {path.name.split("--", 1)[1].split(".", 1)[0] for path in (directory / "consumed").glob(f"{decision_id}--*.json")}
-    expected_slots = [each_slot["slot_id"] for each_slot in decision["slots"] if each_slot["slot_id"] not in consumed_slots]
-    if expected_slots and slot_id != expected_slots[0]:
-        raise ValueError(INVALID_ROUTE_ARM)
-    decision_base = decision.get("base_ref") if decision.get("base_source") == "explicit" else None
-    state_root = router_state_root(cwd)
-    current_hash = str(inventory_generation(cwd, decision_base, state_root=state_root)["diff_hash"])
-    if current_hash != decision["diff_hash"]:
-        raise ValueError(INVALID_ROUTE_ARM)
-    prompt = f"{CLEANUP_CONTRACT} Review {decision['review_kind']} for {decision['worktree']}. Angles: Reuse, Simplification, Efficiency, Altitude. Apply direct fixes within scope. Skip correctness, security, behavior-changing, and out-of-scope findings. Decision {decision_id}; slot {slot_id}."
-    spawn = {"decision_id": decision_id, "decision_hash": canonical_json_hash(decision), "state_root_id": router_state_root_id(state_root), "slot_id": slot_id, "tool_name": "Agent", "executor_type": "Luna", "model": slot["model"], "effort": slot["effort"], "prompt": prompt, "prompt_hash": hashlib.sha256(prompt.encode()).hexdigest(), "diff_hash": decision["diff_hash"]}
-    _write_signed(directory, "armed-spawn.json", spawn, secret)
-    return {"tool_name": "Agent", "tool_input": {"executor_type": "Luna", "model": spawn["model"], "effort": spawn["effort"], "prompt": prompt}}
-
-
-def close(cwd: str, decision_id: str) -> dict:
-    """Close a decision after its permit is consumed.
-
-    Args:
-        cwd: Repository path.
-        decision_id: Decision identifier.
-    Returns:
-        Closure summary.
-    Raises:
-        OSError: If signed state is unavailable.
-        ValueError: If the decision is invalid or still armed.
-    """
-    directory = router_state_directory(cwd)
-    decision = _read_signed(directory, "decision.json")
-    if decision["decision_id"] != decision_id or (directory / "armed-spawn.json").exists():
-        raise ValueError(ROUTE_SPAWN_ARMED)
-    (directory / "decision.json").unlink()
-    (directory / "decision.json.hmac").unlink()
-    return {"status": "CLOSED", "decision_id": decision_id}
-
-
-def main() -> int:
-    """Run the review-routing command line interface.
-
-    Returns:
-        Process exit status.
-    """
-    parser = argparse.ArgumentParser()
-    parser.add_argument("command", choices=("resolve", "arm", "close"))
-    parser.add_argument("--review-kind", default="e-simplify")
-    parser.add_argument("--cwd", default=os.getcwd())
-    parser.add_argument("--arguments", default="")
-    parser.add_argument("--base-ref")
-    parser.add_argument("--decision-id")
-    parser.add_argument("--slot")
-    parser.add_argument("--requested", action="store_true")
-    options = parser.parse_args()
-    if options.requested:
-        parser.error("--requested is not supported")
-    try:
-        if options.command == "resolve":
-            dispatch_record = resolve(options.cwd, options.review_kind, options.arguments, base_ref=options.base_ref)
-        elif options.command == "arm":
-            dispatch_record = arm(options.cwd, options.decision_id, options.slot)
-        else:
-            dispatch_record = close(options.cwd, options.decision_id)
-    except (OSError, ValueError) as error:
-        parser.error(str(error))
-    print(json.dumps(dispatch_record, sort_keys=True))
-    return 0
-
-
-if __name__ == "__main__":
-    raise SystemExit(main())

package/.agents/skills/review-router/scripts/review_router_constants/__init__.py

@@ -1 +0,0 @@
-"""Review-router constants package."""

package/.agents/skills/review-router/scripts/review_router_constants/config/constants.py

@@ -1,13 +0,0 @@
-"""Constants for route_review_config."""
-
-UNSUPPORTED_ROUTE = "UNSUPPORTED_ROUTE"
-UNSUPPORTED_TIER = "UNSUPPORTED_TIER"
-INVALID_ROUTE_RECORD = "INVALID_ROUTE_RECORD"
-MALFORMED_TIER_OVERRIDE = "MALFORMED_TIER_OVERRIDE"
-INVALID_ROUTE_ARM = "INVALID_ROUTE_ARM"
-UNKNOWN_ROUTE_SLOT = "UNKNOWN_ROUTE_SLOT"
-ROUTE_SPAWN_ARMED = "ROUTE_SPAWN_ARMED"
-ALL_OVERRIDE_VALUES = ("1", "2", "3")
-INTEGRITY_KEY_BYTES = 32
-DECISION_ID_BYTES = 16
-CLEANUP_CONTRACT = """This is a cleanup-only review of the current diff, not a correctness or security bug hunt. Gather the diff and include uncommitted changes. Review reuse, simplification, efficiency, and altitude. Reuse existing helpers and adjacent patterns. Simplify redundant state, copy-paste, nesting, dead code, and unnecessary complexity. Remove redundant computation, repeated I/O, sequential independent work, and long-lived captured objects. Fix each issue at the owning abstraction and preserve the intended behavior. Apply safe fixes directly within the reviewed diff. Each finding has file, line, summary, and concrete cost. Skip findings whose fix changes intended behavior, reaches outside the diff, or belongs to correctness review. Respond exactly: That's a correctness review — use /e-code-review, not this skill. Finish with what was fixed and what was skipped."""

package/.agents/skills/review-router/scripts/test_review_router.py

@@ -1,23 +0,0 @@
-from review_router import load_route_policy, resolve_route
-
-
-def test_load_route_policy_returns_versioned_policy() -> None:
-    assert load_route_policy()["version"] == 1
-
-
-def test_e_simplify_route_and_unsupported_e_code_review() -> None:
-    assert resolve_route("e-simplify", "T1")["status"] == "SUPPORTED"
-    assert resolve_route("e-code-review", "T1")["status"] == "UNSUPPORTED_ROUTE"
-
-
-def test_route_has_only_current_dispatch_fields() -> None:
-    route_result = resolve_route("e-simplify", "T1")
-    assert route_result["dispatch"]["pass_ids"] == ["simplify-01"]
-    assert "advisor" not in route_result
-    assert "same_executor_redirect" not in route_result
-
-
-def test_t3_has_six_ordered_slots() -> None:
-    assert resolve_route("e-simplify", "T3")["dispatch"]["pass_ids"] == [
-        "simplify-01", "simplify-02", "simplify-03", "simplify-04", "simplify-05", "simplify-06"
-    ]

package/.agents/skills/review-router/scripts/test_review_router_cli.py

@@ -1,47 +0,0 @@
-"""CLI production-path acceptance tests."""
-
-from __future__ import annotations
-
-import os
-import subprocess
-import sys
-from pathlib import Path
-import pytest
-
-from review_router_cli import arm, close, resolve
-from review_router_constants.config.constants import UNSUPPORTED_ROUTE
-
-CLI = Path(__file__).with_name("review_router_cli.py")
-
-
-def test_public_arm_and_close_reject_missing_signed_state(tmp_path: Path) -> None:
-    with pytest.raises(OSError):
-        arm(str(tmp_path), "missing", "slot")
-    with pytest.raises(OSError):
-        close(str(tmp_path), "missing")
-
-
-def test_resolve_returns_unsupported_for_unknown_route(tmp_path: Path) -> None:
-    resolve_response = resolve(str(tmp_path), "unknown-route", "", None)
-    assert resolve_response["status"] == UNSUPPORTED_ROUTE
-
-
-def test_cli_rejects_requested_dispatch(tmp_path: Path) -> None:
-    command_result = subprocess.run(
-        [sys.executable, str(CLI), "next", "--cwd", str(tmp_path)],
-        capture_output=True,
-        text=True,
-    )
-    assert command_result.returncode != 0
-    assert "invalid choice" in command_result.stderr
-
-
-@pytest.mark.parametrize("arguments", ["--tier 4", "--tier", "--tier x", "--tier 1 --tier 2"])
-def test_malformed_tier_override_writes_no_artifacts(tmp_path: Path, arguments: str) -> None:
-    repository = tmp_path / "repository"
-    repository.mkdir()
-    subprocess.run(["git", "init", "-q"], cwd=repository, check=True)
-    environment = {**os.environ, "CLAUDE_PLUGIN_DATA": str(tmp_path / "data")}
-    command_result = subprocess.run([sys.executable, str(CLI), "resolve", "--cwd", str(repository), "--arguments", arguments], capture_output=True, text=True, env=environment)
-    assert command_result.returncode != 0
-    assert not (tmp_path / "data").exists()

package/.agents/skills/review-tier/SKILL.md

@@ -1,56 +0,0 @@
----
-name: review-tier
-description: >-
-  Classify `review_tier_constants` from change axes, hard triggers, and user overrides. Triggers: /review-tier, tier override, and review classification.
----
-
-# Review Tier
-
-Classify one current change surface into T1, T2, or T3 using `reference/tier-policy.json` and `scripts/review_tier.py`.
-
-## Composition
-
-| Skill | When | Produces |
-|---|---|---|
-| `/review-router` | After classification | Current decision route and guarded execution |
-| `/task-build` | At workflow start | Registered classification tasks |
-
-If `/review-router` is unavailable, return the current classification.
-
-## When this applies
-
-Use for `/review-tier` and automatic review classification. Refuse execution requests with: `This is a route execution request — use /review-router.` Refuse malformed policy with: `The review-tier policy is invalid; repair the policy before classification.`
-
-## Process
-
-1. Register `reference/task-seeds.md` with the host task tool.
-2. Run `scripts/review_tier.py` and record the current decision fields.
-3. Hand the current decision to `/review-router` when route execution is requested.
-
-## Examples
-
-Input `{"packages": 0, "risk": 0}` produces `T1`. Input `{"hard_triggers": ["migration"]}` produces `T3`. An empty input with override `T2` produces calculated `T1` and effective `T2`.
-
-## Dependencies
-
-Requires Python 3.11+ and the standard library only. Treat a non-zero script exit as a failed classification.
-
-## File index
-
-| File | Purpose |
-|---|---|
-| `SKILL.md` | Classification workflow and boundaries |
-| `reference/tier-policy.json` | Versioned axes, thresholds, and hard triggers |
-| `reference/task-seeds.md` | Ordered classification tasks |
-| `scripts/review_tier.py` | Deterministic classifier |
-| `scripts/test_review_tier.py` | Classifier behavior tests |
-| `scripts/test_generation.py` | Inventory generation tests |
-| `scripts/conftest.py` | Test import setup |
-| `scripts/review_tier_constants/__init__.py` | Constants package |
-| `scripts/review_tier_constants/config/__init__.py` | Runtime configuration package |
-| `scripts/review_tier_constants/config/constants.py` | Portable tier constants |
-
-## Folder map
-
-- `reference/` — policy and task data.
-- `scripts/` — executable classifier and paired tests.

package/.agents/skills/review-tier/reference/task-seeds.md

@@ -1 +0,0 @@
-Register classification inputs, policy validation, tier selection, and override resolution as host tasks. Complete each with command output or the current decision.

package/.agents/skills/review-tier/reference/tier-policy.json

@@ -1,9 +0,0 @@
-{
-  "version": 1,
-  "tiers": ["T1", "T2", "T3"],
-  "thresholds": {"T1": 0, "T2": 2, "T3": 5},
-  "hard_triggers": ["security", "migration", "public-api", "release"],
-  "axes": ["packages", "risk", "public_api", "dependencies"],
-  "axis_weights": {"packages": 2, "risk": 2, "public_api": 2, "dependencies": 1},
-  "approved_downgrades": ["T1", "T2"]
-}

package/.agents/skills/review-tier/scripts/conftest.py

@@ -1,4 +0,0 @@
-from pathlib import Path
-import sys
-
-sys.path.insert(0, str(Path(__file__).resolve().parent))