claude-dev-env 4.3.0 → 7.1.0

package/hooks/hooks_constants/pre_tool_use_dispatcher_constants.py

@@ -1,8 +1,9 @@
 """Constants for the PreToolUse dispatcher that hosts Write/Edit/MultiEdit hooks.
 
-Holds the ordered hosted-hook list with per-hook applicable-tool sets, the
-special exit codes, the deny decision string, and the hook-event name. The
-dispatcher imports each of these by name.
+The roster keeps action-boundary checks, repository checks, and checks without
+a proven local replacement. File-policy rules with a staged replacement run
+through cde lint in native pre-commit. Their detectors stay importable for that
+linter. Bash cleanup protection uses its own roster.
 """
 
 from __future__ import annotations
@@ -25,7 +26,6 @@ __all__ = [
     "ALL_WRITE_AND_EDIT_TOOL_NAMES",
     "ALL_WRITE_EDIT_MULTI_EDIT_TOOL_NAMES",
     "ALL_WRITE_EDIT_MULTI_EDIT_APPLY_PATCH_TOOL_NAMES",
-    "ALL_IMMEDIATE_HARM_SCRIPT_PATHS",
     "STATE_DESCRIPTION_BLOCKER_MODULE_NAME",
     "SYSTEM_MESSAGE_JOIN_SEPARATOR",
     "HostedHookEntry",
@@ -55,15 +55,6 @@ ALL_WRITE_EDIT_MULTI_EDIT_APPLY_PATCH_TOOL_NAMES: frozenset[str] = frozenset(
     ALL_WRITE_EDIT_MULTI_EDIT_TOOL_NAMES | {APPLY_PATCH_TOOL_NAME}
 )
 
-# apply_patch reaches this narrower roster: the gates whose miss causes immediate
-# harm, plus the TDD gate and the edit tracker. It stays off the full lint surface.
-ALL_IMMEDIATE_HARM_SCRIPT_PATHS: tuple[str, ...] = (
-    "blocking/pii_prevention_blocker.py",
-    "blocking/sensitive_file_protector.py",
-    "blocking/write_existing_file_blocker.py",
-    "blocking/code_rules_enforcer.py",
-    "blocking/tdd_enforcer.py",
-)
 
 
 STATE_DESCRIPTION_BLOCKER_MODULE_NAME = "state_description_blocker"
@@ -71,19 +62,18 @@ STATE_DESCRIPTION_BLOCKER_MODULE_NAME = "state_description_blocker"
 
 @dataclass(frozen=True)
 class HostedHookEntry:
-    """A single hosted hook with its applicable-tools constraint and blocking flag.
+    """One hosted hook, the tools it applies to, and whether a crash blocks.
 
     Attributes:
         script_relative_path: Hook path relative to the hooks/ directory.
         applicable_tool_names: Tool names this hook applies to. The dispatcher
             skips the hook when the payload's tool is not in this set.
-        is_blocking: True when a crash surfaces a blocking signal; False when the
+        is_blocking: True when a crash is a blocking signal. False when the
             hook is advisory and a crash stays silent.
-        native_module_name: The importable module name whose evaluate function
-            the dispatcher calls in-process for this hook, or None when the hook
-            runs via runpy under __main__. The named module exposes a function
-            named `evaluate` taking the payload dict and returning a deny-reason
-            string or None.
+        native_module_name: Importable module whose evaluate function the
+            dispatcher calls in-process, or None when the hook runs via runpy
+            under __main__. evaluate takes the payload dict and returns a
+            deny-reason string or None.
     """
 
     script_relative_path: str
@@ -93,79 +83,6 @@ class HostedHookEntry:
 
 
 ALL_HOSTED_HOOK_ENTRIES: tuple[HostedHookEntry, ...] = (
-    HostedHookEntry(
-        script_relative_path="blocking/write_existing_file_blocker.py",
-        applicable_tool_names=ALL_WRITE_EDIT_MULTI_EDIT_APPLY_PATCH_TOOL_NAMES,
-    ),
-    HostedHookEntry(
-        script_relative_path="blocking/sensitive_file_protector.py",
-        applicable_tool_names=ALL_WRITE_EDIT_MULTI_EDIT_APPLY_PATCH_TOOL_NAMES,
-    ),
-    HostedHookEntry(
-        script_relative_path="blocking/pii_prevention_blocker.py",
-        applicable_tool_names=ALL_WRITE_EDIT_MULTI_EDIT_APPLY_PATCH_TOOL_NAMES,
-    ),
-    HostedHookEntry(
-        script_relative_path="validation/hook_format_validator.py",
-        applicable_tool_names=ALL_WRITE_EDIT_MULTI_EDIT_TOOL_NAMES,
-    ),
-    HostedHookEntry(
-        script_relative_path="blocking/code_rules_enforcer.py",
-        applicable_tool_names=ALL_WRITE_EDIT_MULTI_EDIT_APPLY_PATCH_TOOL_NAMES,
-    ),
-    HostedHookEntry(
-        script_relative_path="blocking/tdd_enforcer.py",
-        applicable_tool_names=ALL_WRITE_EDIT_MULTI_EDIT_APPLY_PATCH_TOOL_NAMES,
-    ),
-    HostedHookEntry(
-        script_relative_path="blocking/windows_rmtree_blocker.py",
-        applicable_tool_names=ALL_WRITE_EDIT_MULTI_EDIT_TOOL_NAMES,
-    ),
-    HostedHookEntry(
-        script_relative_path="blocking/duplicate_rmtree_helper_blocker.py",
-        applicable_tool_names=ALL_WRITE_EDIT_MULTI_EDIT_TOOL_NAMES,
-    ),
-    HostedHookEntry(
-        script_relative_path="blocking/state_description_blocker.py",
-        applicable_tool_names=ALL_WRITE_EDIT_MULTI_EDIT_TOOL_NAMES,
-        native_module_name=STATE_DESCRIPTION_BLOCKER_MODULE_NAME,
-    ),
-    HostedHookEntry(
-        script_relative_path="blocking/subprocess_budget_completeness.py",
-        applicable_tool_names=ALL_WRITE_EDIT_MULTI_EDIT_TOOL_NAMES,
-    ),
-    HostedHookEntry(
-        script_relative_path="blocking/hook_prose_detector_consistency.py",
-        applicable_tool_names=ALL_WRITE_EDIT_MULTI_EDIT_TOOL_NAMES,
-    ),
-    HostedHookEntry(
-        script_relative_path="blocking/workflow_substitution_slot_blocker.py",
-        applicable_tool_names=ALL_WRITE_EDIT_MULTI_EDIT_TOOL_NAMES,
-    ),
-    HostedHookEntry(
-        script_relative_path="blocking/claude_md_orphan_file_blocker.py",
-        applicable_tool_names=ALL_WRITE_EDIT_MULTI_EDIT_TOOL_NAMES,
-    ),
-    HostedHookEntry(
-        script_relative_path="blocking/package_inventory_stale_blocker.py",
-        applicable_tool_names=ALL_WRITE_EDIT_MULTI_EDIT_TOOL_NAMES,
-    ),
-    HostedHookEntry(
-        script_relative_path="blocking/env_var_table_code_drift_blocker.py",
-        applicable_tool_names=ALL_WRITE_EDIT_MULTI_EDIT_TOOL_NAMES,
-    ),
-    HostedHookEntry(
-        script_relative_path="blocking/pytest_testpaths_orphan_blocker.py",
-        applicable_tool_names=ALL_WRITE_EDIT_MULTI_EDIT_TOOL_NAMES,
-    ),
-    HostedHookEntry(
-        script_relative_path="blocking/open_questions_in_plans_blocker.py",
-        applicable_tool_names=ALL_WRITE_EDIT_MULTI_EDIT_TOOL_NAMES,
-    ),
-    HostedHookEntry(
-        script_relative_path="blocking/docstring_rule_gate_count_blocker.py",
-        applicable_tool_names=ALL_WRITE_EDIT_MULTI_EDIT_TOOL_NAMES,
-    ),
     HostedHookEntry(
         script_relative_path="advisory/refactor_guard.py",
         applicable_tool_names=frozenset({EDIT_TOOL_NAME, MULTI_EDIT_TOOL_NAME}),

package/hooks/hooks_constants/stop_dispatcher_constants.py

@@ -17,7 +17,4 @@ BLOCK_DECISION = "block"
 DECISION_KEY = "decision"
 REASON_KEY = "reason"
 
-ALL_STOP_HOSTED_HOOK_PATHS: tuple[str, ...] = (
-    "blocking/question_to_user_enforcer.py",
-    "blocking/session_handoff_blocker.py",
-)
+ALL_STOP_HOSTED_HOOK_PATHS: tuple[str, ...] = ()

package/hooks/hooks_constants/test_bash_post_call_dispatcher_constants.py

@@ -1,16 +1,33 @@
 """Behavioral tests for the Bash PostToolUse dispatcher's hosted-hook roster."""
 
+from hooks_constants import bash_post_call_dispatcher_constants as constants
 from hooks_constants.bash_post_call_dispatcher_constants import (
     ALL_BASH_POST_TOOL_USE_HOSTED_HOOK_ENTRIES,
 )
 from hooks_constants.bash_pre_tool_use_dispatcher_constants import BASH_TOOL_NAME
 
 
-def test_roster_names_the_test_failure_recorder_hook() -> None:
+def test_roster_runs_the_recorder_then_the_pr_done_reminder() -> None:
     all_script_paths = [
         each_entry.script_relative_path for each_entry in ALL_BASH_POST_TOOL_USE_HOSTED_HOOK_ENTRIES
     ]
-    assert "observability/test_failure_recorder.py" in all_script_paths
+    assert all_script_paths == [
+        "observability/test_failure_recorder.py",
+        "advisory/pr_done_reminder.py",
+    ]
+
+
+def test_pr_done_reminder_also_serves_the_powershell_tool() -> None:
+    reminder_entry = ALL_BASH_POST_TOOL_USE_HOSTED_HOOK_ENTRIES[-1]
+    assert reminder_entry.script_relative_path == "advisory/pr_done_reminder.py"
+    assert "PowerShell" in reminder_entry.applicable_tool_names
+
+
+def test_context_forwarding_keys_match_the_hook_output_contract() -> None:
+    assert constants.POST_TOOL_USE_HOOK_EVENT_NAME == "PostToolUse"
+    assert constants.HOOK_SPECIFIC_OUTPUT_KEY == "hookSpecificOutput"
+    assert constants.ADDITIONAL_CONTEXT_KEY == "additionalContext"
+    assert constants.ADDITIONAL_CONTEXT_JOIN_SEPARATOR == "\n\n"
 
 
 def test_every_roster_entry_applies_to_bash() -> None:

package/hooks/hooks_constants/test_bash_pre_tool_use_dispatcher_constants.py

@@ -1,11 +1,4 @@
-"""Tests for the Bash and PowerShell dispatcher hosted-hook roster.
-
-The roster order and per-hook applicable-tool sets fix the firing sequence and
-tool coverage the dispatcher must reproduce, so these tests pin both against the
-registration order the standalone chain used.
-"""
-
-from __future__ import annotations
+"""Tests for the Bash and PowerShell dispatcher hosted-hook roster."""
 
 from pathlib import Path
 from runpy import run_path
@@ -13,64 +6,8 @@ from runpy import run_path
 ALL_CONSTANT_BINDINGS = run_path(
     str(Path(__file__).with_name("bash_pre_tool_use_dispatcher_constants.py"))
 )
-ALL_BASH_AND_POWERSHELL_TOOL_NAMES = ALL_CONSTANT_BINDINGS["ALL_BASH_AND_POWERSHELL_TOOL_NAMES"]
 ALL_BASH_HOSTED_HOOK_ENTRIES = ALL_CONSTANT_BINDINGS["ALL_BASH_HOSTED_HOOK_ENTRIES"]
-BASH_TOOL_NAME = ALL_CONSTANT_BINDINGS["BASH_TOOL_NAME"]
-POWERSHELL_TOOL_NAME = ALL_CONSTANT_BINDINGS["POWERSHELL_TOOL_NAME"]
-
-_EXPECTED_BASH_ORDER = (
-    "blocking/destructive_command_blocker.py",
-    "blocking/shell_substitution_blocker.py",
-    "blocking/piped_pytest_blocker.py",
-    "blocking/cursor_cli_python_misfire_blocker.py",
-    "blocking/unscoped_search_blocker.py",
-    "blocking/nas_ssh_binary_enforcer.py",
-    "blocking/pii_prevention_blocker.py",
-    "blocking/block_main_commit.py",
-    "blocking/session_edit_stage_gate.py",
-    "blocking/windows_rmtree_blocker.py",
-)
-
-_POWERSHELL_APPLICABLE = (
-    "blocking/cursor_cli_python_misfire_blocker.py",
-    "blocking/unscoped_search_blocker.py",
-    "blocking/pii_prevention_blocker.py",
-)
-
-
-def test_roster_lists_all_bash_hooks_in_registration_order() -> None:
-    """The roster reproduces the standalone Bash chain order exactly."""
-    actual_order = tuple(
-        each_entry.script_relative_path for each_entry in ALL_BASH_HOSTED_HOOK_ENTRIES
-    )
-    assert actual_order == _EXPECTED_BASH_ORDER
-
-
-def test_every_hook_applies_to_the_bash_tool() -> None:
-    """Every hosted hook runs on a Bash tool call."""
-    for each_entry in ALL_BASH_HOSTED_HOOK_ENTRIES:
-        assert BASH_TOOL_NAME in each_entry.applicable_tool_names
-
-
-def test_powershell_applicable_hooks_include_the_shared_gates() -> None:
-    """PowerShell runs the shared unscoped-search and PII gates."""
-    powershell_hooks = tuple(
-        each_entry.script_relative_path
-        for each_entry in ALL_BASH_HOSTED_HOOK_ENTRIES
-        if POWERSHELL_TOOL_NAME in each_entry.applicable_tool_names
-    )
-    assert powershell_hooks == _POWERSHELL_APPLICABLE
-
-
-def test_powershell_hooks_carry_the_shared_tool_set() -> None:
-    """The PowerShell-applicable hooks name both Bash and PowerShell."""
-    for each_entry in ALL_BASH_HOSTED_HOOK_ENTRIES:
-        if each_entry.script_relative_path in _POWERSHELL_APPLICABLE:
-            assert each_entry.applicable_tool_names == ALL_BASH_AND_POWERSHELL_TOOL_NAMES
 
 
-def test_every_roster_path_points_at_an_existing_hook() -> None:
-    """Each roster path names a hook script present on disk, catching a typo."""
-    hooks_root = Path(__file__).resolve().parent.parent
-    for each_entry in ALL_BASH_HOSTED_HOOK_ENTRIES:
-        assert (hooks_root / each_entry.script_relative_path).is_file()
+def test_roster_has_no_blocking_hooks() -> None:
+    assert ALL_BASH_HOSTED_HOOK_ENTRIES == ()

package/hooks/hooks_constants/test_pr_done_reminder_constants.py

@@ -0,0 +1,40 @@
+"""Pin the PR done reminder's command shape and checklist wording."""
+
+from __future__ import annotations
+
+from hooks_constants import pr_done_reminder_constants as constants
+
+
+def test_gh_probe_asks_for_every_field_the_checklist_reads() -> None:
+    assert constants.ALL_GH_PR_VIEW_ARGUMENTS[:3] == ("gh", "pr", "view")
+    all_requested_fields = constants.ALL_GH_PR_VIEW_ARGUMENTS[-1].split(",")
+    for each_field in ("number", "url", "isDraft", "mergeable", "statusCheckRollup", "labels"):
+        assert each_field in all_requested_fields
+
+
+def test_git_global_options_that_take_a_value_are_named() -> None:
+    assert constants.ALL_GIT_OPTIONS_WITH_VALUE == frozenset({"-C", "-c"})
+
+
+def test_powershell_wrappers_and_their_command_flags_are_named() -> None:
+    assert "pwsh" in constants.ALL_POWERSHELL_PROGRAM_NAMES
+    assert "powershell" in constants.ALL_POWERSHELL_PROGRAM_NAMES
+    assert "-command" in constants.ALL_POWERSHELL_COMMAND_FLAGS
+    assert "-c" in constants.ALL_POWERSHELL_COMMAND_FLAGS
+
+
+def test_checklist_lines_join_on_a_single_newline() -> None:
+    assert constants.REMINDER_LINE_SEPARATOR == "\n"
+
+
+def test_every_mergeable_value_has_a_hint() -> None:
+    assert set(constants.ALL_REMINDER_HINTS_BY_MERGEABLE) == {
+        constants.MERGEABLE_CLEAN_VALUE,
+        constants.MERGEABLE_CONFLICTING_VALUE,
+        constants.MERGEABLE_UNKNOWN_VALUE,
+    }
+
+
+def test_header_says_it_never_blocks() -> None:
+    assert "never a block" in constants.REMINDER_HEADER
+    assert "never a block" in constants.NO_PULL_REQUEST_REMINDER

package/hooks/hooks_constants/test_pre_tool_use_dispatcher_constants.py

@@ -4,36 +4,24 @@ import importlib
 import pathlib
 import sys
 
-try:
-    _HOOKS_ROOT = pathlib.Path(__file__).resolve().parent.parent
-    if str(_HOOKS_ROOT) not in sys.path:
-        sys.path.insert(0, str(_HOOKS_ROOT))
-
-    _BLOCKING_DIR = _HOOKS_ROOT / "blocking"
-    if str(_BLOCKING_DIR) not in sys.path:
-        sys.path.insert(0, str(_BLOCKING_DIR))
-
-    from hooks_constants.pre_tool_use_dispatcher_constants import (
-        ALL_HOSTED_HOOK_ENTRIES,
-        ALL_IMMEDIATE_HARM_SCRIPT_PATHS,
-        ALL_WRITE_AND_EDIT_TOOL_NAMES,
-        ALL_WRITE_EDIT_MULTI_EDIT_APPLY_PATCH_TOOL_NAMES,
-        ALL_WRITE_EDIT_MULTI_EDIT_TOOL_NAMES,
-        APPLY_PATCH_TOOL_NAME,
-        BLOCKING_CRASH_DENY_REASON,
-        EDIT_TOOL_NAME,
-        MULTI_EDIT_TOOL_NAME,
-        WRITE_TOOL_NAME,
-    )
-    from pre_tool_use_dispatcher import (
-        HostedHookResult,
-        aggregate_hosted_hook_results,
-    )
-except ImportError as import_error:
-    raise ImportError(
-        "test_pre_tool_use_dispatcher_constants: cannot import its sibling modules; "
-        "ensure the hooks and blocking directories are importable."
-    ) from import_error
+_HOOKS_ROOT = pathlib.Path(__file__).resolve().parent.parent
+if str(_HOOKS_ROOT) not in sys.path:
+    sys.path.insert(0, str(_HOOKS_ROOT))
+
+_BLOCKING_DIR = _HOOKS_ROOT / "blocking"
+if str(_BLOCKING_DIR) not in sys.path:
+    sys.path.insert(0, str(_BLOCKING_DIR))
+
+from hooks_constants.pre_tool_use_dispatcher_constants import (
+    ALL_HOSTED_HOOK_ENTRIES,
+    ALL_WRITE_EDIT_MULTI_EDIT_APPLY_PATCH_TOOL_NAMES,
+    ALL_WRITE_EDIT_MULTI_EDIT_TOOL_NAMES,
+    APPLY_PATCH_TOOL_NAME,
+    BLOCKING_CRASH_DENY_REASON,
+    EDIT_TOOL_NAME,
+    MULTI_EDIT_TOOL_NAME,
+)
+from pre_tool_use_dispatcher import HostedHookResult, aggregate_hosted_hook_results
 
 
 def _entry_for(script_relative_path: str):
@@ -45,39 +33,44 @@ def _entry_for(script_relative_path: str):
     return matching_entries[0] if matching_entries else None
 
 
-def test_roster_includes_duplicate_rmtree_helper_blocker_script_path() -> None:
-    all_registered_script_paths = [
+def test_roster_keeps_only_nonblocking_edit_advisors() -> None:
+    all_script_paths = tuple(
         each_entry.script_relative_path for each_entry in ALL_HOSTED_HOOK_ENTRIES
-    ]
-    assert "blocking/duplicate_rmtree_helper_blocker.py" in all_registered_script_paths, (
-        "duplicate_rmtree_helper_blocker must be hosted by the dispatcher so a local "
-        "re-definition of the Windows-safe rmtree helper trio is blocked at Write time"
     )
+    assert all_script_paths == (
+        "advisory/refactor_guard.py",
+        "advisory/migration_safety_advisor.py",
+    )
+    assert all(not each_entry.is_blocking for each_entry in ALL_HOSTED_HOOK_ENTRIES)
 
 
-def test_duplicate_rmtree_helper_blocker_applies_to_write_and_edit() -> None:
-    entry = _entry_for("blocking/duplicate_rmtree_helper_blocker.py")
-    assert entry is not None
-    assert WRITE_TOOL_NAME in entry.applicable_tool_names
-    assert EDIT_TOOL_NAME in entry.applicable_tool_names
+def test_advisors_apply_to_edit_and_multi_edit() -> None:
+    for each_script_path in (
+        "advisory/refactor_guard.py",
+        "advisory/migration_safety_advisor.py",
+    ):
+        entry = _entry_for(each_script_path)
+        assert entry is not None
+        assert entry.applicable_tool_names == frozenset({EDIT_TOOL_NAME, MULTI_EDIT_TOOL_NAME})
 
 
-def test_duplicate_rmtree_helper_blocker_is_blocking() -> None:
-    entry = _entry_for("blocking/duplicate_rmtree_helper_blocker.py")
-    assert entry is not None
-    assert entry.is_blocking is True
+def test_every_hosted_script_path_exists_under_the_hooks_root() -> None:
+    for each_entry in ALL_HOSTED_HOOK_ENTRIES:
+        hosted_script_path = _HOOKS_ROOT / each_entry.script_relative_path
+        assert hosted_script_path.is_file()
 
 
-def test_duplicate_rmtree_helper_blocker_runs_via_runpy() -> None:
-    entry = _entry_for("blocking/duplicate_rmtree_helper_blocker.py")
-    assert entry is not None
-    assert entry.native_module_name is None
+def test_retired_native_detector_keeps_its_callable_linter_interface() -> None:
+    native_module = importlib.import_module("state_description_blocker")
+    assert native_module.find_violations("The API uses port 8080.", "guide.md") == []
+    assert native_module.find_violations("Previously set via env var.", "guide.md")
+    assert all(each_entry.native_module_name is None for each_entry in ALL_HOSTED_HOOK_ENTRIES)
 
 
-def test_windows_rmtree_blocker_still_registered() -> None:
-    entry = _entry_for("blocking/windows_rmtree_blocker.py")
-    assert entry is not None
-    assert entry.applicable_tool_names == ALL_WRITE_EDIT_MULTI_EDIT_TOOL_NAMES
+def test_four_way_set_covers_every_mutation_tool_name() -> None:
+    assert ALL_WRITE_EDIT_MULTI_EDIT_APPLY_PATCH_TOOL_NAMES == (
+        ALL_WRITE_EDIT_MULTI_EDIT_TOOL_NAMES | {APPLY_PATCH_TOOL_NAME}
+    )
 
 
 def test_blocking_hook_crash_deny_reason_surfaces_the_constant() -> None:
@@ -90,151 +83,3 @@ def test_blocking_hook_crash_deny_reason_surfaces_the_constant() -> None:
     decision = aggregate_hosted_hook_results([crash_result])
     assert decision.should_deny
     assert BLOCKING_CRASH_DENY_REASON in decision.all_deny_reasons
-
-
-def test_refactor_guard_is_hosted_as_an_edit_and_multi_edit_advisory_hook() -> None:
-    entry = _entry_for("advisory/refactor_guard.py")
-    assert entry is not None, (
-        "refactor_guard must be hosted by the dispatcher rather than spawning its own process"
-    )
-    assert entry.applicable_tool_names == frozenset({EDIT_TOOL_NAME, MULTI_EDIT_TOOL_NAME})
-    assert entry.is_blocking is False
-
-
-def test_migration_safety_advisor_is_hosted_as_an_edit_and_multi_edit_advisory_hook() -> None:
-    entry = _entry_for("advisory/migration_safety_advisor.py")
-    assert entry is not None, (
-        "migration_safety_advisor must be hosted by the dispatcher rather than "
-        "spawning its own process"
-    )
-    assert entry.applicable_tool_names == frozenset({EDIT_TOOL_NAME, MULTI_EDIT_TOOL_NAME})
-    assert entry.is_blocking is False
-
-
-def test_every_hosted_script_path_exists_under_the_hooks_root() -> None:
-    for each_entry in ALL_HOSTED_HOOK_ENTRIES:
-        hosted_script_path = _HOOKS_ROOT / each_entry.script_relative_path
-        assert hosted_script_path.is_file(), (
-            f"{each_entry.script_relative_path} is on the roster but missing from the hooks tree"
-        )
-
-
-def test_every_native_module_exposes_a_callable_evaluate() -> None:
-    nativized_entries = [
-        each_entry
-        for each_entry in ALL_HOSTED_HOOK_ENTRIES
-        if each_entry.native_module_name is not None
-    ]
-    assert nativized_entries, (
-        "the roster must carry at least one nativized hook for this test to lock the contract"
-    )
-    for each_entry in nativized_entries:
-        native_module = importlib.import_module(each_entry.native_module_name)
-        evaluate_function = getattr(native_module, "evaluate", None)
-        assert callable(evaluate_function), (
-            f"{each_entry.native_module_name} must expose a callable named evaluate, "
-            "matching the native_module_name docstring contract"
-        )
-
-
-def test_four_way_set_covers_every_mutation_tool_name() -> None:
-    assert ALL_WRITE_EDIT_MULTI_EDIT_APPLY_PATCH_TOOL_NAMES == (
-        ALL_WRITE_EDIT_MULTI_EDIT_TOOL_NAMES | {APPLY_PATCH_TOOL_NAME}
-    )
-
-
-def test_immediate_harm_hooks_reach_apply_patch() -> None:
-    """PII, sensitive-path, existing-file, CODE_RULES, and TDD gates all see apply_patch."""
-    for each_script_path in ALL_IMMEDIATE_HARM_SCRIPT_PATHS:
-        entry = _entry_for(each_script_path)
-        assert entry is not None, f"{each_script_path} must stay on the hosted roster"
-        assert APPLY_PATCH_TOOL_NAME in entry.applicable_tool_names, (
-            f"{each_script_path} must reach apply_patch for mutation-tool parity"
-        )
-
-
-_ALL_DEFERRED_LINT_SCRIPT_PATHS = (
-    "blocking/state_description_blocker.py",
-    "blocking/workflow_substitution_slot_blocker.py",
-    "blocking/claude_md_orphan_file_blocker.py",
-    "blocking/package_inventory_stale_blocker.py",
-    "blocking/env_var_table_code_drift_blocker.py",
-    "blocking/pytest_testpaths_orphan_blocker.py",
-    "blocking/open_questions_in_plans_blocker.py",
-    "blocking/docstring_rule_gate_count_blocker.py",
-    "blocking/duplicate_rmtree_helper_blocker.py",
-    "validation/hook_format_validator.py",
-    "blocking/hook_prose_detector_consistency.py",
-    "blocking/subprocess_budget_completeness.py",
-    "blocking/windows_rmtree_blocker.py",
-    "advisory/refactor_guard.py",
-    "advisory/migration_safety_advisor.py",
-)
-
-
-def test_lint_and_advisory_hooks_stay_off_the_apply_patch_roster() -> None:
-    """Every hook reaching MultiEdit but not apply_patch fails the same one rule.
-
-    apply_patch reaches only a gate whose violation is already real and
-    unrecoverable the moment the call returns: a leaked secret, an exposed
-    sensitive path, a blind overwrite, or an untested change landing. Every
-    hook named here instead judges the quality of the authored content for a
-    consequence the write itself does not cause right now: doc-inventory
-    drift, prose or naming style, a future-runtime correctness pattern (an
-    unsafe rmtree that only misbehaves on Windows, a subprocess-timeout
-    budget the harness reads separately), or an advisory suggestion that
-    never denies at all. Each is fixable in a later Edit-tool pass, so none
-    needs apply_patch's narrower, deny-only roster.
-    """
-    for each_script_path in _ALL_DEFERRED_LINT_SCRIPT_PATHS:
-        entry = _entry_for(each_script_path)
-        assert entry is not None, f"{each_script_path} must stay on the hosted roster"
-        assert MULTI_EDIT_TOOL_NAME in entry.applicable_tool_names, (
-            f"{each_script_path} must still reach MultiEdit"
-        )
-        assert APPLY_PATCH_TOOL_NAME not in entry.applicable_tool_names, (
-            f"{each_script_path} judges deferred-fixable quality, not immediate harm, "
-            "so it must stay off the apply_patch roster"
-        )
-
-
-def test_edit_and_multi_edit_applicable_sets_are_equal() -> None:
-    """The Edit roster and the MultiEdit roster name the same hooks.
-
-    Every hook applicable to Edit judges Write's content or an Edit's
-    old/new string pair with no dependency on which tool delivered it, so
-    the two sets must match exactly. A hook that legitimately stays
-    Edit-only is an exception written down here with its reason, not a
-    silent gap this test lets back in.
-    """
-    all_edit_script_paths = {
-        each_entry.script_relative_path
-        for each_entry in ALL_HOSTED_HOOK_ENTRIES
-        if EDIT_TOOL_NAME in each_entry.applicable_tool_names
-    }
-    all_multi_edit_script_paths = {
-        each_entry.script_relative_path
-        for each_entry in ALL_HOSTED_HOOK_ENTRIES
-        if MULTI_EDIT_TOOL_NAME in each_entry.applicable_tool_names
-    }
-    assert all_edit_script_paths == all_multi_edit_script_paths, (
-        "Edit-only (not MultiEdit): "
-        f"{sorted(all_edit_script_paths - all_multi_edit_script_paths)}; "
-        "MultiEdit-only (not Edit): "
-        f"{sorted(all_multi_edit_script_paths - all_edit_script_paths)}"
-    )
-
-
-def test_multi_edit_widened_hooks_reach_multi_edit() -> None:
-    all_multi_edit_widened_script_paths = (
-        "blocking/write_existing_file_blocker.py",
-        "blocking/code_rules_enforcer.py",
-        "blocking/tdd_enforcer.py",
-        "blocking/state_description_blocker.py",
-    )
-    for each_script_path in all_multi_edit_widened_script_paths:
-        entry = _entry_for(each_script_path)
-        assert entry is not None, f"{each_script_path} must stay on the hosted roster"
-        assert MULTI_EDIT_TOOL_NAME in entry.applicable_tool_names, (
-            f"{each_script_path} must reach MultiEdit for mutation-tool parity"
-        )

package/hooks/hooks_constants/test_stop_dispatcher_constants.py

@@ -1,29 +1,7 @@
 """Tests for the Stop-hook dispatcher hosted-hook roster."""
 
-from __future__ import annotations
+from hooks_constants.stop_dispatcher_constants import ALL_STOP_HOSTED_HOOK_PATHS
 
-import sys
-from pathlib import Path
 
-_HOOKS_DIR = str(Path(__file__).resolve().parent.parent)
-if _HOOKS_DIR not in sys.path:
-    sys.path.insert(0, _HOOKS_DIR)
-
-from hooks_constants.stop_dispatcher_constants import ALL_STOP_HOSTED_HOOK_PATHS  # noqa: E402
-
-_EXPECTED_STOP_ORDER = (
-    "blocking/question_to_user_enforcer.py",
-    "blocking/session_handoff_blocker.py",
-)
-
-
-def test_roster_lists_all_stop_hooks_in_registration_order() -> None:
-    """The roster reproduces the standalone Stop chain order exactly."""
-    assert ALL_STOP_HOSTED_HOOK_PATHS == _EXPECTED_STOP_ORDER
-
-
-def test_every_roster_path_points_at_an_existing_hook() -> None:
-    """Each roster path names a hook script present on disk, catching a typo."""
-    hooks_root = Path(__file__).resolve().parent.parent
-    for each_relative_path in ALL_STOP_HOSTED_HOOK_PATHS:
-        assert (hooks_root / each_relative_path).is_file()
+def test_roster_has_no_blocking_hooks() -> None:
+    assert ALL_STOP_HOSTED_HOOK_PATHS == ()