claude-dev-env 2.31.0 → 2.32.0

package/hooks/validators/fast_save_validators.py

@@ -45,6 +45,7 @@ from .test_safety_checks import (
 from .todo_checks import validate_file as validate_todo_file
 from .type_safety_checks import validate_file as validate_type_safety_file
 from .useless_test_checks import validate_file as validate_useless_test_file
+from .validator_base import ValidatorResult
 
 FilePredicate = Callable[[Path], bool]
 FileViolationLineCollector = Callable[[Path], "list[str]"]
@@ -76,21 +77,6 @@ def _violation_lines_from(raw_validate_file: _RawFileValidator) -> FileViolation
     return _collect
 
 
-@dataclass(frozen=True)
-class FastSaveCheckOutcome:
-    """One save-path check's finding.
-
-    The caller wraps this into its own reporting type. This module never
-    imports that type back, so no circular import exists between the two
-    modules.
-    """
-
-    display_name: str
-    checks: str
-    is_clean: bool
-    violation_report: str
-
-
 def _is_python_file(file_path: Path) -> bool:
     return file_path.suffix == PYTHON_SOURCE_SUFFIX
 
@@ -122,15 +108,10 @@ def _collect_test_safety_violation_lines(file_path: Path) -> "list[str]":
 
 
 def _collect_react_violation_lines(file_path: Path) -> "list[str]":
-    """Adapt react_checks's whole-batch ``check_no_class_components`` to one file.
-
-    react_checks.Violation carries no ``__str__`` override, so this formats
-    each violation the same way react_checks's own ``main`` prints one.
-    """
-    all_violations = check_no_class_components([str(file_path)])
+    """Adapt react_checks's whole-batch ``check_no_class_components`` to one file."""
     return [
-        f"{each_violation.file}:{each_violation.line}: {each_violation.message}"
-        for each_violation in all_violations
+        str(each_violation)
+        for each_violation in check_no_class_components([str(file_path)])
     ]
 
 
@@ -145,11 +126,12 @@ class _FastSaveValidatorSpecification:
     no_matching_files_message: str
 
 
-def _python_naming_and_syntax_specifications() -> (
-    "list[_FastSaveValidatorSpecification]"
+def _all_fast_save_validator_specifications() -> (
+    "tuple[_FastSaveValidatorSpecification, ...]"
 ):
-    """Return the save-path checks for Python naming, style, and constants."""
-    return [
+    """Return the save-path roster: every non-Mypy, non-Ruff file-scoped check."""
+    return (
+        # Python naming, style, and constants.
         _FastSaveValidatorSpecification(
             "Python Style",
             "1,2,3,4",
@@ -171,14 +153,7 @@ def _python_naming_and_syntax_specifications() -> (
             _violation_lines_from(validate_magic_literal_file),
             NO_PYTHON_FILES_MESSAGE,
         ),
-    ]
-
-
-def _python_quality_and_tracking_specifications() -> (
-    "list[_FastSaveValidatorSpecification]"
-):
-    """Return the save-path checks for Python code quality and TODO tracking."""
-    return [
+        # Python code quality and TODO tracking.
         _FastSaveValidatorSpecification(
             "TODO Tracking",
             "36",
@@ -200,14 +175,7 @@ def _python_quality_and_tracking_specifications() -> (
             _violation_lines_from(validate_code_quality_file),
             NO_PYTHON_FILES_MESSAGE,
         ),
-    ]
-
-
-def _python_safety_and_typing_specifications() -> (
-    "list[_FastSaveValidatorSpecification]"
-):
-    """Return the save-path checks for Python anti-patterns and typing."""
-    return [
+        # Python anti-patterns and typing.
         _FastSaveValidatorSpecification(
             "Python Anti-patterns",
             "33,34,35",
@@ -222,12 +190,7 @@ def _python_safety_and_typing_specifications() -> (
             _violation_lines_from(validate_type_safety_file),
             NO_PYTHON_FILES_MESSAGE,
         ),
-    ]
-
-
-def _test_scoped_fast_save_specifications() -> "list[_FastSaveValidatorSpecification]":
-    """Return the save-path checks scoped to a ``test_*.py``-shaped file."""
-    return [
+        # Scoped to a test_*.py-shaped file.
         _FastSaveValidatorSpecification(
             "Test Safety",
             "11,21",
@@ -242,14 +205,7 @@ def _test_scoped_fast_save_specifications() -> "list[_FastSaveValidatorSpecifica
             _violation_lines_from(validate_useless_test_file),
             NO_TEST_FILES_MESSAGE,
         ),
-    ]
-
-
-def _cross_language_fast_save_specifications() -> (
-    "list[_FastSaveValidatorSpecification]"
-):
-    """Return the save-path checks that read a non-Python or multi-language file."""
-    return [
+        # Non-Python or multi-language files.
         _FastSaveValidatorSpecification(
             "React",
             "17",
@@ -264,39 +220,26 @@ def _cross_language_fast_save_specifications() -> (
             _violation_lines_from(validate_pr_reference_file),
             NO_CODE_REFERENCE_FILES_MESSAGE,
         ),
-    ]
-
-
-def _all_fast_save_validator_specifications() -> (
-    "list[_FastSaveValidatorSpecification]"
-):
-    """Return the save-path roster: every non-Mypy, non-Ruff file-scoped check."""
-    return [
-        *_python_naming_and_syntax_specifications(),
-        *_python_quality_and_tracking_specifications(),
-        *_python_safety_and_typing_specifications(),
-        *_test_scoped_fast_save_specifications(),
-        *_cross_language_fast_save_specifications(),
-    ]
+    )
 
 
 def _fast_save_outcome(
     specification: _FastSaveValidatorSpecification,
     is_clean: bool,
     violation_report: str,
-) -> FastSaveCheckOutcome:
-    """Build one outcome from a specification's display name and check numbers."""
-    return FastSaveCheckOutcome(
-        display_name=specification.display_name,
+) -> ValidatorResult:
+    """Build one result from a specification's display name and check numbers."""
+    return ValidatorResult(
+        name=specification.display_name,
         checks=specification.checks,
-        is_clean=is_clean,
-        violation_report=violation_report,
+        passed=is_clean,
+        output=violation_report,
     )
 
 
 def _run_specification(
     specification: _FastSaveValidatorSpecification, files: "list[Path]"
-) -> FastSaveCheckOutcome:
+) -> ValidatorResult:
     """Run one validator's violation collector in-process over its matching files."""
     matching_files = [
         each_file for each_file in files if specification.applies_to_file(each_file)
@@ -316,14 +259,14 @@ def _run_specification(
     return _fast_save_outcome(specification, False, violation_report)
 
 
-def run_fast_save_validators(files: "list[Path]") -> "list[FastSaveCheckOutcome]":
+def run_fast_save_validators(files: "list[Path]") -> "list[ValidatorResult]":
     """Run every save-path validator in-process, skipping Mypy and Ruff.
 
     Args:
         files: The files under validation -- one reconstructed file in gate mode.
 
     Returns:
-        One outcome per in-process validator, in roster order. The caller adds
+        One result per in-process validator, in roster order. The caller adds
         Ruff and never adds Mypy.
     """
     return [

package/hooks/validators/mypy_integration.py

@@ -13,28 +13,26 @@ _validators_directory = str(Path(__file__).resolve().parent)
 _hooks_directory = str(Path(__file__).resolve().parent.parent)
 
 try:
+    from project_roots import enclosing_project_root
     from pyproject_config_discovery import (
-        ancestor_directories,
+        ancestor_directories,  # noqa: F401  re-exported for validation/mypy_validator
         find_pyproject_configuring_tool,
     )
-    from system_temporary_roots import enclosing_system_temporary_root
 except ModuleNotFoundError:
     if _validators_directory not in sys.path:
         sys.path.insert(0, _validators_directory)
+    from project_roots import enclosing_project_root
     from pyproject_config_discovery import (
-        ancestor_directories,
+        ancestor_directories,  # noqa: F401  re-exported for validation/mypy_validator
         find_pyproject_configuring_tool,
     )
-    from system_temporary_roots import enclosing_system_temporary_root
 
 try:
     from hooks_constants.mypy_integration_constants import (
         FOLLOW_IMPORTS_FLAG,
         FOLLOW_IMPORTS_SKIP_VALUE,
-        GIT_DIRECTORY_NAME,
         MYPY_DETACHED_SUBPROCESS_TIMEOUT_SECONDS,
         MYPY_DETACHED_TIMEOUT_SKIP_MESSAGE,
-        PYPROJECT_FILENAME,
         PYTHON_SOURCE_SUFFIX,
     )
     from hooks_constants.pyproject_config_discovery_constants import MYPY_TOOL_TABLE_NAME
@@ -44,10 +42,8 @@ except ModuleNotFoundError:
     from hooks_constants.mypy_integration_constants import (
         FOLLOW_IMPORTS_FLAG,
         FOLLOW_IMPORTS_SKIP_VALUE,
-        GIT_DIRECTORY_NAME,
         MYPY_DETACHED_SUBPROCESS_TIMEOUT_SECONDS,
         MYPY_DETACHED_TIMEOUT_SKIP_MESSAGE,
-        PYPROJECT_FILENAME,
         PYTHON_SOURCE_SUFFIX,
     )
     from hooks_constants.pyproject_config_discovery_constants import MYPY_TOOL_TABLE_NAME
@@ -97,41 +93,19 @@ def find_pyproject_with_mypy_config(starting_file: Path) -> Path | None:
 
 
 def find_module_resolution_root(starting_file: Path) -> Path | None:
-    """Return the nearest ancestor directory that roots a project, else None.
+    """Return the project root mypy resolves this file's first-party imports against.
 
-    A project root is the first ancestor holding a ``.git`` entry or a
-    ``pyproject.toml``. Mypy resolves a first-party import against its working
-    directory, so anchoring there binds ``config.*`` to the target file's own
-    project and keeps a foreign ``config`` in the caller's directory out of scope.
-
-    The walk does not climb out of the system temp directory. A PreToolUse
-    staging copy lives under ``%TEMP%``, and a ``.git`` in the user home above
-    that temp root is not this file's project.
-
-    ::
-
-        target_repo/.git + target_repo/tools/x.py -> target_repo
-        /tmp/detached/x.py (home .git above temp) -> None
-        flag: walk past %TEMP% into ~/.git        -> mypy cwd=home, hook timeout
+    Mypy resolves a first-party import against its working directory, so
+    anchoring there binds ``config.*`` to the target file's own project and
+    keeps a foreign ``config`` in the caller's directory out of scope.
 
     Args:
         starting_file: The file (or directory) the walk begins from.
 
     Returns:
-        The nearest ancestor Path that holds ``.git`` or ``pyproject.toml``,
-        or ``None`` when no such ancestor exists inside the walk limit.
+        The project root, or None when the file sits inside none.
     """
-    git_entry_name = GIT_DIRECTORY_NAME
-    pyproject_filename = PYPROJECT_FILENAME
-    enclosing_temporary_root = enclosing_system_temporary_root(starting_file)
-    for each_candidate_directory in ancestor_directories(starting_file):
-        has_git_entry = (each_candidate_directory / git_entry_name).exists()
-        has_pyproject = (each_candidate_directory / pyproject_filename).is_file()
-        if has_git_entry or has_pyproject:
-            return each_candidate_directory
-        if each_candidate_directory == enclosing_temporary_root:
-            return None
-    return None
+    return enclosing_project_root(starting_file)
 
 
 def _first_module_resolution_root(all_py_files: list[str]) -> Path | None:

package/hooks/validators/pr_reference_checks.py

@@ -9,7 +9,7 @@ import sys
 from pathlib import Path
 from typing import List
 
-from .validator_base import Violation
+from .validator_base import Violation, source_text
 
 
 PR_PATTERN = re.compile(r"#.*\bPR\s*#?\d+", re.IGNORECASE)
@@ -42,7 +42,7 @@ def check_pr_references(source: str, filename: str) -> List[Violation]:
 def validate_file(file_path: Path) -> List[Violation]:
     filename = str(file_path)
     try:
-        source = file_path.read_text(encoding="utf-8")
+        source = source_text(file_path)
     except Exception as error:
         return [Violation(filename, 0, f"Error reading file: {error}")]
 

package/hooks/validators/project_roots.py

@@ -0,0 +1,58 @@
+"""Resolve the project root that contains a path, if any.
+
+A project root is the nearest ancestor holding a ``.git`` entry or a
+``pyproject.toml``. Callers need that anchor for unrelated reasons: binding a
+first-party import, deciding which directory segments a project owns. One
+module answers it rather than each re-coding the walk.
+
+::
+
+    target_repo/.git + target_repo/tools/x.py  -> target_repo
+    /tmp/detached/x.py (home .git above temp)  -> None
+"""
+
+from __future__ import annotations
+
+import sys
+from pathlib import Path
+
+_validators_directory = str(Path(__file__).resolve().parent)
+_hooks_directory = str(Path(__file__).resolve().parent.parent)
+for each_directory in (_validators_directory, _hooks_directory):
+    if each_directory not in sys.path:
+        sys.path.insert(0, each_directory)
+
+from pyproject_config_discovery import ancestor_directories  # noqa: E402
+from system_temporary_roots import (  # noqa: E402
+    enclosing_system_temporary_root,
+)
+
+from hooks_constants.mypy_integration_constants import (  # noqa: E402
+    GIT_DIRECTORY_NAME,
+    PYPROJECT_FILENAME,
+)
+
+
+def enclosing_project_root(starting_file: Path) -> Path | None:
+    """Return the nearest ancestor directory that roots a project, else None.
+
+    The walk stops at the system temp root. A staging copy lives under a temp
+    directory, and a ``.git`` in the user home above that root roots no
+    project of the staged file's.
+
+    Args:
+        starting_file: The file (or directory) the walk begins from.
+
+    Returns:
+        The nearest ancestor holding ``.git`` or ``pyproject.toml``, or None
+        when the walk reaches the temp root or runs out of ancestors.
+    """
+    enclosing_temporary_root = enclosing_system_temporary_root(starting_file)
+    for each_candidate_directory in ancestor_directories(starting_file):
+        has_git_entry = (each_candidate_directory / GIT_DIRECTORY_NAME).exists()
+        has_pyproject = (each_candidate_directory / PYPROJECT_FILENAME).is_file()
+        if has_git_entry or has_pyproject:
+            return each_candidate_directory
+        if each_candidate_directory == enclosing_temporary_root:
+            return None
+    return None

package/hooks/validators/python_antipattern_checks.py

@@ -11,7 +11,7 @@ import sys
 from pathlib import Path
 from typing import List
 
-from .validator_base import Violation
+from .validator_base import Violation, source_text, syntax_tree
 
 _hooks_directory = str(Path(__file__).resolve().parent.parent)
 
@@ -90,8 +90,8 @@ def validate_file(file_path: Path) -> List[Violation]:
     filename = str(file_path)
 
     try:
-        source = file_path.read_text(encoding="utf-8")
-        tree = ast.parse(source)
+        source = source_text(file_path)
+        tree = syntax_tree(source)
     except Exception as error:
         return [Violation(filename, 0, f"Error: {error}")]
 

package/hooks/validators/python_style_checks.py

@@ -21,6 +21,7 @@ from hooks_constants.python_style_checks_constants import (  # noqa: E402
     EXPECTED_BLANK_LINES_BETWEEN_FUNCTIONS,
     MINIMUM_ARGUMENT_COUNT,
 )
+from validators.validator_base import source_text, syntax_tree  # noqa: E402
 from validators.python_style_helpers import (  # noqa: E402
     FunctionNode,
     blank_line_for_source,
@@ -331,12 +332,12 @@ def validate_file(file_path: Path) -> list[Violation]:
     violations: list[Violation] = []
     filename = str(file_path)
     try:
-        source = file_path.read_text(encoding="utf-8")
+        source = source_text(file_path)
     except Exception as error:
         violations.append(Violation(filename, 0, f"Error reading file: {error}"))
         return violations
     try:
-        tree = ast.parse(source)
+        tree = syntax_tree(source)
     except SyntaxError as error:
         violations.append(
             Violation(filename, error.lineno or 0, f"Syntax error: {error.msg}")

package/hooks/validators/react_checks.py

@@ -7,16 +7,9 @@ Validates React-specific code standards:
 
 import re
 import sys
-from dataclasses import dataclass
 from pathlib import Path
 
-
-@dataclass(frozen=True)
-class Violation:
-    """Represents a validation violation."""
-    file: str
-    line: int
-    message: str
+from .validator_base import Violation
 
 
 CLASS_COMPONENT_PATTERN = re.compile(
@@ -81,7 +74,7 @@ def main() -> int:
     violations = check_no_class_components(file_paths)
 
     for violation in violations:
-        print(f"{violation.file}:{violation.line}: {violation.message}")
+        print(violation)
 
     return 1 if violations else 0