claude-dev-env 2.31.0 → 2.32.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (80) hide show
  1. package/bin/install.test.mjs +11 -3
  2. package/docs/CODE_RULES.md +2 -1
  3. package/hooks/blocking/bash_post_call_dispatcher.py +70 -0
  4. package/hooks/blocking/bash_pre_tool_use_dispatcher.py +8 -21
  5. package/hooks/blocking/code_rules_duplicate_body.py +280 -102
  6. package/hooks/blocking/code_rules_enforcer.py +32 -14
  7. package/hooks/blocking/code_rules_enforcer_test_support.py +39 -0
  8. package/hooks/blocking/code_rules_shared.py +64 -14
  9. package/hooks/blocking/pr_description_writer_gate.py +18 -25
  10. package/hooks/blocking/shell_substitution_blocker.py +175 -8
  11. package/hooks/blocking/stop_dispatcher.py +6 -9
  12. package/hooks/blocking/tdd_enforcer.py +11 -5
  13. package/hooks/blocking/tdd_enforcer_parts/config/tdd_enforcer_constants.py +7 -0
  14. package/hooks/blocking/tdd_enforcer_parts/content_hash_store.py +141 -23
  15. package/hooks/blocking/tdd_enforcer_parts/tests/test_content_hash_store.py +114 -1
  16. package/hooks/blocking/test_bash_post_call_dispatcher.py +112 -0
  17. package/hooks/blocking/test_code_rules_enforcer_ephemeral.py +12 -1
  18. package/hooks/blocking/test_code_rules_enforcer_ephemeral_repository_root.py +118 -0
  19. package/hooks/blocking/test_code_rules_enforcer_same_file_inline_duplicate.py +251 -0
  20. package/hooks/blocking/test_code_rules_enforcer_split_entry_2.py +22 -0
  21. package/hooks/blocking/test_pr_description_writer_gate.py +21 -3
  22. package/hooks/blocking/test_pre_tool_use_dispatcher_native.py +14 -2
  23. package/hooks/blocking/test_shell_substitution_blocker.py +105 -0
  24. package/hooks/blocking/test_state_description_blocker.py +84 -53
  25. package/hooks/blocking/test_tdd_enforcer.py +131 -1
  26. package/hooks/hooks.json +2 -2
  27. package/hooks/hooks_constants/bash_post_call_dispatcher_constants.py +22 -0
  28. package/hooks/hooks_constants/hosted_hook_runner.py +53 -0
  29. package/hooks/hooks_constants/piped_pytest_blocker_constants.py +9 -2
  30. package/hooks/hooks_constants/pr_description_writer_gate_constants.py +34 -0
  31. package/hooks/hooks_constants/shell_substitution_blocker_constants.py +10 -0
  32. package/hooks/hooks_constants/state_file_lock.py +76 -0
  33. package/hooks/hooks_constants/subprocess_budget_completeness_content.py +2 -2
  34. package/hooks/hooks_constants/test_bash_post_call_dispatcher_constants.py +27 -0
  35. package/hooks/hooks_constants/test_failure_recorder_constants.py +35 -0
  36. package/hooks/hooks_constants/test_hosted_hook_runner.py +55 -1
  37. package/hooks/hooks_constants/test_multi_edit_reconstruction.py +1 -0
  38. package/hooks/hooks_constants/test_subprocess_budget_completeness_content.py +33 -0
  39. package/hooks/observability/pr_description_writer_spawn_tracker.py +4 -12
  40. package/hooks/observability/session_file_edit_tracker.py +2 -55
  41. package/hooks/observability/test_failure_recorder.py +219 -0
  42. package/hooks/observability/test_pr_description_writer_spawn_tracker.py +6 -2
  43. package/hooks/observability/test_test_failure_recorder.py +173 -0
  44. package/hooks/validators/abbreviation_checks.py +3 -3
  45. package/hooks/validators/code_quality_checks.py +4 -4
  46. package/hooks/validators/config/baseline_identity_constants.py +12 -0
  47. package/hooks/validators/config/directory_exemption_constants.py +42 -8
  48. package/hooks/validators/config/system_temporary_roots_constants.py +15 -0
  49. package/hooks/validators/config/validator_base_constants.py +9 -0
  50. package/hooks/validators/fast_save_validators.py +23 -80
  51. package/hooks/validators/mypy_integration.py +10 -36
  52. package/hooks/validators/pr_reference_checks.py +2 -2
  53. package/hooks/validators/project_roots.py +58 -0
  54. package/hooks/validators/python_antipattern_checks.py +3 -3
  55. package/hooks/validators/python_style_checks.py +3 -2
  56. package/hooks/validators/react_checks.py +2 -9
  57. package/hooks/validators/run_all_validators.py +247 -148
  58. package/hooks/validators/security_checks.py +3 -3
  59. package/hooks/validators/system_temporary_roots.py +1 -1
  60. package/hooks/validators/test_directory_exemption_constants.py +30 -24
  61. package/hooks/validators/test_fast_save_validators.py +16 -16
  62. package/hooks/validators/test_hook_timing_harness.py +10 -1
  63. package/hooks/validators/test_run_all_validators.py +22 -0
  64. package/hooks/validators/test_run_all_validators_mutation_tool_parity.py +249 -0
  65. package/hooks/validators/test_run_all_validators_pretooluse.py +161 -0
  66. package/hooks/validators/test_run_all_validators_reporting.py +66 -0
  67. package/hooks/validators/test_run_all_validators_repository_root.py +202 -0
  68. package/hooks/validators/test_validator_base.py +51 -2
  69. package/hooks/validators/todo_checks.py +2 -2
  70. package/hooks/validators/type_safety_checks.py +3 -3
  71. package/hooks/validators/useless_test_checks.py +3 -3
  72. package/hooks/validators/validator_base.py +73 -1
  73. package/package.json +1 -1
  74. package/rules/shell-invocation.md +1 -1
  75. package/rules/testing.md +4 -0
  76. package/scripts/dev_env_scripts_constants/grok_worker_constants.py +19 -0
  77. package/scripts/dev_env_scripts_constants/shared_tree_constants.py +17 -0
  78. package/scripts/grok_headless_runner.py +15 -12
  79. package/scripts/shared_tree_paths.py +104 -0
  80. package/scripts/test_shared_tree_paths.py +173 -0
@@ -13,16 +13,27 @@ blocking the tool call.
13
13
  run = run_hook_capturing_output("/hooks/blocking/gate.py", '{"tool_name": "Bash"}')
14
14
  ok: run.captured_stdout carries the gate's deny JSON, run.did_crash is False
15
15
  flag: run.did_crash is True when the gate raised, run.captured_stdout is ""
16
+
17
+ ``run_dispatcher_main`` holds the entry-point shell a hosted-hook dispatcher's
18
+ own ``main`` needs: read one stdin payload, resolve its tool_name, and hand
19
+ both to the dispatcher's own ``dispatch`` callback. Every dispatcher's
20
+ ``main`` reduces to one call into this shared shell, so the read-resolve-exit
21
+ boilerplate lives in one place rather than once per dispatcher.
16
22
  """
17
23
 
18
24
  from __future__ import annotations
19
25
 
20
26
  import io
27
+ import json
21
28
  import runpy
22
29
  import sys
30
+ from pathlib import Path
23
31
  import traceback
32
+ from collections.abc import Callable
24
33
  from dataclasses import dataclass
25
34
 
35
+ from hooks_constants.pre_tool_use_stdin import read_hook_input_dictionary_from_stdin
36
+
26
37
 
27
38
  @dataclass
28
39
  class HostedHookRun:
@@ -71,3 +82,45 @@ def run_hook_capturing_output(hook_script_path: str, payload_text: str) -> Hoste
71
82
  finally:
72
83
  sys.stdin, sys.stdout, sys.argv = original_stdin, original_stdout, original_argv
73
84
  return HostedHookRun(captured_stdout=captured_output.getvalue(), did_crash=did_crash)
85
+
86
+
87
+ def resolved_hook_script_path(relative_path: str) -> str:
88
+ """Resolve a hooks/-relative path to the absolute script path to run.
89
+
90
+ ::
91
+
92
+ "observability/test_failure_recorder.py" -> <hooks>/observability/...
93
+
94
+ The root comes from this module's own location, so every dispatcher
95
+ resolves against the same directory however deep it sits.
96
+
97
+ Args:
98
+ relative_path: A path relative to the hooks directory.
99
+
100
+ Returns:
101
+ The absolute path of that script.
102
+ """
103
+ hooks_root = Path(__file__).resolve().parent.parent
104
+ return str(hooks_root / relative_path)
105
+
106
+
107
+ def run_dispatcher_main(dispatch: Callable[[str, str], None]) -> None:
108
+ """Read one stdin payload and hand its JSON text and tool_name to dispatch.
109
+
110
+ Every hosted-hook dispatcher's own ``main`` reduces to this one call.
111
+ Exits 0 before ever calling dispatch when stdin is empty, malformed, or
112
+ names no tool_name string; always exits 0 afterward, since a dispatcher
113
+ signals its own outcome, if any, through what dispatch itself writes.
114
+
115
+ Args:
116
+ dispatch: The dispatcher's own ``dispatch(payload_text, tool_name)``.
117
+ """
118
+ payload_dictionary = read_hook_input_dictionary_from_stdin()
119
+ if payload_dictionary is None:
120
+ sys.exit(0)
121
+ payload_text = json.dumps(payload_dictionary)
122
+ tool_name = payload_dictionary.get("tool_name", "")
123
+ if not isinstance(tool_name, str) or not tool_name:
124
+ sys.exit(0)
125
+ dispatch(payload_text, tool_name)
126
+ sys.exit(0)
@@ -91,7 +91,9 @@ bare, quoted, or backslash-escaped (``<<\\EOF`` quotes the delimiter the way
91
91
  ``<<'EOF'`` does). ``<<<`` is a here-string rather than a heredoc, so the
92
92
  pattern refuses to read one as an opener and leave the lines below it unread.
93
93
  The opener also reports its own ``-``, because ``<<`` closes on a line spelling
94
- the delimiter exactly while ``<<-`` closes on one carrying leading tabs.
94
+ the delimiter exactly while ``<<-`` closes on one carrying leading tabs. It
95
+ reports the quote and the backslash separately from the delimiter word, because
96
+ either one tells a caller that bash expands nothing inside the body below.
95
97
 
96
98
  The string-executing shell basenames and command flags start from the shared
97
99
  ``unscoped_search_blocker_constants.py`` sets and add the Windows command shell
@@ -167,8 +169,10 @@ __all__ = [
167
169
  "HEREDOC_OPENER_PATTERN",
168
170
  "HEREDOC_TAB_STRIP_GROUP",
169
171
  "HEREDOC_QUOTE_GROUP",
172
+ "HEREDOC_ESCAPE_GROUP",
170
173
  "HEREDOC_TERMINATOR_GROUP",
171
174
  "HEREDOC_TAB_STRIP_MARKER",
175
+ "HEREDOC_UNQUOTED_MARKER",
172
176
  "HEREDOC_STRIPPED_INDENT_CHARACTERS",
173
177
  "NO_FOLLOWING_OPERATOR",
174
178
  "ALL_QUOTE_CHARACTERS",
@@ -340,13 +344,16 @@ CLOSED_GROUP_DEPTH = 0
340
344
  _HEREDOC_DELIMITER_CHARACTER_CLASS = r"[^\s'\"<>|&;()`$\\]"
341
345
  HEREDOC_TAB_STRIP_GROUP = "heredoc_tab_strip"
342
346
  HEREDOC_QUOTE_GROUP = "heredoc_quote"
347
+ HEREDOC_ESCAPE_GROUP = "heredoc_escape"
343
348
  HEREDOC_TERMINATOR_GROUP = "heredoc_terminator"
344
349
  HEREDOC_OPENER_PATTERN = re.compile(
345
- rf"(?<!<)<<(?!<)(?P<{HEREDOC_TAB_STRIP_GROUP}>-?)\s*(?P<{HEREDOC_QUOTE_GROUP}>['\"]?)\\?"
350
+ rf"(?<!<)<<(?!<)(?P<{HEREDOC_TAB_STRIP_GROUP}>-?)\s*(?P<{HEREDOC_QUOTE_GROUP}>['\"]?)"
351
+ rf"(?P<{HEREDOC_ESCAPE_GROUP}>\\?)"
346
352
  rf"(?P<{HEREDOC_TERMINATOR_GROUP}>{_HEREDOC_DELIMITER_CHARACTER_CLASS}+)"
347
353
  rf"(?P={HEREDOC_QUOTE_GROUP})"
348
354
  )
349
355
  HEREDOC_TAB_STRIP_MARKER = "-"
356
+ HEREDOC_UNQUOTED_MARKER = ""
350
357
  HEREDOC_STRIPPED_INDENT_CHARACTERS = "\t"
351
358
  NO_FOLLOWING_OPERATOR = ""
352
359
  ALL_QUOTE_CHARACTERS = "\"'"
@@ -7,6 +7,13 @@ The tracker records one fact per session: the session spawned the
7
7
 
8
8
  from __future__ import annotations
9
9
 
10
+ import tempfile
11
+ from pathlib import Path
12
+
13
+ from hooks_constants.session_edit_stage_gate_constants import (
14
+ SESSION_ID_UNSAFE_CHARACTERS_PATTERN,
15
+ )
16
+
10
17
  PR_DESCRIPTION_WRITER_SUBAGENT_TYPE: str = "pr-description-writer"
11
18
 
12
19
  ALL_AGENT_SPAWN_TOOL_NAMES: frozenset[str] = frozenset({"Agent", "Task"})
@@ -37,3 +44,30 @@ CORRECTIVE_MESSAGE: str = (
37
44
  " 2. Append the trailing comment `# pr-description-skip` to the command when "
38
45
  "you are writing the body yourself on purpose."
39
46
  )
47
+
48
+
49
+ def spawn_marker_path(session_id: str, temp_directory: Path | None = None) -> Path | None:
50
+ """Return this session's marker file path, or None when it names no session.
51
+
52
+ The tracker writes this path and the gate reads it, so the file name lives
53
+ in one place. A session id that sanitizes to nothing yields no path, so
54
+ every marker on disk belongs to one real session and a marker a crashed
55
+ session leaves behind is inert.
56
+
57
+ Args:
58
+ session_id: Raw ``session_id`` from the hook payload.
59
+ temp_directory: The directory holding the marker. Defaults to the
60
+ system temp directory.
61
+
62
+ Returns:
63
+ Absolute path to this session's marker file, or None when the payload
64
+ names no session this hook can key on.
65
+ """
66
+ sanitized_session_id = SESSION_ID_UNSAFE_CHARACTERS_PATTERN.sub("", session_id)
67
+ if not sanitized_session_id:
68
+ return None
69
+ file_name = (
70
+ f"{SPAWN_MARKER_FILE_PREFIX}{sanitized_session_id}{SPAWN_MARKER_FILE_SUFFIX}"
71
+ )
72
+ resolved_temp_directory = temp_directory or Path(tempfile.gettempdir())
73
+ return resolved_temp_directory / file_name
@@ -25,6 +25,11 @@ __all__ = [
25
25
  "PROCESS_SUBSTITUTION_PATTERN",
26
26
  "SINGLE_QUOTED_RUN_PATTERN",
27
27
  "STRIPPED_RUN_REPLACEMENT",
28
+ "COMMAND_LINE_SEPARATOR",
29
+ "BACKSLASH_CHARACTER",
30
+ "SINGLE_QUOTE_CHARACTER",
31
+ "DOUBLE_QUOTE_CHARACTER",
32
+ "NO_TERMINATOR_INDEX",
28
33
  "CORRECTIVE_MESSAGE",
29
34
  ]
30
35
 
@@ -49,6 +54,11 @@ EVEN_BACKSLASH_BACKTICK_PATTERN = re.compile(r"(?<!\\)(?:\\\\)*`")
49
54
  PROCESS_SUBSTITUTION_PATTERN = re.compile(r"[<>]\(")
50
55
  SINGLE_QUOTED_RUN_PATTERN = re.compile(r"'[^']*'")
51
56
  STRIPPED_RUN_REPLACEMENT = ""
57
+ COMMAND_LINE_SEPARATOR = "\n"
58
+ BACKSLASH_CHARACTER = "\\"
59
+ SINGLE_QUOTE_CHARACTER = "'"
60
+ DOUBLE_QUOTE_CHARACTER = '"'
61
+ NO_TERMINATOR_INDEX = -1
52
62
 
53
63
  CORRECTIVE_MESSAGE = (
54
64
  "BLOCKED [shell-substitution]: command contains $(...), backtick, or "
@@ -0,0 +1,76 @@
1
+ """Hold a best-effort exclusive lock across one read-modify-write of a state file.
2
+
3
+ Two hooks can reach the same state file in one turn. The file is written
4
+ through a temporary-plus-replace, so it is never torn; what this closes is
5
+ the separate lost-update race, where one writer reads before the other
6
+ writes and then overwrites it.
7
+
8
+ ::
9
+
10
+ with hold_state_file_lock(state_file):
11
+ all_stored = read(state_file)
12
+ write(state_file, updated(all_stored))
13
+
14
+ The lock is best effort. A caller that cannot take it inside the timeout
15
+ proceeds without it rather than stalling the tool call that triggered it.
16
+ """
17
+
18
+ from __future__ import annotations
19
+
20
+ import contextlib
21
+ import os
22
+ import sys
23
+ import time
24
+ from collections.abc import Iterator
25
+ from pathlib import Path
26
+
27
+ _hooks_directory = str(Path(__file__).resolve().parent.parent)
28
+ if _hooks_directory not in sys.path:
29
+ sys.path.insert(0, _hooks_directory)
30
+
31
+ from hooks_constants.session_edit_stage_gate_constants import ( # noqa: E402
32
+ LOCK_ACQUIRE_RETRY_SECONDS,
33
+ LOCK_ACQUIRE_TIMEOUT_SECONDS,
34
+ SESSION_EDIT_LOCK_FILE_SUFFIX,
35
+ )
36
+
37
+
38
+ def _acquire_lock_descriptor(lock_file: Path) -> int | None:
39
+ """Grab the exclusive lock, spinning until it frees or the timeout passes.
40
+
41
+ Args:
42
+ lock_file: Path to the lock file beside the state file.
43
+
44
+ Returns:
45
+ An open descriptor for the held lock, or None when it stayed held
46
+ past the acquire timeout.
47
+ """
48
+ lock_acquire_deadline = time.monotonic() + LOCK_ACQUIRE_TIMEOUT_SECONDS
49
+ while True:
50
+ try:
51
+ return os.open(str(lock_file), os.O_CREAT | os.O_EXCL | os.O_WRONLY)
52
+ except FileExistsError:
53
+ if time.monotonic() >= lock_acquire_deadline:
54
+ return None
55
+ time.sleep(LOCK_ACQUIRE_RETRY_SECONDS)
56
+
57
+
58
+ @contextlib.contextmanager
59
+ def hold_state_file_lock(state_file: Path) -> Iterator[None]:
60
+ """Hold the lock beside one state file for the body of the with-block.
61
+
62
+ Args:
63
+ state_file: The state file whose read-modify-write is being guarded.
64
+
65
+ Yields:
66
+ Control to the caller while the lock is held.
67
+ """
68
+ lock_file = state_file.with_name(state_file.name + SESSION_EDIT_LOCK_FILE_SUFFIX)
69
+ lock_file.parent.mkdir(parents=True, exist_ok=True)
70
+ lock_descriptor = _acquire_lock_descriptor(lock_file)
71
+ try:
72
+ yield
73
+ finally:
74
+ if lock_descriptor is not None:
75
+ os.close(lock_descriptor)
76
+ lock_file.unlink(missing_ok=True)
@@ -6,7 +6,7 @@ find a named budget helper that omits a reachable subprocess timeout.
6
6
 
7
7
  from __future__ import annotations
8
8
 
9
- from hooks_constants.multi_edit_reconstruction import apply_edits
9
+ from hooks_constants.multi_edit_reconstruction import apply_edits, edits_for_tool
10
10
 
11
11
  __all__ = [
12
12
  "existing_file_content",
@@ -35,7 +35,7 @@ def reconstructed_edit_content(all_tool_input_fields: dict[str, object]) -> str:
35
35
  existing_content = existing_file_content(file_path)
36
36
  if existing_content is None or old_string not in existing_content:
37
37
  return ""
38
- return existing_content.replace(old_string, new_string, 1)
38
+ return apply_edits(existing_content, edits_for_tool("Edit", all_tool_input_fields))
39
39
 
40
40
 
41
41
  def reconstructed_multi_edit_content(
@@ -0,0 +1,27 @@
1
+ """Behavioral tests for the Bash PostToolUse dispatcher's hosted-hook roster."""
2
+
3
+ from hooks_constants.bash_post_call_dispatcher_constants import (
4
+ ALL_BASH_POST_TOOL_USE_HOSTED_HOOK_ENTRIES,
5
+ )
6
+ from hooks_constants.bash_pre_tool_use_dispatcher_constants import BASH_TOOL_NAME
7
+
8
+
9
+ def test_roster_names_the_gh_pr_author_restore_hook() -> None:
10
+ all_script_paths = [
11
+ each_entry.script_relative_path for each_entry in ALL_BASH_POST_TOOL_USE_HOSTED_HOOK_ENTRIES
12
+ ]
13
+ assert "blocking/gh_pr_author_restore.py" in all_script_paths
14
+
15
+
16
+ def test_roster_names_the_test_failure_recorder_hook() -> None:
17
+ all_script_paths = [
18
+ each_entry.script_relative_path for each_entry in ALL_BASH_POST_TOOL_USE_HOSTED_HOOK_ENTRIES
19
+ ]
20
+ assert "observability/test_failure_recorder.py" in all_script_paths
21
+
22
+
23
+ def test_every_roster_entry_applies_to_bash() -> None:
24
+ assert all(
25
+ BASH_TOOL_NAME in each_entry.applicable_tool_names
26
+ for each_entry in ALL_BASH_POST_TOOL_USE_HOSTED_HOOK_ENTRIES
27
+ )
@@ -0,0 +1,35 @@
1
+ """Constants for the failing-test-run PostToolUse recorder hook.
2
+
3
+ Holds the cheap substring check the hook runs before any shell parsing, the
4
+ harness's own exit-code error prefix, the chaining and redirection operator
5
+ tokens that keep the recognizer to one unchained command, the pytest program
6
+ and Python interpreter basenames, and the flag-token marker the path
7
+ extractor uses to skip an option rather than an existing test file argument.
8
+
9
+ ``BASH_TOOL_NAME`` lives in ``gh_pr_author_swap_constants`` already; this
10
+ module reuses that name rather than a second literal. The pytest-program and
11
+ interpreter recognition here is deliberately its own small, stdlib-only
12
+ check rather than a reuse of ``piped_pytest_blocker_constants`` /
13
+ ``pytest_invocation``: those solve the harder pipe-and-wrapper problem and
14
+ pull in a much larger transitive import for every Bash call regardless of
15
+ content, working against the point of the recognizer's own cheap prefilter.
16
+ """
17
+
18
+ from __future__ import annotations
19
+
20
+ import re
21
+
22
+ ALL_PYTEST_MENTION_SUBSTRINGS: tuple[str, ...] = ("pytest", "py.test")
23
+ EXIT_CODE_ERROR_PREFIX: str = "Error: Exit code "
24
+ OPTION_TOKEN_PREFIX: str = "-"
25
+ NODE_ID_FILE_PATH_SEPARATOR: str = "::"
26
+ ALL_CHAINING_OPERATOR_SUBSTRINGS: tuple[str, ...] = ("&&", "||", ";", "|", "\n")
27
+ ALL_REDIRECTION_TOKENS: frozenset[str] = frozenset(
28
+ {">", ">>", "<", "<<", "2>&1", "1>&2", "2>", "1>"}
29
+ )
30
+ ALL_PYTEST_PROGRAM_BASENAMES: frozenset[str] = frozenset({"pytest", "py.test"})
31
+ MODULE_RUN_FLAG: str = "-m"
32
+ PYTEST_MODULE_NAME: str = "pytest"
33
+ PYTHON_INTERPRETER_BASENAME_PATTERN: re.Pattern[str] = re.compile(
34
+ r"^(?:python|py|pypy)[0-9.]*(?:\.exe)?$"
35
+ )
@@ -7,15 +7,22 @@ and the restoration of the interpreter's stdin, stdout, and argv.
7
7
 
8
8
  from __future__ import annotations
9
9
 
10
+ import io
10
11
  import json
11
12
  import sys
12
13
  from pathlib import Path
13
14
 
15
+ import pytest
16
+
14
17
  _HOOKS_DIR = str(Path(__file__).resolve().parent.parent)
15
18
  if _HOOKS_DIR not in sys.path:
16
19
  sys.path.insert(0, _HOOKS_DIR)
17
20
 
18
- from hooks_constants.hosted_hook_runner import HostedHookRun, run_hook_capturing_output # noqa: E402
21
+ from hooks_constants.hosted_hook_runner import ( # noqa: E402
22
+ HostedHookRun,
23
+ run_dispatcher_main,
24
+ run_hook_capturing_output,
25
+ )
19
26
 
20
27
 
21
28
  def _write_probe(tmp_path: Path, body: str) -> str:
@@ -99,3 +106,50 @@ def test_returns_a_hosted_hook_run_instance(tmp_path: Path) -> None:
99
106
  probe_path = _write_probe(tmp_path, "print('x')\n")
100
107
  hook_run = run_hook_capturing_output(probe_path, "{}")
101
108
  assert isinstance(hook_run, HostedHookRun)
109
+
110
+
111
+ def test_run_dispatcher_main_calls_dispatch_with_payload_text_and_tool_name(
112
+ monkeypatch: pytest.MonkeyPatch,
113
+ ) -> None:
114
+ """A well-formed payload reaches dispatch with its JSON text and tool_name."""
115
+ all_calls: list[tuple[str, str]] = []
116
+ monkeypatch.setattr(
117
+ sys, "stdin", io.StringIO(json.dumps({"tool_name": "Bash", "tool_input": {}}))
118
+ )
119
+
120
+ with pytest.raises(SystemExit) as raised_exit:
121
+ run_dispatcher_main(lambda payload_text, tool_name: all_calls.append((payload_text, tool_name)))
122
+
123
+ assert int(raised_exit.value.code or 0) == 0
124
+ assert len(all_calls) == 1
125
+ recorded_payload_text, recorded_tool_name = all_calls[0]
126
+ assert recorded_tool_name == "Bash"
127
+ assert json.loads(recorded_payload_text)["tool_name"] == "Bash"
128
+
129
+
130
+ def test_run_dispatcher_main_skips_dispatch_for_malformed_stdin(
131
+ monkeypatch: pytest.MonkeyPatch,
132
+ ) -> None:
133
+ """Unparseable stdin exits zero and never calls dispatch."""
134
+ all_calls: list[tuple[str, str]] = []
135
+ monkeypatch.setattr(sys, "stdin", io.StringIO("not json"))
136
+
137
+ with pytest.raises(SystemExit) as raised_exit:
138
+ run_dispatcher_main(lambda payload_text, tool_name: all_calls.append((payload_text, tool_name)))
139
+
140
+ assert int(raised_exit.value.code or 0) == 0
141
+ assert all_calls == []
142
+
143
+
144
+ def test_run_dispatcher_main_skips_dispatch_when_tool_name_is_missing(
145
+ monkeypatch: pytest.MonkeyPatch,
146
+ ) -> None:
147
+ """A payload with no tool_name exits zero and never calls dispatch."""
148
+ all_calls: list[tuple[str, str]] = []
149
+ monkeypatch.setattr(sys, "stdin", io.StringIO(json.dumps({"tool_input": {}})))
150
+
151
+ with pytest.raises(SystemExit) as raised_exit:
152
+ run_dispatcher_main(lambda payload_text, tool_name: all_calls.append((payload_text, tool_name)))
153
+
154
+ assert int(raised_exit.value.code or 0) == 0
155
+ assert all_calls == []
@@ -69,6 +69,7 @@ def test_apply_edits_mixes_replace_all_and_single_edits_in_one_list() -> None:
69
69
  ]
70
70
  assert apply_edits("a b a b", all_edits) == "A B A b"
71
71
 
72
+
72
73
  def test_joined_new_strings_joins_every_new_string_on_a_newline() -> None:
73
74
  """Each edit's introduced text reaches the scanner as its own line."""
74
75
  tool_input = {
@@ -68,3 +68,36 @@ def test_resolved_content_returns_empty_for_an_unreadable_edit_target(
68
68
  resolved_content({"file_path": str(missing_target), "old_string": "a", "new_string": "b"})
69
69
  == ""
70
70
  )
71
+
72
+
73
+ def test_reconstructed_edit_content_replaces_every_occurrence_when_replace_all_is_set(
74
+ tmp_path: pathlib.Path,
75
+ ) -> None:
76
+ """An Edit carrying replace_all rewrites every occurrence, as the tool does.
77
+
78
+ The MultiEdit branch has honored the flag since it moved onto apply_edits;
79
+ the Edit branch must agree, or one payload reconstructs two ways.
80
+ """
81
+ target_file = tmp_path / "module.py"
82
+ target_file.write_text("a = 1\na = 1\n", encoding="utf-8")
83
+ reconstructed = reconstructed_edit_content(
84
+ {
85
+ "file_path": str(target_file),
86
+ "old_string": "a = 1",
87
+ "new_string": "a = 2",
88
+ "replace_all": True,
89
+ }
90
+ )
91
+ assert reconstructed == "a = 2\na = 2\n"
92
+
93
+
94
+ def test_reconstructed_edit_content_replaces_one_occurrence_without_replace_all(
95
+ tmp_path: pathlib.Path,
96
+ ) -> None:
97
+ """Without the flag, only the first occurrence changes."""
98
+ target_file = tmp_path / "module.py"
99
+ target_file.write_text("a = 1\na = 1\n", encoding="utf-8")
100
+ reconstructed = reconstructed_edit_content(
101
+ {"file_path": str(target_file), "old_string": "a = 1", "new_string": "a = 2"}
102
+ )
103
+ assert reconstructed == "a = 2\na = 1\n"
@@ -23,7 +23,6 @@ touch each returns quietly.
23
23
  from __future__ import annotations
24
24
 
25
25
  import sys
26
- import tempfile
27
26
  from pathlib import Path
28
27
 
29
28
  _hooks_dir = str(Path(__file__).resolve().parent.parent)
@@ -33,18 +32,16 @@ if _hooks_dir not in sys.path:
33
32
  from hooks_constants.pr_description_writer_gate_constants import ( # noqa: E402
34
33
  ALL_AGENT_SPAWN_TOOL_NAMES,
35
34
  PR_DESCRIPTION_WRITER_SUBAGENT_TYPE,
36
- SPAWN_MARKER_FILE_PREFIX,
37
- SPAWN_MARKER_FILE_SUFFIX,
38
35
  SUBAGENT_TYPE_FIELD_NAME,
39
36
  TOOL_INPUT_FIELD_NAME,
40
37
  TOOL_NAME_FIELD_NAME,
41
38
  )
39
+ from hooks_constants.pr_description_writer_gate_constants import ( # noqa: E402
40
+ spawn_marker_path as shared_spawn_marker_path,
41
+ )
42
42
  from hooks_constants.pre_tool_use_stdin import ( # noqa: E402
43
43
  read_hook_input_dictionary_from_stdin,
44
44
  )
45
- from hooks_constants.session_edit_stage_gate_constants import ( # noqa: E402
46
- SESSION_ID_UNSAFE_CHARACTERS_PATTERN,
47
- )
48
45
 
49
46
 
50
47
  def spawn_marker_path(session_id: str, temp_directory: Path | None = None) -> Path | None:
@@ -70,12 +67,7 @@ def spawn_marker_path(session_id: str, temp_directory: Path | None = None) -> Pa
70
67
  Absolute path to this session's marker file, or None when the payload
71
68
  names no session this hook can key on.
72
69
  """
73
- sanitized_session_id = SESSION_ID_UNSAFE_CHARACTERS_PATTERN.sub("", session_id)
74
- if not sanitized_session_id:
75
- return None
76
- file_name = f"{SPAWN_MARKER_FILE_PREFIX}{sanitized_session_id}{SPAWN_MARKER_FILE_SUFFIX}"
77
- resolved_temp_directory = temp_directory or Path(tempfile.gettempdir())
78
- return resolved_temp_directory / file_name
70
+ return shared_spawn_marker_path(session_id, temp_directory)
79
71
 
80
72
 
81
73
  def _record_spawn(session_id: str) -> None:
@@ -18,13 +18,10 @@ never interrupts the edit that triggered it.
18
18
 
19
19
  from __future__ import annotations
20
20
 
21
- import contextlib
22
21
  import json
23
22
  import os
24
23
  import sys
25
24
  import tempfile
26
- import time
27
- from collections.abc import Iterator
28
25
  from pathlib import Path
29
26
 
30
27
  _hooks_dir = str(Path(__file__).resolve().parent.parent)
@@ -35,15 +32,13 @@ from blocking.codex_apply_patch import payload_patch_target_paths # noqa: E402
35
32
  from hooks_constants.pre_tool_use_stdin import ( # noqa: E402
36
33
  read_hook_input_dictionary_from_stdin,
37
34
  )
35
+ from hooks_constants.state_file_lock import hold_state_file_lock # noqa: E402
38
36
  from hooks_constants.session_edit_stage_gate_constants import ( # noqa: E402
39
37
  ALL_EDITED_FILE_PATHS_KEY,
40
38
  ALL_TRACKED_EDIT_TOOL_NAMES,
41
39
  APPLY_PATCH_TOOL_NAME,
42
- LOCK_ACQUIRE_RETRY_SECONDS,
43
- LOCK_ACQUIRE_TIMEOUT_SECONDS,
44
40
  SESSION_EDIT_FILE_PREFIX,
45
41
  SESSION_EDIT_FILE_SUFFIX,
46
- SESSION_EDIT_LOCK_FILE_SUFFIX,
47
42
  SESSION_ID_UNSAFE_CHARACTERS_PATTERN,
48
43
  STATE_FILE_ATOMIC_WRITE_SUFFIX,
49
44
  STATE_FILE_DEFAULT_SESSION_ID,
@@ -140,54 +135,6 @@ def _atomic_write_edit_file(edit_file: Path, all_edited_file_paths: list[str]) -
140
135
  raise
141
136
 
142
137
 
143
- def _acquire_edit_file_lock(lock_file: Path) -> int | None:
144
- """Grab an exclusive per-session lock, spinning until it frees or times out.
145
-
146
- Args:
147
- lock_file: Path to this session's lock file.
148
-
149
- Returns:
150
- An open file descriptor for the held lock, or None when the lock stayed
151
- held past the acquire timeout so the caller proceeds without it rather
152
- than stalling the edit that triggered the hook.
153
- """
154
- lock_acquire_deadline = time.monotonic() + LOCK_ACQUIRE_TIMEOUT_SECONDS
155
- while True:
156
- try:
157
- return os.open(str(lock_file), os.O_CREAT | os.O_EXCL | os.O_WRONLY)
158
- except FileExistsError:
159
- if time.monotonic() >= lock_acquire_deadline:
160
- return None
161
- time.sleep(LOCK_ACQUIRE_RETRY_SECONDS)
162
-
163
-
164
- @contextlib.contextmanager
165
- def _hold_edit_file_lock(edit_file: Path) -> Iterator[None]:
166
- """Hold the per-session lock across one read-modify-write of the tracker.
167
-
168
- Two PostToolUse invocations run concurrently when Claude issues parallel
169
- Write or Edit calls in one turn. Serializing the read-then-write on a shared
170
- lock file keeps each invocation's appended path from overwriting another's.
171
- The lock is best-effort: when it cannot be acquired within the timeout, the
172
- write proceeds without it rather than stalling the edit.
173
-
174
- Args:
175
- edit_file: This session's tracker file path.
176
-
177
- Yields:
178
- Control to the caller while the lock is held.
179
- """
180
- lock_file = edit_file.with_name(edit_file.name + SESSION_EDIT_LOCK_FILE_SUFFIX)
181
- lock_file.parent.mkdir(parents=True, exist_ok=True)
182
- lock_descriptor = _acquire_edit_file_lock(lock_file)
183
- try:
184
- yield
185
- finally:
186
- if lock_descriptor is not None:
187
- os.close(lock_descriptor)
188
- lock_file.unlink(missing_ok=True)
189
-
190
-
191
138
  def _record_edited_path(session_id: str, resolved_file_path: str) -> None:
192
139
  """Append one edited path to this session's tracker file when it is new.
193
140
 
@@ -200,7 +147,7 @@ def _record_edited_path(session_id: str, resolved_file_path: str) -> None:
200
147
  resolved_file_path: The resolved absolute path of the edited file.
201
148
  """
202
149
  edit_file = _session_edit_file_path(session_id)
203
- with _hold_edit_file_lock(edit_file):
150
+ with hold_state_file_lock(edit_file):
204
151
  recorded_paths = _read_recorded_paths(edit_file)
205
152
  if resolved_file_path in recorded_paths:
206
153
  return