claude-dev-env 1.37.0 → 1.38.0

package/skills/pr-converge/scripts/test_fetch_copilot_reviews.py

@@ -1,366 +0,0 @@
-"""Tests for fetch_copilot_reviews.
-
-Covers:
-- gh command uses --paginate --slurp (per gh-paginate rule)
-- per-page filter happens in Python after fetching all pages
-- only copilot-pull-request-reviewer[bot] reviews are returned
-- reviews are sorted newest-first by submitted_at
-- reviews with state APPROVED are classified "clean"
-- reviews with state CHANGES_REQUESTED or COMMENTED are classified "dirty"
-- subprocess errors propagate with stderr context
-"""
-
-from __future__ import annotations
-
-import importlib.util
-import json
-import subprocess
-from pathlib import Path
-from types import ModuleType
-from unittest.mock import MagicMock, patch
-
-import pytest
-
-
-def _load_module() -> ModuleType:
-    module_path = Path(__file__).parent / "fetch_copilot_reviews.py"
-    spec = importlib.util.spec_from_file_location("fetch_copilot_reviews", module_path)
-    assert spec is not None
-    assert spec.loader is not None
-    module = importlib.util.module_from_spec(spec)
-    spec.loader.exec_module(module)
-    return module
-
-
-fetch_copilot_reviews_module = _load_module()
-
-
-def _completed(stdout: str) -> subprocess.CompletedProcess:
-    process = MagicMock(spec=subprocess.CompletedProcess)
-    process.stdout = stdout
-    process.returncode = 0
-    return process
-
-
-def test_should_invoke_gh_with_paginate_slurp_against_reviews_endpoint() -> None:
-    pages_payload = json.dumps([[]])
-    with patch("subprocess.run") as mock_run:
-        mock_run.return_value = _completed(pages_payload)
-        fetch_copilot_reviews_module.fetch_copilot_reviews(
-            owner="acme", repo="widget", number=42
-        )
-    invoked_argv = mock_run.call_args[0][0]
-    assert invoked_argv[0] == "gh"
-    assert invoked_argv[1] == "api"
-    assert "repos/acme/widget/pulls/42/reviews?per_page=100" in invoked_argv[2]
-    assert "--paginate" in invoked_argv
-    assert "--slurp" in invoked_argv
-
-
-def test_should_filter_to_copilot_reviewer_only() -> None:
-    pages_payload = json.dumps(
-        [
-            [
-                {
-                    "id": 1,
-                    "user": {"login": "cursor[bot]"},
-                    "state": "COMMENTED",
-                    "commit_id": "abc",
-                    "submitted_at": "2026-01-01T00:00:00Z",
-                    "body": "bugbot stuff",
-                },
-                {
-                    "id": 2,
-                    "user": {"login": "copilot-pull-request-reviewer[bot]"},
-                    "state": "CHANGES_REQUESTED",
-                    "commit_id": "abc",
-                    "submitted_at": "2026-01-02T00:00:00Z",
-                    "body": "copilot finding",
-                },
-            ]
-        ]
-    )
-    with patch("subprocess.run") as mock_run:
-        mock_run.return_value = _completed(pages_payload)
-        all_reviews = fetch_copilot_reviews_module.fetch_copilot_reviews(
-            owner="acme", repo="widget", number=42
-        )
-    assert len(all_reviews) == 1
-    assert all_reviews[0]["review_id"] == 2
-
-
-def test_should_return_reviews_newest_first_across_pages() -> None:
-    pages_payload = json.dumps(
-        [
-            [
-                {
-                    "id": 10,
-                    "user": {"login": "copilot-pull-request-reviewer[bot]"},
-                    "state": "APPROVED",
-                    "commit_id": "old",
-                    "submitted_at": "2026-01-01T00:00:00Z",
-                    "body": "lgtm",
-                }
-            ],
-            [
-                {
-                    "id": 11,
-                    "user": {"login": "copilot-pull-request-reviewer[bot]"},
-                    "state": "CHANGES_REQUESTED",
-                    "commit_id": "new",
-                    "submitted_at": "2026-01-03T00:00:00Z",
-                    "body": "issues found",
-                },
-                {
-                    "id": 12,
-                    "user": {"login": "copilot-pull-request-reviewer[bot]"},
-                    "state": "APPROVED",
-                    "commit_id": "mid",
-                    "submitted_at": "2026-01-02T00:00:00Z",
-                    "body": "lgtm",
-                },
-            ],
-        ]
-    )
-    with patch("subprocess.run") as mock_run:
-        mock_run.return_value = _completed(pages_payload)
-        all_reviews = fetch_copilot_reviews_module.fetch_copilot_reviews(
-            owner="acme", repo="widget", number=42
-        )
-    submitted_at_sequence = [each_review["submitted_at"] for each_review in all_reviews]
-    assert submitted_at_sequence == [
-        "2026-01-03T00:00:00Z",
-        "2026-01-02T00:00:00Z",
-        "2026-01-01T00:00:00Z",
-    ]
-
-
-def test_should_classify_dirty_review_when_state_is_changes_requested() -> None:
-    pages_payload = json.dumps(
-        [
-            [
-                {
-                    "id": 1,
-                    "user": {"login": "copilot-pull-request-reviewer[bot]"},
-                    "state": "CHANGES_REQUESTED",
-                    "commit_id": "abc",
-                    "submitted_at": "2026-01-01T00:00:00Z",
-                    "body": "Issues need addressing.",
-                }
-            ]
-        ]
-    )
-    with patch("subprocess.run") as mock_run:
-        mock_run.return_value = _completed(pages_payload)
-        all_reviews = fetch_copilot_reviews_module.fetch_copilot_reviews(
-            owner="acme", repo="widget", number=42
-        )
-    assert all_reviews[0]["classification"] == "dirty"
-
-
-def test_should_classify_dirty_review_when_state_is_commented_with_body() -> None:
-    pages_payload = json.dumps(
-        [
-            [
-                {
-                    "id": 1,
-                    "user": {"login": "copilot-pull-request-reviewer[bot]"},
-                    "state": "COMMENTED",
-                    "commit_id": "abc",
-                    "submitted_at": "2026-01-01T00:00:00Z",
-                    "body": "Found a couple of nits inline.",
-                }
-            ]
-        ]
-    )
-    with patch("subprocess.run") as mock_run:
-        mock_run.return_value = _completed(pages_payload)
-        all_reviews = fetch_copilot_reviews_module.fetch_copilot_reviews(
-            owner="acme", repo="widget", number=42
-        )
-    assert all_reviews[0]["classification"] == "dirty"
-
-
-def test_should_classify_clean_review_when_state_is_commented_with_empty_body() -> None:
-    pages_payload = json.dumps(
-        [
-            [
-                {
-                    "id": 1,
-                    "user": {"login": "copilot-pull-request-reviewer[bot]"},
-                    "state": "COMMENTED",
-                    "commit_id": "abc",
-                    "submitted_at": "2026-01-01T00:00:00Z",
-                    "body": "",
-                }
-            ]
-        ]
-    )
-    with patch("subprocess.run") as mock_run:
-        mock_run.return_value = _completed(pages_payload)
-        all_reviews = fetch_copilot_reviews_module.fetch_copilot_reviews(
-            owner="acme", repo="widget", number=42
-        )
-    assert all_reviews[0]["classification"] == "clean"
-
-
-def test_should_dispatch_dirty_classification_off_copilot_dirty_review_states_tuple() -> None:
-    source_text = (
-        Path(__file__).resolve().parent / "reviewer_specs.py"
-    ).read_text(encoding="utf-8")
-    assert "ALL_COPILOT_DIRTY_REVIEW_STATES" in source_text
-    assert "all_dirty_states=ALL_COPILOT_DIRTY_REVIEW_STATES" in source_text
-
-
-def test_should_classify_clean_review_when_state_is_approved() -> None:
-    pages_payload = json.dumps(
-        [
-            [
-                {
-                    "id": 1,
-                    "user": {"login": "copilot-pull-request-reviewer[bot]"},
-                    "state": "APPROVED",
-                    "commit_id": "abc",
-                    "submitted_at": "2026-01-01T00:00:00Z",
-                    "body": "looks good",
-                }
-            ]
-        ]
-    )
-    with patch("subprocess.run") as mock_run:
-        mock_run.return_value = _completed(pages_payload)
-        all_reviews = fetch_copilot_reviews_module.fetch_copilot_reviews(
-            owner="acme", repo="widget", number=42
-        )
-    assert all_reviews[0]["classification"] == "clean"
-
-
-def test_should_match_login_case_insensitively() -> None:
-    pages_payload = json.dumps(
-        [
-            [
-                {
-                    "id": 1,
-                    "user": {"login": "Copilot"},
-                    "state": "CHANGES_REQUESTED",
-                    "commit_id": "abc",
-                    "submitted_at": "2026-01-01T00:00:00Z",
-                    "body": "uppercase login",
-                },
-                {
-                    "id": 2,
-                    "user": {"login": "GITHUB-COPILOT[bot]"},
-                    "state": "APPROVED",
-                    "commit_id": "abc",
-                    "submitted_at": "2026-01-02T00:00:00Z",
-                    "body": "screaming login",
-                },
-            ]
-        ]
-    )
-    with patch("subprocess.run") as mock_run:
-        mock_run.return_value = _completed(pages_payload)
-        all_reviews = fetch_copilot_reviews_module.fetch_copilot_reviews(
-            owner="acme", repo="widget", number=42
-        )
-    assert len(all_reviews) == 2
-    assert {each_review["review_id"] for each_review in all_reviews} == {1, 2}
-
-
-def test_should_match_login_containing_copilot_substring() -> None:
-    pages_payload = json.dumps(
-        [
-            [
-                {
-                    "id": 1,
-                    "user": {"login": "copilot-pull-request-reviewer[bot]"},
-                    "state": "CHANGES_REQUESTED",
-                    "commit_id": "abc",
-                    "submitted_at": "2026-01-01T00:00:00Z",
-                    "body": "canonical bot login",
-                },
-                {
-                    "id": 2,
-                    "user": {"login": "internal-copilot-fork[bot]"},
-                    "state": "CHANGES_REQUESTED",
-                    "commit_id": "abc",
-                    "submitted_at": "2026-01-02T00:00:00Z",
-                    "body": "non-canonical login still matches",
-                },
-            ]
-        ]
-    )
-    with patch("subprocess.run") as mock_run:
-        mock_run.return_value = _completed(pages_payload)
-        all_reviews = fetch_copilot_reviews_module.fetch_copilot_reviews(
-            owner="acme", repo="widget", number=42
-        )
-    assert {each_review["review_id"] for each_review in all_reviews} == {1, 2}
-
-
-def test_should_exclude_login_without_copilot_substring() -> None:
-    pages_payload = json.dumps(
-        [
-            [
-                {
-                    "id": 1,
-                    "user": {"login": "cursor[bot]"},
-                    "state": "CHANGES_REQUESTED",
-                    "commit_id": "abc",
-                    "submitted_at": "2026-01-01T00:00:00Z",
-                    "body": "wrong bot",
-                },
-                {
-                    "id": 2,
-                    "user": {"login": "dependabot[bot]"},
-                    "state": "CHANGES_REQUESTED",
-                    "commit_id": "abc",
-                    "submitted_at": "2026-01-02T00:00:00Z",
-                    "body": "also wrong",
-                },
-            ]
-        ]
-    )
-    with patch("subprocess.run") as mock_run:
-        mock_run.return_value = _completed(pages_payload)
-        all_reviews = fetch_copilot_reviews_module.fetch_copilot_reviews(
-            owner="acme", repo="widget", number=42
-        )
-    assert all_reviews == []
-
-
-def test_should_raise_when_gh_subprocess_fails() -> None:
-    failure = subprocess.CalledProcessError(
-        returncode=1, cmd=["gh"], stderr="auth failure"
-    )
-    with patch("subprocess.run", side_effect=failure):
-        with pytest.raises(subprocess.CalledProcessError):
-            fetch_copilot_reviews_module.fetch_copilot_reviews(
-                owner="acme", repo="widget", number=42
-            )
-
-
-def test_should_return_entries_whose_keys_are_strings() -> None:
-    pages_payload = json.dumps(
-        [
-            [
-                {
-                    "id": 1,
-                    "user": {"login": "copilot-pull-request-reviewer[bot]"},
-                    "state": "APPROVED",
-                    "commit_id": "abc",
-                    "submitted_at": "2026-01-01T00:00:00Z",
-                    "body": "looks good",
-                }
-            ]
-        ]
-    )
-    with patch("subprocess.run") as mock_run:
-        mock_run.return_value = _completed(pages_payload)
-        all_reviews = fetch_copilot_reviews_module.fetch_copilot_reviews(
-            owner="acme", repo="widget", number=42
-        )
-    assert len(all_reviews) == 1
-    first_review_entry = all_reviews[0]
-    assert isinstance(first_review_entry, dict)
-    assert all(isinstance(each_key, str) for each_key in first_review_entry.keys())

package/skills/pr-converge/scripts/test_mark_pr_ready.py

@@ -1,69 +0,0 @@
-"""Tests for mark_pr_ready.
-
-Covers:
-- gh pr ready is invoked with the PR number and --repo flag
-- subprocess errors propagate
-"""
-
-from __future__ import annotations
-
-import importlib.util
-import subprocess
-from pathlib import Path
-from types import ModuleType
-from unittest.mock import MagicMock, patch
-
-import pytest
-
-
-def _load_module() -> ModuleType:
-    module_path = Path(__file__).parent / "mark_pr_ready.py"
-    spec = importlib.util.spec_from_file_location("mark_pr_ready", module_path)
-    assert spec is not None
-    assert spec.loader is not None
-    module = importlib.util.module_from_spec(spec)
-    spec.loader.exec_module(module)
-    return module
-
-
-mark_pr_ready_module = _load_module()
-
-
-def _completed(stdout: str) -> subprocess.CompletedProcess:
-    process = MagicMock(spec=subprocess.CompletedProcess)
-    process.stdout = stdout
-    process.returncode = 0
-    return process
-
-
-def test_should_invoke_gh_pr_ready_with_number_and_repo() -> None:
-    with patch("subprocess.run") as mock_run:
-        mock_run.return_value = _completed('Pull request "#42" is marked as ready')
-        mark_pr_ready_module.mark_pr_ready(owner="acme", repo="widget", number=42)
-    invoked_argv = mock_run.call_args[0][0]
-    assert invoked_argv[0:3] == ["gh", "pr", "ready"]
-    assert "42" in invoked_argv
-    assert "--repo" in invoked_argv
-    assert "acme/widget" in invoked_argv
-
-
-def test_should_raise_when_gh_subprocess_fails() -> None:
-    failure = subprocess.CalledProcessError(
-        returncode=1, cmd=["gh"], stderr="auth failure"
-    )
-    with patch("subprocess.run", side_effect=failure):
-        with pytest.raises(subprocess.CalledProcessError):
-            mark_pr_ready_module.mark_pr_ready(owner="acme", repo="widget", number=42)
-
-
-def test_should_render_repo_arg_via_named_template_constant() -> None:
-    with patch("subprocess.run") as mock_run:
-        mock_run.return_value = _completed("ok\n")
-        mark_pr_ready_module.mark_pr_ready(owner="acme", repo="widget", number=42)
-    invoked_argv = mock_run.call_args[0][0]
-    expected_repo_arg = mark_pr_ready_module.GH_REPO_ARG_TEMPLATE.format(
-        owner="acme", repo="widget"
-    )
-    assert expected_repo_arg == "acme/widget"
-    repo_flag_index = invoked_argv.index("--repo")
-    assert invoked_argv[repo_flag_index + 1] == expected_repo_arg

package/skills/pr-converge/scripts/test_post_bugbot_run.py

@@ -1,195 +0,0 @@
-"""Tests for post-bugbot-run PowerShell helpers.
-
-Covers Resolve-InvocationMode / Build-GhArgumentList for URL, owner/repo#N, and
--Repository/-Number forms (Windows Bugbot re-trigger argv construction).
-"""
-
-from __future__ import annotations
-
-import json
-import os
-import subprocess
-import sys
-from pathlib import Path
-
-import pytest
-
-
-def _run_powershell(*, expression: str) -> str:
-    helpers = Path(__file__).resolve().parent / "post-bugbot-run.helpers.ps1"
-    command = (
-        f". '{helpers}'; "
-        + expression
-        + " | ConvertTo-Json -Compress -Depth 5"
-    )
-    completed = subprocess.run(
-        ["pwsh", "-NoProfile", "-NonInteractive", "-ExecutionPolicy", "Bypass", "-Command", command],
-        capture_output=True,
-        text=True,
-        encoding="utf-8",
-        errors="replace",
-        check=False,
-    )
-    if completed.returncode != 0:
-        raise AssertionError(
-            f"pwsh failed ({completed.returncode}): stderr={completed.stderr!r} stdout={completed.stdout!r}"
-        )
-    return completed.stdout.strip()
-
-
-def _argv_for(*, pull: str, repository: str, number: int, body: str) -> list[str]:
-    pull_esc = pull.replace("'", "''")
-    repository_esc = repository.replace("'", "''")
-    body_esc = body.replace("'", "''")
-    expression = (
-        f"$i = Resolve-InvocationMode -PullRequestInput '{pull_esc}' "
-        f"-RepositoryInput '{repository_esc}' -NumberInput {int(number)}; "
-        f"@(Build-GhArgumentList -Invocation $i -BodyFilePath '{body_esc}')"
-    )
-    raw = _run_powershell(expression=expression)
-    return json.loads(raw)
-
-
-def test_should_build_arguments_for_https_pull_url() -> None:
-    argv = _argv_for(
-        pull="https://github.com/acme/widget/pull/42",
-        repository="",
-        number=0,
-        body=r"C:\\temp\\body.md",
-    )
-    assert argv == [
-        "pr",
-        "comment",
-        "https://github.com/acme/widget/pull/42",
-        "--body-file",
-        r"C:\\temp\\body.md",
-    ]
-
-
-def test_should_build_arguments_for_owner_repo_hash_form() -> None:
-    argv = _argv_for(
-        pull="acme/widget#7",
-        repository="",
-        number=0,
-        body=r"D:\\x\\f.md",
-    )
-    assert argv == ["pr", "comment", "7", "-R", "acme/widget", "--body-file", r"D:\\x\\f.md"]
-
-
-def test_should_build_arguments_for_repository_and_number_parameters() -> None:
-    argv = _argv_for(
-        pull="",
-        repository="jl-cmd/claude-code-config",
-        number=331,
-        body=r"E:\\y\\z.md",
-    )
-    assert argv == [
-        "pr",
-        "comment",
-        "331",
-        "-R",
-        "jl-cmd/claude-code-config",
-        "--body-file",
-        r"E:\\y\\z.md",
-    ]
-
-
-def test_should_fail_when_number_without_repository() -> None:
-    helpers = Path(__file__).resolve().parent / "post-bugbot-run.helpers.ps1"
-    command = (
-        f". '{helpers}'; "
-        "try { Resolve-InvocationMode -PullRequestInput '' -RepositoryInput '' -NumberInput 3 } "
-        "catch { $_.Exception.Message }"
-    )
-    completed = subprocess.run(
-        ["pwsh", "-NoProfile", "-NonInteractive", "-ExecutionPolicy", "Bypass", "-Command", command],
-        capture_output=True,
-        text=True,
-        encoding="utf-8",
-        errors="replace",
-        check=False,
-    )
-    assert completed.returncode == 0
-    message = completed.stdout.strip()
-    assert "Repository" in message
-
-
-def test_should_reject_pull_url_with_trailing_junk() -> None:
-    helpers = Path(__file__).resolve().parent / "post-bugbot-run.helpers.ps1"
-    pull = "https://github.com/acme/widget/pull/42extra"
-    command = (
-        f". '{helpers}'; "
-        f"$i = Resolve-InvocationMode -PullRequestInput '{pull}' -RepositoryInput '' -NumberInput 0; "
-        r"try { Build-GhArgumentList -Invocation $i -BodyFilePath 'C:\\t\\b.md' } "
-        "catch { $_.Exception.Message }"
-    )
-    completed = subprocess.run(
-        ["pwsh", "-NoProfile", "-NonInteractive", "-ExecutionPolicy", "Bypass", "-Command", command],
-        capture_output=True,
-        text=True,
-        encoding="utf-8",
-        errors="replace",
-        check=False,
-    )
-    assert completed.returncode == 0
-    assert "Unrecognized PullRequest" in completed.stdout
-
-
-def test_should_fail_for_unrecognized_pull_string() -> None:
-    helpers = Path(__file__).resolve().parent / "post-bugbot-run.helpers.ps1"
-    pull = "not-a-valid-pr-reference"
-    command = (
-        f". '{helpers}'; "
-        f"$i = Resolve-InvocationMode -PullRequestInput '{pull}' -RepositoryInput '' -NumberInput 0; "
-        r"try { Build-GhArgumentList -Invocation $i -BodyFilePath 'C:\\t\\b.md' } "
-        "catch { $_.Exception.Message }"
-    )
-    completed = subprocess.run(
-        ["pwsh", "-NoProfile", "-NonInteractive", "-ExecutionPolicy", "Bypass", "-Command", command],
-        capture_output=True,
-        text=True,
-        encoding="utf-8",
-        errors="replace",
-        check=False,
-    )
-    assert completed.returncode == 0
-    assert "Unrecognized PullRequest" in completed.stdout
-
-
-def test_full_script_removes_temp_files_when_gh_stub_succeeds(tmp_path: Path) -> None:
-    scripts_dir = Path(__file__).resolve().parent
-    script_path = scripts_dir / "post-bugbot-run.ps1"
-    stub_bin_dir = tmp_path / "gh_stub_bin"
-    stub_bin_dir.mkdir()
-    gh_cmd = stub_bin_dir / "gh.cmd"
-    gh_cmd.write_text("@echo off\r\nexit /b 0\r\n", encoding="utf-8")
-    env = dict(os.environ)
-    env["PATH"] = str(stub_bin_dir) + os.pathsep + env.get("PATH", "")
-    completed = subprocess.run(
-        [
-            "pwsh",
-            "-NoProfile",
-            "-NonInteractive",
-            "-ExecutionPolicy",
-            "Bypass",
-            "-File",
-            str(script_path),
-            "acme/widget#9",
-        ],
-        capture_output=True,
-        text=True,
-        encoding="utf-8",
-        errors="replace",
-        env=env,
-        check=False,
-    )
-    assert completed.returncode == 0, (completed.stdout, completed.stderr)
-
-def test_post_bugbot_run_script_finally_removes_temp_paths() -> None:
-    script_text = (Path(__file__).resolve().parent / "post-bugbot-run.ps1").read_text(
-        encoding="utf-8"
-    )
-    assert "finally" in script_text
-    assert "Remove-Item" in script_text
-    assert "body_file_path" in script_text
-    assert "scratch_temp_path" in script_text