claude-dev-env 1.37.0 → 1.38.0

package/skills/pr-converge/scripts/test_fetch_copilot_inline_comments.py

@@ -1,440 +0,0 @@
-"""Tests for fetch_copilot_inline_comments.
-
-Covers:
-- gh command uses --paginate --slurp on the comments endpoint
-- only copilot-pull-request-reviewer[bot] inline comments are returned
-- comments not anchored to the requested commit are filtered out
-- comments on the same commit but from an older Copilot review are filtered out
-- multi-page responses are flattened correctly
-- subprocess errors propagate
-"""
-
-from __future__ import annotations
-
-import importlib.util
-import json
-import subprocess
-from pathlib import Path
-from types import ModuleType
-from unittest.mock import MagicMock, patch
-
-import pytest
-
-
-def _load_module() -> ModuleType:
-    module_path = Path(__file__).parent / "fetch_copilot_inline_comments.py"
-    spec = importlib.util.spec_from_file_location(
-        "fetch_copilot_inline_comments", module_path
-    )
-    assert spec is not None
-    assert spec.loader is not None
-    module = importlib.util.module_from_spec(spec)
-    spec.loader.exec_module(module)
-    return module
-
-
-fetch_copilot_inline_comments_module = _load_module()
-
-
-def _completed(stdout: str) -> subprocess.CompletedProcess:
-    process = MagicMock(spec=subprocess.CompletedProcess)
-    process.stdout = stdout
-    process.returncode = 0
-    return process
-
-
-def _default_review_for_head(*, commit: str, review_id: int) -> list[dict]:
-    return [
-        {
-            "review_id": review_id,
-            "commit_id": commit,
-            "submitted_at": "2026-01-01T00:00:00Z",
-            "state": "CHANGES_REQUESTED",
-            "body": "Please address the inline notes.",
-            "classification": "dirty",
-        }
-    ]
-
-
-def test_should_invoke_gh_with_paginate_slurp_against_comments_endpoint() -> None:
-    pages_payload = json.dumps([[]])
-    with (
-        patch.object(
-            fetch_copilot_inline_comments_module,
-            "fetch_copilot_reviews",
-            return_value=_default_review_for_head(commit="abc123", review_id=1),
-        ),
-        patch("subprocess.run") as mock_run,
-    ):
-        mock_run.return_value = _completed(pages_payload)
-        fetch_copilot_inline_comments_module.fetch_copilot_inline_comments(
-            owner="acme", repo="widget", number=42, current_head="abc123"
-        )
-    invoked_argv = mock_run.call_args[0][0]
-    assert invoked_argv[0] == "gh"
-    assert invoked_argv[1] == "api"
-    assert "repos/acme/widget/pulls/42/comments?per_page=100" in invoked_argv[2]
-    assert "--paginate" in invoked_argv
-    assert "--slurp" in invoked_argv
-
-
-def test_should_filter_to_copilot_reviewer_only() -> None:
-    pages_payload = json.dumps(
-        [
-            [
-                {
-                    "id": 100,
-                    "user": {"login": "cursor[bot]"},
-                    "commit_id": "abc123",
-                    "pull_request_review_id": 1,
-                    "body": "bugbot finding",
-                    "path": "x.py",
-                    "line": 5,
-                },
-                {
-                    "id": 101,
-                    "user": {"login": "copilot-pull-request-reviewer[bot]"},
-                    "commit_id": "abc123",
-                    "pull_request_review_id": 1,
-                    "body": "copilot finding",
-                    "path": "x.py",
-                    "line": 6,
-                },
-            ]
-        ]
-    )
-    with (
-        patch.object(
-            fetch_copilot_inline_comments_module,
-            "fetch_copilot_reviews",
-            return_value=_default_review_for_head(commit="abc123", review_id=1),
-        ),
-        patch("subprocess.run") as mock_run,
-    ):
-        mock_run.return_value = _completed(pages_payload)
-        all_inline_comments = (
-            fetch_copilot_inline_comments_module.fetch_copilot_inline_comments(
-                owner="acme", repo="widget", number=42, current_head="abc123"
-            )
-        )
-    assert len(all_inline_comments) == 1
-    assert all_inline_comments[0]["comment_id"] == 101
-
-
-def test_should_filter_out_comments_not_on_current_head() -> None:
-    pages_payload = json.dumps(
-        [
-            [
-                {
-                    "id": 200,
-                    "user": {"login": "copilot-pull-request-reviewer[bot]"},
-                    "commit_id": "old_sha",
-                    "pull_request_review_id": 1,
-                    "body": "stale finding",
-                    "path": "x.py",
-                    "line": 5,
-                },
-                {
-                    "id": 201,
-                    "user": {"login": "copilot-pull-request-reviewer[bot]"},
-                    "commit_id": "current_sha",
-                    "pull_request_review_id": 2,
-                    "body": "fresh finding",
-                    "path": "x.py",
-                    "line": 6,
-                },
-            ]
-        ]
-    )
-    with (
-        patch.object(
-            fetch_copilot_inline_comments_module,
-            "fetch_copilot_reviews",
-            return_value=_default_review_for_head(commit="current_sha", review_id=2),
-        ),
-        patch("subprocess.run") as mock_run,
-    ):
-        mock_run.return_value = _completed(pages_payload)
-        all_inline_comments = (
-            fetch_copilot_inline_comments_module.fetch_copilot_inline_comments(
-                owner="acme", repo="widget", number=42, current_head="current_sha"
-            )
-        )
-    assert len(all_inline_comments) == 1
-    assert all_inline_comments[0]["comment_id"] == 201
-
-
-def test_should_ignore_inline_comments_from_older_copilot_review_on_same_commit() -> (
-    None
-):
-    pages_payload = json.dumps(
-        [
-            [
-                {
-                    "id": 300,
-                    "user": {"login": "copilot-pull-request-reviewer[bot]"},
-                    "commit_id": "same_sha",
-                    "pull_request_review_id": 10,
-                    "body": "stale dirty thread",
-                    "path": "x.py",
-                    "line": 1,
-                },
-                {
-                    "id": 301,
-                    "user": {"login": "copilot-pull-request-reviewer[bot]"},
-                    "commit_id": "same_sha",
-                    "pull_request_review_id": 11,
-                    "body": "current clean thread",
-                    "path": "x.py",
-                    "line": 2,
-                },
-            ]
-        ]
-    )
-    reviews_newest_first = [
-        {
-            "review_id": 11,
-            "commit_id": "same_sha",
-            "submitted_at": "2026-01-02T00:00:00Z",
-            "state": "APPROVED",
-            "body": "lgtm",
-            "classification": "clean",
-        },
-        {
-            "review_id": 10,
-            "commit_id": "same_sha",
-            "submitted_at": "2026-01-01T00:00:00Z",
-            "state": "CHANGES_REQUESTED",
-            "body": "fix the thing",
-            "classification": "dirty",
-        },
-    ]
-    with (
-        patch.object(
-            fetch_copilot_inline_comments_module,
-            "fetch_copilot_reviews",
-            return_value=reviews_newest_first,
-        ),
-        patch("subprocess.run") as mock_run,
-    ):
-        mock_run.return_value = _completed(pages_payload)
-        all_inline_comments = (
-            fetch_copilot_inline_comments_module.fetch_copilot_inline_comments(
-                owner="acme", repo="widget", number=42, current_head="same_sha"
-            )
-        )
-    assert [each_comment["comment_id"] for each_comment in all_inline_comments] == [301]
-
-
-def test_should_return_empty_when_no_copilot_review_exists_for_commit() -> None:
-    with (
-        patch.object(
-            fetch_copilot_inline_comments_module,
-            "fetch_copilot_reviews",
-            return_value=[
-                {
-                    "review_id": 1,
-                    "commit_id": "other_sha",
-                    "submitted_at": "2026-01-01T00:00:00Z",
-                    "state": "APPROVED",
-                    "body": "",
-                    "classification": "clean",
-                }
-            ],
-        ),
-        patch("subprocess.run") as mock_run,
-    ):
-        all_inline_comments = (
-            fetch_copilot_inline_comments_module.fetch_copilot_inline_comments(
-                owner="acme", repo="widget", number=42, current_head="missing_sha"
-            )
-        )
-    assert all_inline_comments == []
-    mock_run.assert_not_called()
-
-
-def test_should_flatten_across_pages() -> None:
-    pages_payload = json.dumps(
-        [
-            [
-                {
-                    "id": 1,
-                    "user": {"login": "copilot-pull-request-reviewer[bot]"},
-                    "commit_id": "abc",
-                    "pull_request_review_id": 9,
-                    "body": "a",
-                    "path": "f.py",
-                    "line": 1,
-                }
-            ],
-            [
-                {
-                    "id": 2,
-                    "user": {"login": "copilot-pull-request-reviewer[bot]"},
-                    "commit_id": "abc",
-                    "pull_request_review_id": 9,
-                    "body": "b",
-                    "path": "f.py",
-                    "line": 2,
-                },
-                {
-                    "id": 3,
-                    "user": {"login": "copilot-pull-request-reviewer[bot]"},
-                    "commit_id": "abc",
-                    "pull_request_review_id": 9,
-                    "body": "c",
-                    "path": "f.py",
-                    "line": 3,
-                },
-            ],
-        ]
-    )
-    with (
-        patch.object(
-            fetch_copilot_inline_comments_module,
-            "fetch_copilot_reviews",
-            return_value=_default_review_for_head(commit="abc", review_id=9),
-        ),
-        patch("subprocess.run") as mock_run,
-    ):
-        mock_run.return_value = _completed(pages_payload)
-        all_inline_comments = (
-            fetch_copilot_inline_comments_module.fetch_copilot_inline_comments(
-                owner="acme", repo="widget", number=42, current_head="abc"
-            )
-        )
-    assert [each_comment["comment_id"] for each_comment in all_inline_comments] == [
-        1,
-        2,
-        3,
-    ]
-
-
-def test_should_match_login_case_insensitively() -> None:
-    pages_payload = json.dumps(
-        [
-            [
-                {
-                    "id": 300,
-                    "user": {"login": "Copilot"},
-                    "commit_id": "abc123",
-                    "pull_request_review_id": 1,
-                    "body": "uppercase login",
-                    "path": "x.py",
-                    "line": 5,
-                },
-                {
-                    "id": 301,
-                    "user": {"login": "GITHUB-COPILOT[bot]"},
-                    "commit_id": "abc123",
-                    "pull_request_review_id": 1,
-                    "body": "screaming login",
-                    "path": "x.py",
-                    "line": 6,
-                },
-            ]
-        ]
-    )
-    with (
-        patch.object(
-            fetch_copilot_inline_comments_module,
-            "fetch_copilot_reviews",
-            return_value=_default_review_for_head(commit="abc123", review_id=1),
-        ),
-        patch("subprocess.run") as mock_run,
-    ):
-        mock_run.return_value = _completed(pages_payload)
-        all_inline_comments = (
-            fetch_copilot_inline_comments_module.fetch_copilot_inline_comments(
-                owner="acme", repo="widget", number=42, current_head="abc123"
-            )
-        )
-    assert {each_comment["comment_id"] for each_comment in all_inline_comments} == {300, 301}
-
-
-def test_should_match_login_containing_copilot_substring() -> None:
-    pages_payload = json.dumps(
-        [
-            [
-                {
-                    "id": 400,
-                    "user": {"login": "internal-copilot-fork[bot]"},
-                    "commit_id": "abc123",
-                    "pull_request_review_id": 1,
-                    "body": "non-canonical login still matches",
-                    "path": "x.py",
-                    "line": 5,
-                }
-            ]
-        ]
-    )
-    with (
-        patch.object(
-            fetch_copilot_inline_comments_module,
-            "fetch_copilot_reviews",
-            return_value=_default_review_for_head(commit="abc123", review_id=1),
-        ),
-        patch("subprocess.run") as mock_run,
-    ):
-        mock_run.return_value = _completed(pages_payload)
-        all_inline_comments = (
-            fetch_copilot_inline_comments_module.fetch_copilot_inline_comments(
-                owner="acme", repo="widget", number=42, current_head="abc123"
-            )
-        )
-    assert len(all_inline_comments) == 1
-    assert all_inline_comments[0]["comment_id"] == 400
-
-
-def test_should_raise_when_gh_subprocess_fails() -> None:
-    failure = subprocess.CalledProcessError(
-        returncode=1, cmd=["gh"], stderr="auth failure"
-    )
-    with (
-        patch.object(
-            fetch_copilot_inline_comments_module,
-            "fetch_copilot_reviews",
-            return_value=_default_review_for_head(commit="abc", review_id=1),
-        ),
-        patch("subprocess.run", side_effect=failure),
-    ):
-        with pytest.raises(subprocess.CalledProcessError):
-            fetch_copilot_inline_comments_module.fetch_copilot_inline_comments(
-                owner="acme", repo="widget", number=42, current_head="abc"
-            )
-
-
-def test_should_return_entries_whose_keys_are_strings() -> None:
-    pages_payload = json.dumps(
-        [
-            [
-                {
-                    "id": 101,
-                    "user": {"login": "copilot-pull-request-reviewer[bot]"},
-                    "commit_id": "abc123",
-                    "pull_request_review_id": 1,
-                    "body": "copilot finding",
-                    "path": "x.py",
-                    "line": 6,
-                }
-            ]
-        ]
-    )
-    with (
-        patch.object(
-            fetch_copilot_inline_comments_module,
-            "fetch_copilot_reviews",
-            return_value=_default_review_for_head(commit="abc123", review_id=1),
-        ),
-        patch("subprocess.run") as mock_run,
-    ):
-        mock_run.return_value = _completed(pages_payload)
-        all_inline_comments = (
-            fetch_copilot_inline_comments_module.fetch_copilot_inline_comments(
-                owner="acme", repo="widget", number=42, current_head="abc123"
-            )
-        )
-    assert len(all_inline_comments) == 1
-    first_comment_entry = all_inline_comments[0]
-    assert isinstance(first_comment_entry, dict)
-    assert all(isinstance(each_key, str) for each_key in first_comment_entry.keys())