claude-dev-env 1.35.0 → 1.36.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/agents/clean-coder.md +109 -1
- package/bin/install.mjs +28 -8
- package/bin/install.test.mjs +9 -1
- package/docs/CODE_RULES.md +3 -0
- package/docs/agents-md-alignment-plan.md +123 -0
- package/hooks/blocking/code_rules_enforcer.py +451 -39
- package/hooks/blocking/es_exe_path_rewriter.py +10 -4
- package/hooks/blocking/test_code_rules_enforcer.py +182 -0
- package/hooks/blocking/test_code_rules_enforcer_banned_identifier.py +106 -0
- package/hooks/blocking/test_code_rules_enforcer_cap_meta.py +173 -0
- package/hooks/blocking/test_code_rules_enforcer_collection_prefix.py +191 -0
- package/hooks/blocking/test_code_rules_enforcer_constant_equality.py +40 -0
- package/hooks/blocking/test_code_rules_enforcer_hardcoded_user_path.py +291 -0
- package/hooks/blocking/test_code_rules_enforcer_loop_variable_naming.py +87 -3
- package/hooks/blocking/test_code_rules_enforcer_naming_pattern.py +49 -0
- package/hooks/blocking/test_code_rules_enforcer_sys_path_insert.py +157 -0
- package/hooks/blocking/test_code_rules_enforcer_unused_imports.py +244 -0
- package/hooks/blocking/test_es_exe_path_rewriter.py +81 -3
- package/hooks/blocking/test_windows_rmtree_blocker.py +120 -8
- package/hooks/blocking/windows_rmtree_blocker.py +23 -6
- package/hooks/config/banned_identifiers_constants.py +24 -0
- package/hooks/config/hardcoded_user_path_constants.py +12 -0
- package/hooks/config/hook_log_extractor_constants.py +1 -1
- package/hooks/config/pre_tool_use_stdin.py +48 -0
- package/hooks/config/setup_project_paths_constants.py +4 -0
- package/hooks/config/stuttering_check_config.py +14 -0
- package/hooks/config/stuttering_import_binding_constants.py +11 -0
- package/hooks/config/sys_path_insert_constants.py +4 -0
- package/hooks/config/test_banned_identifiers_constants.py +48 -0
- package/hooks/config/test_hardcoded_user_path_constants.py +78 -0
- package/hooks/config/test_hook_log_extractor_constants.py +3 -3
- package/hooks/config/test_pre_tool_use_stdin.py +80 -0
- package/hooks/config/unused_module_import_constants.py +7 -0
- package/hooks/config/windows_rmtree_blocker_constants.py +3 -0
- package/hooks/diagnostic/hook_log_stop_wrapper.py +7 -4
- package/hooks/git-hooks/config.py +3 -3
- package/hooks/git-hooks/test_gate_utils.py +10 -10
- package/hooks/mypy.ini +2 -0
- package/package.json +1 -1
- package/rules/gh-paginate.md +125 -0
- package/skills/bugteam/CONSTRAINTS.md +12 -6
- package/skills/bugteam/SKILL.md +77 -91
- package/skills/bugteam/SKILL_EVALS.md +25 -23
- package/skills/bugteam/reference/README.md +2 -0
- package/skills/bugteam/reference/audit-and-teammates.md +2 -2
- package/skills/bugteam/reference/teardown-publish-permissions.md +1 -1
- package/skills/bugteam/reference/workflow-path-a-orchestrated-teams.md +113 -0
- package/skills/bugteam/reference/workflow-path-b-task-harness.md +48 -0
- package/skills/bugteam/test_skill_additions.py +13 -4
- package/skills/bugteam/test_team_lifecycle.py +94 -0
- package/skills/findbugs/SKILL.md +3 -3
- package/skills/fixbugs/SKILL.md +4 -4
- package/skills/monitor-open-prs/SKILL.md +32 -2
- package/skills/monitor-open-prs/test_team_lifecycle.py +46 -0
- package/skills/pr-converge/SKILL.md +562 -97
- package/skills/pr-converge/scripts/README.md +145 -0
- package/skills/pr-converge/scripts/caller-window-pid.ps1 +86 -0
- package/skills/pr-converge/scripts/check_pr_mergeability.py +79 -0
- package/skills/pr-converge/scripts/config/pr_converge_constants.py +65 -0
- package/skills/pr-converge/scripts/config/test_pr_converge_constants.py +176 -0
- package/skills/pr-converge/scripts/cursor-agents-continue-caller.cmd +9 -0
- package/skills/pr-converge/scripts/cursor-agents-continue-stop-others.ps1 +16 -0
- package/skills/pr-converge/scripts/cursor-agents-continue.ahk +172 -0
- package/skills/pr-converge/scripts/cursor-agents-continue.cmd +2 -0
- package/skills/pr-converge/scripts/evict_cached_config_modules.py +20 -0
- package/skills/pr-converge/scripts/fetch_bugbot_inline_comments.py +110 -0
- package/skills/pr-converge/scripts/fetch_bugbot_reviews.py +103 -0
- package/skills/pr-converge/scripts/fetch_copilot_inline_comments.py +112 -0
- package/skills/pr-converge/scripts/fetch_copilot_reviews.py +121 -0
- package/skills/pr-converge/scripts/mark_pr_ready.py +54 -0
- package/skills/pr-converge/scripts/open_followup_copilot_pr.py +136 -0
- package/skills/pr-converge/scripts/post-bugbot-run.helpers.ps1 +49 -0
- package/skills/pr-converge/scripts/post-bugbot-run.ps1 +33 -0
- package/skills/pr-converge/scripts/reply_to_inline_comment.py +84 -0
- package/skills/pr-converge/scripts/request_copilot_review.py +71 -0
- package/skills/pr-converge/scripts/resolve_pr_head.py +58 -0
- package/skills/pr-converge/scripts/review_field_helpers.py +43 -0
- package/skills/pr-converge/scripts/test_check_pr_mergeability.py +126 -0
- package/skills/pr-converge/scripts/test_evict_cached_config_modules.py +22 -0
- package/skills/pr-converge/scripts/test_fetch_bugbot_inline_comments.py +342 -0
- package/skills/pr-converge/scripts/test_fetch_bugbot_reviews.py +220 -0
- package/skills/pr-converge/scripts/test_fetch_copilot_inline_comments.py +372 -0
- package/skills/pr-converge/scripts/test_fetch_copilot_reviews.py +280 -0
- package/skills/pr-converge/scripts/test_mark_pr_ready.py +69 -0
- package/skills/pr-converge/scripts/test_open_followup_copilot_pr.py +236 -0
- package/skills/pr-converge/scripts/test_post_bugbot_run.py +195 -0
- package/skills/pr-converge/scripts/test_reply_to_inline_comment.py +159 -0
- package/skills/pr-converge/scripts/test_request_copilot_review.py +101 -0
- package/skills/pr-converge/scripts/test_resolve_pr_head.py +79 -0
- package/skills/pr-converge/scripts/test_review_field_helpers.py +80 -0
- package/skills/pr-converge/scripts/test_trigger_bugbot.py +139 -0
- package/skills/pr-converge/scripts/test_view_pr_context.py +111 -0
- package/skills/pr-converge/scripts/trigger_bugbot.py +77 -0
- package/skills/pr-converge/scripts/view_pr_context.py +47 -0
- package/skills/pr-converge/test_team_lifecycle.py +47 -0
- package/skills/pr-converge/workflows/ahk-auto-continue-loop.md +108 -0
- package/skills/pr-converge/workflows/schedule-wakeup-loop.md +37 -0
- package/skills/qbug/SKILL.md +4 -4
- package/skills/qbug/test_qbug_skill_post_fix_audit.py +2 -2
- package/skills/resume-review/SKILL.md +261 -0
- package/skills/bugteam/scripts/README.md +0 -58
- package/skills/bugteam/scripts/_claude_permissions_common.py +0 -219
- package/skills/bugteam/scripts/bugteam_code_rules_gate.py +0 -633
- package/skills/bugteam/scripts/bugteam_fix_hookspath.py +0 -260
- package/skills/bugteam/scripts/bugteam_preflight.py +0 -201
- package/skills/bugteam/scripts/config/bugteam_fix_hookspath_constants.py +0 -17
- package/skills/bugteam/scripts/grant_project_claude_permissions.py +0 -109
- package/skills/bugteam/scripts/revoke_project_claude_permissions.py +0 -135
- package/skills/bugteam/scripts/test_bugteam_code_rules_gate.py +0 -271
- package/skills/bugteam/scripts/test_bugteam_fix_hookspath.py +0 -267
- package/skills/bugteam/scripts/test_bugteam_preflight.py +0 -189
- package/skills/bugteam/scripts/test_claude_permissions_common.py +0 -44
- /package/skills/{bugteam → pr-converge}/scripts/config/__init__.py +0 -0
|
@@ -0,0 +1,108 @@
|
|
|
1
|
+
# AHK auto-continue loop pacing (pr-converge)
|
|
2
|
+
|
|
3
|
+
Load this document when **`ScheduleWakeup` is not available** in this session (orchestrated teams disabled, restricted tool registry, Cursor
|
|
4
|
+
without that primitive, or the user wants a visibly-running pacer). Follow it for **every** instruction below that depends on that choice.
|
|
5
|
+
Shared bugbot / bugteam / Fix protocol steps stay in the main `SKILL.md`.
|
|
6
|
+
|
|
7
|
+
## Session behavior
|
|
8
|
+
|
|
9
|
+
Keep ticks in the **same** window the auto-typer targets so each `continue` re-enters here and reads the same state line and `gh` context.
|
|
10
|
+
|
|
11
|
+
## Why this path exists
|
|
12
|
+
|
|
13
|
+
It is not a separate "mode" the user must remember — bare `/pr-converge` already implies loop-until-done; when the primary wakeup tool is
|
|
14
|
+
missing, fall through to AHK automatically. The per-tick work is unchanged; what changes is who fires the next tick. Instead of
|
|
15
|
+
`ScheduleWakeup` re-entering the skill, an external AutoHotkey utility auto-types `continue` into the active Claude Code window every 5
|
|
16
|
+
minutes, and the model treats each `continue` as the next tick trigger.
|
|
17
|
+
|
|
18
|
+
**AHK is loop pacing only:** every `phase == BUGTEAM` tick still runs **`/bugteam`** via the bugteam skill per Step 2 of the main skill —
|
|
19
|
+
nothing here replaces that audit.
|
|
20
|
+
|
|
21
|
+
**Fix protocol** commits use **`Task`** with **`subagent_type: "generalPurpose"`** and the **clean-coder preamble** from the main
|
|
22
|
+
[`SKILL.md` Fix protocol](../SKILL.md#fix-protocol) section (same as ScheduleWakeup pacing — Cursor has no `clean-coder` `subagent_type`).
|
|
23
|
+
|
|
24
|
+
Ensure `~/.claude/agents/clean-coder.md` exists (Windows: `%USERPROFILE%\.claude\agents\clean-coder.md`). Optionally also copy it to
|
|
25
|
+
`.cursor/agents/clean-coder.md` in the repo when you want the file co-located with the checkout; the spawn **prompt** must still name the
|
|
26
|
+
absolute path the subagent should **Read** first.
|
|
27
|
+
|
|
28
|
+
### One-time setup at the start of the loop
|
|
29
|
+
|
|
30
|
+
The skill bundles its driver scripts under `scripts/` and resolves them at runtime via `$HOME\.claude\skills\pr-converge\scripts\…` (the same
|
|
31
|
+
convention `/logifix` uses). The bundled `.cmd` launchers locate their siblings via `%~dp0`, so they need no path arguments — only the AHK
|
|
32
|
+
target PID.
|
|
33
|
+
|
|
34
|
+
Run these two commands in order (PowerShell-friendly Bash escaping):
|
|
35
|
+
|
|
36
|
+
1. Resolve the PID of the GUI ancestor that hosts this Claude Code session:
|
|
37
|
+
```bash
|
|
38
|
+
pwsh -NoProfile -ExecutionPolicy Bypass -File "$HOME\.claude\skills\pr-converge\scripts\caller-window-pid.ps1"
|
|
39
|
+
```
|
|
40
|
+
Capture the printed integer as `caller_pid`. Verify it points at the right window before continuing:
|
|
41
|
+
```bash
|
|
42
|
+
pwsh -NoProfile -Command "Get-Process -Id $caller_pid | Select-Object Id,ProcessName,MainWindowTitle"
|
|
43
|
+
```
|
|
44
|
+
2. Launch the auto-typer attached to that PID with auto-start enabled. The bundled launcher accepts the PID as its first arg and the
|
|
45
|
+
`--start-on` flag is forwarded to the AHK script:
|
|
46
|
+
```bash
|
|
47
|
+
"$HOME\.claude\skills\pr-converge\scripts\cursor-agents-continue.cmd" $caller_pid --start-on
|
|
48
|
+
```
|
|
49
|
+
AutoHotkey v2 must be installed at `C:\Program Files\AutoHotkey\v2\AutoHotkey64.exe`.
|
|
50
|
+
|
|
51
|
+
### Per-tick behavior under this driver
|
|
52
|
+
|
|
53
|
+
- Run Steps 1–3 of **Per-tick work** in the main `SKILL.md` exactly as written.
|
|
54
|
+
- In **Step 4**, do **not** call `ScheduleWakeup` — the auto-typer is the pacer (this is the fallback branch of Step 4 in the main skill).
|
|
55
|
+
- End every assistant response with the literal sentence `Awaiting next "continue" tick.` so the next iteration is unambiguously identifiable
|
|
56
|
+
in the transcript.
|
|
57
|
+
- When the next user message is `continue` (auto-typed by AHK) or any close paraphrase, treat it as the next tick of default-loop
|
|
58
|
+
`/pr-converge` and re-enter from Step 1 against the freshest PR state.
|
|
59
|
+
|
|
60
|
+
### Convergence cleanup
|
|
61
|
+
|
|
62
|
+
On back-to-back clean (the existing convergence rule in the main skill), run `gh pr ready`, then kill the auto-typer when this session used
|
|
63
|
+
this AHK pacing path:
|
|
64
|
+
|
|
65
|
+
```bash
|
|
66
|
+
pwsh -NoProfile -Command "Get-CimInstance Win32_Process -Filter \"Name='AutoHotkey64.exe'\" | Where-Object CommandLine -like '*cursor-agents-continue.ahk*' | ForEach-Object { Stop-Process -Id $_.ProcessId -Force }"
|
|
67
|
+
```
|
|
68
|
+
|
|
69
|
+
Report convergence in the same one-sentence shape as the standard flow, plus a second sentence noting the auto-typer was stopped. The skill
|
|
70
|
+
returns; no next tick fires.
|
|
71
|
+
|
|
72
|
+
### Gotchas
|
|
73
|
+
|
|
74
|
+
- **Resolver fallback semantics matter.** `caller-window-pid.ps1` walks up the parent process chain, terminates at `explorer.exe`, and falls
|
|
75
|
+
back to the foreground window when no GUI ancestor is found. Always verify `MainWindowTitle` after capture — if it isn't the Claude Code
|
|
76
|
+
session, the auto-typer will fire `continue` into the wrong window and the loop stalls silently.
|
|
77
|
+
- **Tick-duration vs. 5-minute cadence.** The auto-typer fires every 5 minutes regardless of model activity. A tick that runs longer than 5
|
|
78
|
+
minutes will receive a queued `continue` while still in flight; Claude Code processes these sequentially, so there's no corruption, but the
|
|
79
|
+
loop pace becomes irregular. Don't try to "fix" this by shortening the AHK interval — the `bugbot run` cadence already has its own pacing
|
|
80
|
+
baked into the standard flow.
|
|
81
|
+
- **AHK runs as `#SingleInstance Force`.** Re-running the launcher replaces the prior instance silently. Safe to re-issue if the loop appears
|
|
82
|
+
stalled.
|
|
83
|
+
- **`Stop-Process -Force` on `AutoHotkey64` is broad.** It kills every AHK instance, not just the one this skill started. When the user has
|
|
84
|
+
unrelated AHK utilities running, scope the kill by command-line match instead:
|
|
85
|
+
```bash
|
|
86
|
+
pwsh -NoProfile -Command "Get-CimInstance Win32_Process -Filter \"Name='AutoHotkey64.exe'\" | Where-Object CommandLine -like '*cursor-agents-continue.ahk*' | ForEach-Object { Stop-Process -Id $_.ProcessId -Force }"
|
|
87
|
+
```
|
|
88
|
+
- **State-line responsibility is unchanged.** The state line (phase, bugbot_clean_at, inline_lag_streak, tick_count) is still emitted at the
|
|
89
|
+
end of every tick — it's how the next tick reads prior state. The auto-typer only fires `continue`; it does not preserve state for you.
|
|
90
|
+
- **No `tick_count` ceiling.** `tick_count` is observability-only (same as the main skill and `state-schema.md`). This path ends on convergence or **Stop conditions** in `SKILL.md`, not on a tick counter.
|
|
91
|
+
- **`/bugteam` is not optional for BUGTEAM ticks.** AHK only paces **when** the next tick runs; it does not replace the bugteam skill. Skipping
|
|
92
|
+
**`/bugteam`** after a clean Bugbot review breaks the back-to-back contract.
|
|
93
|
+
- **Fix protocol:** use **`Task` + `generalPurpose`** with the clean-coder **Read** preamble from the main [`SKILL.md` Fix protocol](../SKILL.md#fix-protocol)
|
|
94
|
+
(never a bare `generalPurpose` production edit). Ensure the clean-coder agent markdown exists at `~/.claude/agents/clean-coder.md` (Windows:
|
|
95
|
+
`%USERPROFILE%\.claude\agents\clean-coder.md`); copy into `.cursor/agents/` only if you want a repo-local duplicate.
|
|
96
|
+
|
|
97
|
+
## BUGBOT inline-lag (this path only)
|
|
98
|
+
|
|
99
|
+
When Step 2 BUGBOT branch c routes to API lag and you are on **this** pacing path: complete Step 4 per **Per-tick behavior under this driver**
|
|
100
|
+
above (fixed AHK cadence — there is no 60s shortcut). The inline comments should appear on the next tick.
|
|
101
|
+
|
|
102
|
+
## Convergence
|
|
103
|
+
|
|
104
|
+
On back-to-back clean: stop the auto-typer per **Convergence cleanup** above; omit `ScheduleWakeup` (not used on this path).
|
|
105
|
+
|
|
106
|
+
## Stop / safety (this path)
|
|
107
|
+
|
|
108
|
+
On hard blockers or user stop: omit loop pacing and stop the AHK auto-typer if it was started, per main skill **Stop conditions**. Use the same **scoped** `Get-CimInstance` / `Stop-Process` command as **Convergence cleanup** (command-line match on `cursor-agents-continue.ahk`) so unrelated AutoHotkey instances are not killed.
|
|
@@ -0,0 +1,37 @@
|
|
|
1
|
+
# ScheduleWakeup loop pacing (pr-converge)
|
|
2
|
+
|
|
3
|
+
Load this document when **`ScheduleWakeup` is available** in the parent harness session and you use it for converge **loop pacing** (primary /
|
|
4
|
+
orchestrated-teams path). Follow it for **every** instruction below that depends on that choice. Shared bugbot / bugteam / Fix protocol steps
|
|
5
|
+
stay in the main `SKILL.md`.
|
|
6
|
+
|
|
7
|
+
## Session behavior
|
|
8
|
+
|
|
9
|
+
Call `ScheduleWakeup` from this same session so the next tick fires back into **this** transcript with the prior tick's state line and PR
|
|
10
|
+
context still addressable.
|
|
11
|
+
|
|
12
|
+
## Step 4 — `ScheduleWakeup` branch
|
|
13
|
+
|
|
14
|
+
At end of tick (unless convergence or another stop condition already omitted pacing), call `ScheduleWakeup` with:
|
|
15
|
+
|
|
16
|
+
- `delaySeconds: 270` whenever bugbot was just re-triggered (whether by Step 3 directly, by the Fix protocol's mandatory re-trigger, or by
|
|
17
|
+
BUGTEAM branch 1's same-tick re-trigger). Bugbot finishes a review in 1–4 minutes, so 270s stays under the 5-minute prompt-cache TTL while
|
|
18
|
+
giving a margin past bugbot's typical upper bound. The single exception is the BUGBOT inline-lag branch in Step 2 of the main skill, which
|
|
19
|
+
uses `delaySeconds: 60` because no re-trigger fired and the only thing being awaited is GitHub's inline-comments API catching up.
|
|
20
|
+
- `reason`: one short sentence on what is being awaited, including the current `phase` and `bugbot_clean_at` SHA when set.
|
|
21
|
+
- `prompt: "/pr-converge"` — re-enters this skill on the next firing with default loop semantics (no need for the user to type `/loop`). If
|
|
22
|
+
the parent harness requires the `/loop` wrapper for wakeups to execute, `prompt: "/loop /pr-converge"` is equivalent.
|
|
23
|
+
|
|
24
|
+
## BUGBOT inline-lag (this path only)
|
|
25
|
+
|
|
26
|
+
When Step 2 BUGBOT branch c routes to API lag and you are on **this** pacing path: complete Step 4 with `ScheduleWakeup` using `delaySeconds:
|
|
27
|
+
60` (lag is short-lived).
|
|
28
|
+
|
|
29
|
+
## Convergence
|
|
30
|
+
|
|
31
|
+
On back-to-back clean: **omit** further `ScheduleWakeup` calls. Do not start the AHK auto-typer for loop pacing when this path is the active
|
|
32
|
+
pacer.
|
|
33
|
+
|
|
34
|
+
## Stop / safety (this path)
|
|
35
|
+
|
|
36
|
+
On hard blockers or user stop: omit `ScheduleWakeup` per main skill **Stop conditions**. If the session never used AHK for pacing,
|
|
37
|
+
skip AHK shutdown commands in the companion AHK workflow.
|
package/skills/qbug/SKILL.md
CHANGED
|
@@ -19,8 +19,8 @@ description: >-
|
|
|
19
19
|
|
|
20
20
|
Shared artifacts with /bugteam are referenced below by path, using the `${CLAUDE_SKILL_DIR}` host-substitution convention (both skills land under `~/.claude/skills/` after install):
|
|
21
21
|
|
|
22
|
-
- Pre-flight script: `${CLAUDE_SKILL_DIR}
|
|
23
|
-
- Code-rules gate script: `${CLAUDE_SKILL_DIR}
|
|
22
|
+
- Pre-flight script: `${CLAUDE_SKILL_DIR}/../../_shared/pr-loop/scripts/preflight.py`
|
|
23
|
+
- Code-rules gate script: `${CLAUDE_SKILL_DIR}/../../_shared/pr-loop/scripts/code_rules_gate.py`
|
|
24
24
|
- Bug category rubric A–J: [`bugteam/PROMPTS.md`](../bugteam/PROMPTS.md#audit-spawn-prompt-xml-bugfind-teammate)
|
|
25
25
|
- **Audit contract** (finding schema, proof-of-absence, adversarial pass, Haiku secondary, post-fix self-audit, diagnostics JSON): [`bugteam/reference/audit-contract.md`](../bugteam/reference/audit-contract.md)
|
|
26
26
|
- PR comment lifecycle shape: [`bugteam/SKILL.md`](../bugteam/SKILL.md#step-25-pr-comments-one-review-per-loop)
|
|
@@ -48,7 +48,7 @@ Refusals — first match wins; respond with the quoted line exactly and stop:
|
|
|
48
48
|
## Step 0: Pre-flight
|
|
49
49
|
|
|
50
50
|
```bash
|
|
51
|
-
python "${CLAUDE_SKILL_DIR}
|
|
51
|
+
python "${CLAUDE_SKILL_DIR}/../../_shared/pr-loop/scripts/preflight.py"
|
|
52
52
|
```
|
|
53
53
|
|
|
54
54
|
`${CLAUDE_SKILL_DIR}` is host-substituted before the shell runs. Non-zero → fix before continuing. `BUGTEAM_PREFLIGHT_SKIP=1` is emergency only. Add `--pre-commit` when `.pre-commit-config.yaml` exists.
|
|
@@ -97,7 +97,7 @@ import os
|
|
|
97
97
|
from pathlib import Path
|
|
98
98
|
|
|
99
99
|
skill_dir = Path(os.environ["CLAUDE_SKILL_DIR"])
|
|
100
|
-
gate_script_path = (skill_dir / ".." / "
|
|
100
|
+
gate_script_path = (skill_dir / ".." / ".." / "_shared" / "pr-loop" / "scripts" / "code_rules_gate.py").resolve()
|
|
101
101
|
categories_file_path = (skill_dir / ".." / "bugteam" / "PROMPTS.md").resolve()
|
|
102
102
|
```
|
|
103
103
|
|
|
@@ -22,8 +22,8 @@ def _load_skill_text() -> str:
|
|
|
22
22
|
|
|
23
23
|
def test_should_require_post_fix_gate_before_git_add() -> None:
|
|
24
24
|
skill_text = _load_skill_text()
|
|
25
|
-
assert "
|
|
26
|
-
"FIX step must run
|
|
25
|
+
assert "code_rules_gate" in skill_text, (
|
|
26
|
+
"FIX step must run code_rules_gate against modified files"
|
|
27
27
|
)
|
|
28
28
|
assert "post-fix" in skill_text.lower() or "post_fix" in skill_text.lower(), (
|
|
29
29
|
"FIX step must reference a post-fix audit phase"
|
|
@@ -0,0 +1,261 @@
|
|
|
1
|
+
---
|
|
2
|
+
name: resume-review
|
|
3
|
+
description: >-
|
|
4
|
+
Audit a resume for nitty-gritty offenses that bury signal. Resumes are
|
|
5
|
+
overviews scanned in 6-30 seconds, not detailed proof artifacts. This skill
|
|
6
|
+
identifies bullets that drift into workflow internals, multi-item technical
|
|
7
|
+
lists, library names, mechanism narration, or implementation detail, and
|
|
8
|
+
proposes tighter rewrites that keep the proof points (numbers, scope,
|
|
9
|
+
outcomes) while dropping the granular how-it-works text. Triggers:
|
|
10
|
+
"/resume-review", "review my resume", "audit this resume", "is my resume too
|
|
11
|
+
detailed", "tighten my resume bullets".
|
|
12
|
+
---
|
|
13
|
+
|
|
14
|
+
# Resume Review
|
|
15
|
+
|
|
16
|
+
A resume is an **overview**. Hiring managers scan a resume in 6-30 seconds on
|
|
17
|
+
first pass. Granular technical detail buries the signal. Stats, scope, and
|
|
18
|
+
quantified outcomes belong on the resume; workflow internals, multi-item
|
|
19
|
+
technical lists, and how-it-works narration belong in the interview.
|
|
20
|
+
|
|
21
|
+
## Source authority
|
|
22
|
+
|
|
23
|
+
Three established sources govern this skill. When a bullet violates one of
|
|
24
|
+
these principles, cite the source in the review comment.
|
|
25
|
+
|
|
26
|
+
- **Laszlo Bock**, *Work Rules!* (2015), Twelve Books, p. 71 (Bock served as
|
|
27
|
+
SVP People Operations at Google, 2006-2016): bullets describe "what you
|
|
28
|
+
accomplished, not what you did." Quantified outcomes beat task descriptions.
|
|
29
|
+
- **Steve Dalton**, *The 2-Hour Job Search* (2012), Ten Speed Press, Ch. 3:
|
|
30
|
+
hiring managers initially scan a resume in 6-30 seconds. Granular technical
|
|
31
|
+
detail buries the signal in that scan.
|
|
32
|
+
- **Lou Adler**, *Hire With Your Head* (4th ed., 2021), Wiley: bullets convey
|
|
33
|
+
**scope and impact**, not tools and tasks.
|
|
34
|
+
|
|
35
|
+
## The principle
|
|
36
|
+
|
|
37
|
+
Every bullet earns its place by carrying one of three things:
|
|
38
|
+
|
|
39
|
+
1. **Scope** — what surface area of work this covered (catalog size, team
|
|
40
|
+
size, user count, transaction volume, geographic reach).
|
|
41
|
+
2. **Impact** — the outcome the work produced (revenue, time saved, error
|
|
42
|
+
rate reduced, problem prevented, capability unlocked).
|
|
43
|
+
3. **Quantified proof** — a single number that anchors scope or impact and
|
|
44
|
+
makes the bullet harder to dismiss as boilerplate.
|
|
45
|
+
|
|
46
|
+
Bullets that describe the **mechanism** of how the work was done (workflow
|
|
47
|
+
steps, internal architecture, library choices, sequencing of operations) fail
|
|
48
|
+
the overview test. Move that content to the interview.
|
|
49
|
+
|
|
50
|
+
## Offense categories
|
|
51
|
+
|
|
52
|
+
The audit walks every bullet and flags any of these patterns. Each pattern
|
|
53
|
+
has a fix template.
|
|
54
|
+
|
|
55
|
+
### 1. Multi-item parenthetical lists
|
|
56
|
+
|
|
57
|
+
A parenthetical that enumerates 3+ named items (tools, systems, features,
|
|
58
|
+
sub-tasks).
|
|
59
|
+
|
|
60
|
+
> **Offender:** "Built and maintain three production Python automation
|
|
61
|
+
> systems (theme submission, theme exports, certification failure
|
|
62
|
+
> processing) backed by a shared utility library."
|
|
63
|
+
|
|
64
|
+
> **Fix:** Drop the parenthetical. Keep the count. "Built and maintain three
|
|
65
|
+
> production Python automations handling [scope]."
|
|
66
|
+
|
|
67
|
+
### 2. Workflow-step narration
|
|
68
|
+
|
|
69
|
+
The bullet describes the sequence of operations the work performs.
|
|
70
|
+
|
|
71
|
+
> **Offender:** "Manage Samsung's annual catalog-update cycle when 2,800+
|
|
72
|
+
> themes must each be updated, exported, and resubmitted one by one within a
|
|
73
|
+
> 1-2 month window."
|
|
74
|
+
|
|
75
|
+
> **Fix:** Drop the workflow steps. Keep the scope numbers. "Manage Samsung's
|
|
76
|
+
> annual catalog-update cycle: 2,800+ themes refreshed within a 1-2 month
|
|
77
|
+
> window."
|
|
78
|
+
|
|
79
|
+
### 3. Engineering-pattern jargon for non-engineering audience
|
|
80
|
+
|
|
81
|
+
Multiple named technical patterns in one bullet, written for an audience
|
|
82
|
+
that does not share the domain (e.g., infrastructure terms in an operations
|
|
83
|
+
or trust-and-safety resume).
|
|
84
|
+
|
|
85
|
+
> **Offender:** "Turn recurring failures into stronger error classification
|
|
86
|
+
> (transient vs. permanent), circuit breakers, and checkpoint/resume
|
|
87
|
+
> recovery."
|
|
88
|
+
|
|
89
|
+
> **Fix:** Replace the pattern enumeration with a single capability noun.
|
|
90
|
+
> "Turn recurring failures into reusable error-handling patterns so the same
|
|
91
|
+
> failure does not happen twice."
|
|
92
|
+
|
|
93
|
+
### 4. Mechanism narration
|
|
94
|
+
|
|
95
|
+
The bullet explains how a tool or system internally works.
|
|
96
|
+
|
|
97
|
+
> **Offender:** "Author and maintain pr-converge, a Claude Code skill that
|
|
98
|
+
> automates the pull request review-and-fix loop until reviewers converge on
|
|
99
|
+
> ready, with three open pull requests (11,000+ lines) actively extending
|
|
100
|
+
> it."
|
|
101
|
+
|
|
102
|
+
> **Fix:** State the outcome the skill produces. Drop the loop description.
|
|
103
|
+
> "Author and maintain pr-converge, an open-source Claude Code skill that
|
|
104
|
+
> drives draft pull requests to merge-ready autonomously."
|
|
105
|
+
|
|
106
|
+
### 5. Library or tool names embedded mid-bullet
|
|
107
|
+
|
|
108
|
+
A library, framework, or tool name appears inside a sentence about
|
|
109
|
+
capability. Library names belong in the dedicated Tools section, not in
|
|
110
|
+
capability bullets.
|
|
111
|
+
|
|
112
|
+
> **Offender:** "Implemented authenticated workflows end-to-end: account
|
|
113
|
+
> creation, token handling, local-first data with IndexedDB/Dexie, and
|
|
114
|
+
> conflict-aware sync between client and server."
|
|
115
|
+
|
|
116
|
+
> **Fix:** Drop the library names. State the capabilities. "Implemented
|
|
117
|
+
> authentication, local-first data persistence, and conflict-aware
|
|
118
|
+
> client-server sync end-to-end."
|
|
119
|
+
|
|
120
|
+
### 6. Redundant statistics
|
|
121
|
+
|
|
122
|
+
Two numbers in the same bullet that express the same quantity at different
|
|
123
|
+
granularities.
|
|
124
|
+
|
|
125
|
+
> **Offender:** "Roughly 30 new theme submissions per day (150 per week)."
|
|
126
|
+
|
|
127
|
+
> **Fix:** Pick one. The daily number is usually the strongest scan signal.
|
|
128
|
+
|
|
129
|
+
### 7. Implementation detail
|
|
130
|
+
|
|
131
|
+
Phrases that describe how the work was built rather than what it does.
|
|
132
|
+
|
|
133
|
+
> **Offender:** "Backed by a shared utility library, with zero manual
|
|
134
|
+
> intervention beyond starting the script."
|
|
135
|
+
|
|
136
|
+
> **Fix:** Drop the implementation phrase entirely. The capability statement
|
|
137
|
+
> should stand on its own.
|
|
138
|
+
|
|
139
|
+
### 8. Two-sentence bullets
|
|
140
|
+
|
|
141
|
+
A bullet that requires two sentences usually carries one bullet of scope and
|
|
142
|
+
one bullet of mechanism. The mechanism sentence should be removed, not
|
|
143
|
+
combined.
|
|
144
|
+
|
|
145
|
+
> **Offender:** "Author and maintain pr-converge, a Claude Code skill
|
|
146
|
+
> that... [first sentence describes what]. Recent work adds mergeability
|
|
147
|
+
> gates, GitHub Copilot reviewer integration, and post-convergence Copilot
|
|
148
|
+
> follow-up across three open pull requests (11,000+ lines)."
|
|
149
|
+
|
|
150
|
+
> **Fix:** Keep the capability sentence. Move the second sentence to a cover
|
|
151
|
+
> letter or interview talking point.
|
|
152
|
+
|
|
153
|
+
## Review protocol
|
|
154
|
+
|
|
155
|
+
Walk this protocol against every bullet on the resume. Mark each bullet
|
|
156
|
+
PASS, MINOR, or MAJOR.
|
|
157
|
+
|
|
158
|
+
### Step 1: Scope check
|
|
159
|
+
|
|
160
|
+
Read the bullet aloud in 4 seconds or less. If you cannot finish in 4
|
|
161
|
+
seconds, the bullet is too long. **Action:** trim to one sentence under 25
|
|
162
|
+
words unless the bullet carries a justified centerpiece (and centerpiece
|
|
163
|
+
bullets stay under 40 words).
|
|
164
|
+
|
|
165
|
+
### Step 2: Offense scan
|
|
166
|
+
|
|
167
|
+
For each bullet, scan for the eight offense categories above. Record any
|
|
168
|
+
hits with the category number.
|
|
169
|
+
|
|
170
|
+
### Step 3: Verify proof points
|
|
171
|
+
|
|
172
|
+
Every numeric claim in a bullet must be verifiable. If a number cannot be
|
|
173
|
+
sourced, drop it. Hedging numbers ("roughly", "around", "approximately")
|
|
174
|
+
are acceptable when the underlying number is verifiable but variable.
|
|
175
|
+
|
|
176
|
+
### Step 4: Audience alignment
|
|
177
|
+
|
|
178
|
+
For each bullet, ask: would the hiring manager for **this specific role**
|
|
179
|
+
recognize the terms used? If the bullet uses domain language outside the
|
|
180
|
+
target role's vocabulary (engineering jargon on a trust-and-safety resume,
|
|
181
|
+
finance acronyms on an engineering resume), rewrite using domain-neutral
|
|
182
|
+
capability nouns.
|
|
183
|
+
|
|
184
|
+
### Step 5: Mechanism removal pass
|
|
185
|
+
|
|
186
|
+
For each bullet that survived steps 1-4, ask: does this bullet describe
|
|
187
|
+
**what** the work accomplished, or **how** the work was done? If it
|
|
188
|
+
describes **how**, rewrite to describe **what** and move the **how** to
|
|
189
|
+
interview prep notes.
|
|
190
|
+
|
|
191
|
+
### Step 6: Section-level coherence
|
|
192
|
+
|
|
193
|
+
After per-bullet review, scan each section. Check for:
|
|
194
|
+
|
|
195
|
+
- **Bullet count consistency** — sections with similar weight should have
|
|
196
|
+
similar bullet counts. A 5-bullet section next to a 1-bullet section
|
|
197
|
+
signals imbalance.
|
|
198
|
+
- **Voice consistency** — verb tense, sentence structure, and bullet length
|
|
199
|
+
should match across sections.
|
|
200
|
+
- **Relevance ordering** — the most-relevant-to-the-target-role section
|
|
201
|
+
should appear first within its time band (Steve Dalton, *The 2-Hour Job
|
|
202
|
+
Search* §6: relevance over strict chronology when chronology does not
|
|
203
|
+
conflict).
|
|
204
|
+
|
|
205
|
+
## Output format
|
|
206
|
+
|
|
207
|
+
The audit produces a markdown report with this structure:
|
|
208
|
+
|
|
209
|
+
```markdown
|
|
210
|
+
# Resume Audit Report
|
|
211
|
+
|
|
212
|
+
## Top offenders (worst first)
|
|
213
|
+
|
|
214
|
+
### #1 — [Section] bullet [N]. [Severity]
|
|
215
|
+
|
|
216
|
+
[Quote of current bullet]
|
|
217
|
+
|
|
218
|
+
**Offenses:** [comma-separated category numbers]
|
|
219
|
+
|
|
220
|
+
**Proposed rewrite:** [tighter version]
|
|
221
|
+
|
|
222
|
+
**Words saved:** [N words → M words]
|
|
223
|
+
|
|
224
|
+
(repeat for each offender)
|
|
225
|
+
|
|
226
|
+
## Sections that pass
|
|
227
|
+
|
|
228
|
+
- [Section name]: [bullet count] bullets, all PASS
|
|
229
|
+
- (repeat)
|
|
230
|
+
|
|
231
|
+
## Section-level findings
|
|
232
|
+
|
|
233
|
+
[Coherence issues from Step 6, if any]
|
|
234
|
+
|
|
235
|
+
## Sources cited
|
|
236
|
+
|
|
237
|
+
- Bock, *Work Rules!* (2015), p. 71 — for offenses [N]
|
|
238
|
+
- Dalton, *2-Hour Job Search* (2012), Ch. 3 — for offenses [N]
|
|
239
|
+
- Adler, *Hire With Your Head* (2021) — for offenses [N]
|
|
240
|
+
```
|
|
241
|
+
|
|
242
|
+
## When this skill applies
|
|
243
|
+
|
|
244
|
+
- User asks to review or audit a resume
|
|
245
|
+
- User asks "is my resume too detailed"
|
|
246
|
+
- User asks for tighter resume bullets
|
|
247
|
+
- A resume document is shared and the user wants feedback
|
|
248
|
+
- Before submitting a resume to a target role
|
|
249
|
+
|
|
250
|
+
## When this skill does not apply
|
|
251
|
+
|
|
252
|
+
- Cover letter review (use a separate cover-letter-review skill if needed)
|
|
253
|
+
- Resume formatting fixes (font, spacing, layout) — this skill audits
|
|
254
|
+
content only
|
|
255
|
+
- Resume creation from scratch — this skill assumes a draft exists
|
|
256
|
+
|
|
257
|
+
## Triggers
|
|
258
|
+
|
|
259
|
+
`/resume-review`, "review my resume", "audit this resume", "is my resume
|
|
260
|
+
too detailed", "tighten my resume bullets", "what offenses do you see in my
|
|
261
|
+
resume", "are my bullets too granular".
|
|
@@ -1,58 +0,0 @@
|
|
|
1
|
-
# Bugteam utility scripts
|
|
2
|
-
|
|
3
|
-
Scripts in this directory are **executed** by the lead or teammates. They are not loaded into context as instructions (see Anthropic [Skill authoring best practices — Progressive disclosure](https://platform.claude.com/docs/en/agents-and-tools/agent-skills/best-practices#progressive-disclosure-patterns)).
|
|
4
|
-
|
|
5
|
-
| Script | Purpose |
|
|
6
|
-
|--------|---------|
|
|
7
|
-
| `bugteam_preflight.py` | Run pytest (when configured) and optional `pre-commit` before `/bugteam`. |
|
|
8
|
-
| `bugteam_fix_hookspath.py` | Auto-remediate a stale local `core.hooksPath` override, set canonical global value, re-run `bugteam_preflight.py`. Invoked by Claude when preflight reports a `core.hooksPath` failure. |
|
|
9
|
-
| `bugteam_code_rules_gate.py` | Run `validate_content` from `code-rules-enforcer.py` on PR-scoped files (`git diff` vs merge-base). Exit `1` if any mandatory rule fails. Invoked **before each audit**; the fixer clears it before the auditor runs. |
|
|
10
|
-
| `grant_project_claude_permissions.py` | Idempotent grant of Edit/Write/Read on `cwd/.claude/**` into `~/.claude/settings.json`. |
|
|
11
|
-
| `revoke_project_claude_permissions.py` | Removes the matching grant entries from `~/.claude/settings.json`. |
|
|
12
|
-
| `test_claude_permissions_common.py` | Pytest module for path normalization and glob-metacharacter guards in `_claude_permissions_common.py`. |
|
|
13
|
-
| `_claude_permissions_common.py` | Shared helpers for the grant/revoke scripts (atomic JSON writes, settings sections). |
|
|
14
|
-
|
|
15
|
-
## `bugteam_preflight.py`
|
|
16
|
-
|
|
17
|
-
From the repository root:
|
|
18
|
-
|
|
19
|
-
```bash
|
|
20
|
-
python "${CLAUDE_SKILL_DIR}/scripts/bugteam_preflight.py"
|
|
21
|
-
```
|
|
22
|
-
|
|
23
|
-
- Skips pytest when `BUGTEAM_PREFLIGHT_SKIP=1`.
|
|
24
|
-
- Skips pytest when `pytest.ini` / `pyproject.toml` exists but no `test_*.py` / `*_test.py` files are found under the repo root.
|
|
25
|
-
- Pytest exit code `5` (no tests collected) is treated as success.
|
|
26
|
-
- Add `--pre-commit` to run `pre-commit run --all-files` when `.pre-commit-config.yaml` exists.
|
|
27
|
-
|
|
28
|
-
## `bugteam_fix_hookspath.py`
|
|
29
|
-
|
|
30
|
-
From the repository root:
|
|
31
|
-
|
|
32
|
-
```bash
|
|
33
|
-
python "${CLAUDE_SKILL_DIR}/scripts/bugteam_fix_hookspath.py"
|
|
34
|
-
```
|
|
35
|
-
|
|
36
|
-
- Removes any local-scope `core.hooksPath` value that does not end in `hooks/git-hooks`.
|
|
37
|
-
- Sets `git config --global core.hooksPath ~/.claude/hooks/git-hooks` when the global value is unset or non-canonical.
|
|
38
|
-
- Refuses to run (exit non-zero) when `~/.claude/hooks/git-hooks` does not exist on disk — install via `npx claude-dev-env .` first.
|
|
39
|
-
- Idempotent: a second invocation is a clean no-op.
|
|
40
|
-
- Re-runs `bugteam_preflight.py --no-pytest` and propagates its exit code.
|
|
41
|
-
|
|
42
|
-
The bugteam SKILL invokes this automatically when preflight stderr indicates a `core.hooksPath` failure, so Claude does not surface the error to the user.
|
|
43
|
-
|
|
44
|
-
## `bugteam_code_rules_gate.py`
|
|
45
|
-
|
|
46
|
-
From the repository root (same merge-base rules as the PR head vs base — default `--base origin/main`):
|
|
47
|
-
|
|
48
|
-
```bash
|
|
49
|
-
python "${CLAUDE_SKILL_DIR}/scripts/bugteam_code_rules_gate.py"
|
|
50
|
-
```
|
|
51
|
-
|
|
52
|
-
Optional explicit files instead of `git diff`:
|
|
53
|
-
|
|
54
|
-
```bash
|
|
55
|
-
python "${CLAUDE_SKILL_DIR}/scripts/bugteam_code_rules_gate.py" path/to/a.py path/to/b.ts
|
|
56
|
-
```
|
|
57
|
-
|
|
58
|
-
This loads `validate_content` from `hooks/blocking/code-rules-enforcer.py` inside `claude-dev-env` (same logic as the PreToolUse hook). Exit `0` = mandatory checks pass on scanned files; exit `1` = violations printed to stderr.
|