claude-dev-env 1.35.0 → 1.36.0

package/skills/pr-converge/scripts/test_request_copilot_review.py

@@ -0,0 +1,101 @@
+"""Tests for request_copilot_review.
+
+Covers:
+- gh api -X POST is invoked against requested_reviewers endpoint
+- the reviewer id literal is `copilot-pull-request-reviewer[bot]` (the [bot]
+  suffix is load-bearing per skills/copilot-review/SKILL.md)
+- subprocess errors propagate
+- the field carries the documented `reviewers[]=<id>` form
+"""
+
+from __future__ import annotations
+
+import importlib.util
+import subprocess
+from pathlib import Path
+from types import ModuleType
+from unittest.mock import MagicMock, patch
+
+import pytest
+
+
+def _load_module() -> ModuleType:
+    module_path = Path(__file__).parent / "request_copilot_review.py"
+    spec = importlib.util.spec_from_file_location("request_copilot_review", module_path)
+    assert spec is not None
+    assert spec.loader is not None
+    module = importlib.util.module_from_spec(spec)
+    spec.loader.exec_module(module)
+    return module
+
+
+request_copilot_review_module = _load_module()
+
+
+def _completed(stdout: str) -> subprocess.CompletedProcess:
+    process = MagicMock(spec=subprocess.CompletedProcess)
+    process.stdout = stdout
+    process.returncode = 0
+    return process
+
+
+def test_should_invoke_gh_api_post_against_requested_reviewers_endpoint() -> None:
+    with patch("subprocess.run") as mock_run:
+        mock_run.return_value = _completed("{}")
+        request_copilot_review_module.request_copilot_review(
+            owner="acme", repo="widget", number=42
+        )
+    invoked_argv = mock_run.call_args[0][0]
+    assert invoked_argv[0:2] == ["gh", "api"]
+    assert "-X" in invoked_argv
+    assert "POST" in invoked_argv
+    assert "repos/acme/widget/pulls/42/requested_reviewers" in invoked_argv
+
+
+def test_should_request_copilot_with_bot_suffix_literal() -> None:
+    with patch("subprocess.run") as mock_run:
+        mock_run.return_value = _completed("{}")
+        request_copilot_review_module.request_copilot_review(
+            owner="acme", repo="widget", number=42
+        )
+    invoked_argv = mock_run.call_args[0][0]
+    assert "reviewers[]=copilot-pull-request-reviewer[bot]" in invoked_argv
+
+
+def test_should_pass_reviewer_field_via_dash_f_flag() -> None:
+    with patch("subprocess.run") as mock_run:
+        mock_run.return_value = _completed("{}")
+        request_copilot_review_module.request_copilot_review(
+            owner="acme", repo="widget", number=42
+        )
+    invoked_argv = mock_run.call_args[0][0]
+    assert "-f" in invoked_argv
+    field_index = invoked_argv.index("-f")
+    field_value = invoked_argv[field_index + 1]
+    assert field_value == "reviewers[]=copilot-pull-request-reviewer[bot]"
+
+
+def test_should_raise_when_gh_subprocess_fails() -> None:
+    failure = subprocess.CalledProcessError(
+        returncode=1, cmd=["gh"], stderr="auth failure"
+    )
+    with patch("subprocess.run", side_effect=failure):
+        with pytest.raises(subprocess.CalledProcessError):
+            request_copilot_review_module.request_copilot_review(
+                owner="acme", repo="widget", number=42
+            )
+
+
+def test_should_render_endpoint_via_named_template_constant() -> None:
+    with patch("subprocess.run") as mock_run:
+        mock_run.return_value = _completed("{}")
+        request_copilot_review_module.request_copilot_review(
+            owner="acme", repo="widget", number=42
+        )
+    invoked_argv = mock_run.call_args[0][0]
+    expected_endpoint = (
+        request_copilot_review_module.GH_REQUESTED_REVIEWERS_PATH_TEMPLATE.format(
+            owner="acme", repo="widget", number=42
+        )
+    )
+    assert expected_endpoint in invoked_argv

package/skills/pr-converge/scripts/test_resolve_pr_head.py

@@ -0,0 +1,79 @@
+"""Tests for resolve_pr_head.
+
+Covers:
+- gh command targets the single-object PR endpoint with --jq .head.sha
+- single-object endpoint does NOT use --paginate or --slurp (per gh-paginate rule)
+- the trimmed SHA is returned
+- subprocess errors propagate
+"""
+
+from __future__ import annotations
+
+import importlib.util
+import subprocess
+from pathlib import Path
+from types import ModuleType
+from unittest.mock import MagicMock, patch
+
+import pytest
+
+
+def _load_module() -> ModuleType:
+    module_path = Path(__file__).parent / "resolve_pr_head.py"
+    spec = importlib.util.spec_from_file_location("resolve_pr_head", module_path)
+    assert spec is not None
+    assert spec.loader is not None
+    module = importlib.util.module_from_spec(spec)
+    spec.loader.exec_module(module)
+    return module
+
+
+resolve_pr_head_module = _load_module()
+
+
+def _completed(stdout: str) -> subprocess.CompletedProcess:
+    process = MagicMock(spec=subprocess.CompletedProcess)
+    process.stdout = stdout
+    process.returncode = 0
+    return process
+
+
+def test_should_invoke_gh_against_single_object_pr_endpoint() -> None:
+    with patch("subprocess.run") as mock_run:
+        mock_run.return_value = _completed("85309a0789e\n")
+        resolve_pr_head_module.resolve_pr_head(owner="acme", repo="widget", number=42)
+    invoked_argv = mock_run.call_args[0][0]
+    assert invoked_argv[0] == "gh"
+    assert invoked_argv[1] == "api"
+    assert invoked_argv[2] == "repos/acme/widget/pulls/42"
+    assert "--jq" in invoked_argv
+    assert ".head.sha" in invoked_argv
+
+
+def test_should_not_use_paginate_or_slurp_on_single_object_endpoint() -> None:
+    with patch("subprocess.run") as mock_run:
+        mock_run.return_value = _completed("abc\n")
+        resolve_pr_head_module.resolve_pr_head(owner="acme", repo="widget", number=42)
+    invoked_argv = mock_run.call_args[0][0]
+    assert "--paginate" not in invoked_argv
+    assert "--slurp" not in invoked_argv
+
+
+def test_should_return_trimmed_sha() -> None:
+    with patch("subprocess.run") as mock_run:
+        mock_run.return_value = _completed("  85309a0789e  \n")
+        resolved_sha = resolve_pr_head_module.resolve_pr_head(
+            owner="acme", repo="widget", number=42
+        )
+    assert resolved_sha == "85309a0789e"
+
+
+def test_should_raise_when_gh_subprocess_fails() -> None:
+    failure = subprocess.CalledProcessError(
+        returncode=1, cmd=["gh"], stderr="auth failure"
+    )
+    with patch("subprocess.run", side_effect=failure):
+        with pytest.raises(subprocess.CalledProcessError):
+            resolve_pr_head_module.resolve_pr_head(
+                owner="acme", repo="widget", number=42
+            )

package/skills/pr-converge/scripts/test_review_field_helpers.py

@@ -0,0 +1,80 @@
+"""Tests for review_field_helpers.
+
+Covers defensive field-coercion for the four GitHub payload field accessors
+shared across fetch_*_reviews.py and fetch_*_inline_comments.py.
+"""
+
+from __future__ import annotations
+
+import importlib.util
+from pathlib import Path
+from types import ModuleType
+
+
+def _load_module() -> ModuleType:
+    module_path = Path(__file__).parent / "review_field_helpers.py"
+    spec = importlib.util.spec_from_file_location("review_field_helpers", module_path)
+    assert spec is not None
+    assert spec.loader is not None
+    module = importlib.util.module_from_spec(spec)
+    spec.loader.exec_module(module)
+    return module
+
+
+review_field_helpers_module = _load_module()
+
+
+def test_login_of_should_return_login_string_when_user_dict_has_login() -> None:
+    payload = {"user": {"login": "cursor[bot]"}}
+    assert review_field_helpers_module.login_of(payload) == "cursor[bot]"
+
+
+def test_login_of_should_return_none_when_user_field_missing() -> None:
+    assert review_field_helpers_module.login_of({}) is None
+
+
+def test_login_of_should_return_none_when_user_field_not_dict() -> None:
+    assert review_field_helpers_module.login_of({"user": "not-a-dict"}) is None
+
+
+def test_login_of_should_return_none_when_login_field_not_string() -> None:
+    assert review_field_helpers_module.login_of({"user": {"login": 12345}}) is None
+
+
+def test_body_of_should_return_body_string_when_present() -> None:
+    assert review_field_helpers_module.body_of({"body": "review body"}) == "review body"
+
+
+def test_body_of_should_return_empty_string_when_body_missing() -> None:
+    assert review_field_helpers_module.body_of({}) == ""
+
+
+def test_body_of_should_return_empty_string_when_body_not_string() -> None:
+    assert review_field_helpers_module.body_of({"body": None}) == ""
+
+
+def test_submitted_at_of_should_return_string_when_present() -> None:
+    payload = {"submitted_at": "2026-05-03T12:00:00Z"}
+    assert (
+        review_field_helpers_module.submitted_at_of(payload) == "2026-05-03T12:00:00Z"
+    )
+
+
+def test_submitted_at_of_should_return_empty_string_when_missing() -> None:
+    assert review_field_helpers_module.submitted_at_of({}) == ""
+
+
+def test_submitted_at_of_should_return_empty_string_when_not_string() -> None:
+    assert review_field_helpers_module.submitted_at_of({"submitted_at": 0}) == ""
+
+
+def test_state_of_should_return_state_string_when_present() -> None:
+    assert review_field_helpers_module.state_of({"state": "APPROVED"}) == "APPROVED"
+
+
+def test_state_of_should_return_empty_string_when_missing() -> None:
+    assert review_field_helpers_module.state_of({}) == ""
+
+
+def test_state_of_should_return_empty_string_when_not_string() -> None:
+    assert review_field_helpers_module.state_of({"state": ["APPROVED"]}) == ""

package/skills/pr-converge/scripts/test_trigger_bugbot.py

@@ -0,0 +1,139 @@
+"""Tests for trigger_bugbot.
+
+Covers:
+- gh pr comment is invoked with --body-file (per gh-body-file rule)
+- the body file written contains the literal phrase "bugbot run\\n"
+- the comment URL emitted by gh is returned
+- the temp body file is cleaned up
+- subprocess errors propagate
+"""
+
+from __future__ import annotations
+
+import importlib.util
+import subprocess
+from pathlib import Path
+from types import ModuleType
+from unittest.mock import MagicMock, patch
+
+import pytest
+
+
+def _load_module() -> ModuleType:
+    module_path = Path(__file__).parent / "trigger_bugbot.py"
+    spec = importlib.util.spec_from_file_location("trigger_bugbot", module_path)
+    assert spec is not None
+    assert spec.loader is not None
+    module = importlib.util.module_from_spec(spec)
+    spec.loader.exec_module(module)
+    return module
+
+
+trigger_bugbot_module = _load_module()
+
+
+def _completed(stdout: str) -> subprocess.CompletedProcess:
+    process = MagicMock(spec=subprocess.CompletedProcess)
+    process.stdout = stdout
+    process.returncode = 0
+    return process
+
+
+def test_should_invoke_gh_pr_comment_with_body_file_flag() -> None:
+    captured_body_paths: list[str] = []
+
+    def capture_body_file_contents(*subprocess_args, **_subprocess_kwargs):
+        invoked_argv = subprocess_args[0]
+        assert "--body-file" in invoked_argv
+        body_file_path = invoked_argv[invoked_argv.index("--body-file") + 1]
+        captured_body_paths.append(body_file_path)
+        return _completed("https://github.com/acme/widget/issues/42#issuecomment-99\n")
+
+    with patch("subprocess.run", side_effect=capture_body_file_contents) as mock_run:
+        trigger_bugbot_module.trigger_bugbot(owner="acme", repo="widget", number=42)
+    invoked_argv = mock_run.call_args[0][0]
+    assert invoked_argv[0:3] == ["gh", "pr", "comment"]
+    assert "42" in invoked_argv
+    assert "--repo" in invoked_argv
+    assert "acme/widget" in invoked_argv
+
+
+def test_should_write_literal_bugbot_run_phrase_into_body_file() -> None:
+    captured_body_contents: list[str] = []
+
+    def capture_body_file_contents(*subprocess_args, **_subprocess_kwargs):
+        invoked_argv = subprocess_args[0]
+        body_file_path = Path(invoked_argv[invoked_argv.index("--body-file") + 1])
+        captured_body_contents.append(body_file_path.read_text(encoding="utf-8"))
+        return _completed("https://example.com\n")
+
+    with patch("subprocess.run", side_effect=capture_body_file_contents):
+        trigger_bugbot_module.trigger_bugbot(owner="acme", repo="widget", number=42)
+    assert len(captured_body_contents) == 1
+    assert captured_body_contents[0] == "bugbot run\n"
+
+
+def test_should_return_comment_url_from_gh_stdout() -> None:
+    expected_url = "https://github.com/acme/widget/pull/42#issuecomment-12345"
+    with patch("subprocess.run") as mock_run:
+        mock_run.return_value = _completed(f"{expected_url}\n")
+        comment_url = trigger_bugbot_module.trigger_bugbot(
+            owner="acme", repo="widget", number=42
+        )
+    assert comment_url == expected_url
+
+
+def test_should_remove_temp_body_file_after_invocation() -> None:
+    captured_body_paths: list[Path] = []
+
+    def capture_body_file_contents(*subprocess_args, **_subprocess_kwargs):
+        invoked_argv = subprocess_args[0]
+        captured_body_paths.append(
+            Path(invoked_argv[invoked_argv.index("--body-file") + 1])
+        )
+        return _completed("https://example.com\n")
+
+    with patch("subprocess.run", side_effect=capture_body_file_contents):
+        trigger_bugbot_module.trigger_bugbot(owner="acme", repo="widget", number=42)
+    assert len(captured_body_paths) == 1
+    assert not captured_body_paths[0].exists()
+
+
+def test_should_raise_when_gh_subprocess_fails() -> None:
+    failure = subprocess.CalledProcessError(
+        returncode=1, cmd=["gh"], stderr="auth failure"
+    )
+    with patch("subprocess.run", side_effect=failure):
+        with pytest.raises(subprocess.CalledProcessError):
+            trigger_bugbot_module.trigger_bugbot(owner="acme", repo="widget", number=42)
+
+
+def test_should_write_imported_constant_directly_without_local_alias() -> None:
+    captured_body_contents: list[str] = []
+
+    def capture_body_file_contents(*subprocess_args, **_subprocess_kwargs):
+        invoked_argv = subprocess_args[0]
+        body_file_path = Path(invoked_argv[invoked_argv.index("--body-file") + 1])
+        captured_body_contents.append(body_file_path.read_text(encoding="utf-8"))
+        return _completed("https://example.com\n")
+
+    with patch("subprocess.run", side_effect=capture_body_file_contents):
+        trigger_bugbot_module.trigger_bugbot(owner="acme", repo="widget", number=99)
+    assert len(captured_body_contents) == 1
+    assert (
+        captured_body_contents[0]
+        == trigger_bugbot_module.BUGBOT_RUN_TRIGGER_PHRASE
+    )
+
+
+def test_should_render_repo_arg_via_named_template_constant() -> None:
+    with patch("subprocess.run") as mock_run:
+        mock_run.return_value = _completed("https://example.com\n")
+        trigger_bugbot_module.trigger_bugbot(owner="acme", repo="widget", number=42)
+    invoked_argv = mock_run.call_args[0][0]
+    expected_repo_arg = trigger_bugbot_module.GH_REPO_ARG_TEMPLATE.format(
+        owner="acme", repo="widget"
+    )
+    assert expected_repo_arg == "acme/widget"
+    repo_flag_index = invoked_argv.index("--repo")
+    assert invoked_argv[repo_flag_index + 1] == expected_repo_arg

package/skills/pr-converge/scripts/test_view_pr_context.py

@@ -0,0 +1,111 @@
+"""Tests for view_pr_context.
+
+Covers:
+- gh pr view is invoked with the documented --json field list
+- the parsed JSON object is returned
+- subprocess errors propagate
+"""
+
+from __future__ import annotations
+
+import importlib.util
+import json
+import subprocess
+from pathlib import Path
+from types import ModuleType
+from unittest.mock import MagicMock, patch
+
+import pytest
+
+
+def _load_module() -> ModuleType:
+    module_path = Path(__file__).parent / "view_pr_context.py"
+    spec = importlib.util.spec_from_file_location("view_pr_context", module_path)
+    assert spec is not None
+    assert spec.loader is not None
+    module = importlib.util.module_from_spec(spec)
+    spec.loader.exec_module(module)
+    return module
+
+
+view_pr_context_module = _load_module()
+
+
+def _completed(stdout: str) -> subprocess.CompletedProcess:
+    process = MagicMock(spec=subprocess.CompletedProcess)
+    process.stdout = stdout
+    process.returncode = 0
+    return process
+
+
+def test_should_invoke_gh_pr_view_with_documented_field_list() -> None:
+    payload = json.dumps(
+        {
+            "number": 42,
+            "url": "https://github.com/acme/widget/pull/42",
+            "headRefOid": "abc123",
+            "baseRefName": "main",
+            "headRefName": "feat/x",
+            "isDraft": True,
+        }
+    )
+    with patch("subprocess.run") as mock_run:
+        mock_run.return_value = _completed(payload)
+        view_pr_context_module.view_pr_context()
+    invoked_argv = mock_run.call_args[0][0]
+    assert invoked_argv[0:3] == ["gh", "pr", "view"]
+    assert "--json" in invoked_argv
+    fields_arg = invoked_argv[invoked_argv.index("--json") + 1]
+    for required_field in (
+        "number",
+        "url",
+        "headRefOid",
+        "baseRefName",
+        "headRefName",
+        "isDraft",
+    ):
+        assert required_field in fields_arg
+
+
+def test_should_return_parsed_json_object() -> None:
+    payload = {
+        "number": 42,
+        "url": "https://github.com/acme/widget/pull/42",
+        "headRefOid": "abc123",
+        "baseRefName": "main",
+        "headRefName": "feat/x",
+        "isDraft": True,
+    }
+    with patch("subprocess.run") as mock_run:
+        mock_run.return_value = _completed(json.dumps(payload))
+        pr_context = view_pr_context_module.view_pr_context()
+    assert pr_context == payload
+
+
+def test_should_raise_when_gh_subprocess_fails() -> None:
+    failure = subprocess.CalledProcessError(
+        returncode=1, cmd=["gh"], stderr="auth failure"
+    )
+    with patch("subprocess.run", side_effect=failure):
+        with pytest.raises(subprocess.CalledProcessError):
+            view_pr_context_module.view_pr_context()
+
+
+def test_should_pass_imported_constant_directly_without_local_alias() -> None:
+    payload = json.dumps(
+        {
+            "number": 7,
+            "url": "https://github.com/acme/widget/pull/7",
+            "headRefOid": "deadbeef",
+            "baseRefName": "main",
+            "headRefName": "feat/y",
+            "isDraft": False,
+        }
+    )
+    with patch("subprocess.run") as mock_run:
+        mock_run.return_value = _completed(payload)
+        view_pr_context_module.view_pr_context()
+    invoked_argv = mock_run.call_args[0][0]
+    fields_arg = invoked_argv[invoked_argv.index("--json") + 1]
+    expected_fields = view_pr_context_module.PR_CONTEXT_FIELDS
+    assert fields_arg is expected_fields

package/skills/pr-converge/scripts/trigger_bugbot.py

@@ -0,0 +1,77 @@
+"""Post a `bugbot run` comment to re-trigger a Cursor Bugbot review.
+
+Writes the literal trigger phrase to a temp file (per the gh-body-file rule —
+`gh pr comment --body "..."` may corrupt backticks), invokes
+`gh pr comment --body-file`, and removes the temp file on success or failure.
+"""
+
+import argparse
+import os
+import subprocess
+import sys
+import tempfile
+from pathlib import Path
+
+if str(Path(__file__).resolve().parent) not in sys.path:
+    sys.path.insert(0, str(Path(__file__).resolve().parent))
+
+from evict_cached_config_modules import evict_cached_config_modules
+
+evict_cached_config_modules()
+
+from config.pr_converge_constants import (
+    BUGBOT_RUN_TEMPFILE_PREFIX,
+    BUGBOT_RUN_TEMPFILE_SUFFIX,
+    BUGBOT_RUN_TRIGGER_PHRASE,
+    GH_REPO_ARG_TEMPLATE,
+)
+
+
+def trigger_bugbot(*, owner: str, repo: str, number: int) -> str:
+    """Post the bugbot re-trigger comment, return the comment URL gh emits."""
+    file_descriptor, raw_path = tempfile.mkstemp(
+        suffix=BUGBOT_RUN_TEMPFILE_SUFFIX, prefix=BUGBOT_RUN_TEMPFILE_PREFIX
+    )
+    try:
+        os.close(file_descriptor)
+        body_file_path = Path(raw_path)
+        body_file_path.write_text(BUGBOT_RUN_TRIGGER_PHRASE, encoding="utf-8")
+        repo_arg = GH_REPO_ARG_TEMPLATE.format(owner=owner, repo=repo)
+        gh_command: list[str] = [
+            "gh",
+            "pr",
+            "comment",
+            str(number),
+            "--repo",
+            repo_arg,
+            "--body-file",
+            str(body_file_path),
+        ]
+        completed = subprocess.run(
+            gh_command,
+            capture_output=True,
+            check=True,
+            text=True,
+            encoding="utf-8",
+            errors="replace",
+        )
+        return completed.stdout.strip()
+    finally:
+        Path(raw_path).unlink(missing_ok=True)
+
+
+def main() -> int:
+    parser = argparse.ArgumentParser(description=__doc__)
+    parser.add_argument("--owner", required=True)
+    parser.add_argument("--repo", required=True)
+    parser.add_argument("--number", required=True, type=int)
+    parsed_arguments = parser.parse_args()
+    comment_url = trigger_bugbot(
+        owner=parsed_arguments.owner, repo=parsed_arguments.repo, number=parsed_arguments.number
+    )
+    sys.stdout.write(f"{comment_url}\n")
+    return 0
+
+
+if __name__ == "__main__":
+    sys.exit(main())

package/skills/pr-converge/scripts/view_pr_context.py

@@ -0,0 +1,47 @@
+"""Resolve the per-tick PR context (number, url, head sha, branch names, draft state).
+
+Wraps `gh pr view --json ...` so the skill body emits one script invocation
+instead of repeating the field list inline.
+"""
+
+import argparse
+import json
+import subprocess
+import sys
+from pathlib import Path
+
+if str(Path(__file__).resolve().parent) not in sys.path:
+    sys.path.insert(0, str(Path(__file__).resolve().parent))
+
+from evict_cached_config_modules import evict_cached_config_modules
+
+evict_cached_config_modules()
+
+from config.pr_converge_constants import PR_CONTEXT_FIELDS
+
+
+def view_pr_context() -> dict[str, object]:
+    """Return the parsed JSON object from `gh pr view --json <fields>`."""
+    gh_command: list[str] = ["gh", "pr", "view", "--json", PR_CONTEXT_FIELDS]
+    completed = subprocess.run(
+        gh_command,
+        capture_output=True,
+        check=True,
+        text=True,
+        encoding="utf-8",
+        errors="replace",
+    )
+    return json.loads(completed.stdout)
+
+
+def main() -> int:
+    parser = argparse.ArgumentParser(description=__doc__)
+    parser.parse_args()
+    pr_context = view_pr_context()
+    json.dump(pr_context, sys.stdout)
+    sys.stdout.write("\n")
+    return 0
+
+
+if __name__ == "__main__":
+    sys.exit(main())

package/skills/pr-converge/test_team_lifecycle.py

@@ -0,0 +1,47 @@
+"""Markdown assertion tests for pr-converge orchestrator team lifecycle.
+
+Locks in the contract that pr-converge multi-PR orchestration must:
+  - own a single long-lived team for the whole sweep
+  - pass that team to every bugteam invocation via attach mode
+  - tear down only when every PR reaches `converged` or `blocked`
+"""
+
+from __future__ import annotations
+
+import pathlib
+
+
+def _skill_text() -> str:
+    here = pathlib.Path(__file__).parent
+    return (here / "SKILL.md").read_text(encoding="utf-8")
+
+
+def test_skill_documents_orchestrator_owned_team_in_multi_pr_mode():
+    skill_text = _skill_text()
+    assert "team_name" in skill_text
+    assert "TeamCreate" in skill_text
+    assert "orchestrator" in skill_text.lower()
+
+
+def test_skill_passes_attach_mode_to_bugteam_invocations():
+    skill_text = _skill_text()
+    assert "BUGTEAM_TEAM_LIFECYCLE" in skill_text
+    assert "attach" in skill_text
+    assert "BUGTEAM_TEAM_NAME" in skill_text
+
+
+def test_skill_tears_down_team_only_on_full_convergence():
+    skill_text = _skill_text()
+    assert "TeamDelete" in skill_text
+    convergence_phrases = [
+        "every PR",
+        "all PRs",
+        "fully converged",
+        "every prs[",
+    ]
+    assert any(phrase in skill_text for phrase in convergence_phrases)
+
+
+def test_state_schema_includes_team_name_field():
+    skill_text = _skill_text()
+    assert '"team_name"' in skill_text or "team_name:" in skill_text