chrome-devtools-frontend 1.0.995491 → 1.0.996595

package/scripts/eslint_rules/tests/inline_type_imports_test.js

@@ -0,0 +1,106 @@
+// Copyright 2022 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+'use strict';
+
+const rule = require('../lib/inline_type_imports.js');
+const ruleTester = new (require('eslint').RuleTester)({
+  parserOptions: {ecmaVersion: 9, sourceType: 'module'},
+  parser: require.resolve('@typescript-eslint/parser'),
+});
+
+ruleTester.run('inline_type_imports', rule, {
+  valid: [
+    {
+      code: 'import \'./foo.js\'',
+    },
+    {
+      code: 'import type * as Foo from \'./foo.js\'',
+    },
+    {
+      code: 'import * as Foo from \'./foo.js\'',
+    },
+    {
+      code: 'import Foo from \'./foo.js\'',
+    },
+    {
+      code: 'import type Foo from \'./foo.js\'',
+    },
+    {
+      code: 'import {type Foo} from \'./foo.js\'',
+    },
+    {
+      code: 'import {type Foo as Foo2} from \'./foo.js\'',
+    },
+    {
+      code: 'import {SomeValue, type Foo as Foo2} from \'./foo.js\'',
+    },
+    {
+      code: 'import {type Bar, type Foo as Foo2} from \'./foo.js\'',
+    },
+  ],
+  invalid: [
+    {
+      code: `import type {AType} from './foo.js';
+  import {AValue} from './foo.js';`,
+      output: `
+  import {AValue, type AType} from './foo.js';`,
+      filename: 'front_end/components/test.ts',
+      errors: [{messageId: 'inlineTypeImport'}],
+    },
+    {
+      code: `import type {AType} from './foo.js';
+  import {AValue} from './foo.js';
+  import type {Foo} from './blah.js'`,
+      output: `
+  import {AValue, type AType} from './foo.js';
+  import {type Foo} from './blah.js'`,
+      filename: 'front_end/components/test.ts',
+      errors: [{messageId: 'inlineTypeImport'}, {messageId: 'convertTypeImport'}],
+    },
+    {
+      code: `import type {AType} from './foo.js';
+  import {AValue} from './foo.js';
+  import {Foo} from './blah.js'`,
+      output: `
+  import {AValue, type AType} from './foo.js';
+  import {Foo} from './blah.js'`,
+      filename: 'front_end/components/test.ts',
+      errors: [{messageId: 'inlineTypeImport'}],
+    },
+    {
+      code: 'import type {AType} from \'./foo.js\';',
+      output: 'import {type AType} from \'./foo.js\';',
+      filename: 'front_end/components/test.ts',
+      errors: [{messageId: 'convertTypeImport'}],
+    },
+    {
+      code: 'import type {Foo as Bar} from \'./foo.js\';',
+      output: 'import {type Foo as Bar} from \'./foo.js\';',
+      filename: 'front_end/components/test.ts',
+      errors: [{messageId: 'convertTypeImport'}],
+    },
+    {
+      code: `import {SomeValue} from './foo.js';
+import type {Foo as Bar} from './foo.js';`,
+      output: 'import {SomeValue, type Foo as Bar} from \'./foo.js\';\n',
+      filename: 'front_end/components/test.ts',
+      errors: [{messageId: 'inlineTypeImport'}],
+    },
+    {
+      code: `import {SomeValue} from './foo.js';
+import type {Foo as Bar, Baz} from './foo.js';`,
+      output: 'import {SomeValue, type Foo as Bar, type Baz} from \'./foo.js\';\n',
+      filename: 'front_end/components/test.ts',
+      errors: [{messageId: 'inlineTypeImport'}],
+    },
+    {
+      code: `import type {SomeValue} from './baz.js';
+import type {Foo as Bar, Baz} from './foo.js';`,
+      output: `import {type SomeValue} from './baz.js';
+import {type Foo as Bar, type Baz} from './foo.js';`,
+      filename: 'front_end/components/test.ts',
+      errors: [{messageId: 'convertTypeImport'}, {messageId: 'convertTypeImport'}],
+    },
+  ]
+});

package/scripts/javascript_natives/index.js

@@ -4,7 +4,6 @@
 
 import * as fs from 'fs';
 import glob from 'glob';
-import * as path from 'path';
 import ts from 'typescript';
 import * as WebIDL2 from 'webidl2';
 
@@ -45,7 +44,7 @@ for (const file of files) {
   if (file.includes('testing')) {
     continue;
   }
-  const data = fs.readFileSync(path.join(process.env.PWD, file), 'utf8');
+  const data = fs.readFileSync(file, 'utf8');
   const lines = data.split('\n');
   const newLines = [];
   for (const line of lines) {