chrome-devtools-frontend 1.0.951410 → 1.0.952713

package/front_end/models/issues_manager/LowTextContrastIssue.ts

@@ -19,17 +19,17 @@ const str_ = i18n.i18n.registerUIStrings('models/issues_manager/LowTextContrastI
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 
 export class LowTextContrastIssue extends Issue {
-  private issueDetails: Protocol.Audits.LowTextContrastIssueDetails;
+  #issueDetails: Protocol.Audits.LowTextContrastIssueDetails;
 
   constructor(issueDetails: Protocol.Audits.LowTextContrastIssueDetails, issuesModel: SDK.IssuesModel.IssuesModel) {
     super('LowTextContrastIssue', issuesModel);
-    this.issueDetails = issueDetails;
+    this.#issueDetails = issueDetails;
   }
 
   primaryKey(): string {
     // We intend to keep only one issue per element so other issues for the element will be discarded even
     // if the issue content is slightly different.
-    return `${this.code()}-(${this.issueDetails.violatingNodeId})`;
+    return `${this.code()}-(${this.#issueDetails.violatingNodeId})`;
   }
 
   getCategory(): IssueCategory {
@@ -37,7 +37,7 @@ export class LowTextContrastIssue extends Issue {
   }
 
   details(): Protocol.Audits.LowTextContrastIssueDetails {
-    return this.issueDetails;
+    return this.#issueDetails;
   }
 
   getDescription(): MarkdownIssueDescription {

package/front_end/models/issues_manager/MixedContentIssue.ts

@@ -19,22 +19,22 @@ const str_ = i18n.i18n.registerUIStrings('models/issues_manager/MixedContentIssu
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 
 export class MixedContentIssue extends Issue {
-  private issueDetails: Protocol.Audits.MixedContentIssueDetails;
+  #issueDetails: Protocol.Audits.MixedContentIssueDetails;
 
   constructor(issueDetails: Protocol.Audits.MixedContentIssueDetails, issuesModel: SDK.IssuesModel.IssuesModel) {
     super(Protocol.Audits.InspectorIssueCode.MixedContentIssue, issuesModel);
-    this.issueDetails = issueDetails;
+    this.#issueDetails = issueDetails;
   }
 
   requests(): Iterable<Protocol.Audits.AffectedRequest> {
-    if (this.issueDetails.request) {
-      return [this.issueDetails.request];
+    if (this.#issueDetails.request) {
+      return [this.#issueDetails.request];
     }
     return [];
   }
 
   getDetails(): Protocol.Audits.MixedContentIssueDetails {
-    return this.issueDetails;
+    return this.#issueDetails;
   }
 
   getCategory(): IssueCategory {
@@ -50,11 +50,11 @@ export class MixedContentIssue extends Issue {
   }
 
   primaryKey(): string {
-    return JSON.stringify(this.issueDetails);
+    return JSON.stringify(this.#issueDetails);
   }
 
   getKind(): IssueKind {
-    switch (this.issueDetails.resolutionStatus) {
+    switch (this.#issueDetails.resolutionStatus) {
       case Protocol.Audits.MixedContentResolutionStatus.MixedContentAutomaticallyUpgraded:
         return IssueKind.Improvement;
       case Protocol.Audits.MixedContentResolutionStatus.MixedContentBlocked:

package/front_end/models/issues_manager/NavigatorUserAgentIssue.ts

@@ -27,11 +27,11 @@ export enum IssueCode {
 }
 
 export class NavigatorUserAgentIssue extends Issue<IssueCode> {
-  private issueDetails: Protocol.Audits.NavigatorUserAgentIssueDetails;
+  #issueDetails: Protocol.Audits.NavigatorUserAgentIssueDetails;
 
   constructor(issueDetails: Protocol.Audits.NavigatorUserAgentIssueDetails, issuesModel: SDK.IssuesModel.IssuesModel) {
     super(IssueCode.NavigatorUserAgentIssue, issuesModel);
-    this.issueDetails = issueDetails;
+    this.#issueDetails = issueDetails;
   }
 
   getCategory(): IssueCategory {
@@ -39,7 +39,7 @@ export class NavigatorUserAgentIssue extends Issue<IssueCode> {
   }
 
   details(): Protocol.Audits.NavigatorUserAgentIssueDetails {
-    return this.issueDetails;
+    return this.#issueDetails;
   }
 
   getDescription(): MarkdownIssueDescription|null {
@@ -53,14 +53,14 @@ export class NavigatorUserAgentIssue extends Issue<IssueCode> {
   }
 
   sources(): Iterable<Protocol.Audits.SourceCodeLocation> {
-    if (this.issueDetails.location) {
-      return [this.issueDetails.location];
+    if (this.#issueDetails.location) {
+      return [this.#issueDetails.location];
     }
     return [];
   }
 
   primaryKey(): string {
-    return JSON.stringify(this.issueDetails);
+    return JSON.stringify(this.#issueDetails);
   }
 
   getKind(): IssueKind {
@@ -69,7 +69,7 @@ export class NavigatorUserAgentIssue extends Issue<IssueCode> {
 
   isCausedByThirdParty(): boolean {
     const topFrame = SDK.FrameManager.FrameManager.instance().getTopFrame();
-    return isCausedByThirdParty(topFrame, this.issueDetails.url);
+    return isCausedByThirdParty(topFrame, this.#issueDetails.url);
   }
 
   static fromInspectorIssue(issuesModel: SDK.IssuesModel.IssuesModel, inspectorIssue: Protocol.Audits.InspectorIssue):

package/front_end/models/issues_manager/QuirksModeIssue.ts

@@ -19,17 +19,17 @@ const str_ = i18n.i18n.registerUIStrings('models/issues_manager/QuirksModeIssue.
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 
 export class QuirksModeIssue extends Issue {
-  private issueDetails: Protocol.Audits.QuirksModeIssueDetails;
+  #issueDetails: Protocol.Audits.QuirksModeIssueDetails;
 
   constructor(issueDetails: Protocol.Audits.QuirksModeIssueDetails, issuesModel: SDK.IssuesModel.IssuesModel) {
     const mode = issueDetails.isLimitedQuirksMode ? 'LimitedQuirksMode' : 'QuirksMode';
     const umaCode = [Protocol.Audits.InspectorIssueCode.QuirksModeIssue, mode].join('::');
     super({code: Protocol.Audits.InspectorIssueCode.QuirksModeIssue, umaCode}, issuesModel);
-    this.issueDetails = issueDetails;
+    this.#issueDetails = issueDetails;
   }
 
   primaryKey(): string {
-    return `${this.code()}-(${this.issueDetails.documentNodeId})-(${this.issueDetails.url})`;
+    return `${this.code()}-(${this.#issueDetails.documentNodeId})-(${this.#issueDetails.url})`;
   }
 
   getCategory(): IssueCategory {
@@ -37,7 +37,7 @@ export class QuirksModeIssue extends Issue {
   }
 
   details(): Protocol.Audits.QuirksModeIssueDetails {
-    return this.issueDetails;
+    return this.#issueDetails;
   }
 
   getDescription(): MarkdownIssueDescription {

package/front_end/models/issues_manager/SameSiteCookieIssue.ts

@@ -38,27 +38,27 @@ const str_ = i18n.i18n.registerUIStrings('models/issues_manager/SameSiteCookieIs
 const i18nLazyString = i18n.i18n.getLazilyComputedLocalizedString.bind(undefined, str_);
 
 export class SameSiteCookieIssue extends Issue {
-  private issueDetails: Protocol.Audits.SameSiteCookieIssueDetails;
+  #issueDetails: Protocol.Audits.SameSiteCookieIssueDetails;
 
   constructor(
       code: string, issueDetails: Protocol.Audits.SameSiteCookieIssueDetails,
       issuesModel: SDK.IssuesModel.IssuesModel) {
     super(code, issuesModel);
-    this.issueDetails = issueDetails;
+    this.#issueDetails = issueDetails;
   }
 
-  private cookieId(): string {
-    if (this.issueDetails.cookie) {
-      const {domain, path, name} = this.issueDetails.cookie;
+  #cookieId(): string {
+    if (this.#issueDetails.cookie) {
+      const {domain, path, name} = this.#issueDetails.cookie;
       const cookieId = `${domain};${path};${name}`;
       return cookieId;
     }
-    return this.issueDetails.rawCookieLine ?? 'no-cookie-info';
+    return this.#issueDetails.rawCookieLine ?? 'no-cookie-info';
   }
 
   primaryKey(): string {
-    const requestId = this.issueDetails.request ? this.issueDetails.request.requestId : 'no-request';
-    return `${this.code()}-(${this.cookieId()})-(${requestId})`;
+    const requestId = this.#issueDetails.request ? this.#issueDetails.request.requestId : 'no-request';
+    return `${this.code()}-(${this.#cookieId()})-(${requestId})`;
   }
 
   /**
@@ -162,22 +162,22 @@ export class SameSiteCookieIssue extends Issue {
   }
 
   cookies(): Iterable<Protocol.Audits.AffectedCookie> {
-    if (this.issueDetails.cookie) {
-      return [this.issueDetails.cookie];
+    if (this.#issueDetails.cookie) {
+      return [this.#issueDetails.cookie];
     }
     return [];
   }
 
   rawCookieLines(): Iterable<string> {
-    if (this.issueDetails.rawCookieLine) {
-      return [this.issueDetails.rawCookieLine];
+    if (this.#issueDetails.rawCookieLine) {
+      return [this.#issueDetails.rawCookieLine];
     }
     return [];
   }
 
   requests(): Iterable<Protocol.Audits.AffectedRequest> {
-    if (this.issueDetails.request) {
-      return [this.issueDetails.request];
+    if (this.#issueDetails.request) {
+      return [this.#issueDetails.request];
     }
     return [];
   }
@@ -196,11 +196,11 @@ export class SameSiteCookieIssue extends Issue {
 
   isCausedByThirdParty(): boolean {
     const topFrame = SDK.FrameManager.FrameManager.instance().getTopFrame();
-    return isCausedByThirdParty(topFrame, this.issueDetails.cookieUrl);
+    return isCausedByThirdParty(topFrame, this.#issueDetails.cookieUrl);
   }
 
   getKind(): IssueKind {
-    if (this.issueDetails.cookieExclusionReasons?.length > 0) {
+    if (this.#issueDetails.cookieExclusionReasons?.length > 0) {
       return IssueKind.PageError;
     }
     return IssueKind.BreakingChange;

package/front_end/models/issues_manager/SharedArrayBufferIssue.ts

@@ -20,12 +20,12 @@ const str_ = i18n.i18n.registerUIStrings('models/issues_manager/SharedArrayBuffe
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 
 export class SharedArrayBufferIssue extends Issue {
-  private issueDetails: Protocol.Audits.SharedArrayBufferIssueDetails;
+  #issueDetails: Protocol.Audits.SharedArrayBufferIssueDetails;
 
   constructor(issueDetails: Protocol.Audits.SharedArrayBufferIssueDetails, issuesModel: SDK.IssuesModel.IssuesModel) {
     const umaCode = [Protocol.Audits.InspectorIssueCode.SharedArrayBufferIssue, issueDetails.type].join('::');
     super({code: Protocol.Audits.InspectorIssueCode.SharedArrayBufferIssue, umaCode}, issuesModel);
-    this.issueDetails = issueDetails;
+    this.#issueDetails = issueDetails;
   }
 
   getCategory(): IssueCategory {
@@ -33,7 +33,7 @@ export class SharedArrayBufferIssue extends Issue {
   }
 
   details(): Protocol.Audits.SharedArrayBufferIssueDetails {
-    return this.issueDetails;
+    return this.#issueDetails;
   }
 
   getDescription(): MarkdownIssueDescription {
@@ -47,11 +47,11 @@ export class SharedArrayBufferIssue extends Issue {
   }
 
   primaryKey(): string {
-    return JSON.stringify(this.issueDetails);
+    return JSON.stringify(this.#issueDetails);
   }
 
   getKind(): IssueKind {
-    if (this.issueDetails.isWarning) {
+    if (this.#issueDetails.isWarning) {
       return IssueKind.BreakingChange;
     }
     return IssueKind.PageError;

package/front_end/models/issues_manager/SourceFrameIssuesManager.ts

@@ -16,21 +16,21 @@ import {Events} from './IssuesManagerEvents.js';
 import {getIssueTitleFromMarkdownDescription} from './MarkdownIssueDescription.js';
 
 export class SourceFrameIssuesManager {
-  private locationPool = new Bindings.LiveLocation.LiveLocationPool();
-  private issueMessages = new Array<IssueMessage>();
+  #locationPool = new Bindings.LiveLocation.LiveLocationPool();
+  #issueMessages = new Array<IssueMessage>();
 
   constructor(private readonly issuesManager: IssuesManager) {
-    this.issuesManager.addEventListener(Events.IssueAdded, this.onIssueAdded, this);
-    this.issuesManager.addEventListener(Events.FullUpdateRequired, this.onFullUpdateRequired, this);
+    this.issuesManager.addEventListener(Events.IssueAdded, this.#onIssueAdded, this);
+    this.issuesManager.addEventListener(Events.FullUpdateRequired, this.#onFullUpdateRequired, this);
   }
 
-  private onIssueAdded(event: Common.EventTarget.EventTargetEvent<IssueAddedEvent>): void {
+  #onIssueAdded(event: Common.EventTarget.EventTargetEvent<IssueAddedEvent>): void {
     const {issue} = event.data;
-    this.addIssue(issue);
+    this.#addIssue(issue);
   }
 
-  private addIssue(issue: Issue): void {
-    if (!this.isTrustedTypeIssue(issue)) {
+  #addIssue(issue: Issue): void {
+    if (!this.#isTrustedTypeIssue(issue)) {
       return;
     }
     const issuesModel = issue.model();
@@ -43,20 +43,20 @@ export class SourceFrameIssuesManager {
       const rawLocation =
           debuggerModel.createRawLocationByURL(srcLocation.url, srcLocation.lineNumber, srcLocation.columnNumber);
       if (rawLocation) {
-        this.addIssueMessageToScript(issue, rawLocation);
+        this.#addIssueMessageToScript(issue, rawLocation);
       }
     }
   }
 
-  private onFullUpdateRequired(): void {
-    this.resetMessages();
+  #onFullUpdateRequired(): void {
+    this.#resetMessages();
     const issues = this.issuesManager.issues();
     for (const issue of issues) {
-      this.addIssue(issue);
+      this.#addIssue(issue);
     }
   }
 
-  private async addIssueMessageToScript(issue: Issue, rawLocation: SDK.DebuggerModel.Location): Promise<void> {
+  async #addIssueMessageToScript(issue: Issue, rawLocation: SDK.DebuggerModel.Location): Promise<void> {
     const description = issue.getDescription();
     if (description) {
       const title = await getIssueTitleFromMarkdownDescription(description);
@@ -64,58 +64,59 @@ export class SourceFrameIssuesManager {
         const clickHandler = (): void => {
           Common.Revealer.reveal(issue);
         };
-        this.issueMessages.push(new IssueMessage(title, issue.getKind(), rawLocation, this.locationPool, clickHandler));
+        this.#issueMessages.push(
+            new IssueMessage(title, issue.getKind(), rawLocation, this.#locationPool, clickHandler));
       }
     }
   }
 
-  private isTrustedTypeIssue(issue: Issue): issue is ContentSecurityPolicyIssue {
+  #isTrustedTypeIssue(issue: Issue): issue is ContentSecurityPolicyIssue {
     return issue instanceof ContentSecurityPolicyIssue && issue.code() === trustedTypesSinkViolationCode ||
         issue.code() === trustedTypesPolicyViolationCode;
   }
 
-  private resetMessages(): void {
-    for (const message of this.issueMessages) {
+  #resetMessages(): void {
+    for (const message of this.#issueMessages) {
       message.dispose();
     }
-    this.issueMessages = [];
-    this.locationPool.disposeAll();
+    this.#issueMessages = [];
+    this.#locationPool.disposeAll();
   }
 }
 
 export class IssueMessage extends Workspace.UISourceCode.Message {
-  private uiSourceCode?: Workspace.UISourceCode.UISourceCode = undefined;
-  private kind: IssueKind;
+  #uiSourceCode?: Workspace.UISourceCode.UISourceCode = undefined;
+  #kind: IssueKind;
 
   constructor(
       title: string, kind: IssueKind, rawLocation: SDK.DebuggerModel.Location,
       locationPool: Bindings.LiveLocation.LiveLocationPool, clickHandler: () => void) {
     super(Workspace.UISourceCode.Message.Level.Issue, title, clickHandler);
-    this.kind = kind;
+    this.#kind = kind;
     Bindings.DebuggerWorkspaceBinding.DebuggerWorkspaceBinding.instance().createLiveLocation(
-        rawLocation, this.updateLocation.bind(this), locationPool);
+        rawLocation, this.#updateLocation.bind(this), locationPool);
   }
 
-  private async updateLocation(liveLocation: Bindings.LiveLocation.LiveLocation): Promise<void> {
-    if (this.uiSourceCode) {
-      this.uiSourceCode.removeMessage(this);
+  async #updateLocation(liveLocation: Bindings.LiveLocation.LiveLocation): Promise<void> {
+    if (this.#uiSourceCode) {
+      this.#uiSourceCode.removeMessage(this);
     }
     const uiLocation = await liveLocation.uiLocation();
     if (!uiLocation) {
       return;
     }
     this.range = TextUtils.TextRange.TextRange.createFromLocation(uiLocation.lineNumber, uiLocation.columnNumber || 0);
-    this.uiSourceCode = uiLocation.uiSourceCode;
-    this.uiSourceCode.addMessage(this);
+    this.#uiSourceCode = uiLocation.uiSourceCode;
+    this.#uiSourceCode.addMessage(this);
   }
 
   getIssueKind(): IssueKind {
-    return this.kind;
+    return this.#kind;
   }
 
   dispose(): void {
-    if (this.uiSourceCode) {
-      this.uiSourceCode.removeMessage(this);
+    if (this.#uiSourceCode) {
+      this.#uiSourceCode.removeMessage(this);
     }
   }
 }

package/front_end/models/issues_manager/TrustedWebActivityIssue.ts

@@ -20,21 +20,21 @@ const str_ = i18n.i18n.registerUIStrings('models/issues_manager/TrustedWebActivi
 const i18nLazyString = i18n.i18n.getLazilyComputedLocalizedString.bind(undefined, str_);
 
 export class TrustedWebActivityIssue extends Issue {
-  private issueDetails: Protocol.Audits.TrustedWebActivityIssueDetails;
+  #issueDetails: Protocol.Audits.TrustedWebActivityIssueDetails;
 
   constructor(issueDetails: Protocol.Audits.TrustedWebActivityIssueDetails) {
     const issueCode =
         [Protocol.Audits.InspectorIssueCode.TrustedWebActivityIssue, issueDetails.violationType].join('::');
     super(issueCode);
-    this.issueDetails = issueDetails;
+    this.#issueDetails = issueDetails;
   }
 
   details(): Protocol.Audits.TrustedWebActivityIssueDetails {
-    return this.issueDetails;
+    return this.#issueDetails;
   }
 
   getDescription(): MarkdownIssueDescription|null {
-    const description = issueDescriptions.get(this.issueDetails.violationType);
+    const description = issueDescriptions.get(this.#issueDetails.violationType);
     if (!description) {
       return null;
     }
@@ -46,7 +46,7 @@ export class TrustedWebActivityIssue extends Issue {
   }
 
   primaryKey(): string {
-    return `${Protocol.Audits.InspectorIssueCode.TrustedWebActivityIssue}-${JSON.stringify(this.issueDetails)}`;
+    return `${Protocol.Audits.InspectorIssueCode.TrustedWebActivityIssue}-${JSON.stringify(this.#issueDetails)}`;
   }
 
   getKind(): IssueKind {

package/front_end/models/issues_manager/WasmCrossOriginModuleSharingIssue.ts

@@ -20,13 +20,13 @@ const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 
 export class WasmCrossOriginModuleSharingIssue extends
     Issue<Protocol.Audits.InspectorIssueCode.WasmCrossOriginModuleSharingIssue> {
-  private issueDetails: Protocol.Audits.WasmCrossOriginModuleSharingIssueDetails;
+  #issueDetails: Protocol.Audits.WasmCrossOriginModuleSharingIssueDetails;
 
   constructor(
       issueDetails: Protocol.Audits.WasmCrossOriginModuleSharingIssueDetails,
       issuesModel: SDK.IssuesModel.IssuesModel) {
     super(Protocol.Audits.InspectorIssueCode.WasmCrossOriginModuleSharingIssue, issuesModel);
-    this.issueDetails = issueDetails;
+    this.#issueDetails = issueDetails;
   }
 
   getCategory(): IssueCategory {
@@ -34,7 +34,7 @@ export class WasmCrossOriginModuleSharingIssue extends
   }
 
   details(): Protocol.Audits.WasmCrossOriginModuleSharingIssueDetails {
-    return this.issueDetails;
+    return this.#issueDetails;
   }
 
   getDescription(): MarkdownIssueDescription|null {
@@ -48,11 +48,11 @@ export class WasmCrossOriginModuleSharingIssue extends
   }
 
   primaryKey(): string {
-    return JSON.stringify(this.issueDetails);
+    return JSON.stringify(this.#issueDetails);
   }
 
   getKind(): IssueKind {
-    return this.issueDetails.isWarning ? IssueKind.BreakingChange : IssueKind.PageError;
+    return this.#issueDetails.isWarning ? IssueKind.BreakingChange : IssueKind.PageError;
   }
 
   static fromInspectorIssue(issuesModel: SDK.IssuesModel.IssuesModel, inspectorIssue: Protocol.Audits.InspectorIssue):

package/front_end/models/issues_manager/descriptions/clientHintMetaTagAllowListInvalidOrigin.md

@@ -0,0 +1,4 @@
+# Client Hint meta tag contained invalid origin
+
+Items in the accept-ch meta tag allow list must be valid origins.
+No special values (e.g. self, none, and *) are permitted.

package/front_end/models/issues_manager/descriptions/clientHintMetaTagModifiedHTML.md

@@ -0,0 +1,4 @@
+# Client Hint meta tag modified by javascript
+
+Only accept-ch meta tags in the original HTML sent from the server
+are respected. Any injected via javascript (or other means) are ignored.

package/front_end/models/issues_manager/issues_manager.ts

@@ -3,6 +3,7 @@
 // found in the LICENSE file.
 
 import * as AttributionReportingIssue from './AttributionReportingIssue.js';
+import * as ClientHintIssue from './ClientHintIssue.js';
 import * as ContentSecurityPolicyIssue from './ContentSecurityPolicyIssue.js';
 import * as ContrastCheckTrigger from './ContrastCheckTrigger.js';
 import * as CorsIssue from './CorsIssue.js';
@@ -27,6 +28,7 @@ import * as WasmCrossOriginModuleSharingIssue from './WasmCrossOriginModuleShari
 
 export {
   AttributionReportingIssue,
+  ClientHintIssue,
   ContentSecurityPolicyIssue,
   ContrastCheckTrigger,
   CorsIssue,

package/front_end/models/timeline_model/TimelineModel.ts

@@ -122,7 +122,7 @@ export class TimelineModelImpl {
   static forEachEvent(
       events: SDK.TracingModel.Event[], onStartEvent: (arg0: SDK.TracingModel.Event) => void,
       onEndEvent: (arg0: SDK.TracingModel.Event) => void,
-      onInstantEvent?: ((arg0: SDK.TracingModel.Event, arg1: SDK.TracingModel.Event|null) => any), startTime?: number,
+      onInstantEvent?: ((arg0: SDK.TracingModel.Event, arg1: SDK.TracingModel.Event|null) => void), startTime?: number,
       endTime?: number, filter?: ((arg0: SDK.TracingModel.Event) => boolean)): void {
     startTime = startTime || 0;
     endTime = endTime || Infinity;