chrome-devtools-frontend 1.0.951410 → 1.0.952713

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (214) hide show
  1. package/config/gni/devtools_grd_files.gni +3 -0
  2. package/extension-api/ExtensionAPI.d.ts +1 -1
  3. package/front_end/.eslintrc.js +6 -0
  4. package/front_end/Tests.js +10 -0
  5. package/front_end/core/common/App.ts +0 -3
  6. package/front_end/core/common/AppProvider.ts +0 -3
  7. package/front_end/core/common/JavaScriptMetaData.ts +0 -3
  8. package/front_end/core/common/QueryParamHandler.ts +0 -3
  9. package/front_end/core/common/Runnable.ts +0 -3
  10. package/front_end/core/common/SimpleHistoryManager.ts +0 -3
  11. package/front_end/core/host/UserMetrics.ts +2 -1
  12. package/front_end/core/i18n/locales/en-US.json +3 -0
  13. package/front_end/core/i18n/locales/en-XL.json +3 -0
  14. package/front_end/core/root/Runtime.ts +4 -12
  15. package/front_end/core/sdk/OverlayPersistentHighlighter.ts +0 -12
  16. package/front_end/core/sdk/PageResourceLoader.ts +2 -1
  17. package/front_end/core/sdk/TracingManager.ts +0 -3
  18. package/front_end/entrypoints/formatter_worker/AcornTokenizer.ts +39 -39
  19. package/front_end/entrypoints/formatter_worker/CSSFormatter.ts +54 -54
  20. package/front_end/entrypoints/formatter_worker/ESTreeWalker.ts +20 -20
  21. package/front_end/entrypoints/formatter_worker/FormattedContentBuilder.ts +54 -54
  22. package/front_end/entrypoints/formatter_worker/HTMLFormatter.ts +145 -144
  23. package/front_end/entrypoints/formatter_worker/JavaScriptFormatter.ts +40 -40
  24. package/front_end/entrypoints/heap_snapshot_worker/AllocationProfile.ts +64 -69
  25. package/front_end/entrypoints/heap_snapshot_worker/HeapSnapshot.ts +203 -203
  26. package/front_end/entrypoints/heap_snapshot_worker/HeapSnapshotLoader.ts +109 -108
  27. package/front_end/entrypoints/heap_snapshot_worker/HeapSnapshotWorkerDispatcher.ts +17 -17
  28. package/front_end/entrypoints/inspector_main/InspectorMain.ts +30 -30
  29. package/front_end/entrypoints/inspector_main/RenderingOptions.ts +25 -25
  30. package/front_end/entrypoints/main/ExecutionContextSelector.ts +52 -55
  31. package/front_end/entrypoints/main/MainImpl.ts +49 -49
  32. package/front_end/entrypoints/node_app/NodeConnectionsPanel.ts +43 -43
  33. package/front_end/entrypoints/node_app/NodeMain.ts +38 -38
  34. package/front_end/generated/InspectorBackendCommands.js +5 -1
  35. package/front_end/generated/protocol.d.ts +16 -0
  36. package/front_end/legacy/legacy-defs.d.ts +0 -21
  37. package/front_end/models/bindings/CSSWorkspaceBinding.ts +0 -3
  38. package/front_end/models/bindings/DebuggerWorkspaceBinding.ts +0 -3
  39. package/front_end/models/bindings/FileUtils.ts +0 -3
  40. package/front_end/models/extensions/ExtensionAPI.ts +2 -1
  41. package/front_end/models/extensions/ExtensionTraceProvider.ts +0 -3
  42. package/front_end/models/heap_snapshot_model/HeapSnapshotModel.ts +1 -1
  43. package/front_end/models/issues_manager/ClientHintIssue.ts +95 -0
  44. package/front_end/models/issues_manager/ContentSecurityPolicyIssue.ts +6 -6
  45. package/front_end/models/issues_manager/ContrastCheckTrigger.ts +15 -15
  46. package/front_end/models/issues_manager/CorsIssue.ts +9 -9
  47. package/front_end/models/issues_manager/CrossOriginEmbedderPolicyIssue.ts +5 -5
  48. package/front_end/models/issues_manager/DeprecationIssue.ts +7 -7
  49. package/front_end/models/issues_manager/GenericIssue.ts +5 -5
  50. package/front_end/models/issues_manager/HeavyAdIssue.ts +5 -5
  51. package/front_end/models/issues_manager/Issue.ts +10 -10
  52. package/front_end/models/issues_manager/IssueResolver.ts +11 -10
  53. package/front_end/models/issues_manager/IssuesManager.ts +61 -56
  54. package/front_end/models/issues_manager/LowTextContrastIssue.ts +4 -4
  55. package/front_end/models/issues_manager/MixedContentIssue.ts +7 -7
  56. package/front_end/models/issues_manager/NavigatorUserAgentIssue.ts +7 -7
  57. package/front_end/models/issues_manager/QuirksModeIssue.ts +4 -4
  58. package/front_end/models/issues_manager/SameSiteCookieIssue.ts +16 -16
  59. package/front_end/models/issues_manager/SharedArrayBufferIssue.ts +5 -5
  60. package/front_end/models/issues_manager/SourceFrameIssuesManager.ts +32 -31
  61. package/front_end/models/issues_manager/TrustedWebActivityIssue.ts +5 -5
  62. package/front_end/models/issues_manager/WasmCrossOriginModuleSharingIssue.ts +5 -5
  63. package/front_end/models/issues_manager/descriptions/clientHintMetaTagAllowListInvalidOrigin.md +4 -0
  64. package/front_end/models/issues_manager/descriptions/clientHintMetaTagModifiedHTML.md +4 -0
  65. package/front_end/models/issues_manager/issues_manager.ts +2 -0
  66. package/front_end/models/timeline_model/TimelineModel.ts +1 -1
  67. package/front_end/panels/application/components/BackForwardCacheView.ts +33 -33
  68. package/front_end/panels/application/components/EndpointsGrid.ts +12 -12
  69. package/front_end/panels/application/components/FrameDetailsView.ts +108 -110
  70. package/front_end/panels/application/components/OriginTrialTreeView.ts +45 -45
  71. package/front_end/panels/application/components/PermissionsPolicySection.ts +19 -19
  72. package/front_end/panels/application/components/ReportsGrid.ts +30 -30
  73. package/front_end/panels/application/components/StackTrace.ts +48 -47
  74. package/front_end/panels/application/components/TrustTokensView.ts +31 -31
  75. package/front_end/panels/console/ConsoleView.ts +1 -1
  76. package/front_end/panels/console/ConsoleViewMessage.ts +1 -25
  77. package/front_end/panels/console/consoleView.css +5 -0
  78. package/front_end/panels/css_overview/CSSOverviewCompletedView.ts +41 -52
  79. package/front_end/panels/css_overview/CSSOverviewController.ts +2 -2
  80. package/front_end/panels/css_overview/CSSOverviewPanel.ts +18 -27
  81. package/front_end/panels/css_overview/CSSOverviewProcessingView.ts +2 -2
  82. package/front_end/panels/css_overview/CSSOverviewSidebarPanel.ts +6 -6
  83. package/front_end/panels/css_overview/components/CSSOverviewStartView.ts +4 -4
  84. package/front_end/panels/elements/ElementsTreeElement.ts +2 -6
  85. package/front_end/panels/elements/components/AccessibilityTreeNode.ts +17 -17
  86. package/front_end/panels/elements/components/AdornerManager.ts +21 -21
  87. package/front_end/panels/elements/components/AdornerSettingsPane.ts +14 -14
  88. package/front_end/panels/elements/components/CSSQuery.ts +16 -16
  89. package/front_end/panels/elements/components/ComputedStyleProperty.ts +14 -14
  90. package/front_end/panels/elements/components/ComputedStyleTrace.ts +15 -15
  91. package/front_end/panels/elements/components/ElementsBreadcrumbs.ts +78 -78
  92. package/front_end/panels/elements/components/ElementsPanelLink.ts +16 -16
  93. package/front_end/panels/elements/components/LayoutPane.ts +47 -47
  94. package/front_end/panels/elements/components/NodeText.ts +18 -18
  95. package/front_end/panels/elements/components/QueryContainer.ts +40 -40
  96. package/front_end/panels/elements/components/StylePropertyEditor.ts +18 -18
  97. package/front_end/panels/emulation/components/DeviceSizeInputElement.ts +4 -4
  98. package/front_end/panels/event_listeners/EventListenersUtils.ts +2 -1
  99. package/front_end/panels/issues/AffectedBlockedByResponseView.ts +4 -4
  100. package/front_end/panels/issues/AffectedCookiesView.ts +4 -5
  101. package/front_end/panels/issues/AffectedDirectivesView.ts +19 -19
  102. package/front_end/panels/issues/AffectedDocumentsInQuirksModeView.ts +7 -8
  103. package/front_end/panels/issues/AffectedElementsView.ts +4 -4
  104. package/front_end/panels/issues/AffectedElementsWithLowContrastView.ts +7 -8
  105. package/front_end/panels/issues/AffectedHeavyAdView.ts +8 -8
  106. package/front_end/panels/issues/AffectedResourcesView.ts +25 -26
  107. package/front_end/panels/issues/AffectedSharedArrayBufferIssueDetailsView.ts +8 -8
  108. package/front_end/panels/issues/AffectedSourcesView.ts +4 -4
  109. package/front_end/panels/issues/AffectedTrustedWebActivityIssueDetailsView.ts +4 -4
  110. package/front_end/panels/issues/AttributionReportingIssueDetailsView.ts +17 -17
  111. package/front_end/panels/issues/CSPViolationsListView.ts +22 -23
  112. package/front_end/panels/issues/CSPViolationsView.ts +17 -17
  113. package/front_end/panels/issues/ComboBoxOfCheckBoxes.ts +13 -13
  114. package/front_end/panels/issues/CorsIssueDetailsView.ts +23 -23
  115. package/front_end/panels/issues/GenericIssueDetailsView.ts +4 -4
  116. package/front_end/panels/issues/HiddenIssuesRow.ts +7 -7
  117. package/front_end/panels/issues/IssueAggregator.ts +95 -95
  118. package/front_end/panels/issues/IssueKindView.ts +14 -14
  119. package/front_end/panels/issues/IssueView.ts +98 -98
  120. package/front_end/panels/issues/IssuesPane.ts +102 -102
  121. package/front_end/panels/issues/WasmCrossOriginModuleSharingAffectedResourcesView.ts +5 -5
  122. package/front_end/panels/issues/components/HideIssuesMenu.ts +10 -10
  123. package/front_end/panels/media/PlayerListView.ts +160 -97
  124. package/front_end/panels/media/PlayerMessagesView.ts +1 -0
  125. package/front_end/panels/media/playerListView.css +58 -0
  126. package/front_end/panels/network/NetworkLogView.ts +2 -6
  127. package/front_end/panels/network/NetworkWaterfallColumn.ts +2 -4
  128. package/front_end/panels/network/components/RequestTrustTokensView.ts +40 -40
  129. package/front_end/panels/network/components/WebBundleInfoView.ts +9 -9
  130. package/front_end/panels/performance_monitor/PerformanceMonitor.ts +92 -37
  131. package/front_end/panels/performance_monitor/performanceMonitor.css +32 -0
  132. package/front_end/panels/protocol_monitor/ProtocolMonitor.ts +2 -2
  133. package/front_end/panels/search/SearchConfig.ts +0 -6
  134. package/front_end/panels/settings/KeybindsSettingsTab.ts +4 -0
  135. package/front_end/panels/settings/components/SyncSection.ts +14 -14
  136. package/front_end/panels/settings/emulation/components/UserAgentClientHintsForm.ts +96 -96
  137. package/front_end/panels/sources/BreakpointEditDialog.ts +4 -3
  138. package/front_end/panels/sources/NavigatorView.ts +3 -9
  139. package/front_end/panels/sources/SourceMapNamesResolver.ts +3 -3
  140. package/front_end/panels/sources/SourcesPanel.ts +1 -3
  141. package/front_end/panels/sources/SourcesView.ts +0 -3
  142. package/front_end/panels/sources/TabbedEditorContainer.ts +0 -3
  143. package/front_end/panels/timeline/TimelineFlameChartView.ts +1 -1
  144. package/front_end/panels/timeline/TimelineLoader.ts +0 -3
  145. package/front_end/panels/timeline/TimelineTreeView.ts +1 -1
  146. package/front_end/panels/timeline/components/WebVitalsLane.ts +77 -76
  147. package/front_end/panels/timeline/components/WebVitalsTimeline.ts +133 -133
  148. package/front_end/panels/timeline/components/WebVitalsTooltip.ts +9 -9
  149. package/front_end/panels/webauthn/WebauthnPane.ts +203 -205
  150. package/front_end/third_party/codemirror.next/bundle.ts +3 -3
  151. package/front_end/third_party/codemirror.next/chunk/codemirror.js +1 -1
  152. package/front_end/third_party/codemirror.next/chunk/markdown.js +2 -1
  153. package/front_end/third_party/codemirror.next/codemirror.next.d.ts +10 -1
  154. package/front_end/third_party/codemirror.next/codemirror.next.js +2 -1
  155. package/front_end/third_party/codemirror.next/package.json +3 -3
  156. package/front_end/third_party/diff/DiffWrapper.ts +7 -0
  157. package/front_end/ui/components/adorners/Adorner.ts +2 -2
  158. package/front_end/ui/components/buttons/Button.ts +9 -9
  159. package/front_end/ui/components/data_grid/DataGrid.ts +64 -64
  160. package/front_end/ui/components/data_grid/DataGridController.ts +22 -22
  161. package/front_end/ui/components/data_grid/DataGridUtils.ts +3 -0
  162. package/front_end/ui/components/diff_view/DiffView.ts +6 -6
  163. package/front_end/ui/components/expandable_list/ExpandableList.ts +5 -5
  164. package/front_end/ui/components/icon_button/Icon.ts +4 -4
  165. package/front_end/ui/components/icon_button/IconButton.ts +4 -4
  166. package/front_end/ui/components/issue_counter/IssueCounter.ts +3 -3
  167. package/front_end/ui/components/issue_counter/IssueLinkIcon.ts +11 -11
  168. package/front_end/ui/components/linear_memory_inspector/LinearMemoryInspector.ts +50 -50
  169. package/front_end/ui/components/linear_memory_inspector/LinearMemoryInspectorController.ts +6 -6
  170. package/front_end/ui/components/linear_memory_inspector/LinearMemoryInspectorPane.ts +4 -4
  171. package/front_end/ui/components/linear_memory_inspector/LinearMemoryNavigator.ts +12 -12
  172. package/front_end/ui/components/linear_memory_inspector/LinearMemoryValueInterpreter.ts +11 -11
  173. package/front_end/ui/components/linear_memory_inspector/LinearMemoryViewer.ts +40 -39
  174. package/front_end/ui/components/linear_memory_inspector/ValueInterpreterDisplay.ts +18 -18
  175. package/front_end/ui/components/linear_memory_inspector/ValueInterpreterSettings.ts +6 -6
  176. package/front_end/ui/components/linkifier/LinkifierImpl.ts +4 -4
  177. package/front_end/ui/components/markdown_view/MarkdownImage.ts +5 -5
  178. package/front_end/ui/components/markdown_view/MarkdownLink.ts +2 -2
  179. package/front_end/ui/components/markdown_view/MarkdownView.ts +4 -4
  180. package/front_end/ui/components/panel_feedback/FeedbackButton.ts +2 -2
  181. package/front_end/ui/components/panel_feedback/PanelFeedback.ts +2 -2
  182. package/front_end/ui/components/panel_feedback/PreviewToggle.ts +4 -4
  183. package/front_end/ui/components/render_coordinator/RenderCoordinator.ts +22 -22
  184. package/front_end/ui/components/report_view/ReportView.ts +16 -16
  185. package/front_end/ui/components/request_link_icon/RequestLinkIcon.ts +14 -14
  186. package/front_end/ui/components/settings/SettingCheckbox.ts +5 -5
  187. package/front_end/ui/components/survey_link/SurveyLink.ts +8 -8
  188. package/front_end/ui/components/text_editor/TextEditor.ts +9 -9
  189. package/front_end/ui/components/text_editor/cursor_tooltip.ts +7 -1
  190. package/front_end/ui/components/text_prompt/TextPrompt.ts +18 -18
  191. package/front_end/ui/components/tree_outline/TreeOutline.ts +69 -70
  192. package/front_end/ui/legacy/ContextFlavorListener.ts +0 -4
  193. package/front_end/ui/legacy/SearchableView.ts +13 -4
  194. package/front_end/ui/legacy/SuggestBox.ts +0 -3
  195. package/front_end/ui/legacy/components/data_grid/DataGrid.ts +6 -6
  196. package/front_end/ui/legacy/components/perf_ui/FlameChart.ts +0 -3
  197. package/front_end/ui/legacy/components/source_frame/JSONView.ts +1 -1
  198. package/front_end/ui/legacy/components/source_frame/SourceFrame.ts +13 -12
  199. package/front_end/ui/legacy/components/source_frame/XMLView.ts +2 -2
  200. package/front_end/ui/legacy/themeColors.css +2 -0
  201. package/front_end/ui/legacy/theme_support/theme_support_impl.ts +34 -7
  202. package/package.json +1 -1
  203. package/scripts/eslint_rules/lib/use_private_class_members.js +41 -0
  204. package/scripts/eslint_rules/tests/use_private_class_members_test.js +62 -0
  205. package/scripts/migration/class-fields/migrate.js +2 -3
  206. package/scripts/migration/class-fields/migrate.sh +1 -3
  207. package/scripts/migration/class-fields/package.json +1 -1
  208. package/config/gni/all_devtools_files.gni +0 -255
  209. package/scripts/build/devtools_file_hashes.py +0 -82
  210. package/scripts/devtools_run/devtools_run_cli +0 -49
  211. package/scripts/devtools_run/package.json +0 -13
  212. package/scripts/unzip.py +0 -20
  213. package/scripts/visualize_deps/jquery_svg.html +0 -57
  214. package/scripts/visualize_deps/run_visualize.js +0 -119
@@ -41,7 +41,7 @@ import inspectorSyntaxHighlightDarkStyles from '../inspectorSyntaxHighlightDark.
41
41
 
42
42
  let themeSupportInstance: ThemeSupport;
43
43
 
44
- const themeValuesCache = new Map<string, string>();
44
+ const themeValuesCache = new Map<CSSStyleDeclaration, Map<string, string>>();
45
45
 
46
46
  export class ThemeSupport {
47
47
  private readonly themeNameInternal: string;
@@ -96,20 +96,35 @@ export class ThemeSupport {
96
96
  return themeSupportInstance;
97
97
  }
98
98
 
99
- getComputedValue(variableName: string): string {
100
- const computedRoot = this.computedRoot();
101
-
99
+ getComputedValue(variableName: string, target: Element|null = null): string {
100
+ const computedRoot = target ? window.getComputedStyle(target) : this.computedRoot();
102
101
  if (typeof computedRoot === 'symbol') {
103
102
  throw new Error(`Computed value for property (${variableName}) could not be found on :root.`);
104
103
  }
105
104
 
105
+ // Since we might query the same variable name from various targets we need to support
106
+ // per-target caching of computed values. Here we attempt to locate the particular computed
107
+ // value cache for the target. If no target was specified we use the default computed root,
108
+ // which belongs to the document element.
109
+ let computedRootCache = themeValuesCache.get(computedRoot);
110
+ if (!computedRootCache) {
111
+ computedRootCache = new Map<string, string>();
112
+ themeValuesCache.set(computedRoot, computedRootCache);
113
+ }
114
+
106
115
  // Since theme changes trigger a reload, we can avoid repeatedly looking up color values
107
116
  // dynamically. Instead we can look up the first time and cache them for future use,
108
117
  // knowing that the cache will be invalidated by virtue of a reload when the theme changes.
109
- let cachedValue = themeValuesCache.get(variableName);
118
+ let cachedValue = computedRootCache.get(variableName);
110
119
  if (!cachedValue) {
111
- cachedValue = computedRoot.getPropertyValue(variableName);
112
- themeValuesCache.set(variableName, cachedValue);
120
+ cachedValue = computedRoot.getPropertyValue(variableName).trim();
121
+
122
+ // If we receive back an empty value (nothing has been set) we don't store it for the future.
123
+ // This means that subsequent requests will continue to query the styles in case the value
124
+ // has been set.
125
+ if (cachedValue) {
126
+ computedRootCache.set(variableName, cachedValue);
127
+ }
113
128
  }
114
129
 
115
130
  return cachedValue;
@@ -291,6 +306,12 @@ export class ThemeSupport {
291
306
  output.push(';');
292
307
  }
293
308
 
309
+ /**
310
+ * This legacy function has been supeseded by CSS custom properties. Wherever possible, please use
311
+ * the values declared in global stylesheets.
312
+ *
313
+ * @deprecated
314
+ */
294
315
  patchColorText(text: string, colorUsage: number): string {
295
316
  const color = Common.Color.Color.parse(text);
296
317
  if (!color) {
@@ -304,6 +325,12 @@ export class ThemeSupport {
304
325
  return outText || text;
305
326
  }
306
327
 
328
+ /**
329
+ * This legacy function has been supeseded by CSS custom properties. Wherever possible, please use
330
+ * the values declared in global stylesheets.
331
+ *
332
+ * @deprecated
333
+ */
307
334
  patchColor(color: Common.Color.Color, colorUsage: number): Common.Color.Color {
308
335
  const hsla = color.hsla();
309
336
  this.patchHSLA(hsla, colorUsage);
package/package.json CHANGED
@@ -53,5 +53,5 @@
53
53
  "unittest": "scripts/test/run_unittests.py --no-text-coverage",
54
54
  "watch": "third_party/node/node.py --output scripts/watch_build.js"
55
55
  },
56
- "version": "1.0.951410"
56
+ "version": "1.0.952713"
57
57
  }
@@ -0,0 +1,41 @@
1
+ // Copyright 2021 The Chromium Authors. All rights reserved.
2
+ // Use of this source code is governed by a BSD-style license that can be
3
+ // found in the LICENSE file.
4
+
5
+ /**
6
+ * @fileoverview Rule to ban private keyword in components
7
+ * @author Tim van der Lippe
8
+ */
9
+ 'use strict';
10
+
11
+ // ------------------------------------------------------------------------------
12
+ // Rule Definition
13
+ // ------------------------------------------------------------------------------
14
+
15
+ module.exports = {
16
+ meta: {
17
+ type: 'problem',
18
+
19
+ docs: {
20
+ description: 'Usage of private keyword',
21
+ category: 'Possible Errors',
22
+ },
23
+
24
+ fixable: 'code',
25
+ schema: [], // no options
26
+ messages:
27
+ {do_not_use_private: 'Use private class notation (start the name with a `#`) rather than the private keyword'},
28
+ },
29
+ create: function(context) {
30
+ return {
31
+ ['MethodDefinition, PropertyDefinition'](node) {
32
+ if (node.accessibility === 'private' && node.kind !== 'constructor') {
33
+ context.report({
34
+ node: node.key,
35
+ messageId: 'do_not_use_private',
36
+ });
37
+ }
38
+ }
39
+ };
40
+ }
41
+ };
@@ -0,0 +1,62 @@
1
+ // Copyright 2020 The Chromium Authors. All rights reserved.
2
+ // Use of this source code is governed by a BSD-style license that can be
3
+ // found in the LICENSE file.
4
+ 'use strict';
5
+
6
+ const rule = require('../lib/use_private_class_members.js');
7
+ const ruleTester = new (require('eslint').RuleTester)({
8
+ parser: require.resolve('@typescript-eslint/parser'),
9
+ parserOptions: {ecmaVersion: 9, sourceType: 'module'},
10
+ });
11
+
12
+ ruleTester.run('use_private_class_members', rule, {
13
+ valid: [
14
+ {
15
+ code: `class Foo {
16
+ #method() {}
17
+ }
18
+ `,
19
+ filename: 'test/e2e/folder/file.ts',
20
+ },
21
+ {
22
+ code: `class Foo {
23
+ public method() {}
24
+ }
25
+ `,
26
+ filename: 'test/e2e/folder/file.ts',
27
+ },
28
+ {
29
+ code: `class Foo {
30
+ public field: string;
31
+ }
32
+ `,
33
+ filename: 'test/e2e/folder/file.ts',
34
+ },
35
+ {
36
+ code: `class Foo {
37
+ private constructor() {}
38
+ }
39
+ `,
40
+ filename: 'test/e2e/folder/file.ts',
41
+ },
42
+ ],
43
+
44
+ invalid: [
45
+ {
46
+ code: `class Foo {
47
+ private method() {}
48
+ }
49
+ `,
50
+ filename: 'test/e2e/folder/file.ts',
51
+ errors: [{messageId: 'do_not_use_private'}],
52
+ },
53
+ {
54
+ code: `class Foo {
55
+ private field: string;
56
+ }
57
+ `,
58
+ filename: 'test/e2e/folder/file.ts',
59
+ errors: [{messageId: 'do_not_use_private'}],
60
+ },
61
+ ]
62
+ });
@@ -33,7 +33,7 @@ for (const file of files) {
33
33
  }
34
34
  const classNodes = file.getClasses();
35
35
  for (const classNode of classNodes) {
36
- for (const property of classNode.getInstanceProperties()) {
36
+ for (const property of classNode.getInstanceMembers()) {
37
37
  const name = property.getStructure().name;
38
38
  console.log(name);
39
39
  if (name.startsWith('#') || !property.hasModifier(SyntaxKind.PrivateKeyword)) {
@@ -44,8 +44,7 @@ for (const file of files) {
44
44
  continue;
45
45
  }
46
46
 
47
- // https://github.com/dsherret/ts-morph/issues/1198
48
- const newName = `SOME_STUPID_PREFIX_${name}`;
47
+ const newName = `#${name}`;
49
48
 
50
49
  property.toggleModifier('private', false);
51
50
  property.rename(newName);
@@ -3,8 +3,6 @@
3
3
  # scripts/migration/class-fields/migrate.sh panels/console
4
4
  #
5
5
  $PWD/third_party/node/node.py --output scripts/migration/class-fields/migrate.js $1/
6
- find $PWD/front_end/$1/ -type f -exec sed -i -e 's/SOME_STUPID_PREFIX_/#/g' {} \;
7
6
  git cl format --js
8
7
  NINJA_SUMMARIZE_BUILD=1 autoninja -C out/Default front_end/$1:bundle
9
- git add .
10
- git commit -m "Migrate to private class fields in $1" -m "" -m "R=szuend@chromium.org" -m "" -m "Bug: 1222126"
8
+ echo 'git commit -m "Migrate to private class fields in $1" -m "" -m "R=szuend@chromium.org" -m "" -m "Bug: 1222126"'
@@ -1,5 +1,5 @@
1
1
  {
2
2
  "dependencies": {
3
- "ts-morph": "^12.0.0"
3
+ "ts-morph": "^13.0.1"
4
4
  }
5
5
  }
@@ -1,255 +0,0 @@
1
- # Copyright 2020 The Chromium Authors. All rights reserved.
2
- # Use of this source code is governed by a BSD-style license that can be
3
- # found in the LICENSE file.
4
-
5
- import("../../scripts/build/ninja/vars.gni")
6
-
7
- all_devtools_files = [
8
- "front_end/legacy_test_runner/accessibility_test_runner/accessibility_test_runner.js",
9
- "front_end/legacy_test_runner/application_test_runner/application_test_runner.js",
10
- "front_end/legacy_test_runner/bindings_test_runner/bindings_test_runner.js",
11
- "front_end/legacy_test_runner/application_test_runner/CacheStorageTestRunner.js",
12
- "front_end/legacy_test_runner/application_test_runner/IndexedDBTestRunner.js",
13
- "front_end/legacy_test_runner/application_test_runner/ResourcesTestRunner.js",
14
- "front_end/legacy_test_runner/application_test_runner/ResourceTreeTestRunner.js",
15
- "front_end/legacy_test_runner/application_test_runner/ServiceWorkersTestRunner.js",
16
- "front_end/legacy_test_runner/application_test_runner/StorageTestRunner.js",
17
- "front_end/legacy_test_runner/lighthouse_test_runner/lighthouse_test_runner.js",
18
- "front_end/legacy_test_runner/axe_core_test_runner/axe_core_test_runner.js",
19
- "front_end/third_party/axe-core/axe.js",
20
- "front_end/legacy_test_runner/bindings_test_runner/AutomappingTestRunner.js",
21
- "front_end/legacy_test_runner/bindings_test_runner/BindingsTestRunner.js",
22
- "front_end/legacy_test_runner/bindings_test_runner/IsolatedFilesystemTestRunner.js",
23
- "front_end/legacy_test_runner/bindings_test_runner/OverridesTestRunner.js",
24
- "front_end/legacy_test_runner/bindings_test_runner/PersistenceTestRunner.js",
25
- "front_end/legacy_test_runner/console_test_runner/console_test_runner.js",
26
- "front_end/legacy_test_runner/coverage_test_runner/coverage_test_runner.js",
27
- "front_end/legacy_test_runner/cpu_profiler_test_runner/cpu_profiler_test_runner.js",
28
- "front_end/legacy_test_runner/data_grid_test_runner/data_grid_test_runner.js",
29
- "front_end/legacy_test_runner/device_mode_test_runner/device_mode_test_runner.js",
30
- "front_end/legacy_test_runner/elements_test_runner/elements_test_runner.js",
31
- "front_end/legacy_test_runner/elements_test_runner/EditDOMTestRunner.js",
32
- "front_end/legacy_test_runner/elements_test_runner/ElementsPanelShadowSelectionOnRefreshTestRunner.js",
33
- "front_end/legacy_test_runner/elements_test_runner/ElementsTestRunner.js",
34
- "front_end/legacy_test_runner/elements_test_runner/SetOuterHTMLTestRunner.js",
35
- "front_end/legacy_test_runner/elements_test_runner/StylesUpdateLinksTestRunner.js",
36
- "front_end/legacy_test_runner/extensions_test_runner/extensions_test_runner.js",
37
- "front_end/legacy_test_runner/extensions_test_runner/ExtensionsNetworkTestRunner.js",
38
- "front_end/legacy_test_runner/extensions_test_runner/ExtensionsTestRunner.js",
39
- "front_end/legacy_test_runner/heap_profiler_test_runner/heap_profiler_test_runner.js",
40
- "front_end/legacy_test_runner/layers_test_runner/layers_test_runner.js",
41
- "front_end/legacy_test_runner/network_test_runner/network_test_runner.js",
42
- "front_end/legacy_test_runner/performance_test_runner/performance_test_runner.js",
43
- "front_end/legacy_test_runner/performance_test_runner/TimelineDataTestRunner.js",
44
- "front_end/legacy_test_runner/performance_test_runner/TimelineTestRunner.js",
45
- "front_end/models/issues_manager/descriptions/arAttributionEventSourceTriggerDataTooLarge.md",
46
- "front_end/models/issues_manager/descriptions/arAttributionSourceUntrustworthyFrameOrigin.md",
47
- "front_end/models/issues_manager/descriptions/arAttributionSourceUntrustworthyOrigin.md",
48
- "front_end/models/issues_manager/descriptions/arAttributionTriggerDataTooLarge.md",
49
- "front_end/models/issues_manager/descriptions/arAttributionUntrustworthyFrameOrigin.md",
50
- "front_end/models/issues_manager/descriptions/arAttributionUntrustworthyOrigin.md",
51
- "front_end/models/issues_manager/descriptions/arInvalidAttributionData.md",
52
- "front_end/models/issues_manager/descriptions/arInvalidAttributionSourceEventId.md",
53
- "front_end/models/issues_manager/descriptions/arInvalidAttributionSourceExpiry.md",
54
- "front_end/models/issues_manager/descriptions/arInvalidAttributionSourcePriority.md",
55
- "front_end/models/issues_manager/descriptions/arInvalidEventSourceTriggerData.md",
56
- "front_end/models/issues_manager/descriptions/arInvalidTriggerDedupKey.md",
57
- "front_end/models/issues_manager/descriptions/arInvalidTriggerPriority.md",
58
- "front_end/models/issues_manager/descriptions/arMissingAttributionData.md",
59
- "front_end/models/issues_manager/descriptions/arPermissionPolicyDisabled.md",
60
- "front_end/models/issues_manager/descriptions/CoepCoopSandboxedIframeCannotNavigateToCoopPage.md",
61
- "front_end/models/issues_manager/descriptions/CoepCorpNotSameSite.md",
62
- "front_end/models/issues_manager/descriptions/CoepCorpNotSameOrigin.md",
63
- "front_end/models/issues_manager/descriptions/CoepCorpNotSameOriginAfterDefaultedToSameOriginByCoep.md",
64
- "front_end/models/issues_manager/descriptions/CoepFrameResourceNeedsCoepHeader.md",
65
- "front_end/models/issues_manager/descriptions/cspEvalViolation.md",
66
- "front_end/models/issues_manager/descriptions/cspInlineViolation.md",
67
- "front_end/models/issues_manager/descriptions/cspURLViolation.md",
68
- "front_end/models/issues_manager/descriptions/deprecationNavigatorUserAgent.md",
69
- "front_end/models/issues_manager/descriptions/LowTextContrast.md",
70
- "front_end/models/issues_manager/descriptions/cspTrustedTypesSinkViolation.md",
71
- "front_end/models/issues_manager/descriptions/cspTrustedTypesPolicyViolation.md",
72
- "front_end/models/issues_manager/descriptions/CompatibilityModeQuirks.md",
73
- "front_end/models/issues_manager/descriptions/heavyAd.md",
74
- "front_end/models/issues_manager/descriptions/corsAllowCredentialsRequired.md",
75
- "front_end/models/issues_manager/descriptions/corsDisallowedByMode.md",
76
- "front_end/models/issues_manager/descriptions/corsDisabledScheme.md",
77
- "front_end/models/issues_manager/descriptions/corsNoCorsRedirectModeNotFollow.md",
78
- "front_end/models/issues_manager/descriptions/corsHeaderDisallowedByPreflightResponse.md",
79
- "front_end/models/issues_manager/descriptions/corsInvalidHeaderValues.md",
80
- "front_end/models/issues_manager/descriptions/corsMethodDisallowedByPreflightResponse.md",
81
- "front_end/models/issues_manager/descriptions/corsOriginMismatch.md",
82
- "front_end/models/issues_manager/descriptions/corsPreflightResponseInvalid.md",
83
- "front_end/models/issues_manager/descriptions/corsRedirectContainsCredentials.md",
84
- "front_end/models/issues_manager/descriptions/corsWildcardOriginNotAllowed.md",
85
- "front_end/models/issues_manager/descriptions/mixedContent.md",
86
- "front_end/models/issues_manager/descriptions/sharedArrayBuffer.md",
87
- "front_end/models/issues_manager/descriptions/corsInsecurePrivateNetwork.md",
88
- "front_end/models/issues_manager/descriptions/corsPreflightAllowPrivateNetworkError.md",
89
- "front_end/models/issues_manager/descriptions/SameSiteExcludeContextDowngradeRead.md",
90
- "front_end/models/issues_manager/descriptions/SameSiteExcludeContextDowngradeSet.md",
91
- "front_end/models/issues_manager/descriptions/SameSiteExcludeNavigationContextDowngrade.md",
92
- "front_end/models/issues_manager/descriptions/SameSiteInvalidSameParty.md",
93
- "front_end/models/issues_manager/descriptions/SameSiteNoneInsecureErrorRead.md",
94
- "front_end/models/issues_manager/descriptions/SameSiteNoneInsecureErrorSet.md",
95
- "front_end/models/issues_manager/descriptions/SameSiteNoneInsecureWarnRead.md",
96
- "front_end/models/issues_manager/descriptions/SameSiteNoneInsecureWarnSet.md",
97
- "front_end/models/issues_manager/descriptions/SameSiteUnspecifiedLaxAllowUnsafeRead.md",
98
- "front_end/models/issues_manager/descriptions/SameSiteUnspecifiedLaxAllowUnsafeSet.md",
99
- "front_end/models/issues_manager/descriptions/SameSiteUnspecifiedTreatedAsLaxRead.md",
100
- "front_end/models/issues_manager/descriptions/SameSiteUnspecifiedTreatedAsLaxSet.md",
101
- "front_end/models/issues_manager/descriptions/SameSiteWarnCrossDowngradeRead.md",
102
- "front_end/models/issues_manager/descriptions/SameSiteWarnCrossDowngradeSet.md",
103
- "front_end/models/issues_manager/descriptions/SameSiteWarnStrictLaxDowngradeStrict.md",
104
- "front_end/models/issues_manager/descriptions/TwaDigitalAssetLinksFailed.md",
105
- "front_end/models/issues_manager/descriptions/TwaHttpError.md",
106
- "front_end/models/issues_manager/descriptions/TwaPageUnavailableOffline.md",
107
- "front_end/legacy_test_runner/sdk_test_runner/sdk_test_runner.js",
108
- "front_end/legacy_test_runner/security_test_runner/security_test_runner.js",
109
- "front_end/legacy_test_runner/sources_test_runner/sources_test_runner.js",
110
- "front_end/legacy_test_runner/sources_test_runner/AutocompleteTestRunner.js",
111
- "front_end/legacy_test_runner/sources_test_runner/DebuggerTestRunner.js",
112
- "front_end/legacy_test_runner/sources_test_runner/EditorTestRunner.js",
113
- "front_end/legacy_test_runner/sources_test_runner/LiveEditTestRunner.js",
114
- "front_end/legacy_test_runner/sources_test_runner/SearchTestRunner.js",
115
- "front_end/legacy_test_runner/sources_test_runner/SourcesTestRunner.js",
116
- ]
117
-
118
- lighthouse_locale_files = [
119
- "locales/ar-XB.json",
120
- "locales/ar.json",
121
- "locales/bg.json",
122
- "locales/ca.json",
123
- "locales/cs.json",
124
- "locales/da.json",
125
- "locales/de.json",
126
- "locales/el.json",
127
- "locales/en-GB.json",
128
- "locales/en-US.json",
129
- "locales/en-XA.json",
130
- "locales/en-XL.json",
131
- "locales/es-419.json",
132
- "locales/es.json",
133
- "locales/fi.json",
134
- "locales/fil.json",
135
- "locales/fr.json",
136
- "locales/he.json",
137
- "locales/hi.json",
138
- "locales/hr.json",
139
- "locales/hu.json",
140
- "locales/id.json",
141
- "locales/it.json",
142
- "locales/ja.json",
143
- "locales/ko.json",
144
- "locales/lt.json",
145
- "locales/lv.json",
146
- "locales/nl.json",
147
- "locales/no.json",
148
- "locales/pl.json",
149
- "locales/pt-PT.json",
150
- "locales/pt.json",
151
- "locales/ro.json",
152
- "locales/ru.json",
153
- "locales/sk.json",
154
- "locales/sl.json",
155
- "locales/sr-Latn.json",
156
- "locales/sr.json",
157
- "locales/sv.json",
158
- "locales/ta.json",
159
- "locales/te.json",
160
- "locales/th.json",
161
- "locales/tr.json",
162
- "locales/uk.json",
163
- "locales/vi.json",
164
- "locales/zh-HK.json",
165
- "locales/zh-TW.json",
166
- "locales/zh.json",
167
- ]
168
-
169
- remote_devtools_locale_files = [
170
- "af.json",
171
- "am.json",
172
- "ar.json",
173
- "as.json",
174
- "az.json",
175
- "be.json",
176
- "bg.json",
177
- "bn.json",
178
- "bs.json",
179
- "ca.json",
180
- "cs.json",
181
- "cy.json",
182
- "da.json",
183
- "de.json",
184
- "el.json",
185
- "en-GB.json",
186
- "es-419.json",
187
- "es.json",
188
- "et.json",
189
- "eu.json",
190
- "fa.json",
191
- "fi.json",
192
- "fil.json",
193
- "fr-CA.json",
194
- "fr.json",
195
- "gl.json",
196
- "gu.json",
197
- "he.json",
198
- "hi.json",
199
- "hr.json",
200
- "hu.json",
201
- "hy.json",
202
- "id.json",
203
- "is.json",
204
- "it.json",
205
- "ja.json",
206
- "ka.json",
207
- "kk.json",
208
- "km.json",
209
- "kn.json",
210
- "ko.json",
211
- "ky.json",
212
- "lo.json",
213
- "lt.json",
214
- "lv.json",
215
- "mk.json",
216
- "ml.json",
217
- "mn.json",
218
- "mr.json",
219
- "ms.json",
220
- "my.json",
221
- "ne.json",
222
- "nl.json",
223
- "no.json",
224
- "or.json",
225
- "pa.json",
226
- "pl.json",
227
- "pt-PT.json",
228
- "pt.json",
229
- "ro.json",
230
- "ru.json",
231
- "si.json",
232
- "sk.json",
233
- "sl.json",
234
- "sq.json",
235
- "sr-Latn.json",
236
- "sr.json",
237
- "sv.json",
238
- "sw.json",
239
- "ta.json",
240
- "te.json",
241
- "th.json",
242
- "tr.json",
243
- "uk.json",
244
- "ur.json",
245
- "uz.json",
246
- "vi.json",
247
- "zh-HK.json",
248
- "zh-TW.json",
249
- "zu.json",
250
- ]
251
-
252
- bundled_devtools_locale_files = [
253
- "en-US.json",
254
- "zh.json",
255
- ]
@@ -1,82 +0,0 @@
1
- # Copyright (c) 2014 Google Inc. All rights reserved.
2
- #
3
- # Redistribution and use in source and binary forms, with or without
4
- # modification, are permitted provided that the following conditions are
5
- # met:
6
- #
7
- # * Redistributions of source code must retain the above copyright
8
- # notice, this list of conditions and the following disclaimer.
9
- # * Redistributions in binary form must reproduce the above
10
- # copyright notice, this list of conditions and the following disclaimer
11
- # in the documentation and/or other materials provided with the
12
- # distribution.
13
- # * Neither the name of Google Inc. nor the names of its
14
- # contributors may be used to endorse or promote products derived from
15
- # this software without specific prior written permission.
16
- #
17
- # THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
18
- # "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
19
- # LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
20
- # A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
21
- # OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
22
- # SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
23
- # LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
24
- # DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
25
- # THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
26
- # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
27
- # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
28
-
29
- import hashlib
30
- import os.path
31
-
32
- try:
33
- import json
34
- except ImportError:
35
- import simplejson as json
36
-
37
-
38
- def save_hashes(hashes_file_path, hashes):
39
- try:
40
- with open(hashes_file_path, "wt") as hashes_file:
41
- json.dump(hashes,
42
- hashes_file,
43
- indent=4,
44
- separators=(",", ": "),
45
- sort_keys=True)
46
- except:
47
- print("ERROR: Failed to write %s" % hashes_file_path)
48
- raise
49
-
50
-
51
- def load_hashes(hashes_file_path):
52
- try:
53
- with open(hashes_file_path, "r") as hashes_file:
54
- hashes = json.load(hashes_file)
55
- except:
56
- return {}
57
- return hashes
58
-
59
-
60
- def calculate_file_hash(file_path):
61
- with open(file_path, "rb") as file:
62
- data = file.read()
63
- md5_hash = hashlib.md5(data).hexdigest()
64
- return md5_hash
65
-
66
-
67
- def files_with_invalid_hashes(hash_file_path, file_paths):
68
- hashes = load_hashes(hash_file_path)
69
- result = []
70
- for file_path in file_paths:
71
- file_name = os.path.basename(file_path)
72
- if calculate_file_hash(file_path) != hashes.get(file_name, ""):
73
- result.append(file_path)
74
- return result
75
-
76
-
77
- def update_file_hashes(hash_file_path, file_paths):
78
- hashes = {}
79
- for file_path in file_paths:
80
- file_name = os.path.basename(file_path)
81
- hashes[file_name] = calculate_file_hash(file_path)
82
- save_hashes(hash_file_path, hashes)
@@ -1,49 +0,0 @@
1
- #!/usr/bin/env node
2
-
3
- // Copyright 2016 The Chromium Authors. All rights reserved.
4
- // Use of this source code is governed by a BSD-style license that can be
5
- // found in the LICENSE file.
6
-
7
- var childProcess = require('child_process');
8
- var fs = require('fs');
9
- var path = require('path');
10
- var shell = require('child_process').execSync;
11
-
12
- var repoRootPath;
13
- try {
14
- repoRootPath = shellOutput('git rev-parse --show-toplevel');
15
- } catch (error) {
16
- console.log('ERROR: cannot use dtrun outside of chromium repo');
17
- process.exit(1);
18
- }
19
-
20
- var devtoolsPath = path.join(repoRootPath, 'third_party', 'devtools-frontend', 'src');
21
-
22
- if (!isDir(devtoolsPath)) {
23
- console.log('ERROR: cannot use dtrun outside of chromium repo');
24
- process.exit(1);
25
- }
26
-
27
- var npmPath = shellOutput('which npm');
28
- var args = ['run'];
29
- if (process.argv.length > 2) {
30
- args.push(process.argv[2]);
31
- args.push('--');
32
- args = args.concat(process.argv.slice(3));
33
- }
34
- var child = childProcess.spawn(npmPath, args, {
35
- cwd: devtoolsPath,
36
- stdio: 'inherit',
37
- });
38
-
39
- function shellOutput(command) {
40
- return shell(command).toString().trim();
41
- }
42
-
43
- function isDir(path) {
44
- try {
45
- return fs.statSync(path).isDirectory();
46
- } catch (error) {
47
- return false;
48
- }
49
- }
@@ -1,13 +0,0 @@
1
- {
2
- "name": "devtools-run",
3
- "description": "cli helper for using devtools npm commands anywhere in a chromium repo",
4
- "version": "0.1.0",
5
- "author": "The Chromium Authors",
6
- "license": "SEE LICENSE IN https://chromium.googlesource.com/chromium/src/+/main/LICENSE",
7
- "bugs": {
8
- "url": "https://bugs.chromium.org/p/chromium/issues/list?can=2&q=component:Platform%3EDevTools%20&sort=-opened&colspec=ID%20Stars%20Owner%20Summary%20Modified%20Opened"
9
- },
10
- "bin": {
11
- "dtrun": "./devtools_run_cli"
12
- }
13
- }
package/scripts/unzip.py DELETED
@@ -1,20 +0,0 @@
1
- #!/usr/bin/env vpython
2
- # Copyright 2016 The Chromium Authors. All rights reserved.
3
- # Use of this source code is governed by a BSD-style license that can be
4
- # found in the LICENSE file.
5
-
6
- import sys
7
- import zipfile
8
-
9
- if len(sys.argv) < 3:
10
- print('Usage: {} <src> <dest>'.format(sys.argv[0]))
11
- print(' <src> full path to zip file to be extracted')
12
- print(' <dest> full path to destination folder')
13
- sys.exit(1)
14
-
15
- src = sys.argv[1]
16
- dest = sys.argv[2]
17
-
18
- zip_ref = zipfile.ZipFile(src, 'r')
19
- zip_ref.extractall(dest)
20
- zip_ref.close()