chrome-devtools-frontend 1.0.950001 → 1.0.950971

package/front_end/third_party/codemirror.next/codemirror.next.d.ts

@@ -2029,6 +2029,11 @@ declare abstract class WidgetType {
     events.
     */
     ignoreEvent(_event: Event): boolean;
+    /**
+    This is called when the an instance of the widget is removed
+    from the editor view.
+    */
+    destroy(_dom: HTMLElement): void;
 }
 /**
 A decoration set represents a collection of decorated ranges,
@@ -2759,6 +2764,11 @@ declare class EditorView {
     Find the DOM parent node and offset (child offset if `node` is
     an element, character offset when it is a text node) at the
     given document position.
+
+    Note that for positions that aren't currently in
+    `visibleRanges`, the resulting DOM position isn't necessarily
+    meaningful (it may just point before or after a placeholder
+    element).
     */
     domAtPos(pos: number): {
         node: Node;
@@ -4639,6 +4649,11 @@ declare abstract class GutterMarker extends RangeValue {
     element that contains this marker.
     */
     elementClass: string;
+    /**
+    Called if the marker has a `toDOM` method and its representation
+    was removed from a gutter.
+    */
+    destroy(dom: Node): void;
 }
 declare type Handlers = {
     [event: string]: (view: EditorView, line: BlockInfo, event: Event) => boolean;

package/front_end/third_party/codemirror.next/package.json

@@ -5,10 +5,10 @@
   "dependencies": {
     "@codemirror/autocomplete": "0.19.9",
     "@codemirror/closebrackets": "0.19.0",
-    "@codemirror/commands": "0.19.5",
+    "@codemirror/commands": "0.19.6",
     "@codemirror/comment": "0.19.0",
     "@codemirror/fold": "0.19.2",
-    "@codemirror/gutter": "0.19.8",
+    "@codemirror/gutter": "0.19.9",
     "@codemirror/highlight": "0.19.6",
     "@codemirror/history": "0.19.0",
     "@codemirror/lang-cpp": "0.19.1",
@@ -32,7 +32,7 @@
     "@codemirror/stream-parser": "0.19.2",
     "@codemirror/text": "0.19.5",
     "@codemirror/tooltip": "0.19.10",
-    "@codemirror/view": "0.19.25",
+    "@codemirror/view": "0.19.29",
     "@lezer/common": "0.15.10",
     "@lezer/lr": "0.15.5",
     "@rollup/plugin-node-resolve": "^13.0.4",

package/front_end/ui/components/markdown_view/MarkdownLinksMap.ts

@@ -27,9 +27,25 @@ export const markdownLinks = new Map<string, string>([
   ],
   ['issueQuirksModeDoctype', 'https://web.dev/doctype/'],
   ['sameSiteAndSameOrigin', 'https://web.dev/same-site-same-origin/'],
+  // Link URLs for deprecation issues (see blink::Deprecation)
+  ['https://xhr.spec.whatwg.org/', 'https://xhr.spec.whatwg.org/'],
+  ['https://goo.gl/rStTGz', 'https://goo.gl/rStTGz'],
+  ['https://webrtc.org/web-apis/chrome/unified-plan/', 'https://webrtc.org/web-apis/chrome/unified-plan/'],
+  [
+    'https://developer.chrome.com/blog/enabling-shared-array-buffer/',
+    'https://developer.chrome.com/blog/enabling-shared-array-buffer/',
+  ],
+  ['https://developer.chrome.com/docs/extensions/mv3/', 'https://developer.chrome.com/docs/extensions/mv3/'],
+  [
+    'https://developer.chrome.com/blog/immutable-document-domain',
+    'https://developer.chrome.com/blog/immutable-document-domain',
+  ],
 ]);
 
 export const getMarkdownLink = (key: string): string => {
+  if (/^https:\/\/www.chromestatus.com\/feature\/\d+$/.test(key)) {
+    return key;
+  }
   const link = markdownLinks.get(key);
   if (!link) {
     throw new Error(`Markdown link with key '${key}' is not available, please check MarkdownLinksMap.ts`);

package/front_end/ui/components/report_view/report.css

@@ -6,7 +6,6 @@
 
 :host {
   display: block;
-  overflow: auto;
 }
 
 .content {

package/front_end/ui/components/text_editor/config.ts

@@ -70,10 +70,13 @@ export const tabMovesFocus = DynamicSetting.bool('textEditorTabMovesFocus', [],
   shift: (view: CM.EditorView): boolean => view.state.doc.length ? CM.indentLess(view) : false,
 }]));
 
-export const autocompletion = CM.autocompletion({
-  icons: false,
-  optionClass: (option: CM.Completion): string => option.type === 'secondary' ? 'cm-secondaryCompletion' : '',
-});
+export const autocompletion: CM.Extension = [
+  CM.autocompletion({
+    icons: false,
+    optionClass: (option: CM.Completion): string => option.type === 'secondary' ? 'cm-secondaryCompletion' : '',
+  }),
+  CM.Prec.highest(CM.keymap.of([{key: 'ArrowRight', run: CM.acceptCompletion}])),
+];
 
 export const sourcesAutocompletion = DynamicSetting.bool('textEditorAutocompletion', autocompletion);
 

package/front_end/ui/components/text_editor/javascript.ts

@@ -402,13 +402,22 @@ async function completeExpressionGlobal(): Promise<CompletionSet> {
   return fetchNames;
 }
 
-export function isExpressionComplete(state: CodeMirror.EditorState): boolean {
-  for (const cursor = CodeMirror.syntaxTree(state).cursor(); cursor.next();) {
-    if (cursor.type.isError) {
-      return false;
-    }
-  }
-  return true;
+export async function isExpressionComplete(expression: string): Promise<boolean> {
+  const currentExecutionContext = UI.Context.Context.instance().flavor(SDK.RuntimeModel.ExecutionContext);
+  if (!currentExecutionContext) {
+    return true;
+  }
+  const result =
+      await currentExecutionContext.runtimeModel.compileScript(expression, '', false, currentExecutionContext.id);
+  if (!result || !result.exceptionDetails || !result.exceptionDetails.exception) {
+    return true;
+  }
+  const description = result.exceptionDetails.exception.description;
+  if (description) {
+    return !description.startsWith('SyntaxError: Unexpected end of input') &&
+        !description.startsWith('SyntaxError: Unterminated template literal');
+  }
+  return false;
 }
 
 export function argumentHints(): CodeMirror.Extension {

package/inspector_overlay/main.ts

@@ -80,10 +80,17 @@ type MessageLookup = {
   drawingFinished: '',
 };
 
+let queue: unknown[][] = [];
+let prevQueue: string = '';
+
 const dispatch = <K extends keyof MessageLookup>(message: [a: K, b: MessageLookup[K]]) => {
   const functionName = message[0];
   if (functionName === 'setOverlay') {
     const overlayName = message[1] as keyof Overlays;
+    // No need to swap overlays if it's the same overlay.
+    if (overlays[overlayName] === currentOverlay) {
+      return;
+    }
     if (currentOverlay) {
       currentOverlay.uninstall();
     }
@@ -97,9 +104,16 @@ const dispatch = <K extends keyof MessageLookup>(message: [a: K, b: MessageLooku
   } else if (functionName === 'setPlatform') {
     platformName = message[1];
   } else if (functionName === 'drawingFinished') {
-    // TODO The logic needs to be added here once the backend starts sending this event.
+    const currentQueue = JSON.stringify(queue);
+    if (currentQueue !== prevQueue) {
+      for (const message of queue) {
+        currentOverlay.dispatch(message);
+      }
+    }
+    prevQueue = currentQueue;
+    queue = [];
   } else {
-    currentOverlay.dispatch(message);
+    queue.push(message);
   }
 };
 

package/package.json

@@ -53,5 +53,5 @@
     "unittest": "scripts/test/run_unittests.py --no-text-coverage",
     "watch": "third_party/node/node.py --output scripts/watch_build.js"
   },
-  "version": "1.0.950001"
+  "version": "1.0.950971"
 }

package/scripts/build/ninja/copy.gni

@@ -16,8 +16,8 @@ template("copy_to_gen") {
 
     script = "scripts/build/ninja/copy-files.js"
 
-    _copy_src = rebase_path(get_path_info(target_name, "dir"))
-    _copy_dest = rebase_path(target_gen_dir)
+    _copy_src = rebase_path(get_path_info(target_name, "dir"), root_build_dir)
+    _copy_dest = rebase_path(target_gen_dir, root_build_dir)
 
     args = [
       _copy_src,

package/front_end/core/platform/utilities.ts

@@ -1,49 +0,0 @@
-// Copyright 2020 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-/*
- * Copyright (C) 2007 Apple Inc.  All rights reserved.
- * Copyright (C) 2012 Google Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- *
- * 1.  Redistributions of source code must retain the above copyright
- *     notice, this list of conditions and the following disclaimer.
- * 2.  Redistributions in binary form must reproduce the above copyright
- *     notice, this list of conditions and the following disclaimer in the
- *     documentation and/or other materials provided with the distribution.
- * 3.  Neither the name of Apple Computer, Inc. ("Apple") nor the names of
- *     its contributors may be used to endorse or promote products derived
- *     from this software without specific prior written permission.
- *
- * THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS "AS IS" AND ANY
- * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
- * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
- * DISCLAIMED. IN NO EVENT SHALL APPLE OR ITS CONTRIBUTORS BE LIABLE FOR ANY
- * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
- * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
- * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
- * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
- * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-export function runOnWindowLoad(callback: () => void): void {
-  function windowLoaded(): void {
-    window.removeEventListener('DOMContentLoaded', windowLoaded, false);
-    callback();
-  }
-
-  if (document.readyState === 'complete' || document.readyState === 'interactive') {
-    callback();
-  } else {
-    window.addEventListener('DOMContentLoaded', windowLoaded, false);
-  }
-}
-
-export function assertNever(type: never, message: string): never {
-  throw new Error(message);
-}