chrome-devtools-frontend 1.0.950001 → 1.0.950971

package/config/gni/devtools_grd_files.gni

@@ -554,7 +554,6 @@ grd_files_debug_sources = [
   "front_end/core/platform/set-utilities.js",
   "front_end/core/platform/string-utilities.js",
   "front_end/core/platform/typescript-utilities.js",
-  "front_end/core/platform/utilities.js",
   "front_end/core/protocol_client/InspectorBackend.js",
   "front_end/core/protocol_client/NodeURL.js",
   "front_end/core/root/Runtime.js",

package/docs/triage_guidelines.md

@@ -45,8 +45,8 @@ Issues in the untriaged queue should receive a meaningful response within a busi
 
 - Close issues as `WontFix` if they don't reproduce (in simple cases) or are requests for features we've already concluded not to pursue.
 - Close issues as `Archived` that are valid, but it seems unlikely that we will get there anytime soon.
-- Move issues out of `Platform>DevTools` if they are not DevTools issues (but just reported via the menu item in DevTools), put on the `Hotlist-DevTools-Triaged` and leave the `Untriaged` status as is.
-- Assign regression bugs with bisects to individuals directly and set the status to `Assigned`.  
+- Move issues out of `Platform>DevTools` if they are not DevTools issues (but just reported via the menu item in DevTools), put on the `DevTools-Triaged` label and leave the `Untriaged` status as is.
+- Assign regression bugs with bisects to individuals directly and set the status to `Assigned`.
 - Put proper `Platform>DevTools>XXX` component(s) on the issue and do an initial check-in regarding the priority.
 - Put one of the following labels on it and set the status to `Available`:
   - `Hotlist-DevTools-ProductReview` if it's controversial or clear that consensus needs to be built first.

package/front_end/core/dom_extension/DOMExtension.ts

@@ -457,7 +457,7 @@ Node.prototype.isSelfOrDescendant = function(node: Node|null): boolean {
   return Boolean(node) && (node === this || this.isDescendant(node));
 };
 
-Node.prototype.traverseNextNode = function(stayWithin?: Node, skipShadowRoot?: boolean = false): Node|null {
+Node.prototype.traverseNextNode = function(stayWithin?: Node, skipShadowRoot: boolean = false): Node|null {
   if (!skipShadowRoot && this.shadowRoot) {
     return this.shadowRoot;
   }

package/front_end/core/host/InspectorFrontendHostAPI.ts

@@ -357,7 +357,6 @@ export enum EnumeratedHistogram {
   IssuesPanelOpenedFrom = 'DevTools.IssuesPanelOpenedFrom',
   IssuesPanelResourceOpened = 'DevTools.IssuesPanelResourceOpened',
   KeybindSetSettingChanged = 'DevTools.KeybindSetSettingChanged',
-  DualScreenDeviceEmulated = 'DevTools.DualScreenDeviceEmulated',
   ExperimentEnabledAtLaunch = 'DevTools.ExperimentEnabledAtLaunch',
   ExperimentEnabled = 'DevTools.ExperimentEnabled',
   ExperimentDisabled = 'DevTools.ExperimentDisabled',

package/front_end/core/host/UserMetrics.ts

@@ -158,12 +158,6 @@ export class UserMetrics {
     InspectorFrontendHostInstance.recordEnumeratedHistogram(EnumeratedHistogram.IssueCreated, issueCreated, size);
   }
 
-  dualScreenDeviceEmulated(emulationAction: DualScreenDeviceEmulated): void {
-    const size = Object.keys(DualScreenDeviceEmulated).length + 1;
-    InspectorFrontendHostInstance.recordEnumeratedHistogram(
-        EnumeratedHistogram.DualScreenDeviceEmulated, emulationAction, size);
-  }
-
   experimentEnabledAtLaunch(experimentId: string): void {
     const size = DevtoolsExperiments['__lastValidEnumPosition'] + 1;
     const experiment = DevtoolsExperiments[experimentId];
@@ -537,14 +531,6 @@ export enum IssueOpener {
   CommandMenu = 5,
 }
 
-// TODO(crbug.com/1167717): Make this a const enum again
-// eslint-disable-next-line rulesdir/const_enum
-export enum DualScreenDeviceEmulated {
-  DualScreenDeviceSelected = 0,
-  SpanButtonClicked = 1,
-  PlatformSupportUsed = 2,  // user starts to use platform dual screen support feature.
-}
-
 /**
  * This list should contain the currently active Devtools Experiments.
  * Therefore, it is possible that the id's will no longer be continuous
@@ -686,6 +672,7 @@ export const IssueCreated: {
   'CorsIssue::CorsDisabledScheme': 53,
   'CorsIssue::PreflightMissingAllowExternal': 54,
   'CorsIssue::PreflightInvalidAllowExternal': 55,
+  'CorsIssue::InvalidResponse': 56,
   'CorsIssue::NoCorsRedirectModeNotFollow': 57,
   'QuirksModeIssue::QuirksMode': 58,
   'QuirksModeIssue::LimitedQuirksMode': 59,

package/front_end/core/platform/platform.ts

@@ -45,8 +45,7 @@ export {DCHECK} from './dcheck.js';
  * (e.g. `Platform.TypeScriptUtilities.assertNotNull` causes a
  * compiler error)
  */
-export {assertNotNullOrUndefined, assertUnhandled} from './typescript-utilities.js';
-export {assertNever, runOnWindowLoad} from './utilities.js';
+export {assertNever, assertNotNullOrUndefined, assertUnhandled} from './typescript-utilities.js';
 export {
   ArrayUtilities,
   DateUtilities,

package/front_end/core/platform/typescript-utilities.ts

@@ -13,6 +13,10 @@ export function assertNotNullOrUndefined<T>(val: T): asserts val is NonNullable<
   }
 }
 
+export function assertNever(type: never, message: string): never {
+  throw new Error(message);
+}
+
 /**
  * This is useful to check on the type-level that the unhandled cases of
  * a switch are exactly `T` (where T is usually a union type of enum values).

package/front_end/devtools_compatibility.js

@@ -385,7 +385,6 @@
     IssuesPanelOpenedFrom: 'DevTools.IssuesPanelOpenedFrom',
     IssuesPanelResourceOpened: 'DevTools.IssuesPanelResourceOpened',
     KeybindSetSettingChanged: 'DevTools.KeybindSetSettingChanged',
-    DualScreenDeviceEmulated: 'DevTools.DualScreenDeviceEmulated',
     ExperimentEnabledAtLaunch: 'DevTools.ExperimentEnabledAtLaunch',
     ExperimentEnabled: 'DevTools.ExperimentEnabled',
     ExperimentDisabled: 'DevTools.ExperimentDisabled',

package/front_end/entrypoints/device_mode_emulation_frame/device_mode_emulation_frame.ts

@@ -5,13 +5,8 @@
 import '../../core/dom_extension/dom_extension.js';
 import '../../Images/Images.js';
 
-import * as Platform from '../../core/platform/platform.js';
-
-Platform.runOnWindowLoad(() => {
-  if (!window.opener) {
-    return;
-  }
+if (window.opener) {
   // @ts-ignore TypeScript doesn't know about `Emulation` on `Window`.
   const app = window.opener.Emulation.AdvancedApp.instance();
   app.deviceModeEmulationFrameLoaded(document);
-});
+}

package/front_end/entrypoints/main/MainImpl.ts

@@ -118,9 +118,7 @@ export class MainImpl {
 
   constructor() {
     MainImpl.instanceForTest = this;
-    Platform.runOnWindowLoad(() => {
-      this.loaded();
-    });
+    this.loaded();
   }
 
   static time(label: string): void {

package/front_end/models/issues_manager/AttributionReportingIssue.ts

@@ -81,7 +81,11 @@ export class AttributionReportingIssue extends Issue<IssueCode> {
       case IssueCode.InvalidAttributionSourceEventId:
         return {
           file: 'arInvalidAttributionSourceEventId.md',
-          links: [],
+          links: [{
+            link:
+                'https://developer.chrome.com/docs/privacy-sandbox/attribution-reporting-event-guide/#html-attribute-attributionsourceeventid-required',
+            linkTitle: 'attributionsourceeventid attribute',
+          }],
         };
       case IssueCode.InvalidAttributionData:
         return {
@@ -101,7 +105,18 @@ export class AttributionReportingIssue extends Issue<IssueCode> {
       case IssueCode.AttributionSourceUntrustworthyOrigin:
         return {
           file: 'arAttributionSourceUntrustworthyOrigin.md',
-          links: [],
+          links: [
+            {
+              link:
+                  'https://developer.chrome.com/docs/privacy-sandbox/attribution-reporting-event-guide/#html-attribute-attributiondestination-required',
+              linkTitle: 'attributiondestination attribute',
+            },
+            {
+              link:
+                  'https://developer.chrome.com/docs/privacy-sandbox/attribution-reporting-event-guide/#html-attribute-attributionreportto',
+              linkTitle: 'attributionreportto attribute',
+            },
+          ],
         };
       case IssueCode.AttributionUntrustworthyFrameOrigin:
         return {
@@ -126,12 +141,20 @@ export class AttributionReportingIssue extends Issue<IssueCode> {
       case IssueCode.InvalidAttributionSourceExpiry:
         return {
           file: 'arInvalidAttributionSourceExpiry.md',
-          links: [],
+          links: [{
+            link:
+                'https://developer.chrome.com/docs/privacy-sandbox/attribution-reporting-event-guide/#html-attribute-attributionexpiry',
+            linkTitle: 'attributionexpiry attribute',
+          }],
         };
       case IssueCode.InvalidAttributionSourcePriority:
         return {
           file: 'arInvalidAttributionSourcePriority.md',
-          links: [],
+          links: [{
+            link:
+                'https://developer.chrome.com/docs/privacy-sandbox/attribution-reporting-event-guide/#html-attribute-attributionsourcepriority',
+            linkTitle: 'attributionsourcepriority attribute',
+          }],
         };
       case IssueCode.InvalidEventSourceTriggerData:
         return {
@@ -141,12 +164,20 @@ export class AttributionReportingIssue extends Issue<IssueCode> {
       case IssueCode.InvalidTriggerPriority:
         return {
           file: 'arInvalidTriggerPriority.md',
-          links: [],
+          links: [{
+            link:
+                'https://developer.chrome.com/docs/privacy-sandbox/attribution-reporting-event-guide/#prioritize-specific-conversions',
+            linkTitle: 'Prioritizing specific conversions',
+          }],
         };
       case IssueCode.InvalidTriggerDedupKey:
         return {
           file: 'arInvalidTriggerDedupKey.md',
-          links: [],
+          links: [{
+            link:
+                'https://developer.chrome.com/docs/privacy-sandbox/attribution-reporting-event-guide/#deduplicate-reports',
+            linkTitle: 'Deduplicating reports',
+          }],
         };
     }
   }

package/front_end/panels/animation/animationTimeline.css

@@ -26,7 +26,8 @@
   display: flex;
   flex-direction: column;
   justify-content: space-around;
-  align-items: center;
+  align-items: flex-start;
+  white-space: nowrap;
   flex: 0 0 150px;
 }
 

package/front_end/panels/console/ConsolePrompt.ts

@@ -207,7 +207,14 @@ export class ConsolePrompt extends Common.ObjectWrapper.eventMixin<EventTypes, t
       {key: 'ArrowDown', run: (): boolean => this.moveHistory(1)},
       {mac: 'Ctrl-p', run: (): boolean => this.moveHistory(-1, true)},
       {mac: 'Ctrl-n', run: (): boolean => this.moveHistory(1, true)},
-      {key: 'Enter', run: (): boolean => this.evaluate(), shift: CodeMirror.insertNewlineAndIndent},
+      {
+        key: 'Enter',
+        run: (): boolean => {
+          this.handleEnter();
+          return true;
+        },
+        shift: CodeMirror.insertNewlineAndIndent,
+      },
     ];
   }
 
@@ -242,29 +249,28 @@ export class ConsolePrompt extends Common.ObjectWrapper.eventMixin<EventTypes, t
     return true;
   }
 
-  private enterWillEvaluate(): boolean {
+  private async enterWillEvaluate(): Promise<boolean> {
     const {state} = this.editor;
-    return state.doc.length > 0 && TextEditor.JavaScript.isExpressionComplete(state);
+    return state.doc.length > 0 && await TextEditor.JavaScript.isExpressionComplete(state.doc.toString());
   }
 
-  private evaluate(): boolean {
-    if (this.enterWillEvaluate()) {
+  private async handleEnter(): Promise<void> {
+    if (await this.enterWillEvaluate()) {
       this.appendCommand(this.text(), true);
       this.editor.dispatch({
         changes: {from: 0, to: this.editor.state.doc.length},
         scrollIntoView: true,
       });
     } else if (this.editor.state.doc.length) {
-      return CodeMirror.insertNewlineAndIndent(this.editor.editor);
+      CodeMirror.insertNewlineAndIndent(this.editor.editor);
     } else {
       this.editor.dispatch({scrollIntoView: true});
     }
-    return true;
   }
 
   private updatePromptIcon(): void {
     this.iconThrottler.schedule(async () => {
-      this.promptIcon.classList.toggle('console-prompt-incomplete', !this.enterWillEvaluate());
+      this.promptIcon.classList.toggle('console-prompt-incomplete', !(await this.enterWillEvaluate()));
     });
   }
 

package/front_end/panels/profiler/heapProfiler.css

@@ -137,7 +137,7 @@
   color: var(--color-text-secondary);
 }
 
-.cycled-ancessor-node {
+.heap-snapshot-view tr:not(.selected) .cycled-ancessor-node {
   opacity: 60%;
 }
 

package/front_end/panels/settings/settingsScreen.css

@@ -137,12 +137,13 @@ fieldset {
 }
 
 #experiments-tab-content .settings-container {
-  column-width: 470px;
+  column-width: auto;
 }
 
 #experiments-tab-content .settings-block {
-  width: 470px;
+  width: auto;
   margin-left: 0;
+  margin-right: 10px;
 }
 
 .settings-tab-container header > h1 {
@@ -172,7 +173,11 @@ fieldset {
 
 .settings-experiment {
   display: grid;
-  grid-template-columns: auto 1fr;
+  grid-template-columns: auto min-content 1fr;
+}
+
+.settings-experiment [is="dt-checkbox"] {
+  padding-right: 10px;
 }
 
 .settings-experiment .devtools-link {

package/front_end/panels/sources/BreakpointEditDialog.ts

@@ -106,11 +106,14 @@ export class BreakpointEditDialog extends UI.Widget.Widget {
 
     const content = oldCondition || '';
     const finishIfComplete = (view: CodeMirror.EditorView): boolean => {
-      if (TextEditor.JavaScript.isExpressionComplete(view.state)) {
-        this.finishEditing(true, this.editor.state.doc.toString());
-        return true;
-      }
-      return false;
+      TextEditor.JavaScript.isExpressionComplete(view.state.doc.toString()).then((complete): void => {
+        if (complete) {
+          this.finishEditing(true, this.editor.state.doc.toString());
+        } else {
+          CodeMirror.insertNewlineAndIndent(view);
+        }
+      });
+      return true;
     };
     const keymap = [
       {

package/front_end/panels/timeline/TimelinePanel.ts

@@ -842,7 +842,7 @@ export class TimelinePanel extends UI.Panel.Panel implements Client, TimelineMod
 
   private recordingFailed(error: string): void {
     if (this.statusPane) {
-      this.statusPane.hide();
+      this.statusPane.remove();
     }
     this.statusPane = new StatusPane(
         {
@@ -1036,7 +1036,7 @@ export class TimelinePanel extends UI.Panel.Panel implements Client, TimelineMod
     this.hideLandingPage();
 
     if (this.statusPane) {
-      this.statusPane.hide();
+      this.statusPane.remove();
     }
     this.statusPane = new StatusPane(
         {
@@ -1073,7 +1073,7 @@ export class TimelinePanel extends UI.Panel.Panel implements Client, TimelineMod
     this.setState(State.Idle);
 
     if (this.statusPane) {
-      this.statusPane.hide();
+      this.statusPane.remove();
     }
     this.statusPane = null;
 
@@ -1405,9 +1405,10 @@ export class StatusPane extends UI.Widget.VBox {
     this.button.disabled = true;
   }
 
-  hide(): void {
+  remove(): void {
     (this.element.parentNode as HTMLElement).classList.remove('tinted');
     this.arrangeDialog((this.element.parentNode as HTMLElement));
+    this.stopTimer();
     this.element.remove();
   }