chrome-devtools-frontend 1.0.948916 → 1.0.950768

package/front_end/panels/accessibility/axBreadcrumbs.css

@@ -99,6 +99,10 @@
   background-color: var(--color-background-elevation-0);
 }
 
+.ax-breadcrumbs .ax-node:not(.inspected):focus {
+  background-color: var(--color-background-elevation-1);
+}
+
 .ax-breadcrumbs .ax-node.inspected:focus * {
   color: inherit;
 }

package/front_end/panels/animation/animationTimeline.css

@@ -26,7 +26,8 @@
   display: flex;
   flex-direction: column;
   justify-content: space-around;
-  align-items: center;
+  align-items: flex-start;
+  white-space: nowrap;
   flex: 0 0 150px;
 }
 

package/front_end/panels/application/components/FrameDetailsView.ts

@@ -47,6 +47,11 @@ const UIStrings = {
   */
   document: 'Document',
   /**
+  *@description A web URL (for a lot of languages this does not need to be translated, please translate only where necessary)
+  */
+  url: 'URL',
+  /**
+  /**
   *@description Title for a link to the Sources panel
   */
   clickToRevealInSourcesPanel: 'Click to reveal in Sources panel',
@@ -63,6 +68,12 @@ const UIStrings = {
   */
   clickToRevealInNetworkPanelMight: 'Click to reveal in Network panel (might require page reload)',
   /**
+  *@description The origin of a URL (https://web.dev/same-site-same-origin/#origin)
+  *(for a lot of languages this does not need to be translated, please translate only where necessary)
+  */
+  origin: 'Origin',
+  /**
+  /**
   *@description Related node label in Timeline UIUtils of the Performance panel
   */
   ownerElement: 'Owner Element',
@@ -107,9 +118,11 @@ const UIStrings = {
   */
   no: 'No',
   /**
-  *@description Row title for in the Frame Details view
+  *@description Label for whether a frame is cross-origin isolated
+  *(https://developer.chrome.com/docs/extensions/mv3/cross-origin-isolation/)
+  *(for a lot of languages this does not need to be translated, please translate only where necessary)
   */
-  crossoriginIsolated: '`Cross-Origin` Isolated',
+  crossoriginIsolated: 'Cross-Origin Isolated',
   /**
   *@description Explanatory text in the Frame Details view
   */
@@ -132,10 +145,11 @@ const UIStrings = {
   */
   apiAvailability: 'API availability',
   /**
-  *@description Explanatory text in the Frame Details view for the API availability section
+  *@description Explanation of why cross-origin isolation is important
+  *(https://web.dev/why-coop-coep/)
+  *(for a lot of languages 'cross-origin isolation' does not need to be translated, please translate only where necessary)
   */
-  availabilityOfCertainApisDepends:
-      'Availability of certain APIs depends on the document being `cross-origin` isolated.',
+  availabilityOfCertainApisDepends: 'Availability of certain APIs depends on the document being cross-origin isolated.',
   /**
   *@description Description of the SharedArrayBuffer status
   */
@@ -159,13 +173,17 @@ const UIStrings = {
   sharedarraybufferConstructorIsAvailable:
       '`SharedArrayBuffer` constructor is available but `SABs` cannot be transferred via `postMessage`',
   /**
-  *@description Explanation for the SharedArrayBuffer availability status
+  *@description Explanation why SharedArrayBuffer will not be available in the future
+  *(https://developer.chrome.com/docs/extensions/mv3/cross-origin-isolation/)
+  *(for a lot of languages 'cross-origin isolation' does not need to be translated, please translate only where necessary)
   */
-  willRequireCrossoriginIsolated: '⚠️ will require `cross-origin` isolated context in the future',
+  willRequireCrossoriginIsolated: '⚠️ will require cross-origin isolated context in the future',
   /**
-  *@description Explanation for the SharedArrayBuffer availability status
+  *@description Explanation why SharedArrayBuffer is not available
+  *(https://developer.chrome.com/docs/extensions/mv3/cross-origin-isolation/)
+  *(for a lot of languages 'cross-origin isolation' does not need to be translated, please translate only where necessary).
   */
-  requiresCrossoriginIsolated: 'requires `cross-origin` isolated context',
+  requiresCrossoriginIsolated: 'requires cross-origin isolated context',
   /**
    *@description Explanation for the SharedArrayBuffer availability status in case the transfer of a SAB requires the
    * permission policy `cross-origin-isolated` to be enabled (e.g. because the message refers to the situation in an iframe).
@@ -218,10 +236,6 @@ const UIStrings = {
   */
   createdByAdScriptExplanation:
       'There was an ad script in the `(async) stack` when this frame was created. Examining the creation `stack trace` of this frame might provide more insight.',
-  /**
-   *@description Label for a list of origin trials that associated with at least one token.
-   */
-  // originTrials: 'Origin Trials',
 };
 const str_ = i18n.i18n.registerUIStrings('panels/application/components/FrameDetailsView.ts', UIStrings);
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
@@ -343,7 +357,7 @@ export class FrameDetailsReportView extends HTMLElement {
     return LitHtml.html`
       <${ReportView.ReportView.ReportSectionHeader.litTagName}>${i18nString(UIStrings.document)}</${
         ReportView.ReportView.ReportSectionHeader.litTagName}>
-      <${ReportView.ReportView.ReportKey.litTagName}>${i18n.i18n.lockedString('URL')}</${
+      <${ReportView.ReportView.ReportKey.litTagName}>${i18nString(UIStrings.url)}</${
         ReportView.ReportView.ReportKey.litTagName}>
       <${ReportView.ReportView.ReportValue.litTagName}>
         <div class="inline-items">
@@ -449,7 +463,7 @@ export class FrameDetailsReportView extends HTMLElement {
   private maybeRenderOrigin(): LitHtml.TemplateResult|{} {
     if (this.frame && this.frame.securityOrigin && this.frame.securityOrigin !== '://') {
       return LitHtml.html`
-        <${ReportView.ReportView.ReportKey.litTagName}>${i18n.i18n.lockedString('Origin')}</${
+        <${ReportView.ReportView.ReportKey.litTagName}>${i18nString(UIStrings.origin)}</${
           ReportView.ReportView.ReportKey.litTagName}>
         <${ReportView.ReportView.ReportValue.litTagName}>
           <div class="text-ellipsis" title=${this.frame.securityOrigin}>${this.frame.securityOrigin}</div>

package/front_end/panels/console/ConsolePrompt.ts

@@ -207,7 +207,14 @@ export class ConsolePrompt extends Common.ObjectWrapper.eventMixin<EventTypes, t
       {key: 'ArrowDown', run: (): boolean => this.moveHistory(1)},
       {mac: 'Ctrl-p', run: (): boolean => this.moveHistory(-1, true)},
       {mac: 'Ctrl-n', run: (): boolean => this.moveHistory(1, true)},
-      {key: 'Enter', run: (): boolean => this.evaluate(), shift: CodeMirror.insertNewlineAndIndent},
+      {
+        key: 'Enter',
+        run: (): boolean => {
+          this.handleEnter();
+          return true;
+        },
+        shift: CodeMirror.insertNewlineAndIndent,
+      },
     ];
   }
 
@@ -242,29 +249,28 @@ export class ConsolePrompt extends Common.ObjectWrapper.eventMixin<EventTypes, t
     return true;
   }
 
-  private enterWillEvaluate(): boolean {
+  private async enterWillEvaluate(): Promise<boolean> {
     const {state} = this.editor;
-    return state.doc.length > 0 && TextEditor.JavaScript.isExpressionComplete(state);
+    return state.doc.length > 0 && await TextEditor.JavaScript.isExpressionComplete(state.doc.toString());
   }
 
-  private evaluate(): boolean {
-    if (this.enterWillEvaluate()) {
+  private async handleEnter(): Promise<void> {
+    if (await this.enterWillEvaluate()) {
       this.appendCommand(this.text(), true);
       this.editor.dispatch({
         changes: {from: 0, to: this.editor.state.doc.length},
         scrollIntoView: true,
       });
     } else if (this.editor.state.doc.length) {
-      return CodeMirror.insertNewlineAndIndent(this.editor.editor);
+      CodeMirror.insertNewlineAndIndent(this.editor.editor);
     } else {
       this.editor.dispatch({scrollIntoView: true});
     }
-    return true;
   }
 
   private updatePromptIcon(): void {
     this.iconThrottler.schedule(async () => {
-      this.promptIcon.classList.toggle('console-prompt-incomplete', !this.enterWillEvaluate());
+      this.promptIcon.classList.toggle('console-prompt-incomplete', !(await this.enterWillEvaluate()));
     });
   }
 

package/front_end/panels/elements/AccessibilityTreeView.ts

@@ -120,16 +120,14 @@ export class AccessibilityTreeView extends UI.Widget.VBox implements
 
   // Selected node in the DOM tree has changed.
   async selectedNodeChanged(inspectedNode: SDK.DOMModel.DOMNode): Promise<void> {
-    if (this.isShowing()) {
+    if (this.isShowing() || (inspectedNode === this.inspectedDOMNode)) {
       return;
     }
     if (inspectedNode.ownerDocument && (inspectedNode.nodeName() === 'HTML' || inspectedNode.nodeName() === 'BODY')) {
-      inspectedNode = inspectedNode.ownerDocument;
+      this.inspectedDOMNode = inspectedNode.ownerDocument;
+    } else {
+      this.inspectedDOMNode = inspectedNode;
     }
-    if (inspectedNode === this.inspectedDOMNode) {
-      return;
-    }
-    this.inspectedDOMNode = inspectedNode;
   }
 
   treeUpdated({data}: Common.EventTarget

package/front_end/panels/issues/AttributionReportingIssueDetailsView.ts

@@ -32,6 +32,16 @@ const UIStrings = {
    * on an anchor HTML element ("a link").
    */
   invalidSourceEventId: 'Invalid `attributionsourceeventid`',
+  /**
+   * @description Label for the column showing the invalid value used as the 'attributionexpiry' attribute
+   * on an anchor HTML element ("a link").
+   */
+  invalidSourceExpiry: 'Invalid `attributionexpiry`',
+  /**
+   * @description Label for the column showing the invalid value used as the 'attributionpriority' attribute
+   * on an anchor HTML element ("a link").
+   */
+  invalidSourcePriority: 'Invalid `attributionsourcepriority`',
   /**
    * @description Label for the column showing the invalid URL used in an HTML anchor element ("a link").
    * A origin is (roughly said) the front part of a URL.
@@ -47,6 +57,16 @@ const UIStrings = {
    * 'event-source-trigger-data' query parameter.
    */
   invalidEventSourceTriggerData: 'Invalid `event-source-trigger-data`',
+  /**
+   * @description Label for the column showing the invalid value used for the
+   * 'priority' query parameter.
+   */
+  invalidTriggerPriority: 'Invalid `priority`',
+  /**
+   * @description Label for the column showing the invalid value used for the
+   * 'dedup-key' query parameter.
+   */
+  invalidTriggerDedupKey: 'Invalid `dedup-key`',
 };
 const str_ = i18n.i18n.registerUIStrings('panels/issues/AttributionReportingIssueDetailsView.ts', UIStrings);
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
@@ -94,15 +114,34 @@ export class AttributionReportingIssueDetailsView extends AffectedResourcesView
         this.appendColumnTitle(header, i18nString(UIStrings.request));
         this.appendColumnTitle(header, i18nString(UIStrings.invalidTriggerData));
         break;
+      case IssuesManager.AttributionReportingIssue.IssueCode.InvalidEventSourceTriggerData:
       case IssuesManager.AttributionReportingIssue.IssueCode.AttributionEventSourceTriggerDataTooLarge:
         this.appendColumnTitle(header, i18nString(UIStrings.request));
         this.appendColumnTitle(header, i18nString(UIStrings.invalidEventSourceTriggerData));
         break;
+      case IssuesManager.AttributionReportingIssue.IssueCode.InvalidTriggerPriority:
+        this.appendColumnTitle(header, i18nString(UIStrings.request));
+        this.appendColumnTitle(header, i18nString(UIStrings.invalidTriggerPriority));
+        break;
+      case IssuesManager.AttributionReportingIssue.IssueCode.InvalidTriggerDedupKey:
+        this.appendColumnTitle(header, i18nString(UIStrings.request));
+        this.appendColumnTitle(header, i18nString(UIStrings.invalidTriggerDedupKey));
+        break;
       case IssuesManager.AttributionReportingIssue.IssueCode.InvalidAttributionSourceEventId:
         this.appendColumnTitle(header, i18nString(UIStrings.frame));
         this.appendColumnTitle(header, i18nString(UIStrings.element));
         this.appendColumnTitle(header, i18nString(UIStrings.invalidSourceEventId));
         break;
+      case IssuesManager.AttributionReportingIssue.IssueCode.InvalidAttributionSourceExpiry:
+        this.appendColumnTitle(header, i18nString(UIStrings.frame));
+        this.appendColumnTitle(header, i18nString(UIStrings.element));
+        this.appendColumnTitle(header, i18nString(UIStrings.invalidSourceExpiry));
+        break;
+      case IssuesManager.AttributionReportingIssue.IssueCode.InvalidAttributionSourcePriority:
+        this.appendColumnTitle(header, i18nString(UIStrings.frame));
+        this.appendColumnTitle(header, i18nString(UIStrings.element));
+        this.appendColumnTitle(header, i18nString(UIStrings.invalidSourcePriority));
+        break;
       case IssuesManager.AttributionReportingIssue.IssueCode.MissingAttributionData:
         this.appendColumnTitle(header, i18nString(UIStrings.request));
         break;
@@ -144,11 +183,16 @@ export class AttributionReportingIssueDetailsView extends AffectedResourcesView
       case IssuesManager.AttributionReportingIssue.IssueCode.AttributionEventSourceTriggerDataTooLarge:
       case IssuesManager.AttributionReportingIssue.IssueCode.AttributionUntrustworthyOrigin:
       case IssuesManager.AttributionReportingIssue.IssueCode.InvalidAttributionData:
+      case IssuesManager.AttributionReportingIssue.IssueCode.InvalidEventSourceTriggerData:
+      case IssuesManager.AttributionReportingIssue.IssueCode.InvalidTriggerPriority:
+      case IssuesManager.AttributionReportingIssue.IssueCode.InvalidTriggerDedupKey:
         this.appendRequestOrEmptyCell(element, details.request);
         this.appendIssueDetailCell(element, details.invalidParameter || '');
         break;
       case IssuesManager.AttributionReportingIssue.IssueCode.AttributionSourceUntrustworthyFrameOrigin:
       case IssuesManager.AttributionReportingIssue.IssueCode.InvalidAttributionSourceEventId:
+      case IssuesManager.AttributionReportingIssue.IssueCode.InvalidAttributionSourceExpiry:
+      case IssuesManager.AttributionReportingIssue.IssueCode.InvalidAttributionSourcePriority:
         this.appendFrameOrEmptyCell(element, issue);
         await this.appendElementOrEmptyCell(element, issue);
         this.appendIssueDetailCell(element, details.invalidParameter || '');

package/front_end/panels/issues/CorsIssueDetailsView.ts

@@ -119,6 +119,10 @@ const UIStrings = {
   *@description Header for the column with the URL scheme that is not supported by fetch
   */
   unsupportedScheme: 'Unsupported Scheme',
+  /**
+  *@description A failed network request.
+  */
+  failedRequest: 'Failed Request',
 };
 const str_ = i18n.i18n.registerUIStrings('panels/issues/CorsIssueDetailsView.ts', UIStrings);
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
@@ -210,7 +214,6 @@ export class CorsIssueDetailsView extends AffectedResourcesView {
       default:
         Platform.assertUnhandled<IssuesManager.CorsIssue.IssueCode.PreflightMissingAllowExternal|
                                  IssuesManager.CorsIssue.IssueCode.PreflightInvalidAllowExternal|
-                                 IssuesManager.CorsIssue.IssueCode.InvalidResponse|
                                  IssuesManager.CorsIssue.IssueCode.InvalidPrivateNetworkAccess|
                                  IssuesManager.CorsIssue.IssueCode.UnexpectedPrivateNetworkAccess>(issueCode);
     }
@@ -283,6 +286,8 @@ export class CorsIssueDetailsView extends AffectedResourcesView {
         return i18nString(UIStrings.preflightInvalidStatus);
       case Protocol.Network.CorsError.PreflightDisallowedRedirect:
         return i18nString(UIStrings.preflightDisallowedRedirect);
+      case Protocol.Network.CorsError.InvalidResponse:
+        return i18nString(UIStrings.failedRequest);
     }
     throw new Error('Invalid Argument');
   }
@@ -447,7 +452,6 @@ export class CorsIssueDetailsView extends AffectedResourcesView {
         this.appendStatus(element, details.isWarning);
         Platform.assertUnhandled<IssuesManager.CorsIssue.IssueCode.PreflightMissingAllowExternal|
                                  IssuesManager.CorsIssue.IssueCode.PreflightInvalidAllowExternal|
-                                 IssuesManager.CorsIssue.IssueCode.InvalidResponse|
                                  IssuesManager.CorsIssue.IssueCode.InvalidPrivateNetworkAccess|
                                  IssuesManager.CorsIssue.IssueCode.UnexpectedPrivateNetworkAccess>(issueCode);
         break;

package/front_end/panels/settings/emulation/components/UserAgentClientHintsForm.ts

@@ -554,6 +554,7 @@ export class UserAgentClientHintsForm extends HTMLElement {
           aria-controls="form-container"
           @disabled=${this.isFormDisabled}
           aria-disabled=${this.isFormDisabled}
+          aria-label=${i18nString(UIStrings.title)}
         >
           <${IconButton.Icon.Icon.litTagName}
             class=${this.isFormOpened ? '' : 'rotate-icon'}

package/front_end/panels/sources/BreakpointEditDialog.ts

@@ -106,11 +106,14 @@ export class BreakpointEditDialog extends UI.Widget.Widget {
 
     const content = oldCondition || '';
     const finishIfComplete = (view: CodeMirror.EditorView): boolean => {
-      if (TextEditor.JavaScript.isExpressionComplete(view.state)) {
-        this.finishEditing(true, this.editor.state.doc.toString());
-        return true;
-      }
-      return false;
+      TextEditor.JavaScript.isExpressionComplete(view.state.doc.toString()).then((complete): void => {
+        if (complete) {
+          this.finishEditing(true, this.editor.state.doc.toString());
+        } else {
+          CodeMirror.insertNewlineAndIndent(view);
+        }
+      });
+      return true;
     };
     const keymap = [
       {

package/front_end/panels/timeline/TimelinePanel.ts

@@ -842,7 +842,7 @@ export class TimelinePanel extends UI.Panel.Panel implements Client, TimelineMod
 
   private recordingFailed(error: string): void {
     if (this.statusPane) {
-      this.statusPane.hide();
+      this.statusPane.remove();
     }
     this.statusPane = new StatusPane(
         {
@@ -1036,7 +1036,7 @@ export class TimelinePanel extends UI.Panel.Panel implements Client, TimelineMod
     this.hideLandingPage();
 
     if (this.statusPane) {
-      this.statusPane.hide();
+      this.statusPane.remove();
     }
     this.statusPane = new StatusPane(
         {
@@ -1073,7 +1073,7 @@ export class TimelinePanel extends UI.Panel.Panel implements Client, TimelineMod
     this.setState(State.Idle);
 
     if (this.statusPane) {
-      this.statusPane.hide();
+      this.statusPane.remove();
     }
     this.statusPane = null;
 
@@ -1405,9 +1405,10 @@ export class StatusPane extends UI.Widget.VBox {
     this.button.disabled = true;
   }
 
-  hide(): void {
+  remove(): void {
     (this.element.parentNode as HTMLElement).classList.remove('tinted');
     this.arrangeDialog((this.element.parentNode as HTMLElement));
+    this.stopTimer();
     this.element.remove();
   }