npm - chrome-devtools-frontend - Versions diffs - 1.0.948916 → 1.0.950768 - Mend

chrome-devtools-frontend 1.0.948916 → 1.0.950768

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (46) hide show

package/config/gni/all_devtools_files.gni CHANGED Viewed

@@ -50,6 +50,11 @@ all_devtools_files = [
   "front_end/models/issues_manager/descriptions/arAttributionUntrustworthyOrigin.md",
   "front_end/models/issues_manager/descriptions/arInvalidAttributionData.md",
   "front_end/models/issues_manager/descriptions/arInvalidAttributionSourceEventId.md",
+  "front_end/models/issues_manager/descriptions/arInvalidAttributionSourceExpiry.md",
+  "front_end/models/issues_manager/descriptions/arInvalidAttributionSourcePriority.md",
+  "front_end/models/issues_manager/descriptions/arInvalidEventSourceTriggerData.md",
+  "front_end/models/issues_manager/descriptions/arInvalidTriggerDedupKey.md",
+  "front_end/models/issues_manager/descriptions/arInvalidTriggerPriority.md",
   "front_end/models/issues_manager/descriptions/arMissingAttributionData.md",
   "front_end/models/issues_manager/descriptions/arPermissionPolicyDisabled.md",
   "front_end/models/issues_manager/descriptions/CoepCoopSandboxedIframeCannotNavigateToCoopPage.md",

package/config/gni/devtools_grd_files.gni CHANGED Viewed

@@ -274,6 +274,11 @@ grd_files_release_sources = [
   "front_end/models/issues_manager/descriptions/arAttributionUntrustworthyOrigin.md",
   "front_end/models/issues_manager/descriptions/arInvalidAttributionData.md",
   "front_end/models/issues_manager/descriptions/arInvalidAttributionSourceEventId.md",
+  "front_end/models/issues_manager/descriptions/arInvalidAttributionSourceExpiry.md",
+  "front_end/models/issues_manager/descriptions/arInvalidAttributionSourcePriority.md",
+  "front_end/models/issues_manager/descriptions/arInvalidEventSourceTriggerData.md",
+  "front_end/models/issues_manager/descriptions/arInvalidTriggerDedupKey.md",
+  "front_end/models/issues_manager/descriptions/arInvalidTriggerPriority.md",
   "front_end/models/issues_manager/descriptions/arMissingAttributionData.md",
   "front_end/models/issues_manager/descriptions/arPermissionPolicyDisabled.md",
   "front_end/models/issues_manager/descriptions/corsAllowCredentialsRequired.md",
@@ -549,7 +554,6 @@ grd_files_debug_sources = [
   "front_end/core/platform/set-utilities.js",
   "front_end/core/platform/string-utilities.js",
   "front_end/core/platform/typescript-utilities.js",
-  "front_end/core/platform/utilities.js",
   "front_end/core/protocol_client/InspectorBackend.js",
   "front_end/core/protocol_client/NodeURL.js",
   "front_end/core/root/Runtime.js",

package/docs/triage_guidelines.md CHANGED Viewed

@@ -45,8 +45,8 @@ Issues in the untriaged queue should receive a meaningful response within a busi
 - Close issues as `WontFix` if they don't reproduce (in simple cases) or are requests for features we've already concluded not to pursue.
 - Close issues as `Archived` that are valid, but it seems unlikely that we will get there anytime soon.
-- Move issues out of `Platform>DevTools` if they are not DevTools issues (but just reported via the menu item in DevTools), put on the `Hotlist-DevTools-Triaged` and leave the `Untriaged` status as is.
-- Assign regression bugs with bisects to individuals directly and set the status to `Assigned`.
+- Move issues out of `Platform>DevTools` if they are not DevTools issues (but just reported via the menu item in DevTools), put on the `DevTools-Triaged` label and leave the `Untriaged` status as is.
+- Assign regression bugs with bisects to individuals directly and set the status to `Assigned`.
 - Put proper `Platform>DevTools>XXX` component(s) on the issue and do an initial check-in regarding the priority.
 - Put one of the following labels on it and set the status to `Available`:
   - `Hotlist-DevTools-ProductReview` if it's controversial or clear that consensus needs to be built first.

package/front_end/core/dom_extension/DOMExtension.ts CHANGED Viewed

@@ -457,7 +457,7 @@ Node.prototype.isSelfOrDescendant = function(node: Node|null): boolean {
   return Boolean(node) && (node === this || this.isDescendant(node));
 };
-Node.prototype.traverseNextNode = function(stayWithin?: Node, skipShadowRoot?: boolean = false): Node|null {
+Node.prototype.traverseNextNode = function(stayWithin?: Node, skipShadowRoot: boolean = false): Node|null {
   if (!skipShadowRoot && this.shadowRoot) {
     return this.shadowRoot;
   }

package/front_end/core/host/InspectorFrontendHostAPI.ts CHANGED Viewed

@@ -357,7 +357,6 @@ export enum EnumeratedHistogram {
   IssuesPanelOpenedFrom = 'DevTools.IssuesPanelOpenedFrom',
   IssuesPanelResourceOpened = 'DevTools.IssuesPanelResourceOpened',
   KeybindSetSettingChanged = 'DevTools.KeybindSetSettingChanged',
-  DualScreenDeviceEmulated = 'DevTools.DualScreenDeviceEmulated',
   ExperimentEnabledAtLaunch = 'DevTools.ExperimentEnabledAtLaunch',
   ExperimentEnabled = 'DevTools.ExperimentEnabled',
   ExperimentDisabled = 'DevTools.ExperimentDisabled',

package/front_end/core/host/UserMetrics.ts CHANGED Viewed

@@ -158,12 +158,6 @@ export class UserMetrics {
     InspectorFrontendHostInstance.recordEnumeratedHistogram(EnumeratedHistogram.IssueCreated, issueCreated, size);
   }
-  dualScreenDeviceEmulated(emulationAction: DualScreenDeviceEmulated): void {
-    const size = Object.keys(DualScreenDeviceEmulated).length + 1;
-    InspectorFrontendHostInstance.recordEnumeratedHistogram(
-        EnumeratedHistogram.DualScreenDeviceEmulated, emulationAction, size);
-  }
   experimentEnabledAtLaunch(experimentId: string): void {
     const size = DevtoolsExperiments['__lastValidEnumPosition'] + 1;
     const experiment = DevtoolsExperiments[experimentId];
@@ -537,14 +531,6 @@ export enum IssueOpener {
   CommandMenu = 5,
 }
-// TODO(crbug.com/1167717): Make this a const enum again
-// eslint-disable-next-line rulesdir/const_enum
-export enum DualScreenDeviceEmulated {
-  DualScreenDeviceSelected = 0,
-  SpanButtonClicked = 1,
-  PlatformSupportUsed = 2,  // user starts to use platform dual screen support feature.
-}
 /**
  * This list should contain the currently active Devtools Experiments.
  * Therefore, it is possible that the id's will no longer be continuous

package/front_end/core/i18n/locales/en-US.json CHANGED Viewed

@@ -1955,9 +1955,18 @@
   "panels/accessibility/AXBreadcrumbsPane.ts | accessibilityTree": {
     "message": "Accessibility Tree"
   },
+  "panels/accessibility/AXBreadcrumbsPane.ts | fullTreeExperimentDescription": {
+    "message": "The accessibility tree moved to the top right corner of the DOM tree."
+  },
+  "panels/accessibility/AXBreadcrumbsPane.ts | fullTreeExperimentName": {
+    "message": "Enable full-page accessibility tree"
+  },
   "panels/accessibility/AXBreadcrumbsPane.ts | ignored": {
     "message": "Ignored"
   },
+  "panels/accessibility/AXBreadcrumbsPane.ts | reloadRequired": {
+    "message": "Reload required before the change takes effect."
+  },
   "panels/accessibility/AXBreadcrumbsPane.ts | scrollIntoView": {
     "message": "Scroll into view"
   },
@@ -2837,6 +2846,9 @@
   "panels/application/components/FrameDetailsView.ts | no": {
     "message": "No"
   },
+  "panels/application/components/FrameDetailsView.ts | origin": {
+    "message": "Origin"
+  },
   "panels/application/components/FrameDetailsView.ts | ownerElement": {
     "message": "Owner Element"
   },
@@ -2888,6 +2900,9 @@
   "panels/application/components/FrameDetailsView.ts | unreachableUrl": {
     "message": "Unreachable URL"
   },
+  "panels/application/components/FrameDetailsView.ts | url": {
+    "message": "URL"
+  },
   "panels/application/components/FrameDetailsView.ts | willRequireCrossoriginIsolated": {
     "message": "⚠️ will require cross-origin isolated context in the future"
   },
@@ -5189,9 +5204,21 @@
   "panels/issues/AttributionReportingIssueDetailsView.ts | invalidSourceEventId": {
     "message": "Invalid attributionsourceeventid"
   },
+  "panels/issues/AttributionReportingIssueDetailsView.ts | invalidSourceExpiry": {
+    "message": "Invalid attributionexpiry"
+  },
+  "panels/issues/AttributionReportingIssueDetailsView.ts | invalidSourcePriority": {
+    "message": "Invalid attributionsourcepriority"
+  },
   "panels/issues/AttributionReportingIssueDetailsView.ts | invalidTriggerData": {
     "message": "Invalid trigger-data"
   },
+  "panels/issues/AttributionReportingIssueDetailsView.ts | invalidTriggerDedupKey": {
+    "message": "Invalid dedup-key"
+  },
+  "panels/issues/AttributionReportingIssueDetailsView.ts | invalidTriggerPriority": {
+    "message": "Invalid priority"
+  },
   "panels/issues/AttributionReportingIssueDetailsView.ts | nViolations": {
     "message": "{n, plural, =1 {# violation} other {# violations}}"
   },
@@ -5219,6 +5246,9 @@
   "panels/issues/CorsIssueDetailsView.ts | disallowedRequestMethod": {
     "message": "Disallowed Request Method"
   },
+  "panels/issues/CorsIssueDetailsView.ts | failedRequest": {
+    "message": "Failed Request"
+  },
   "panels/issues/CorsIssueDetailsView.ts | header": {
     "message": "Header"
   },

package/front_end/core/i18n/locales/en-XL.json CHANGED Viewed

@@ -1955,9 +1955,18 @@
   "panels/accessibility/AXBreadcrumbsPane.ts | accessibilityTree": {
     "message": "Âćĉéŝśîb́îĺît́ŷ T́r̂éê"
   },
+  "panels/accessibility/AXBreadcrumbsPane.ts | fullTreeExperimentDescription": {
+    "message": "T̂h́ê áĉćêśŝíb̂íl̂ít̂ý t̂ŕêé m̂óv̂éd̂ t́ô t́ĥé t̂óp̂ ŕîǵĥt́ ĉór̂ńêŕ ôf́ t̂h́ê D́ÔḾ t̂ŕêé."
+  },
+  "panels/accessibility/AXBreadcrumbsPane.ts | fullTreeExperimentName": {
+    "message": "Êńâb́l̂é f̂úl̂ĺ-p̂áĝé âćĉéŝśîb́îĺît́ŷ t́r̂éê"
+  },
   "panels/accessibility/AXBreadcrumbsPane.ts | ignored": {
     "message": "Îǵn̂ór̂éd̂"
   },
+  "panels/accessibility/AXBreadcrumbsPane.ts | reloadRequired": {
+    "message": "R̂él̂óâd́ r̂éq̂úîŕêd́ b̂éf̂ór̂é t̂h́ê ćĥán̂ǵê t́âḱêś êf́f̂éĉt́."
+  },
   "panels/accessibility/AXBreadcrumbsPane.ts | scrollIntoView": {
     "message": "Ŝćr̂ól̂ĺ îńt̂ó v̂íêẃ"
   },
@@ -2775,7 +2784,7 @@
     "message": "ÂṔÎ áv̂áîĺâb́îĺît́ŷ"
   },
   "panels/application/components/FrameDetailsView.ts | availabilityOfCertainApisDepends": {
-    "message": "Âv́âíl̂áb̂íl̂ít̂ý ôf́ ĉér̂t́âín̂ ÁP̂Íŝ d́êṕêńd̂ś ôń t̂h́ê d́ôćûḿêńt̂ b́êín̂ǵ cross-origin îśôĺât́êd́."
+    "message": "Âv́âíl̂áb̂íl̂ít̂ý ôf́ ĉér̂t́âín̂ ÁP̂Íŝ d́êṕêńd̂ś ôń t̂h́ê d́ôćûḿêńt̂ b́êín̂ǵ ĉŕôśŝ-ór̂íĝín̂ íŝól̂át̂éd̂."
   },
   "panels/application/components/FrameDetailsView.ts | available": {
     "message": "âv́âíl̂áb̂ĺê"
@@ -2814,7 +2823,7 @@
     "message": "T̂h́îś f̂ŕâḿê ẃâś ĉŕêát̂éd̂ ṕr̂óĝŕâḿm̂át̂íĉál̂ĺŷ. T́ĥé stack trace ŝh́ôẃŝ ẃĥér̂é t̂h́îś ĥáp̂ṕêńêd́."
   },
   "panels/application/components/FrameDetailsView.ts | crossoriginIsolated": {
-    "message": "Cross-Origin Îśôĺât́êd́"
+    "message": "Ĉŕôśŝ-Ór̂íĝín̂ Íŝól̂át̂éd̂"
   },
   "panels/application/components/FrameDetailsView.ts | document": {
     "message": "D̂óĉúm̂én̂t́"
@@ -2837,6 +2846,9 @@
   "panels/application/components/FrameDetailsView.ts | no": {
     "message": "N̂ó"
   },
+  "panels/application/components/FrameDetailsView.ts | origin": {
+    "message": "Ôŕîǵîń"
+  },
   "panels/application/components/FrameDetailsView.ts | ownerElement": {
     "message": "Ôẃn̂ér̂ Él̂ém̂én̂t́"
   },
@@ -2847,7 +2859,7 @@
     "message": "r̂ép̂ór̂t́îńĝ t́ô"
   },
   "panels/application/components/FrameDetailsView.ts | requiresCrossoriginIsolated": {
-    "message": "r̂éq̂úîŕêś cross-origin îśôĺât́êd́ ĉón̂t́êx́t̂"
+    "message": "r̂éq̂úîŕêś ĉŕôśŝ-ór̂íĝín̂ íŝól̂át̂éd̂ ćôńt̂éx̂t́"
   },
   "panels/application/components/FrameDetailsView.ts | root": {
     "message": "r̂óôt́"
@@ -2888,8 +2900,11 @@
   "panels/application/components/FrameDetailsView.ts | unreachableUrl": {
     "message": "Ûńr̂éâćĥáb̂ĺê ÚR̂Ĺ"
   },
+  "panels/application/components/FrameDetailsView.ts | url": {
+    "message": "ÛŔL̂"
+  },
   "panels/application/components/FrameDetailsView.ts | willRequireCrossoriginIsolated": {
-    "message": "⚠️ ŵíl̂ĺ r̂éq̂úîŕê cross-origin íŝól̂át̂éd̂ ćôńt̂éx̂t́ îń t̂h́ê f́ût́ûŕê"
+    "message": "⚠️ ŵíl̂ĺ r̂éq̂úîŕê ćr̂óŝś-ôŕîǵîń îśôĺât́êd́ ĉón̂t́êx́t̂ ín̂ t́ĥé f̂út̂úr̂é"
   },
   "panels/application/components/FrameDetailsView.ts | yes": {
     "message": "Ŷéŝ"
@@ -5189,9 +5204,21 @@
   "panels/issues/AttributionReportingIssueDetailsView.ts | invalidSourceEventId": {
     "message": "Îńv̂ál̂íd̂ attributionsourceeventid"
   },
+  "panels/issues/AttributionReportingIssueDetailsView.ts | invalidSourceExpiry": {
+    "message": "Îńv̂ál̂íd̂ attributionexpiry"
+  },
+  "panels/issues/AttributionReportingIssueDetailsView.ts | invalidSourcePriority": {
+    "message": "Îńv̂ál̂íd̂ attributionsourcepriority"
+  },
   "panels/issues/AttributionReportingIssueDetailsView.ts | invalidTriggerData": {
     "message": "Îńv̂ál̂íd̂ trigger-data"
   },
+  "panels/issues/AttributionReportingIssueDetailsView.ts | invalidTriggerDedupKey": {
+    "message": "Îńv̂ál̂íd̂ dedup-key"
+  },
+  "panels/issues/AttributionReportingIssueDetailsView.ts | invalidTriggerPriority": {
+    "message": "Îńv̂ál̂íd̂ priority"
+  },
   "panels/issues/AttributionReportingIssueDetailsView.ts | nViolations": {
     "message": "{n, plural, =1 {# v̂íôĺât́îón̂} other {# v́îól̂át̂íôńŝ}}"
   },
@@ -5219,6 +5246,9 @@
   "panels/issues/CorsIssueDetailsView.ts | disallowedRequestMethod": {
     "message": "D̂íŝál̂ĺôẃêd́ R̂éq̂úêśt̂ Ḿêt́ĥód̂"
   },
+  "panels/issues/CorsIssueDetailsView.ts | failedRequest": {
+    "message": "F̂áîĺêd́ R̂éq̂úêśt̂"
+  },
   "panels/issues/CorsIssueDetailsView.ts | header": {
     "message": "Ĥéâd́êŕ"
   },

package/front_end/core/platform/platform.ts CHANGED Viewed

@@ -45,8 +45,7 @@ export {DCHECK} from './dcheck.js';
  * (e.g. `Platform.TypeScriptUtilities.assertNotNull` causes a
  * compiler error)
  */
-export {assertNotNullOrUndefined, assertUnhandled} from './typescript-utilities.js';
-export {assertNever, runOnWindowLoad} from './utilities.js';
+export {assertNever, assertNotNullOrUndefined, assertUnhandled} from './typescript-utilities.js';
 export {
   ArrayUtilities,
   DateUtilities,

package/front_end/core/platform/typescript-utilities.ts CHANGED Viewed

@@ -13,6 +13,10 @@ export function assertNotNullOrUndefined<T>(val: T): asserts val is NonNullable<
   }
 }
+export function assertNever(type: never, message: string): never {
+  throw new Error(message);
+}
 /**
  * This is useful to check on the type-level that the unhandled cases of
  * a switch are exactly `T` (where T is usually a union type of enum values).

package/front_end/core/root/Runtime.ts CHANGED Viewed

@@ -351,6 +351,7 @@ export enum ExperimentName {
   PROTOCOL_MONITOR = 'protocolMonitor',
   WEBAUTHN_PANE = 'webauthnPane',
   SYNC_SETTINGS = 'syncSettings',
+  FULL_ACCESSIBILITY_TREE = 'fullAccessibilityTree',
 }
 // TODO(crbug.com/1167717): Make this a const enum again

package/front_end/core/sdk/AccessibilityModel.ts CHANGED Viewed

@@ -291,25 +291,25 @@ export class AccessibilityModel extends SDKModel<EventTypes> implements Protocol
   async requestAXChildren(nodeId: Protocol.Accessibility.AXNodeId, frameId?: Protocol.Page.FrameId):
       Promise<AccessibilityNode[]> {
     const parent = this.#axIdToAXNode.get(nodeId);
-    if (parent && !parent.hasUnloadedChildren()) {
+    if (!parent) {
+      throw Error('Cannot request children before parent');
+    }
+    if (!parent.hasUnloadedChildren()) {
       return parent.children();
     }
     let nodes;
     const request = this.#pendingChildRequests.get(nodeId);
     if (request) {
-      nodes = (await request).nodes;
+      await request;
     } else {
       const req = this.agent.invoke_getChildAXNodes({id: nodeId, frameId});
       this.#pendingChildRequests.set(nodeId, req);
       nodes = (await req).nodes;
+      this.createNodesFromPayload(nodes);
       this.#pendingChildRequests.delete(nodeId);
     }
-    if (!nodes) {
-      return [];
-    }
-    const axNodes = this.createNodesFromPayload(nodes);
-    return axNodes;
+    return parent.children();
   }
   async requestAndLoadSubTreeToNode(node: DOMNode): Promise<AccessibilityNode[]|null> {

package/front_end/devtools_compatibility.js CHANGED Viewed

@@ -385,7 +385,6 @@
     IssuesPanelOpenedFrom: 'DevTools.IssuesPanelOpenedFrom',
     IssuesPanelResourceOpened: 'DevTools.IssuesPanelResourceOpened',
     KeybindSetSettingChanged: 'DevTools.KeybindSetSettingChanged',
-    DualScreenDeviceEmulated: 'DevTools.DualScreenDeviceEmulated',
     ExperimentEnabledAtLaunch: 'DevTools.ExperimentEnabledAtLaunch',
     ExperimentEnabled: 'DevTools.ExperimentEnabled',
     ExperimentDisabled: 'DevTools.ExperimentDisabled',

package/front_end/entrypoints/device_mode_emulation_frame/device_mode_emulation_frame.ts CHANGED Viewed

@@ -5,13 +5,8 @@
 import '../../core/dom_extension/dom_extension.js';
 import '../../Images/Images.js';
-import * as Platform from '../../core/platform/platform.js';
-Platform.runOnWindowLoad(() => {
-  if (!window.opener) {
-    return;
-  }
+if (window.opener) {
   // @ts-ignore TypeScript doesn't know about `Emulation` on `Window`.
   const app = window.opener.Emulation.AdvancedApp.instance();
   app.deviceModeEmulationFrameLoaded(document);
-});
+}

package/front_end/entrypoints/main/MainImpl.ts CHANGED Viewed

@@ -118,9 +118,7 @@ export class MainImpl {
   constructor() {
     MainImpl.instanceForTest = this;
-    Platform.runOnWindowLoad(() => {
-      this.loaded();
-    });
+    this.loaded();
   }
   static time(label: string): void {

package/front_end/models/issues_manager/AttributionReportingIssue.ts CHANGED Viewed

@@ -81,7 +81,11 @@ export class AttributionReportingIssue extends Issue<IssueCode> {
       case IssueCode.InvalidAttributionSourceEventId:
         return {
           file: 'arInvalidAttributionSourceEventId.md',
-          links: [],
+          links: [{
+            link:
+                'https://developer.chrome.com/docs/privacy-sandbox/attribution-reporting-event-guide/#html-attribute-attributionsourceeventid-required',
+            linkTitle: 'attributionsourceeventid attribute',
+          }],
         };
       case IssueCode.InvalidAttributionData:
         return {
@@ -101,7 +105,18 @@ export class AttributionReportingIssue extends Issue<IssueCode> {
       case IssueCode.AttributionSourceUntrustworthyOrigin:
         return {
           file: 'arAttributionSourceUntrustworthyOrigin.md',
-          links: [],
+          links: [
+            {
+              link:
+                  'https://developer.chrome.com/docs/privacy-sandbox/attribution-reporting-event-guide/#html-attribute-attributiondestination-required',
+              linkTitle: 'attributiondestination attribute',
+            },
+            {
+              link:
+                  'https://developer.chrome.com/docs/privacy-sandbox/attribution-reporting-event-guide/#html-attribute-attributionreportto',
+              linkTitle: 'attributionreportto attribute',
+            },
+          ],
         };
       case IssueCode.AttributionUntrustworthyFrameOrigin:
         return {
@@ -124,15 +139,46 @@ export class AttributionReportingIssue extends Issue<IssueCode> {
           links: [],
         };
       case IssueCode.InvalidAttributionSourceExpiry:
-        return null;
+        return {
+          file: 'arInvalidAttributionSourceExpiry.md',
+          links: [{
+            link:
+                'https://developer.chrome.com/docs/privacy-sandbox/attribution-reporting-event-guide/#html-attribute-attributionexpiry',
+            linkTitle: 'attributionexpiry attribute',
+          }],
+        };
       case IssueCode.InvalidAttributionSourcePriority:
-        return null;
+        return {
+          file: 'arInvalidAttributionSourcePriority.md',
+          links: [{
+            link:
+                'https://developer.chrome.com/docs/privacy-sandbox/attribution-reporting-event-guide/#html-attribute-attributionsourcepriority',
+            linkTitle: 'attributionsourcepriority attribute',
+          }],
+        };
       case IssueCode.InvalidEventSourceTriggerData:
-        return null;
+        return {
+          file: 'arInvalidEventSourceTriggerData.md',
+          links: [],
+        };
       case IssueCode.InvalidTriggerPriority:
-        return null;
+        return {
+          file: 'arInvalidTriggerPriority.md',
+          links: [{
+            link:
+                'https://developer.chrome.com/docs/privacy-sandbox/attribution-reporting-event-guide/#prioritize-specific-conversions',
+            linkTitle: 'Prioritizing specific conversions',
+          }],
+        };
       case IssueCode.InvalidTriggerDedupKey:
-        return null;
+        return {
+          file: 'arInvalidTriggerDedupKey.md',
+          links: [{
+            link:
+                'https://developer.chrome.com/docs/privacy-sandbox/attribution-reporting-event-guide/#deduplicate-reports',
+            linkTitle: 'Deduplicating reports',
+          }],
+        };
     }
   }

package/front_end/models/issues_manager/CorsIssue.ts CHANGED Viewed

@@ -40,7 +40,6 @@ export enum IssueCode {
   PreflightMissingAllowExternal = 'CorsIssue::PreflightMissingAllowExternal',
   // TODO(https://crbug.com/1263483): Remove this once it's removed from CDP.
   PreflightInvalidAllowExternal = 'CorsIssue::PreflightInvalidAllowExternal',
-  InvalidResponse = 'CorsIssue::InvalidResponse',
   NoCorsRedirectModeNotFollow = 'CorsIssue::NoCorsRedirectModeNotFollow',
   InvalidPrivateNetworkAccess = 'CorsIssue::InvalidPrivateNetworkAccess',
   UnexpectedPrivateNetworkAccess = 'CorsIssue::UnexpectedPrivateNetworkAccess',
@@ -63,6 +62,7 @@ function getIssueCode(details: Protocol.Audits.CorsIssueDetails): IssueCode {
       return IssueCode.WildcardOriginNotAllowed;
     case Protocol.Network.CorsError.PreflightInvalidStatus:
     case Protocol.Network.CorsError.PreflightDisallowedRedirect:
+    case Protocol.Network.CorsError.InvalidResponse:
       return IssueCode.PreflightResponseInvalid;
     case Protocol.Network.CorsError.AllowOriginMismatch:
     case Protocol.Network.CorsError.PreflightAllowOriginMismatch:
@@ -84,8 +84,6 @@ function getIssueCode(details: Protocol.Audits.CorsIssueDetails): IssueCode {
       return IssueCode.PreflightMissingAllowExternal;
     case Protocol.Network.CorsError.PreflightInvalidAllowExternal:
       return IssueCode.PreflightInvalidAllowExternal;
-    case Protocol.Network.CorsError.InvalidResponse:
-      return IssueCode.InvalidResponse;
     case Protocol.Network.CorsError.InsecurePrivateNetwork:
       return IssueCode.InsecurePrivateNetwork;
     case Protocol.Network.CorsError.NoCorsRedirectModeNotFollow:
@@ -226,7 +224,6 @@ export class CorsIssue extends Issue<IssueCode> {
         };
       case IssueCode.PreflightMissingAllowExternal:
       case IssueCode.PreflightInvalidAllowExternal:
-      case IssueCode.InvalidResponse:
       case IssueCode.InvalidPrivateNetworkAccess:
       case IssueCode.UnexpectedPrivateNetworkAccess:
         return null;

package/front_end/models/issues_manager/descriptions/arInvalidAttributionSourceExpiry.md ADDED Viewed

@@ -0,0 +1,4 @@
+# Ensure attribution source expiry is a valid number
+The expiry associated with an attribution source was defaulted to 30 days.
+This happens if the provided value is not a valid 64-bit signed integer.

package/front_end/models/issues_manager/descriptions/arInvalidAttributionSourcePriority.md ADDED Viewed

@@ -0,0 +1,4 @@
+# Ensure attribution source priority is a valid number
+The priority associated with an attribution source was defaulted to `0`.
+This happens if the provided value is not a valid 64-bit signed integer.

package/front_end/models/issues_manager/descriptions/arInvalidEventSourceTriggerData.md ADDED Viewed

@@ -0,0 +1,9 @@
+# Ensure the "event-source-trigger-data" query parameter for an attribution redirect is a valid number
+The event-source trigger data associated with an attribution was defaulted to `0`.
+This happens if the `event-source-trigger-data` query parameter provided in the `.well-known`
+redirect is not a valid 64-bit unsigned integer.
+Note that even if a valid integer is provided, only the lowest 1-bit of the
+`event-source-trigger-data` query parameter is recorded, with a 5% chance of the 1 bit being
+noised.

package/front_end/models/issues_manager/descriptions/arInvalidTriggerDedupKey.md ADDED Viewed

@@ -0,0 +1,5 @@
+# Ensure the "dedup-key" query parameter for an attribution redirect is a valid number
+The dedup key associated with an attribution was defaulted to `null`.
+This happens if the `dedup-key` query parameter provided in the `.well-known` redirect is not a
+valid 64-bit signed integer.

package/front_end/models/issues_manager/descriptions/arInvalidTriggerPriority.md ADDED Viewed

@@ -0,0 +1,5 @@
+# Ensure the "priority" query parameter for an attribution redirect is a valid number
+The priority associated with an attribution was defaulted to `0`.
+This happens if the `priority` query parameter provided in the `.well-known` redirect is not a
+valid 64-bit signed integer.

package/front_end/models/issues_manager/descriptions/corsPreflightResponseInvalid.md CHANGED Viewed

@@ -1,5 +1,5 @@
 # Ensure preflight responses are valid
-A cross-origin resource sharing (CORS) request was blocked because the response to the associated [preflight request](issueCorsPreflightRequest) had an unsuccessful HTTP status code and/or was a redirect.
+A cross-origin resource sharing (CORS) request was blocked because the response to the associated [preflight request](issueCorsPreflightRequest) failed, had an unsuccessful HTTP status code, and/or was a redirect.
-To fix this issue, ensure all CORS preflight `OPTION` requests are answered with a successful HTTP status code (2xx) and do not redirect.
+To fix this issue, ensure all CORS preflight `OPTIONS` requests are answered with a successful HTTP status code (2xx) and do not redirect.

package/front_end/panels/accessibility/AXBreadcrumbsPane.ts CHANGED Viewed

@@ -3,8 +3,11 @@
 // found in the LICENSE file.
 import * as Common from '../../core/common/common.js';
+import * as Host from '../../core/host/host.js';
 import * as i18n from '../../core/i18n/i18n.js';
+import * as Root from '../../core/root/root.js';
 import * as SDK from '../../core/sdk/sdk.js';
+import * as Feedback from '../../ui/components/panel_feedback/panel_feedback.js';
 import * as UI from '../../ui/legacy/legacy.js';
 import axBreadcrumbsStyles from './axBreadcrumbs.css.js';
@@ -27,6 +30,18 @@ const UIStrings = {
   *@description Ignored node element text content in AXBreadcrumbs Pane of the Accessibility panel
   */
   ignored: 'Ignored',
+  /**
+  *@description Name for experimental tree toggle.
+  */
+  fullTreeExperimentName: 'Enable full-page accessibility tree',
+  /**
+  *@description Description text for experimental tree toggle.
+  */
+  fullTreeExperimentDescription: 'The accessibility tree moved to the top right corner of the DOM tree.',
+  /**
+  *@description Message saying that DevTools must be restarted before the experiment is enabled.
+  */
+  reloadRequired: 'Reload required before the change takes effect.',
 };
 const str_ = i18n.i18n.registerUIStrings('panels/accessibility/AXBreadcrumbsPane.ts', UIStrings);
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
@@ -37,24 +52,48 @@ export class AXBreadcrumbsPane extends AccessibilitySubPane {
   private collapsingBreadcrumbId: number;
   private hoveredBreadcrumb: AXBreadcrumb|null;
   private readonly rootElement: HTMLElement;
+  #legacyTreeDisabled = false;
   constructor(axSidebarView: AccessibilitySidebarView) {
     super(i18nString(UIStrings.accessibilityTree));
     this.element.classList.add('ax-subpane');
-    UI.ARIAUtils.markAsTree(this.element);
     this.element.tabIndex = -1;
     this.axSidebarView = axSidebarView;
     this.preselectedBreadcrumb = null;
     this.inspectedNodeBreadcrumb = null;
     this.collapsingBreadcrumbId = -1;
-    this.hoveredBreadcrumb = null;
     this.rootElement = this.element.createChild('div', 'ax-breadcrumbs');
+    this.hoveredBreadcrumb = null;
+    const previewToggle = new Feedback.PreviewToggle.PreviewToggle();
+    const name = i18nString(UIStrings.fullTreeExperimentName);
+    const experiment = Root.Runtime.ExperimentName.FULL_ACCESSIBILITY_TREE;
+    const onChangeCallback: (checked: boolean) => void = checked => {
+      Host.userMetrics.experimentChanged(experiment, checked);
+      UI.InspectorView.InspectorView.instance().displayReloadRequiredWarning(i18nString(UIStrings.reloadRequired));
+    };
+    if (Root.Runtime.experiments.isEnabled(experiment)) {
+      this.#legacyTreeDisabled = true;
+      const feedbackURL = 'https://goo.gle/devtools-a11y-tree-feedback';
+      previewToggle.data = {
+        name,
+        helperText: i18nString(UIStrings.fullTreeExperimentDescription),
+        feedbackURL,
+        experiment,
+        onChangeCallback,
+      };
+      this.element.appendChild(previewToggle);
+      return;
+    }
+    previewToggle.data = {name, helperText: null, feedbackURL: null, experiment, onChangeCallback};
+    this.element.prepend(previewToggle);
+    UI.ARIAUtils.markAsTree(this.rootElement);
     this.rootElement.addEventListener('keydown', this.onKeyDown.bind(this), true);
     this.rootElement.addEventListener('mousemove', this.onMouseMove.bind(this), false);
     this.rootElement.addEventListener('mouseleave', this.onMouseLeave.bind(this), false);
@@ -72,6 +111,9 @@ export class AXBreadcrumbsPane extends AccessibilitySubPane {
   }
   setAXNode(axNode: SDK.AccessibilityModel.AccessibilityNode|null): void {
+    if (this.#legacyTreeDisabled) {
+      return;
+    }
     const hadFocus = this.element.hasFocus();
     super.setAXNode(axNode);

package/front_end/panels/accessibility/AccessibilitySidebarView.ts CHANGED Viewed

@@ -31,10 +31,8 @@ export class AccessibilitySidebarView extends UI.ThrottledWidget.ThrottledWidget
     this.axNodeInternal = null;
     this.skipNextPullNode = false;
     this.sidebarPaneStack = UI.ViewManager.ViewManager.instance().createStackLocation();
-    if (!Root.Runtime.experiments.isEnabled('fullAccessibilityTree')) {
-      this.breadcrumbsSubPane = new AXBreadcrumbsPane(this);
-      this.sidebarPaneStack.showView(this.breadcrumbsSubPane);
-    }
+    this.breadcrumbsSubPane = new AXBreadcrumbsPane(this);
+    this.sidebarPaneStack.showView(this.breadcrumbsSubPane);
     this.ariaSubPane = new ARIAAttributesPane();
     this.sidebarPaneStack.showView(this.ariaSubPane);
     this.axNodeSubPane = new AXNodeSubPane();