chrome-devtools-frontend 1.0.948445 → 1.0.950484

package/front_end/third_party/codemirror.next/codemirror.next.d.ts

@@ -2276,6 +2276,7 @@ interface MeasureRequest<T> {
     */
     key?: any;
 }
+declare type AttrSource = Attrs | ((view: EditorView) => Attrs | null);
 /**
 View [plugins](https://codemirror.net/6/docs/ref/#view.ViewPlugin) are given instances of this
 class, which describe what happened, whenever the view is updated.
@@ -2539,6 +2540,7 @@ declare class EditorView {
     readonly contentDOM: HTMLElement;
     private announceDOM;
     private plugins;
+    private pluginMap;
     private editorAttrs;
     private contentAttrs;
     private styleModules;
@@ -2960,12 +2962,12 @@ declare class EditorView {
     Facet that provides additional DOM attributes for the editor's
     editable DOM element.
     */
-    static contentAttributes: Facet<Attrs, Attrs>;
+    static contentAttributes: Facet<AttrSource, readonly AttrSource[]>;
     /**
     Facet that provides DOM attributes for the editor's outer
     element.
     */
-    static editorAttributes: Facet<Attrs, Attrs>;
+    static editorAttributes: Facet<AttrSource, readonly AttrSource[]>;
     /**
     An extension that enables line wrapping in the editor (by
     setting CSS `white-space` to `pre-wrap` in the content).
@@ -3157,10 +3159,10 @@ Configuration options.
 config?: SpecialCharConfig): Extension;
 
 /**
-Returns a plugin that makes sure the content has a bottom margin
-equivalent to the height of the editor, minus one line height, so
-that every line in the document can be scrolled to the top of the
-editor.
+Returns an extension that makes sure the content has a bottom
+margin equivalent to the height of the editor, minus one line
+height, so that every line in the document can be scrolled to the
+top of the editor.
 
 This is only meaningful when the editor is scrollable, and should
 not be enabled in editors that take the size of their content.

package/front_end/third_party/codemirror.next/package.json

@@ -8,7 +8,7 @@
     "@codemirror/commands": "0.19.5",
     "@codemirror/comment": "0.19.0",
     "@codemirror/fold": "0.19.2",
-    "@codemirror/gutter": "0.19.7",
+    "@codemirror/gutter": "0.19.8",
     "@codemirror/highlight": "0.19.6",
     "@codemirror/history": "0.19.0",
     "@codemirror/lang-cpp": "0.19.1",
@@ -22,7 +22,7 @@
     "@codemirror/lang-python": "0.19.2",
     "@codemirror/lang-wast": "0.19.0",
     "@codemirror/lang-xml": "0.19.2",
-    "@codemirror/language": "0.19.6",
+    "@codemirror/language": "0.19.7",
     "@codemirror/legacy-modes": "0.19.0",
     "@codemirror/matchbrackets": "0.19.3",
     "@codemirror/panel": "0.19.0",
@@ -32,7 +32,7 @@
     "@codemirror/stream-parser": "0.19.2",
     "@codemirror/text": "0.19.5",
     "@codemirror/tooltip": "0.19.10",
-    "@codemirror/view": "0.19.23",
+    "@codemirror/view": "0.19.25",
     "@lezer/common": "0.15.10",
     "@lezer/lr": "0.15.5",
     "@rollup/plugin-node-resolve": "^13.0.4",

package/front_end/ui/components/markdown_view/MarkdownLinksMap.ts

@@ -27,9 +27,25 @@ export const markdownLinks = new Map<string, string>([
   ],
   ['issueQuirksModeDoctype', 'https://web.dev/doctype/'],
   ['sameSiteAndSameOrigin', 'https://web.dev/same-site-same-origin/'],
+  // Link URLs for deprecation issues (see blink::Deprecation)
+  ['https://xhr.spec.whatwg.org/', 'https://xhr.spec.whatwg.org/'],
+  ['https://goo.gl/rStTGz', 'https://goo.gl/rStTGz'],
+  ['https://webrtc.org/web-apis/chrome/unified-plan/', 'https://webrtc.org/web-apis/chrome/unified-plan/'],
+  [
+    'https://developer.chrome.com/blog/enabling-shared-array-buffer/',
+    'https://developer.chrome.com/blog/enabling-shared-array-buffer/',
+  ],
+  ['https://developer.chrome.com/docs/extensions/mv3/', 'https://developer.chrome.com/docs/extensions/mv3/'],
+  [
+    'https://developer.chrome.com/blog/immutable-document-domain',
+    'https://developer.chrome.com/blog/immutable-document-domain',
+  ],
 ]);
 
 export const getMarkdownLink = (key: string): string => {
+  if (/^https:\/\/www.chromestatus.com\/feature\/\d+$/.test(key)) {
+    return key;
+  }
   const link = markdownLinks.get(key);
   if (!link) {
     throw new Error(`Markdown link with key '${key}' is not available, please check MarkdownLinksMap.ts`);

package/front_end/ui/components/text_editor/javascript.ts

@@ -402,13 +402,22 @@ async function completeExpressionGlobal(): Promise<CompletionSet> {
   return fetchNames;
 }
 
-export function isExpressionComplete(state: CodeMirror.EditorState): boolean {
-  for (const cursor = CodeMirror.syntaxTree(state).cursor(); cursor.next();) {
-    if (cursor.type.isError) {
-      return false;
-    }
-  }
-  return true;
+export async function isExpressionComplete(expression: string): Promise<boolean> {
+  const currentExecutionContext = UI.Context.Context.instance().flavor(SDK.RuntimeModel.ExecutionContext);
+  if (!currentExecutionContext) {
+    return true;
+  }
+  const result =
+      await currentExecutionContext.runtimeModel.compileScript(expression, '', false, currentExecutionContext.id);
+  if (!result || !result.exceptionDetails || !result.exceptionDetails.exception) {
+    return true;
+  }
+  const description = result.exceptionDetails.exception.description;
+  if (description) {
+    return !description.startsWith('SyntaxError: Unexpected end of input') &&
+        !description.startsWith('SyntaxError: Unterminated template literal');
+  }
+  return false;
 }
 
 export function argumentHints(): CodeMirror.Extension {

package/package.json

@@ -53,5 +53,5 @@
     "unittest": "scripts/test/run_unittests.py --no-text-coverage",
     "watch": "third_party/node/node.py --output scripts/watch_build.js"
   },
-  "version": "1.0.948445"
+  "version": "1.0.950484"
 }

package/scripts/eslint_rules/lib/ban_a_tags_in_lit_html.js

@@ -3,16 +3,7 @@
 // found in the LICENSE file.
 'use strict';
 
-function isLitHtmlTemplateCall(taggedTemplateExpression) {
-  if (taggedTemplateExpression.name) {
-    // Call to html`` and we assume that html = LitHtml's html function.
-    return taggedTemplateExpression.name === 'html';
-  }
-
-  // Match calls to LitHtml.html``
-  return taggedTemplateExpression.object && taggedTemplateExpression.object.name === 'LitHtml' &&
-      taggedTemplateExpression.property.name === 'html';
-}
+const {isLitHtmlTemplateCall} = require('./utils.js');
 
 module.exports = {
   meta: {
@@ -27,7 +18,7 @@ module.exports = {
   create: function(context) {
     return {
       TaggedTemplateExpression(node) {
-        const isLitHtmlCall = isLitHtmlTemplateCall(node.tag);
+        const isLitHtmlCall = isLitHtmlTemplateCall(node);
         if (!isLitHtmlCall) {
           return;
         }

package/scripts/eslint_rules/lib/ban_literal_devtools_component_tag_names.js

@@ -3,16 +3,7 @@
 // found in the LICENSE file.
 'use strict';
 
-function isLitHtmlTemplateCall(taggedTemplateExpression) {
-  if (taggedTemplateExpression.name) {
-    // Call to html`` and we assume that html = LitHtml's html function.
-    return taggedTemplateExpression.name === 'html';
-  }
-
-  // Match calls to LitHtml.html``
-  return taggedTemplateExpression.object && taggedTemplateExpression.object.name === 'LitHtml' &&
-      taggedTemplateExpression.property.name === 'html';
-}
+const {isLitHtmlTemplateCall} = require('./utils.js');
 
 module.exports = {
   meta: {
@@ -28,7 +19,7 @@ module.exports = {
   create: function(context) {
     return {
       TaggedTemplateExpression(node) {
-        const isLitHtmlCall = isLitHtmlTemplateCall(node.tag);
+        const isLitHtmlCall = isLitHtmlTemplateCall(node);
         if (!isLitHtmlCall) {
           return;
         }

package/scripts/eslint_rules/lib/ban_self_closing_custom_element_tagnames.js

@@ -3,16 +3,7 @@
 // found in the LICENSE file.
 'use strict';
 
-function isLitHtmlTemplateCall(taggedTemplateExpression) {
-  if (taggedTemplateExpression.name) {
-    // Call to html`` and we assume that html = LitHtml's html function.
-    return taggedTemplateExpression.name === 'html';
-  }
-
-  // Match calls to LitHtml.html``
-  return taggedTemplateExpression.object && taggedTemplateExpression.object.name === 'LitHtml' &&
-      taggedTemplateExpression.property.name === 'html';
-}
+const {isLitHtmlTemplateCall} = require('./utils.js');
 
 module.exports = {
   meta: {
@@ -27,7 +18,7 @@ module.exports = {
   create: function(context) {
     return {
       TaggedTemplateExpression(node) {
-        const isLitHtmlCall = isLitHtmlTemplateCall(node.tag);
+        const isLitHtmlCall = isLitHtmlTemplateCall(node);
         if (!isLitHtmlCall) {
           return;
         }

package/scripts/eslint_rules/lib/ban_style_tags_in_lit_html.js

@@ -3,16 +3,7 @@
 // found in the LICENSE file.
 'use strict';
 
-function isLitHtmlTemplateCall(taggedTemplateExpression) {
-  if (taggedTemplateExpression.name) {
-    // Call to html`` and we assume that html = LitHtml's html function.
-    return taggedTemplateExpression.name === 'html';
-  }
-
-  // Match calls to LitHtml.html``
-  return taggedTemplateExpression.object && taggedTemplateExpression.object.name === 'LitHtml' &&
-      taggedTemplateExpression.property.name === 'html';
-}
+const {isLitHtmlTemplateCall} = require('./utils.js');
 
 module.exports = {
   meta: {
@@ -28,7 +19,7 @@ module.exports = {
   create: function(context) {
     return {
       TaggedTemplateExpression(node) {
-        const isLitHtmlCall = isLitHtmlTemplateCall(node.tag);
+        const isLitHtmlCall = isLitHtmlTemplateCall(node);
         if (!isLitHtmlCall) {
           return;
         }

package/scripts/eslint_rules/lib/lit_html_data_as_type.js

@@ -3,16 +3,7 @@
 // found in the LICENSE file.
 'use strict';
 
-function isLitHtmlTemplateCall(taggedTemplateExpression) {
-  if (taggedTemplateExpression.name) {
-    // Call to html`` and we assume that html = LitHtml's html function.
-    return taggedTemplateExpression.name === 'html';
-  }
-
-  // Match calls to LitHtml.html``
-  return taggedTemplateExpression.object && taggedTemplateExpression.object.name === 'LitHtml' &&
-      taggedTemplateExpression.property.name === 'html';
-}
+const {isLitHtmlTemplateCall} = require('./utils.js');
 
 function findIndexOfDataSetterUsageForNode(taggedTemplateExpression) {
   const dataSetterText = '.data=';
@@ -66,7 +57,7 @@ module.exports = {
   create: function(context) {
     return {
       TaggedTemplateExpression(node) {
-        const isLitHtmlCall = isLitHtmlTemplateCall(node.tag);
+        const isLitHtmlCall = isLitHtmlTemplateCall(node);
         if (!isLitHtmlCall) {
           return;
         }

package/scripts/eslint_rules/lib/lit_html_no_attribute_quotes.js

@@ -3,19 +3,7 @@
 // found in the LICENSE file.
 'use strict';
 
-function isLitHtmlTemplateCall(taggedTemplateExpressionNode) {
-  // Match LitHtml.html``
-  const {tag} = taggedTemplateExpressionNode;
-  if (!tag) {
-    return false;
-  }
-  // Match LitHtml.html``
-  const isLitHtmlDotHtmlCall = tag.object?.name === 'LitHtml' && tag.property?.name === 'html';
-  // Match html`` (and guess that it's Lit)
-  const isDestructuredHtmlCall = tag.type === 'Identifier' && tag.name === 'html';
-
-  return isLitHtmlDotHtmlCall || isDestructuredHtmlCall;
-}
+const {isLitHtmlTemplateCall} = require('./utils.js');
 
 function templateElementPartStartsWithDoubleQuote(templateElementPartNode) {
   return templateElementPartNode.value.raw.startsWith('"');

package/scripts/eslint_rules/lib/lit_no_style_interpolation.js

@@ -3,16 +3,7 @@
 // found in the LICENSE file.
 'use strict';
 
-function isLitHtmlTemplateCall(taggedTemplateExpression) {
-  if (taggedTemplateExpression.name) {
-    // Call to html`` and we assume that html = LitHtml's html function.
-    return taggedTemplateExpression.name === 'html';
-  }
-
-  // Match calls to LitHtml.html``
-  return taggedTemplateExpression.object && taggedTemplateExpression.object.name === 'LitHtml' &&
-      taggedTemplateExpression.property.name === 'html';
-}
+const {isLitHtmlTemplateCall} = require('./utils.js');
 
 function countOccurencesOfSubstring(string, subString) {
   let count = 0;
@@ -71,7 +62,7 @@ module.exports = {
   create: function(context) {
     return {
       TaggedTemplateExpression(node) {
-        const isLitHtmlCall = isLitHtmlTemplateCall(node.tag);
+        const isLitHtmlCall = isLitHtmlTemplateCall(node);
         if (!isLitHtmlCall) {
           return;
         }

package/scripts/eslint_rules/lib/static_tag_must_be_static_property.js

@@ -3,16 +3,7 @@
 // found in the LICENSE file.
 'use strict';
 
-function isLitHtmlTemplateCall(taggedTemplateExpression) {
-  if (taggedTemplateExpression.name) {
-    // Call to html`` and we assume that html = LitHtml's html function.
-    return taggedTemplateExpression.name === 'html';
-  }
-
-  // Match calls to LitHtml.html``
-  return taggedTemplateExpression.object && taggedTemplateExpression.object.name === 'LitHtml' &&
-      taggedTemplateExpression.property.name === 'html';
-}
+const {isLitHtmlTemplateCall} = require('./utils.js');
 
 module.exports = {
   meta: {
@@ -52,7 +43,7 @@ module.exports = {
 
     return {
       TaggedTemplateExpression(node) {
-        if (!isLitHtmlTemplateCall(node.tag)) {
+        if (!isLitHtmlTemplateCall(node)) {
           return;
         }
 

package/scripts/eslint_rules/lib/utils.js

@@ -0,0 +1,29 @@
+// Copyright 2021 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// This file contains utility functions that are commonly needed in ESLint
+// rules. It does not contain any ESLint rules itself.
+
+/**
+ * @param taggedTemplateExpressionNode - a TaggedTemplateExpression node from the AST of the parsed code.
+ * @returns {boolean} - `true` if the code matches LitHtml.html`` or html``, and false otherwise.
+*/
+function isLitHtmlTemplateCall(taggedTemplateExpressionNode) {
+  if (taggedTemplateExpressionNode.type !== 'TaggedTemplateExpression') {
+    throw new Error('Node of type other than TaggedTemplateExpression passed to isLitHtmlTemplateCall.');
+  }
+  // Match LitHtml.html``
+  const {tag} = taggedTemplateExpressionNode;
+  if (!tag) {
+    return false;
+  }
+  // Match LitHtml.html``
+  const isLitHtmlDotHtmlCall = tag.object?.name === 'LitHtml' && tag.property?.name === 'html';
+  // Match html`` (and guess that it's Lit)
+  const isDestructuredHtmlCall = tag.type === 'Identifier' && tag.name === 'html';
+
+  return isLitHtmlDotHtmlCall || isDestructuredHtmlCall;
+}
+
+module.exports = {isLitHtmlTemplateCall};

package/scripts/eslint_rules/tests/.eslintrc.js

@@ -10,5 +10,9 @@ rulesDirPlugin.RULES_DIR = path.join(__dirname, '..', 'lib');
 module.exports = {
   'rules': {
     'rulesdir/no_only_eslint_tests': 2,
+    // errors on it('test') with no body
+    'mocha/no-pending-tests': 2,
+    // errors on {describe, it}.only
+    'mocha/no-exclusive-tests': 2,
   }
 };

package/scripts/eslint_rules/tests/utils_test.js

@@ -0,0 +1,40 @@
+// Copyright 2021 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+const parser = require('@typescript-eslint/parser');
+
+const utils = require('../lib/utils.js');
+const {assert} = require('chai');
+
+describe('eslint utils', () => {
+  describe('isLitHtmlTemplateCall', () => {
+    it('returns true if the code is LitHtml.html``', () => {
+      const code = 'LitHtml.html`<span>foo</span>`';
+      const parsed = parser.parse(code);
+      const result = utils.isLitHtmlTemplateCall(parsed.body[0].expression);
+      assert.strictEqual(result, true);
+    });
+
+    it('returns true if the code is html``', () => {
+      const code = 'html`<span>foo</span>`';
+      const parsed = parser.parse(code);
+      const result = utils.isLitHtmlTemplateCall(parsed.body[0].expression);
+      assert.strictEqual(result, true);
+    });
+
+    it('returns false if the code is LitHtml.somethingElse``', () => {
+      const code = 'LitHtml.somethingElse`<span>foo</span>`';
+      const parsed = parser.parse(code);
+      const result = utils.isLitHtmlTemplateCall(parsed.body[0].expression);
+      assert.strictEqual(result, false);
+    });
+
+    it('returns false if the code is another tagged template function``', () => {
+      const code = 'notLitHtml`<span>foo</span>`';
+      const parsed = parser.parse(code);
+      const result = utils.isLitHtmlTemplateCall(parsed.body[0].expression);
+      assert.strictEqual(result, false);
+    });
+  });
+});

package/front_end/panels/help/HelpImpl.ts

@@ -1,141 +0,0 @@
-// Copyright 2017 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-import * as Common from '../../core/common/common.js';
-import * as Host from '../../core/host/host.js';
-import * as UI from '../../ui/legacy/legacy.js';
-
-import {releaseNoteText} from './ReleaseNoteText.js';
-
-export const releaseVersionSeen = 'releaseNoteVersionSeen';
-
-export const releaseNoteViewId: string = 'release-note';
-
-let latestReleaseNoteInstance: ReleaseNote;
-
-let releaseNotesForTest: ReleaseNote[];
-
-let releaseNoteVersionSetting: Common.Settings.Setting<number>;
-
-export function latestReleaseNote(): ReleaseNote {
-  if (!latestReleaseNoteInstance) {
-    latestReleaseNoteInstance =
-        (releaseNotesForTest || releaseNoteText).reduce((acc, note) => note.version > acc.version ? note : acc);
-  }
-  return latestReleaseNoteInstance;
-}
-
-export function showReleaseNoteIfNeeded(): void {
-  const releaseNoteVersionSetting = Common.Settings.Settings.instance().createSetting(releaseVersionSeen, 0);
-  const releaseNoteVersionSettingValue = releaseNoteVersionSetting.get();
-  innerShowReleaseNoteIfNeeded(
-      releaseNoteVersionSettingValue, latestReleaseNote().version,
-      Common.Settings.Settings.instance().moduleSetting('help.show-release-note').get());
-}
-
-export function setReleaseNotesForTest(releaseNote: ReleaseNote[]): void {
-  releaseNotesForTest = releaseNote;
-}
-
-export function getReleaseNoteVersionSetting(): Common.Settings.Setting<number> {
-  if (!releaseNoteVersionSetting) {
-    releaseNoteVersionSetting = Common.Settings.Settings.instance().createSetting(releaseVersionSeen, 0);
-  }
-  return releaseNoteVersionSetting;
-}
-
-export function innerShowReleaseNoteIfNeeded(
-    lastSeenVersion: number, latestVersion: number, showReleaseNote: boolean): boolean {
-  const releaseNoteVersionSetting = Common.Settings.Settings.instance().createSetting(releaseVersionSeen, 0);
-  if (!lastSeenVersion) {
-    releaseNoteVersionSetting.set(latestVersion);
-    return false;
-  }
-  if (!showReleaseNote) {
-    return false;
-  }
-  if (lastSeenVersion >= latestVersion) {
-    return false;
-  }
-  releaseNoteVersionSetting.set(latestVersion);
-  UI.ViewManager.ViewManager.instance().showView(releaseNoteViewId, true);
-  return true;
-}
-
-let helpLateInitializationInstance: HelpLateInitialization;
-export class HelpLateInitialization implements Common.Runnable.Runnable {
-  static instance(opts: {forceNew: boolean|null} = {forceNew: null}): HelpLateInitialization {
-    const {forceNew} = opts;
-    if (!helpLateInitializationInstance || forceNew) {
-      helpLateInitializationInstance = new HelpLateInitialization();
-    }
-    return helpLateInitializationInstance;
-  }
-
-  async run(): Promise<void> {
-    if (!Host.InspectorFrontendHost.isUnderTest()) {
-      showReleaseNoteIfNeeded();
-    }
-  }
-}
-
-let releaseNotesActionDelegateInstance: ReleaseNotesActionDelegate;
-export class ReleaseNotesActionDelegate implements UI.ActionRegistration.ActionDelegate {
-  handleAction(_context: UI.Context.Context, _actionId: string): boolean {
-    Host.InspectorFrontendHost.InspectorFrontendHostInstance.openInNewTab(latestReleaseNote().link);
-    return true;
-  }
-  static instance(opts: {forceNew: boolean|null} = {forceNew: null}): ReleaseNotesActionDelegate {
-    const {forceNew} = opts;
-    if (!releaseNotesActionDelegateInstance || forceNew) {
-      releaseNotesActionDelegateInstance = new ReleaseNotesActionDelegate();
-    }
-
-    return releaseNotesActionDelegateInstance;
-  }
-}
-
-let reportIssueActionDelegateInstance: ReportIssueActionDelegate;
-export class ReportIssueActionDelegate implements UI.ActionRegistration.ActionDelegate {
-  handleAction(_context: UI.Context.Context, _actionId: string): boolean {
-    Host.InspectorFrontendHost.InspectorFrontendHostInstance.openInNewTab(
-        'https://bugs.chromium.org/p/chromium/issues/entry?template=DevTools+issue');
-    return true;
-  }
-  static instance(opts: {forceNew: boolean|null} = {forceNew: null}): ReportIssueActionDelegate {
-    const {forceNew} = opts;
-    if (!reportIssueActionDelegateInstance || forceNew) {
-      reportIssueActionDelegateInstance = new ReportIssueActionDelegate();
-    }
-
-    return reportIssueActionDelegateInstance;
-  }
-}
-
-let reportTranslationIssueActionDelegateInstance: ReportTranslationIssueActionDelegate;
-export class ReportTranslationIssueActionDelegate implements UI.ActionRegistration.ActionDelegate {
-  handleAction(_context: UI.Context.Context, _actionId: string): boolean {
-    Host.InspectorFrontendHost.InspectorFrontendHostInstance.openInNewTab('https://goo.gle/devtools-translate');
-    return true;
-  }
-  static instance(opts: {forceNew: boolean|null} = {forceNew: null}): ReportTranslationIssueActionDelegate {
-    const {forceNew} = opts;
-    if (!reportTranslationIssueActionDelegateInstance || forceNew) {
-      reportTranslationIssueActionDelegateInstance = new ReportTranslationIssueActionDelegate();
-    }
-
-    return reportTranslationIssueActionDelegateInstance;
-  }
-}
-export interface ReleaseNoteHighlight {
-  title: string;
-  subtitle: string;
-  link: string;
-}
-export interface ReleaseNote {
-  version: number;
-  header: string;
-  highlights: {title: string, subtitle: string, link: string}[];
-  link: string;
-}