chrome-devtools-frontend 1.0.948445 → 1.0.950484

package/front_end/panels/issues/AttributionReportingIssueDetailsView.ts

@@ -32,6 +32,16 @@ const UIStrings = {
    * on an anchor HTML element ("a link").
    */
   invalidSourceEventId: 'Invalid `attributionsourceeventid`',
+  /**
+   * @description Label for the column showing the invalid value used as the 'attributionexpiry' attribute
+   * on an anchor HTML element ("a link").
+   */
+  invalidSourceExpiry: 'Invalid `attributionexpiry`',
+  /**
+   * @description Label for the column showing the invalid value used as the 'attributionpriority' attribute
+   * on an anchor HTML element ("a link").
+   */
+  invalidSourcePriority: 'Invalid `attributionsourcepriority`',
   /**
    * @description Label for the column showing the invalid URL used in an HTML anchor element ("a link").
    * A origin is (roughly said) the front part of a URL.
@@ -47,6 +57,16 @@ const UIStrings = {
    * 'event-source-trigger-data' query parameter.
    */
   invalidEventSourceTriggerData: 'Invalid `event-source-trigger-data`',
+  /**
+   * @description Label for the column showing the invalid value used for the
+   * 'priority' query parameter.
+   */
+  invalidTriggerPriority: 'Invalid `priority`',
+  /**
+   * @description Label for the column showing the invalid value used for the
+   * 'dedup-key' query parameter.
+   */
+  invalidTriggerDedupKey: 'Invalid `dedup-key`',
 };
 const str_ = i18n.i18n.registerUIStrings('panels/issues/AttributionReportingIssueDetailsView.ts', UIStrings);
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
@@ -94,15 +114,34 @@ export class AttributionReportingIssueDetailsView extends AffectedResourcesView
         this.appendColumnTitle(header, i18nString(UIStrings.request));
         this.appendColumnTitle(header, i18nString(UIStrings.invalidTriggerData));
         break;
+      case IssuesManager.AttributionReportingIssue.IssueCode.InvalidEventSourceTriggerData:
       case IssuesManager.AttributionReportingIssue.IssueCode.AttributionEventSourceTriggerDataTooLarge:
         this.appendColumnTitle(header, i18nString(UIStrings.request));
         this.appendColumnTitle(header, i18nString(UIStrings.invalidEventSourceTriggerData));
         break;
+      case IssuesManager.AttributionReportingIssue.IssueCode.InvalidTriggerPriority:
+        this.appendColumnTitle(header, i18nString(UIStrings.request));
+        this.appendColumnTitle(header, i18nString(UIStrings.invalidTriggerPriority));
+        break;
+      case IssuesManager.AttributionReportingIssue.IssueCode.InvalidTriggerDedupKey:
+        this.appendColumnTitle(header, i18nString(UIStrings.request));
+        this.appendColumnTitle(header, i18nString(UIStrings.invalidTriggerDedupKey));
+        break;
       case IssuesManager.AttributionReportingIssue.IssueCode.InvalidAttributionSourceEventId:
         this.appendColumnTitle(header, i18nString(UIStrings.frame));
         this.appendColumnTitle(header, i18nString(UIStrings.element));
         this.appendColumnTitle(header, i18nString(UIStrings.invalidSourceEventId));
         break;
+      case IssuesManager.AttributionReportingIssue.IssueCode.InvalidAttributionSourceExpiry:
+        this.appendColumnTitle(header, i18nString(UIStrings.frame));
+        this.appendColumnTitle(header, i18nString(UIStrings.element));
+        this.appendColumnTitle(header, i18nString(UIStrings.invalidSourceExpiry));
+        break;
+      case IssuesManager.AttributionReportingIssue.IssueCode.InvalidAttributionSourcePriority:
+        this.appendColumnTitle(header, i18nString(UIStrings.frame));
+        this.appendColumnTitle(header, i18nString(UIStrings.element));
+        this.appendColumnTitle(header, i18nString(UIStrings.invalidSourcePriority));
+        break;
       case IssuesManager.AttributionReportingIssue.IssueCode.MissingAttributionData:
         this.appendColumnTitle(header, i18nString(UIStrings.request));
         break;
@@ -144,11 +183,16 @@ export class AttributionReportingIssueDetailsView extends AffectedResourcesView
       case IssuesManager.AttributionReportingIssue.IssueCode.AttributionEventSourceTriggerDataTooLarge:
       case IssuesManager.AttributionReportingIssue.IssueCode.AttributionUntrustworthyOrigin:
       case IssuesManager.AttributionReportingIssue.IssueCode.InvalidAttributionData:
+      case IssuesManager.AttributionReportingIssue.IssueCode.InvalidEventSourceTriggerData:
+      case IssuesManager.AttributionReportingIssue.IssueCode.InvalidTriggerPriority:
+      case IssuesManager.AttributionReportingIssue.IssueCode.InvalidTriggerDedupKey:
         this.appendRequestOrEmptyCell(element, details.request);
         this.appendIssueDetailCell(element, details.invalidParameter || '');
         break;
       case IssuesManager.AttributionReportingIssue.IssueCode.AttributionSourceUntrustworthyFrameOrigin:
       case IssuesManager.AttributionReportingIssue.IssueCode.InvalidAttributionSourceEventId:
+      case IssuesManager.AttributionReportingIssue.IssueCode.InvalidAttributionSourceExpiry:
+      case IssuesManager.AttributionReportingIssue.IssueCode.InvalidAttributionSourcePriority:
         this.appendFrameOrEmptyCell(element, issue);
         await this.appendElementOrEmptyCell(element, issue);
         this.appendIssueDetailCell(element, details.invalidParameter || '');

package/front_end/panels/issues/CorsIssueDetailsView.ts

@@ -119,6 +119,10 @@ const UIStrings = {
   *@description Header for the column with the URL scheme that is not supported by fetch
   */
   unsupportedScheme: 'Unsupported Scheme',
+  /**
+  *@description A failed network request.
+  */
+  failedRequest: 'Failed Request',
 };
 const str_ = i18n.i18n.registerUIStrings('panels/issues/CorsIssueDetailsView.ts', UIStrings);
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
@@ -210,7 +214,6 @@ export class CorsIssueDetailsView extends AffectedResourcesView {
       default:
         Platform.assertUnhandled<IssuesManager.CorsIssue.IssueCode.PreflightMissingAllowExternal|
                                  IssuesManager.CorsIssue.IssueCode.PreflightInvalidAllowExternal|
-                                 IssuesManager.CorsIssue.IssueCode.InvalidResponse|
                                  IssuesManager.CorsIssue.IssueCode.InvalidPrivateNetworkAccess|
                                  IssuesManager.CorsIssue.IssueCode.UnexpectedPrivateNetworkAccess>(issueCode);
     }
@@ -283,6 +286,8 @@ export class CorsIssueDetailsView extends AffectedResourcesView {
         return i18nString(UIStrings.preflightInvalidStatus);
       case Protocol.Network.CorsError.PreflightDisallowedRedirect:
         return i18nString(UIStrings.preflightDisallowedRedirect);
+      case Protocol.Network.CorsError.InvalidResponse:
+        return i18nString(UIStrings.failedRequest);
     }
     throw new Error('Invalid Argument');
   }
@@ -447,7 +452,6 @@ export class CorsIssueDetailsView extends AffectedResourcesView {
         this.appendStatus(element, details.isWarning);
         Platform.assertUnhandled<IssuesManager.CorsIssue.IssueCode.PreflightMissingAllowExternal|
                                  IssuesManager.CorsIssue.IssueCode.PreflightInvalidAllowExternal|
-                                 IssuesManager.CorsIssue.IssueCode.InvalidResponse|
                                  IssuesManager.CorsIssue.IssueCode.InvalidPrivateNetworkAccess|
                                  IssuesManager.CorsIssue.IssueCode.UnexpectedPrivateNetworkAccess>(issueCode);
         break;

package/front_end/panels/settings/emulation/components/UserAgentClientHintsForm.ts

@@ -554,6 +554,7 @@ export class UserAgentClientHintsForm extends HTMLElement {
           aria-controls="form-container"
           @disabled=${this.isFormDisabled}
           aria-disabled=${this.isFormDisabled}
+          aria-label=${i18nString(UIStrings.title)}
         >
           <${IconButton.Icon.Icon.litTagName}
             class=${this.isFormOpened ? '' : 'rotate-icon'}

package/front_end/panels/sources/BreakpointEditDialog.ts

@@ -106,11 +106,14 @@ export class BreakpointEditDialog extends UI.Widget.Widget {
 
     const content = oldCondition || '';
     const finishIfComplete = (view: CodeMirror.EditorView): boolean => {
-      if (TextEditor.JavaScript.isExpressionComplete(view.state)) {
-        this.finishEditing(true, this.editor.state.doc.toString());
-        return true;
-      }
-      return false;
+      TextEditor.JavaScript.isExpressionComplete(view.state.doc.toString()).then((complete): void => {
+        if (complete) {
+          this.finishEditing(true, this.editor.state.doc.toString());
+        } else {
+          CodeMirror.insertNewlineAndIndent(view);
+        }
+      });
+      return true;
     };
     const keymap = [
       {

package/front_end/panels/timeline/TimelinePanel.ts

@@ -842,7 +842,7 @@ export class TimelinePanel extends UI.Panel.Panel implements Client, TimelineMod
 
   private recordingFailed(error: string): void {
     if (this.statusPane) {
-      this.statusPane.hide();
+      this.statusPane.remove();
     }
     this.statusPane = new StatusPane(
         {
@@ -1036,7 +1036,7 @@ export class TimelinePanel extends UI.Panel.Panel implements Client, TimelineMod
     this.hideLandingPage();
 
     if (this.statusPane) {
-      this.statusPane.hide();
+      this.statusPane.remove();
     }
     this.statusPane = new StatusPane(
         {
@@ -1073,7 +1073,7 @@ export class TimelinePanel extends UI.Panel.Panel implements Client, TimelineMod
     this.setState(State.Idle);
 
     if (this.statusPane) {
-      this.statusPane.hide();
+      this.statusPane.remove();
     }
     this.statusPane = null;
 
@@ -1405,9 +1405,10 @@ export class StatusPane extends UI.Widget.VBox {
     this.button.disabled = true;
   }
 
-  hide(): void {
+  remove(): void {
     (this.element.parentNode as HTMLElement).classList.remove('tinted');
     this.arrangeDialog((this.element.parentNode as HTMLElement));
+    this.stopTimer();
     this.element.remove();
   }