chrome-devtools-frontend 1.0.946920 → 1.0.948445

package/front_end/legacy/legacy-defs.d.ts

@@ -1,9 +1,6 @@
 // Copyright 2020 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
-interface StringConstructor {
-  sprintf(format: string, ...var_arg: any): string;
-}
 
 interface Window {
   UI: {themeSupport: unknown}
@@ -124,7 +121,6 @@ interface Node {
 
 declare function isEnterOrSpaceKey(event: Event): boolean;
 declare function isEscKey(event: Event): boolean;
-declare function createPlainTextSearchRegex(query: string, flags?: string): RegExp;
 declare function onInvokeElement(element: Element, callback: (event: Event) => void): void;
 
 interface ServicePort {

package/front_end/legacy_test_runner/test_runner/TestRunner.js

@@ -23,6 +23,10 @@ self.Platform = self.Platform || {};
 self.Platform.StringUtilities = Platform.StringUtilities;
 self.Platform.MapUtilities = Platform.MapUtilities;
 self.Platform.ArrayUtilities = Platform.ArrayUtilities;
+self.createPlainTextSearchRegex = Platform.StringUtilities.createPlainTextSearchRegex;
+String.sprintf = Platform.StringUtilities.sprintf;
+String.regexSpecialCharacters = Platform.StringUtilities.regexSpecialCharacters;
+String.caseInsensetiveComparator = Platform.StringUtilities.caseInsensetiveComparator;
 
 /**
  * @return {boolean}
@@ -229,23 +233,36 @@ export function addSnifferPromise(receiver, methodName) {
   });
 }
 
-/** @type {function():void} */
-let _resolveOnFinishInits;
-
-/**
- * @param {string} module
- * @return {!Promise<undefined>}
- */
-export async function loadModule(module) {
-  const promise = new Promise(resolve => {
-    _resolveOnFinishInits = resolve;
-  });
-  await self.runtime.loadModulePromise(module);
-  if (!_pendingInits) {
-    return;
-  }
-  return promise;
-}
+const mappingForLayoutTests = new Map([
+  ['panels/animation', 'animation'],
+  ['panels/browser_debugger', 'browser_debugger'],
+  ['panels/changes', 'changes'],
+  ['panels/console', 'console'],
+  ['panels/elements', 'elements'],
+  ['panels/emulation', 'emulation'],
+  ['panels/mobile_throttling', 'mobile_throttling'],
+  ['panels/network', 'network'],
+  ['panels/profiler', 'profiler'],
+  ['panels/application', 'resources'],
+  ['panels/search', 'search'],
+  ['panels/sources', 'sources'],
+  ['panels/snippets', 'snippets'],
+  ['panels/settings', 'settings'],
+  ['panels/timeline', 'timeline'],
+  ['panels/web_audio', 'web_audio'],
+  ['models/persistence', 'persistence'],
+  ['models/workspace_diff', 'workspace_diff'],
+  ['entrypoints/main', 'main'],
+  ['third_party/diff', 'diff'],
+  ['ui/legacy/components/inline_editor', 'inline_editor'],
+  ['ui/legacy/components/data_grid', 'data_grid'],
+  ['ui/legacy/components/perf_ui', 'perf_ui'],
+  ['ui/legacy/components/source_frame', 'source_frame'],
+  ['ui/legacy/components/color_picker', 'color_picker'],
+  ['ui/legacy/components/cookie_table', 'cookie_table'],
+  ['ui/legacy/components/quick_open', 'quick_open'],
+  ['ui/legacy/components/utils', 'components'],
+]);
 
 /**
  * @param {string} module
@@ -253,7 +270,7 @@ export async function loadModule(module) {
  */
 export async function loadLegacyModule(module) {
   let containingFolder = module;
-  for (const [remappedFolder, originalFolder] of Root.Runtime.mappingForLayoutTests.entries()) {
+  for (const [remappedFolder, originalFolder] of mappingForLayoutTests.entries()) {
     if (originalFolder === module) {
       containingFolder = remappedFolder;
     }
@@ -667,9 +684,6 @@ export function addIframe(path, options = {}) {
   `);
 }
 
-/** @type {number} */
-let _pendingInits = 0;
-
 /**
  * The old test framework executed certain snippets in the inspected page
  * context as part of loading a test helper file.
@@ -685,12 +699,7 @@ let _pendingInits = 0;
  * @param {string} code
  */
 export async function deprecatedInitAsync(code) {
-  _pendingInits++;
   await TestRunner.RuntimeAgent.invoke_evaluate({expression: code, objectGroup: 'console'});
-  _pendingInits--;
-  if (!_pendingInits && _resolveOnFinishInits !== undefined) {
-    _resolveOnFinishInits();
-  }
 }
 
 /**
@@ -1290,36 +1299,6 @@ export class MockSetting {
   }
 }
 
-/**
- * @return {!Array<!Root.Runtime.Module>}
- */
-export function loadedModules() {
-  return self.runtime.modules.filter(module => module.loadedForTest)
-      .filter(module => module.name() !== 'help')
-      .filter(module => module.name().indexOf('test_runner') === -1);
-}
-
-/**
- * @param {!Array<!Root.Runtime.Module>} relativeTo
- * @return {!Array<!Root.Runtime.Module>}
- */
-export function dumpLoadedModules(relativeTo) {
-  const previous = new Set(relativeTo || []);
-  function moduleSorter(left, right) {
-    return Platform.StringUtilities.naturalOrderComparator(left.descriptor.name, right.descriptor.name);
-  }
-
-  addResult('Loaded modules:');
-  const sortedLoadedModules = loadedModules().sort(moduleSorter);
-  for (const module of sortedLoadedModules) {
-    if (previous.has(module)) {
-      continue;
-    }
-    addResult('    ' + module.descriptor.name);
-  }
-  return sortedLoadedModules;
-}
-
 /**
  * @param {string} urlSuffix
  * @param {!Workspace.Workspace.projectTypes=} projectType
@@ -1511,13 +1490,10 @@ TestRunner.override = override;
 TestRunner.clearSpecificInfoFromStackFrames = clearSpecificInfoFromStackFrames;
 TestRunner.hideInspectorView = hideInspectorView;
 TestRunner.mainFrame = mainFrame;
-TestRunner.loadedModules = loadedModules;
-TestRunner.dumpLoadedModules = dumpLoadedModules;
 TestRunner.waitForUISourceCode = waitForUISourceCode;
 TestRunner.waitForUISourceCodeRemoved = waitForUISourceCodeRemoved;
 TestRunner.url = url;
 TestRunner.dumpSyntaxHighlight = dumpSyntaxHighlight;
-TestRunner.loadModule = loadModule;
 TestRunner.loadLegacyModule = loadLegacyModule;
 TestRunner.loadTestModule = loadTestModule;
 TestRunner.evaluateInPageRemoteObject = evaluateInPageRemoteObject;

package/front_end/models/bindings/CompilerScriptMapping.ts

@@ -329,7 +329,6 @@ class Binding {
   readonly #project: ContentProviderBasedProject;
   readonly #url: string;
   referringSourceMaps: SDK.SourceMap.SourceMap[];
-  readonly #activeSourceMap?: SDK.SourceMap.SourceMap|null;
   uiSourceCode: Workspace.UISourceCode.UISourceCode|null;
 
   constructor(project: ContentProviderBasedProject, url: string) {

package/front_end/models/bindings/DebuggerLanguagePlugins.ts

@@ -614,15 +614,12 @@ class SourceScopeRemoteObject extends SDK.RemoteObject.RemoteObjectImpl {
   variables: Chrome.DevTools.Variable[];
   #callFrame: SDK.DebuggerModel.CallFrame;
   #plugin: DebuggerLanguagePlugin;
-  readonly #location: Chrome.DevTools.RawLocation;
 
-  constructor(
-      callFrame: SDK.DebuggerModel.CallFrame, plugin: DebuggerLanguagePlugin, location: Chrome.DevTools.RawLocation) {
+  constructor(callFrame: SDK.DebuggerModel.CallFrame, plugin: DebuggerLanguagePlugin) {
     super(callFrame.debuggerModel.runtimeModel(), undefined, 'object', undefined, null);
     this.variables = [];
     this.#callFrame = callFrame;
     this.#plugin = plugin;
-    this.#location = location;
   }
 
   async doGetProperties(ownProperties: boolean, accessorPropertiesOnly: boolean, _generatePreview: boolean):
@@ -691,18 +688,16 @@ export class SourceScope implements SDK.DebuggerModel.ScopeChainEntry {
   readonly #typeNameInternal: string;
   readonly #iconInternal: string|undefined;
   readonly #objectInternal: SourceScopeRemoteObject;
-  readonly #nameInternal: string;
   readonly #startLocationInternal: SDK.DebuggerModel.Location|null;
   readonly #endLocationInternal: SDK.DebuggerModel.Location|null;
   constructor(
       callFrame: SDK.DebuggerModel.CallFrame, type: string, typeName: string, icon: string|undefined,
-      plugin: DebuggerLanguagePlugin, location: Chrome.DevTools.RawLocation) {
+      plugin: DebuggerLanguagePlugin) {
     this.#callFrameInternal = callFrame;
     this.#typeInternal = type;
     this.#typeNameInternal = typeName;
     this.#iconInternal = icon;
-    this.#objectInternal = new SourceScopeRemoteObject(callFrame, plugin, location);
-    this.#nameInternal = type;
+    this.#objectInternal = new SourceScopeRemoteObject(callFrame, plugin);
     this.#startLocationInternal = null;
     this.#endLocationInternal = null;
   }
@@ -1154,7 +1149,7 @@ export class DebuggerLanguagePluginManager implements
         let scope = scopes.get(variable.scope);
         if (!scope) {
           const {type, typeName, icon} = await plugin.getScopeInfo(variable.scope);
-          scope = new SourceScope(callFrame, type, typeName, icon, plugin, location);
+          scope = new SourceScope(callFrame, type, typeName, icon, plugin);
           scopes.set(variable.scope, scope);
         }
         scope.object().variables.push(variable);
@@ -1292,11 +1287,9 @@ export class DebuggerLanguagePluginManager implements
 }
 
 class ModelData {
-  readonly #debuggerModel: SDK.DebuggerModel.DebuggerModel;
   project: ContentProviderBasedProject;
   readonly uiSourceCodeToScripts: Map<Workspace.UISourceCode.UISourceCode, SDK.Script.Script[]>;
   constructor(debuggerModel: SDK.DebuggerModel.DebuggerModel, workspace: Workspace.Workspace.WorkspaceImpl) {
-    this.#debuggerModel = debuggerModel;
     this.project = new ContentProviderBasedProject(
         workspace, 'language_plugins::' + debuggerModel.target().id(), Workspace.Workspace.projectTypes.Network, '',
         false /* isServiceProject */);

package/front_end/models/bindings/SASSSourceMapping.ts

@@ -165,7 +165,6 @@ class Binding {
   readonly #project: ContentProviderBasedProject;
   readonly #url: string;
   referringSourceMaps: SDK.SourceMap.TextSourceMap[];
-  readonly #activeSourceMap?: SDK.SourceMap.TextSourceMap|null;
   uiSourceCode: Workspace.UISourceCode.UISourceCode|null;
 
   constructor(project: ContentProviderBasedProject, url: string) {

package/front_end/models/emulation/DeviceModeModel.ts

@@ -99,7 +99,6 @@ export class DeviceModeModel extends Common.ObjectWrapper.ObjectWrapper<EventTyp
   #touchMobile: boolean;
   #emulationModel: SDK.EmulationModel.EmulationModel|null;
   #onModelAvailable: (() => void)|null;
-  #emulatedPageSize?: UI.Geometry.Size;
   #outlineRectInternal?: Rect;
 
   private constructor() {
@@ -622,7 +621,6 @@ export class DeviceModeModel extends Common.ObjectWrapper.ObjectWrapper<EventTyp
 
     let pageWidth: 0|number = screenSize.width - insets.left - insets.right;
     let pageHeight: 0|number = screenSize.height - insets.top - insets.bottom;
-    this.#emulatedPageSize = new UI.Geometry.Size(pageWidth, pageHeight);
 
     const positionX = insets.left;
     const positionY = insets.top;

package/front_end/models/issues_manager/CorsIssue.ts

@@ -13,7 +13,7 @@ const UIStrings = {
   /**
   *@description Label for the link for CORS private network issues
   */
-  corsForPrivateNetworksRfc: 'CORS for private networks (RFC1918)',
+  corsPrivateNetworkAccess: 'Private Network Access',
   /**
   *@description Label for the link for CORS network issues
   */
@@ -26,7 +26,6 @@ const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 // eslint-disable-next-line rulesdir/const_enum
 export enum IssueCode {
   InsecurePrivateNetwork = 'CorsIssue::InsecurePrivateNetwork',
-  InsecurePrivateNetworkPreflight = 'CorsIssue::InsecurePrivateNetworkPreflight',
   InvalidHeaderValues = 'CorsIssue::InvalidHeaders',
   WildcardOriginNotAllowed = 'CorsIssue::WildcardOriginWithCredentials',
   PreflightResponseInvalid = 'CorsIssue::PreflightResponseInvalid',
@@ -37,12 +36,15 @@ export enum IssueCode {
   RedirectContainsCredentials = 'CorsIssue::RedirectContainsCredentials',
   DisallowedByMode = 'CorsIssue::DisallowedByMode',
   CorsDisabledScheme = 'CorsIssue::CorsDisabledScheme',
+  // TODO(https://crbug.com/1263483): Remove this once it's removed from CDP.
   PreflightMissingAllowExternal = 'CorsIssue::PreflightMissingAllowExternal',
+  // TODO(https://crbug.com/1263483): Remove this once it's removed from CDP.
   PreflightInvalidAllowExternal = 'CorsIssue::PreflightInvalidAllowExternal',
   InvalidResponse = 'CorsIssue::InvalidResponse',
   NoCorsRedirectModeNotFollow = 'CorsIssue::NoCorsRedirectModeNotFollow',
   InvalidPrivateNetworkAccess = 'CorsIssue::InvalidPrivateNetworkAccess',
   UnexpectedPrivateNetworkAccess = 'CorsIssue::UnexpectedPrivateNetworkAccess',
+  PreflightAllowPrivateNetworkError = 'CorsIssue::PreflightAllowPrivateNetworkError',
 }
 
 function getIssueCode(details: Protocol.Audits.CorsIssueDetails): IssueCode {
@@ -85,14 +87,16 @@ function getIssueCode(details: Protocol.Audits.CorsIssueDetails): IssueCode {
     case Protocol.Network.CorsError.InvalidResponse:
       return IssueCode.InvalidResponse;
     case Protocol.Network.CorsError.InsecurePrivateNetwork:
-      return details.clientSecurityState?.initiatorIsSecureContext ? IssueCode.InsecurePrivateNetworkPreflight :
-                                                                     IssueCode.InsecurePrivateNetwork;
+      return IssueCode.InsecurePrivateNetwork;
     case Protocol.Network.CorsError.NoCorsRedirectModeNotFollow:
       return IssueCode.NoCorsRedirectModeNotFollow;
     case Protocol.Network.CorsError.InvalidPrivateNetworkAccess:
       return IssueCode.InvalidPrivateNetworkAccess;
     case Protocol.Network.CorsError.UnexpectedPrivateNetworkAccess:
       return IssueCode.UnexpectedPrivateNetworkAccess;
+    case Protocol.Network.CorsError.PreflightMissingAllowPrivateNetwork:
+    case Protocol.Network.CorsError.PreflightInvalidAllowPrivateNetwork:
+      return IssueCode.PreflightAllowPrivateNetworkError;
   }
 }
 
@@ -121,15 +125,15 @@ export class CorsIssue extends Issue<IssueCode> {
           file: 'corsInsecurePrivateNetwork.md',
           links: [{
             link: 'https://developer.chrome.com/blog/private-network-access-update',
-            linkTitle: i18nString(UIStrings.corsForPrivateNetworksRfc),
+            linkTitle: i18nString(UIStrings.corsPrivateNetworkAccess),
           }],
         };
-      case IssueCode.InsecurePrivateNetworkPreflight:
+      case IssueCode.PreflightAllowPrivateNetworkError:
         return {
-          file: 'corsInsecurePrivateNetworkPreflight.md',
+          file: 'corsPreflightAllowPrivateNetworkError.md',
           links: [{
             link: 'https://developer.chrome.com/blog/private-network-access-update',
-            linkTitle: i18nString(UIStrings.corsForPrivateNetworksRfc),
+            linkTitle: i18nString(UIStrings.corsPrivateNetworkAccess),
           }],
         };
       case IssueCode.InvalidHeaderValues:
@@ -235,7 +239,11 @@ export class CorsIssue extends Issue<IssueCode> {
 
   getKind(): IssueKind {
     if (this.issueDetails.isWarning &&
-        this.issueDetails.corsErrorStatus.corsError === Protocol.Network.CorsError.InsecurePrivateNetwork) {
+        (this.issueDetails.corsErrorStatus.corsError === Protocol.Network.CorsError.InsecurePrivateNetwork ||
+         this.issueDetails.corsErrorStatus.corsError ===
+             Protocol.Network.CorsError.PreflightMissingAllowPrivateNetwork ||
+         this.issueDetails.corsErrorStatus.corsError ===
+             Protocol.Network.CorsError.PreflightInvalidAllowPrivateNetwork)) {
       return IssueKind.BreakingChange;
     }
     return IssueKind.PageError;

package/front_end/models/issues_manager/descriptions/{corsInsecurePrivateNetworkPreflight.md → corsPreflightAllowPrivateNetworkError.md}

@@ -3,7 +3,7 @@
 A site requested a resource from a network that it could only access because of its users' privileged network position.
 These requests expose devices and servers to the internet, increasing the risk of a cross-site request forgery (CSRF) attack, and/or information leakage.
 
-To mitigate these risks, a future version of Chrome will require non-public subresources to opt-into being accessed with a preflight request.
+To mitigate these risks, Chrome will require non-public subresources to opt-into being accessed with a preflight request and will start blocking them in Chrome 101 (April 2022).
 
 To fix this issue, ensure that response to the [preflight request](issueCorsPreflightRequest) for the private network resource has the `Access-Control-Allow-Private-Network` header set to `true`.
 

package/front_end/panels/accessibility/AccessibilitySidebarView.ts

@@ -107,7 +107,9 @@ export class AccessibilitySidebarView extends UI.ThrottledWidget.ThrottledWidget
     if (!accessibilityModel) {
       return;
     }
-    accessibilityModel.clear();
+    if (!Root.Runtime.experiments.isEnabled('fullAccessibilityTree')) {
+      accessibilityModel.clear();
+    }
     await accessibilityModel.requestPartialAXTree(node);
     this.accessibilityNodeCallback(accessibilityModel.axNodeForDOMNode(node));
   }

package/front_end/panels/animation/AnimationTimeline.ts

@@ -107,7 +107,6 @@ export class AnimationTimeline extends UI.Widget.VBox implements SDK.TargetManag
   #uiAnimations: AnimationUI[];
   #groupBuffer: AnimationGroup[];
   readonly #previewMap: Map<AnimationGroup, AnimationGroupPreviewUI>;
-  readonly #symbol: symbol;
   readonly #animationsMap: Map<string, AnimationImpl>;
   #timelineScrubberLine?: HTMLElement;
   #pauseButton?: UI.Toolbar.ToolbarToggle;
@@ -143,7 +142,6 @@ export class AnimationTimeline extends UI.Widget.VBox implements SDK.TargetManag
     this.#uiAnimations = [];
     this.#groupBuffer = [];
     this.#previewMap = new Map();
-    this.#symbol = Symbol('animationTimeline');
     this.#animationsMap = new Map();
     SDK.TargetManager.TargetManager.instance().addModelListener(
         SDK.DOMModel.DOMModel, SDK.DOMModel.Events.NodeRemoved, this.nodeRemoved, this);

package/front_end/panels/animation/AnimationUI.ts

@@ -42,7 +42,6 @@ type CachedElement = {
 export class AnimationUI {
   #animationInternal: AnimationImpl;
   #timeline: AnimationTimeline;
-  readonly #parentElement: Element;
   #keyframes?: KeyframeStyle[];
   #nameElement: HTMLElement;
   readonly #svg: Element;
@@ -62,7 +61,6 @@ export class AnimationUI {
   constructor(animation: AnimationImpl, timeline: AnimationTimeline, parentElement: Element) {
     this.#animationInternal = animation;
     this.#timeline = timeline;
-    this.#parentElement = parentElement;
 
     const keyframesRule = this.#animationInternal.source().keyframesRule();
     if (keyframesRule) {

package/front_end/panels/application/BackForwardCacheStrings.ts

@@ -154,10 +154,6 @@ const UIStrings = {
       * @description Description text for not restored reason BackForwardCacheDisabledForDelegate.
       */
   backForwardCacheDisabledForDelegate: 'Back/forward cache is not supported by delegate.',
-  /**
-      * @description Description text for not restored reason OptInUnloadHeaderNotPresent.
-      */
-  optInUnloadHeaderNotPresent: 'The page has unload handler without the back/forward cache opt-in header.',
   /**
       * @description Description text for not restored reason UnloadHandlerExistsInMainFrame.
       */
@@ -466,7 +462,7 @@ export const NotRestoredReasonDescription = {
   'UserAgentOverrideDiffers': {name: i18nLazyString(UIStrings.userAgentOverrideDiffers)},
   'ForegroundCacheLimit': {name: i18nLazyString(UIStrings.foregroundCacheLimit)},
   'BackForwardCacheDisabledForDelegate': {name: i18nLazyString(UIStrings.backForwardCacheDisabledForDelegate)},
-  'OptInUnloadHeaderNotPresent': {name: i18nLazyString(UIStrings.optInUnloadHeaderNotPresent)},
+  'OptInUnloadHeaderNotPresent': {name: i18nLazyString(UIStrings.unloadHandlerExistsInMainFrame)},
   'UnloadHandlerExistsInMainFrame': {name: i18nLazyString(UIStrings.unloadHandlerExistsInMainFrame)},
   'UnloadHandlerExistsInSubFrame': {name: i18nLazyString(UIStrings.unloadHandlerExistsInSubFrame)},
   'ServiceWorkerUnregistration': {name: i18nLazyString(UIStrings.serviceWorkerUnregistration)},
@@ -541,6 +537,7 @@ export const NotRestoredReasonDescription = {
   'ContentMediaSession': {name: i18nLazyString(UIStrings.contentMediaSession)},
   'ContentMediaSessionService': {name: i18nLazyString(UIStrings.contentMediaSessionService)},
   'ContentMediaPlay': {name: i18nLazyString(UIStrings.contentMediaPlay)},
+  'ContentScreenReader': {name: i18n.i18n.lockedLazyString('ContentScreenReader')},
   'EmbedderPopupBlockerTabHelper': {name: i18n.i18n.lockedLazyString('EmbedderPopupBlockerTabHelper')},
   'EmbedderSafeBrowsingTriggeredPopupBlocker':
       {name: i18n.i18n.lockedLazyString('EmbedderSafeBrowsingTriggeredPopupBlocker')},