chrome-devtools-frontend 1.0.946920 → 1.0.948445

package/scripts/eslint_rules/lib/no_only_eslint_tests.js

@@ -0,0 +1,53 @@
+// Copyright 2021 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+module.exports = {
+  meta: {
+    type: 'problem',
+
+    docs: {
+      description: 'Usage of only: true in ESLint tests',
+      category: 'Possible Errors',
+    },
+    fixable: 'code',
+    messages: {noOnlyInESLintTest: 'You cannot use only: true in an ESLint test.'},
+    schema: []  // no options
+  },
+  create: function(context) {
+    function checkForOnlyInTestCases(testCaseObjects) {
+      for (const testCase of testCaseObjects) {
+        const onlyKeyProp = testCase.properties.find(prop => {
+          return prop.key.name === 'only';
+        });
+        if (onlyKeyProp) {
+          context.report({
+            node: onlyKeyProp,
+            messageId: 'noOnlyInESLintTest'
+
+          });
+        }
+      }
+    }
+
+    return {
+      // match ruleTester.run('foo', rule, {...})
+      'CallExpression[callee.object.name=\'ruleTester\'][callee.property.name=\'run\']'(node) {
+        // first argument = string name
+        // second argument = rule itself
+        // third argument = the object containing the test cases - what we want!
+        const tests = node.arguments[2];
+        if (!tests) {
+          return;
+        }
+
+        for (const testProperty of tests.properties) {
+          // Iterate over the "valid" and "invalid" rules
+          // Here .value = the array of test cases, and .elements gets us each
+          // object (individual test case) within that array.
+          checkForOnlyInTestCases(testProperty.value.elements);
+        }
+      }
+    };
+  }
+};

package/scripts/eslint_rules/tests/.eslintrc.js

@@ -0,0 +1,14 @@
+// Copyright 2021 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+const path = require('path');
+const rulesDirPlugin = require('eslint-plugin-rulesdir');
+
+rulesDirPlugin.RULES_DIR = path.join(__dirname, '..', 'lib');
+
+module.exports = {
+  'rules': {
+    'rulesdir/no_only_eslint_tests': 2,
+  }
+};

package/scripts/eslint_rules/tests/l10n_filename_matches_test.js

@@ -17,14 +17,17 @@ ruleTester.run('l10n_filename_matches', rule, {
     {
       code: 'const str_ = i18n.i18n.registerUIStrings(\'components/test.ts\', UIStrings);',
       filename: 'front_end/components/test.ts',
+      options: [{rootFrontendDirectory: path.join(__dirname, '..', '..', '..', 'front_end')}]
     },
     {
       code: 'const str_ = i18n.i18n.registerUIStrings(\'components/ModuleUIStrings.js\', UIStrings);',
       filename: 'front_end/components/test.ts',
+      options: [{rootFrontendDirectory: path.join(__dirname, '..', '..', '..', 'front_end')}]
     },
     {
       code: 'const str_ = i18n.i18n.registerUIStrings(\'components/ModuleUIStrings.ts\', UIStrings);',
       filename: 'front_end/components/test.ts',
+      options: [{rootFrontendDirectory: path.join(__dirname, '..', '..', '..', 'front_end')}]
     },
     {
       code: 'const str_ = i18n.i18n.registerUIStrings(\'ModuleUIStrings.ts\', UIStrings);',
@@ -41,6 +44,7 @@ ruleTester.run('l10n_filename_matches', rule, {
     {
       code: 'const str_ = i18n.i18n.registerUIStrings(\'components/foo.ts\', UIStrings);',
       filename: 'front_end/components/test.ts',
+      options: [{rootFrontendDirectory: path.join(__dirname, '..', '..', '..', 'front_end')}],
       errors: [{
         message:
             'First argument to \'registerUIStrings\' call must be \'components/test.ts\' or the ModuleUIStrings.(js|ts)'

package/scripts/eslint_rules/tests/lit_html_no_attribute_quotes_test.js

@@ -0,0 +1,45 @@
+// Copyright 2021 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+'use strict';
+
+const rule = require('../lib/lit_html_no_attribute_quotes.js');
+const ruleTester = new (require('eslint').RuleTester)({
+  parserOptions: {ecmaVersion: 9, sourceType: 'module'},
+  parser: require.resolve('@typescript-eslint/parser'),
+});
+
+ruleTester.run('lit_html_no_attribute_quotes', rule, {
+  valid: [
+    {
+      code: 'LitHtml.html`<p class=${foo}>foo</p>`',
+      filename: 'front_end/components/datagrid.ts',
+    },
+    {
+      code: 'LitHtml.html`<p class=${foo}>"${someOutput}"</p>`',
+      filename: 'front_end/components/datagrid.ts',
+    },
+    {
+      code: 'html`<p class=${foo}>"${someOutput}"</p>`',
+      filename: 'front_end/components/datagrid.ts',
+    },
+    {
+      code: 'html`<p class="my-${fooClassName}">"${someOutput}"</p>`',
+      filename: 'front_end/components/datagrid.ts',
+    },
+  ],
+  invalid: [
+    {
+      code: 'LitHtml.html`<p class="${foo}">foo</p>`',
+      filename: 'front_end/components/datagrid.ts',
+      errors: [{messageId: 'attributeQuotesNotRequired', column: 26, line: 1}],
+      output: 'LitHtml.html`<p class=${foo}>foo</p>`',
+    },
+    {
+      code: 'html`<p class="${foo}">foo</p>`',
+      filename: 'front_end/components/datagrid.ts',
+      errors: [{messageId: 'attributeQuotesNotRequired'}],
+      output: 'html`<p class=${foo}>foo</p>`',
+    },
+  ]
+});

package/scripts/eslint_rules/tests/no_only_eslint_tests_test.js

@@ -0,0 +1,94 @@
+// Copyright 2021 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+const rule = require('../lib/no_only_eslint_tests.js');
+const ruleTester = new (require('eslint').RuleTester)({
+  parserOptions: {ecmaVersion: 9, sourceType: 'module'},
+});
+
+ruleTester.run('no_only_eslint_tests', rule, {
+  valid: [
+    {
+      code: `ruleTester.run('my_eslint_rule', rule, {
+        valid: [{
+          code: 'foo',
+          filename: 'foo.ts',
+        }]
+      })`,
+      filename: 'scripts/eslint_rules/tests/foo_test.js',
+    },
+    {
+      code: `ruleTester.run('my_eslint_rule', rule, {
+        invalid: [{
+          code: 'foo',
+          filename: 'foo.ts',
+        }]
+      })`,
+      filename: 'scripts/eslint_rules/tests/foo_test.js',
+    },
+  ],
+
+  invalid: [
+    {
+      code: `ruleTester.run('my_eslint_rule', rule, {
+        valid: [{
+          only: true,
+          code: 'foo',
+          filename: 'foo.ts',
+        }]
+      })`,
+      filename: 'scripts/eslint_rules/tests/foo_test.js',
+      errors: [{messageId: 'noOnlyInESLintTest'}],
+    },
+    {
+      code: `ruleTester.run('my_eslint_rule', rule, {
+        invalid: [{
+          only: true,
+          code: 'foo',
+          filename: 'foo.ts',
+          errors: [{ messagId: 'foo' }]
+        }]
+      })`,
+      filename: 'scripts/eslint_rules/tests/foo_test.js',
+      errors: [{messageId: 'noOnlyInESLintTest'}],
+    },
+    {
+      code: `ruleTester.run('my_eslint_rule', rule, {
+        valid: [{
+          only: true,
+          code: 'foo',
+          filename: 'foo.ts',
+        }],
+        invalid: [{
+          only: true,
+          code: 'foo',
+          filename: 'foo.ts',
+          errors: [{ messagId: 'foo' }]
+        }]
+      })`,
+      filename: 'scripts/eslint_rules/tests/foo_test.js',
+      errors: [{messageId: 'noOnlyInESLintTest'}, {messageId: 'noOnlyInESLintTest'}],
+    },
+    {
+      code: `ruleTester.run('my_eslint_rule', rule, {
+        valid: [{
+          only: true,
+          code: 'foo',
+          filename: 'foo.ts',
+        }, {
+          code: 'foo',
+          filename: 'foo.ts',
+        }],
+        invalid: [{
+          only: true,
+          code: 'foo',
+          filename: 'foo.ts',
+          errors: [{ messagId: 'foo' }]
+        }]
+      })`,
+      filename: 'scripts/eslint_rules/tests/foo_test.js',
+      errors: [{messageId: 'noOnlyInESLintTest'}, {messageId: 'noOnlyInESLintTest'}],
+    },
+  ]
+});

package/front_end/entrypoints/devtools_app/devtools_app.js

@@ -1,11 +0,0 @@
-// Copyright 2018 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-import '../shell/shell.js';
-import './devtools_app-meta-files.js';
-
-import * as Main from '../main/main.js';
-import * as Startup from '../startup/startup.js';
-
-new Main.MainImpl.MainImpl();
-Startup.RuntimeInstantiator.startApplication('devtools_app');

package/front_end/entrypoints/devtools_app/devtools_app.json

@@ -1,5 +0,0 @@
-{
-  "modules" : [
-    { "name": "panels/lighthouse" }
-  ]
-}

package/front_end/entrypoints/inspector/inspector.json

@@ -1,4 +0,0 @@
-{
-  "modules" : [],
-  "extends": "devtools_app"
-}

package/front_end/entrypoints/js_app/js_app.js

@@ -1,12 +0,0 @@
-// Copyright 2018 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-import '../shell/shell.js';
-import '../../panels/js_profiler/js_profiler-meta.js';
-import './JsMain.js';
-
-import * as Main from '../main/main.js';
-import * as Startup from '../startup/startup.js';
-
-new Main.MainImpl.MainImpl();
-Startup.RuntimeInstantiator.startApplication('js_app');

package/front_end/entrypoints/js_app/js_app.json

@@ -1,3 +0,0 @@
-{
-  "modules" : []
-}

package/front_end/entrypoints/ndb_app/ndb_app.json

@@ -1,4 +0,0 @@
-{
-  "modules" : [
-  ]
-}

package/front_end/entrypoints/startup/RuntimeInstantiator.ts

@@ -1,95 +0,0 @@
-/*
- * Copyright (C) 2014 Google Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions are
- * met:
- *
- *     * Redistributions of source code must retain the above copyright
- * notice, this list of conditions and the following disclaimer.
- *     * Redistributions in binary form must reproduce the above
- * copyright notice, this list of conditions and the following disclaimer
- * in the documentation and/or other materials provided with the
- * distribution.
- *     * Neither the name of Google Inc. nor the names of its
- * contributors may be used to endorse or promote products derived from
- * this software without specific prior written permission.
- *
- * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
- * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
- * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
- * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
- * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
- * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
- * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-import '../../core/root/root-legacy.js';
-
-import * as RootModule from '../../core/root/root.js';
-
-// Legacy runtime namespace definitions
-// @ts-ignore
-self.Runtime = self.Runtime || {};
-// @ts-ignore
-Runtime = Runtime || {};
-// The following two variables are initialized in `build_release_applications`
-// @ts-ignore
-Root.allDescriptors = Root.allDescriptors || [];
-// @ts-ignore
-Root.applicationDescriptor = Root.applicationDescriptor || undefined;
-
-export async function startApplication(_appName: string): Promise<void> {
-  console.timeStamp('Root.Runtime.startApplication');
-
-  const allDescriptorsByName: {
-    [x: string]: RootModule.Runtime.ModuleDescriptor,
-  } = {};
-  // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration
-  // @ts-ignore
-  for (let i = 0; i < Root.allDescriptors.length; ++i) {
-    // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration
-    // @ts-ignore
-    const d = Root.allDescriptors[i];
-    allDescriptorsByName[d['name']] = d;
-  }
-
-  // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration
-  // @ts-ignore
-  const configuration = Root.applicationDescriptor.modules;
-  const moduleDescriptors = [];
-  const coreModuleNames = [];
-  for (let i = 0; i < configuration.length; ++i) {
-    const descriptor = configuration[i];
-    const name = descriptor['name'];
-    moduleDescriptors.push(allDescriptorsByName[name]);
-    if (descriptor['type'] === 'autostart') {
-      coreModuleNames.push(name);
-    }
-  }
-
-  for (let i = 0; i < moduleDescriptors.length; ++i) {
-    moduleDescriptors[i].name = configuration[i]['name'];
-    moduleDescriptors[i].condition = configuration[i]['condition'];
-  }
-  const runtimeInstance = RootModule.Runtime.Runtime.instance({forceNew: true, moduleDescriptors});
-  // @ts-ignore Exposed for legacy layout tests
-  self.runtime = runtimeInstance;
-  if (coreModuleNames) {
-    await runtimeInstance.loadAutoStartModules(coreModuleNames);
-  }
-  RootModule.Runtime.appStartedPromiseCallback();
-}
-
-export async function startWorker(appName: string): Promise<void> {
-  return startApplication(appName).then(sendWorkerReady);
-
-  function sendWorkerReady(): void {
-    // @ts-ignore
-    self.postMessage('workerReady');
-  }
-}

package/front_end/entrypoints/startup/startup.ts

@@ -1,9 +0,0 @@
-// Copyright 2019 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-import * as RuntimeInstantiator from './RuntimeInstantiator.js';
-
-export {
-  RuntimeInstantiator,
-};

package/front_end/entrypoints/worker_app/worker_app.json

@@ -1,3 +0,0 @@
-{
-  "modules" : []
-}

package/front_end/panels/lighthouse/module.json

@@ -1,6 +0,0 @@
-{
-  "resources": [
-    "../../third_party/lighthouse/report-assets/standalone-template.html",
-    "../../third_party/lighthouse/report-assets/report.js"
-  ]
-}

package/front_end/third_party/lighthouse/report-assets/report.d.ts

@@ -1 +0,0 @@
-export {}