chrome-devtools-frontend 1.0.945677 → 1.0.947377

package/front_end/core/sdk/CSSProperty.ts

@@ -6,8 +6,8 @@ import * as TextUtils from '../../models/text_utils/text_utils.js';
 import * as Common from '../common/common.js';
 import * as HostModule from '../host/host.js';
 import * as Platform from '../platform/platform.js';
+import * as Root from '../root/root.js';
 import type * as Protocol from '../../generated/protocol.js';
-import type * as CodeMirrorModule from '../../third_party/codemirror/codemirror-legacy.js'; // eslint-disable-line @typescript-eslint/no-unused-vars
 
 import {cssMetadata, GridAreaRowRegex} from './CSSMetadata.js';
 import type {Edit} from './CSSModel.js';
@@ -27,7 +27,6 @@ export class CSSProperty {
   #active: boolean;
   #nameRangeInternal: TextUtils.TextRange.TextRange|null;
   #valueRangeInternal: TextUtils.TextRange.TextRange|null;
-  readonly #invalidProperty: string|null;
   #invalidString?: Common.UIString.LocalizedString;
 
   constructor(
@@ -46,7 +45,6 @@ export class CSSProperty {
     this.#active = true;
     this.#nameRangeInternal = null;
     this.#valueRangeInternal = null;
-    this.#invalidProperty = null;
   }
 
   static parsePayload(ownerStyle: CSSStyleDeclaration, index: number, payload: Protocol.CSS.CSSProperty): CSSProperty {
@@ -178,7 +176,7 @@ export class CSSProperty {
 
   static formatStyle(
       styleText: string, indentation: string, endIndentation: string,
-      tokenizerFactory: TextUtils.TextUtils.TokenizerFactory, codeMirrorMode?: CodeMirror.Mode<unknown>): string {
+      tokenizerFactory: TextUtils.TextUtils.TokenizerFactory): string {
     const doubleIndent = indentation.substring(endIndentation.length) + indentation;
     if (indentation) {
       indentation = '\n' + indentation;
@@ -188,7 +186,7 @@ export class CSSProperty {
     let propertyText = '';
     let insideProperty = false;
     let needsSemi = false;
-    const tokenize = tokenizerFactory.createTokenizer('text/css', codeMirrorMode);
+    const tokenize = tokenizerFactory.createTokenizer('text/css');
 
     tokenize('*{' + styleText + '}', processToken);
     if (insideProperty) {
@@ -199,10 +197,10 @@ export class CSSProperty {
 
     function processToken(token: string, tokenType: string|null, _column: number, _newColumn: number): void {
       if (!insideProperty) {
-        const disabledProperty = tokenType && tokenType.includes('css-comment') && isDisabledProperty(token);
+        const disabledProperty = tokenType && tokenType.includes('comment') && isDisabledProperty(token);
         const isPropertyStart = tokenType &&
-            (tokenType.includes('css-string') || tokenType.includes('css-meta') || tokenType.includes('css-property') ||
-             tokenType.includes('css-variable-2'));
+            (tokenType.includes('string') || tokenType.includes('meta') || tokenType.includes('property') ||
+             tokenType.includes('variable-2'));
         if (disabledProperty) {
           result = result.trimRight() + indentation + token;
         } else if (isPropertyStart) {
@@ -210,7 +208,7 @@ export class CSSProperty {
           propertyText = token;
         } else if (token !== ';' || needsSemi) {
           result += token;
-          if (token.trim() && !(tokenType && tokenType.includes('css-comment'))) {
+          if (token.trim() && !(tokenType && tokenType.includes('comment'))) {
             needsSemi = token !== ';';
           }
         }
@@ -227,11 +225,18 @@ export class CSSProperty {
         // implementation takes special care to restore a single
         // whitespace token in this edge case. https://crbug.com/1071296
         const trimmedPropertyText = propertyText.trim();
-        result = result.trimRight() + indentation + trimmedPropertyText +
-            (trimmedPropertyText.endsWith(':') ? ' ' : '') + ';';
+        result =
+            result.trimRight() + indentation + trimmedPropertyText + (trimmedPropertyText.endsWith(':') ? ' ' : '');
         needsSemi = false;
         insideProperty = false;
         propertyName = '';
+        if (Root.Runtime.experiments.isEnabled('preciseChanges')) {
+          result += token;
+          return;
+        }
+        // We preserve the legacy behavior to always add semicolon to
+        // declarations regardless of its original text.
+        result += ';';
         if (token === '}') {
           result += '}';
         }

package/front_end/core/sdk/CSSRule.ts

@@ -203,11 +203,9 @@ export class CSSStyleRule extends CSSRule {
 }
 
 export class CSSKeyframesRule {
-  readonly #cssModel: CSSModel;
   readonly #animationName: CSSValue;
   readonly #keyframesInternal: CSSKeyframeRule[];
   constructor(cssModel: CSSModel, payload: Protocol.CSS.CSSKeyframesRule) {
-    this.#cssModel = cssModel;
     this.#animationName = new CSSValue(payload.animationName);
     this.#keyframesInternal = payload.keyframes.map(keyframeRule => new CSSKeyframeRule(cssModel, keyframeRule));
   }

package/front_end/core/sdk/Cookie.ts

@@ -269,14 +269,10 @@ export enum Attributes {
  * included to make it clear which site under Application>Cookies should be opened when revealing a `CookieReference`.
  */
 export class CookieReference {
-  readonly #name: string;
   readonly #domainInternal: string;
-  readonly #path: string;
   readonly #contextUrlInternal: string|undefined;
-  constructor(name: string, domain: string, path: string, contextUrl: string|undefined) {
-    this.#name = name;
+  constructor(_name: string, domain: string, _path: string, contextUrl: string|undefined) {
     this.#domainInternal = domain;
-    this.#path = path;
     this.#contextUrlInternal = contextUrl;
   }
 

package/front_end/core/sdk/EmulationModel.ts

@@ -15,7 +15,6 @@ import {SDKModel} from './SDKModel.js';
 
 export class EmulationModel extends SDKModel<void> {
   readonly #emulationAgent: ProtocolProxyApi.EmulationApi;
-  readonly #pageAgent: ProtocolProxyApi.PageApi;
   readonly #deviceOrientationAgent: ProtocolProxyApi.DeviceOrientationApi;
   #cssModel: CSSModel|null;
   readonly #overlayModelInternal: OverlayModel|null;
@@ -31,7 +30,6 @@ export class EmulationModel extends SDKModel<void> {
   constructor(target: Target) {
     super(target);
     this.#emulationAgent = target.emulationAgent();
-    this.#pageAgent = target.pageAgent();
     this.#deviceOrientationAgent = target.deviceOrientationAgent();
     this.#cssModel = target.model(CSSModel);
     this.#overlayModelInternal = target.model(OverlayModel);

package/front_end/core/sdk/HeapProfilerModel.ts

@@ -15,7 +15,6 @@ import {SDKModel} from './SDKModel.js';
 export class HeapProfilerModel extends SDKModel<EventTypes> {
   #enabled: boolean;
   readonly #heapProfilerAgent: ProtocolProxyApi.HeapProfilerApi;
-  readonly #memoryAgent: ProtocolProxyApi.MemoryApi;
   readonly #runtimeModelInternal: RuntimeModel;
   #samplingProfilerDepth: number;
 
@@ -24,7 +23,6 @@ export class HeapProfilerModel extends SDKModel<EventTypes> {
     target.registerHeapProfilerDispatcher(new HeapProfilerDispatcher(this));
     this.#enabled = false;
     this.#heapProfilerAgent = target.heapProfilerAgent();
-    this.#memoryAgent = target.memoryAgent();
     this.#runtimeModelInternal = (target.model(RuntimeModel) as RuntimeModel);
     this.#samplingProfilerDepth = 0;
   }

package/front_end/core/sdk/NetworkManager.ts

@@ -1575,7 +1575,6 @@ class ExtraInfoBuilder {
   #requestExtraInfos: (ExtraRequestInfo|null)[];
   #responseExtraInfos: (ExtraResponseInfo|null)[];
   #finishedInternal: boolean;
-  #hasExtraInfo: boolean;
   #webBundleInfo: WebBundleInfo|null;
   #webBundleInnerRequestInfo: WebBundleInnerRequestInfo|null;
 
@@ -1584,7 +1583,6 @@ class ExtraInfoBuilder {
     this.#requestExtraInfos = [];
     this.#responseExtraInfos = [];
     this.#finishedInternal = false;
-    this.#hasExtraInfo = false;
     this.#webBundleInfo = null;
     this.#webBundleInnerRequestInfo = null;
   }
@@ -1595,7 +1593,6 @@ class ExtraInfoBuilder {
   }
 
   addRequestExtraInfo(info: ExtraRequestInfo): void {
-    this.#hasExtraInfo = true;
     this.#requestExtraInfos.push(info);
     this.sync(this.#requestExtraInfos.length - 1);
   }

package/front_end/core/sdk/Resource.ts

@@ -52,7 +52,6 @@ export class Resource implements TextUtils.ContentProvider.ContentProvider {
   #lastModifiedInternal: Date|null;
   readonly #contentSizeInternal: number|null;
   #contentInternal!: string|null;
-  #contentLoadError!: string|null;
   #contentEncodedInternal!: boolean;
   readonly #pendingContentCallbacks: ((arg0: Object|null) => void)[];
   #parsedURLInternal?: Common.ParsedURL.ParsedURL;
@@ -245,12 +244,10 @@ export class Resource implements TextUtils.ContentProvider.ContentProvider {
           {frameId: this.frameId as Protocol.Page.FrameId, url: this.url});
       const protocolError = response.getError();
       if (protocolError) {
-        this.#contentLoadError = protocolError;
         this.#contentInternal = null;
         loadResult = {content: null, error: protocolError, isEncoded: false};
       } else {
         this.#contentInternal = response.content;
-        this.#contentLoadError = null;
         loadResult = {content: response.content, isEncoded: response.base64Encoded};
       }
       this.#contentEncodedInternal = response.base64Encoded;

package/front_end/core/sdk/ResourceTreeModel.ts

@@ -604,7 +604,6 @@ export class ResourceTreeFrame {
   #urlInternal: string;
   #domainAndRegistryInternal: string;
   #securityOriginInternal: string|null;
-  #mimeType: string|null;
   #unreachableUrlInternal: string;
   #adFrameStatusInternal?: Protocol.Page.AdFrameStatus;
   #secureContextType: Protocol.Page.SecureContextType|null;
@@ -632,7 +631,6 @@ export class ResourceTreeFrame {
     this.#urlInternal = (payload && payload.url) || '';
     this.#domainAndRegistryInternal = (payload && payload.domainAndRegistry) || '';
     this.#securityOriginInternal = payload && payload.securityOrigin;
-    this.#mimeType = payload && payload.mimeType;
     this.#unreachableUrlInternal = (payload && payload.unreachableUrl) || '';
     this.#adFrameStatusInternal = payload?.adFrameStatus;
     this.#secureContextType = payload && payload.secureContextType;
@@ -685,7 +683,6 @@ export class ResourceTreeFrame {
     this.#urlInternal = framePayload.url;
     this.#domainAndRegistryInternal = framePayload.domainAndRegistry;
     this.#securityOriginInternal = framePayload.securityOrigin;
-    this.#mimeType = framePayload.mimeType;
     this.#unreachableUrlInternal = framePayload.unreachableUrl || '';
     this.#adFrameStatusInternal = framePayload?.adFrameStatus;
     this.#secureContextType = framePayload.secureContextType;

package/front_end/core/sdk/ServiceWorkerManager.ts

@@ -98,7 +98,6 @@ const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 const i18nLazyString = i18n.i18n.getLazilyComputedLocalizedString.bind(undefined, str_);
 
 export class ServiceWorkerManager extends SDKModel<EventTypes> {
-  readonly #lastAnonymousTargetId: number;
   readonly #agent: ProtocolProxyApi.ServiceWorkerApi;
   readonly #registrationsInternal: Map<string, ServiceWorkerRegistration>;
   #enabled: boolean;
@@ -111,7 +110,6 @@ export class ServiceWorkerManager extends SDKModel<EventTypes> {
   constructor(target: Target) {
     super(target);
     target.registerServiceWorkerDispatcher(new ServiceWorkerDispatcher(this));
-    this.#lastAnonymousTargetId = 0;
     this.#agent = target.serviceWorkerAgent();
     this.#registrationsInternal = new Map();
     this.#enabled = false;

package/front_end/core/sdk/sdk-meta.ts

@@ -306,8 +306,8 @@ const UIStrings = {
   */
   enableCache: 'Enable cache',
   /**
-   * @description Title of a setting under the Network category that can be invoked through the Command Menu
-   */
+  * @description Title of a setting under the Network category that can be invoked through the Command Menu
+  */
   disableCache: 'Disable cache (while DevTools is open)',
   /**
   * @description The name of a checkbox setting in the Rendering tool. This setting
@@ -315,13 +315,25 @@ const UIStrings = {
   */
   emulateAutoDarkMode: 'Emulate auto dark mode',
   /**
-  *@description Title of a setting for emulating enabled auto dark mode.
+  * @description Title of a setting for enabling auto dark mode.
+  */
+  enableEmulateAutoDarkMode: 'Enable auto dark mode',
+  /**
+  * @description Text to emulate enabled auto dark mode.
   */
   enabledDarkMode: 'Enable',
   /**
-   * @description Title of a setting for emulating disabled auto dark mode.
-   */
+  * @description Title of a setting for disabling auto dark mode.
+  */
+  disableEmulateAutoDarkMode: 'Disable auto dark mode',
+  /**
+  * @description Text to emulate disabled auto dark mode.
+  */
   disabledDarkMode: 'Disable',
+  /**
+  * @description Title of a setting for disabling dark mode emulation.
+  */
+  doNotEmulateDarkMode: 'Do not emulate auto dark mode',
 };
 const str_ = i18n.i18n.registerUIStrings('core/sdk/sdk-meta.ts', UIStrings);
 const i18nLazyString = i18n.i18n.getLazilyComputedLocalizedString.bind(undefined, str_);
@@ -1042,17 +1054,17 @@ Common.Settings.registerSettingExtension({
   defaultValue: 'default',
   options: [
     {
-      title: i18nLazyString(UIStrings.emulateAutoDarkMode),
+      title: i18nLazyString(UIStrings.doNotEmulateDarkMode),
       text: i18nLazyString(UIStrings.noEmulation),
       value: 'default',
     },
     {
-      title: i18nLazyString(UIStrings.emulateAutoDarkMode),
+      title: i18nLazyString(UIStrings.enableEmulateAutoDarkMode),
       text: i18nLazyString(UIStrings.enabledDarkMode),
       value: 'enabled',
     },
     {
-      title: i18nLazyString(UIStrings.emulateAutoDarkMode),
+      title: i18nLazyString(UIStrings.disableEmulateAutoDarkMode),
       text: i18nLazyString(UIStrings.disabledDarkMode),
       value: 'disabled',
     },

package/front_end/devtools_compatibility.js

@@ -389,7 +389,6 @@
     ExperimentEnabledAtLaunch: 'DevTools.ExperimentEnabledAtLaunch',
     ExperimentEnabled: 'DevTools.ExperimentEnabled',
     ExperimentDisabled: 'DevTools.ExperimentDisabled',
-    CssEditorOpened: 'DevTools.CssEditorOpened',
     DeveloperResourceLoaded: 'DevTools.DeveloperResourceLoaded',
     DeveloperResourceScheme: 'DevTools.DeveloperResourceScheme',
     LinearMemoryInspectorRevealedFrom: 'DevTools.LinearMemoryInspector.RevealedFrom',
@@ -401,6 +400,7 @@
     RecordingReplayFinished: 'DevTools.RecordingReplayFinished',
     RecordingReplayStarted: 'DevTools.RecordingReplayStarted',
     RecordingToggled: 'DevTools.RecordingToggled',
+    SyncSetting: 'DevTools.SyncSetting',
   };
 
   /**
@@ -1490,13 +1490,6 @@
       styleRules.push('* { min-width: 0; min-height: 0; }');
     }
 
-    if (majorVersion <= 51) {
-      // Support for quirky border-image behavior (<M51), see:
-      // https://bugs.chromium.org/p/chromium/issues/detail?id=559258
-      styleRules.push('.cm-breakpoint .CodeMirror-linenumber { border-style: solid !important; }');
-      styleRules.push(
-          '.cm-breakpoint.cm-breakpoint-conditional .CodeMirror-linenumber { border-style: solid !important; }');
-    }
     if (majorVersion <= 71) {
       styleRules.push(
           '.coverage-toolbar-container, .animation-timeline-toolbar-container, .computed-properties { flex-basis: auto; }');

package/front_end/entrypoints/devtools_app/devtools_app.js

@@ -3,6 +3,9 @@
 // found in the LICENSE file.
 import '../shell/shell.js';
 import './devtools_app-meta-files.js';
+
+import * as Main from '../main/main.js';
 import * as Startup from '../startup/startup.js';
 
+new Main.MainImpl.MainImpl();
 Startup.RuntimeInstantiator.startApplication('devtools_app');

package/front_end/entrypoints/devtools_app/devtools_app.json

@@ -1,6 +1,4 @@
 {
   "modules" : [
-    { "name": "panels/lighthouse" }
-  ],
-  "extends": "shell"
+  ]
 }

package/front_end/entrypoints/formatter_worker/CSSFormatter.ts

@@ -86,9 +86,7 @@ export class CSSFormatter {
     if (startLine !== this.lastLine) {
       this.state.eatWhitespace = true;
     }
-    // The css- prefix is optional, as we override that in the tokenizer defined
-    // in CodeMirrorTextEditor.js. In a worker context, we don't use the prefix.
-    if (type && (/^(css-)?property/.test(type) || /^(css-)?variable-2/.test(type)) && !this.state.inPropertyValue) {
+    if (type && (/^property/.test(type) || /^variable-2/.test(type)) && !this.state.inPropertyValue) {
       this.state.seenProperty = true;
     }
     this.lastLine = startLine;

package/front_end/entrypoints/formatter_worker/FormatterActions.ts

@@ -9,7 +9,5 @@ export const enum FormatterActions {
   JAVASCRIPT_OUTLINE = 'javaScriptOutline',
   JAVASCRIPT_IDENTIFIERS = 'javaScriptIdentifiers',
   EVALUATE_JAVASCRIPT_SUBSTRING = 'evaluatableJavaScriptSubstring',
-  FIND_LAST_EXPRESSION = 'findLastExpression',
-  FIND_LAST_FUNCTION_CALL = 'findLastFunctionCall',
   ARGUMENTS_LIST = 'argumentsList',
 }

package/front_end/entrypoints/formatter_worker/FormatterWorker.ts

@@ -230,55 +230,6 @@ export function format(
   return result;
 }
 
-export function findLastFunctionCall(content: string): {
-  baseExpression: string,
-  receiver: string,
-  argumentIndex: number,
-  functionName: string,
-}|null {
-  if (content.length > 10000) {
-    return null;
-  }
-  try {
-    const tokenizer = Acorn.tokenizer(content, {ecmaVersion: ECMA_VERSION});
-    while (tokenizer.getToken().type !== Acorn.tokTypes.eof) {
-    }
-  } catch (e) {
-    return null;
-  }
-
-  const suffix = '000)';
-  const base = _lastCompleteExpression(content, suffix, new Set(['CallExpression', 'NewExpression']));
-  if (!base) {
-    return null;
-  }
-  if (base.baseNode.type !== 'CallExpression' && base.baseNode.type !== 'NewExpression') {
-    return null;
-  }
-  const callee = base.baseNode['callee'];
-
-  let functionName = '';
-  const functionProperty = callee.type === 'Identifier' ? callee : (callee as Acorn.ESTree.MemberExpression).property;
-  if (functionProperty) {
-    if (functionProperty.type === 'Identifier') {
-      functionName = functionProperty.name;
-    } else if (functionProperty.type === 'Literal') {
-      functionName = (functionProperty.value as string);
-    }
-  }
-
-  const argumentIndex = base.baseNode['arguments'].length - 1;
-  const baseExpression =
-      `(${base.baseExpression.substring(callee.start - base.baseNode.start, callee.end - base.baseNode.start)})`;
-  let receiver = '(function(){return this})()';
-  if (callee.type === 'MemberExpression') {
-    const receiverBase = callee['object'];
-    receiver =
-        base.baseExpression.substring(receiverBase.start - base.baseNode.start, receiverBase.end - base.baseNode.start);
-  }
-  return {baseExpression, receiver, argumentIndex, functionName};
-}
-
 export function argumentsList(content: string): string[] {
   if (content.length > 10000) {
     return [];
@@ -349,77 +300,6 @@ export function argumentsList(content: string): string[] {
   }
 }
 
-export function findLastExpression(content: string): string|null {
-  if (content.length > 10000) {
-    return null;
-  }
-  try {
-    const tokenizer = Acorn.tokenizer(content, {ecmaVersion: ECMA_VERSION});
-    while (tokenizer.getToken().type !== Acorn.tokTypes.eof) {
-    }
-  } catch (e) {
-    return null;
-  }
-
-  const suffix = '.DEVTOOLS';
-  try {
-    Acorn.parse(content + suffix, {ecmaVersion: ECMA_VERSION});
-  } catch (parseError) {
-    // If this is an invalid location for a '.', don't attempt to give autocomplete
-    if (parseError.message.startsWith('Unexpected token') && parseError.pos === content.length) {
-      return null;
-    }
-  }
-  const base = _lastCompleteExpression(content, suffix, new Set(['MemberExpression', 'Identifier']));
-  if (base) {
-    return base.baseExpression;
-  }
-  return null;
-}
-
-// TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration
-// eslint-disable-next-line @typescript-eslint/naming-convention
-export function _lastCompleteExpression(content: string, suffix: string, types: Set<string>): {
-  baseNode: Acorn.ESTree.Node,
-  baseExpression: string,
-}|null {
-  let ast: Acorn.ESTree.Node|null = null;
-  let parsedContent = '';
-  for (let i = 0; i < content.length; i++) {
-    try {
-      // Wrap content in paren to successfully parse object literals
-      parsedContent = content[i] === '{' ? `(${content.substring(i)})${suffix}` : `${content.substring(i)}${suffix}`;
-      ast = (Acorn.parse(parsedContent, {ecmaVersion: ECMA_VERSION}) as Acorn.ESTree.Node);
-      break;
-    } catch (e) {
-    }
-  }
-  if (!ast) {
-    return null;
-  }
-  const astEnd = ast.end;
-  let baseNode: Acorn.ESTree.Node|null = null;
-  const walker = new ESTreeWalker(node => {
-    if (baseNode || node.end < astEnd) {
-      return ESTreeWalker.SkipSubtree;
-    }
-    if (types.has(node.type)) {
-      baseNode = node;
-    }
-    return;
-  });
-  walker.walk(ast);
-  if (!baseNode) {
-    return null;
-  }
-  let baseExpression =
-      parsedContent.substring((baseNode as Acorn.ESTree.Node).start, parsedContent.length - suffix.length);
-  if (baseExpression.startsWith('{')) {
-    baseExpression = `(${baseExpression})`;
-  }
-  return {baseNode, baseExpression};
-}
-
 (function disableLoggingForTest(): void {
   if (Root.Runtime.Runtime.queryParam('test')) {
     console.error = (): undefined => undefined;

package/front_end/entrypoints/formatter_worker/formatter_worker-entrypoint.ts

@@ -2,12 +2,8 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-import '../../third_party/codemirror/package/addon/runmode/runmode-standalone.js';
-import '../../third_party/codemirror/package/mode/css/css.js';
-import '../../third_party/codemirror/package/mode/xml/xml.js';
-import '../../third_party/codemirror/package/mode/javascript/javascript.js';
-
 import * as Platform from '../../core/platform/platform.js';
+
 import * as FormatterWorker from './formatter_worker.js';
 
 import {FormatterActions} from './FormatterActions.js';
@@ -38,12 +34,6 @@ self.onmessage = function(event: MessageEvent): void {
     case FormatterActions.EVALUATE_JAVASCRIPT_SUBSTRING:
       self.postMessage(FormatterWorker.FormatterWorker.evaluatableJavaScriptSubstring(params.content));
       break;
-    case FormatterActions.FIND_LAST_EXPRESSION:
-      self.postMessage(FormatterWorker.FormatterWorker.findLastExpression(params.content));
-      break;
-    case FormatterActions.FIND_LAST_FUNCTION_CALL:
-      self.postMessage(FormatterWorker.FormatterWorker.findLastFunctionCall(params.content));
-      break;
     case FormatterActions.ARGUMENTS_LIST:
       self.postMessage(FormatterWorker.FormatterWorker.argumentsList(params.content));
       break;

package/front_end/entrypoints/formatter_worker/formatter_worker.ts

@@ -2,6 +2,11 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+import '../../third_party/codemirror/package/addon/runmode/runmode-standalone.js';
+import '../../third_party/codemirror/package/mode/css/css.js';
+import '../../third_party/codemirror/package/mode/xml/xml.js';
+import '../../third_party/codemirror/package/mode/javascript/javascript.js';
+
 import * as CSSFormatter from './CSSFormatter.js';
 import * as CSSRuleParser from './CSSRuleParser.js';
 import * as FormattedContentBuilder from './FormattedContentBuilder.js';

package/front_end/entrypoints/inspector/{inspector.js → inspector.ts}

@@ -3,6 +3,3 @@
 // found in the LICENSE file.
 import '../devtools_app/devtools_app.js';
 import '../../panels/screencast/screencast-meta.js';
-import * as Startup from '../startup/startup.js';
-
-Startup.RuntimeInstantiator.startApplication('inspector');

package/front_end/entrypoints/js_app/js_app.js

@@ -4,6 +4,9 @@
 import '../shell/shell.js';
 import '../../panels/js_profiler/js_profiler-meta.js';
 import './JsMain.js';
+
+import * as Main from '../main/main.js';
 import * as Startup from '../startup/startup.js';
 
+new Main.MainImpl.MainImpl();
 Startup.RuntimeInstantiator.startApplication('js_app');

package/front_end/entrypoints/js_app/js_app.json

@@ -1,4 +1,3 @@
 {
-  "modules" : [],
-  "extends": "shell"
+  "modules" : []
 }

package/front_end/entrypoints/main/MainImpl.ts

@@ -299,9 +299,6 @@ export class MainImpl {
         'keyboardShortcutEditor', 'Enable keyboard shortcut editor', true,
         'https://developer.chrome.com/blog/new-in-devtools-88/#keyboard-shortcuts');
 
-    // Back/forward cache
-    Root.Runtime.experiments.register('bfcacheDebugging', 'Enable back/forward cache debugging support');
-
     // Timeline
     Root.Runtime.experiments.register('timelineEventInitiators', 'Timeline: event initiators');
     Root.Runtime.experiments.register('timelineInvalidationTracking', 'Timeline: invalidation tracking', true);
@@ -371,7 +368,6 @@ export class MainImpl {
     Root.Runtime.experiments.enableExperimentsByDefault([
       'sourceOrderViewer',
       'hideIssuesFeature',
-      'bfcacheDebugging',
       'cssTypeComponentLength',
       'preciseChanges',
       Root.Runtime.ExperimentName.SYNC_SETTINGS,
@@ -1011,5 +1007,3 @@ export class ReloadActionDelegate implements UI.ActionRegistration.ActionDelegat
     return false;
   }
 }
-
-new MainImpl();

package/front_end/entrypoints/ndb_app/ndb_app.js

@@ -2,6 +2,9 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 import '../shell/shell.js';
+
+import * as Main from '../main/main.js';
 import * as Startup from '../startup/startup.js';
 
+new Main.MainImpl.MainImpl();
 Startup.RuntimeInstantiator.startApplication('ndb_app');

package/front_end/entrypoints/ndb_app/ndb_app.json

@@ -1,5 +1,4 @@
 {
   "modules" : [
-  ],
-  "extends": "shell"
+  ]
 }

package/front_end/entrypoints/{node_main → node_app}/NodeConnectionsPanel.ts

@@ -32,7 +32,7 @@ const UIStrings = {
   */
   networkAddressEgLocalhost: 'Network address (e.g. localhost:9229)',
 };
-const str_ = i18n.i18n.registerUIStrings('entrypoints/node_main/NodeConnectionsPanel.ts', UIStrings);
+const str_ = i18n.i18n.registerUIStrings('entrypoints/node_app/NodeConnectionsPanel.ts', UIStrings);
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 
 let nodeConnectionsPanelInstance: NodeConnectionsPanel;

package/front_end/entrypoints/{node_main → node_app}/NodeMain.ts

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-import * as Common from '../../core/common/common.js';
+import type * as Common from '../../core/common/common.js';
 import * as Host from '../../core/host/host.js';
 import * as i18n from '../../core/i18n/i18n.js';
 import * as Components from '../../ui/legacy/components/utils/utils.js';
@@ -23,7 +23,7 @@ const UIStrings = {
   */
   nodejsS: 'Node.js: {PH1}',
 };
-const str_ = i18n.i18n.registerUIStrings('entrypoints/node_main/NodeMain.ts', UIStrings);
+const str_ = i18n.i18n.registerUIStrings('entrypoints/node_app/NodeMain.ts', UIStrings);
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 let nodeMainImplInstance: NodeMainImpl;
 
@@ -45,8 +45,6 @@ export class NodeMainImpl implements Common.Runnable.Runnable {
   }
 }
 
-Common.Runnable.registerEarlyInitializationRunnable(NodeMainImpl.instance);
-
 export class NodeChildTargetManager extends SDK.SDKModel.SDKModel<void> implements ProtocolProxyApi.TargetDispatcher {
   private readonly targetManager: SDK.TargetManager.TargetManager;
   private readonly parentTarget: SDK.Target.Target;