chrome-devtools-frontend 1.0.943986 → 1.0.944427

package/front_end/panels/elements/components/AccessibilityTreeNode.ts

@@ -4,6 +4,7 @@
 
 import * as i18n from '../../../core/i18n/i18n.js';
 import * as Platform from '../../../core/platform/platform.js';
+import * as Protocol from '../../../generated/protocol.js';
 
 import * as ComponentHelpers from '../../../ui/components/helpers/helpers.js';
 import * as Coordinator from '../../../ui/components/render_coordinator/render_coordinator.js';
@@ -31,10 +32,23 @@ function truncateTextIfNeeded(text: string): string {
   return text;
 }
 
+function isPrintable(valueType: Protocol.Accessibility.AXValueType): boolean {
+  switch (valueType) {
+    case Protocol.Accessibility.AXValueType.Boolean:
+    case Protocol.Accessibility.AXValueType.BooleanOrUndefined:
+    case Protocol.Accessibility.AXValueType.String:
+    case Protocol.Accessibility.AXValueType.Number:
+      return true;
+    default:
+      return false;
+  }
+}
+
 export interface AccessibilityTreeNodeData {
   ignored: boolean;
   name: string;
   role: string;
+  properties: Protocol.Accessibility.AXProperty[];
 }
 
 export class AccessibilityTreeNode extends HTMLElement {
@@ -44,11 +58,13 @@ export class AccessibilityTreeNode extends HTMLElement {
   private ignored = true;
   private name = '';
   private role = '';
+  private properties: Protocol.Accessibility.AXProperty[] = [];
 
   set data(data: AccessibilityTreeNodeData) {
     this.ignored = data.ignored;
     this.name = data.name;
     this.role = data.role;
+    this.properties = data.properties;
     this.render();
   }
 
@@ -57,12 +73,20 @@ export class AccessibilityTreeNode extends HTMLElement {
   }
 
   private async render(): Promise<void> {
+    const role = LitHtml.html`<span class='role-value'>${truncateTextIfNeeded(this.role)}</span>`;
+    const name = LitHtml.html`"<span class='attribute-value'>${this.name}</span>"`;
+    const properties = this.properties.map(
+        ({name, value}) => isPrintable(value.type) ?
+            LitHtml.html`&nbsp<span class='attribute-name'>${name}</span>:&nbsp<span class='attribute-value'>${
+                value.value}</span>` :
+            LitHtml.nothing);
+
     await Coordinator.RenderCoordinator.RenderCoordinator.instance().write('Accessibility node render', () => {
       // clang-format off
       LitHtml.render(
-        LitHtml.html`${this.ignored?
-          LitHtml.html`<span>${i18nString(UIStrings.ignored)}</span>`:
-          LitHtml.html`<span class='role-value'>${truncateTextIfNeeded(this.role)}</span>&nbsp"<span class='attribute-value'>${this.name}</span>"`}`,
+        this.ignored ?
+          LitHtml.html`<span>${i18nString(UIStrings.ignored)}</span>` :
+          LitHtml.html`${role}&nbsp${name}${properties}`,
         this.shadow,
         {host: this});
       // clang-format on

package/front_end/panels/network/NetworkDataGridNode.ts

@@ -246,6 +246,7 @@ const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 // TODO(crbug.com/1167717): Make this a const enum again
 // eslint-disable-next-line rulesdir/const_enum
 export enum Events {
+  // RequestSelected might fire twice for the same "activation"
   RequestSelected = 'RequestSelected',
   RequestActivated = 'RequestActivated',
 }
@@ -1007,7 +1008,10 @@ export class NetworkRequestNode extends NetworkNode {
       cell.style.setProperty('padding-left', leftPadding);
       this.nameCell = cell;
       cell.addEventListener('dblclick', this.openInNewTab.bind(this), false);
-      cell.addEventListener('click', () => {
+      cell.addEventListener('mousedown', () => {
+        // When the request panel isn't visible yet, firing the RequestActivated event
+        // doesn't make it visible if no request is selected. So we'll select it first.
+        this.select();
         this.parentView().dispatchEventToListeners(Events.RequestActivated, {showPanel: true});
       });
       let iconElement;

package/front_end/panels/sources/BreakpointEditDialog.ts

@@ -71,6 +71,7 @@ export class BreakpointEditDialog extends UI.Widget.Widget {
     const editorConfig = [
       CodeMirror.javascript.javascriptLanguage,
       TextEditor.Config.baseConfiguration(oldCondition || ''),
+      TextEditor.Config.closeBrackets,
       TextEditor.Config.autocompletion,
       CodeMirror.EditorView.lineWrapping,
       TextEditor.Config.showCompletionHint,

package/front_end/panels/timeline/TimelineController.ts

@@ -93,9 +93,6 @@ export class TimelineController implements SDK.TargetManager.SDKModelObserver<SD
     ];
     categoriesArray.push(TimelineModel.TimelineModel.TimelineModelImpl.Category.LatencyInfo);
 
-    if (Root.Runtime.experiments.isEnabled('timelineV8RuntimeCallStats') && options.enableJSSampling) {
-      categoriesArray.push(disabledByDefault('v8.runtime_stats_sampling'));
-    }
     if (!Root.Runtime.Runtime.queryParam('timelineTracingJSProfileDisabled') && options.enableJSSampling) {
       categoriesArray.push(disabledByDefault('v8.cpu_profiler'));
     }

package/front_end/third_party/codemirror.next/bundle.ts

@@ -7,8 +7,9 @@
 import {StreamLanguage} from '@codemirror/stream-parser';
 
 export {
-  acceptCompletion, autocompletion, completeAnyWord, Completion, CompletionContext,
-  CompletionResult, CompletionSource, currentCompletions, ifNotIn
+  acceptCompletion, autocompletion, closeCompletion, completeAnyWord,
+  Completion, CompletionContext, CompletionResult, CompletionSource, currentCompletions,
+  ifNotIn, selectedCompletion, startCompletion,
 } from '@codemirror/autocomplete';
 export {closeBrackets, closeBracketsKeymap} from '@codemirror/closebrackets';
 export {