chrome-devtools-frontend 1.0.943986 → 1.0.944427

package/front_end/core/host/UserMetrics.ts

@@ -598,7 +598,6 @@ export const DevtoolsExperiments: {
   'timelineEventInitiators': 24,
   'timelineInvalidationTracking': 26,
   'timelineShowAllEvents': 27,
-  'timelineV8RuntimeCallStats': 28,
   'timelineWebGL': 29,
   'timelineReplayEvent': 30,
   'wasmDWARFDebugging': 31,

package/front_end/core/i18n/locales/en-US.json

@@ -710,9 +710,6 @@
   "core/sdk/sdk-meta.ts | hideFramesPerSecondFpsMeter": {
     "message": "Hide frames per second (FPS) meter"
   },
-  "core/sdk/sdk-meta.ts | hideHittestBorders": {
-    "message": "Hide hit-test borders"
-  },
   "core/sdk/sdk-meta.ts | hideLayerBorders": {
     "message": "Hide layer borders"
   },
@@ -767,9 +764,6 @@
   "core/sdk/sdk-meta.ts | showGridTrackSizes": {
     "message": "Show grid track sizes"
   },
-  "core/sdk/sdk-meta.ts | showHittestBorders": {
-    "message": "Show hit-test borders"
-  },
   "core/sdk/sdk-meta.ts | showLayerBorders": {
     "message": "Show layer borders"
   },
@@ -992,9 +986,6 @@
   "entrypoints/inspector_main/RenderingOptions.ts | highlightsFramesRedDetectedToBe": {
     "message": "Highlights frames (red) detected to be ads."
   },
-  "entrypoints/inspector_main/RenderingOptions.ts | hittestBorders": {
-    "message": "Hit-test borders"
-  },
   "entrypoints/inspector_main/RenderingOptions.ts | layerBorders": {
     "message": "Layer borders"
   },
@@ -1016,9 +1007,6 @@
   "entrypoints/inspector_main/RenderingOptions.ts | showsAnOverlayWithCoreWebVitals": {
     "message": "Shows an overlay with Core Web Vitals."
   },
-  "entrypoints/inspector_main/RenderingOptions.ts | showsBordersAroundHittestRegions": {
-    "message": "Shows borders around hit-test regions."
-  },
   "entrypoints/inspector_main/RenderingOptions.ts | showsLayerBordersOrangeoliveAnd": {
     "message": "Shows layer borders (orange/olive) and tiles (cyan)."
   },

package/front_end/core/i18n/locales/en-XL.json

@@ -710,9 +710,6 @@
   "core/sdk/sdk-meta.ts | hideFramesPerSecondFpsMeter": {
     "message": "Ĥíd̂é f̂ŕâḿêś p̂ér̂ śêćôńd̂ (F́P̂Ś) m̂ét̂ér̂"
   },
-  "core/sdk/sdk-meta.ts | hideHittestBorders": {
-    "message": "Ĥíd̂é ĥít̂-t́êśt̂ b́ôŕd̂ér̂ś"
-  },
   "core/sdk/sdk-meta.ts | hideLayerBorders": {
     "message": "Ĥíd̂é l̂áŷér̂ b́ôŕd̂ér̂ś"
   },
@@ -767,9 +764,6 @@
   "core/sdk/sdk-meta.ts | showGridTrackSizes": {
     "message": "Ŝh́ôẃ ĝŕîd́ t̂ŕâćk̂ śîźêś"
   },
-  "core/sdk/sdk-meta.ts | showHittestBorders": {
-    "message": "Ŝh́ôẃ ĥít̂-t́êśt̂ b́ôŕd̂ér̂ś"
-  },
   "core/sdk/sdk-meta.ts | showLayerBorders": {
     "message": "Ŝh́ôẃ l̂áŷér̂ b́ôŕd̂ér̂ś"
   },
@@ -992,9 +986,6 @@
   "entrypoints/inspector_main/RenderingOptions.ts | highlightsFramesRedDetectedToBe": {
     "message": "Ĥíĝh́l̂íĝh́t̂ś f̂ŕâḿêś (r̂éd̂) d́êt́êćt̂éd̂ t́ô b́ê ád̂ś."
   },
-  "entrypoints/inspector_main/RenderingOptions.ts | hittestBorders": {
-    "message": "Ĥít̂-t́êśt̂ b́ôŕd̂ér̂ś"
-  },
   "entrypoints/inspector_main/RenderingOptions.ts | layerBorders": {
     "message": "L̂áŷér̂ b́ôŕd̂ér̂ś"
   },
@@ -1016,9 +1007,6 @@
   "entrypoints/inspector_main/RenderingOptions.ts | showsAnOverlayWithCoreWebVitals": {
     "message": "Ŝh́ôẃŝ án̂ óv̂ér̂ĺâý ŵít̂h́ Ĉór̂é Ŵéb̂ V́ît́âĺŝ."
   },
-  "entrypoints/inspector_main/RenderingOptions.ts | showsBordersAroundHittestRegions": {
-    "message": "Ŝh́ôẃŝ b́ôŕd̂ér̂ś âŕôún̂d́ ĥít̂-t́êśt̂ ŕêǵîón̂ś."
-  },
   "entrypoints/inspector_main/RenderingOptions.ts | showsLayerBordersOrangeoliveAnd": {
     "message": "Ŝh́ôẃŝ ĺâýêŕ b̂ór̂d́êŕŝ (ór̂án̂ǵê/ól̂ív̂é) âńd̂ t́îĺêś (ĉýâń)."
   },

package/front_end/core/sdk/CSSStyleDeclaration.ts

@@ -289,6 +289,10 @@ export class CSSStyleDeclaration {
     return this.#allPropertiesInternal;
   }
 
+  hasActiveProperty(name: string): boolean {
+    return this.#activePropertyMap.has(name);
+  }
+
   getPropertyValue(name: string): string {
     const property = this.#activePropertyMap.get(name);
     return property ? property.value : '';

package/front_end/core/sdk/OverlayModel.ts

@@ -79,9 +79,6 @@ export class OverlayModel extends SDKModel<EventTypes> implements ProtocolProxyA
   #showScrollBottleneckRectsSetting: Common.Settings.Setting<any>;
   // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration
   // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  #showHitTestBordersSetting: Common.Settings.Setting<any>;
-  // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   #showWebVitalsSetting: Common.Settings.Setting<any>;
   #registeredListeners: Common.EventTarget.EventDescriptor[];
   #showViewportSizeOnResize: boolean;
@@ -123,7 +120,6 @@ export class OverlayModel extends SDKModel<EventTypes> implements ProtocolProxyA
     this.#showFPSCounterSetting = Common.Settings.Settings.instance().moduleSetting('showFPSCounter');
     this.#showScrollBottleneckRectsSetting =
         Common.Settings.Settings.instance().moduleSetting('showScrollBottleneckRects');
-    this.#showHitTestBordersSetting = Common.Settings.Settings.instance().moduleSetting('showHitTestBorders');
     this.#showWebVitalsSetting = Common.Settings.Settings.instance().moduleSetting('showWebVitals');
 
     this.#registeredListeners = [];
@@ -213,8 +209,6 @@ export class OverlayModel extends SDKModel<EventTypes> implements ProtocolProxyA
       this.#showScrollBottleneckRectsSetting.addChangeListener(
           () => this.overlayAgent.invoke_setShowScrollBottleneckRects(
               {show: this.#showScrollBottleneckRectsSetting.get()})),
-      this.#showHitTestBordersSetting.addChangeListener(
-          () => this.overlayAgent.invoke_setShowHitTestBorders({show: this.#showHitTestBordersSetting.get()})),
       this.#showWebVitalsSetting.addChangeListener(
           () => this.overlayAgent.invoke_setShowWebVitals({show: this.#showWebVitalsSetting.get()})),
     ];
@@ -237,9 +231,6 @@ export class OverlayModel extends SDKModel<EventTypes> implements ProtocolProxyA
     if (this.#showScrollBottleneckRectsSetting.get()) {
       this.overlayAgent.invoke_setShowScrollBottleneckRects({show: true});
     }
-    if (this.#showHitTestBordersSetting.get()) {
-      this.overlayAgent.invoke_setShowHitTestBorders({show: true});
-    }
     if (this.#showWebVitalsSetting.get()) {
       this.overlayAgent.invoke_setShowWebVitals({show: true});
     }

package/front_end/core/sdk/sdk-meta.ts

@@ -155,14 +155,6 @@ const UIStrings = {
   */
   hideScrollPerformanceBottlenecks: 'Hide scroll performance bottlenecks',
   /**
-  *@description Title of a setting under the Rendering category that can be invoked through the Command Menu
-  */
-  showHittestBorders: 'Show hit-test borders',
-  /**
-  *@description Title of a setting under the Rendering category that can be invoked through the Command Menu
-  */
-  hideHittestBorders: 'Hide hit-test borders',
-  /**
   *@description Title of a Rendering setting that can be invoked through the Command Menu
   */
   emulateAFocusedPage: 'Emulate a focused page',
@@ -665,24 +657,6 @@ Common.Settings.registerSettingExtension({
   defaultValue: false,
 });
 
-Common.Settings.registerSettingExtension({
-  category: Common.Settings.SettingCategory.RENDERING,
-  settingName: 'showHitTestBorders',
-  settingType: Common.Settings.SettingType.BOOLEAN,
-  storageType: Common.Settings.SettingStorageType.Session,
-  options: [
-    {
-      value: true,
-      title: i18nLazyString(UIStrings.showHittestBorders),
-    },
-    {
-      value: false,
-      title: i18nLazyString(UIStrings.hideHittestBorders),
-    },
-  ],
-  defaultValue: false,
-});
-
 Common.Settings.registerSettingExtension({
   category: Common.Settings.SettingCategory.RENDERING,
   title: i18nLazyString(UIStrings.emulateAFocusedPage),

package/front_end/entrypoints/inspector_main/RenderingOptions.ts

@@ -95,16 +95,6 @@ const UIStrings = {
   */
   highlightsFramesRedDetectedToBe: 'Highlights frames (red) detected to be ads.',
   /**
-  * @description The name of a checkbox setting in the Rendering tool. This setting shows borders
-  * around hit-test regions. 'hit-test regions' are areas on the page where the browser is listening
-  * for mouse clicks.
-  */
-  hittestBorders: 'Hit-test borders',
-  /**
-  * @description Explanation text for the 'Hit-test borders' setting in the Rendering tool.
-  */
-  showsBordersAroundHittestRegions: 'Shows borders around hit-test regions.',
-  /**
   * @description The name of a checkbox setting in the Rendering tool. This setting shows an overlay
   * with Core Web Vitals. Core Web Vitals: https://support.google.com/webmasters/answer/9205520?hl=en
   */
@@ -246,9 +236,6 @@ export class RenderingOptionsView extends UI.Widget.VBox {
     this.appendCheckbox(
         i18nString(UIStrings.highlightAdFrames), i18nString(UIStrings.highlightsFramesRedDetectedToBe),
         Common.Settings.Settings.instance().moduleSetting('showAdHighlights'));
-    this.appendCheckbox(
-        i18nString(UIStrings.hittestBorders), i18nString(UIStrings.showsBordersAroundHittestRegions),
-        Common.Settings.Settings.instance().moduleSetting('showHitTestBorders'));
     this.appendCheckbox(
         i18nString(UIStrings.coreWebVitals), i18nString(UIStrings.showsAnOverlayWithCoreWebVitals),
         Common.Settings.Settings.instance().moduleSetting('showWebVitals'));

package/front_end/entrypoints/main/MainImpl.ts

@@ -306,8 +306,6 @@ export class MainImpl {
     Root.Runtime.experiments.register('timelineEventInitiators', 'Timeline: event initiators');
     Root.Runtime.experiments.register('timelineInvalidationTracking', 'Timeline: invalidation tracking', true);
     Root.Runtime.experiments.register('timelineShowAllEvents', 'Timeline: show all events', true);
-    Root.Runtime.experiments.register(
-        'timelineV8RuntimeCallStats', 'Timeline: V8 Runtime Call Stats on Timeline', true);
     Root.Runtime.experiments.register('timelineWebGL', 'Timeline: WebGL-based flamechart');
     Root.Runtime.experiments.register('timelineReplayEvent', 'Timeline: Replay input events', true);
     Root.Runtime.experiments.register(

package/front_end/models/timeline_model/TimelineJSProfile.ts

@@ -59,7 +59,6 @@ export class TimelineJSProfileProcessor {
 
   static generateJSFrameEvents(events: SDK.TracingModel.Event[], config: {
     showAllEvents: boolean,
-    showRuntimeCallStats: boolean,
     showNativeFunctions: boolean,
   }): SDK.TracingModel.Event[] {
     function equalFrames(frame1: Protocol.Runtime.CallFrame, frame2: Protocol.Runtime.CallFrame): boolean {
@@ -85,7 +84,7 @@ export class TimelineJSProfileProcessor {
     const lockedJsStackDepth: number[] = [];
     let ordinal = 0;
     let fakeJSInvocation = false;
-    const {showAllEvents, showRuntimeCallStats, showNativeFunctions} = config;
+    const {showAllEvents, showNativeFunctions} = config;
 
     function onStartEvent(e: SDK.TracingModel.Event): void {
       if (fakeJSInvocation) {
@@ -135,15 +134,10 @@ export class TimelineJSProfileProcessor {
       jsFramesStack.length = depth;
     }
 
-    function showNativeName(name: string): boolean {
-      return showRuntimeCallStats && Boolean(TimelineJSProfileProcessor.nativeGroup(name));
-    }
-
     function filterStackFrames(stack: Protocol.Runtime.CallFrame[]): void {
       if (showAllEvents) {
         return;
       }
-      let previousNativeFrameName: (string|null)|null = null;
       let j = 0;
       for (let i = 0; i < stack.length; ++i) {
         const frame = stack[i];
@@ -153,16 +147,9 @@ export class TimelineJSProfileProcessor {
           continue;
         }
         const isNativeRuntimeFrame = TimelineJSProfileProcessor.isNativeRuntimeFrame(frame);
-        if (isNativeRuntimeFrame && !showNativeName(frame.functionName)) {
-          continue;
-        }
-        const nativeFrameName =
-            isNativeRuntimeFrame ? TimelineJSProfileProcessor.nativeGroup(frame.functionName) : null;
-        if (previousNativeFrameName && previousNativeFrameName === nativeFrameName) {
-          continue;
+        if (!isNativeRuntimeFrame) {
+          stack[j++] = frame;
         }
-        previousNativeFrameName = nativeFrameName;
-        stack[j++] = frame;
       }
       stack.length = j;
     }

package/front_end/models/timeline_model/TimelineModel.ts

@@ -678,7 +678,6 @@ export class TimelineModelImpl {
     if (jsSamples || events.some(e => e.name === RecordType.JSSample)) {
       const jsFrameEvents = TimelineJSProfileProcessor.generateJSFrameEvents(events, {
         showAllEvents: Root.Runtime.experiments.isEnabled('timelineShowAllEvents'),
-        showRuntimeCallStats: Root.Runtime.experiments.isEnabled('timelineV8RuntimeCallStats'),
         showNativeFunctions: Common.Settings.Settings.instance().moduleSetting('showNativeFunctionsInJSProfile').get(),
       });
       if (jsFrameEvents && jsFrameEvents.length) {

package/front_end/panels/console/ConsolePinPane.ts

@@ -255,6 +255,7 @@ export class ConsolePin {
         ]),
         CodeMirror.EditorView.domEventHandlers({blur: (_e, view) => this.onBlur(view)}),
         TextEditor.Config.baseConfiguration(expression),
+        TextEditor.Config.closeBrackets,
         TextEditor.Config.autocompletion,
       ],
     }));