chrome-devtools-frontend 1.0.943182 → 1.0.944903

package/front_end/ui/legacy/Dialog.ts

@@ -137,9 +137,14 @@ export class Dialog extends Common.ObjectWrapper.eventMixin<EventTypes, typeof G
       if (node instanceof HTMLElement) {
         const element = (node as HTMLElement);
         const tabIndex = element.tabIndex;
-        if (tabIndex >= 0 && (!exclusionSet || !exclusionSet.has(element))) {
-          this.tabIndexMap.set(element, tabIndex);
-          element.tabIndex = -1;
+        if (!exclusionSet?.has(element)) {
+          if (tabIndex >= 0) {
+            this.tabIndexMap.set(element, tabIndex);
+            element.tabIndex = -1;
+          } else if (element.hasAttribute('contenteditable')) {
+            this.tabIndexMap.set(element, element.hasAttribute('tabindex') ? tabIndex : 0);
+            element.tabIndex = -1;
+          }
         }
       }
     }

package/front_end/ui/legacy/ViewManager.ts

@@ -828,6 +828,12 @@ export class _TabbedLocation extends Location implements TabbedViewLocation {
     this.tabOrderSetting.set(tabOrders);
   }
 
+  // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
+  getCloseableTabSetting(): Common.Settings.Setting<any> {
+    return this.closeableTabSetting.get();
+  }
+
   static orderStep = 10;  // Keep in sync with descriptors.
 }
 

package/front_end/ui/legacy/components/cookie_table/CookiesTable.ts

@@ -103,6 +103,10 @@ const UIStrings = {
    * @example {9001628746521180} seconds
    */
   timeAfterTooltip: 'The expiration timestamp is {seconds}, which corresponds to a date after {date}',
+  /**
+   * @description Text to be show in the Partition Key column in case it is an opaque origin.
+   */
+  opaquePartitionKey: '(opaque)',
 };
 const str_ = i18n.i18n.registerUIStrings('ui/legacy/components/cookie_table/CookiesTable.ts', UIStrings);
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
@@ -215,6 +219,13 @@ export class CookiesTable extends UI.Widget.VBox {
         dataType: DataGrid.DataGrid.DataType.Boolean,
         editable: editable,
       },
+      {
+        id: SDK.Cookie.Attributes.PartitionKey,
+        title: 'Partition Key',
+        sortable: true,
+        weight: 7,
+        editable: editable,
+      },
       {
         id: SDK.Cookie.Attributes.Priority,
         title: 'Priority',
@@ -462,6 +473,8 @@ export class CookiesTable extends UI.Widget.VBox {
           return String(cookie.sameSite());
         case SDK.Cookie.Attributes.SameParty:
           return String(cookie.sameParty());
+        case SDK.Cookie.Attributes.PartitionKey:
+          return cookie.partitionKeyOpaque() ? i18nString(UIStrings.opaquePartitionKey) : String(cookie.partitionKey());
         case SDK.Cookie.Attributes.SourceScheme:
           return String(cookie.sourceScheme());
         default:
@@ -570,6 +583,7 @@ export class CookiesTable extends UI.Widget.VBox {
     data[SDK.Cookie.Attributes.SourcePort] = cookie.sourcePort();
     data[SDK.Cookie.Attributes.SourceScheme] = cookie.sourceScheme();
     data[SDK.Cookie.Attributes.Priority] = cookie.priority() || '';
+    data[SDK.Cookie.Attributes.PartitionKey] = cookie.partitionKey() || '';
 
     const blockedReasons = this.cookieToBlockedReasons?.get(cookie);
     const node = new DataGridNode(data, cookie, blockedReasons || null);
@@ -613,6 +627,9 @@ export class CookiesTable extends UI.Widget.VBox {
     if (node.data[SDK.Cookie.Attributes.Expires] === null) {
       node.data[SDK.Cookie.Attributes.Expires] = expiresSessionValue();
     }
+    if (node.data[SDK.Cookie.Attributes.PartitionKey] === null) {
+      node.data[SDK.Cookie.Attributes.PartitionKey] = '';
+    }
   }
 
   private saveNode(node: DataGridNode): void {
@@ -660,6 +677,9 @@ export class CookiesTable extends UI.Widget.VBox {
       cookie.addAttribute(
           SDK.Cookie.Attributes.SourcePort, Number.parseInt(data[SDK.Cookie.Attributes.SourcePort], 10) || undefined);
     }
+    if (SDK.Cookie.Attributes.PartitionKey in data) {
+      cookie.addAttribute(SDK.Cookie.Attributes.PartitionKey, data[SDK.Cookie.Attributes.PartitionKey]);
+    }
     cookie.setSize(data[SDK.Cookie.Attributes.Name].length + data[SDK.Cookie.Attributes.Value].length);
     return cookie;
   }

package/front_end/ui/legacy/components/source_frame/SourceFrame.ts

@@ -159,6 +159,11 @@ export class SourceFrameImpl extends Common.ObjectWrapper.eventMixin<EventTypes,
     this.textEditorInternal = new TextEditor.TextEditor.TextEditor(this.placeholderEditorState(''));
     this.textEditorInternal.style.flexGrow = '1';
     this.element.appendChild(this.textEditorInternal);
+    this.element.addEventListener('keydown', (event: KeyboardEvent): void => {
+      if (event.defaultPrevented) {
+        event.stopPropagation();
+      }
+    });
 
     this.baseDoc = this.textEditorInternal.state.doc;
 
@@ -201,6 +206,7 @@ export class SourceFrameImpl extends Common.ObjectWrapper.eventMixin<EventTypes,
     return [
       CodeMirror.EditorView.updateListener.of(update => this.dispatchEventToListeners(Events.EditorUpdate, update)),
       TextEditor.Config.baseConfiguration(doc),
+      TextEditor.Config.closeBrackets,
       TextEditor.Config.sourcesAutocompletion.instance(),
       TextEditor.Config.showWhitespace.instance(),
       TextEditor.Config.allowScrollPastEof.instance(),
@@ -716,7 +722,6 @@ export class SourceFrameImpl extends Common.ObjectWrapper.eventMixin<EventTypes,
     if (wasLoaded) {
       textEditor.editor.scrollDOM.scrollTop = scrollTop;
     }
-    this.editorInitialized();
     this.wasShownOrLoaded();
 
     if (this.delayedFindSearchMatches) {
@@ -726,9 +731,6 @@ export class SourceFrameImpl extends Common.ObjectWrapper.eventMixin<EventTypes,
     this.muteChangeEventsForSetContent = false;
   }
 
-  protected editorInitialized(): void {
-  }
-
   setSearchableView(view: UI.SearchableView.SearchableView|null): void {
     this.searchableView = view;
   }

package/front_end/ui/legacy/components/utils/Linkifier.ts

@@ -184,17 +184,9 @@ export class Linkifier implements SDK.TargetManager.Observer {
       }
       info.liveLocation = null;
       Linkifier.unbindUILocation(anchor);
-      const fallback = (info.fallback as HTMLElement | null);
+      const fallback = info.fallback;
       if (fallback) {
-        // @ts-ignore
-        anchor.href = fallback.href;
-        UI.Tooltip.Tooltip.install(anchor, fallback.title);
-        anchor.className = fallback.className;
-        anchor.textContent = fallback.textContent;
-        const fallbackInfo = infoByAnchor.get(fallback);
-        if (fallbackInfo) {
-          infoByAnchor.set(anchor, fallbackInfo);
-        }
+        anchor.replaceWith(fallback);
       }
     }
   }
@@ -249,15 +241,11 @@ export class Linkifier implements SDK.TargetManager.Observer {
     // Not initialising the anchor element with 'zero width space' (\u200b) causes a crash
     // in the layout engine.
     // TODO(szuend): Remove comment and workaround once the crash is fixed.
-    const anchor = Linkifier.createLink(
+    const {link, linkInfo} = Linkifier.createLink(
         fallbackAnchor && fallbackAnchor.textContent ? fallbackAnchor.textContent : '\u200b', className,
         createLinkOptions);
-    const info = Linkifier.linkInfo(anchor);
-    if (!info) {
-      return fallbackAnchor;
-    }
-    info.enableDecorator = this.useLinkDecorator;
-    info.fallback = fallbackAnchor;
+    linkInfo.enableDecorator = this.useLinkDecorator;
+    linkInfo.fallback = fallbackAnchor;
 
     const pool = this.locationPoolByTarget.get(rawLocation.debuggerModel.target());
     if (!pool) {
@@ -268,10 +256,10 @@ export class Linkifier implements SDK.TargetManager.Observer {
 
     const currentOnLiveLocationUpdate = this.onLiveLocationUpdate;
     Bindings.DebuggerWorkspaceBinding.DebuggerWorkspaceBinding.instance()
-        .createLiveLocation(rawLocation, this.updateAnchor.bind(this, anchor, linkDisplayOptions), pool)
+        .createLiveLocation(rawLocation, this.updateAnchor.bind(this, link, linkDisplayOptions), pool)
         .then(liveLocation => {
           if (liveLocation) {
-            info.liveLocation = liveLocation;
+            linkInfo.liveLocation = liveLocation;
             // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration
             // @ts-expect-error
             currentOnLiveLocationUpdate();
@@ -279,8 +267,8 @@ export class Linkifier implements SDK.TargetManager.Observer {
         });
 
     const anchors = (this.anchorsByTarget.get(rawLocation.debuggerModel.target()) as Element[]);
-    anchors.push(anchor);
-    return anchor;
+    anchors.push(link);
+    return link;
   }
 
   linkifyScriptLocation(
@@ -327,68 +315,61 @@ export class Linkifier implements SDK.TargetManager.Observer {
         target, callFrame.scriptId, callFrame.url, callFrame.lineNumber, linkifyOptions);
   }
 
-  linkifyStackTraceTopFrame(target: SDK.Target.Target, stackTrace: Protocol.Runtime.StackTrace, classes?: string):
+  linkifyStackTraceTopFrame(target: SDK.Target.Target, stackTrace: Protocol.Runtime.StackTrace, className?: string):
       HTMLElement {
-    console.assert(Boolean(stackTrace.callFrames) && Boolean(stackTrace.callFrames.length));
+    console.assert(stackTrace.callFrames.length > 0);
 
-    const topFrame = stackTrace.callFrames[0];
-    const fallbackAnchor = Linkifier.linkifyURL(topFrame.url, {
-      className: classes,
-      lineNumber: topFrame.lineNumber,
-      columnNumber: topFrame.columnNumber,
+    const {url, lineNumber, columnNumber} = stackTrace.callFrames[0];
+    const fallbackAnchor = Linkifier.linkifyURL(url, {
+      className,
+      lineNumber,
+      columnNumber,
       showColumnNumber: false,
       inlineFrameIndex: 0,
       maxLength: this.maxLength,
       text: undefined,
-      preventClick: undefined,
+      preventClick: true,
       tabStop: undefined,
       bypassURLTrimming: undefined,
     });
-    if (target.isDisposed()) {
-      return fallbackAnchor;
-    }
 
-    const debuggerModel = target.model(SDK.DebuggerModel.DebuggerModel);
-    if (!debuggerModel) {
-      return fallbackAnchor;
-    }
-    const rawLocations = debuggerModel.createRawLocationsByStackTrace(stackTrace);
-    if (rawLocations.length === 0) {
+    // The contract is that disposed targets don't have a LiveLocationPool
+    // associated, whereas all active targets have one such pool. This ensures
+    // that the fallbackAnchor is only ever used when the target was disposed.
+    const pool = this.locationPoolByTarget.get(target);
+    if (!pool) {
+      console.assert(target.isDisposed());
       return fallbackAnchor;
     }
+    console.assert(!target.isDisposed());
+
+    // All targets that can report stack traces also have a debugger model.
+    const debuggerModel = target.model(SDK.DebuggerModel.DebuggerModel) as SDK.DebuggerModel.DebuggerModel;
 
     // Not initialising the anchor element with 'zero width space' (\u200b) causes a crash
     // in the layout engine.
     // TODO(szuend): Remove comment and workaround once the crash is fixed.
-    const anchor = Linkifier.createLink('\u200b', classes || '');
-    const info = Linkifier.linkInfo(anchor);
-    if (!info) {
-      return fallbackAnchor;
-    }
-    info.enableDecorator = this.useLinkDecorator;
-    info.fallback = fallbackAnchor;
-
-    const pool = this.locationPoolByTarget.get(target);
-    if (!pool) {
-      return fallbackAnchor;
-    }
+    const {link, linkInfo} = Linkifier.createLink('\u200b', className ?? '');
+    linkInfo.enableDecorator = this.useLinkDecorator;
+    linkInfo.fallback = fallbackAnchor;
 
     const linkDisplayOptions = {showColumnNumber: false};
 
     const currentOnLiveLocationUpdate = this.onLiveLocationUpdate;
     Bindings.DebuggerWorkspaceBinding.DebuggerWorkspaceBinding.instance()
         .createStackTraceTopFrameLiveLocation(
-            rawLocations, this.updateAnchor.bind(this, anchor, linkDisplayOptions), pool)
+            debuggerModel.createRawLocationsByStackTrace(stackTrace),
+            this.updateAnchor.bind(this, link, linkDisplayOptions), pool)
         .then(liveLocation => {
-          info.liveLocation = liveLocation;
+          linkInfo.liveLocation = liveLocation;
           // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration
           // @ts-expect-error
           currentOnLiveLocationUpdate();
         });
 
     const anchors = (this.anchorsByTarget.get(target) as Element[]);
-    anchors.push(anchor);
-    return anchor;
+    anchors.push(link);
+    return link;
   }
 
   linkifyCSSLocation(rawLocation: SDK.CSSModel.CSSLocation, classes?: string): Element {
@@ -403,33 +384,29 @@ export class Linkifier implements SDK.TargetManager.Observer {
     // Not initialising the anchor element with 'zero width space' (\u200b) causes a crash
     // in the layout engine.
     // TODO(szuend): Remove comment and workaround once the crash is fixed.
-    const anchor = (Linkifier.createLink('\u200b', classes || '', createLinkOptions) as HTMLElement);
-    const info = Linkifier.linkInfo(anchor);
-    if (!info) {
-      return anchor;
-    }
-    info.enableDecorator = this.useLinkDecorator;
+    const {link, linkInfo} = Linkifier.createLink('\u200b', classes || '', createLinkOptions);
+    linkInfo.enableDecorator = this.useLinkDecorator;
 
     const pool = this.locationPoolByTarget.get(rawLocation.cssModel().target());
     if (!pool) {
-      return anchor;
+      return link;
     }
 
     const linkDisplayOptions = {showColumnNumber: false};
 
     const currentOnLiveLocationUpdate = this.onLiveLocationUpdate;
     Bindings.CSSWorkspaceBinding.CSSWorkspaceBinding.instance()
-        .createLiveLocation(rawLocation, this.updateAnchor.bind(this, anchor, linkDisplayOptions), pool)
+        .createLiveLocation(rawLocation, this.updateAnchor.bind(this, link, linkDisplayOptions), pool)
         .then(liveLocation => {
-          info.liveLocation = liveLocation;
+          linkInfo.liveLocation = liveLocation;
           // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration
           // @ts-expect-error
           currentOnLiveLocationUpdate();
         });
 
     const anchors = (this.anchorsByTarget.get(rawLocation.cssModel().target()) as Element[]);
-    anchors.push(anchor);
-    return anchor;
+    anchors.push(link);
+    return link;
   }
 
   reset(): void {
@@ -557,16 +534,12 @@ export class Linkifier implements SDK.TargetManager.Observer {
     }
     const title = linkText !== url ? url : '';
     const linkOptions = {maxLength, title, href: url, preventClick, tabStop: options.tabStop, bypassURLTrimming};
-    const link = Linkifier.createLink(linkText, className, linkOptions);
-    const info = Linkifier.linkInfo(link);
-    if (!info) {
-      return link;
-    }
+    const {link, linkInfo} = Linkifier.createLink(linkText, className, linkOptions);
     if (lineNumber) {
-      info.lineNumber = lineNumber;
+      linkInfo.lineNumber = lineNumber;
     }
     if (columnNumber) {
-      info.columnNumber = columnNumber;
+      linkInfo.columnNumber = columnNumber;
     }
     return link;
   }
@@ -582,16 +555,13 @@ export class Linkifier implements SDK.TargetManager.Observer {
       tabStop: undefined,
       bypassURLTrimming: undefined,
     };
-    const link = Linkifier.createLink(text, className || '', createLinkOptions);
-    const linkInfo = Linkifier.linkInfo(link);
-    if (!linkInfo) {
-      return link;
-    }
+    const {link, linkInfo} = Linkifier.createLink(text, className || '', createLinkOptions);
     linkInfo.revealable = revealable;
     return link;
   }
 
-  private static createLink(text: string|HTMLElement, className: string, options?: _CreateLinkOptions): HTMLElement {
+  private static createLink(text: string|HTMLElement, className: string, options?: _CreateLinkOptions):
+      {link: HTMLElement, linkInfo: _LinkInfo} {
     options = options || {
       maxLength: undefined,
       title: undefined,
@@ -654,7 +624,7 @@ export class Linkifier implements SDK.TargetManager.Observer {
     }
     UI.ARIAUtils.markAsLink(link);
     link.tabIndex = tabStop ? 0 : -1;
-    return link;
+    return {link, linkInfo};
   }
 
   private static setTrimmedText(link: Element, text: string, maxLength?: number): void {

package/front_end/ui/legacy/themeColors.css

@@ -167,6 +167,7 @@
   --color-selected-option: #fff;
   --color-selected-option-background: #1a73e8;
   --color-highlighted-line: rgb(255 255 0 / 50%);
+  --color-completion-hover: rgb(56 121 217 / 10%);
   --color-search-match-border: rgb(128 128 128);
   --color-selected-search-match: var(--color-text-primary);
   --color-selected-search-match-background: rgb(241 234 0);
@@ -307,6 +308,7 @@
   --color-selected-option: #fff;
   --color-selected-option-background: #0e639c;
   --color-highlighted-line: hsl(133deg 100% 30% / 50%);
+  --color-completion-hover: rgb(56 121 217 / 10%);
   --color-search-match-border: rgb(128 128 128);
   --color-selected-search-match: #eee;
   --color-selected-search-match-background: hsl(133deg 100% 30%);

package/inspector_overlay/css_grid_label_helpers.ts

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-import {luminance} from '../front_end/core/common/ColorUtils.js';
+import {luminance} from '../front_end/core/common/ColorUtils.js';  // eslint-disable-line rulesdir/es_modules_import
 
 import type {AreaBounds, Bounds, Position} from './common.js';
 import {createChild} from './common.js';

package/inspector_overlay/highlight_common.ts

@@ -28,7 +28,7 @@
 //  (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
 //  THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-import {rgbaToHsla} from '../front_end/core/common/ColorUtils.js';
+import {rgbaToHsla} from '../front_end/core/common/ColorUtils.js';  // eslint-disable-line rulesdir/es_modules_import
 
 import type {Bounds, PathCommands, Quad} from './common.js';
 

package/inspector_overlay/tool_highlight.ts

@@ -28,7 +28,7 @@
 //  (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
 //  THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-import {contrastRatio, contrastRatioAPCA, getAPCAThreshold, getContrastThreshold} from '../front_end/core/common/ColorUtils.js';
+import {contrastRatio, contrastRatioAPCA, getAPCAThreshold, getContrastThreshold} from '../front_end/core/common/ColorUtils.js';  // eslint-disable-line rulesdir/es_modules_import
 
 import type {Bounds, PathCommands, ResetData} from './common.js';
 import {constrainNumber, createChild, createElement, createTextChild, ellipsify, Overlay} from './common.js';

package/package.json

@@ -55,5 +55,5 @@
     "unittest": "scripts/test/run_unittests.py --no-text-coverage",
     "watch": "third_party/node/node.py --output scripts/watch_build.js"
   },
-  "version": "1.0.943182"
+  "version": "1.0.944903"
 }

package/scripts/eslint_rules/lib/es_modules_import.js

@@ -11,7 +11,6 @@
 const path = require('path');
 
 const FRONT_END_DIRECTORY = path.join(__dirname, '..', '..', '..', 'front_end');
-const UNITTESTS_DIRECTORY = path.join(__dirname, '..', '..', '..', 'test', 'unittests');
 const INSPECTOR_OVERLAY_DIRECTORY = path.join(__dirname, '..', '..', '..', 'front_end', 'inspector_overlay');
 const COMPONENT_DOCS_DIRECTORY = path.join(FRONT_END_DIRECTORY, 'ui', 'components', 'docs');
 
@@ -164,12 +163,6 @@ module.exports = {
           });
         }
 
-        const importingFileIsUnitTestFile = importingFileName.startsWith(UNITTESTS_DIRECTORY);
-        const importingFileIsComponentDocsFile = importingFileName.startsWith(COMPONENT_DOCS_DIRECTORY);
-        if (!importingFileName.startsWith(FRONT_END_DIRECTORY) && !importingFileIsUnitTestFile) {
-          return;
-        }
-
         if (importingFileName.startsWith(INSPECTOR_OVERLAY_DIRECTORY)) {
           return;
         }
@@ -180,15 +173,6 @@ module.exports = {
 
         const exportingFileName = path.resolve(path.dirname(importingFileName), importPath);
 
-        if (importPath.replace(/\\/g, '/').includes('/front_end/') && !importingFileIsUnitTestFile &&
-            !importingFileIsComponentDocsFile) {
-          context.report({
-            node,
-            message:
-                'Invalid relative import: an import should not include the "front_end" directory. If you are in a unit test, you should import from the module entrypoint.',
-          });
-        }
-
         if (importPathForErrorMessage.endsWith('platform/platform.js') &&
             nodeSpecifiersSpecialImportsOnly(node.specifiers)) {
           /* We allow direct importing of the ls and assertNotNull utility as it's so frequently used. */

package/scripts/eslint_rules/tests/es_modules_import_test.js

@@ -248,21 +248,5 @@ ruleTester.run('es_modules_import', rule, {
             'Incorrect cross-namespace import: "../third_party/marked/package/lib/marked.esm.js". Use "import * as Namespace from \'../namespace/namespace.js\';" instead. If the third_party dependency does not expose a single entrypoint, update es_modules_import.js to make it exempt.'
       }],
     },
-    {
-      code: 'import * as Marked from \'../../front_end/third_party/marked/package/lib/marked.esm.js\';',
-      filename: 'front_end/marked/marked.js',
-      errors: [{
-        message:
-            'Invalid relative import: an import should not include the "front_end" directory. If you are in a unit test, you should import from the module entrypoint.'
-      }],
-    },
-    {
-      code: 'import * as SDK from \'../../front_end/sdk/sdk.js\';',
-      filename: 'front_end/marked/marked.js',
-      errors: [{
-        message:
-            'Invalid relative import: an import should not include the "front_end" directory. If you are in a unit test, you should import from the module entrypoint.'
-      }],
-    }
   ]
 });