chrome-devtools-frontend 1.0.1730971 → 1.0.1732697

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (210) hide show
  1. package/docs/get_the_code.md +1 -73
  2. package/front_end/Tests.js +15 -0
  3. package/front_end/core/host/AidaClient.ts +47 -3
  4. package/front_end/core/host/AidaClientTypes.ts +27 -3
  5. package/front_end/core/host/AidaGcaTranslation.ts +1 -1
  6. package/front_end/core/sdk/DOMModel.ts +8 -3
  7. package/front_end/core/sdk/NetworkManager.ts +2 -1
  8. package/front_end/entrypoints/formatter_worker/ScopeParser.ts +2 -2
  9. package/front_end/generated/Deprecation.ts +0 -8
  10. package/front_end/generated/InspectorBackendCommands.ts +2 -1
  11. package/front_end/generated/SupportedCSSProperties.ts +2 -2
  12. package/front_end/generated/protocol.ts +9 -0
  13. package/front_end/models/ai-utils/debug.ts +127 -22
  14. package/front_end/models/ai_assistance/README.md +1 -1
  15. package/front_end/models/ai_assistance/agents/AiAgent.ts +10 -5
  16. package/front_end/models/ai_assistance/agents/StylingAgent.snapshot.txt +1 -1
  17. package/front_end/models/ai_assistance/contexts/DOMNodeContext.ts +4 -3
  18. package/front_end/models/ai_assistance/contexts/LighthouseContext.snapshot.txt +9 -2
  19. package/front_end/models/ai_assistance/contexts/LighthouseContext.ts +4 -3
  20. package/front_end/models/ai_assistance/data_formatters/LighthouseFormatter.snapshot.txt +97 -11
  21. package/front_end/models/ai_assistance/data_formatters/LighthouseFormatter.ts +92 -43
  22. package/front_end/models/ai_assistance/data_formatters/PerformanceInsightFormatter.snapshot.txt +1 -1
  23. package/front_end/models/ai_assistance/data_formatters/PerformanceTraceFormatter.snapshot.txt +26 -26
  24. package/front_end/models/ai_assistance/skills/styling.md +4 -2
  25. package/front_end/models/ai_assistance/tools/ExecuteJavaScript.ts +31 -36
  26. package/front_end/models/ai_code_completion/AiCodeCompletion.ts +2 -1
  27. package/front_end/models/ai_code_completion/ai_code_completion.ts +11 -2
  28. package/front_end/models/ai_code_generation/AiCodeGeneration.ts +2 -1
  29. package/front_end/models/ai_code_generation/ai_code_generation.ts +11 -2
  30. package/front_end/models/bindings/CompilerScriptMapping.ts +0 -1
  31. package/front_end/models/bindings/DebuggerLanguagePlugins.ts +0 -1
  32. package/front_end/models/bindings/DebuggerWorkspaceBinding.ts +0 -1
  33. package/front_end/models/har/HARFormat.ts +1 -0
  34. package/front_end/models/har/Importer.ts +7 -1
  35. package/front_end/models/har/Log.snapshot.txt +2 -0
  36. package/front_end/models/har/Log.ts +2 -0
  37. package/front_end/models/javascript_metadata/NativeFunctions.ts +0 -4
  38. package/front_end/models/trace/LanternComputationData.ts +4 -0
  39. package/front_end/models/trace/lantern/metrics/LargestContentfulPaint.ts +126 -1
  40. package/front_end/models/trace/lantern/types/Lantern.ts +3 -0
  41. package/front_end/panels/ai_assistance/AiAssistancePanel.ts +33 -1
  42. package/front_end/panels/ai_assistance/ExternalHandler.ts +1 -1
  43. package/front_end/panels/ai_assistance/components/ChatInput.ts +2 -0
  44. package/front_end/panels/ai_assistance/components/PermissionPrompt.ts +4 -4
  45. package/front_end/panels/ai_assistance/components/chatInput.css +1 -1
  46. package/front_end/panels/ai_assistance/components/chatMessage.css +3 -4
  47. package/front_end/panels/ai_assistance/components/exploreWidget.css +3 -3
  48. package/front_end/panels/animation/animationTimeline.css +11 -9
  49. package/front_end/panels/application/IndexedDBViews.ts +2 -2
  50. package/front_end/panels/application/PrivateVerificationTokensView.ts +217 -9
  51. package/front_end/panels/application/ServiceWorkerCacheViews.ts +1 -1
  52. package/front_end/panels/application/ServiceWorkersView.ts +1 -1
  53. package/front_end/panels/application/StorageView.ts +1 -1
  54. package/front_end/panels/application/appManifestView.css +0 -6
  55. package/front_end/panels/application/backgroundServiceView.css +0 -21
  56. package/front_end/panels/application/components/backForwardCacheView.css +1 -9
  57. package/front_end/panels/application/components/endpointsGrid.css +1 -1
  58. package/front_end/panels/application/components/permissionsPolicySection.css +1 -1
  59. package/front_end/panels/application/components/reportsGrid.css +1 -1
  60. package/front_end/panels/application/components/serviceWorkerRouterView.css +2 -2
  61. package/front_end/panels/application/components/trustTokensView.css +1 -1
  62. package/front_end/panels/application/cookieItemsView.css +0 -1
  63. package/front_end/panels/application/frameDetailsReportView.css +0 -10
  64. package/front_end/panels/application/indexedDBViews.css +0 -10
  65. package/front_end/panels/application/privateVerificationTokensView.css +12 -0
  66. package/front_end/panels/application/resourcesPanel.css +0 -23
  67. package/front_end/panels/application/serviceWorkerUpdateCycleView.css +7 -7
  68. package/front_end/panels/application/serviceWorkersView.css +4 -3
  69. package/front_end/panels/changes/CombinedDiffView.ts +1 -1
  70. package/front_end/panels/comments/CommentsPane.ts +7 -11
  71. package/front_end/panels/common/CommentThreadWidget.ts +11 -3
  72. package/front_end/panels/common/CommentsOverlayWidget.ts +337 -117
  73. package/front_end/panels/console/consoleContextSelector.css +1 -1
  74. package/front_end/panels/console/consolePinPane.css +1 -1
  75. package/front_end/panels/console/consolePrompt.css +4 -2
  76. package/front_end/panels/console/consoleView.css +5 -3
  77. package/front_end/panels/coverage/CoverageView.ts +0 -1
  78. package/front_end/panels/coverage/coverageView.css +4 -3
  79. package/front_end/panels/css_overview/CSSOverviewCompletedView.ts +0 -1
  80. package/front_end/panels/elements/AccessibilityTreeView.ts +1 -1
  81. package/front_end/panels/elements/CSSValueTraceView.ts +2 -4
  82. package/front_end/panels/elements/ComputedStyleWidget.ts +8 -19
  83. package/front_end/panels/elements/DOMTreeContextMenu.ts +1 -1
  84. package/front_end/panels/elements/DOMTreeWidget.ts +14 -0
  85. package/front_end/panels/elements/MetricsSidebarPane.ts +1 -1
  86. package/front_end/panels/elements/PlatformFontsWidget.ts +0 -1
  87. package/front_end/panels/elements/PropertiesWidget.ts +1 -1
  88. package/front_end/panels/elements/PropertyRenderer.ts +7 -27
  89. package/front_end/panels/elements/StylePropertyTreeElement.ts +61 -72
  90. package/front_end/panels/elements/StylesSidebarPane.ts +2 -0
  91. package/front_end/panels/elements/WebCustomData.ts +1 -1
  92. package/front_end/panels/elements/components/cssHintDetailsView.css +1 -1
  93. package/front_end/panels/elements/components/cssVariableValueView.css +3 -1
  94. package/front_end/panels/elements/components/elementsBreadcrumbs.css +1 -1
  95. package/front_end/panels/elements/components/elementsTreeExpandButton.css +3 -2
  96. package/front_end/panels/elements/components/stylePropertyEditor.css +2 -2
  97. package/front_end/panels/elements/layoutPane.css +1 -1
  98. package/front_end/panels/elements/metricsSidebarPane.css +6 -6
  99. package/front_end/panels/elements/platformFontsWidget.css +1 -1
  100. package/front_end/panels/elements/propertiesWidget.css +0 -5
  101. package/front_end/panels/elements/stylesSidebarPane.css +1 -1
  102. package/front_end/panels/emulation/DeviceModeView.ts +4 -3
  103. package/front_end/panels/emulation/deviceModeView.css +9 -10
  104. package/front_end/panels/event_listeners/eventListenersView.css +5 -5
  105. package/front_end/panels/explain/components/consoleInsight.css +5 -20
  106. package/front_end/panels/issues/issuesTree.css +11 -10
  107. package/front_end/panels/layer_viewer/LayerDetailsView.ts +4 -2
  108. package/front_end/panels/layer_viewer/TransformController.ts +106 -54
  109. package/front_end/panels/layer_viewer/layerTreeOutline.css +1 -1
  110. package/front_end/panels/lighthouse/lighthousePanel.css +5 -8
  111. package/front_end/panels/lighthouse/lighthouseStartView.css +1 -2
  112. package/front_end/panels/linear_memory_inspector/components/linearMemoryHighlightChipList.css +4 -4
  113. package/front_end/panels/linear_memory_inspector/components/valueInterpreterDisplay.css +1 -1
  114. package/front_end/panels/media/EventTimelineView.ts +1 -4
  115. package/front_end/panels/media/TickingFlameChart.ts +3 -2
  116. package/front_end/panels/media/playerListView.css +14 -7
  117. package/front_end/panels/media/playerMessagesView.css +11 -7
  118. package/front_end/panels/mobile_throttling/ThrottlingSettingsTab.ts +1 -1
  119. package/front_end/panels/mobile_throttling/throttlingSettingsTab.css +5 -7
  120. package/front_end/panels/network/NetworkConfigView.ts +1 -1
  121. package/front_end/panels/network/NetworkWaterfallColumn.ts +92 -55
  122. package/front_end/panels/network/binaryResourceView.css +0 -7
  123. package/front_end/panels/network/networkConfigView.css +3 -3
  124. package/front_end/panels/network/networkLogView.css +5 -11
  125. package/front_end/panels/network/networkManageCustomHeadersView.css +1 -1
  126. package/front_end/panels/network/networkTimingTable.css +6 -6
  127. package/front_end/panels/network/requestConditionsDrawer.css +1 -24
  128. package/front_end/panels/network/requestPayloadView.css +1 -1
  129. package/front_end/panels/performance_monitor/PerformanceMonitor.ts +1 -1
  130. package/front_end/panels/performance_monitor/performanceMonitor.css +2 -2
  131. package/front_end/panels/profiler/ModuleUIStrings.ts +12 -0
  132. package/front_end/panels/protocol_monitor/JSONEditor.css +4 -3
  133. package/front_end/panels/protocol_monitor/JSONEditor.ts +1 -1
  134. package/front_end/panels/protocol_monitor/protocolMonitor.css +1 -1
  135. package/front_end/panels/recorder/createRecordingView.css +2 -2
  136. package/front_end/panels/recorder/extensionView.css +1 -1
  137. package/front_end/panels/recorder/recorderPanel.css +3 -3
  138. package/front_end/panels/recorder/recordingListView.css +1 -1
  139. package/front_end/panels/recorder/stepEditor.css +2 -2
  140. package/front_end/panels/recorder/stepView.css +0 -31
  141. package/front_end/panels/recorder/timelineSection.css +1 -1
  142. package/front_end/panels/screencast/screencastView.css +3 -2
  143. package/front_end/panels/search/searchView.css +4 -3
  144. package/front_end/panels/security/SecurityPanelSidebar.ts +0 -1
  145. package/front_end/panels/security/mainView.css +2 -2
  146. package/front_end/panels/security/originView.css +1 -5
  147. package/front_end/panels/settings/FrameworkIgnoreListSettingsTab.ts +2 -1
  148. package/front_end/panels/sources/WatchExpressionsSidebarPane.ts +1 -2
  149. package/front_end/panels/sources/breakpointsView.css +3 -4
  150. package/front_end/panels/sources/tabbedEditorContainer.css +1 -1
  151. package/front_end/panels/sources/watchExpressionsSidebarPane.css +4 -3
  152. package/front_end/panels/timeline/CompatibilityTracksAppender.ts +30 -10
  153. package/front_end/panels/timeline/TimelineSelectorStatsView.ts +1 -1
  154. package/front_end/panels/timeline/components/OriginMap.ts +1 -1
  155. package/front_end/panels/timeline/components/fieldSettingsDialog.css +1 -1
  156. package/front_end/panels/timeline/components/metricCard.css +1 -1
  157. package/front_end/panels/timeline/components/networkRequestDetails.css +0 -1
  158. package/front_end/panels/timeline/components/networkRequestTooltip.css +4 -4
  159. package/front_end/panels/timeline/components/relatedInsightChips.css +1 -1
  160. package/front_end/panels/timeline/timelineFlameChartView.css +4 -4
  161. package/front_end/panels/timeline/timelineFlamechartPopover.css +3 -3
  162. package/front_end/panels/timeline/timelineHistoryManager.css +1 -1
  163. package/front_end/panels/timeline/timelineMiniMap.css +3 -2
  164. package/front_end/panels/timeline/timelineStatusDialog.css +1 -1
  165. package/front_end/panels/web_audio/webAudio.css +0 -20
  166. package/front_end/third_party/chromium/README.chromium +1 -1
  167. package/front_end/ui/comments/CommentAnchorResolver.ts +166 -8
  168. package/front_end/ui/comments/CommentOverlayManager.ts +17 -2
  169. package/front_end/ui/components/buttons/button.css +0 -1
  170. package/front_end/ui/components/diff_view/diffView.css +2 -2
  171. package/front_end/ui/components/markdown_view/codeBlock.css +3 -3
  172. package/front_end/ui/components/markdown_view/markdownView.css +3 -3
  173. package/front_end/ui/components/menus/Menu.ts +1 -1
  174. package/front_end/ui/components/menus/menuItem.css +1 -1
  175. package/front_end/ui/components/panel_feedback/panelFeedback.css +5 -4
  176. package/front_end/ui/components/panel_introduction_steps/panelIntroductionSteps.css +1 -1
  177. package/front_end/ui/components/report_view/reportValue.css +5 -2
  178. package/front_end/ui/components/suggestion_input/suggestionInput.css +6 -6
  179. package/front_end/ui/legacy/ContextMenu.ts +3 -0
  180. package/front_end/ui/legacy/GlassPane.ts +3 -3
  181. package/front_end/ui/legacy/SoftContextMenu.ts +7 -1
  182. package/front_end/ui/legacy/components/data_grid/DataGrid.ts +2 -0
  183. package/front_end/ui/legacy/components/inline_editor/bezierEditor.css +7 -6
  184. package/front_end/ui/legacy/components/inline_editor/colorSwatch.css +1 -2
  185. package/front_end/ui/legacy/components/inline_editor/cssAngleEditor.css +3 -3
  186. package/front_end/ui/legacy/components/perf_ui/chartViewport.css +1 -1
  187. package/front_end/ui/legacy/components/perf_ui/filmStripView.css +1 -1
  188. package/front_end/ui/legacy/components/perf_ui/flameChart.css +12 -9
  189. package/front_end/ui/legacy/components/perf_ui/overviewGrid.css +11 -7
  190. package/front_end/ui/legacy/components/perf_ui/pieChart.css +3 -4
  191. package/front_end/ui/legacy/components/source_frame/imageView.css +4 -4
  192. package/front_end/ui/legacy/components/utils/imagePreview.css +1 -1
  193. package/front_end/ui/legacy/components/utils/jsUtils.css +2 -1
  194. package/front_end/ui/legacy/dropTarget.css +1 -1
  195. package/front_end/ui/legacy/filter.css +4 -3
  196. package/front_end/ui/legacy/inspectorCommon.css +16 -48
  197. package/front_end/ui/legacy/inspectorDrawerTabbedPane.css +1 -1
  198. package/front_end/ui/legacy/progressIndicator.css +1 -2
  199. package/front_end/ui/legacy/reportView.css +4 -1
  200. package/front_end/ui/legacy/searchableView.css +1 -1
  201. package/front_end/ui/legacy/suggestBox.css +2 -1
  202. package/front_end/ui/legacy/tabbedPane.css +7 -4
  203. package/front_end/ui/legacy/toolbar.css +2 -1
  204. package/front_end/ui/legacy/treeoutline.css +6 -5
  205. package/front_end/ui/legacy/viewContainers.css +3 -2
  206. package/front_end/ui/visual_logging/KnownContextValues.ts +15 -0
  207. package/inspector_overlay/highlight_anchor.ts +8 -11
  208. package/package.json +1 -1
  209. package/front_end/models/ai_code_completion/debug.ts +0 -33
  210. package/front_end/models/ai_code_generation/debug.ts +0 -33
@@ -57,7 +57,7 @@
57
57
  devtools-toolbar {
58
58
  overflow: hidden;
59
59
  flex: 0 100000 auto;
60
- padding: 0 5px;
60
+ padding: 0 var(--sys-size-3);
61
61
 
62
62
  &[wrappable] {
63
63
  height: var(--toolbar-height);
@@ -158,7 +158,7 @@ devtools-toolbar.device-mode-toolbar-options {
158
158
  }
159
159
 
160
160
  .device-mode-content-clip .device-mode-screen-area {
161
- --override-screen-area-box-shadow: hsl(240deg 3% 84%) 0 0 0 0.5px, hsl(0deg 0% 80% / 40%) 0 0 var(--sys-size-9);
161
+ --override-screen-area-box-shadow: hsl(240deg 3% 84% / 50%) 0 0 0 var(--sys-size-1), hsl(0deg 0% 80% / 40%) 0 0 var(--sys-size-9);
162
162
 
163
163
  box-shadow: var(--override-screen-area-box-shadow);
164
164
  }
@@ -222,7 +222,6 @@ devtools-toolbar.device-mode-toolbar-options {
222
222
  /* stylelint-disable-next-line custom-property-pattern */
223
223
  content: var(--image-file-resizeHorizontal);
224
224
  width: var(--sys-size-4);
225
- height: 26px;
226
225
  }
227
226
 
228
227
  .device-mode-left-resizer > div {
@@ -236,16 +235,15 @@ devtools-toolbar.device-mode-toolbar-options {
236
235
  /* stylelint-disable-next-line custom-property-pattern */
237
236
  content: var(--image-file-resizeVertical);
238
237
  margin-bottom: calc(-1 * var(--sys-size-2));
239
- width: 26px;
240
238
  height: var(--sys-size-4);
241
239
  }
242
240
 
243
241
  .device-mode-bottom-right-resizer > div {
244
242
  position: absolute;
245
- bottom: 3px;
246
- right: 3px;
247
- width: 13px;
248
- height: 13px;
243
+ bottom: var(--sys-size-3);
244
+ right: var(--sys-size-3);
245
+ width: var(--sys-size-6);
246
+ height: var(--sys-size-6);
249
247
  /* stylelint-disable-next-line custom-property-pattern */
250
248
  content: var(--image-file-resizeDiagonal);
251
249
  }
@@ -318,7 +316,8 @@ devtools-toolbar.device-mode-toolbar-options {
318
316
  }
319
317
 
320
318
  .device-mode-ruler-left .device-mode-ruler-inner {
321
- inset: 19px 0 0;
319
+ /* Offset by the 20px ruler track (--sys-size-9) minus the parent's 1px top border (--sys-size-1) to align with the viewport top edge. */
320
+ inset: calc(var(--sys-size-9) - var(--sys-size-1)) 0 0;
322
321
  border-right: var(--sys-size-1) solid var(--sys-color-token-subtle);
323
322
  background-color: var(--sys-color-cdt-base-container);
324
323
  }
@@ -336,7 +335,7 @@ devtools-toolbar.device-mode-toolbar-options {
336
335
  }
337
336
 
338
337
  .device-mode-ruler-top .device-mode-ruler-marker.device-mode-ruler-marker-medium {
339
- height: 10px;
338
+ height: var(--sys-size-5);
340
339
  }
341
340
 
342
341
  .device-mode-ruler-top .device-mode-ruler-marker.device-mode-ruler-marker-large {
@@ -5,7 +5,7 @@
5
5
  */
6
6
 
7
7
  .tree-outline-disclosure li {
8
- padding: 0 0 0 5px;
8
+ padding: 0 0 0 var(--sys-size-3);
9
9
  overflow: hidden;
10
10
  display: flex;
11
11
  min-height: var(--sys-size-8);
@@ -44,17 +44,17 @@
44
44
 
45
45
  .event-listener-tree-subtitle {
46
46
  float: right;
47
- margin-left: 5px;
47
+ margin-left: var(--sys-size-3);
48
48
  flex-shrink: 0;
49
49
  }
50
50
 
51
51
  .event-listener-button {
52
- padding: 0 5px;
52
+ padding: 0 var(--sys-size-3);
53
53
  color: var(--sys-color-primary);
54
54
  background-color: var(--sys-color-cdt-base-container);
55
- border-radius: 7px;
55
+ border-radius: var(--sys-shape-corner-full);
56
56
  border: var(--sys-size-1) solid var(--sys-color-tonal-outline);
57
- margin-left: 5px;
57
+ margin-left: var(--sys-size-3);
58
58
  display: block;
59
59
  flex-shrink: 0;
60
60
 
@@ -59,11 +59,6 @@
59
59
  border-radius: var(--sys-shape-corner-medium) var(--sys-shape-corner-medium) var(--sys-shape-corner-extra-small) var(--sys-shape-corner-extra-small);
60
60
  }
61
61
 
62
- .wrapper.bottom {
63
- margin-top: 5px;
64
- border-radius: var(--sys-shape-corner-extra-small) var(--sys-shape-corner-extra-small) var(--sys-shape-corner-medium) var(--sys-shape-corner-medium);
65
- }
66
-
67
62
  header {
68
63
  display: flex;
69
64
  flex-direction: row;
@@ -192,16 +187,6 @@
192
187
  gap: var(--sys-size-5);
193
188
  }
194
189
 
195
- textarea {
196
- height: 84px;
197
- padding: 10px;
198
- border-radius: var(--sys-shape-corner-small);
199
- border: var(--sys-size-1) solid var(--sys-color-neutral-outline);
200
- width: 100%;
201
- font-family: var(--default-font-family);
202
- font-size: inherit;
203
- }
204
-
205
190
  .buttons {
206
191
  display: flex;
207
192
  gap: 5px;
@@ -274,7 +259,7 @@
274
259
 
275
260
  details {
276
261
  overflow: hidden;
277
- margin-top: 10px;
262
+ margin-top: var(--sys-size-6);
278
263
  }
279
264
 
280
265
  ::details-content {
@@ -329,8 +314,8 @@
329
314
  .header-icon-container {
330
315
  background: linear-gradient(135deg, var(--sys-color-gradient-primary), var(--sys-color-gradient-tertiary));
331
316
  border-radius: var(--sys-size-4);
332
- height: 36px;
333
- width: 36px;
317
+ height: var(--sys-size-13);
318
+ width: var(--sys-size-13);
334
319
  display: flex;
335
320
  align-items: center;
336
321
  justify-content: center;
@@ -383,7 +368,7 @@
383
368
  }
384
369
 
385
370
  details h3 {
386
- font-size: 10px;
371
+ font-size: var(--sys-typescale-body5-size);
387
372
  font-weight: var(--ref-typeface-weight-medium);
388
373
  text-transform: uppercase;
389
374
  color: var(--sys-color-on-surface-subtle);
@@ -408,7 +393,7 @@
408
393
  font-style: normal;
409
394
  font-weight: 400;
410
395
  line-height: 18px;
411
- margin-top: var(--sys-size-5);
396
+ margin-top: var(--sys-size-6);
412
397
  padding-left: var(--sys-size-6);
413
398
  }
414
399
 
@@ -33,7 +33,9 @@
33
33
  }
34
34
 
35
35
  .issues li.parent::before {
36
- margin-top: 7px;
36
+ /* Center the 16px chevron on the 20px leading issue icon:
37
+ 4px header padding + 2px header child margin + (20px - 16px) / 2 = 8px. */
38
+ margin-top: var(--sys-size-5);
37
39
  }
38
40
 
39
41
  .issues .affected-resources li.parent::before {
@@ -144,8 +146,8 @@ p {
144
146
  border-bottom: var(--sys-size-1) solid var(--sys-color-divider);
145
147
  padding: var(--sys-size-4) 0;
146
148
  position: relative;
147
- padding-left: calc(var(--issue-indent) + 43px);
148
- padding-bottom: 26px;
149
+ padding-left: calc(var(--issue-indent) + var(--sys-size-14));
150
+ padding-bottom: var(--sys-size-11);
149
151
  padding-right: var(--sys-size-5);
150
152
  }
151
153
 
@@ -161,7 +163,8 @@ p {
161
163
  content: "";
162
164
  display: block;
163
165
  position: absolute;
164
- left: calc(var(--issue-indent) + 23px);
166
+ /* Align with .leading-issue-icon left edge: --issue-indent + 16px disclosure arrow (--sys-size-8) + 7px icon margin-left (--sys-size-5 - --sys-size-1). */
167
+ left: calc(var(--issue-indent) + var(--sys-size-8) + var(--sys-size-5) - var(--sys-size-1));
165
168
  top: 0;
166
169
  bottom: var(--sys-size-9);
167
170
  width: var(--sys-size-2);
@@ -184,7 +187,8 @@ p {
184
187
  }
185
188
 
186
189
  devtools-icon.leading-issue-icon {
187
- margin: var(--sys-size-1) 0 calc(-1 * var(--sys-size-1)) 7px;
190
+ /* 8px (--sys-size-5) minus 1px (--sys-size-1) aligns the 20px icon after the 16px disclosure arrow with the 23px .issue-body::before border and 43px body indent. */
191
+ margin: var(--sys-size-1) 0 calc(-1 * var(--sys-size-1)) calc(var(--sys-size-5) - var(--sys-size-1));
188
192
  }
189
193
 
190
194
  .message {
@@ -290,7 +294,6 @@ ul > li.plain-enum::before {
290
294
 
291
295
  .affected-resource-label {
292
296
  font-size: var(--sys-typescale-body4-size);
293
- line-height: 18px;
294
297
  color: var(--sys-color-on-surface);
295
298
  position: relative;
296
299
  cursor: pointer;
@@ -298,7 +301,6 @@ ul > li.plain-enum::before {
298
301
 
299
302
  .affected-resource-cookie {
300
303
  font-size: var(--sys-typescale-body4-size);
301
- line-height: 18px;
302
304
  border: 0;
303
305
  border-collapse: collapse;
304
306
  }
@@ -320,14 +322,12 @@ ul > li.plain-enum::before {
320
322
 
321
323
  .affected-resource-mixed-content {
322
324
  font-size: var(--sys-typescale-body4-size);
323
- line-height: 18px;
324
325
  border: 0;
325
326
  border-collapse: collapse;
326
327
  }
327
328
 
328
329
  .affected-resource-heavy-ad {
329
330
  font-size: var(--sys-typescale-body4-size);
330
- line-height: 18px;
331
331
  border: 0;
332
332
  border-collapse: collapse;
333
333
  }
@@ -427,7 +427,8 @@ ul > li.plain-enum::before {
427
427
  }
428
428
 
429
429
  .aggregated-issues-count {
430
- padding: 3px 7px 0;
430
+ /* Center the 14px (--sys-size-7) adorner pill vertically against the 20px (--sys-size-9) issue icon. */
431
+ padding: calc((var(--sys-size-9) - var(--sys-size-7)) / 2) var(--sys-size-4) 0;
431
432
  }
432
433
 
433
434
  .affected-resource-directive-info-header {
@@ -157,7 +157,9 @@ export const DEFAULT_VIEW = (input: ViewInput, _output: ViewOutput, target: Docu
157
157
 
158
158
  if (!layer) {
159
159
  // clang-format off
160
- Lit.render(html`<div class="layer-details-container">
160
+ Lit.render(html`
161
+ <style>${layerDetailsViewStyles}</style>
162
+ <div class="layer-details-container">
161
163
  <devtools-widget class="learn-more" ${widget(UI.EmptyWidget.EmptyWidget, {
162
164
  header: i18nString(UIStrings.noLayerSelected),
163
165
  text: i18nString(UIStrings.selectALayerToSeeItsDetails)})}>
@@ -220,6 +222,7 @@ export const DEFAULT_VIEW = (input: ViewInput, _output: ViewOutput, target: Docu
220
222
  // clang-format off
221
223
  Lit.render(
222
224
  html`
225
+ <style>${layerDetailsViewStyles}</style>
223
226
  <div class="layer-details-container"
224
227
  data-backend-node-id=${domNode ? domNode.backendNodeId() : nothing}
225
228
  data-target-id=${domNode ? domNode.domModel().target().id() : nothing}
@@ -296,7 +299,6 @@ export class LayerDetailsView extends LayerDetailsViewBase implements LayerView
296
299
  constructor(layerViewHost: LayerViewHost, view: typeof DEFAULT_VIEW = DEFAULT_VIEW) {
297
300
  super({useShadowDom: 'pure'});
298
301
  this.view = view;
299
- this.registerRequiredCSS(layerDetailsViewStyles);
300
302
  this.layerViewHost = layerViewHost;
301
303
  this.layerViewHost.registerView(this);
302
304
  this.layerSnapshotMap = this.layerViewHost.getLayerSnapshotMap();
@@ -1,34 +1,97 @@
1
1
  // Copyright 2014 The Chromium Authors
2
2
  // Use of this source code is governed by a BSD-style license that can be
3
3
  // found in the LICENSE file.
4
- /* eslint-disable @devtools/no-imperative-dom-api */
5
4
 
6
5
  import '../../ui/legacy/legacy.js';
7
6
 
8
7
  import * as Common from '../../core/common/common.js';
9
8
  import * as i18n from '../../core/i18n/i18n.js';
10
9
  import * as Platform from '../../core/platform/platform.js';
10
+ import * as Buttons from '../../ui/components/buttons/buttons.js';
11
11
  import * as UI from '../../ui/legacy/legacy.js';
12
+ import {html, nothing, render} from '../../ui/lit/lit.js';
12
13
  import * as VisualLogging from '../../ui/visual_logging/visual_logging.js';
13
14
 
14
15
  const UIStrings = {
15
16
  /**
16
- * @description Tooltip text that appears when hovering over largeicon pan button in transform controller of the Layers panel.
17
+ * @description Tooltip text that appears when hovering over largeicon pan
18
+ * button in transform controller of the Layers panel.
17
19
  */
18
20
  panModeX: 'Pan mode (X)',
19
21
  /**
20
- * @description Tooltip text that appears when hovering over largeicon rotate button in transform controller of the Layers panel.
22
+ * @description Tooltip text that appears when hovering over largeicon rotate
23
+ * button in transform controller of the Layers panel.
21
24
  */
22
25
  rotateModeV: 'Rotate mode (V)',
23
26
  /**
24
- * @description Tooltip text that appears when hovering over the largeicon center button in the transform controller of the Layers panel.
27
+ * @description Tooltip text that appears when hovering over the largeicon
28
+ * center button in the transform controller of the Layers panel.
25
29
  */
26
30
  resetTransform: 'Reset transform (0)',
27
31
  } as const;
28
32
  const str_ = i18n.i18n.registerUIStrings('panels/layer_viewer/TransformController.ts', UIStrings);
29
33
  const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
34
+
35
+ export interface ViewInput {
36
+ disableRotate: boolean;
37
+ mode: Modes;
38
+ onSetMode: (mode: Modes) => void;
39
+ onReset: () => void;
40
+ }
41
+
42
+ export type View = (input: ViewInput, output: undefined, target: HTMLElement) => void;
43
+
44
+ export const DEFAULT_VIEW: View = (input, _output, target) => {
45
+ // clang-format off
46
+ render(html`
47
+ ${!input.disableRotate ? html`
48
+ <devtools-button
49
+ class="toolbar-button"
50
+ title=${i18nString(UIStrings.panModeX)}
51
+ jslog=${VisualLogging.toggle().track({click: true}).context('layers.3d-pan')}
52
+ .iconName=${'3d-pan'}
53
+ .toggledIconName=${'3d-pan'}
54
+ .toggleType=${Buttons.Button.ToggleType.PRIMARY}
55
+ .toggleOnClick=${false}
56
+ .toggled=${input.mode === Modes.PAN}
57
+ .variant=${Buttons.Button.Variant.ICON_TOGGLE}
58
+ @click=${() => input.onSetMode(Modes.PAN)}>
59
+ </devtools-button>
60
+ <devtools-button
61
+ class="toolbar-button"
62
+ title=${i18nString(UIStrings.rotateModeV)}
63
+ jslog=${VisualLogging.toggle().track({click: true}).context('layers.3d-rotate')}
64
+ .iconName=${'3d-rotate'}
65
+ .toggledIconName=${'3d-rotate'}
66
+ .toggleType=${Buttons.Button.ToggleType.PRIMARY}
67
+ .toggleOnClick=${false}
68
+ .toggled=${input.mode === Modes.ROTATE}
69
+ .variant=${Buttons.Button.Variant.ICON_TOGGLE}
70
+ @click=${() => input.onSetMode(Modes.ROTATE)}>
71
+ </devtools-button>
72
+ ` : nothing}
73
+ <devtools-button
74
+ class="toolbar-button"
75
+ title=${i18nString(UIStrings.resetTransform)}
76
+ .iconName=${'3d-center'}
77
+ .jslogContext=${'layers.3d-center'}
78
+ .variant=${Buttons.Button.Variant.TOOLBAR}
79
+ @click=${(event: Event) => {
80
+ event.preventDefault();
81
+ input.onReset();
82
+ }}>
83
+ </devtools-button>
84
+ `, target, {
85
+ container: {
86
+ classes: ['transform-control-panel'],
87
+ attributes: {jslog: `${VisualLogging.toolbar()}`},
88
+ },
89
+ });
90
+ // clang-format on
91
+ };
92
+
30
93
  export class TransformController extends Common.ObjectWrapper.ObjectWrapper<EventTypes> {
31
- private mode!: Modes;
94
+ private mode: Modes = Modes.PAN;
32
95
  #scale: number;
33
96
  #offsetX: number;
34
97
  #offsetY: number;
@@ -41,15 +104,22 @@ export class TransformController extends Common.ObjectWrapper.ObjectWrapper<Even
41
104
  element: HTMLElement;
42
105
  private minScale: number;
43
106
  private maxScale: number;
44
- private readonly controlPanelToolbar: UI.Toolbar.Toolbar;
45
- private readonly modeButtons: Record<string, UI.Toolbar.ToolbarToggle>;
107
+ readonly #disableRotate: boolean;
108
+ readonly #controlPanelToolbar = new UI.Toolbar.Toolbar();
109
+ readonly #view: View;
46
110
  /**
47
111
  * @param element The HTML element to apply transformations to.
48
- * @param disableRotate Optional. If true, pan and rotate will be disabled. Defaults to false.
49
- * @param preventDefaultOnMousedown Optional. If true, mousedown events will be prevented from their default behavior (including focus). Defaults to true.
112
+ * @param disableRotate Optional. If true, pan and rotate will be disabled.
113
+ * Defaults to false.
114
+ * @param preventDefaultOnMousedown Optional. If true, mousedown events will
115
+ * be prevented from their default behavior (including focus). Defaults to
116
+ * true.
50
117
  */
51
- constructor(element: HTMLElement, disableRotate?: boolean, preventDefaultOnMouseDown = true) {
118
+ constructor(element: HTMLElement, disableRotate?: boolean, preventDefaultOnMouseDown = true,
119
+ view: View = DEFAULT_VIEW) {
52
120
  super();
121
+ this.#view = view;
122
+ this.#disableRotate = Boolean(disableRotate);
53
123
  this.#scale = 1;
54
124
  this.#offsetX = 0;
55
125
  this.#offsetY = 0;
@@ -61,42 +131,31 @@ export class TransformController extends Common.ObjectWrapper.ObjectWrapper<Even
61
131
  this.originY = 0;
62
132
  this.element = element;
63
133
  this.registerShortcuts();
64
- UI.UIUtils.installDragHandle(
65
- element, this.onDragStart.bind(this), this.onDrag.bind(this), this.onDragEnd.bind(this), 'move', null, 0,
66
- preventDefaultOnMouseDown);
134
+ UI.UIUtils.installDragHandle(element, this.onDragStart.bind(this), this.onDrag.bind(this),
135
+ this.onDragEnd.bind(this), 'move', null, 0, preventDefaultOnMouseDown);
67
136
  element.addEventListener('wheel', this.onMouseWheel.bind(this), false);
68
137
  this.minScale = 0;
69
138
  this.maxScale = Infinity;
70
139
 
71
- this.controlPanelToolbar = document.createElement('devtools-toolbar');
72
- this.controlPanelToolbar.classList.add('transform-control-panel');
73
- this.controlPanelToolbar.setAttribute('jslog', `${VisualLogging.toolbar()}`);
74
-
75
- this.modeButtons = {};
76
- if (!disableRotate) {
77
- const panModeButton = new UI.Toolbar.ToolbarToggle(
78
- i18nString(UIStrings.panModeX), '3d-pan', undefined, 'layers.3d-pan', /* toggleOnClick */ false);
79
- panModeButton.addEventListener(UI.Toolbar.ToolbarButton.Events.CLICK, this.setMode.bind(this, Modes.PAN));
80
- this.modeButtons[Modes.PAN] = panModeButton;
81
- this.controlPanelToolbar.appendToolbarItem(panModeButton);
82
- const rotateModeButton = new UI.Toolbar.ToolbarToggle(
83
- i18nString(UIStrings.rotateModeV), '3d-rotate', undefined, 'layers.3d-rotate', /* toggleOnClick */ false);
84
- rotateModeButton.addEventListener(UI.Toolbar.ToolbarButton.Events.CLICK, this.setMode.bind(this, Modes.ROTATE));
85
- this.modeButtons[Modes.ROTATE] = rotateModeButton;
86
- this.controlPanelToolbar.appendToolbarItem(rotateModeButton);
87
- }
88
- this.setMode(Modes.PAN);
89
-
90
- const resetButton =
91
- new UI.Toolbar.ToolbarButton(i18nString(UIStrings.resetTransform), '3d-center', undefined, 'layers.3d-center');
92
- resetButton.addEventListener(UI.Toolbar.ToolbarButton.Events.CLICK, this.resetAndNotify.bind(this, undefined));
93
- this.controlPanelToolbar.appendToolbarItem(resetButton);
94
-
140
+ this.#performUpdate();
95
141
  this.reset();
96
142
  }
97
143
 
144
+ #performUpdate(): void {
145
+ this.#view(
146
+ {
147
+ disableRotate: this.#disableRotate,
148
+ mode: this.mode,
149
+ onSetMode: this.setMode.bind(this),
150
+ onReset: this.resetAndNotify.bind(this),
151
+ },
152
+ undefined,
153
+ this.#controlPanelToolbar,
154
+ );
155
+ }
156
+
98
157
  toolbar(): UI.Toolbar.Toolbar {
99
- return this.controlPanelToolbar;
158
+ return this.#controlPanelToolbar;
100
159
  }
101
160
 
102
161
  private registerShortcuts(): void {
@@ -140,13 +199,7 @@ export class TransformController extends Common.ObjectWrapper.ObjectWrapper<Even
140
199
  return;
141
200
  }
142
201
  this.mode = mode;
143
- this.updateModeButtons();
144
- }
145
-
146
- private updateModeButtons(): void {
147
- for (const mode in this.modeButtons) {
148
- this.modeButtons[mode].setToggled(mode === this.mode);
149
- }
202
+ this.#performUpdate();
150
203
  }
151
204
 
152
205
  resetAndNotify(event?: Event): void {
@@ -219,9 +272,10 @@ export class TransformController extends Common.ObjectWrapper.ObjectWrapper<Even
219
272
  const rotateStepInDegrees = 5;
220
273
 
221
274
  if (this.mode === Modes.ROTATE) {
222
- // Sic! onRotate treats X and Y as "rotate around X" and "rotate around Y", so swap X/Y multipliers.
223
- this.onRotate(
224
- this.#rotateX + yMultiplier * rotateStepInDegrees, this.#rotateY + xMultiplier * rotateStepInDegrees);
275
+ // Sic! onRotate treats X and Y as "rotate around X" and "rotate around
276
+ // Y", so swap X/Y multipliers.
277
+ this.onRotate(this.#rotateX + yMultiplier * rotateStepInDegrees,
278
+ this.#rotateY + xMultiplier * rotateStepInDegrees);
225
279
  } else {
226
280
  this.onPan(xMultiplier * panStepInPixels, yMultiplier * panStepInPixels);
227
281
  }
@@ -235,17 +289,15 @@ export class TransformController extends Common.ObjectWrapper.ObjectWrapper<Even
235
289
  const wheelZoomSpeed = 1 / 53;
236
290
  const mouseEvent = event as WheelEvent;
237
291
  const scaleFactor = Math.pow(zoomFactor, -mouseEvent.deltaY * wheelZoomSpeed);
238
- this.onScale(
239
- scaleFactor, mouseEvent.clientX - this.element.getBoundingClientRect().left,
240
- mouseEvent.clientY - this.element.getBoundingClientRect().top);
292
+ this.onScale(scaleFactor, mouseEvent.clientX - this.element.getBoundingClientRect().left,
293
+ mouseEvent.clientY - this.element.getBoundingClientRect().top);
241
294
  }
242
295
 
243
296
  private onDrag(event: Event): void {
244
297
  const {clientX, clientY} = event as MouseEvent;
245
298
  if (this.mode === Modes.ROTATE) {
246
- this.onRotate(
247
- this.oldRotateX + (this.originY - clientY) / this.element.clientHeight * 180,
248
- this.oldRotateY - (this.originX - clientX) / this.element.clientWidth * 180);
299
+ this.onRotate(this.oldRotateX + (this.originY - clientY) / this.element.clientHeight * 180,
300
+ this.oldRotateY - (this.originX - clientX) / this.element.clientWidth * 180);
249
301
  } else {
250
302
  this.onPan(clientX - this.originX, clientY - this.originY);
251
303
  this.originX = clientX;
@@ -8,7 +8,7 @@
8
8
  .layer-summary {
9
9
  border-top: var(--sys-size-1) solid var(--sys-color-divider);
10
10
  justify-content: space-between;
11
- padding: var(--sys-size-3) 10px;
11
+ padding: var(--sys-size-3) var(--sys-size-5);
12
12
  flex-shrink: 0;
13
13
  }
14
14
 
@@ -15,10 +15,6 @@
15
15
  position: relative;
16
16
  }
17
17
 
18
- button.view-trace {
19
- margin: 10px;
20
- }
21
-
22
18
  /** `window.opener` is null for windows opened from DevTools. This breaks
23
19
  the LH viewer app, so disable this feature. */
24
20
 
@@ -38,9 +34,10 @@ button.view-trace {
38
34
  }
39
35
 
40
36
  select.lighthouse-report {
41
- min-width: 140px;
42
- /* Up to 180px wide, but if window is very small ensure dropdown arrow is visible */
43
- max-width: min(180px, calc(100% - 30px));
37
+ min-width: var(--sys-size-22);
38
+ /* Up to 176px (--sys-size-24) wide; reserve 28px (--sys-size-12)
39
+ in narrow viewports so the dropdown arrow stays visible. */
40
+ max-width: min(var(--sys-size-24), calc(100% - var(--sys-size-12)));
44
41
  }
45
42
 
46
43
  .lighthouse-toolbar-container {
@@ -79,7 +76,7 @@ select.lighthouse-report {
79
76
  }
80
77
 
81
78
  &.lh-active + .lh-tools__dropdown {
82
- clip: rect(calc(-1 * var(--sys-size-5)), 204px, 270px, -10px); /* stylelint-disable-line property-no-deprecated */
79
+ clip: rect(calc(-1 * var(--sys-size-5)), var(--sys-size-26), var(--sys-size-30), calc(-1 * var(--sys-size-6))); /* stylelint-disable-line property-no-deprecated */
83
80
  }
84
81
  }
85
82
 
@@ -59,7 +59,7 @@
59
59
  }
60
60
 
61
61
  .lighthouse-form-section-label {
62
- margin: 7px 0;
62
+ margin: var(--sys-size-5) 0;
63
63
  font-weight: 500;
64
64
  }
65
65
 
@@ -128,7 +128,6 @@
128
128
  color: #f00; /* stylelint-disable-line plugin/use_theme_colors */
129
129
  /* See: crbug.com/1152736 for color variable migration. */
130
130
  font-weight: bold;
131
- padding-left: 10px;
132
131
  }
133
132
 
134
133
  .lighthouse-warning-text {
@@ -45,8 +45,8 @@
45
45
 
46
46
  .delete-highlight-button {
47
47
  cursor: pointer;
48
- width: 13px;
49
- height: 13px;
48
+ width: var(--sys-size-7);
49
+ height: var(--sys-size-7);
50
50
  border: none;
51
51
  background-color: transparent;
52
52
  display: flex;
@@ -71,8 +71,8 @@
71
71
  }
72
72
 
73
73
  .delete-highlight-button devtools-icon {
74
- width: 13px;
75
- height: 13px;
74
+ width: var(--sys-size-7);
75
+ height: var(--sys-size-7);
76
76
  display: flex;
77
77
  align-items: center;
78
78
  justify-content: center;
@@ -41,7 +41,7 @@
41
41
 
42
42
  .signed-divider {
43
43
  width: var(--sys-size-1);
44
- height: 15px;
44
+ height: var(--sys-size-8);
45
45
  background-color: var(--sys-color-divider);
46
46
  margin: 0 var(--sys-size-3);
47
47
  }
@@ -1,7 +1,6 @@
1
1
  // Copyright 2019 The Chromium Authors
2
2
  // Use of this source code is governed by a BSD-style license that can be
3
3
  // found in the LICENSE file.
4
- /* eslint-disable @devtools/no-imperative-dom-api */
5
4
 
6
5
  import * as i18n from '../../core/i18n/i18n.js';
7
6
  import * as VisualLogging from '../../ui/visual_logging/visual_logging.js';
@@ -40,9 +39,7 @@ export class PlayerEventsTimeline extends TickingFlameChart {
40
39
  private videoBufferingStateEvent: Event|null;
41
40
 
42
41
  constructor() {
43
- super();
44
-
45
- this.element.setAttribute('jslog', `${VisualLogging.pane('timeline')}`);
42
+ super({jslog: `${VisualLogging.pane('timeline')}`});
46
43
 
47
44
  this.normalizedTimestamp = NO_NORMALIZED_TIMESTAMP;
48
45
 
@@ -293,8 +293,9 @@ export class TickingFlameChart extends UI.Widget.VBox {
293
293
  readonly #view: TickingFlameChartView;
294
294
  readonly #boundOnScroll = this.onScroll.bind(this);
295
295
 
296
- constructor(element?: HTMLElement, view: TickingFlameChartView = DEFAULT_VIEW) {
297
- super(element);
296
+ constructor(elementOrOptions?: HTMLElement|UI.Widget.WidgetOptions, view: TickingFlameChartView = DEFAULT_VIEW) {
297
+ // @ts-expect-error
298
+ super(elementOrOptions);
298
299
  this.#view = view;
299
300
 
300
301
  // set to update once per second _while the tab is active_
@@ -22,9 +22,12 @@ li.storage-group-list-item::before {
22
22
  }
23
23
 
24
24
  .player-entry-row {
25
- height: 26px;
26
- min-height: 26px;
27
- line-height: 26px;
25
+ /* 28px icon-column/toolbar base (--sys-size-12) minus 2px compact
26
+ * row offset (--sys-size-2) = 26px, matching the 26px child cells
27
+ * and continuous border-right column dividers below. */
28
+ height: calc(var(--sys-size-12) - var(--sys-size-2));
29
+ min-height: calc(var(--sys-size-12) - var(--sys-size-2));
30
+ line-height: calc(var(--sys-size-12) - var(--sys-size-2));
28
31
 
29
32
  &:nth-child(odd) {
30
33
  background: var(--sys-color-surface1);
@@ -80,9 +83,13 @@ li.storage-group-list-item::before {
80
83
  }
81
84
 
82
85
  .player-entry-header {
83
- height: 27px;
84
- line-height: 27px;
85
- min-height: 27px;
86
- padding-left: 10px;
86
+ /* 28px toolbar height (--sys-size-12) minus 1px divider border (--sys-size-1) = 27px,
87
+ * matching .tabbed-pane-header in the adjacent PlayerDetailView split pane. */
88
+ height: calc(var(--sys-size-12) - var(--sys-size-1));
89
+ line-height: calc(var(--sys-size-12) - var(--sys-size-1));
90
+ min-height: calc(var(--sys-size-12) - var(--sys-size-1));
91
+ /* 8px base inline padding (--sys-size-5) plus 2px optical inset (--sys-size-2) = 10px,
92
+ * matching the 10px cell padding of the player rows below. */
93
+ padding-left: calc(var(--sys-size-5) + var(--sys-size-2));
87
94
  border-bottom: var(--sys-size-1) solid var(--sys-color-divider);
88
95
  }