chrome-devtools-frontend 1.0.1730971 → 1.0.1732697

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (210) hide show
  1. package/docs/get_the_code.md +1 -73
  2. package/front_end/Tests.js +15 -0
  3. package/front_end/core/host/AidaClient.ts +47 -3
  4. package/front_end/core/host/AidaClientTypes.ts +27 -3
  5. package/front_end/core/host/AidaGcaTranslation.ts +1 -1
  6. package/front_end/core/sdk/DOMModel.ts +8 -3
  7. package/front_end/core/sdk/NetworkManager.ts +2 -1
  8. package/front_end/entrypoints/formatter_worker/ScopeParser.ts +2 -2
  9. package/front_end/generated/Deprecation.ts +0 -8
  10. package/front_end/generated/InspectorBackendCommands.ts +2 -1
  11. package/front_end/generated/SupportedCSSProperties.ts +2 -2
  12. package/front_end/generated/protocol.ts +9 -0
  13. package/front_end/models/ai-utils/debug.ts +127 -22
  14. package/front_end/models/ai_assistance/README.md +1 -1
  15. package/front_end/models/ai_assistance/agents/AiAgent.ts +10 -5
  16. package/front_end/models/ai_assistance/agents/StylingAgent.snapshot.txt +1 -1
  17. package/front_end/models/ai_assistance/contexts/DOMNodeContext.ts +4 -3
  18. package/front_end/models/ai_assistance/contexts/LighthouseContext.snapshot.txt +9 -2
  19. package/front_end/models/ai_assistance/contexts/LighthouseContext.ts +4 -3
  20. package/front_end/models/ai_assistance/data_formatters/LighthouseFormatter.snapshot.txt +97 -11
  21. package/front_end/models/ai_assistance/data_formatters/LighthouseFormatter.ts +92 -43
  22. package/front_end/models/ai_assistance/data_formatters/PerformanceInsightFormatter.snapshot.txt +1 -1
  23. package/front_end/models/ai_assistance/data_formatters/PerformanceTraceFormatter.snapshot.txt +26 -26
  24. package/front_end/models/ai_assistance/skills/styling.md +4 -2
  25. package/front_end/models/ai_assistance/tools/ExecuteJavaScript.ts +31 -36
  26. package/front_end/models/ai_code_completion/AiCodeCompletion.ts +2 -1
  27. package/front_end/models/ai_code_completion/ai_code_completion.ts +11 -2
  28. package/front_end/models/ai_code_generation/AiCodeGeneration.ts +2 -1
  29. package/front_end/models/ai_code_generation/ai_code_generation.ts +11 -2
  30. package/front_end/models/bindings/CompilerScriptMapping.ts +0 -1
  31. package/front_end/models/bindings/DebuggerLanguagePlugins.ts +0 -1
  32. package/front_end/models/bindings/DebuggerWorkspaceBinding.ts +0 -1
  33. package/front_end/models/har/HARFormat.ts +1 -0
  34. package/front_end/models/har/Importer.ts +7 -1
  35. package/front_end/models/har/Log.snapshot.txt +2 -0
  36. package/front_end/models/har/Log.ts +2 -0
  37. package/front_end/models/javascript_metadata/NativeFunctions.ts +0 -4
  38. package/front_end/models/trace/LanternComputationData.ts +4 -0
  39. package/front_end/models/trace/lantern/metrics/LargestContentfulPaint.ts +126 -1
  40. package/front_end/models/trace/lantern/types/Lantern.ts +3 -0
  41. package/front_end/panels/ai_assistance/AiAssistancePanel.ts +33 -1
  42. package/front_end/panels/ai_assistance/ExternalHandler.ts +1 -1
  43. package/front_end/panels/ai_assistance/components/ChatInput.ts +2 -0
  44. package/front_end/panels/ai_assistance/components/PermissionPrompt.ts +4 -4
  45. package/front_end/panels/ai_assistance/components/chatInput.css +1 -1
  46. package/front_end/panels/ai_assistance/components/chatMessage.css +3 -4
  47. package/front_end/panels/ai_assistance/components/exploreWidget.css +3 -3
  48. package/front_end/panels/animation/animationTimeline.css +11 -9
  49. package/front_end/panels/application/IndexedDBViews.ts +2 -2
  50. package/front_end/panels/application/PrivateVerificationTokensView.ts +217 -9
  51. package/front_end/panels/application/ServiceWorkerCacheViews.ts +1 -1
  52. package/front_end/panels/application/ServiceWorkersView.ts +1 -1
  53. package/front_end/panels/application/StorageView.ts +1 -1
  54. package/front_end/panels/application/appManifestView.css +0 -6
  55. package/front_end/panels/application/backgroundServiceView.css +0 -21
  56. package/front_end/panels/application/components/backForwardCacheView.css +1 -9
  57. package/front_end/panels/application/components/endpointsGrid.css +1 -1
  58. package/front_end/panels/application/components/permissionsPolicySection.css +1 -1
  59. package/front_end/panels/application/components/reportsGrid.css +1 -1
  60. package/front_end/panels/application/components/serviceWorkerRouterView.css +2 -2
  61. package/front_end/panels/application/components/trustTokensView.css +1 -1
  62. package/front_end/panels/application/cookieItemsView.css +0 -1
  63. package/front_end/panels/application/frameDetailsReportView.css +0 -10
  64. package/front_end/panels/application/indexedDBViews.css +0 -10
  65. package/front_end/panels/application/privateVerificationTokensView.css +12 -0
  66. package/front_end/panels/application/resourcesPanel.css +0 -23
  67. package/front_end/panels/application/serviceWorkerUpdateCycleView.css +7 -7
  68. package/front_end/panels/application/serviceWorkersView.css +4 -3
  69. package/front_end/panels/changes/CombinedDiffView.ts +1 -1
  70. package/front_end/panels/comments/CommentsPane.ts +7 -11
  71. package/front_end/panels/common/CommentThreadWidget.ts +11 -3
  72. package/front_end/panels/common/CommentsOverlayWidget.ts +337 -117
  73. package/front_end/panels/console/consoleContextSelector.css +1 -1
  74. package/front_end/panels/console/consolePinPane.css +1 -1
  75. package/front_end/panels/console/consolePrompt.css +4 -2
  76. package/front_end/panels/console/consoleView.css +5 -3
  77. package/front_end/panels/coverage/CoverageView.ts +0 -1
  78. package/front_end/panels/coverage/coverageView.css +4 -3
  79. package/front_end/panels/css_overview/CSSOverviewCompletedView.ts +0 -1
  80. package/front_end/panels/elements/AccessibilityTreeView.ts +1 -1
  81. package/front_end/panels/elements/CSSValueTraceView.ts +2 -4
  82. package/front_end/panels/elements/ComputedStyleWidget.ts +8 -19
  83. package/front_end/panels/elements/DOMTreeContextMenu.ts +1 -1
  84. package/front_end/panels/elements/DOMTreeWidget.ts +14 -0
  85. package/front_end/panels/elements/MetricsSidebarPane.ts +1 -1
  86. package/front_end/panels/elements/PlatformFontsWidget.ts +0 -1
  87. package/front_end/panels/elements/PropertiesWidget.ts +1 -1
  88. package/front_end/panels/elements/PropertyRenderer.ts +7 -27
  89. package/front_end/panels/elements/StylePropertyTreeElement.ts +61 -72
  90. package/front_end/panels/elements/StylesSidebarPane.ts +2 -0
  91. package/front_end/panels/elements/WebCustomData.ts +1 -1
  92. package/front_end/panels/elements/components/cssHintDetailsView.css +1 -1
  93. package/front_end/panels/elements/components/cssVariableValueView.css +3 -1
  94. package/front_end/panels/elements/components/elementsBreadcrumbs.css +1 -1
  95. package/front_end/panels/elements/components/elementsTreeExpandButton.css +3 -2
  96. package/front_end/panels/elements/components/stylePropertyEditor.css +2 -2
  97. package/front_end/panels/elements/layoutPane.css +1 -1
  98. package/front_end/panels/elements/metricsSidebarPane.css +6 -6
  99. package/front_end/panels/elements/platformFontsWidget.css +1 -1
  100. package/front_end/panels/elements/propertiesWidget.css +0 -5
  101. package/front_end/panels/elements/stylesSidebarPane.css +1 -1
  102. package/front_end/panels/emulation/DeviceModeView.ts +4 -3
  103. package/front_end/panels/emulation/deviceModeView.css +9 -10
  104. package/front_end/panels/event_listeners/eventListenersView.css +5 -5
  105. package/front_end/panels/explain/components/consoleInsight.css +5 -20
  106. package/front_end/panels/issues/issuesTree.css +11 -10
  107. package/front_end/panels/layer_viewer/LayerDetailsView.ts +4 -2
  108. package/front_end/panels/layer_viewer/TransformController.ts +106 -54
  109. package/front_end/panels/layer_viewer/layerTreeOutline.css +1 -1
  110. package/front_end/panels/lighthouse/lighthousePanel.css +5 -8
  111. package/front_end/panels/lighthouse/lighthouseStartView.css +1 -2
  112. package/front_end/panels/linear_memory_inspector/components/linearMemoryHighlightChipList.css +4 -4
  113. package/front_end/panels/linear_memory_inspector/components/valueInterpreterDisplay.css +1 -1
  114. package/front_end/panels/media/EventTimelineView.ts +1 -4
  115. package/front_end/panels/media/TickingFlameChart.ts +3 -2
  116. package/front_end/panels/media/playerListView.css +14 -7
  117. package/front_end/panels/media/playerMessagesView.css +11 -7
  118. package/front_end/panels/mobile_throttling/ThrottlingSettingsTab.ts +1 -1
  119. package/front_end/panels/mobile_throttling/throttlingSettingsTab.css +5 -7
  120. package/front_end/panels/network/NetworkConfigView.ts +1 -1
  121. package/front_end/panels/network/NetworkWaterfallColumn.ts +92 -55
  122. package/front_end/panels/network/binaryResourceView.css +0 -7
  123. package/front_end/panels/network/networkConfigView.css +3 -3
  124. package/front_end/panels/network/networkLogView.css +5 -11
  125. package/front_end/panels/network/networkManageCustomHeadersView.css +1 -1
  126. package/front_end/panels/network/networkTimingTable.css +6 -6
  127. package/front_end/panels/network/requestConditionsDrawer.css +1 -24
  128. package/front_end/panels/network/requestPayloadView.css +1 -1
  129. package/front_end/panels/performance_monitor/PerformanceMonitor.ts +1 -1
  130. package/front_end/panels/performance_monitor/performanceMonitor.css +2 -2
  131. package/front_end/panels/profiler/ModuleUIStrings.ts +12 -0
  132. package/front_end/panels/protocol_monitor/JSONEditor.css +4 -3
  133. package/front_end/panels/protocol_monitor/JSONEditor.ts +1 -1
  134. package/front_end/panels/protocol_monitor/protocolMonitor.css +1 -1
  135. package/front_end/panels/recorder/createRecordingView.css +2 -2
  136. package/front_end/panels/recorder/extensionView.css +1 -1
  137. package/front_end/panels/recorder/recorderPanel.css +3 -3
  138. package/front_end/panels/recorder/recordingListView.css +1 -1
  139. package/front_end/panels/recorder/stepEditor.css +2 -2
  140. package/front_end/panels/recorder/stepView.css +0 -31
  141. package/front_end/panels/recorder/timelineSection.css +1 -1
  142. package/front_end/panels/screencast/screencastView.css +3 -2
  143. package/front_end/panels/search/searchView.css +4 -3
  144. package/front_end/panels/security/SecurityPanelSidebar.ts +0 -1
  145. package/front_end/panels/security/mainView.css +2 -2
  146. package/front_end/panels/security/originView.css +1 -5
  147. package/front_end/panels/settings/FrameworkIgnoreListSettingsTab.ts +2 -1
  148. package/front_end/panels/sources/WatchExpressionsSidebarPane.ts +1 -2
  149. package/front_end/panels/sources/breakpointsView.css +3 -4
  150. package/front_end/panels/sources/tabbedEditorContainer.css +1 -1
  151. package/front_end/panels/sources/watchExpressionsSidebarPane.css +4 -3
  152. package/front_end/panels/timeline/CompatibilityTracksAppender.ts +30 -10
  153. package/front_end/panels/timeline/TimelineSelectorStatsView.ts +1 -1
  154. package/front_end/panels/timeline/components/OriginMap.ts +1 -1
  155. package/front_end/panels/timeline/components/fieldSettingsDialog.css +1 -1
  156. package/front_end/panels/timeline/components/metricCard.css +1 -1
  157. package/front_end/panels/timeline/components/networkRequestDetails.css +0 -1
  158. package/front_end/panels/timeline/components/networkRequestTooltip.css +4 -4
  159. package/front_end/panels/timeline/components/relatedInsightChips.css +1 -1
  160. package/front_end/panels/timeline/timelineFlameChartView.css +4 -4
  161. package/front_end/panels/timeline/timelineFlamechartPopover.css +3 -3
  162. package/front_end/panels/timeline/timelineHistoryManager.css +1 -1
  163. package/front_end/panels/timeline/timelineMiniMap.css +3 -2
  164. package/front_end/panels/timeline/timelineStatusDialog.css +1 -1
  165. package/front_end/panels/web_audio/webAudio.css +0 -20
  166. package/front_end/third_party/chromium/README.chromium +1 -1
  167. package/front_end/ui/comments/CommentAnchorResolver.ts +166 -8
  168. package/front_end/ui/comments/CommentOverlayManager.ts +17 -2
  169. package/front_end/ui/components/buttons/button.css +0 -1
  170. package/front_end/ui/components/diff_view/diffView.css +2 -2
  171. package/front_end/ui/components/markdown_view/codeBlock.css +3 -3
  172. package/front_end/ui/components/markdown_view/markdownView.css +3 -3
  173. package/front_end/ui/components/menus/Menu.ts +1 -1
  174. package/front_end/ui/components/menus/menuItem.css +1 -1
  175. package/front_end/ui/components/panel_feedback/panelFeedback.css +5 -4
  176. package/front_end/ui/components/panel_introduction_steps/panelIntroductionSteps.css +1 -1
  177. package/front_end/ui/components/report_view/reportValue.css +5 -2
  178. package/front_end/ui/components/suggestion_input/suggestionInput.css +6 -6
  179. package/front_end/ui/legacy/ContextMenu.ts +3 -0
  180. package/front_end/ui/legacy/GlassPane.ts +3 -3
  181. package/front_end/ui/legacy/SoftContextMenu.ts +7 -1
  182. package/front_end/ui/legacy/components/data_grid/DataGrid.ts +2 -0
  183. package/front_end/ui/legacy/components/inline_editor/bezierEditor.css +7 -6
  184. package/front_end/ui/legacy/components/inline_editor/colorSwatch.css +1 -2
  185. package/front_end/ui/legacy/components/inline_editor/cssAngleEditor.css +3 -3
  186. package/front_end/ui/legacy/components/perf_ui/chartViewport.css +1 -1
  187. package/front_end/ui/legacy/components/perf_ui/filmStripView.css +1 -1
  188. package/front_end/ui/legacy/components/perf_ui/flameChart.css +12 -9
  189. package/front_end/ui/legacy/components/perf_ui/overviewGrid.css +11 -7
  190. package/front_end/ui/legacy/components/perf_ui/pieChart.css +3 -4
  191. package/front_end/ui/legacy/components/source_frame/imageView.css +4 -4
  192. package/front_end/ui/legacy/components/utils/imagePreview.css +1 -1
  193. package/front_end/ui/legacy/components/utils/jsUtils.css +2 -1
  194. package/front_end/ui/legacy/dropTarget.css +1 -1
  195. package/front_end/ui/legacy/filter.css +4 -3
  196. package/front_end/ui/legacy/inspectorCommon.css +16 -48
  197. package/front_end/ui/legacy/inspectorDrawerTabbedPane.css +1 -1
  198. package/front_end/ui/legacy/progressIndicator.css +1 -2
  199. package/front_end/ui/legacy/reportView.css +4 -1
  200. package/front_end/ui/legacy/searchableView.css +1 -1
  201. package/front_end/ui/legacy/suggestBox.css +2 -1
  202. package/front_end/ui/legacy/tabbedPane.css +7 -4
  203. package/front_end/ui/legacy/toolbar.css +2 -1
  204. package/front_end/ui/legacy/treeoutline.css +6 -5
  205. package/front_end/ui/legacy/viewContainers.css +3 -2
  206. package/front_end/ui/visual_logging/KnownContextValues.ts +15 -0
  207. package/inspector_overlay/highlight_anchor.ts +8 -11
  208. package/package.json +1 -1
  209. package/front_end/models/ai_code_completion/debug.ts +0 -33
  210. package/front_end/models/ai_code_generation/debug.ts +0 -33
@@ -752,41 +752,196 @@ function isClippingOverflow(overflow: string): boolean {
752
752
 
753
753
  interface ClippingAncestor {
754
754
  element: Element;
755
+ occluders: Element[];
755
756
  clipsX: boolean;
756
757
  clipsY: boolean;
757
758
  }
758
759
 
760
+ /**
761
+ * Attribute that marks an element as a sticky occluder: an element that sticks
762
+ * to its scroll container (e.g. a `position: sticky` table header or toolbar)
763
+ * and paints over scrolled content. Comment overlays are clipped against it.
764
+ * Components set it directly so they don't need to depend on this module.
765
+ */
766
+ export const STICKY_OCCLUDER_ATTRIBUTE = 'data-sticky-occluder';
767
+
768
+ /**
769
+ * Sticky occluders collected by the caller's DOM scan (see `setStickyOccluders()`),
770
+ * or null to let the resolver scan the document itself.
771
+ */
772
+ let stickyOccluders: Element[]|null = null;
773
+ let occludersByScrollerCache: Map<Element, Element[]>|null = null;
759
774
  let clippingAncestorsCache = new WeakMap<Element, ClippingAncestor[]>();
760
775
 
776
+ /**
777
+ * Provides the sticky occluders found by a DOM scan the caller already runs, so
778
+ * the resolver does not walk the whole DOM again. CommentOverlayManager collects
779
+ * them in the same pass as `[jslog]` elements during rematching.
780
+ *
781
+ * @param elements Elements with the sticky occluder attribute, or null to make
782
+ * the resolver scan the document itself.
783
+ */
784
+ export function setStickyOccluders(elements: Element[]|null): void {
785
+ stickyOccluders = elements;
786
+ clearClippingAncestorsCache();
787
+ }
788
+
789
+ function isScrollingOverflow(overflow: string): boolean {
790
+ return overflow === 'hidden' || overflow === 'auto' || overflow === 'scroll';
791
+ }
792
+
793
+ function getStickyScroller(occluder: Element, doc: Document, win: Window): Element|null {
794
+ let current = occluder.parentElementOrShadowHost();
795
+ while (current && current !== doc.documentElement && current !== doc.body) {
796
+ const currentStyle = win.getComputedStyle(current);
797
+
798
+ if (isScrollingOverflow(currentStyle.overflowX) || isScrollingOverflow(currentStyle.overflowY)) {
799
+ return current;
800
+ }
801
+
802
+ current = current.parentElementOrShadowHost();
803
+ }
804
+
805
+ return null;
806
+ }
807
+
808
+ function buildOccludersByScrollerMap(doc: Document, win: Window): Map<Element, Element[]> {
809
+ if (occludersByScrollerCache) {
810
+ return occludersByScrollerCache;
811
+ }
812
+
813
+ const result = new Map<Element, Element[]>();
814
+ const occluders = stickyOccluders ?? deepQuerySelectorAll(doc, `[${STICKY_OCCLUDER_ATTRIBUTE}]`);
815
+ for (const occ of occluders) {
816
+ // The provided list can be up to one rematch behind the DOM.
817
+ if (!occ.isConnected) {
818
+ continue;
819
+ }
820
+
821
+ const scroller = getStickyScroller(occ, doc, win);
822
+ if (!scroller) {
823
+ continue;
824
+ }
825
+
826
+ const existingOccluders = result.get(scroller);
827
+ if (existingOccluders) {
828
+ existingOccluders.push(occ);
829
+ } else {
830
+ result.set(scroller, [occ]);
831
+ }
832
+ }
833
+
834
+ occludersByScrollerCache = result;
835
+ return result;
836
+ }
837
+
761
838
  /**
762
839
  * Clears the cached clipping ancestor chains for elements.
763
840
  * Called when DOM mutations or comment rematches occur.
764
841
  */
765
842
  export function clearClippingAncestorsCache(): void {
766
843
  clippingAncestorsCache = new WeakMap<Element, ClippingAncestor[]>();
844
+ occludersByScrollerCache = null;
767
845
  }
768
846
 
769
847
  function getClippingAncestors(element: Element, doc: Document, win: Window): ClippingAncestor[] {
770
848
  const cached = clippingAncestorsCache.get(element);
771
- if (cached && cached.every(item => item.element.isConnected)) {
849
+ if (cached && cached.every(item => item.element.isConnected && item.occluders.every(occ => occ.isConnected))) {
772
850
  return cached;
773
851
  }
774
852
 
775
853
  const ancestors: ClippingAncestor[] = [];
854
+ const allAncestors = new Set<Element>();
855
+
776
856
  let current = element.parentElementOrShadowHost();
777
857
  while (current && current !== doc.documentElement && current !== doc.body) {
858
+ allAncestors.add(current);
778
859
  const style = win.getComputedStyle(current);
779
860
  const clipsX = isClippingOverflow(style.overflowX);
780
861
  const clipsY = isClippingOverflow(style.overflowY);
781
862
  if (clipsX || clipsY) {
782
- ancestors.push({element: current, clipsX, clipsY});
863
+ ancestors.push({element: current, clipsX, clipsY, occluders: []});
783
864
  }
784
865
  current = current.parentElementOrShadowHost();
785
866
  }
867
+
868
+ const occludersByScroller = buildOccludersByScrollerMap(doc, win);
869
+ for (const ancestor of ancestors) {
870
+ const occluders = occludersByScroller.get(ancestor.element);
871
+ if (!occluders) {
872
+ continue;
873
+ }
874
+ // An anchor that is the occluder or sits inside it (e.g. a header cell) is painted by it, not covered.
875
+ ancestor.occluders = occluders.filter(occ => occ !== element && !allAncestors.has(occ));
876
+ }
877
+
786
878
  clippingAncestorsCache.set(element, ancestors);
787
879
  return ancestors;
788
880
  }
789
881
 
882
+ interface Bounds {
883
+ left: number;
884
+ right: number;
885
+ top: number;
886
+ bottom: number;
887
+ }
888
+
889
+ function getCachedRect(element: Element, rectCache?: Map<Element, DOMRect>): DOMRect {
890
+ let rect = rectCache?.get(element);
891
+ if (!rect) {
892
+ rect = element.getBoundingClientRect();
893
+ rectCache?.set(element, rect);
894
+ }
895
+ return rect;
896
+ }
897
+
898
+ /**
899
+ * Trims visible bounds by the sticky occluders of one scroll container.
900
+ *
901
+ * A sticky occluder is an element marked with STICKY_OCCLUDER_ATTRIBUTE that sticks
902
+ * to the edge of its scroll container (e.g. a table header or toolbar) and paints
903
+ * over content scrolled underneath it. That content is not visible, even though it
904
+ * is still inside the scroll container's bounds.
905
+ *
906
+ * - Covers the top edge: the bounds start at the occluder's bottom.
907
+ * - Covers the bottom edge: the bounds end at the occluder's top.
908
+ * - Covers the whole height: returns null.
909
+ * - Sits strictly inside the bounds: ignored, since a rect cannot have a hole.
910
+ *
911
+ * Occluders with no size or no horizontal overlap with the bounds are skipped.
912
+ *
913
+ * @param bounds The visible bounds after clipping against the scroll container.
914
+ * @param occluders The sticky occluders of that scroll container.
915
+ * @param rectCache Optional per-frame cache of element bounding client rects.
916
+ * @returns The trimmed bounds, or null if the occluders cover them completely.
917
+ */
918
+ function trimByStickyOccluders(bounds: Bounds, occluders: Element[], rectCache?: Map<Element, DOMRect>): Bounds|null {
919
+ let {top, bottom} = bounds;
920
+ for (const occ of occluders) {
921
+ const occRect = getCachedRect(occ, rectCache);
922
+ if (occRect.width <= 0 || occRect.height <= 0) {
923
+ continue;
924
+ }
925
+
926
+ if (occRect.right <= bounds.left || occRect.left >= bounds.right) {
927
+ continue;
928
+ }
929
+
930
+ const coversTop = occRect.top <= top && occRect.bottom > top;
931
+ const coversBottom = occRect.top < bottom && occRect.bottom >= bottom;
932
+ if (coversTop && coversBottom) {
933
+ return null;
934
+ }
935
+
936
+ if (coversTop) {
937
+ top = occRect.bottom;
938
+ } else if (coversBottom) {
939
+ bottom = occRect.top;
940
+ }
941
+ }
942
+ return {left: bounds.left, right: bounds.right, top, bottom};
943
+ }
944
+
790
945
  /**
791
946
  * Computes the visible viewport-relative bounding box of an element after clipping against
792
947
  * all ancestor scroll/overflow containers and viewport boundaries across shadow DOM roots.
@@ -833,12 +988,8 @@ export function computeVisibleRect(
833
988
  }
834
989
 
835
990
  const clippingAncestors = getClippingAncestors(element, doc, win);
836
- for (const {element: ancestor, clipsX, clipsY} of clippingAncestors) {
837
- let parentRect = rectCache?.get(ancestor);
838
- if (!parentRect) {
839
- parentRect = ancestor.getBoundingClientRect();
840
- rectCache?.set(ancestor, parentRect);
841
- }
991
+ for (const {element: ancestor, clipsX, clipsY, occluders} of clippingAncestors) {
992
+ const parentRect = getCachedRect(ancestor, rectCache);
842
993
  if (clipsX) {
843
994
  visibleLeft = Math.max(visibleLeft, parentRect.left);
844
995
  visibleRight = Math.min(visibleRight, parentRect.right);
@@ -851,6 +1002,13 @@ export function computeVisibleRect(
851
1002
  if (visibleLeft >= visibleRight || visibleTop >= visibleBottom) {
852
1003
  return null;
853
1004
  }
1005
+
1006
+ const trimmed = trimByStickyOccluders(
1007
+ {left: visibleLeft, right: visibleRight, top: visibleTop, bottom: visibleBottom}, occluders, rectCache);
1008
+ if (!trimmed) {
1009
+ return null;
1010
+ }
1011
+ ({top: visibleTop, bottom: visibleBottom} = trimmed);
854
1012
  }
855
1013
 
856
1014
  const width = visibleRight - visibleLeft;
@@ -22,6 +22,8 @@ import {
22
22
  removeCustomAnchorsMovedListener,
23
23
  resolveCommentAnchor,
24
24
  resolveCommentAnchorElement,
25
+ setStickyOccluders,
26
+ STICKY_OCCLUDER_ATTRIBUTE,
25
27
  } from './CommentAnchorResolver.js';
26
28
 
27
29
  export const COMMENT_MODE_CURSOR = 'var(--comment-cursor)';
@@ -394,7 +396,19 @@ export class CommentOverlayManager extends Common.ObjectWrapper.ObjectWrapper<Ev
394
396
  */
395
397
  #rematchAllComments(root: Document|Element = document): void {
396
398
  clearClippingAncestorsCache();
397
- const jslogElements = deepQuerySelectorAll(root, '[jslog]');
399
+ // Single deep traversal shared by anchor rematching and sticky occluder clipping.
400
+ const scannedElements = deepQuerySelectorAll(root, `[jslog], [${STICKY_OCCLUDER_ATTRIBUTE}]`);
401
+ const jslogElements: Element[] = [];
402
+ const stickyOccluders: Element[] = [];
403
+ for (const el of scannedElements) {
404
+ if (el.hasAttribute('jslog')) {
405
+ jslogElements.push(el);
406
+ }
407
+ if (el.hasAttribute(STICKY_OCCLUDER_ATTRIBUTE)) {
408
+ stickyOccluders.push(el);
409
+ }
410
+ }
411
+ setStickyOccluders(stickyOccluders);
398
412
  const oldElements = new Set<Element>();
399
413
  const newElements = new Set<Element>();
400
414
 
@@ -559,7 +573,7 @@ export class CommentOverlayManager extends Common.ObjectWrapper.ObjectWrapper<Ev
559
573
  */
560
574
  stop(): void {
561
575
  document.body.style.cursor = '';
562
- clearClippingAncestorsCache();
576
+ setStickyOccluders(null);
563
577
  this.clearDraftThreads();
564
578
  this.#removeClickListener();
565
579
  this.#removeScrollListener();
@@ -870,6 +884,7 @@ export class CommentOverlayManager extends Common.ObjectWrapper.ObjectWrapper<Ev
870
884
  'data-target-id',
871
885
  'aria-expanded',
872
886
  'data-file-path',
887
+ STICKY_OCCLUDER_ATTRIBUTE,
873
888
  ],
874
889
  });
875
890
  }
@@ -135,7 +135,6 @@ button {
135
135
  devtools-icon.long-click {
136
136
  position: absolute;
137
137
  top: var(--sys-size-2);
138
- left: 3px;
139
138
  }
140
139
 
141
140
  devtools-icon[name='cross-circle-filled'] {
@@ -16,7 +16,7 @@
16
16
 
17
17
  .diff-line-number {
18
18
  color: var(--sys-color-token-subtle);
19
- padding: 0 3px 0 9px;
19
+ padding: 0 var(--sys-size-3) 0 var(--sys-size-5);
20
20
  text-align: right;
21
21
  user-select: none;
22
22
  }
@@ -78,5 +78,5 @@
78
78
  font-family: var(--source-code-font-family);
79
79
  font-size: var(--source-code-font-size);
80
80
  margin: 0;
81
- padding: var(--sys-size-5) 9px;
81
+ padding: var(--sys-size-5);
82
82
  }
@@ -43,7 +43,7 @@
43
43
  .codeblock .editor-wrapper .code {
44
44
  max-height: var(--code-block-max-code-height);
45
45
  overflow: auto;
46
- padding-bottom: 10px;
46
+ padding-bottom: var(--sys-size-5);
47
47
  }
48
48
 
49
49
  .codeblock.no-toolbar .editor-wrapper {
@@ -52,8 +52,8 @@
52
52
 
53
53
  .codeblock.no-toolbar .copy-button-container {
54
54
  position: absolute;
55
- top: 5px;
56
- right: 5px;
55
+ top: var(--sys-size-4);
56
+ right: var(--sys-size-4);
57
57
  z-index: 1;
58
58
  }
59
59
 
@@ -34,7 +34,7 @@ devtools-code-block.animating {
34
34
  }
35
35
 
36
36
  .message {
37
- line-height: 18px;
37
+ line-height: var(--sys-typescale-body4-line-height);
38
38
  font-size: var(--sys-typescale-body4-size);
39
39
  color: var(--sys-color-on-surface);
40
40
  user-select: text;
@@ -115,13 +115,13 @@ devtools-code-block {
115
115
  outline-offset: var(--sys-size-2);
116
116
  border: none;
117
117
  padding: 0;
118
- font-size: 10px;
118
+ font-size: var(--sys-typescale-body5-size);
119
119
  font-family: var(--default-font-family);
120
120
  }
121
121
 
122
122
  h1.insight, h2.insight, h3.insight, h4.insight, h5.insight, h6.insight {
123
123
  font: var(--sys-typescale-body4-bold);
124
- margin: var(--sys-size-1) 0 10px;
124
+ margin: var(--sys-size-1) 0 var(--sys-size-5);
125
125
  }
126
126
 
127
127
  .message table {
@@ -143,7 +143,7 @@ export class Menu extends HTMLElement {
143
143
  connectedCallback(): void {
144
144
  void RenderCoordinator.write(() => {
145
145
  this.style.setProperty('--selected-item-check', `url(${selectedItemCheckmark})`);
146
- this.style.setProperty('--menu-checkmark-width', this.#props.showSelectedItem ? '26px' : '0px');
146
+ this.style.setProperty('--menu-checkmark-width', this.#props.showSelectedItem ? 'var(--sys-size-8)' : '0px');
147
147
  this.style.setProperty('--menu-checkmark-height', this.#props.showSelectedItem ? '12px' : '0px');
148
148
  const dividerLine = this.showDivider ? '1px var(--divider-line) solid' : 'none';
149
149
  this.style.setProperty('--override-divider-line', dividerLine);
@@ -42,7 +42,7 @@
42
42
  display: inline-block;
43
43
  mask-repeat: no-repeat;
44
44
  mask-position: center;
45
- width: calc(var(--menu-checkmark-width) - 10px);
45
+ width: var(--menu-checkmark-width);
46
46
  height: var(--menu-checkmark-height);
47
47
  mask-image: var(--selected-item-check);
48
48
  background: var(--sys-color-token-subtle);
@@ -15,7 +15,7 @@
15
15
  font-size: var(--sys-typescale-body3-size);
16
16
  line-height: var(--sys-typescale-body3-line-height);
17
17
  border-radius: var(--sys-shape-corner-medium-small);
18
- margin: 42px 0;
18
+ margin: var(--sys-size-14) 0;
19
19
  letter-spacing: 0.01em;
20
20
  }
21
21
 
@@ -24,10 +24,10 @@ h2 {
24
24
  font-size: var(--sys-typescale-body3-size);
25
25
  line-height: var(--sys-typescale-body3-line-height);
26
26
  letter-spacing: 0.01em;
27
- margin: 9px 0 var(--sys-size-7);
27
+ margin: var(--sys-size-5) 0 var(--sys-size-7);
28
28
  display: flex;
29
29
  align-items: center;
30
- gap: 5px;
30
+ gap: var(--sys-size-3);
31
31
  font-weight: normal;
32
32
  }
33
33
 
@@ -45,7 +45,8 @@ h3 {
45
45
  }
46
46
 
47
47
  .thumbnail {
48
- height: 92px;
48
+ /* 80px (--sys-size-19) + 12px (--sys-size-6) = 92px to match the 144x92 preview_feature_video_thumbnail.svg height without inline descender gap. */
49
+ height: calc(var(--sys-size-19) + var(--sys-size-6));
49
50
  }
50
51
 
51
52
  .video {
@@ -30,7 +30,7 @@ h1 {
30
30
  font-size: var(--sys-typescale-body3-size);
31
31
  letter-spacing: 0.03em;
32
32
  line-height: 1.54;
33
- margin-bottom: 9px;
33
+ margin-bottom: var(--sys-size-5);
34
34
  position: relative;
35
35
  }
36
36
 
@@ -6,7 +6,7 @@
6
6
 
7
7
  :host {
8
8
  margin: var(--sys-size-3) var(--sys-size-9) var(--sys-size-3) var(--sys-size-9);
9
- min-width: 150px;
9
+ min-width: var(--sys-size-22);
10
10
  }
11
11
 
12
12
  .value {
@@ -15,5 +15,8 @@
15
15
  margin-inline-start: 0;
16
16
  padding: 0 var(--sys-size-4);
17
17
  overflow-wrap: break-word;
18
- line-height: 18px;
18
+ /* 16px body4 line-height (--sys-typescale-body4-line-height, equal to --sys-size-8)
19
+ * + 2px row leading (--sys-size-2) = 18px, preserving baseline alignment with
20
+ * paired 18px .key cells and inline 18px-20px report icons/buttons. */
21
+ line-height: calc(var(--sys-typescale-body4-line-height) + var(--sys-size-2));
19
22
  }
@@ -30,8 +30,8 @@ devtools-editable-content {
30
30
 
31
31
  devtools-editable-content:hover,
32
32
  devtools-editable-content:focus {
33
- box-shadow: 0 0 0 1px var(--sys-color-divider);
34
- border-radius: 2px;
33
+ box-shadow: 0 0 0 var(--sys-size-1) var(--sys-color-divider);
34
+ border-radius: var(--sys-size-2);
35
35
  }
36
36
 
37
37
  devtools-editable-content[placeholder]:empty::before {
@@ -57,16 +57,16 @@ devtools-editable-content:focus ~ devtools-suggestion-box {
57
57
  background-color: var(--sys-color-cdt-base-container);
58
58
  box-shadow: var(--drop-shadow);
59
59
  min-height: 1em;
60
- min-width: 150px;
60
+ min-width: var(--sys-size-23);
61
61
  overflow: hidden auto;
62
62
  position: relative;
63
63
  z-index: 100;
64
- max-height: 350px;
64
+ max-height: var(--sys-size-32);
65
65
  }
66
66
 
67
67
  .suggestions > li {
68
- padding: 1px;
69
- border: 1px solid transparent;
68
+ padding: var(--sys-size-1);
69
+ border: var(--sys-size-1) solid transparent;
70
70
  white-space: nowrap;
71
71
  font-family: var(--source-code-font-family);
72
72
  font-size: var(--source-code-font-size);
@@ -759,6 +759,9 @@ export class ContextMenu extends SubMenu {
759
759
  * Discards (closes) the soft context menu if it's currently shown.
760
760
  */
761
761
  discard(): void {
762
+ if (ContextMenu.pendingMenu === this) {
763
+ ContextMenu.pendingMenu = null;
764
+ }
762
765
  if (this.softMenu) {
763
766
  this.softMenu.discard();
764
767
  }
@@ -130,9 +130,6 @@ export class GlassPane {
130
130
  return;
131
131
  }
132
132
  this.#widget.detach(/* overrideHideOnDetach= */ true);
133
- if (this.#onHideCallback) {
134
- this.#onHideCallback();
135
- }
136
133
  }
137
134
 
138
135
  #onDetach(): void {
@@ -147,6 +144,9 @@ export class GlassPane {
147
144
  this.onMouseDownBound,
148
145
  true,
149
146
  );
147
+ if (this.#onHideCallback) {
148
+ this.#onHideCallback();
149
+ }
150
150
  }
151
151
 
152
152
  private onMouseDown(event: Event): void {
@@ -90,6 +90,11 @@ export class SoftContextMenu {
90
90
  this.document = document;
91
91
 
92
92
  this.glassPane = new GlassPane();
93
+ this.glassPane.setOnHideCallback(() => {
94
+ if (this.glassPane) {
95
+ this.discard();
96
+ }
97
+ });
93
98
  this.glassPane.setPointerEventsBehavior(
94
99
  this.parentMenu ? PointerEventsBehavior.PIERCE_GLASS_PANE : PointerEventsBehavior.BLOCKED_BY_GLASS_PANE);
95
100
  this.glassPane.registerRequiredCSS(softContextMenuStyles);
@@ -178,8 +183,9 @@ export class SoftContextMenu {
178
183
  this.focusRestorer.restore();
179
184
  }
180
185
  if (this.glassPane) {
181
- this.glassPane.hide();
186
+ const glassPane = this.glassPane;
182
187
  delete this.glassPane;
188
+ glassPane.hide();
183
189
  if (this.hideOnUserMouseDownUnlessInMenu) {
184
190
  if (this.document) {
185
191
  this.document.body.removeEventListener('mousedown', this.hideOnUserMouseDownUnlessInMenu, false);
@@ -220,6 +220,8 @@ export class DataGridImpl<T> extends Common.ObjectWrapper.ObjectWrapper<EventTyp
220
220
  this.dataTableColumnGroup = this.dataTable.createChild('colgroup');
221
221
 
222
222
  this.#dataTableHead = this.dataTable.createChild('thead');
223
+ // Sticky header: comment overlays for rows scrolled under it are clipped (see CommentAnchorResolver).
224
+ this.#dataTableHead.setAttribute('data-sticky-occluder', '');
223
225
  this.headerRow = this.#dataTableHead.createChild('tr');
224
226
 
225
227
  this.dataTableBody = this.dataTable.createChild('tbody');
@@ -5,8 +5,7 @@
5
5
  */
6
6
 
7
7
  :host {
8
- width: 270px;
9
- height: 350px;
8
+ width: var(--sys-size-30);
10
9
  user-select: none;
11
10
  padding: var(--sys-size-8);
12
11
  overflow: hidden;
@@ -30,12 +29,14 @@
30
29
  }
31
30
 
32
31
  .bezier-preset {
33
- width: 50px;
34
- height: 50px;
35
- padding: 5px;
32
+ /* 48px (--sys-size-16) - 2 * 4px (--sys-size-3)
33
+ preserves the 40x40 PresetUI SVG canvas. */
34
+ width: var(--sys-size-16);
35
+ height: var(--sys-size-16);
36
+ padding: var(--sys-size-3);
36
37
  margin: auto;
37
38
  background-color: var(--sys-color-surface1);
38
- border-radius: 3px;
39
+ border-radius: var(--sys-shape-corner-extra-small);
39
40
  }
40
41
 
41
42
  .bezier-preset line.bezier-control-line {
@@ -19,13 +19,12 @@
19
19
  display: inline-block;
20
20
  user-select: none;
21
21
  background-image: var(--image-file-checker);
22
- line-height: 10px;
23
22
  }
24
23
 
25
24
  .color-swatch-inner {
26
25
  width: 100%;
27
26
  height: 100%;
28
- display: inline-block;
27
+ display: block;
29
28
  border: var(--sys-size-1) solid var(--sys-color-neutral-outline);
30
29
  box-sizing: border-box;
31
30
  cursor: pointer;
@@ -57,7 +57,7 @@
57
57
  .center {
58
58
  width: 0.7em;
59
59
  height: 0.7em;
60
- border-radius: 10px;
60
+ border-radius: var(--sys-shape-corner-full);
61
61
  }
62
62
 
63
63
  .dial {
@@ -83,7 +83,7 @@
83
83
  height: 1em;
84
84
  border-radius: var(--sys-shape-corner-full);
85
85
  cursor: pointer;
86
- box-shadow: 0 0 5px var(--box-shadow-outline-color);
86
+ box-shadow: 0 0 var(--sys-size-3) var(--box-shadow-outline-color);
87
87
  }
88
88
 
89
89
  .hand::before,
@@ -93,7 +93,7 @@
93
93
 
94
94
  :host-context(.theme-with-dark-background) .hand::before {
95
95
  /* stylelint-disable-next-line plugin/use_theme_colors */
96
- box-shadow: 0 0 5px hsl(0deg 0% 0% / 80%);
96
+ box-shadow: 0 0 var(--sys-size-3) hsl(0deg 0% 0% / 80%);
97
97
  }
98
98
 
99
99
  :host-context(.theme-with-dark-background) .center,
@@ -40,7 +40,7 @@
40
40
  /* force non overlay scrollbars for Aura Overlay Scrollbar enabled */
41
41
 
42
42
  :host-context(.overlay-scrollbar-enabled) ::-webkit-scrollbar {
43
- width: 10px;
43
+ width: var(--sys-size-5);
44
44
  }
45
45
 
46
46
  :host-context(.overlay-scrollbar-enabled) ::-webkit-scrollbar-thumb {
@@ -7,7 +7,7 @@
7
7
  .film-strip-view {
8
8
  overflow: auto hidden;
9
9
  align-content: flex-start;
10
- min-height: 81px;
10
+ min-height: var(--sys-size-19);
11
11
  }
12
12
 
13
13
  .film-strip-view .frame .time {
@@ -17,9 +17,11 @@
17
17
  .flame-chart-marker-highlight-element {
18
18
  position: absolute;
19
19
  top: var(--sys-size-1);
20
- height: 18px;
20
+ /* 20px header (--sys-size-9) minus two 1px top/bottom borders (2 * --sys-size-1). */
21
+ height: calc(var(--sys-size-9) - 2 * var(--sys-size-1));
21
22
  width: var(--sys-size-4);
22
- margin: 0 -3px;
23
+ /* Half of 6px width (--sys-size-4) to center horizontally on left: barX. */
24
+ margin: 0 calc(-1 * var(--sys-size-4) / 2);
23
25
  content: "";
24
26
  display: block;
25
27
  }
@@ -75,7 +77,7 @@
75
77
  }
76
78
 
77
79
  .flame-chart-entry-info table tr td:not(:empty) {
78
- padding: 0 5px;
80
+ padding: 0 var(--sys-size-3);
79
81
  white-space: nowrap;
80
82
  }
81
83
 
@@ -83,12 +85,13 @@
83
85
  font-weight: bold;
84
86
  }
85
87
 
86
- .flame-chart-entry-info table tr td span {
87
- margin-right: 5px;
88
- }
89
-
90
88
  .flame-chart-edit-confirm {
91
89
  position: fixed;
92
- bottom: 10px;
93
- right: 10px;
90
+ bottom: var(--sys-size-6);
91
+ right: var(--sys-size-6);
92
+ }
93
+
94
+ :has(+ .chart-viewport-v-scroll:not(.hidden)) > .flame-chart-edit-confirm {
95
+ /* 12px margin (--sys-size-6) + 16px scrollbar gutter (--sys-size-8) = 28px (--sys-size-12). */
96
+ right: var(--sys-size-12);
94
97
  }