chrome-devtools-frontend 1.0.1696961 → 1.0.1697595

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (94) hide show
  1. package/.geminiignore +0 -1
  2. package/front_end/core/common/Color.ts +5 -2
  3. package/front_end/core/host/InspectorFrontendHostAPI.ts +16 -3
  4. package/front_end/core/host/InspectorFrontendHostStub.ts +3 -2
  5. package/front_end/core/host/ResourceLoader.ts +1 -2
  6. package/front_end/core/platform/api/HostRuntime.ts +1 -0
  7. package/front_end/core/platform/browser/HostRuntime.ts +4 -0
  8. package/front_end/core/platform/node/HostRuntime.ts +5 -0
  9. package/front_end/core/root/Runtime.ts +5 -0
  10. package/front_end/core/sdk/DOMModel.ts +13 -0
  11. package/front_end/core/sdk/SourceMapScopeChainEntry.ts +9 -6
  12. package/front_end/core/sdk/SourceMapScopesInfo.ts +3 -1
  13. package/front_end/foundation/Universe.ts +8 -0
  14. package/front_end/generated/InspectorBackendCommands.ts +3 -0
  15. package/front_end/generated/protocol-mapping.d.ts +19 -0
  16. package/front_end/generated/protocol-proxy-api.d.ts +15 -0
  17. package/front_end/generated/protocol.ts +35 -0
  18. package/front_end/models/ai_assistance/AiAgent2.ts +20 -18
  19. package/front_end/models/ai_assistance/AiConversation.ts +38 -12
  20. package/front_end/models/ai_assistance/agents/AccessibilityAgent.ts +9 -2
  21. package/front_end/models/ai_assistance/agents/StylingAgent.ts +13 -4
  22. package/front_end/models/ai_assistance/tools/CookieUtils.ts +10 -8
  23. package/front_end/models/ai_assistance/tools/ExecuteJavaScript.ts +1 -1
  24. package/front_end/models/ai_assistance/tools/GetElementAccessibilityDetails.ts +1 -3
  25. package/front_end/models/ai_assistance/tools/GetNetworkRequestDetails.ts +9 -8
  26. package/front_end/models/ai_assistance/tools/GetSourceContent.ts +5 -6
  27. package/front_end/models/ai_assistance/tools/GetStorageValues.ts +6 -25
  28. package/front_end/models/ai_assistance/tools/GetStyles.ts +1 -3
  29. package/front_end/models/ai_assistance/tools/ListNetworkRequests.ts +7 -6
  30. package/front_end/models/ai_assistance/tools/ListPageOrigins.ts +8 -5
  31. package/front_end/models/ai_assistance/tools/ListSources.ts +8 -10
  32. package/front_end/models/ai_assistance/tools/ListStorageKeys.ts +6 -25
  33. package/front_end/models/ai_assistance/tools/README.md +5 -3
  34. package/front_end/models/ai_assistance/tools/ResolveDevtoolsNodePath.ts +1 -2
  35. package/front_end/models/ai_assistance/tools/Tool.ts +52 -14
  36. package/front_end/models/change_tracker/ChangeTracker.ts +89 -0
  37. package/front_end/models/change_tracker/change_tracker.ts +9 -0
  38. package/front_end/models/issues_manager/MarkdownIssueDescription.ts +2 -2
  39. package/front_end/models/live-metrics/LiveMetrics.ts +1 -2
  40. package/front_end/models/trace/ModelImpl.ts +0 -6
  41. package/front_end/models/trace/Processor.ts +4 -7
  42. package/front_end/models/trace/helpers/Timing.ts +2 -1
  43. package/front_end/models/trace/types/Overlays.ts +12 -1
  44. package/front_end/panels/accessibility/AccessibilityAnnouncementRecordingView.ts +67 -19
  45. package/front_end/panels/application/IndexedDBViews.ts +1 -1
  46. package/front_end/panels/elements/DOMTreeContextMenu.ts +16 -23
  47. package/front_end/panels/elements/ElementsTreeElement.ts +286 -59
  48. package/front_end/panels/elements/ElementsTreeOutline.ts +273 -42
  49. package/front_end/panels/network/NetworkPanel.ts +137 -52
  50. package/front_end/panels/network/RequestHeadersView.ts +65 -32
  51. package/front_end/panels/network/components/RequestHeadersView.css +7 -1
  52. package/front_end/panels/network/forward/BackendLinking.ts +49 -0
  53. package/front_end/panels/network/forward/forward.ts +2 -0
  54. package/front_end/panels/settings/BackendLinkingSettingsTab.ts +303 -0
  55. package/front_end/panels/settings/backendLinkingSettingsTab.css +78 -0
  56. package/front_end/panels/settings/settings-meta.ts +25 -0
  57. package/front_end/panels/settings/settings.ts +2 -0
  58. package/front_end/panels/timeline/README.md +3 -2
  59. package/front_end/panels/timeline/TimelineFlameChartView.ts +23 -2
  60. package/front_end/panels/timeline/overlays/OverlaysImpl.ts +64 -4
  61. package/front_end/panels/timeline/timelineFlameChartView.css +47 -0
  62. package/front_end/panels/whats_new/ReleaseNoteText.ts +8 -8
  63. package/front_end/panels/whats_new/resources/WNDT.md +6 -6
  64. package/front_end/third_party/chromium/README.chromium +1 -1
  65. package/front_end/third_party/puppeteer/README.chromium +2 -2
  66. package/front_end/third_party/puppeteer/package/lib/es5-iife/puppeteer-core-browser.d.ts +6 -0
  67. package/front_end/third_party/puppeteer/package/lib/es5-iife/puppeteer-core-browser.js +5 -8
  68. package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/Coverage.d.ts +6 -0
  69. package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/Coverage.d.ts.map +1 -1
  70. package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/Coverage.js.map +1 -1
  71. package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/ScreenRecording.d.ts.map +1 -1
  72. package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/ScreenRecording.js +1 -5
  73. package/front_end/third_party/puppeteer/package/lib/puppeteer/cdp/ScreenRecording.js.map +1 -1
  74. package/front_end/third_party/puppeteer/package/lib/puppeteer/revisions.d.ts +3 -3
  75. package/front_end/third_party/puppeteer/package/lib/puppeteer/revisions.js +3 -3
  76. package/front_end/third_party/puppeteer/package/lib/puppeteer/revisions.js.map +1 -1
  77. package/front_end/third_party/puppeteer/package/lib/puppeteer/util/version.d.ts +1 -1
  78. package/front_end/third_party/puppeteer/package/lib/puppeteer/util/version.js +1 -1
  79. package/front_end/third_party/puppeteer/package/lib/types.d.ts +6 -0
  80. package/front_end/third_party/puppeteer/package/package.json +2 -2
  81. package/front_end/third_party/puppeteer/package/src/cdp/Coverage.ts +6 -0
  82. package/front_end/third_party/puppeteer/package/src/cdp/ScreenRecording.ts +3 -7
  83. package/front_end/third_party/puppeteer/package/src/revisions.ts +3 -3
  84. package/front_end/third_party/puppeteer/package/src/util/version.ts +1 -1
  85. package/front_end/third_party/web-vitals/README.chromium +2 -2
  86. package/front_end/third_party/web-vitals/package/dist/modules/attribution/onINP.js +8 -5
  87. package/front_end/third_party/web-vitals/package/package.json +1 -1
  88. package/front_end/third_party/web-vitals/package/src/attribution/onINP.ts +8 -4
  89. package/front_end/third_party/web-vitals/rebuild.sh +2 -2
  90. package/front_end/ui/legacy/ContextMenu.ts +19 -0
  91. package/front_end/ui/legacy/SoftContextMenu.ts +6 -0
  92. package/front_end/ui/legacy/components/perf_ui/FlameChart.ts +62 -22
  93. package/front_end/ui/visual_logging/KnownContextValues.ts +4 -0
  94. package/package.json +5 -4
@@ -370,6 +370,22 @@ export function handleAdornerKeydown(cb: (event: Event) => void): (event: Keyboa
370
370
  };
371
371
  }
372
372
 
373
+ function formatCandidateLabel(node: SDK.DOMModel.DOMNode): string {
374
+ let label = node.localName() || node.nodeName().toLowerCase();
375
+ const id = node.getAttribute('id');
376
+ if (id) {
377
+ label += '#' + id;
378
+ }
379
+ const classes = node.getAttribute('class');
380
+ if (classes) {
381
+ const classList = classes.trim().split(/\s+/g).filter(Boolean);
382
+ if (classList.length) {
383
+ label += '.' + classList.join('.');
384
+ }
385
+ }
386
+ return label;
387
+ }
388
+
373
389
  function renderTitle(
374
390
  node: SDK.DOMModel.DOMNode,
375
391
  isClosingTag: boolean,
@@ -1113,7 +1129,8 @@ export class ElementsTreeWidget extends UI.Widget.Widget {
1113
1129
  #domIssuesManager?: IssuesManager.DOMIssuesManager.DOMIssuesManager;
1114
1130
 
1115
1131
  #node!: SDK.DOMModel.DOMNode;
1116
- isClosingTag = false;
1132
+ #eventsBound = false;
1133
+ #isClosingTag = false;
1117
1134
  #expanded = false;
1118
1135
  #isExpandable = false;
1119
1136
  #selected = false;
@@ -1123,6 +1140,28 @@ export class ElementsTreeWidget extends UI.Widget.Widget {
1123
1140
  isDOMNodeSelected = false;
1124
1141
  initialEdit?: InitialEditState|null;
1125
1142
  onInitialEditCompleted?: () => void;
1143
+ attributeToHighlight?: string|null;
1144
+ onAttributeHighlighted?: () => void;
1145
+ #adornersDirty = false;
1146
+ get adornersDirty(): boolean {
1147
+ return this.#adornersDirty;
1148
+ }
1149
+ set adornersDirty(dirty: boolean) {
1150
+ this.#adornersDirty = dirty;
1151
+ }
1152
+ #adornersUpdateVersion = 0;
1153
+ get adornersUpdateVersion(): number {
1154
+ return this.#adornersUpdateVersion;
1155
+ }
1156
+ set adornersUpdateVersion(version: number) {
1157
+ if (this.#adornersUpdateVersion === version) {
1158
+ return;
1159
+ }
1160
+ this.#adornersUpdateVersion = version;
1161
+ if (version > 0) {
1162
+ void this.updateAdorners();
1163
+ }
1164
+ }
1126
1165
 
1127
1166
  expand?: () => void;
1128
1167
  collapse?: () => void;
@@ -1135,10 +1174,9 @@ export class ElementsTreeWidget extends UI.Widget.Widget {
1135
1174
  computeLeftIndent?: number|(() => number);
1136
1175
  setChildrenListElementVisible?: (visible: boolean) => void;
1137
1176
 
1138
- findStartTagWidget?: () => ElementsTreeWidget | null;
1139
1177
  selectDOMNode?: (node: SDK.DOMModel.DOMNode, selectedByUser?: boolean) => void;
1140
1178
  revealInTopLayer?: (node: SDK.DOMModel.DOMNode) => void;
1141
- showContextMenu?: (event: Event, widget?: ElementsTreeWidget) => void;
1179
+ showContextMenu?: (event: Event) => void;
1142
1180
  populateTreeElement?: () => Promise<void>;
1143
1181
  toggleHideElement?: (node: SDK.DOMModel.DOMNode) => Promise<void>;
1144
1182
  isToggledToHidden?: (node: SDK.DOMModel.DOMNode) => boolean;
@@ -1171,7 +1209,33 @@ export class ElementsTreeWidget extends UI.Widget.Widget {
1171
1209
  #flexAdornerActive = false;
1172
1210
  #gridAdornerActive = false;
1173
1211
  #popoverAdornerActive = false;
1212
+ get popoverAdornerActive(): boolean {
1213
+ return this.#popoverAdornerActive;
1214
+ }
1215
+ set popoverAdornerActive(active: boolean) {
1216
+ if (this.#popoverAdornerActive === active) {
1217
+ return;
1218
+ }
1219
+ this.#popoverAdornerActive = active;
1220
+ this.requestUpdate();
1221
+ }
1222
+
1223
+ #activePopoverInvokerId: Protocol.DOM.BackendNodeId|null = null;
1224
+ #implicitAnchorCandidatesPromise: Promise<SDK.DOMModel.DeferredDOMNode[]>|null = null;
1174
1225
  #interestAdornerActive = false;
1226
+ get interestAdornerActive(): boolean {
1227
+ return this.#interestAdornerActive;
1228
+ }
1229
+ set interestAdornerActive(active: boolean) {
1230
+ if (this.#interestAdornerActive === active) {
1231
+ return;
1232
+ }
1233
+ this.#interestAdornerActive = active;
1234
+ this.requestUpdate();
1235
+ }
1236
+
1237
+ onPopoverAdornerToggled?: (node: SDK.DOMModel.DOMNode, active: boolean) => void;
1238
+ onInterestAdornerToggled?: (node: SDK.DOMModel.DOMNode, active: boolean) => void;
1175
1239
 
1176
1240
  #scrollSnapAdornerActive = false;
1177
1241
  #startingStyleAdornerActive = false;
@@ -1203,13 +1267,44 @@ export class ElementsTreeWidget extends UI.Widget.Widget {
1203
1267
  }
1204
1268
 
1205
1269
  set node(node: SDK.DOMModel.DOMNode) {
1270
+ if (this.#node === node) {
1271
+ return;
1272
+ }
1273
+ this.#unbindEvents();
1274
+ if (this.#isBound && this.editing) {
1275
+ this.editing.cancel();
1276
+ }
1206
1277
  this.#node = node;
1207
- if (!this.isClosingTag) {
1278
+ this.#bindEvents();
1279
+ if (this.#isBound) {
1280
+ this.requestUpdate();
1281
+ }
1282
+ if (!this.#isClosingTag) {
1208
1283
  void this.#updateAdorners();
1209
1284
  this.updateDecorations();
1210
1285
  }
1211
1286
  }
1212
1287
 
1288
+ get isClosingTag(): boolean {
1289
+ return this.#isClosingTag;
1290
+ }
1291
+
1292
+ set isClosingTag(isClosingTag: boolean) {
1293
+ if (this.#isClosingTag === isClosingTag) {
1294
+ return;
1295
+ }
1296
+ this.#unbindEvents();
1297
+ this.#isClosingTag = isClosingTag;
1298
+ this.#bindEvents();
1299
+ if (this.#isBound) {
1300
+ if (!this.#isClosingTag) {
1301
+ void this.#updateAdorners();
1302
+ this.updateDecorations();
1303
+ }
1304
+ this.requestUpdate();
1305
+ }
1306
+ }
1307
+
1213
1308
  get expanded(): boolean {
1214
1309
  return this.#expanded;
1215
1310
  }
@@ -1267,8 +1362,8 @@ export class ElementsTreeWidget extends UI.Widget.Widget {
1267
1362
  const universe = UI.Widget.lookupUniverseForElement(this.contentElement);
1268
1363
  if (universe) {
1269
1364
  this.#domIssuesManager = universe.get(IssuesManager.DOMIssuesManager.DOMIssuesManager);
1270
- if (this.node?.id) {
1271
- this.#domIssuesManager.subscribeByNodeId(this.node.id, this.#onDOMIssueUpdated);
1365
+ if (this.#eventsBound && this.#node?.id) {
1366
+ this.#domIssuesManager.subscribeByNodeId(this.#node.id, this.#onDOMIssueUpdated);
1272
1367
  }
1273
1368
  }
1274
1369
  }
@@ -1366,15 +1461,22 @@ export class ElementsTreeWidget extends UI.Widget.Widget {
1366
1461
  }
1367
1462
 
1368
1463
  #clearDOMNextUpdate = false;
1464
+ #isBound = false;
1369
1465
 
1370
1466
  override wasShown(): void {
1371
1467
  super.wasShown();
1468
+ this.onbind();
1372
1469
  if (!this.isClosingTag) {
1373
1470
  void this.#updateAdorners();
1374
1471
  this.updateDecorations();
1375
1472
  }
1376
1473
  }
1377
1474
 
1475
+ override willHide(): void {
1476
+ super.willHide();
1477
+ this.onunbind();
1478
+ }
1479
+
1378
1480
  override performUpdate(): void {
1379
1481
  // Skip updating when in-place editing (not HTML editing indicated by the
1380
1482
  // editorState) is happening. Doing an update would break editing
@@ -1456,7 +1558,7 @@ export class ElementsTreeWidget extends UI.Widget.Widget {
1456
1558
  },
1457
1559
  topLayerIndex: this.node.topLayerIndex(),
1458
1560
  onViewSourceAdornerClick: this.disableEdits ? () => {} : this.revealHTMLInSources.bind(this),
1459
- onGutterClick: this.showContextMenu ? (event: Event) => this.showContextMenu?.(event, this) : () => {},
1561
+ onGutterClick: this.showContextMenu ? (event: Event) => this.showContextMenu?.(event) : () => {},
1460
1562
  onContainerAdornerClick: this.disableEdits ? () => {} : (event: Event) => this.#onContainerAdornerClick(event),
1461
1563
  onFlexAdornerClick: this.disableEdits ? () => {} : (event: Event) => this.#onFlexAdornerClick(event),
1462
1564
  onGridAdornerClick: this.disableEdits ? () => {} : (event: Event) => this.#onGridAdornerClick(event),
@@ -1518,6 +1620,12 @@ export class ElementsTreeWidget extends UI.Widget.Widget {
1518
1620
  this.triggerEditAttribute(edit.attributeName);
1519
1621
  }
1520
1622
  }
1623
+ if (this.attributeToHighlight) {
1624
+ const attribute = this.attributeToHighlight;
1625
+ this.attributeToHighlight = null;
1626
+ this.onAttributeHighlighted?.();
1627
+ this.highlightAttribute(attribute);
1628
+ }
1521
1629
  }
1522
1630
 
1523
1631
  async #onCustomElementAdornerClick(event: Event): Promise<void> {
@@ -1702,24 +1810,34 @@ export class ElementsTreeWidget extends UI.Widget.Widget {
1702
1810
  }
1703
1811
 
1704
1812
  onbind(): void {
1813
+ if (this.#isBound) {
1814
+ return;
1815
+ }
1816
+ this.#isBound = true;
1705
1817
  this.requestUpdate();
1706
- if (!this.isClosingTag) {
1707
- this.node.addEventListener(SDK.DOMModel.DOMNodeEvents.TOP_LAYER_INDEX_CHANGED, this.onTopLayerIndexChanged, this);
1708
- this.node.addEventListener(SDK.DOMModel.DOMNodeEvents.SCROLLABLE_FLAG_UPDATED, this.#onScrollableFlagUpdated,
1709
- this);
1710
- this.node.addEventListener(SDK.DOMModel.DOMNodeEvents.AD_RELATED_STATE_UPDATED, this.#onAdRelatedStateUpdated,
1711
- this);
1712
- this.node.addEventListener(SDK.DOMModel.DOMNodeEvents.CONTAINER_QUERY_OVERLAY_STATE_CHANGED,
1713
- this.#onPersistentContainerQueryOverlayStateChanged, this);
1714
- this.node.addEventListener(SDK.DOMModel.DOMNodeEvents.FLEX_CONTAINER_OVERLAY_STATE_CHANGED,
1715
- this.#onPersistentFlexContainerOverlayStateChanged, this);
1716
- this.node.addEventListener(SDK.DOMModel.DOMNodeEvents.GRID_OVERLAY_STATE_CHANGED,
1717
- this.#onPersistentGridOverlayStateChanged, this);
1718
- this.node.addEventListener(SDK.DOMModel.DOMNodeEvents.SCROLL_SNAP_OVERLAY_STATE_CHANGED,
1719
- this.#onPersistentScrollSnapOverlayStateChanged, this);
1720
- if (this.#domIssuesManager && this.node.id) {
1721
- this.#domIssuesManager.subscribeByNodeId(this.node.id, this.#onDOMIssueUpdated);
1722
- }
1818
+ this.#bindEvents();
1819
+ }
1820
+
1821
+ #bindEvents(): void {
1822
+ if (!this.#isBound || this.#isClosingTag || !this.#node || this.#eventsBound) {
1823
+ return;
1824
+ }
1825
+ this.#eventsBound = true;
1826
+ this.#node.addEventListener(SDK.DOMModel.DOMNodeEvents.TOP_LAYER_INDEX_CHANGED, this.onTopLayerIndexChanged, this);
1827
+ this.#node.addEventListener(SDK.DOMModel.DOMNodeEvents.SCROLLABLE_FLAG_UPDATED, this.#onScrollableFlagUpdated,
1828
+ this);
1829
+ this.#node.addEventListener(SDK.DOMModel.DOMNodeEvents.AD_RELATED_STATE_UPDATED, this.#onAdRelatedStateUpdated,
1830
+ this);
1831
+ this.#node.addEventListener(SDK.DOMModel.DOMNodeEvents.CONTAINER_QUERY_OVERLAY_STATE_CHANGED,
1832
+ this.#onPersistentContainerQueryOverlayStateChanged, this);
1833
+ this.#node.addEventListener(SDK.DOMModel.DOMNodeEvents.FLEX_CONTAINER_OVERLAY_STATE_CHANGED,
1834
+ this.#onPersistentFlexContainerOverlayStateChanged, this);
1835
+ this.#node.addEventListener(SDK.DOMModel.DOMNodeEvents.GRID_OVERLAY_STATE_CHANGED,
1836
+ this.#onPersistentGridOverlayStateChanged, this);
1837
+ this.#node.addEventListener(SDK.DOMModel.DOMNodeEvents.SCROLL_SNAP_OVERLAY_STATE_CHANGED,
1838
+ this.#onPersistentScrollSnapOverlayStateChanged, this);
1839
+ if (this.#domIssuesManager && this.#node.id) {
1840
+ this.#domIssuesManager.subscribeByNodeId(this.#node.id, this.#onDOMIssueUpdated);
1723
1841
  }
1724
1842
  }
1725
1843
 
@@ -1794,27 +1912,41 @@ export class ElementsTreeWidget extends UI.Widget.Widget {
1794
1912
  }
1795
1913
 
1796
1914
  onunbind(): void {
1915
+ if (!this.#isBound) {
1916
+ return;
1917
+ }
1918
+ this.#isBound = false;
1797
1919
  if (this.editing) {
1798
1920
  this.editing.cancel();
1799
1921
  }
1800
1922
  this.clearView();
1801
- this.node.removeEventListener(SDK.DOMModel.DOMNodeEvents.TOP_LAYER_INDEX_CHANGED, this.onTopLayerIndexChanged,
1802
- this);
1803
- this.node.removeEventListener(SDK.DOMModel.DOMNodeEvents.SCROLLABLE_FLAG_UPDATED, this.#onScrollableFlagUpdated,
1804
- this);
1805
- this.node.removeEventListener(SDK.DOMModel.DOMNodeEvents.AD_RELATED_STATE_UPDATED, this.#onAdRelatedStateUpdated,
1806
- this);
1807
- this.node.removeEventListener(SDK.DOMModel.DOMNodeEvents.CONTAINER_QUERY_OVERLAY_STATE_CHANGED,
1808
- this.#onPersistentContainerQueryOverlayStateChanged, this);
1809
- this.node.removeEventListener(SDK.DOMModel.DOMNodeEvents.FLEX_CONTAINER_OVERLAY_STATE_CHANGED,
1810
- this.#onPersistentFlexContainerOverlayStateChanged, this);
1811
- this.node.removeEventListener(SDK.DOMModel.DOMNodeEvents.GRID_OVERLAY_STATE_CHANGED,
1812
- this.#onPersistentGridOverlayStateChanged, this);
1813
- this.node.removeEventListener(SDK.DOMModel.DOMNodeEvents.SCROLL_SNAP_OVERLAY_STATE_CHANGED,
1814
- this.#onPersistentScrollSnapOverlayStateChanged, this);
1815
- if (this.#domIssuesManager && this.node.id) {
1816
- this.#domIssuesManager.unsubscribeByNodeId(this.node.id, this.#onDOMIssueUpdated);
1923
+ this.#unbindEvents();
1924
+ }
1925
+
1926
+ #unbindEvents(): void {
1927
+ this.#implicitAnchorCandidatesPromise = null;
1928
+ this.#activePopoverInvokerId = null;
1929
+ if (!this.#eventsBound || !this.#node) {
1930
+ return;
1817
1931
  }
1932
+ this.#node.removeEventListener(SDK.DOMModel.DOMNodeEvents.TOP_LAYER_INDEX_CHANGED, this.onTopLayerIndexChanged,
1933
+ this);
1934
+ this.#node.removeEventListener(SDK.DOMModel.DOMNodeEvents.SCROLLABLE_FLAG_UPDATED, this.#onScrollableFlagUpdated,
1935
+ this);
1936
+ this.#node.removeEventListener(SDK.DOMModel.DOMNodeEvents.AD_RELATED_STATE_UPDATED, this.#onAdRelatedStateUpdated,
1937
+ this);
1938
+ this.#node.removeEventListener(SDK.DOMModel.DOMNodeEvents.CONTAINER_QUERY_OVERLAY_STATE_CHANGED,
1939
+ this.#onPersistentContainerQueryOverlayStateChanged, this);
1940
+ this.#node.removeEventListener(SDK.DOMModel.DOMNodeEvents.FLEX_CONTAINER_OVERLAY_STATE_CHANGED,
1941
+ this.#onPersistentFlexContainerOverlayStateChanged, this);
1942
+ this.#node.removeEventListener(SDK.DOMModel.DOMNodeEvents.GRID_OVERLAY_STATE_CHANGED,
1943
+ this.#onPersistentGridOverlayStateChanged, this);
1944
+ this.#node.removeEventListener(SDK.DOMModel.DOMNodeEvents.SCROLL_SNAP_OVERLAY_STATE_CHANGED,
1945
+ this.#onPersistentScrollSnapOverlayStateChanged, this);
1946
+ if (this.#domIssuesManager && this.#node.id) {
1947
+ this.#domIssuesManager.unsubscribeByNodeId(this.#node.id, this.#onDOMIssueUpdated);
1948
+ }
1949
+ this.#eventsBound = false;
1818
1950
  }
1819
1951
 
1820
1952
  #onDOMIssueUpdated = (): void => {
@@ -2015,8 +2147,8 @@ export class ElementsTreeWidget extends UI.Widget.Widget {
2015
2147
  if (isOpeningTag(this.tagTypeContext) && this.tagTypeContext.canAddAttributes) {
2016
2148
  const attribute = listItem.getElementsByClassName('webkit-html-attribute')[0];
2017
2149
  if (attribute) {
2018
- return this.startEditingAttribute(
2019
- attribute, attribute.getElementsByClassName('webkit-html-attribute-value')[0]);
2150
+ const valueElement = attribute.getElementsByClassName('webkit-html-attribute-value')[0];
2151
+ return this.startEditingAttribute(attribute, valueElement ?? attribute);
2020
2152
  }
2021
2153
 
2022
2154
  return this.addNewAttribute();
@@ -2074,6 +2206,7 @@ export class ElementsTreeWidget extends UI.Widget.Widget {
2074
2206
  return this.startEditingAttribute((elem.parentElement as HTMLElement), (elem as Element));
2075
2207
  }
2076
2208
  }
2209
+ return this.startEditingAttribute((attributeElements[i].parentElement as HTMLElement), attributeElements[i]);
2077
2210
  }
2078
2211
  }
2079
2212
 
@@ -2097,7 +2230,9 @@ export class ElementsTreeWidget extends UI.Widget.Widget {
2097
2230
 
2098
2231
  // Make sure elementForSelection is not a child of attributeValueElement.
2099
2232
  elementForSelection =
2100
- attributeValueElement?.isAncestor(elementForSelection) ? attributeValueElement : elementForSelection;
2233
+ (attributeValueElement && elementForSelection && attributeValueElement.isAncestor(elementForSelection)) ?
2234
+ attributeValueElement :
2235
+ (elementForSelection ?? attribute);
2101
2236
 
2102
2237
  function removeZeroWidthSpaceRecursive(node: Node): void {
2103
2238
  if (node.nodeType === Node.TEXT_NODE) {
@@ -2460,7 +2595,9 @@ export class ElementsTreeWidget extends UI.Widget.Widget {
2460
2595
  }
2461
2596
 
2462
2597
  if (attributeName !== null && (attributeName.trim() || newText.trim()) && oldText !== newText) {
2463
- this.node.setAttribute(attributeName, newText, moveToNextAttributeIfNeeded.bind(this));
2598
+ this.node.setAttribute(attributeName, newText, (error: string|null) => {
2599
+ moveToNextAttributeIfNeeded.call(this, error);
2600
+ });
2464
2601
  Badges.UserBadges.instance().recordAction(Badges.BadgeAction.DOM_ELEMENT_OR_ATTRIBUTE_EDITED);
2465
2602
  return;
2466
2603
  }
@@ -2509,7 +2646,7 @@ export class ElementsTreeWidget extends UI.Widget.Widget {
2509
2646
  }
2510
2647
 
2511
2648
  newText = newText.trim();
2512
- if (newText === oldText) {
2649
+ if (!newText || newText === oldText) {
2513
2650
  cancel();
2514
2651
  return;
2515
2652
  }
@@ -2521,12 +2658,11 @@ export class ElementsTreeWidget extends UI.Widget.Widget {
2521
2658
  cancel();
2522
2659
  return;
2523
2660
  }
2524
- if (!this.selectNodeAfterEdit) {
2525
- return;
2526
- }
2527
2661
 
2528
2662
  Badges.UserBadges.instance().recordAction(Badges.BadgeAction.DOM_ELEMENT_OR_ATTRIBUTE_EDITED);
2529
- this.selectNodeAfterEdit(wasExpanded, error, newNode, moveDirection);
2663
+ if (this.selectNodeAfterEdit) {
2664
+ this.selectNodeAfterEdit(wasExpanded, error, newNode, moveDirection);
2665
+ }
2530
2666
  });
2531
2667
  }
2532
2668
 
@@ -2713,11 +2849,11 @@ export class ElementsTreeWidget extends UI.Widget.Widget {
2713
2849
  }
2714
2850
  }
2715
2851
 
2716
- function commitChange(initialValue: string, value: string): void {
2852
+ const commitChange = (initialValue: string, value: string): void => {
2717
2853
  if (initialValue !== value) {
2718
2854
  node.setOuterHTML(value, selectNode);
2719
2855
  }
2720
- }
2856
+ };
2721
2857
 
2722
2858
  function disposeCallback(): void {
2723
2859
  if (callback) {
@@ -2782,6 +2918,11 @@ export class ElementsTreeWidget extends UI.Widget.Widget {
2782
2918
  } else {
2783
2919
  this.#layout = null;
2784
2920
  }
2921
+ if (this.node.attributes().some(attr => attr.name === 'popover')) {
2922
+ this.#implicitAnchorCandidatesPromise = this.node.getImplicitAnchorCandidates();
2923
+ } else {
2924
+ this.#implicitAnchorCandidatesPromise = null;
2925
+ }
2785
2926
  this.requestUpdate();
2786
2927
  }
2787
2928
 
@@ -2792,12 +2933,100 @@ export class ElementsTreeWidget extends UI.Widget.Widget {
2792
2933
  if (!nodeId) {
2793
2934
  return;
2794
2935
  }
2795
- await node.domModel().agent.invoke_forceShowPopover({nodeId, enable: !this.#popoverAdornerActive});
2796
- this.#popoverAdornerActive = !this.#popoverAdornerActive;
2797
- if (this.#popoverAdornerActive) {
2798
- Badges.UserBadges.instance().recordAction(Badges.BadgeAction.MODERN_DOM_BADGE_CLICKED);
2936
+ const candidates = await this.#implicitAnchorCandidatesPromise;
2937
+ if (!candidates) {
2938
+ return;
2799
2939
  }
2800
- this.requestUpdate();
2940
+ if (candidates.length <= 1) {
2941
+ const enable = !this.#popoverAdornerActive;
2942
+ const invokerNodeId = enable && candidates.length === 1 ? candidates[0].backendNodeId() : undefined;
2943
+ await node.domModel().agent.invoke_forceShowPopover({nodeId, enable, invokerNodeId});
2944
+ this.#popoverAdornerActive = enable;
2945
+ this.#activePopoverInvokerId = enable ? (invokerNodeId ?? null) : null;
2946
+ if (this.#popoverAdornerActive) {
2947
+ Badges.UserBadges.instance().recordAction(Badges.BadgeAction.MODERN_DOM_BADGE_CLICKED);
2948
+ }
2949
+ this.onPopoverAdornerToggled?.(node, this.#popoverAdornerActive);
2950
+ this.requestUpdate();
2951
+ return;
2952
+ }
2953
+
2954
+ let activeInvokerId = this.#activePopoverInvokerId;
2955
+ if (this.#popoverAdornerActive && activeInvokerId === null && candidates.length > 0) {
2956
+ activeInvokerId = candidates[0].backendNodeId();
2957
+ }
2958
+
2959
+ let x: number|undefined;
2960
+ let y: number|undefined;
2961
+ if (event.target instanceof HTMLElement) {
2962
+ const rect = event.target.getBoundingClientRect();
2963
+ if (event instanceof MouseEvent && (event.clientX || event.clientY)) {
2964
+ x = event.clientX;
2965
+ y = event.clientY;
2966
+ } else {
2967
+ x = rect.left;
2968
+ y = rect.bottom;
2969
+ }
2970
+ }
2971
+
2972
+ const contextMenu = new UI.ContextMenu.ContextMenu(event, {
2973
+ useSoftMenu: true,
2974
+ x,
2975
+ y,
2976
+ onSoftMenuClosed: () => {
2977
+ SDK.OverlayModel.OverlayModel.hideDOMNodeHighlight(SDK.TargetManager.TargetManager.instance());
2978
+ },
2979
+ });
2980
+
2981
+ const resolvedNodes = await Promise.all(candidates.map(candidate => candidate.resolvePromise()));
2982
+
2983
+ for (let i = 0; i < candidates.length; ++i) {
2984
+ const candidate = candidates[i];
2985
+ const resolvedNode = resolvedNodes[i];
2986
+ const candidateBackendId = candidate.backendNodeId();
2987
+ const isActive = this.#popoverAdornerActive && candidateBackendId === activeInvokerId;
2988
+ const label = resolvedNode ? formatCandidateLabel(resolvedNode) : '';
2989
+ if (!label) {
2990
+ continue;
2991
+ }
2992
+ contextMenu.defaultSection().appendCheckboxItem(
2993
+ label,
2994
+ async () => {
2995
+ if (isActive) {
2996
+ await node.domModel().agent.invoke_forceShowPopover({nodeId, enable: false});
2997
+ this.#popoverAdornerActive = false;
2998
+ this.#activePopoverInvokerId = null;
2999
+ } else {
3000
+ if (this.#popoverAdornerActive) {
3001
+ await node.domModel().agent.invoke_forceShowPopover({nodeId, enable: false});
3002
+ }
3003
+ await node.domModel().agent.invoke_forceShowPopover({
3004
+ nodeId,
3005
+ enable: true,
3006
+ invokerNodeId: candidateBackendId,
3007
+ });
3008
+ this.#popoverAdornerActive = true;
3009
+ this.#activePopoverInvokerId = candidateBackendId;
3010
+ Badges.UserBadges.instance().recordAction(Badges.BadgeAction.MODERN_DOM_BADGE_CLICKED);
3011
+ }
3012
+ this.onPopoverAdornerToggled?.(node, this.#popoverAdornerActive);
3013
+ this.requestUpdate();
3014
+ },
3015
+ {
3016
+ checked: isActive,
3017
+ onHover: (hovered: boolean) => {
3018
+ if (hovered) {
3019
+ candidate.highlight();
3020
+ } else {
3021
+ SDK.OverlayModel.OverlayModel.hideDOMNodeHighlight(SDK.TargetManager.TargetManager.instance());
3022
+ }
3023
+ },
3024
+ jslogContext: 'implicit-anchor-candidate',
3025
+ },
3026
+ );
3027
+ }
3028
+
3029
+ await contextMenu.show();
2801
3030
  }
2802
3031
 
2803
3032
  async #onInterestAdornerClick(event: Event): Promise<void> {
@@ -2812,6 +3041,7 @@ export class ElementsTreeWidget extends UI.Widget.Widget {
2812
3041
  if (this.#interestAdornerActive) {
2813
3042
  Badges.UserBadges.instance().recordAction(Badges.BadgeAction.MODERN_DOM_BADGE_CLICKED);
2814
3043
  }
3044
+ this.onInterestAdornerToggled?.(node, this.#interestAdornerActive);
2815
3045
  this.requestUpdate();
2816
3046
  }
2817
3047
 
@@ -3022,9 +3252,6 @@ export class ElementsTreeElement extends UI.TreeOutline.TreeElement {
3022
3252
  outline.selectDOMNode(node, selectedByUser);
3023
3253
  outline.suppressRevealAndSelect = false;
3024
3254
  };
3025
- this.widget.findStartTagWidget = () => {
3026
- return (outline.findTreeElement(this.nodeInternal) as ElementsTreeElement | null)?.widget ?? null;
3027
- };
3028
3255
  this.widget.revealInTopLayer = node => outline.revealInTopLayer(node);
3029
3256
  this.widget.showContextMenu = event => void outline.showContextMenu(this, event);
3030
3257
  this.widget.populateTreeElement = async () => await outline.populateTreeElement(this);