chrome-devtools-frontend 1.0.1696961 → 1.0.1697595

package/.geminiignore

@@ -2,5 +2,4 @@ node_modules/
 /third_party/
 front_end/core/i18n/locales/*.json
 front_end/third_party/lighthouse/locales/*.json
-front_end/third_party/puppeteer/package/lib/cjs/
 front_end/panels/timeline/fixtures/traces/

package/front_end/core/common/Color.ts

@@ -613,12 +613,15 @@ export function findFgColorForContrastAPCA(fgColor: Legacy, bgColor: Legacy, req
   const fgIsLighter = fgLuminance >= bgLuminance;
   const desiredLuminance = desiredLuminanceAPCA(bgLuminance, requiredContrast, fgIsLighter);
 
+  const meetsRequiredContrast = (candidate: Legacy): boolean =>
+      Math.round(Math.abs(contrastRatioAPCA(candidate.rgba(), bgColor.rgba()))) >= requiredContrast;
+
   const saturationComponentIndex = 1;
   const valueComponentIndex = 2;
 
   if (approachColorValue(candidateHSVA, valueComponentIndex, desiredLuminance, candidateLuminance)) {
     const candidate = Legacy.fromHSVA(candidateHSVA);
-    if (Math.abs(contrastRatioAPCA(bgColor.rgba(), candidate.rgba())) >= requiredContrast) {
+    if (meetsRequiredContrast(candidate)) {
       return candidate;
     }
   }
@@ -626,7 +629,7 @@ export function findFgColorForContrastAPCA(fgColor: Legacy, bgColor: Legacy, req
   candidateHSVA[valueComponentIndex] = 1;
   if (approachColorValue(candidateHSVA, saturationComponentIndex, desiredLuminance, candidateLuminance)) {
     const candidate = Legacy.fromHSVA(candidateHSVA);
-    if (Math.abs(contrastRatioAPCA(bgColor.rgba(), candidate.rgba())) >= requiredContrast) {
+    if (meetsRequiredContrast(candidate)) {
       return candidate;
     }
   }

package/front_end/core/host/InspectorFrontendHostAPI.ts

@@ -6,6 +6,11 @@ import type * as Platform from '../../core/platform/platform.js';
 import type * as Common from '../common/common.js';
 import type * as Root from '../root/root.js';
 
+declare global {
+  // eslint-disable-next-line @typescript-eslint/naming-convention
+  var InspectorFrontendHost: InspectorFrontendHostAPI;
+}
+
 /**
  * This values should match the one getting called from Chromium
  */
@@ -227,6 +232,14 @@ export interface FunctionCallEvent {
  * Please note that the "dispatch" side can't be type-checked as the dispatch is
  * done dynamically.
  **/
+export interface DevicesDiscoveryConfig {
+  discoverUsbDevices: boolean;
+  portForwardingEnabled: boolean;
+  portForwardingConfig: Record<string, string>;
+  networkDiscoveryEnabled: boolean;
+  networkDiscoveryConfig: string[];
+}
+
 export interface EventTypes {
   [Events.AppendedToURL]: Platform.DevToolsPath.RawPathString|Platform.DevToolsPath.UrlString;
   [Events.CanceledSaveURL]: Platform.DevToolsPath.UrlString;
@@ -234,7 +247,7 @@ export interface EventTypes {
   [Events.ContextMenuCleared]: void;
   [Events.ContextMenuItemSelected]: number;
   [Events.DeviceCountUpdated]: number;
-  [Events.DevicesDiscoveryConfigChanged]: Adb.Config;
+  [Events.DevicesDiscoveryConfigChanged]: DevicesDiscoveryConfig;
   [Events.DevicesPortForwardingStatusChanged]: void;
   [Events.DevicesUpdated]: void;
   [Events.DispatchMessage]: string;
@@ -399,7 +412,7 @@ export interface InspectorFrontendHostAPI {
 
   sendMessageToBackend(message: string): void;
 
-  setDevicesDiscoveryConfig(config: Adb.Config): void;
+  setDevicesDiscoveryConfig(config: DevicesDiscoveryConfig): void;
 
   setDevicesUpdatesEnabled(enabled: boolean): void;
 
@@ -423,7 +436,7 @@ export interface InspectorFrontendHostAPI {
 
   resetZoom(): void;
 
-  showContextMenuAtPoint(x: number, y: number, items: ContextMenuDescriptor[], document: Document): void;
+  showContextMenuAtPoint(x: number, y: number, items: ContextMenuDescriptor[], document: object): void;
 
   reattach(callback: () => void): void;
 

package/front_end/core/host/InspectorFrontendHostStub.ts

@@ -14,6 +14,7 @@ import {
   type ChangeEvent,
   type ClickEvent,
   type ContextMenuDescriptor,
+  type DevicesDiscoveryConfig,
   type DispatchHttpRequestRequest,
   type DispatchHttpRequestResult,
   type DoAidaConversationResult,
@@ -460,7 +461,7 @@ export class InspectorFrontendHostStub implements InspectorFrontendHostAPI {
   setOpenNewWindowForPopups(_value: boolean): void {
   }
 
-  setDevicesDiscoveryConfig(_config: Adb.Config): void {
+  setDevicesDiscoveryConfig(_config: DevicesDiscoveryConfig): void {
   }
 
   setDevicesUpdatesEnabled(_enabled: boolean): void {
@@ -472,7 +473,7 @@ export class InspectorFrontendHostStub implements InspectorFrontendHostAPI {
   openNodeFrontend(): void {
   }
 
-  showContextMenuAtPoint(_x: number, _y: number, _items: ContextMenuDescriptor[], _document: Document): void {
+  showContextMenuAtPoint(_x: number, _y: number, _items: ContextMenuDescriptor[], _document: object): void {
     throw new Error('Soft context menu should be used');
   }
 

package/front_end/core/host/ResourceLoader.ts

@@ -7,7 +7,6 @@
 import * as Common from '../common/common.js';
 import * as i18n from '../i18n/i18n.js';
 
-import {InspectorFrontendHostInstance} from './InspectorFrontendHost.js';
 import type {LoadNetworkResourceResult} from './InspectorFrontendHostAPI.js';
 
 const UIStrings = {
@@ -248,7 +247,7 @@ export const loadAsStream = function(
       rawHeaders.push(key + ': ' + headers[key]);
     }
   }
-  InspectorFrontendHostInstance.loadNetworkResource(url, rawHeaders.join('\r\n'), streamId, finishedCallback);
+  globalThis.InspectorFrontendHost.loadNetworkResource(url, rawHeaders.join('\r\n'), streamId, finishedCallback);
 
   function finishedCallback(response: LoadNetworkResourceResult): void {
     if (callback) {

package/front_end/core/platform/api/HostRuntime.ts

@@ -26,6 +26,7 @@ export interface HostRuntime {
   getDevicePixelRatio(): number;
   saveScreenshot(options: ScreenshotOptions): Promise<void>;
   revokeLastScreenshotUrl(): void;
+  loadTextFile(url: URL): Promise<string>;
 }
 
 /**

package/front_end/core/platform/browser/HostRuntime.ts

@@ -150,4 +150,8 @@ export const HOST_RUNTIME: Api.HostRuntime.HostRuntime = {
   },
   saveScreenshot,
   revokeLastScreenshotUrl,
+  async loadTextFile(url: URL): Promise<string> {
+    const response = await fetch(url);
+    return await response.text();
+  },
 };

package/front_end/core/platform/node/HostRuntime.ts

@@ -2,6 +2,8 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+import * as Fs from 'node:fs';
+import * as Url from 'node:url';
 import * as WorkerThreads from 'node:worker_threads';
 
 import type * as Api from '../api/api.js';
@@ -101,4 +103,7 @@ export const HOST_RUNTIME: Api.HostRuntime.HostRuntime = {
   },
   async saveScreenshot(_options: Api.HostRuntime.ScreenshotOptions): Promise<void>{},
   revokeLastScreenshotUrl(): void{},
+  async loadTextFile(url: URL): Promise<string> {
+    return await Fs.promises.readFile(Url.fileURLToPath(url), 'utf-8');
+  },
 };

package/front_end/core/root/Runtime.ts

@@ -545,6 +545,10 @@ interface DevToolsMobileSafeAreaEmulation {
   enabled: boolean;
 }
 
+interface DevToolsNetworkBackendLinking {
+  enabled: boolean;
+}
+
 /**
  * The host configuration that we expect from the DevTools back-end.
  *
@@ -602,6 +606,7 @@ export type HostConfig = Platform.TypeScriptUtilities.RecursivePartial<{
   devToolsAriaLiveRecording: DevToolsAriaLiveRecording,
   devToolsInstrumentationBreakpoints: DevToolsInstrumentationBreakpoints,
   devToolsMobileSafeAreaEmulation: DevToolsMobileSafeAreaEmulation,
+  devToolsNetworkBackendLinking: DevToolsNetworkBackendLinking,
   extensionsOnChromeUrls: ExtensionsOnChromeUrls,
   devToolsComments: HostConfigDevToolsComments,
 }>;

package/front_end/core/sdk/DOMModel.ts

@@ -1427,6 +1427,19 @@ export class DOMNode extends Common.ObjectWrapper.ObjectWrapper<DOMNodeEventType
     return this.domModel().nodeForId(response.nodeId);
   }
 
+  async getImplicitAnchorCandidates(): Promise<DeferredDOMNode[]> {
+    const response = await this.#agent.invoke_getImplicitAnchorCandidates({
+      nodeId: this.id,
+    });
+
+    if (response.getError() || !response.backendNodeIds) {
+      return [];
+    }
+
+    const target = this.domModel().target();
+    return response.backendNodeIds.map(backendNodeId => new DeferredDOMNode(target, backendNodeId));
+  }
+
   async takeSnapshot(ownerDocumentSnapshot?: DOMDocument): Promise<DOMNode> {
     const snapshot = (this instanceof DOMDocument) ? new DOMDocumentSnapshot(this.domModel(), {
       nodeId: this.id,

package/front_end/core/sdk/SourceMapScopeChainEntry.ts

@@ -73,11 +73,13 @@ export class SourceMapScopeChainEntry implements ScopeChainEntry {
   }
 
   type(): string {
-    switch (this.#scope.kind) {
+    if (this.#scope.isStackFrame) {
+      return this.#isInnerMostFunction ? Protocol.Debugger.ScopeType.Local : Protocol.Debugger.ScopeType.Closure;
+    }
+    // `kind` is a free-form label. The spec encourages 'Global'/'Block' but doesn't mandate the casing.
+    switch (this.#scope.kind?.toLowerCase()) {
       case 'global':
         return Protocol.Debugger.ScopeType.Global;
-      case 'function':
-        return this.#isInnerMostFunction ? Protocol.Debugger.ScopeType.Local : Protocol.Debugger.ScopeType.Closure;
       case 'block':
         return Protocol.Debugger.ScopeType.Block;
     }
@@ -85,11 +87,12 @@ export class SourceMapScopeChainEntry implements ScopeChainEntry {
   }
 
   typeName(): string {
-    switch (this.#scope.kind) {
+    if (this.#scope.isStackFrame) {
+      return this.#isInnerMostFunction ? i18nString(UIStrings.local) : i18nString(UIStrings.closure);
+    }
+    switch (this.#scope.kind?.toLowerCase()) {
       case 'global':
         return i18nString(UIStrings.global);
-      case 'function':
-        return this.#isInnerMostFunction ? i18nString(UIStrings.local) : i18nString(UIStrings.closure);
       case 'block':
         return i18nString(UIStrings.block);
     }

package/front_end/core/sdk/SourceMapScopesInfo.ts

@@ -359,7 +359,9 @@ export class SourceMapScopesInfo {
     // Walk the original scope chain outwards and try to find the corresponding generated range along the way.
     for (let originalScope = rangeChain.at(-1)?.originalScope; originalScope; originalScope = originalScope.parent) {
       const range = rangeChain.findLast(r => r.originalScope === originalScope);
-      const isFunctionScope = originalScope.kind === 'function';
+      // `kind` is just a label for scope UI views and has no semantic significance, so `isStackFrame`
+      // decides whether this scope is a function scope.
+      const isFunctionScope = originalScope.isStackFrame;
       const isInnerMostFunction = isFunctionScope && !seenFunctionScope;
       const returnValue = isInnerMostFunction ? callFrame.returnValue() : null;
       const scopeNumber = range ? findMatchingScopeNumber(callFrame, range) : undefined;

package/front_end/foundation/Universe.ts

@@ -11,6 +11,7 @@ import * as AutofillManager from '../models/autofill_manager/autofill_manager.js
 import * as Badges from '../models/badges/badges.js';
 import * as Bindings from '../models/bindings/bindings.js';
 import * as Breakpoints from '../models/breakpoints/breakpoints.js';
+import * as ChangeTracker from '../models/change_tracker/change_tracker.js';
 import * as CommentManager from '../models/comment_manager/comment_manager.js';
 import * as CrUXManager from '../models/crux-manager/crux-manager.js';
 import * as Emulation from '../models/emulation/emulation.js';
@@ -238,6 +239,9 @@ export class Universe {
       context.set(CommentManager.CD4ABridge.CD4ABridge, this.cd4aBridge);
     }
 
+    const changeTracker = new ChangeTracker.ChangeTracker.ChangeTracker(commentManager);
+    context.set(ChangeTracker.ChangeTracker.ChangeTracker, changeTracker);
+
     this.autofillManager = new AutofillManager.AutofillManager.AutofillManager(targetManager, frameManager);
     context.set(AutofillManager.AutofillManager.AutofillManager, this.autofillManager);
   }
@@ -275,6 +279,10 @@ export class Universe {
     return this.context.get(Breakpoints.BreakpointManager.BreakpointManager);
   }
 
+  get changeTracker(): ChangeTracker.ChangeTracker.ChangeTracker {
+    return this.context.get(ChangeTracker.ChangeTracker.ChangeTracker);
+  }
+
   get commentManager(): CommentManager.CommentManager.CommentManager {
     return this.context.get(CommentManager.CommentManager.CommentManager);
   }

package/front_end/generated/InspectorBackendCommands.ts

@@ -444,6 +444,9 @@ inspectorBackend.registerCommand("DOM.getAnchorElement", [{"name": "nodeId", "ty
 inspectorBackend.registerCommand("DOM.forceShowPopover", [{"name": "nodeId", "type": "number", "optional": false, "description": "Id of the popover HTMLElement", "typeRef": "DOM.NodeId"}, {"name": "enable", "type": "boolean", "optional": false, "description": "If true, opens the popover and keeps it open. If false, closes the popover if it was previously force-opened.", "typeRef": null}, {"name": "invokerNodeId", "type": "number", "optional": true, "description": "Optional ID of the element invoking this popover, used to establish the implicit anchor. If not provided, it will fall back to the first invoker in the document, preferring elements with a popovertarget attribute over those with a commandfor attribute. Note that if there are multiple invokers, this is just an estimate.", "typeRef": "DOM.BackendNodeId"}], ["nodeIds"], "When enabling, this API force-opens the popover identified by nodeId and keeps it open until disabled.");
 inspectorBackend.registerCommand("DOM.getImplicitAnchorCandidates", [{"name": "nodeId", "type": "number", "optional": false, "description": "Id of the popover HTMLElement.", "typeRef": "DOM.NodeId"}], ["backendNodeIds"], "Returns candidate nodes that are configured as triggers for the given popover.");
 inspectorBackend.registerCommand("DOM.forceShowInterest", [{"name": "nodeId", "type": "number", "optional": false, "description": "Id of the interest invoker HTMLElement.", "typeRef": "DOM.NodeId"}, {"name": "enable", "type": "boolean", "optional": false, "description": "If true, opens and holds interest. If false, releases forced interest.", "typeRef": null}], [], "When enabling, this API forces an element to gain interest in its target, keeping interest active until disabled.");
+inspectorBackend.registerEnum("DOM.SetTextMarkerRequestType", {Spelling: "spelling", Grammar: "grammar"});
+inspectorBackend.registerCommand("DOM.setTextMarker", [{"name": "nodeId", "type": "number", "optional": true, "description": "Identifier of the node.", "typeRef": "DOM.NodeId"}, {"name": "backendNodeId", "type": "number", "optional": true, "description": "Identifier of the backend node.", "typeRef": "DOM.BackendNodeId"}, {"name": "objectId", "type": "string", "optional": true, "description": "JavaScript object id of the node wrapper.", "typeRef": "Runtime.RemoteObjectId"}, {"name": "type", "type": "string", "optional": false, "description": "The type of marker to set on the given range of text.", "typeRef": "DOM.SetTextMarkerRequestType"}, {"name": "start", "type": "number", "optional": false, "description": "Start offset into the element's rendered text in UTF-16 code units. For a text control, an offset into the control's value. Offsets count text in DOM order and do not enter shadow trees. To mark text inside a shadow tree, pass the element inside the shadow tree.", "typeRef": null}, {"name": "end", "type": "number", "optional": false, "description": "End offset (exclusive) in the same units and space as start.", "typeRef": null}], [], "Sets a spelling or grammar error marker on the given range of text. See https://github.com/Igalia/explainers/blob/main/force-spelling-grammar-markers/README.md Note: exactly one between nodeId, backendNodeId and objectId should be passed to identify the node.");
+inspectorBackend.registerCommand("DOM.clearTextMarkers", [], [], "Clears the spelling and grammar error text markers overlapping the ranges set by setTextMarker in this session. These markers are also removed when the DOM domain is disabled or the session ends.");
 inspectorBackend.registerType("DOM.BackendNode", [{"name": "nodeType", "type": "number", "optional": false, "description": "`Node`'s nodeType.", "typeRef": null}, {"name": "nodeName", "type": "string", "optional": false, "description": "`Node`'s nodeName.", "typeRef": null}, {"name": "backendNodeId", "type": "number", "optional": false, "description": "", "typeRef": "DOM.BackendNodeId"}]);
 inspectorBackend.registerType("DOM.Node", [{"name": "nodeId", "type": "number", "optional": false, "description": "Node identifier that is passed into the rest of the DOM messages as the `nodeId`. Backend will only push node with given `id` once. It is aware of all requested nodes and will only fire DOM events for nodes known to the client.", "typeRef": "DOM.NodeId"}, {"name": "parentId", "type": "number", "optional": true, "description": "The id of the parent node if any.", "typeRef": "DOM.NodeId"}, {"name": "backendNodeId", "type": "number", "optional": false, "description": "The BackendNodeId for this node.", "typeRef": "DOM.BackendNodeId"}, {"name": "nodeType", "type": "number", "optional": false, "description": "`Node`'s nodeType.", "typeRef": null}, {"name": "nodeName", "type": "string", "optional": false, "description": "`Node`'s nodeName.", "typeRef": null}, {"name": "localName", "type": "string", "optional": false, "description": "`Node`'s localName.", "typeRef": null}, {"name": "nodeValue", "type": "string", "optional": false, "description": "`Node`'s nodeValue.", "typeRef": null}, {"name": "childNodeCount", "type": "number", "optional": true, "description": "Child count for `Container` nodes.", "typeRef": null}, {"name": "children", "type": "array", "optional": true, "description": "Child nodes of this node when requested with children.", "typeRef": "DOM.Node"}, {"name": "attributes", "type": "array", "optional": true, "description": "Attributes of the `Element` node in the form of flat array `[name1, value1, name2, value2]`.", "typeRef": "string"}, {"name": "documentURL", "type": "string", "optional": true, "description": "Document URL that `Document` or `FrameOwner` node points to.", "typeRef": null}, {"name": "baseURL", "type": "string", "optional": true, "description": "Base URL that `Document` or `FrameOwner` node uses for URL completion.", "typeRef": null}, {"name": "publicId", "type": "string", "optional": true, "description": "`DocumentType`'s publicId.", "typeRef": null}, {"name": "systemId", "type": "string", "optional": true, "description": "`DocumentType`'s systemId.", "typeRef": null}, {"name": "internalSubset", "type": "string", "optional": true, "description": "`DocumentType`'s internalSubset.", "typeRef": null}, {"name": "xmlVersion", "type": "string", "optional": true, "description": "`Document`'s XML version in case of XML documents.", "typeRef": null}, {"name": "name", "type": "string", "optional": true, "description": "`Attr`'s name.", "typeRef": null}, {"name": "value", "type": "string", "optional": true, "description": "`Attr`'s value.", "typeRef": null}, {"name": "pseudoType", "type": "string", "optional": true, "description": "Pseudo element type for this node.", "typeRef": "DOM.PseudoType"}, {"name": "pseudoIdentifier", "type": "string", "optional": true, "description": "Pseudo element identifier for this node. Only present if there is a valid pseudoType.", "typeRef": null}, {"name": "shadowRootType", "type": "string", "optional": true, "description": "Shadow root type.", "typeRef": "DOM.ShadowRootType"}, {"name": "frameId", "type": "string", "optional": true, "description": "Frame ID for frame owner elements.", "typeRef": "Page.FrameId"}, {"name": "contentDocument", "type": "object", "optional": true, "description": "Content document for frame owner elements.", "typeRef": "DOM.Node"}, {"name": "shadowRoots", "type": "array", "optional": true, "description": "Shadow root list for given element host.", "typeRef": "DOM.Node"}, {"name": "templateContent", "type": "object", "optional": true, "description": "Content document fragment for template elements.", "typeRef": "DOM.Node"}, {"name": "pseudoElements", "type": "array", "optional": true, "description": "Pseudo elements associated with this node.", "typeRef": "DOM.Node"}, {"name": "importedDocument", "type": "object", "optional": true, "description": "Deprecated, as the HTML Imports API has been removed (crbug.com/937746). This property used to return the imported document for the HTMLImport links. The property is always undefined now.", "typeRef": "DOM.Node"}, {"name": "distributedNodes", "type": "array", "optional": true, "description": "Distributed nodes for given insertion point.", "typeRef": "DOM.BackendNode"}, {"name": "isSVG", "type": "boolean", "optional": true, "description": "Whether the node is SVG.", "typeRef": null}, {"name": "compatibilityMode", "type": "string", "optional": true, "description": "", "typeRef": "DOM.CompatibilityMode"}, {"name": "assignedSlot", "type": "object", "optional": true, "description": "", "typeRef": "DOM.BackendNode"}, {"name": "isScrollable", "type": "boolean", "optional": true, "description": "", "typeRef": null}, {"name": "affectedByStartingStyles", "type": "boolean", "optional": true, "description": "", "typeRef": null}, {"name": "adoptedStyleSheets", "type": "array", "optional": true, "description": "", "typeRef": "DOM.StyleSheetId"}, {"name": "adProvenance", "type": "object", "optional": true, "description": "", "typeRef": "Network.AdProvenance"}]);
 inspectorBackend.registerType("DOM.DetachedElementInfo", [{"name": "treeNode", "type": "object", "optional": false, "description": "", "typeRef": "DOM.Node"}, {"name": "retainedNodeIds", "type": "array", "optional": false, "description": "", "typeRef": "DOM.NodeId"}]);

package/front_end/generated/protocol-mapping.d.ts

@@ -2312,6 +2312,25 @@ export namespace ProtocolMapping {
       paramsType: [Protocol.DOM.ForceShowInterestRequest];
       returnType: void;
     };
+    /**
+     * Sets a spelling or grammar error marker on the given range of text.
+     * See https://github.com/Igalia/explainers/blob/main/force-spelling-grammar-markers/README.md
+     * Note: exactly one between nodeId, backendNodeId and objectId should be passed
+     * to identify the node.
+     */
+    'DOM.setTextMarker': {
+      paramsType: [Protocol.DOM.SetTextMarkerRequest];
+      returnType: void;
+    };
+    /**
+     * Clears the spelling and grammar error text markers overlapping the ranges
+     * set by setTextMarker in this session. These markers are also removed when
+     * the DOM domain is disabled or the session ends.
+     */
+    'DOM.clearTextMarkers': {
+      paramsType: [];
+      returnType: void;
+    };
     /**
      * Returns event listeners of the given object.
      */

package/front_end/generated/protocol-proxy-api.d.ts

@@ -1406,6 +1406,21 @@ declare namespace ProtocolProxyApi {
      */
     invoke_forceShowInterest(params: Protocol.DOM.ForceShowInterestRequest): Promise<Protocol.ProtocolResponseWithError>;
 
+    /**
+     * Sets a spelling or grammar error marker on the given range of text.
+     * See https://github.com/Igalia/explainers/blob/main/force-spelling-grammar-markers/README.md
+     * Note: exactly one between nodeId, backendNodeId and objectId should be passed
+     * to identify the node.
+     */
+    invoke_setTextMarker(params: Protocol.DOM.SetTextMarkerRequest): Promise<Protocol.ProtocolResponseWithError>;
+
+    /**
+     * Clears the spelling and grammar error text markers overlapping the ranges
+     * set by setTextMarker in this session. These markers are also removed when
+     * the DOM domain is disabled or the session ends.
+     */
+    invoke_clearTextMarkers(): Promise<Protocol.ProtocolResponseWithError>;
+
   }
   export interface DOMDispatcher {
     /**

package/front_end/generated/protocol.ts

@@ -5990,6 +5990,41 @@ export namespace DOM {
     enable: boolean;
   }
 
+  export const enum SetTextMarkerRequestType {
+    Spelling = 'spelling',
+    Grammar = 'grammar',
+  }
+
+  export interface SetTextMarkerRequest {
+    /**
+     * Identifier of the node.
+     */
+    nodeId?: NodeId;
+    /**
+     * Identifier of the backend node.
+     */
+    backendNodeId?: BackendNodeId;
+    /**
+     * JavaScript object id of the node wrapper.
+     */
+    objectId?: Runtime.RemoteObjectId;
+    /**
+     * The type of marker to set on the given range of text.
+     */
+    type: SetTextMarkerRequestType;
+    /**
+     * Start offset into the element's rendered text in UTF-16 code units.
+     * For a text control, an offset into the control's value.
+     * Offsets count text in DOM order and do not enter shadow trees.
+     * To mark text inside a shadow tree, pass the element inside the shadow tree.
+     */
+    start: integer;
+    /**
+     * End offset (exclusive) in the same units and space as start.
+     */
+    end: integer;
+  }
+
   /**
    * Fired when `Element`'s attribute is modified.
    */

package/front_end/models/ai_assistance/AiAgent2.ts

@@ -10,7 +10,6 @@ import type * as Trace from '../trace/trace.js';
 
 import {
   AiAgent,
-  type AllowedOriginResult,
   type ContextResponse,
   type ConversationContext,
   type MultimodalInputType,
@@ -26,7 +25,13 @@ import {debugLog} from './debug.js';
 import {ExtensionScope} from './ExtensionScope.js';
 import type {Skill, SkillName} from './skills/Skill.js';
 import {SKILLS} from './skills/SkillRegistry.js';
-import {type AllToolsCapabilities, isOriginAllowedByLock, type Tool, type ToolArgs} from './tools/Tool.js';
+import {
+  type AllToolsCapabilities,
+  isOriginAllowedByLock,
+  type OriginLockState,
+  type Tool,
+  type ToolArgs,
+} from './tools/Tool.js';
 import {ToolRegistry} from './tools/ToolRegistry.js';
 
 const SKILL_DISPLAY_NAMES: Record<SkillName, string> = {
@@ -71,6 +76,10 @@ If the user asks a question that requires an investigation or debugging, use thi
 * **CRITICAL**: Do not expose raw, internal system identifiers (such as database IDs, internal node paths, or event keys) directly to the user. Use descriptive names instead.`;
 
 export interface AiAgent2Options extends ExecuteJsAgentOptions {
+  /**
+   * Supplies the origin lock state for the conversation.
+   */
+  originLock: () => OriginLockState;
   lighthouseRecording?: (overrides?: LHModel.RunTypes.RunOverrides) => Promise<LHModel.ReporterTypes.ReportJSON|null>;
   performanceRecordAndReload?: () => Promise<Trace.TraceModel.ParsedTrace>;
 }
@@ -85,7 +94,7 @@ export class AiAgent2 extends AiAgent<unknown> {
 
   #changes: ChangeManager;
   #execJs: typeof executeJsCode;
-  readonly #allowedOrigin?: () => AllowedOriginResult;
+  readonly #originLock: () => OriginLockState;
   readonly #lighthouseRecording?:
       (overrides?: LHModel.RunTypes.RunOverrides) => Promise<LHModel.ReporterTypes.ReportJSON|null>;
   readonly #performanceRecordAndReload?: () => Promise<Trace.TraceModel.ParsedTrace>;
@@ -102,11 +111,10 @@ export class AiAgent2 extends AiAgent<unknown> {
     }
 
     const target = this.targetManager.primaryPageTarget();
-    const establishedOrigin = this.#getConversationOrigin();
+    const originLock = this.#originLock();
     // Avoid fetching or caching top-level documents across origins or when
     // the origin lock is blocked/uninitialized.
-    // Note: b/559642568 tracks making the tri-state ('blocked' | 'uninitialized' | 'locked') explicit.
-    const isTargetAllowed = target && isOriginAllowedByLock(establishedOrigin, target.inspectedSecurityOrigin());
+    const isTargetAllowed = target && isOriginAllowedByLock(originLock, target.inspectedSecurityOrigin());
     const domModel = isTargetAllowed ? target.model(SDK.DOMModel.DOMModel) : null;
     // Ensure the DOM document is requested and cached in DOMModel so that
     // subsequent synchronous lookups via domModel.existingDocument() (e.g.,
@@ -138,7 +146,7 @@ export class AiAgent2 extends AiAgent<unknown> {
     this.#lighthouseRecording = opts.lighthouseRecording;
     this.#performanceRecordAndReload = opts.performanceRecordAndReload;
     this.#execJs = opts.execJs ?? executeJsCode;
-    this.#allowedOrigin = opts.allowedOrigin;
+    this.#originLock = opts.originLock;
     this.#declaredTools.add('learnSkills');
     this.declareFunction<{skills: SkillName[]}>('learnSkills', {
       description: () => {
@@ -297,7 +305,7 @@ User query: ${enhancedQuery}`;
           execJs: this.#execJs,
           getExecutionContextNode: () => this.#getExecutionContextNode(),
           getTarget: () => this.#getTarget(),
-          getEstablishedOrigin: () => this.#getConversationOrigin(),
+          getOriginLock: () => this.#originLock(),
           getLighthouseReport: () => (this.context instanceof AccessibilityContext ? this.context.getItem() : null),
           runLighthouse: async overrides => await (this.#lighthouseRecording?.(overrides) ?? null),
           getPerformanceTraceContext: () => (this.context instanceof PerformanceTraceContext ? this.context : null),
@@ -318,8 +326,7 @@ User query: ${enhancedQuery}`;
    * perform their own origin checks on the resolved entities.
    */
   #getTarget(): SDK.Target.Target|null {
-    const allowed = this.#allowedOrigin?.();
-    if (allowed && 'blocked' in allowed) {
+    if (this.#originLock().status === 'BLOCKED_BY_NAVIGATION') {
       return null;
     }
     return this.targetManager.primaryPageTarget();
@@ -329,7 +336,7 @@ User query: ${enhancedQuery}`;
    * For non-DOM contexts (e.g., Lighthouse accessibility reports or storage items),
    * there is no user-selected DOM node. We fall back to the document body as the
    * default execution context node so scripts have a valid `$0` target.
-   * Fails closed and returns null if the conversation origin is not established or
+   * Returns null if the conversation origin is not established or
    * does not match the primary page document's security origin.
    */
   #getDocumentBodyNode(): SDK.DOMModel.DOMNode|null {
@@ -338,18 +345,13 @@ User query: ${enhancedQuery}`;
     if (!document) {
       return null;
     }
-    const establishedOrigin = this.#getConversationOrigin();
-    if (!isOriginAllowedByLock(establishedOrigin, document.securityOrigin())) {
+    const originLock = this.#originLock();
+    if (!isOriginAllowedByLock(originLock, document.securityOrigin())) {
       return null;
     }
     return document.body ?? null;
   }
 
-  #getConversationOrigin(): SDK.SecurityOrigin.SecurityOrigin|undefined {
-    const allowed = this.#allowedOrigin?.();
-    return allowed && 'origin' in allowed ? allowed.origin : undefined;
-  }
-
   get activeSkills(): Set<SkillName> {
     return this.#activeSkills;
   }

package/front_end/models/ai_assistance/AiConversation.ts

@@ -38,7 +38,7 @@ import {FileContext} from './contexts/FileContext.js';
 import {PerformanceTraceContext} from './contexts/PerformanceTraceContext.js';
 import {RequestContext} from './contexts/RequestContext.js';
 import {StorageContext} from './contexts/StorageContext.js';
-import {ToolAnnotation} from './tools/Tool.js';
+import {type OriginLockState, ToolAnnotation} from './tools/Tool.js';
 import {ToolRegistry} from './tools/ToolRegistry.js';
 
 export const NOT_FOUND_IMAGE_DATA = '';
@@ -381,7 +381,7 @@ export class AiConversation {
     const isTransitioningFromStorage = previousType === ConversationType.STORAGE && type !== ConversationType.STORAGE;
     const history = isTransitioningFromStorage ? [] : this.#filterHistoryForNewAgent();
 
-    const options = {
+    const baseOptions = {
       aidaClient: this.#aidaClient,
       serverSideLoggingAllowed: isAiAssistanceServerSideLoggingAllowed(),
       sessionId: this.id,
@@ -390,13 +390,18 @@ export class AiConversation {
       onInspectElement: this.#onInspectElement,
       networkTimeCalculator: this.#networkTimeCalculator,
       lighthouseRecording: this.#lighthouseRecording,
-      allowedOrigin: this.allowedOrigin,
       history,
       targetManager: this.#targetManager,
     };
 
-    this.#agent = Root.Runtime.hostConfig.devToolsAiV2Architecture?.enabled ? new AiAgent2(options) :
-                                                                              this.#createV1Agent(type, options);
+    this.#agent = Root.Runtime.hostConfig.devToolsAiV2Architecture?.enabled ? new AiAgent2({
+      ...baseOptions,
+      originLock: this.getOriginLock,
+    }) :
+                                                                              this.#createV1Agent(type, {
+                                                                                ...baseOptions,
+                                                                                allowedOrigin: this.allowedOrigin,
+                                                                              });
   }
 
   #createV1Agent(type: ConversationType, options: AgentOptions): AiAgent<unknown> {
@@ -553,19 +558,40 @@ export class AiConversation {
   }
 
   /**
-   * Returns the permitted origin for agent tool execution, or blocks execution
-   * if an unapproved cross-origin navigation occurred during the current run.
+   * Returns the conversation's origin-locking state:
+   * - `BLOCKED_BY_NAVIGATION`: An unapproved cross-origin navigation occurred during the active run.
+   * - `ESTABLISHED_ORIGIN`: The conversation is locked to the established origin.
+   * - `UNINITIALIZED`: No origin lock has been established yet.
    */
-  allowedOrigin = (): AllowedOriginResult => {
+  getOriginLock = (): OriginLockState => {
     if (this.#navigationOccurredDuringRun) {
-      return {blocked: true};
+      return {status: 'BLOCKED_BY_NAVIGATION'};
     }
     if (this.#origin) {
-      return {origin: this.#origin};
+      return {status: 'ESTABLISHED_ORIGIN', origin: this.#origin};
+    }
+    const pageOrigin = getPrimaryPageSecurityOrigin(this.#targetManager);
+    if (pageOrigin) {
+      this.#origin = pageOrigin;
+      return {status: 'ESTABLISHED_ORIGIN', origin: this.#origin};
     }
-    this.#origin = getPrimaryPageSecurityOrigin(this.#targetManager);
 
-    return {origin: this.#origin};
+    return {status: 'UNINITIALIZED'};
+  };
+
+  /**
+   * Returns the permitted origin for legacy V1 agent tool execution.
+   * Maps the OriginLockState to the AllowedOriginResult format expected by V1 agents.
+   */
+  allowedOrigin = (): AllowedOriginResult => {
+    const lock = this.getOriginLock();
+    if (lock.status === 'BLOCKED_BY_NAVIGATION') {
+      return {blocked: true};
+    }
+    if (lock.status === 'ESTABLISHED_ORIGIN') {
+      return {origin: lock.origin};
+    }
+    return {origin: undefined};
   };
 }
 

package/front_end/models/ai_assistance/agents/AccessibilityAgent.ts

@@ -11,7 +11,10 @@ import {ChangeManager} from '../ChangeManager.js';
 import {LighthouseFormatter} from '../data_formatters/LighthouseFormatter.js';
 import {debugLog} from '../debug.js';
 import {ExtensionScope} from '../ExtensionScope.js';
-import {ToolName} from '../tools/Tool.js';
+import {
+  type OriginLockState,
+  ToolName,
+} from '../tools/Tool.js';
 import {ToolRegistry} from '../tools/ToolRegistry.js';
 
 import {
@@ -253,7 +256,11 @@ export class AccessibilityAgent extends AiAgent<LHModel.ReporterTypes.ReportJSON
               createExtensionScope: this.#createExtensionScope.bind(this),
               execJs: this.#execJs,
               getExecutionContextNode: () => this.#getDocumentBodyNode(),
-              getEstablishedOrigin: () => this.context?.getOrigin(),
+              getOriginLock: (): OriginLockState => {
+                // V1 AccessibilityAgent adapts the selected node's security origin to OriginLockState.
+                const origin = this.context?.getOrigin();
+                return origin ? {status: 'ESTABLISHED_ORIGIN', origin} : {status: 'UNINITIALIZED'};
+              },
             },
             options,
         );