chrome-devtools-frontend 1.0.1683520 → 1.0.1689415

package/inspector_overlay/tool_persistent.ts

@@ -68,25 +68,25 @@ export class PersistentOverlay extends Overlay {
   private dragHandler?: DragResizeHandler;
   private greenDevAnchorsOverlay?: GreenDevAnchorsOverlay;
 
-  setGreenDevAnchorsOverlay(greenDevAnchorsOverlay: GreenDevAnchorsOverlay) {
+  setGreenDevAnchorsOverlay(greenDevAnchorsOverlay: GreenDevAnchorsOverlay): void {
     this.greenDevAnchorsOverlay = greenDevAnchorsOverlay;
   }
 
-  override reset(data: ResetData) {
+  override reset(data: ResetData): void {
     super.reset(data);
     this.gridLabelState.gridLayerCounter = 0;
     this.gridLabels.innerHTML = '';
     this.greenDevAnchorsOverlay?.reset(data);
   }
 
-  renderGridMarkup() {
+  renderGridMarkup(): void {
     const gridLabels = this.document.createElement('div');
     gridLabels.id = 'grid-label-container';
     this.document.body.append(gridLabels);
     this.gridLabels = gridLabels;
   }
 
-  override install() {
+  override install(): void {
     this.document.body.classList.add('fill');
 
     const canvas = this.document.createElement('canvas');
@@ -102,7 +102,7 @@ export class PersistentOverlay extends Overlay {
     this.dragHandler?.install();
   }
 
-  override uninstall() {
+  override uninstall(): void {
     this.document.body.classList.remove('fill');
     this.document.body.innerHTML = '';
     this.draggableBorders = new Map();
@@ -110,7 +110,7 @@ export class PersistentOverlay extends Overlay {
     this.dragHandler?.uninstall();
   }
 
-  drawGridHighlight(highlight: GridHighlight) {
+  drawGridHighlight(highlight: GridHighlight): void {
     this.context.save();
     drawLayoutGridHighlight(
         highlight, this.context, this.deviceScaleFactor, this.canvasWidth, this.canvasHeight, this.emulationScaleFactor,
@@ -118,32 +118,32 @@ export class PersistentOverlay extends Overlay {
     this.context.restore();
   }
 
-  drawFlexContainerHighlight(highlight: FlexContainerHighlight) {
+  drawFlexContainerHighlight(highlight: FlexContainerHighlight): void {
     this.context.save();
     drawLayoutFlexContainerHighlight(highlight, this.context, this.emulationScaleFactor);
     this.context.restore();
   }
 
-  drawScrollSnapHighlight(highlight: ScrollSnapHighlight) {
+  drawScrollSnapHighlight(highlight: ScrollSnapHighlight): void {
     this.context.save();
     drawScrollSnapHighlight(highlight, this.context, this.emulationScaleFactor);
     this.context.restore();
   }
 
-  drawContainerQueryHighlight(highlight: ContainerQueryHighlight) {
+  drawContainerQueryHighlight(highlight: ContainerQueryHighlight): void {
     this.context.save();
     drawContainerQueryHighlight(highlight, this.context, this.emulationScaleFactor);
     this.context.restore();
   }
 
-  drawGreenDevFloatyAnchors(highlights: GreenDevAnchorsHighlight[]) {
+  drawGreenDevFloatyAnchors(highlights: GreenDevAnchorsHighlight[]): void {
     if (this.greenDevAnchorsOverlay && !this.greenDevAnchorsOverlay.installed) {
       this.greenDevAnchorsOverlay.install();
     }
     this.greenDevAnchorsOverlay?.drawGreenDevAnchors(highlights);
   }
 
-  drawIsolatedElementHighlight(highlight: IsolatedElementHighlight) {
+  drawIsolatedElementHighlight(highlight: IsolatedElementHighlight): void {
     if (!this.dragHandler) {
       this.dragHandler = new DragResizeHandler(this.document, makeDraggableDelegate(this));
       this.dragHandler.install();

package/inspector_overlay/tool_screenshot.ts

@@ -25,7 +25,7 @@ export class ScreenshotOverlay extends Overlay {
     this.onKeyDown = this.onKeyDown.bind(this);
   }
 
-  override install() {
+  override install(): void {
     const root = this.document.documentElement;
     root.addEventListener('mousedown', this.onMouseDown, true);
     root.addEventListener('mouseup', this.onMouseUp, true);
@@ -41,7 +41,7 @@ export class ScreenshotOverlay extends Overlay {
     super.install();
   }
 
-  override uninstall() {
+  override uninstall(): void {
     this.document.body.innerHTML = '';
     const root = this.document.documentElement;
     root.removeEventListener('mousedown', this.onMouseDown, true);
@@ -51,7 +51,7 @@ export class ScreenshotOverlay extends Overlay {
     super.uninstall();
   }
 
-  onMouseDown(event: MouseEvent) {
+  onMouseDown(event: MouseEvent): void {
     anchor = {x: event.pageX, y: event.pageY};
     position = anchor;
     this.updateZone();
@@ -59,7 +59,7 @@ export class ScreenshotOverlay extends Overlay {
     event.preventDefault();
   }
 
-  onMouseUp(event: MouseEvent) {
+  onMouseUp(event: MouseEvent): void {
     if (anchor && position) {
       const rect = currentRect();
       if (rect.width >= 5 && rect.height >= 5) {
@@ -72,7 +72,7 @@ export class ScreenshotOverlay extends Overlay {
     event.preventDefault();
   }
 
-  onMouseMove(event: MouseEvent) {
+  onMouseMove(event: MouseEvent): void {
     if (anchor && event.buttons === 1) {
       position = {x: event.pageX, y: event.pageY};
     } else {
@@ -83,7 +83,7 @@ export class ScreenshotOverlay extends Overlay {
     event.preventDefault();
   }
 
-  onKeyDown(event: KeyboardEvent) {
+  onKeyDown(event: KeyboardEvent): void {
     if (anchor && event.key === 'Escape') {
       cancel();
       this.updateZone();
@@ -92,7 +92,7 @@ export class ScreenshotOverlay extends Overlay {
     }
   }
 
-  updateZone() {
+  updateZone(): void {
     const zone = this.zone;
     if (!position || !anchor) {
       zone.style.display = 'none';

package/inspector_overlay/tool_source_order.ts

@@ -19,12 +19,12 @@ interface SourceOrderHighlight {
 export class SourceOrderOverlay extends Overlay {
   private sourceOrderContainer!: HTMLElement;
 
-  override reset(resetData: ResetData) {
+  override reset(resetData: ResetData): void {
     super.reset(resetData);
     this.sourceOrderContainer.textContent = '';
   }
 
-  override install() {
+  override install(): void {
     this.document.body.classList.add('fill');
 
     const canvas = this.document.createElement('canvas');
@@ -42,13 +42,13 @@ export class SourceOrderOverlay extends Overlay {
     super.install();
   }
 
-  override uninstall() {
+  override uninstall(): void {
     this.document.body.classList.remove('fill');
     this.document.body.innerHTML = '';
     super.uninstall();
   }
 
-  drawSourceOrder(highlight: SourceOrderHighlight) {
+  drawSourceOrder(highlight: SourceOrderHighlight): {bounds: PathBounds} {
     const sourceOrder = highlight.sourceOrder || 0;
     const path = highlight.paths.slice().pop();
 

package/inspector_overlay/tool_viewport_size.ts

@@ -12,7 +12,7 @@ function formatNumber(n: number): string {
 }
 
 export class ViewportSizeOverlay extends Overlay {
-  override install() {
+  override install(): void {
     this.document.body.classList.add('fill');
     const canvas = this.document.createElement('canvas');
     canvas.id = 'canvas';
@@ -22,13 +22,13 @@ export class ViewportSizeOverlay extends Overlay {
     super.install();
   }
 
-  override uninstall() {
+  override uninstall(): void {
     this.document.body.classList.remove('fill');
     this.document.body.innerHTML = '';
     super.uninstall();
   }
 
-  drawViewSize() {
+  drawViewSize(): void {
     const viewportSize = this.viewportSizeForMediaQueries || this.viewportSize;
     const text = `${formatNumber(viewportSize.width)}px \xD7 ${formatNumber(viewportSize.height)}px`;
     const canvasWidth = this.canvasWidth || 0;

package/inspector_overlay/tool_window_controls.ts

@@ -23,7 +23,7 @@ export class WindowControlsOverlay extends Overlay {
     super(window, style);
   }
 
-  override install() {
+  override install(): void {
     const windowLinuxToolbarIcons = ['chevron', 'ellipsis', 'minimize', 'maximize', 'close'];
     const macLeftToolbarIcons = ['mac-close', 'mac-minimize', 'mac-maximize'];
     const macRightToolbarIcons = ['mac-chevron', 'mac-ellipsis'];
@@ -37,7 +37,7 @@ export class WindowControlsOverlay extends Overlay {
     super.install();
   }
 
-  override uninstall() {
+  override uninstall(): void {
     this.windowsToolBar.remove();
     this.linuxToolBar.remove();
     this.macToolbarRight.remove();
@@ -45,7 +45,7 @@ export class WindowControlsOverlay extends Overlay {
     super.uninstall();
   }
 
-  drawWindowControlsOverlay(config: WindowControlsOverlayConfig) {
+  drawWindowControlsOverlay(config: WindowControlsOverlayConfig): void {
     // Clear all overlays
     this.clearOverlays();
 
@@ -64,7 +64,7 @@ export class WindowControlsOverlay extends Overlay {
     this.document.documentElement.style.setProperty('--wco-icon-color', generateLegibleTextColor(config.themeColor));
   }
 
-  clearOverlays() {
+  clearOverlays(): void {
     hideElement(this.linuxToolBar);
     hideElement(this.windowsToolBar);
     hideElement(this.macToolbarLeft);

package/mcp/mcp.ts

@@ -20,6 +20,7 @@ export {DebuggerModel, skipAllPausesSettingDescriptor} from '../front_end/core/s
 export * as DOMModel from '../front_end/core/sdk/DOMModel.js';
 export * as NetworkManager from '../front_end/core/sdk/NetworkManager.js';
 export {RuntimeModel} from '../front_end/core/sdk/RuntimeModel.js';
+export * as SDKSettings from '../front_end/core/sdk/SDKSettings.js';
 export * as SourceMapManager from '../front_end/core/sdk/SourceMapManager.js';
 export {Target} from '../front_end/core/sdk/Target.js';
 export {TargetManager} from '../front_end/core/sdk/TargetManager.js';

package/package.json

@@ -24,7 +24,7 @@
     "debug-webtest": "vpython3 third_party/node/node.py --output scripts/npm_test.js --debug-devtools",
     "generate-protocol-resources": "vpython3 scripts/deps/generate_protocol_resources.py && git cl format --js",
     "install-deps": "vpython3 scripts/deps/manage_node_deps.py",
-    "lint": "vpython3 third_party/node/node.py --output scripts/test/run_lint_check.mjs",
+    "lint": "vpython3 third_party/node/node.py --output scripts/lint/run_lint_check.mjs",
     "prebuild": "gn gen out/Default",
     "rdb": "rdb stream -new -realm chromium:public --",
     "start": "vpython3 third_party/node/node.py --output scripts/run_start.mjs",
@@ -92,5 +92,5 @@
     "webidl2": "24.5.0",
     "yargs": "17.7.2"
   },
-  "version": "1.0.1683520"
+  "version": "1.0.1689415"
 }

package/front_end/generated/protocol-tsconfig.json

@@ -1,10 +0,0 @@
-{
-  "compilerOptions": {
-    "composite": true
-  },
-  "files": [
-    "protocol.ts",
-    "protocol-mapping.d.ts",
-    "protocol-proxy-api.d.ts"
-  ]
-}

package/front_end/panels/js_timeline/DIR_METADATA

@@ -1,3 +0,0 @@
-buganizer_public: {
-  component_id: 1457310
-}

package/front_end/panels/js_timeline/js_timeline-meta.ts

@@ -1,193 +0,0 @@
-// Copyright 2020 The Chromium Authors
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-import * as Common from '../../core/common/common.js';
-import * as i18n from '../../core/i18n/i18n.js';
-import * as UI from '../../ui/legacy/legacy.js';
-import type * as Timeline from '../timeline/timeline.js';
-
-const UIStrings = {
-  /**
-   * @description Title of the Performance panel.
-   */
-  performance: 'Performance',
-  /**
-   * @description Command for showing the Performance panel.
-   */
-  showPerformance: 'Show Performance',
-  /**
-   * @description Title of an action in the Performance panel to show history.
-   */
-  showRecentTimelineSessions: 'Show recent timeline sessions',
-  /**
-   * @description Text to record a series of actions for analysis.
-   */
-  record: 'Record',
-  /**
-   * @description Text of an item that stops the running task.
-   */
-  stop: 'Stop',
-  /**
-   * @description Title of an action in the Performance panel to record a reload of the current page.
-   */
-  recordAndReload: 'Record and reload',
-  /**
-   * @description Title of a setting under the Performance category in Settings.
-   */
-  timelineShowAllEvents: 'Show all events',
-  /**
-   * @description Title of a setting under the Performance category in Settings.
-   */
-  timelineDebugMode: 'Timeline debug mode (trace event details, etc.)',
-} as const;
-const str_ = i18n.i18n.registerUIStrings('panels/js_timeline/js_timeline-meta.ts', UIStrings);
-const i18nLazyString = i18n.i18n.getLazilyComputedLocalizedString.bind(undefined, str_);
-
-let loadedTimelineModule: (typeof Timeline|undefined);
-
-async function loadTimelineModule(): Promise<typeof Timeline> {
-  if (!loadedTimelineModule) {
-    loadedTimelineModule = await import('../timeline/timeline.js');
-  }
-  return loadedTimelineModule;
-}
-
-function maybeRetrieveTimelineContextTypes<T = unknown>(getClassCallBack: (timelineModule: typeof Timeline) => T[]):
-    T[] {
-  if (loadedTimelineModule === undefined) {
-    return [];
-  }
-  return getClassCallBack(loadedTimelineModule);
-}
-
-UI.ViewManager.registerViewExtension({
-  location: UI.ViewManager.ViewLocationValues.PANEL,
-  id: 'timeline',
-  title: i18nLazyString(UIStrings.performance),
-  commandPrompt: i18nLazyString(UIStrings.showPerformance),
-  order: 66,
-  hasToolbar: false,
-  isPreviewFeature: true,
-  async loadView(universe) {
-    const Timeline = await loadTimelineModule();
-    const {pageResourceLoader: resourceLoader, targetManager, isolateManager} = universe;
-    return Timeline.TimelinePanel.TimelinePanel.instance(
-        {forceNew: true, resourceLoader, targetManager, isolateManager});
-  },
-});
-
-UI.ActionRegistration.registerActionExtension({
-  actionId: 'timeline.show-history',
-  async loadActionDelegate() {
-    const Timeline = await loadTimelineModule();
-    return new Timeline.TimelinePanel.ActionDelegate();
-  },
-  category: UI.ActionRegistration.ActionCategory.PERFORMANCE,
-  title: i18nLazyString(UIStrings.showRecentTimelineSessions),
-  contextTypes() {
-    return maybeRetrieveTimelineContextTypes(Timeline => [Timeline.TimelinePanel.TimelinePanel]);
-  },
-  bindings: [
-    {
-      platform: UI.ActionRegistration.Platforms.WINDOWS_LINUX,
-      shortcut: 'Ctrl+H',
-    },
-    {
-      platform: UI.ActionRegistration.Platforms.MAC,
-      shortcut: 'Meta+Y',
-    },
-  ],
-});
-
-UI.ActionRegistration.registerActionExtension({
-  actionId: 'timeline.toggle-recording',
-  category: UI.ActionRegistration.ActionCategory.PERFORMANCE,
-  iconClass: UI.ActionRegistration.IconClass.START_RECORDING,
-  toggleable: true,
-  toggledIconClass: UI.ActionRegistration.IconClass.STOP_RECORDING,
-  toggleWithRedColor: true,
-  contextTypes() {
-    return maybeRetrieveTimelineContextTypes(Timeline => [Timeline.TimelinePanel.TimelinePanel]);
-  },
-  async loadActionDelegate() {
-    const Timeline = await loadTimelineModule();
-    return new Timeline.TimelinePanel.ActionDelegate();
-  },
-  options: [
-    {
-      value: true,
-      title: i18nLazyString(UIStrings.record),
-    },
-    {
-      value: false,
-      title: i18nLazyString(UIStrings.stop),
-    },
-  ],
-  bindings: [
-    {
-      platform: UI.ActionRegistration.Platforms.WINDOWS_LINUX,
-      shortcut: 'Ctrl+E',
-    },
-    {
-      platform: UI.ActionRegistration.Platforms.MAC,
-      shortcut: 'Meta+E',
-    },
-  ],
-});
-
-UI.ActionRegistration.registerActionExtension({
-  actionId: 'timeline.record-reload',
-  iconClass: UI.ActionRegistration.IconClass.REFRESH,
-  contextTypes() {
-    return maybeRetrieveTimelineContextTypes(Timeline => [Timeline.TimelinePanel.TimelinePanel]);
-  },
-  category: UI.ActionRegistration.ActionCategory.PERFORMANCE,
-  title: i18nLazyString(UIStrings.recordAndReload),
-  async loadActionDelegate() {
-    const Timeline = await loadTimelineModule();
-    return new Timeline.TimelinePanel.ActionDelegate();
-  },
-  bindings: [
-    {
-      platform: UI.ActionRegistration.Platforms.WINDOWS_LINUX,
-      shortcut: 'Ctrl+Shift+E',
-    },
-    {
-      platform: UI.ActionRegistration.Platforms.MAC,
-      shortcut: 'Meta+Shift+E',
-    },
-  ],
-});
-
-// IMPORTANT: if you are updating this, you should also update the setting in
-// timeline-meta.
-Common.Settings.registerSettingExtension({
-  category: Common.Settings.SettingCategory.PERFORMANCE,
-  storageType: Common.Settings.SettingStorageType.SYNCED,
-  title: i18nLazyString(UIStrings.timelineShowAllEvents),
-  settingName: 'timeline-show-all-events',
-  settingType: Common.Settings.SettingType.BOOLEAN,
-  defaultValue: false,
-});
-
-// IMPORTANT: if you are updating this, you should also update the setting in
-// timeline-meta.
-Common.Settings.registerSettingExtension({
-  category: Common.Settings.SettingCategory.PERFORMANCE,
-  storageType: Common.Settings.SettingStorageType.SYNCED,
-  title: i18nLazyString(UIStrings.timelineDebugMode),
-  settingName: 'timeline-debug-mode',
-  settingType: Common.Settings.SettingType.BOOLEAN,
-  defaultValue: false,
-});
-
-// IMPORTANT: if you are updating this, you should also update the setting in
-// timeline-meta.
-Common.Settings.registerSettingExtension({
-  category: Common.Settings.SettingCategory.PERFORMANCE,
-  storageType: Common.Settings.SettingStorageType.SYNCED,
-  settingName: 'annotations-hidden',
-  settingType: Common.Settings.SettingType.BOOLEAN,
-  defaultValue: true,
-});

package/front_end/panels/js_timeline/js_timeline.ts

@@ -1 +0,0 @@
-// File intentionally left blank, as the Runtime unconditionally imports entrypoints