chrome-devtools-frontend 1.0.1683520 → 1.0.1689415

package/front_end/models/trace/LanternComputationData.ts

@@ -269,9 +269,8 @@ function linkInitiators(lanternRequests: NetworkRequest[]): void {
   }
 }
 
-function createNetworkRequests(
-    trace: Lantern.Types.Trace, data: Handlers.Types.HandlerData, startTime = 0,
-    endTime = Number.POSITIVE_INFINITY): NetworkRequest[] {
+function createNetworkRequests(trace: Lantern.Types.Trace, data: Handlers.Types.HandlerData, startTime = 0,
+                               endTime: number = Number.POSITIVE_INFINITY): NetworkRequest[] {
   const workerThreads = findWorkerThreads(trace);
 
   const lanternRequestsNoRedirects: NetworkRequest[] = [];

package/front_end/models/trace/extras/StackTraceForEvent.ts

@@ -7,8 +7,9 @@ import type * as Handlers from '../handlers/handlers.js';
 import * as Helpers from '../helpers/helpers.js';
 import * as Types from '../types/types.js';
 
-export const stackTraceForEventInTrace =
-    new Map<Handlers.Types.HandlerData, Map<Types.Events.Event, Protocol.Runtime.StackTrace>>();
+export const stackTraceForEventInTrace:
+    Map<Handlers.Types.HandlerData, Map<Types.Events.Event, Protocol.Runtime.StackTrace>> =
+        new Map<Handlers.Types.HandlerData, Map<Types.Events.Event, Protocol.Runtime.StackTrace>>();
 
 export function clearCacheForTrace(data: Handlers.Types.HandlerData): void {
   stackTraceForEventInTrace.delete(data);

package/front_end/models/trace/extras/ThirdParties.ts

@@ -52,7 +52,7 @@ function collectMainThreadActivity(data: Handlers.Types.HandlerData): Types.Even
 
 export function summarizeByThirdParty(
     data: Handlers.Types.HandlerData, traceBounds: Types.Timing.TraceWindowMicro): EntitySummary[] {
-  const mainThreadEvents = collectMainThreadActivity(data).sort(Helpers.Trace.eventTimeComparator);
+  const mainThreadEvents = collectMainThreadActivity(data);
   const groupingFunction = (event: Types.Events.Event): string => {
     const entity = data.Renderer.entityMappings.entityByEvent.get(event);
     return entity?.name ?? '';
@@ -68,7 +68,7 @@ export function summarizeByThirdParty(
  */
 export function summarizeByURL(
     data: Handlers.Types.HandlerData, traceBounds: Types.Timing.TraceWindowMicro): URLSummary[] {
-  const mainThreadEvents = collectMainThreadActivity(data).sort(Helpers.Trace.eventTimeComparator);
+  const mainThreadEvents = collectMainThreadActivity(data);
   const groupingFunction = (event: Types.Events.Event): string => {
     return Handlers.Helpers.getNonResolvedURL(event, data) ?? '';
   };
@@ -140,20 +140,20 @@ function summarizeBottomUpByURL(root: TraceTree.BottomUpRootNode, data: Handlers
   return summaries;
 }
 
+// Use the same filtering as front_end/panels/timeline/TimelineTreeView.ts.
+const exclusiveNameFilter = new TraceFilter.ExclusiveNameFilter([]);
+const visibleEventsFilter = new TraceFilter.VisibleEventsFilter(
+    [...Helpers.Trace.VISIBLE_TRACE_EVENT_TYPES.values(), Types.Events.Name.SYNTHETIC_NETWORK_REQUEST]);
+
 function getBottomUpTree(
     mainThreadEvents: Types.Events.Event[], tracebounds: Types.Timing.TraceWindowMicro,
     groupingFunction: ((arg0: Types.Events.Event) => string)|null): TraceTree.BottomUpRootNode {
-  // Use the same filtering as front_end/panels/timeline/TimelineTreeView.ts.
-  const visibleEvents = Helpers.Trace.VISIBLE_TRACE_EVENT_TYPES.values().toArray();
-  const filter =
-      new TraceFilter.VisibleEventsFilter(visibleEvents.concat([Types.Events.Name.SYNTHETIC_NETWORK_REQUEST]));
-
   // The bottom up root node handles all the "in Tracebounds" checks we need for the insight.
   const startTime = Helpers.Timing.microToMilli(tracebounds.min);
   const endTime = Helpers.Timing.microToMilli(tracebounds.max);
   return new TraceTree.BottomUpRootNode(mainThreadEvents, {
-    textFilter: new TraceFilter.ExclusiveNameFilter([]),
-    filters: [filter],
+    textFilter: exclusiveNameFilter,
+    filters: [visibleEventsFilter],
     startTime,
     endTime,
     eventGroupIdCallback: groupingFunction,

package/front_end/models/trace/handlers/AsyncJSCallsHandler.ts

@@ -8,13 +8,16 @@ import * as Types from '../types/types.js';
 import {data as flowsHandlerData} from './FlowsHandler.js';
 import {data as rendererHandlerData} from './RendererHandler.js';
 
-let schedulerToRunEntryPoints = new Map<Types.Events.Event, Types.Events.Event[]>();
+let schedulerToRunEntryPoints: Map<Types.Events.Event, Types.Events.Event[]> =
+    new Map<Types.Events.Event, Types.Events.Event[]>();
 
-let taskScheduleForTaskRunEvent = new Map<Types.Events.DebuggerAsyncTaskRun, Types.Events.DebuggerAsyncTaskScheduled>();
-let asyncCallToScheduler =
+let taskScheduleForTaskRunEvent: Map<Types.Events.DebuggerAsyncTaskRun, Types.Events.DebuggerAsyncTaskScheduled> =
+    new Map<Types.Events.DebuggerAsyncTaskRun, Types.Events.DebuggerAsyncTaskScheduled>();
+let asyncCallToScheduler: Map<Types.Events.SyntheticProfileCall, {taskName: string, scheduler: Types.Events.Event}> =
     new Map<Types.Events.SyntheticProfileCall, {taskName: string, scheduler: Types.Events.Event}>();
 
-let runEntryPointToScheduler = new Map<Types.Events.Event, {taskName: string, scheduler: Types.Events.Event}>();
+let runEntryPointToScheduler: Map<Types.Events.Event, {taskName: string, scheduler: Types.Events.Event}> =
+    new Map<Types.Events.Event, {taskName: string, scheduler: Types.Events.Event}>();
 
 export function reset(): void {
   schedulerToRunEntryPoints = new Map();

package/front_end/models/trace/handlers/FramesHandler.ts

@@ -390,10 +390,10 @@ class TimelineFrame implements Types.Events.LegacyTimelineFrame {
   // Types.Events.Event.
   cat = 'devtools.legacy_frame';
   name = 'frame';
-  ph = Types.Events.Phase.COMPLETE;
+  ph: Types.Events.Phase = Types.Events.Phase.COMPLETE;
   ts: Types.Timing.Micro;
-  pid = Types.Events.ProcessID(-1);
-  tid = Types.Events.ThreadID(-1);
+  pid: Types.Events.ProcessID = Types.Events.ProcessID(-1);
+  tid: Types.Events.ThreadID = Types.Events.ThreadID(-1);
 
   index = -1;
   startTime: Types.Timing.Micro;

package/front_end/models/trace/handlers/LayoutShiftsHandler.ts

@@ -67,13 +67,13 @@ interface RemoteFont {
  * This represents the maximum #time we will allow a cluster to go before we
  * reset it.
  **/
-export const MAX_CLUSTER_DURATION = Helpers.Timing.milliToMicro(Types.Timing.Milli(5000));
+export const MAX_CLUSTER_DURATION: Types.Timing.Micro = Helpers.Timing.milliToMicro(Types.Timing.Milli(5000));
 
 /**
  * This represents the maximum #time we will allow between layout shift events
  * before considering it to be the start of a new cluster.
  **/
-export const MAX_SHIFT_TIME_DELTA = Helpers.Timing.milliToMicro(Types.Timing.Milli(1000));
+export const MAX_SHIFT_TIME_DELTA: Types.Timing.Micro = Helpers.Timing.milliToMicro(Types.Timing.Milli(1000));
 
 // Layout shifts are reported globally to the developer, irrespective of which
 // frame they originated in. However, each process does have its own individual

package/front_end/models/trace/handlers/SamplesHandler.ts

@@ -8,8 +8,10 @@ import * as CPUProfile from '../../cpu_profile/cpu_profile.js';
 import * as Helpers from '../helpers/helpers.js';
 import * as Types from '../types/types.js';
 
-let profilesInProcess = new Map<Types.Events.ProcessID, Map<Types.Events.ThreadID, ProfileData>>();
-let entryToNode = new Map<Types.Events.Event, Helpers.TreeHelpers.TraceEntryNode>();
+let profilesInProcess: Map<Types.Events.ProcessID, Map<Types.Events.ThreadID, ProfileData>> =
+    new Map<Types.Events.ProcessID, Map<Types.Events.ThreadID, ProfileData>>();
+let entryToNode: Map<Types.Events.Event, Helpers.TreeHelpers.TraceEntryNode> =
+    new Map<Types.Events.Event, Helpers.TreeHelpers.TraceEntryNode>();
 
 // The profile head, containing its metadata like its start
 // time, comes in a "Profile" event. The sample data comes in

package/front_end/models/trace/handlers/UserInteractionsHandler.ts

@@ -16,7 +16,7 @@ import type {HandlerName} from './types.js';
 let beginCommitCompositorFrameEvents: Types.Events.BeginCommitCompositorFrame[] = [];
 let parseMetaViewportEvents: Types.Events.ParseMetaViewport[] = [];
 
-export const LONG_INTERACTION_THRESHOLD = Helpers.Timing.milliToMicro(Types.Timing.Milli(200));
+export const LONG_INTERACTION_THRESHOLD: Types.Timing.Micro = Helpers.Timing.milliToMicro(Types.Timing.Milli(200));
 
 const INP_GOOD_TIMING = LONG_INTERACTION_THRESHOLD;
 const INP_MEDIUM_TIMING = Helpers.Timing.milliToMicro(Types.Timing.Milli(500));

package/front_end/models/trace/handlers/WarningsHandler.ts

@@ -42,9 +42,9 @@ let taskReflowEvents: Types.Events.Event[] = [];
  */
 let longTaskEvents: Types.Events.Event[] = [];
 
-export const FORCED_REFLOW_THRESHOLD = Helpers.Timing.milliToMicro(Types.Timing.Milli(30));
+export const FORCED_REFLOW_THRESHOLD: Types.Timing.Micro = Helpers.Timing.milliToMicro(Types.Timing.Milli(30));
 
-export const LONG_MAIN_THREAD_TASK_THRESHOLD = Helpers.Timing.milliToMicro(Types.Timing.Milli(50));
+export const LONG_MAIN_THREAD_TASK_THRESHOLD: Types.Timing.Micro = Helpers.Timing.milliToMicro(Types.Timing.Milli(50));
 
 export function reset(): void {
   warningsPerEvent = new Map();

package/front_end/models/trace/helpers/Network.ts

@@ -48,10 +48,10 @@ export interface CacheControl {
   'private'?: boolean;
 }
 
-export const CACHEABLE_STATUS_CODES = new Set([200, 203, 206]);
+export const CACHEABLE_STATUS_CODES: Set<number> = new Set([200, 203, 206]);
 
 /** @type {Set<LH.Crdp.Network.ResourceType>} */
-export const STATIC_RESOURCE_TYPES = new Set([
+export const STATIC_RESOURCE_TYPES: Set<Protocol.Network.ResourceType> = new Set([
   Protocol.Network.ResourceType.Font,
   Protocol.Network.ResourceType.Image,
   Protocol.Network.ResourceType.Media,
@@ -59,7 +59,7 @@ export const STATIC_RESOURCE_TYPES = new Set([
   Protocol.Network.ResourceType.Stylesheet,
 ]);
 
-export const NON_NETWORK_SCHEMES = [
+export const NON_NETWORK_SCHEMES: string[] = [
   'blob',        // @see https://developer.mozilla.org/en-US/docs/Web/API/URL/createObjectURL
   'data',        // @see https://developer.mozilla.org/en-US/docs/Web/HTTP/Basics_of_HTTP/Data_URIs
   'intent',      // @see https://developer.chrome.com/docs/multidevice/android/intents/

package/front_end/models/trace/helpers/Trace.ts

@@ -838,7 +838,7 @@ export function extractSampleTraceId(event: Types.Events.Event): number|null {
  * This exactly matches Trace.Styles.visibleTypes. See the runtime verification in maybeInitStylesMap.
  * TODO(crbug.com/410884528)
  **/
-export const VISIBLE_TRACE_EVENT_TYPES = new Set<Types.Events.Name>([
+export const VISIBLE_TRACE_EVENT_TYPES: Set<Types.Events.Name> = new Set<Types.Events.Name>([
   Types.Events.Name.ABORT_POST_TASK_CALLBACK,
   Types.Events.Name.ANIMATION,
   Types.Events.Name.ASYNC_TASK,

package/front_end/models/trace/insights/CLSCulprits.ts

@@ -72,7 +72,8 @@ export const UIStrings = {
 } as const;
 
 const str_ = i18n.i18n.registerUIStrings('models/trace/insights/CLSCulprits.ts', UIStrings);
-export const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
+export const i18nString: (id: string, values?: Record<string, string|number|boolean>) =>
+    Platform.UIString.LocalizedString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 
 export type CLSCulpritsInsightModel = InsightModel<typeof UIStrings, {
   animationFailures: readonly NoncompositedAnimationFailure[],

package/front_end/models/trace/insights/Cache.ts

@@ -3,6 +3,7 @@
 // found in the LICENSE file.
 
 import * as i18n from '../../../core/i18n/i18n.js';
+import type * as Platform from '../../../core/platform/platform.js';
 import * as Protocol from '../../../generated/protocol.js';
 import type * as Handlers from '../handlers/handlers.js';
 import * as Helpers from '../helpers/helpers.js';
@@ -48,7 +49,8 @@ export const UIStrings = {
 } as const;
 
 const str_ = i18n.i18n.registerUIStrings('models/trace/insights/Cache.ts', UIStrings);
-export const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
+export const i18nString: (id: string, values?: Record<string, string|number|boolean>) =>
+    Platform.UIString.LocalizedString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 
 export type CacheInsightModel = InsightModel<typeof UIStrings, {
   requests: Array<{

package/front_end/models/trace/insights/CharacterSet.ts

@@ -3,6 +3,7 @@
 // found in the LICENSE file.
 
 import * as i18n from '../../../core/i18n/i18n.js';
+import type * as Platform from '../../../core/platform/platform.js';
 import type * as Handlers from '../handlers/handlers.js';
 import type * as Types from '../types/types.js';
 
@@ -53,7 +54,8 @@ export const UIStrings = {
 } as const;
 
 const str_ = i18n.i18n.registerUIStrings('models/trace/insights/CharacterSet.ts', UIStrings);
-export const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
+export const i18nString: (id: string, values?: Record<string, string|number|boolean>) =>
+    Platform.UIString.LocalizedString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 
 const CHARSET_HTTP_REGEX = /charset\s*=\s*[a-zA-Z0-9\-_:.()]{2,}/i;
 

package/front_end/models/trace/insights/DOMSize.ts

@@ -4,6 +4,7 @@
 
 import type * as Common from '../../../core/common/common.js';
 import * as i18n from '../../../core/i18n/i18n.js';
+import type * as Platform from '../../../core/platform/platform.js';
 import * as Handlers from '../handlers/handlers.js';
 import * as Helpers from '../helpers/helpers.js';
 import * as Types from '../types/types.js';
@@ -72,7 +73,8 @@ export const UIStrings = {
 } as const;
 
 const str_ = i18n.i18n.registerUIStrings('models/trace/insights/DOMSize.ts', UIStrings);
-export const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
+export const i18nString: (id: string, values?: Record<string, string|number|boolean>) =>
+    Platform.UIString.LocalizedString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 
 const DOM_SIZE_DURATION_THRESHOLD = Helpers.Timing.milliToMicro(Types.Timing.Milli(40));
 

package/front_end/models/trace/insights/DocumentLatency.ts

@@ -3,6 +3,7 @@
 // found in the LICENSE file.
 
 import * as i18n from '../../../core/i18n/i18n.js';
+import type * as Platform from '../../../core/platform/platform.js';
 import type * as Handlers from '../handlers/handlers.js';
 import * as Helpers from '../helpers/helpers.js';
 import * as Types from '../types/types.js';
@@ -71,7 +72,8 @@ export const UIStrings = {
 } as const;
 
 const str_ = i18n.i18n.registerUIStrings('models/trace/insights/DocumentLatency.ts', UIStrings);
-export const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
+export const i18nString: (id: string, values?: Record<string, string|number|boolean>) =>
+    Platform.UIString.LocalizedString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 
 // Due to the way that DevTools throttling works we cannot see if server response took less than ~570ms.
 // We set our failure threshold to 600ms to avoid those false positives but we want devs to shoot for 100ms.

package/front_end/models/trace/insights/DuplicatedJavaScript.ts

@@ -3,6 +3,7 @@
 // found in the LICENSE file.
 
 import * as i18n from '../../../core/i18n/i18n.js';
+import type * as Platform from '../../../core/platform/platform.js';
 import * as Extras from '../extras/extras.js';
 import type * as Handlers from '../handlers/handlers.js';
 import * as Helpers from '../helpers/helpers.js';
@@ -42,7 +43,8 @@ export const UIStrings = {
 } as const;
 
 const str_ = i18n.i18n.registerUIStrings('models/trace/insights/DuplicatedJavaScript.ts', UIStrings);
-export const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
+export const i18nString: (id: string, values?: Record<string, string|number|boolean>) =>
+    Platform.UIString.LocalizedString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 
 export type DuplicatedJavaScriptInsightModel = InsightModel<typeof UIStrings, {
   duplication: Extras.ScriptDuplication.ScriptDuplication,

package/front_end/models/trace/insights/FontDisplay.ts

@@ -41,7 +41,8 @@ export const UIStrings = {
 } as const;
 
 const str_ = i18n.i18n.registerUIStrings('models/trace/insights/FontDisplay.ts', UIStrings);
-export const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
+export const i18nString: (id: string, values?: Record<string, string|number|boolean>) =>
+    Platform.UIString.LocalizedString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 
 export interface RemoteFont {
   name?: string;

package/front_end/models/trace/insights/ForcedReflow.ts

@@ -51,7 +51,8 @@ export const UIStrings = {
 } as const;
 
 const str_ = i18n.i18n.registerUIStrings('models/trace/insights/ForcedReflow.ts', UIStrings);
-export const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
+export const i18nString: (id: string, values?: Record<string, string|number|boolean>) =>
+    Platform.UIString.LocalizedString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 
 export type ForcedReflowInsightModel = InsightModel<typeof UIStrings, {
   topLevelFunctionCallData: ForcedReflowAggregatedData | undefined,

package/front_end/models/trace/insights/INPBreakdown.ts

@@ -3,6 +3,7 @@
 // found in the LICENSE file.
 
 import * as i18n from '../../../core/i18n/i18n.js';
+import type * as Platform from '../../../core/platform/platform.js';
 import * as Handlers from '../handlers/handlers.js';
 import * as Helpers from '../helpers/helpers.js';
 import type * as Types from '../types/types.js';
@@ -54,7 +55,8 @@ export const UIStrings = {
 } as const;
 
 const str_ = i18n.i18n.registerUIStrings('models/trace/insights/INPBreakdown.ts', UIStrings);
-export const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
+export const i18nString: (id: string, values?: Record<string, string|number|boolean>) =>
+    Platform.UIString.LocalizedString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 
 export type INPBreakdownInsightModel = InsightModel<typeof UIStrings, {
   longestInteractionEvent?: Types.Events.SyntheticInteractionPair,

package/front_end/models/trace/insights/ImageDelivery.ts

@@ -3,6 +3,7 @@
 // found in the LICENSE file.
 
 import * as i18n from '../../../core/i18n/i18n.js';
+import type * as Platform from '../../../core/platform/platform.js';
 import type * as Handlers from '../handlers/handlers.js';
 import * as Helpers from '../helpers/helpers.js';
 import type * as Types from '../types/types.js';
@@ -68,7 +69,8 @@ export const UIStrings = {
 } as const;
 
 const str_ = i18n.i18n.registerUIStrings('models/trace/insights/ImageDelivery.ts', UIStrings);
-export const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
+export const i18nString: (id: string, values?: Record<string, string|number|boolean>) =>
+    Platform.UIString.LocalizedString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 
 /**
  * Even JPEGs with lots of detail can usually be compressed down to <1 byte per pixel

package/front_end/models/trace/insights/LCPBreakdown.ts

@@ -4,6 +4,7 @@
 
 import type * as Common from '../../../core/common/common.js';
 import * as i18n from '../../../core/i18n/i18n.js';
+import type * as Platform from '../../../core/platform/platform.js';
 import * as Handlers from '../handlers/handlers.js';
 import * as Helpers from '../helpers/helpers.js';
 import * as Types from '../types/types.js';
@@ -63,7 +64,8 @@ export const UIStrings = {
   noLcp: 'No LCP detected',
 } as const;
 const str_ = i18n.i18n.registerUIStrings('models/trace/insights/LCPBreakdown.ts', UIStrings);
-export const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
+export const i18nString: (id: string, values?: Record<string, string|number|boolean>) =>
+    Platform.UIString.LocalizedString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 
 /** A TraceWindow plus its UIString. **/
 export type Subpart = Types.Timing.TraceWindowMicro&{label: Common.UIString.LocalizedString};

package/front_end/models/trace/insights/LCPDiscovery.ts

@@ -3,6 +3,7 @@
 // found in the LICENSE file.
 
 import * as i18n from '../../../core/i18n/i18n.js';
+import type * as Platform from '../../../core/platform/platform.js';
 import * as Handlers from '../handlers/handlers.js';
 import * as Helpers from '../helpers/helpers.js';
 import * as Types from '../types/types.js';
@@ -64,7 +65,8 @@ export const UIStrings = {
 } as const;
 
 const str_ = i18n.i18n.registerUIStrings('models/trace/insights/LCPDiscovery.ts', UIStrings);
-export const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
+export const i18nString: (id: string, values?: Record<string, string|number|boolean>) =>
+    Platform.UIString.LocalizedString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 
 export function isLCPDiscoveryInsight(model: InsightModel): model is LCPDiscoveryInsightModel {
   return model.insightKey === 'LCPDiscovery';

package/front_end/models/trace/insights/LegacyJavaScript.ts

@@ -3,6 +3,7 @@
 // found in the LICENSE file.
 
 import * as i18n from '../../../core/i18n/i18n.js';
+import type * as Platform from '../../../core/platform/platform.js';
 import * as LegacyJavaScriptLib from '../../../third_party/legacy-javascript/legacy-javascript.js';
 import type * as Handlers from '../handlers/handlers.js';
 import * as Helpers from '../helpers/helpers.js';
@@ -44,7 +45,8 @@ export const UIStrings = {
 } as const;
 
 const str_ = i18n.i18n.registerUIStrings('models/trace/insights/LegacyJavaScript.ts', UIStrings);
-export const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
+export const i18nString: (id: string, values?: Record<string, string|number|boolean>) =>
+    Platform.UIString.LocalizedString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 
 export interface PatternMatchResult {
   name: string;

package/front_end/models/trace/insights/ModernHTTP.ts

@@ -44,7 +44,8 @@ export const UIStrings = {
 } as const;
 
 const str_ = i18n.i18n.registerUIStrings('models/trace/insights/ModernHTTP.ts', UIStrings);
-export const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
+export const i18nString: (id: string, values?: Record<string, string|number|boolean>) =>
+    Platform.UIString.LocalizedString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 
 export type ModernHTTPInsightModel = InsightModel<typeof UIStrings, {
   http1Requests: Types.Events.SyntheticNetworkRequest[],

package/front_end/models/trace/insights/NetworkDependencyTree.ts

@@ -108,7 +108,8 @@ export const UIStrings = {
 } as const;
 
 const str_ = i18n.i18n.registerUIStrings('models/trace/insights/NetworkDependencyTree.ts', UIStrings);
-export const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
+export const i18nString: (id: string, values?: Record<string, string|number|boolean>) =>
+    Platform.UIString.LocalizedString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 
 // XHRs are fetched at High priority, but we exclude them, as they are unlikely to be critical
 // Images are also non-critical.

package/front_end/models/trace/insights/RenderBlocking.ts

@@ -3,6 +3,7 @@
 // found in the LICENSE file.
 
 import * as i18n from '../../../core/i18n/i18n.js';
+import type * as Platform from '../../../core/platform/platform.js';
 import * as Protocol from '../../../generated/protocol.js';
 import * as Handlers from '../handlers/handlers.js';
 import * as Helpers from '../helpers/helpers.js';
@@ -28,9 +29,8 @@ export const UIStrings = {
   /**
    * @description Text to describe that there are requests blocking rendering, which may affect LCP.
    */
-  description: 'Requests are blocking the page’s initial render, which may delay LCP. ' +
-      '[Deferring or inlining](https://developer.chrome.com/docs/performance/insights/render-blocking) ' +
-      'can move these network requests out of the critical path.',
+  description:
+      `Requests are blocking the page’s initial render, which may delay LCP. [Deferring or inlining](https://developer.chrome.com/docs/performance/insights/render-blocking) can move these network requests out of the critical path.`,
   /**
    * @description Label to describe a network request (that happens to be render-blocking).
    */
@@ -46,7 +46,8 @@ export const UIStrings = {
 } as const;
 
 const str_ = i18n.i18n.registerUIStrings('models/trace/insights/RenderBlocking.ts', UIStrings);
-export const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
+export const i18nString: (id: string, values?: Record<string, string|number|boolean>) =>
+    Platform.UIString.LocalizedString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 
 export function isRenderBlockingInsight(insight: InsightModel): insight is RenderBlockingInsightModel {
   return insight.insightKey === 'RenderBlocking';

package/front_end/models/trace/insights/SlowCSSSelector.ts

@@ -3,6 +3,7 @@
 // found in the LICENSE file.
 
 import * as i18n from '../../../core/i18n/i18n.js';
+import type * as Platform from '../../../core/platform/platform.js';
 import type * as Handlers from '../handlers/handlers.js';
 import * as Helpers from '../helpers/helpers.js';
 import * as Types from '../types/types.js';
@@ -62,7 +63,8 @@ export const UIStrings = {
 } as const;
 
 const str_ = i18n.i18n.registerUIStrings('models/trace/insights/SlowCSSSelector.ts', UIStrings);
-export const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
+export const i18nString: (id: string, values?: Record<string, string|number|boolean>) =>
+    Platform.UIString.LocalizedString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 const slowCSSSelectorThreshold = 500;  // 500us threshold for slow selectors
 
 export type SlowCSSSelectorInsightModel = InsightModel<typeof UIStrings, {

package/front_end/models/trace/insights/ThirdParties.ts

@@ -3,6 +3,7 @@
 // found in the LICENSE file.
 
 import * as i18n from '../../../core/i18n/i18n.js';
+import type * as Platform from '../../../core/platform/platform.js';
 import * as ThirdPartyWeb from '../../../third_party/third-party-web/third-party-web.js';
 import * as Extras from '../extras/extras.js';
 import * as Handlers from '../handlers/handlers.js';
@@ -25,8 +26,8 @@ export const UIStrings = {
    * @description Description of a DevTools insight that identifies the code on the page that the user doesn't control.
    * This is displayed after a user expands the section to see more. No character length limits.
    */
-  description: '3rd party code can significantly impact load performance. ' +
-      '[Reduce and defer loading of 3rd party code](https://developer.chrome.com/docs/performance/insights/third-parties) to prioritize your page’s content.',
+  description:
+      `3rd party code can significantly impact load performance. [Reduce and defer loading of 3rd party code](https://developer.chrome.com/docs/performance/insights/third-parties) to prioritize your page’s content.`,
   /**
    * @description Label for a table column that displays the name of a third-party provider.
    */
@@ -46,7 +47,8 @@ export const UIStrings = {
 } as const;
 
 const str_ = i18n.i18n.registerUIStrings('models/trace/insights/ThirdParties.ts', UIStrings);
-export const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
+export const i18nString: (id: string, values?: Record<string, string|number|boolean>) =>
+    Platform.UIString.LocalizedString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 
 export type ThirdPartiesInsightModel = InsightModel<typeof UIStrings, {
   /** The entity for this navigation's URL. Any other entity is from a third party. */

package/front_end/models/trace/insights/Viewport.ts

@@ -34,7 +34,8 @@ export const UIStrings = {
 } as const;
 
 const str_ = i18n.i18n.registerUIStrings('models/trace/insights/Viewport.ts', UIStrings);
-export const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
+export const i18nString: (id: string, values?: Record<string, string|number|boolean>) =>
+    Platform.UIString.LocalizedString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 
 export type ViewportInsightModel = InsightModel<typeof UIStrings, {
   mobileOptimized: boolean | null,

package/front_end/models/trace/lantern/simulation/Constants.ts

@@ -5,7 +5,37 @@
 const DEVTOOLS_RTT_ADJUSTMENT_FACTOR = 3.75;
 const DEVTOOLS_THROUGHPUT_ADJUSTMENT_FACTOR = 0.9;
 
-const throttling = {
+/* eslint-disable @typescript-eslint/naming-convention */
+export interface ThrottlingSettings {
+  DEVTOOLS_RTT_ADJUSTMENT_FACTOR: number;
+  DEVTOOLS_THROUGHPUT_ADJUSTMENT_FACTOR: number;
+  mobileSlow4G: {
+    rttMs: number,
+    throughputKbps: number,
+    requestLatencyMs: number,
+    downloadThroughputKbps: number,
+    uploadThroughputKbps: number,
+    cpuSlowdownMultiplier: number,
+  };
+  mobileRegular3G: {
+    rttMs: number,
+    throughputKbps: number,
+    requestLatencyMs: number,
+    downloadThroughputKbps: number,
+    uploadThroughputKbps: number,
+    cpuSlowdownMultiplier: number,
+  };
+  desktopDense4G: {
+    rttMs: number,
+    throughputKbps: number,
+    cpuSlowdownMultiplier: number,
+    requestLatencyMs: number,
+    downloadThroughputKbps: number,
+    uploadThroughputKbps: number,
+  };
+}
+
+const throttling: ThrottlingSettings = {
   DEVTOOLS_RTT_ADJUSTMENT_FACTOR,
   DEVTOOLS_THROUGHPUT_ADJUSTMENT_FACTOR,
   // These values align with WebPageTest's definition of "Fast 3G"
@@ -41,6 +71,8 @@ const throttling = {
   },
 };
 
-const Constants = {throttling};
+const Constants: {throttling: ThrottlingSettings} = {
+  throttling,
+};
 
 export {Constants};

package/front_end/models/trace/lantern/simulation/DNSCache.ts

@@ -12,7 +12,7 @@ import type * as Lantern from '../types/types.js';
 const DNS_RESOLUTION_RTT_MULTIPLIER = 2;
 
 class DNSCache {
-  static rttMultiplier = DNS_RESOLUTION_RTT_MULTIPLIER;
+  static rttMultiplier: number = DNS_RESOLUTION_RTT_MULTIPLIER;
 
   rtt: number;
   resolvedDomainNames: Map<string, {resolvedAt: number}>;

package/front_end/models/trace/types/TraceEvents.ts

@@ -770,7 +770,12 @@ const markerTypeGuards = [
   isSoftNavigationStart,
 ];
 
-export const MarkerName = [
+export type MarkerEventName = Name.MARK_DOM_CONTENT|Name.MARK_LOAD|Name.MARK_FIRST_PAINT|Name.MARK_FCP|
+                              Name.MARK_SOFT_FCP|Name.MARK_LCP_CANDIDATE|
+                              Name.MARK_LCP_CANDIDATE_FOR_SOFT_NAVIGATION|Name.NAVIGATION_START|
+                              Name.SOFT_NAVIGATION_START;
+
+export const MarkerName: readonly MarkerEventName[] = [
   Name.MARK_DOM_CONTENT,
   Name.MARK_LOAD,
   Name.MARK_FIRST_PAINT,
@@ -780,10 +785,10 @@ export const MarkerName = [
   Name.MARK_LCP_CANDIDATE_FOR_SOFT_NAVIGATION,
   Name.NAVIGATION_START,
   Name.SOFT_NAVIGATION_START,
-] as const;
+];
 
 export interface MarkerEvent extends Event {
-  name: typeof MarkerName[number];
+  name: MarkerEventName;
 }
 
 export function isMarkerEvent(event: Event): event is MarkerEvent {

package/front_end/models/trace_source_maps_resolver/SourceMapsResolver.ts

@@ -23,7 +23,8 @@ export class SourceMappingsUpdated extends Event {
 }
 
 /** The code location key is created as a concatenation of its fields. **/
-export const resolvedCodeLocationDataNames = new Map<string, ResolvedCodeLocationData|null>();
+export const resolvedCodeLocationDataNames: Map<string, ResolvedCodeLocationData|null> =
+    new Map<string, ResolvedCodeLocationData|null>();
 
 export class SourceMapsResolver extends EventTarget {
   readonly #debuggerWorkspaceBinding: Bindings.DebuggerWorkspaceBinding.DebuggerWorkspaceBinding;