chrome-devtools-frontend 1.0.1669021 → 1.0.1672557

package/front_end/ui/legacy/components/settings_ui/SettingsUI.ts

@@ -42,7 +42,8 @@ export function createSettingCheckbox(
   return label;
 }
 
-export function renderSettingSelect(setting: Common.Settings.Setting<unknown>, subtitle?: string): TemplateResult {
+export function renderSettingSelect(setting: Common.Settings.Setting<unknown>, subtitle?: string,
+                                    disabled?: boolean): TemplateResult {
   const uiDescriptor = SettingUIRegistration.SettingUIRegistration.maybeResolve(setting.descriptor());
   const name = uiDescriptor?.title?.() ?? setting.title();
   const options = uiDescriptor?.options?.map(opt => ({
@@ -53,7 +54,6 @@ export function renderSettingSelect(setting: Common.Settings.Setting<unknown>, s
                                              })) ??
       setting.options();
   const requiresReload = Boolean(uiDescriptor?.reloadRequired ?? setting.reloadRequired());
-  const {deprecation} = setting;
   const controlId = UI.ARIAUtils.nextId('labelledControl');
   const reloadWarningRef = createRef<HTMLParagraphElement>();
 
@@ -76,14 +76,11 @@ export function renderSettingSelect(setting: Common.Settings.Setting<unknown>, s
         <label for=${controlId}>
           ${name}
           ${subtitle ? html`<p>${subtitle}</p>` : nothing}
-          ${deprecation ? html`<devtools-setting-deprecation-warning .data=${
-              deprecation as Common.Settings.Deprecation}></devtools-setting-deprecation-warning>` :
-                          nothing}
         </label>
         <select
           id=${controlId}
           aria-label=${name}
-          .disabled=${setting.disabled()}
+          .disabled=${disabled ?? setting.disabled()}
           @change=${onSelectChange}
           jslog=${VisualLogging.dropDown().track({change: true}).context(setting.name)}
         >
@@ -112,8 +109,8 @@ export function renderSettingSelect(setting: Common.Settings.Setting<unknown>, s
   // clang-format on
 }
 
-export const renderControlForSetting = function(
-    setting: Common.Settings.Setting<unknown>, subtitle?: string): TemplateResult|typeof nothing {
+export const renderControlForSetting = function(setting: Common.Settings.Setting<unknown>, subtitle?: string,
+                                                disabled?: boolean): TemplateResult|typeof nothing {
   switch (setting.type()) {
     case Common.Settings.SettingType.BOOLEAN: {
       const onchange = (): void => {
@@ -126,10 +123,11 @@ export const renderControlForSetting = function(
       };
       return html`<setting-checkbox .data=${{
         setting: setting as Common.Settings.Setting<boolean>,
+        disabled,
       } as Settings.SettingCheckbox.SettingCheckboxData} @change=${onchange}></setting-checkbox>`;
     }
     case Common.Settings.SettingType.ENUM: {
-      return renderSettingSelect(setting, subtitle);
+      return renderSettingSelect(setting, subtitle, disabled);
     }
     default:
       console.error('Invalid setting type: ' + setting.type());
@@ -137,9 +135,9 @@ export const renderControlForSetting = function(
   }
 };
 
-export const createControlForSetting = function(
-    setting: Common.Settings.Setting<unknown>, subtitle?: string): HTMLElement|null {
-  const template = renderControlForSetting(setting, subtitle);
+export const createControlForSetting = function(setting: Common.Settings.Setting<unknown>, subtitle?: string,
+                                                disabled?: boolean): HTMLElement|null {
+  const template = renderControlForSetting(setting, subtitle, disabled);
   if (template === nothing) {
     return null;
   }

package/front_end/ui/settings/SettingUIRegistration.ts

@@ -30,13 +30,6 @@ export interface SettingUIDescriptor {
    * Whether DevTools must be reloaded for a change in the setting to take effect.
    */
   reloadRequired?: boolean;
-  /**
-   * If a setting is deprecated, define this notice to show an appropriate warning according to the `warning` property.
-   * If `disabled` is set, the setting will be disabled in the settings UI. In that case, `experiment` optionally can be
-   * set to link to an experiment (by experiment name). The information icon in the settings UI can then be clicked to
-   * jump to the experiment. If a setting is not disabled, the experiment entry will be ignored.
-   */
-  deprecationNotice?: {disabled: boolean, warning: () => Platform.UIString.LocalizedString, experiment?: string};
   /**
    * See {@link LearnMore} for more info.
    */
@@ -78,7 +71,6 @@ export function getRegisteredSettings(): readonly RegisteredSettingUI[] {
         tags: legacy.tags,
         options: legacy.options,
         reloadRequired: legacy.reloadRequired,
-        deprecationNotice: legacy.deprecationNotice,
         learnMore: legacy.learnMore,
       },
     });

package/front_end/ui/visual_logging/KnownContextValues.ts

@@ -787,6 +787,7 @@ export const knownContextValues = new Set([
   'chrome-theme-colors-documentation',
   'chrome-theme-colors-false',
   'chrome-windows',
+  'circle',
   'city',
   'classic',
   'clear',
@@ -1269,6 +1270,17 @@ export const knownContextValues = new Set([
   'custom-user-agent-metadata',
   'customize-pwa-tittle-bar',
   'cut',
+  'cutout-border-radius',
+  'cutout-cx',
+  'cutout-cy',
+  'cutout-height',
+  'cutout-lower-radius',
+  'cutout-radius',
+  'cutout-shape',
+  'cutout-upper-radius',
+  'cutout-width',
+  'cutout-x',
+  'cutout-y',
   'cx',
   'cy',
   'd',
@@ -1847,7 +1859,9 @@ export const knownContextValues = new Set([
   'full-accessibility-tree-feedback',
   'full-version',
   'function',
+  'galaxy-z-flip-6',
   'galaxy-z-fold-5',
+  'galaxy-z-fold-6',
   'gamma',
   'gap',
   'gap-rule-overlap',
@@ -2007,11 +2021,14 @@ export const knownContextValues = new Set([
   'hyphenate-limit-chars',
   'hyphens',
   'i-pad-air',
+  'i-pad-air-11',
   'i-pad-mini',
   'i-pad-pro',
+  'i-pad-pro-13',
   'i-phone-12-pro',
   'i-phone-14-pro-max',
   'i-phone-15-pro-max',
+  'i-phone-16',
   'i-phone-16-pro-max',
   'i-phone-se',
   'i-phone-xr',
@@ -2209,6 +2226,10 @@ export const knownContextValues = new Set([
   'ky',
   'landscape-left',
   'landscape-right',
+  'landscape-safe-area-bottom',
+  'landscape-safe-area-left',
+  'landscape-safe-area-right',
+  'landscape-safe-area-top',
   'language',
   'language-af',
   'language-am',
@@ -2699,6 +2720,7 @@ export const knownContextValues = new Set([
   'math-shift',
   'math-style',
   'max-block-size',
+  'max-content-sizing',
   'max-height',
   'max-inline-size',
   'max-lines',
@@ -2772,6 +2794,7 @@ export const knownContextValues = new Set([
   'more-options',
   'more-tabs',
   'more-tools',
+  'moto-g4',
   'mouse',
   'mousedown',
   'mouseenter',
@@ -2911,6 +2934,7 @@ export const knownContextValues = new Set([
   'none',
   'normal',
   'not-logged-in',
+  'notch',
   'notification',
   'notification.request-permission',
   'notifications',
@@ -3090,12 +3114,17 @@ export const knownContextValues = new Set([
   'perspective',
   'perspective-origin',
   'picture-in-picture',
+  'pill',
   'ping',
   'pixel-10',
   'pixel-7',
   'pixel-8',
   'pixel-9',
+  'pixel-9-pro',
+  'pixel-9-pro-fold',
   'pixel-9-pro-xl',
+  'pixel-fold',
+  'pixel-tablet',
   'pl',
   'place-content',
   'place-items',
@@ -3267,6 +3296,7 @@ export const knownContextValues = new Set([
   'recorder_recordings',
   'recording',
   'recordings',
+  'rectangle',
   'redirect-source-request',
   'redirect-source-request-url',
   'reduce',
@@ -3469,9 +3499,15 @@ export const knownContextValues = new Set([
   'safari-i-pad-i-os-13.2',
   'safari-i-phone-i-os-13.2',
   'safari-mac',
+  'safe-area-bottom',
+  'safe-area-left',
+  'safe-area-right',
+  'safe-area-top',
   'same-site',
   'sampling-heap-profiler-timeline',
+  'samsung-galaxy-a24-4g',
   'samsung-galaxy-a51-71',
+  'samsung-galaxy-a55',
   'samsung-galaxy-s20-ultra',
   'samsung-galaxy-s8',
   'sans-serif',
@@ -3958,6 +3994,7 @@ export const knownContextValues = new Set([
   'suggestion',
   'supports',
   'surface-duo',
+  'surface-pro-10',
   'surface-pro-7',
   'suspend',
   'sv',

package/inspector_overlay/tsconfig.json

@@ -1,7 +1,13 @@
 {
   "extends": "../config/typescript/tsconfig.base.json",
   "compilerOptions": {
-    "lib": ["esnext", "dom", "dom.iterable", "webworker", "webworker.iterable"],
-    "outDir": "ignored-for-vscode"
+    "lib": [
+      "esnext",
+      "dom",
+      "dom.iterable",
+      "webworker",
+      "webworker.iterable"
+    ],
+    "noEmit": true
   }
 }

package/package.json

@@ -85,11 +85,12 @@
     "svgo": "4.0.2",
     "terser": "5.48.0",
     "ts-lit-plugin": "2.0.2",
-    "typescript": "6.0.2",
+    "@typescript/tsc": "npm:typescript@6.0.2",
+    "typescript": "npm:@typescript/typescript6@6.0.2",
     "typescript-eslint": "8.64.0",
     "uuid": "14.0.0",
     "webidl2": "24.5.0",
     "yargs": "17.7.2"
   },
-  "version": "1.0.1669021"
+  "version": "1.0.1672557"
 }

package/.agents/skills/gerrit-cli/scripts/gerrit_client_wrapper.py

@@ -1,47 +0,0 @@
-#!/usr/bin/env python3
-# Copyright 2026 The Chromium Authors
-# Use of this source code is governed by a BSD-style license that can be
-# found in the LICENSE file.
-"""Helper wrapper script to run gerrit_client.py from PATH."""
-
-import shutil
-import subprocess
-import sys
-
-
-def main():
-    client = shutil.which('gerrit_client.py')
-    if not client:
-        print('gerrit_client.py not found. '
-              'Is depot_tools available and added to PATH?')
-        sys.exit(1)
-
-    # DevTools specific defaults
-    default_args = [
-        '--host',
-        'https://chromium-review.googlesource.com',
-        '--project',
-        'devtools/devtools-frontend',
-    ]
-
-    # gerrit_client.py expects: <command> [options] [args]
-    # We need to extract the command from sys.argv and put it first.
-    user_args = sys.argv[1:]
-    command = []
-    other_args = []
-    for i, arg in enumerate(user_args):
-        if not arg.startswith('-'):
-            command = [arg]
-            other_args = user_args[:i] + user_args[i + 1:]
-            break
-    else:
-        other_args = user_args
-
-    full_args = command + default_args + other_args
-
-    rc = subprocess.call(['vpython3', client] + full_args)
-    sys.exit(rc)
-
-
-if __name__ == '__main__':
-    main()

package/front_end/core/sdk/CSSModel.test.api.ts

@@ -1,102 +0,0 @@
-// Copyright 2026 The Chromium Authors
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-import {assert} from 'chai';
-import sinon from 'sinon';
-
-// eslint-disable-next-line @devtools/es-modules-import
-import * as SDK from './sdk.js';
-
-interface GlobalWithCSS {
-  // eslint-disable-next-line @typescript-eslint/naming-convention
-  CSS?: unknown;
-}
-
-describe('CSSModel API Test', () => {
-  it('adds a semicolon when enabling a property that lacked one, inserts properties, and enables them correctly',
-     async ({inspectedPage, universe}) => {
-       // Mock CSS.supports in Node environment for API tests.
-       let cssMocked = false;
-       if (typeof globalThis.CSS === 'undefined') {
-         (globalThis as unknown as GlobalWithCSS).CSS = undefined;
-         cssMocked = true;
-       }
-       const stub = sinon.stub(globalThis, 'CSS').value({
-         supports: () => true,
-       });
-
-       try {
-         const primaryTarget = universe.targetManager.primaryPageTarget();
-         assert.isNotNull(primaryTarget);
-
-         const domModel = primaryTarget.model(SDK.DOMModel.DOMModel);
-         assert.isNotNull(domModel);
-
-         const cssModel = primaryTarget.model(SDK.CSSModel.CSSModel);
-         assert.isNotNull(cssModel);
-
-         await inspectedPage.goToHtml(`
-           <style>
-           #formatted {
-               color: red;
-               margin: 0
-           }
-           </style>
-           <div id="formatted">Formatted</div>
-         `);
-
-         const documentNode = await domModel.requestDocument();
-         assert.isNotNull(documentNode);
-
-         // Retrieve the subtree to populate the DOMModel cache.
-         await documentNode.getSubtree(5, true);
-
-         const nodeId = await domModel.querySelector(documentNode.id, '#formatted');
-         assert.isNotNull(nodeId);
-
-         const matchedResult = await cssModel.getMatchedStyles(nodeId);
-         assert.isNotNull(matchedResult);
-
-         const style = matchedResult.nodeStyles()[1];
-         assert.isNotNull(style);
-
-         cssModel.addEventListener(SDK.CSSModel.Events.StyleSheetChanged, event => {
-           const {edit} = event.data;
-           if (edit) {
-             style.rebase(edit);
-           }
-         });
-
-         const marginProperty = style.allProperties()[1];
-         assert.strictEqual(marginProperty.name, 'margin');
-         assert.strictEqual(marginProperty.value, '0');
-
-         let success = await marginProperty.setDisabled(true);
-         assert.isTrue(success);
-         assert.include(style.cssText, '/* margin: 0; */');
-
-         const insertPromise = new Promise<void>(resolve => {
-           style.insertPropertyAt(2, 'endProperty', 'endValue', success => {
-             assert.isTrue(success);
-             resolve();
-           });
-         });
-         await insertPromise;
-         assert.include(style.cssText, '/* margin: 0; */');
-         assert.include(style.cssText, 'endProperty: endValue;');
-
-         const updatedMarginProperty = style.allProperties()[1];
-         success = await updatedMarginProperty.setDisabled(false);
-         assert.isTrue(success);
-         assert.include(style.cssText, 'margin: 0;');
-         assert.include(style.cssText, 'endProperty: endValue;');
-       } finally {
-         // Clean up the mock to avoid polluting the global scope.
-         stub.restore();
-         if (cssMocked) {
-           delete (globalThis as unknown as GlobalWithCSS).CSS;
-         }
-       }
-     });
-});

package/front_end/core/sdk/DOMModel.test.api.ts

@@ -1,104 +0,0 @@
-// Copyright 2026 The Chromium Authors
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-import {assert} from 'chai';
-
-import type * as Common from '../common/common.js';
-
-// eslint-disable-next-line @devtools/es-modules-import
-import * as SDK from './sdk.js';
-
-function findNode(node: SDK.DOMModel.DOMNode, predicate: (node: SDK.DOMModel.DOMNode) => boolean): SDK.DOMModel.DOMNode|
-    null {
-  if (predicate(node)) {
-    return node;
-  }
-  const children = node.children();
-  if (children) {
-    for (const child of children) {
-      const result = findNode(child, predicate);
-      if (result) {
-        return result;
-      }
-    }
-  }
-  return null;
-}
-
-describe('DOMModel API Test', () => {
-  it('generates attribute updated event only when attribute is actually changed', async ({inspectedPage, universe}) => {
-    const primaryTarget = universe.targetManager.primaryPageTarget();
-    assert.isNotNull(primaryTarget);
-
-    const domModel = primaryTarget.model(SDK.DOMModel.DOMModel);
-    assert.isNotNull(domModel);
-
-    await inspectedPage.goToHtml(`
-      <div id="container">
-          <div id="node-set-new-value" style="color:red"></div>
-          <div id="node-set-same-value" style="color:red"></div>
-      </div>
-    `);
-
-    const documentNode = await domModel.requestDocument();
-    assert.isNotNull(documentNode);
-
-    // Retrieve the subtree to populate the DOMModel cache.
-    await documentNode.getSubtree(5, true);
-
-    const container = findNode(documentNode, n => n.getAttribute('id') === 'container');
-    assert.isNotNull(container);
-
-    const nodeSetNewValue = findNode(documentNode, n => n.getAttribute('id') === 'node-set-new-value');
-    assert.isNotNull(nodeSetNewValue);
-
-    const nodeSetSameValue = findNode(documentNode, n => n.getAttribute('id') === 'node-set-same-value');
-    assert.isNotNull(nodeSetSameValue);
-
-    if (!nodeSetNewValue || !nodeSetSameValue) {
-      assert.fail('Could not find test nodes');
-    }
-
-    // Verifies that setting a new style attribute value triggers the AttrModified event.
-    let attrModifiedPromise = domModel.once(SDK.DOMModel.Events.AttrModified);
-
-    await inspectedPage.evaluate(() => {
-      (document.getElementById('node-set-new-value') as HTMLElement).style.setProperty('color', 'blue');
-    });
-
-    let eventData = await attrModifiedPromise;
-    assert.strictEqual(eventData.node, nodeSetNewValue);
-    assert.strictEqual(eventData.name, 'style');
-    assert.strictEqual(nodeSetNewValue.getAttribute('style'), 'color: blue;');
-
-    // Verifies that setting the style attribute to the same value does not trigger the AttrModified event.
-    let attrModifiedFired = false;
-    const listener =
-        (event: Common.EventTarget
-             .EventTargetEvent<SDK.DOMModel.EventTypes[SDK.DOMModel.Events.AttrModified], SDK.DOMModel.EventTypes>):
-            void => {
-              if (event.data.node === nodeSetSameValue) {
-                attrModifiedFired = true;
-              }
-            };
-    domModel.addEventListener(SDK.DOMModel.Events.AttrModified, listener);
-
-    await inspectedPage.evaluate(() => {
-      (document.getElementById('node-set-same-value') as HTMLElement).style.setProperty('color', 'red');
-    });
-
-    // Flushes pending events by triggering a style change on the new value node.
-    attrModifiedPromise = domModel.once(SDK.DOMModel.Events.AttrModified);
-
-    await inspectedPage.evaluate(() => {
-      (document.getElementById('node-set-new-value') as HTMLElement).style.setProperty('color', 'green');
-    });
-
-    eventData = await attrModifiedPromise;
-    assert.strictEqual(eventData.node, nodeSetNewValue);
-    assert.isFalse(attrModifiedFired, 'AttrModified should not have fired for same value');
-
-    domModel.removeEventListener(SDK.DOMModel.Events.AttrModified, listener);
-  });
-});

package/front_end/foundation/Universe.test.api.ts

@@ -1,73 +0,0 @@
-// Copyright 2026 The Chromium Authors
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-import {assert} from 'chai';
-
-import * as Root from '../core/root/root.js';
-import * as SDK from '../core/sdk/sdk.js';
-
-describe('Universe API Test', () => {
-  describe('ConsoleModel', () => {
-    it('receives console messages emitted from inspected page in universe ConsoleModel',
-       async ({inspectedPage, universe}) => {
-         assert.isNotNull(universe);
-
-         const primaryTarget = universe.targetManager.primaryPageTarget();
-         assert.isNotNull(primaryTarget, 'Primary page target should exist in target manager');
-
-         await inspectedPage.goToHtml('<h1>DevTools API Test Page</h1>');
-
-         const consoleModel = primaryTarget?.model(SDK.ConsoleModel.ConsoleModel);
-         const messagePromise = consoleModel?.once(SDK.ConsoleModel.Events.MessageAdded);
-
-         // eslint-disable-next-line no-console
-         await inspectedPage.evaluate(() => console.log('Hello from Universe API Test!'));
-
-         const consoleMessage = await messagePromise;
-         assert.isDefined(consoleMessage);
-         assert.strictEqual(
-             consoleMessage?.messageText,
-             'Hello from Universe API Test!',
-             'Console message should be received by universe ConsoleModel',
-         );
-       });
-  });
-
-  describe('Suite with setup configuration', () => {
-    setup({
-      creationOptions: {
-        hostConfig: {
-          devToolsConsoleInsights: {
-            enabled: true,
-            modelId: 'test-model',
-            temperature: 0.7,
-          },
-        },
-      },
-    });
-
-    it('applies hostConfig from setup creationOptions globally and to Universe', async ({universe}) => {
-      assert.isNotNull(universe);
-      assert.isTrue(Root.Runtime.hostConfig.devToolsConsoleInsights?.enabled);
-      assert.strictEqual(Root.Runtime.hostConfig.devToolsConsoleInsights?.modelId, 'test-model');
-    });
-  });
-
-  describe('Suite with targetUrl configuration', () => {
-    setup({
-      targetUrl: 'data:text/html,<!DOCTYPE%20html><h1>Target%20URL%20Test</h1>',
-    });
-
-    it('navigates to targetUrl before attaching universe', async ({inspectedPage}) => {
-      const heading = await inspectedPage.evaluate(() => document.querySelector('h1')?.textContent);
-      assert.strictEqual(heading, 'Target URL Test');
-    });
-  });
-
-  describe('Suite without custom setup', () => {
-    it('restores default hostConfig after previous test suite cleaned up', async () => {
-      assert.isUndefined(Root.Runtime.hostConfig.devToolsConsoleInsights?.modelId);
-    });
-  });
-});