chrome-devtools-frontend 1.0.1669021 → 1.0.1672557

package/.agents/skills/fixing-skipped-tests/SKILL.md

@@ -16,17 +16,17 @@ This skill outlines the workflow for fixing skipped tests in the DevTools codeba
    - Ensure you use the instructions from the `devtools-version-control` skill to create and switch branches appropriately.
 
 3. **Search for the Skipped Tests**
-   - Search the codebase for the `<bugid>` to find skipped tests.
-   - You should look for occurrences like `it.skip('[crbug.com/<bugid>] ...', ...)` or skipped describes that mention the bug ID.
+   - Search the `test/TestExpectations` file for the `<bugid>` to find skipped tests.
+   - Tests are no longer skipped using `.skip` in the code, but rather by having a `[ Skip ]` expectation in `test/TestExpectations`.
 
 4. **Iterative Fix Process**
-   - **Step 1:** Remove `it.skip` or `describe.skip` for *one* of the tests associated with the bug.
+   - **Step 1:** Remove the `[ Skip ]` expectation for *one* of the tests associated with the bug in `test/TestExpectations` (or change it to `[ Pass Failure ]` if you are investigating flakiness).
    - **Step 2:** Re-run the specific test using its exact test ID (e.g., `npm run test path/to/foo.test.ts:test_name`) using the guidelines from the `devtools-verification` skill. If you are dealing with flaky tests, you can use the `--repeat=x` flag (e.g. `npm run test -- --repeat=20 path/to/foo.test.ts:test_name`) to run the test multiple times to reproduce the flakiness. This flag works for both E2E and unit tests.
    - **Step 3:** Analyze the test failure and make the necessary fixes to the code or the test itself.
    - **Step 4:** Re-run the test to ensure the fix is correct.
-   - **Step 5:** Remove the `[crbug.com/<bugid>]` prefix from the test name string if it is present.
-   - **Step 6:** Remove any comments directly above the test that explain the reason why the test was skipped (e.g., `// TODO(crbug...): Flaky`).
-   - **Step 7:** Apply the fix to the remaining tests, un-skipping them one by one or in batches, and verifying until all are passing.
+   - **Step 5:** Remove the `[crbug.com/<bugid>]` prefix from the test name string in the code if it is present.
+   - **Step 6:** Remove any comments directly above the test in the code that explain the reason why the test was skipped (e.g., `// TODO(crbug...): Flaky`).
+   - **Step 7:** Apply the fix to the remaining tests, un-skipping them one by one or in batches by modifying `test/TestExpectations`, and verifying until all are passing.
 
 5. **Verify Full Build**
    - Before finishing, run the full verification process (TypeScript checks, linters, full test run) as required by the repository best practices.

package/.agents/skills/gerrit-cli/SKILL.md

@@ -16,8 +16,6 @@ depot_tools.
 
 ## Prerequisites
 
-- **Environment**: Always execute the wrapper script using **`vpython3`** instead of `python3` to ensure all internal dependencies are satisfied.
-
 - Ensure `gerrit_client.py` is available in the system `PATH` (typically part of
   `depot_tools`). If `gerrit_client.py` is not available in your environment,
   stop execution immediately.
@@ -33,15 +31,11 @@ depot_tools.
 - Before querying public CLs, adding comments, voting, or submitting changes,
   read `references/workflows.md` for step-by-step procedures.
 
-## Global Flags
-
-The wrapper script includes DevTools-specific defaults for `--host` and
-`--project`. You do not need to provide them unless you are targeting a
-different host or project.
+## Gotchas & Environment Constraints
 
-- **Default Host**: `https://chromium-review.googlesource.com`
-- **Default Project**: `devtools/devtools-frontend`
-- **JSON Output**: Always use the `--json_file=<path>` flag when querying
+- **Specify Host**: Always supply the `--host` flag explicitly (e.g.
+  `--host https://chromium-review.googlesource.com`).
+- **Use JSON Output**: Always use the `--json_file=<path>` flag when querying
   changes or fetching metadata to obtain structured, machine-readable output.
 
 > [!CAUTION]

package/.agents/skills/gerrit-cli/references/commands.md

@@ -1,6 +1,7 @@
 # Gerrit CLI Common Commands & Usage (Public)
 
 Run the tool directly using the wrapper script path with the `--help` flag:
+
 - `vpython3 .agents/skills/gerrit-cli/scripts/gerrit_client_wrapper.py --help`
 - `vpython3 .agents/skills/gerrit-cli/scripts/gerrit_client_wrapper.py changes --help`
 
@@ -19,22 +20,36 @@ ______________________________________________________________________
 ### 1. Inspecting and Searching Changes
 
 - **Query active changes:**
+
   ```bash
   vpython3 .agents/skills/gerrit-cli/scripts/gerrit_client_wrapper.py \
     changes \
+    --host https://chromium-review.googlesource.com \
     --query "owner:self status:open"
   ```
+
 - **View the content of a specific file in a change:**
+
+  **Note:** This command does not work with the `--json_file` flag, instead use
+  stdout redirection (`>`).
+
   ```bash
   vpython3 .agents/skills/gerrit-cli/scripts/gerrit_client_wrapper.py \
     content \
-    --json_file output.json \
-    --change <change_id> --revision <revision> --path <file_path>
+    --host https://chromium-review.googlesource.com \
+    --project <project> \
+    --change <change_id> \
+    --revision <revision> \
+    --path <file_path> \
+    > output_file
   ```
+
 - **Get related changes:**
+
   ```bash
   vpython3 .agents/skills/gerrit-cli/scripts/gerrit_client_wrapper.py \
     relatedchanges \
+    --host https://chromium-review.googlesource.com \
     --change <change_id> --revision <revision>
   ```
 
@@ -44,6 +59,7 @@ ______________________________________________________________________
   ```bash
   vpython3 .agents/skills/gerrit-cli/scripts/gerrit_client_wrapper.py \
     addpatchsetcomment \
+    --host https://chromium-review.googlesource.com \
     --change <change_id> --revision <revision> \
     --message "Review findings: <message>"
   ```
@@ -51,6 +67,7 @@ ______________________________________________________________________
   ```bash
   vpython3 .agents/skills/gerrit-cli/scripts/gerrit_client_wrapper.py \
     setlabel \
+    --host https://chromium-review.googlesource.com \
     --change <change_id> \
     --label Code-Review 1
   ```
@@ -61,12 +78,14 @@ ______________________________________________________________________
   ```bash
   vpython3 .agents/skills/gerrit-cli/scripts/gerrit_client_wrapper.py \
     submitchange \
+    --host https://chromium-review.googlesource.com \
     --change <change_id>
   ```
 - **Abandon a change:**
   ```bash
   vpython3 .agents/skills/gerrit-cli/scripts/gerrit_client_wrapper.py \
     abandon \
+    --host https://chromium-review.googlesource.com \
     --change <change_id> \
     --message "<reason>"
   ```
@@ -74,6 +93,7 @@ ______________________________________________________________________
   ```bash
   vpython3 .agents/skills/gerrit-cli/scripts/gerrit_client_wrapper.py \
     restore \
+    --host https://chromium-review.googlesource.com \
     --change <change_id> \
     --message "<reason>"
   ```
@@ -91,3 +111,26 @@ Explore the built-in CLI help for additional subcommands or advanced syntax:
   vpython3 .agents/skills/gerrit-cli/scripts/gerrit_client_wrapper.py \
     help <command>
   ```
+
+
+## Advanced / Escape Hatch: Arbitrary REST API Calls (`rawapi`)
+
+If the built-in subcommands do not cover a specific action or metadata query, you can use the `rawapi` subcommand to execute arbitrary HTTP requests against the Gerrit REST API.
+
+- **Endpoint Reference**: [Gerrit REST API - Changes](https://gerrit-review.googlesource.com/Documentation/rest-api-changes.html)
+
+### Usage
+
+```bash
+vpython3 .agents/skills/gerrit-cli/scripts/gerrit_client_wrapper.py \
+  rawapi \
+  --host https://chromium-review.googlesource.com \
+  --path "/changes/<change_id>/detail?o=SUBMITTABLE" \
+  --json_file output.json
+```
+
+- **Options**:
+  - `--path`: HTTP path of the API endpoint (e.g. `/changes/<change_id>/revisions/current/mergeable`).
+  - `--method`: HTTP method (GET, POST, PUT, DELETE). Defaults to GET.
+  - `--body`: JSON string body for write requests (e.g., POST/PUT).
+  - `--accept_status`: Comma-separated list of successful HTTP status codes.

package/.agents/skills/gerrit-cli/references/workflows.md

@@ -9,6 +9,7 @@ provided with a link or ID:
    ```bash
    vpython3 .agents/skills/gerrit-cli/scripts/gerrit_client_wrapper.py \
      changes \
+     --host https://chromium-review.googlesource.com \
      --query "change:<id>"
    ```
 2. **Fetch File Contents**: Retrieve the content of specific files modified in
@@ -16,6 +17,8 @@ provided with a link or ID:
    ```bash
    vpython3 .agents/skills/gerrit-cli/scripts/gerrit_client_wrapper.py \
      content \
+     --host https://chromium-review.googlesource.com \
+     --project <project> \
      --change <change_id> --revision current --path <file_path>
    ```
 3. **Analyze Local Modifications**: Inspect the fetched contents and local diffs
@@ -25,6 +28,7 @@ provided with a link or ID:
    ```bash
    vpython3 .agents/skills/gerrit-cli/scripts/gerrit_client_wrapper.py \
      addpatchsetcomment \
+     --host https://chromium-review.googlesource.com \
      --change <change_id> --revision current \
      --message "Review findings: ..."
    ```
@@ -38,12 +42,14 @@ Execute these steps in chronological order to approve and merge a Change List:
    ```bash
    vpython3 .agents/skills/gerrit-cli/scripts/gerrit_client_wrapper.py \
      relatedchanges \
+     --host https://chromium-review.googlesource.com \
      --change <change_id> --revision current
    ```
 2. **Vote on Review Labels**: Apply the required Code-Review approval vote:
    ```bash
    vpython3 .agents/skills/gerrit-cli/scripts/gerrit_client_wrapper.py \
      setlabel \
+     --host https://chromium-review.googlesource.com \
      --change <change_id> \
      --label Code-Review 1
    ```
@@ -52,5 +58,6 @@ Execute these steps in chronological order to approve and merge a Change List:
    ```bash
    vpython3 .agents/skills/gerrit-cli/scripts/gerrit_client_wrapper.py \
      submitchange \
+     --host https://chromium-review.googlesource.com \
      --change <change_id>
    ```

package/.agents/skills/gerrit-cli/scripts/import_upstream.py

@@ -17,40 +17,6 @@ from pathlib import Path
 
 UPSTREAM_URL = "https://chromium.googlesource.com/chromium/agents/+archive/refs/heads/main/skills/gerrit-cli.tar.gz"
 
-DEVTOOLS_WRAPPER_LOGIC = """    # DevTools specific defaults
-    default_args = [
-        '--host', 'https://chromium-review.googlesource.com',
-        '--project', 'devtools/devtools-frontend',
-    ]
-
-    # gerrit_client.py expects: <command> [options] [args]
-    # We need to extract the command from sys.argv and put it first.
-    user_args = sys.argv[1:]
-    command = []
-    other_args = []
-    for i, arg in enumerate(user_args):
-        if not arg.startswith('-'):
-            command = [arg]
-            other_args = user_args[:i] + user_args[i + 1:]
-            break
-    else:
-        other_args = user_args
-
-    full_args = command + default_args + other_args
-
-    rc = subprocess.call(['vpython3', client] + full_args)"""
-
-CAUTION_TEXT = """> [!CAUTION]
-> **NEVER** use this to add patchset comments to an existing comment thread that
-> contains human reviewers in it. Using an agent to reply to a human is a
-> violation of Chromium's code of conduct.
->
-> If the user requests this or you encounter this scenario as part of your work,
-> inform the user about which comment threads cannot be updated but otherwise
-> continue work.
-"""
-
-
 def fetch_upstream_skill(target_dir: Path):
     print(f"Downloading upstream skill from {UPSTREAM_URL}...")
     try:
@@ -71,53 +37,16 @@ def fetch_upstream_skill(target_dir: Path):
 def apply_devtools_revisions(target_dir: Path):
     print("Applying DevTools-specific adaptations...")
 
-    # 1. Update gerrit_client_wrapper.py
-    wrapper_path = target_dir / "scripts" / "gerrit_client_wrapper.py"
-    if wrapper_path.exists():
-        code = wrapper_path.read_text()
-        # Remove ". All rights reserved." from license header to satisfy DevTools presubmit
-        code = code.replace(". All rights reserved.", "")
-        target_line = "    rc = subprocess.call(['vpython3', client] + sys.argv[1:])"
-        if target_line in code:
-            code = code.replace(target_line, DEVTOOLS_WRAPPER_LOGIC)
-        else:
-            # Fallback if upstream changed to python3
-            fallback_line = "    rc = subprocess.call(['python3', client] + sys.argv[1:])"
-            code = code.replace(fallback_line, DEVTOOLS_WRAPPER_LOGIC)
-        wrapper_path.write_text(code)
-        print("  - Adapted gerrit_client_wrapper.py")
-
     # 2. Update SKILL.md
     skill_md_path = target_dir / "SKILL.md"
     if skill_md_path.exists():
         content = skill_md_path.read_text()
 
-        # Re-route wrapper script path & change python3 to vpython3
-        content = content.replace(
-            "python3 agents/shared/skills/gerrit-cli/scripts/gerrit_client_wrapper.py",
-            "vpython3 .agents/skills/gerrit-cli/scripts/gerrit_client_wrapper.py"
-        )
-
-        # Add vpython3 environment warning under Prerequisites
-        if "- **Environment**:" not in content:
-            prereq_note = "- **Environment**: Always execute the wrapper script using **`vpython3`** instead of `python3` to ensure all internal dependencies are satisfied.\n"
-            content = content.replace("## Prerequisites\n",
-                                      f"## Prerequisites\n\n{prereq_note}")
-
-        # Replace Gotchas section with DevTools defaults info
-        global_flags_section = """## Global Flags
-
-The wrapper script includes DevTools-specific defaults for `--host` and
-`--project`. You do not need to provide them unless you are targeting a
-different host or project.
-
-- **Default Host**: `https://chromium-review.googlesource.com`
-- **Default Project**: `devtools/devtools-frontend`
-- **JSON Output**: Always use the `--json_file=<path>` flag when querying
-  changes or fetching metadata to obtain structured, machine-readable output.
-"""
-        gotchas_pattern = r"## Gotchas & Environment Constraints\n\n(?:[^\n]+\n)+"
-        content = re.sub(gotchas_pattern, global_flags_section, content)
+        # Re-route wrapper script path
+        content = re.sub(
+            r'(?:v)?python3\s+agents/shared/skills/gerrit-cli/scripts/gerrit_client_wrapper.py',
+            'vpython3 .agents/skills/gerrit-cli/scripts/gerrit_client_wrapper.py',
+            content)
 
         # Add attribution note at the bottom
         attribution = """
@@ -138,91 +67,44 @@ different host or project.
             c = ref_path.read_text()
 
             # Path & executable transformations
-            c = c.replace("python3 agents/shared/skills/gerrit-cli/",
-                          "vpython3 .agents/skills/gerrit-cli/")
-
-            # Remove redundant host/project flags since our wrapper defaults them
-            # This matches the flag and any trailing backslash & newline to keep shell syntax valid
-            c = re.sub(r'^[ \t]+--(host|project)[ \t]+\S+[ \t]*(?:\\)?\n',
-                       '',
-                       c,
-                       flags=re.M)
-
-            # Re-route positional arguments to flags for various commands.
-            # TODO(b/40292850): Simplify/remove these once CL lands upstream:
-            # https://chromium-review.googlesource.com/c/chromium/agents/+/8146436
-
-            # content
-            c = c.replace(
-                "<change_id> <revision> <file_path>",
-                "--change <change_id> --revision <revision> --path <file_path>"
-            )
-            c = c.replace(
-                "<change_id> current <file_path>",
-                "--change <change_id> --revision current --path <file_path>")
-
-            # changes (query flag is required)
-            c = c.replace('changes \\\n    "owner:self status:open"',
-                          'changes \\\n    --query "owner:self status:open"')
-            c = c.replace('changes \\\n     "change:<id>"',
-                          'changes \\\n     --query "change:<id>"')
-
-            # relatedchanges
-            c = c.replace(
-                "relatedchanges \\\n    <change_id> <revision>",
-                "relatedchanges \\\n    --change <change_id> --revision <revision>"
-            )
-            c = c.replace(
-                "relatedchanges \\\n     <change_id> current",
-                "relatedchanges \\\n     --change <change_id> --revision current"
-            )
-
-            # addpatchsetcomment
-            c = c.replace(
-                'addpatchsetcomment \\\n    --message "Review findings: <message>" \\\n    <change_id> <revision>',
-                'addpatchsetcomment \\\n    --change <change_id> --revision <revision> \\\n    --message "Review findings: <message>"'
-            )
-            c = c.replace(
-                'addpatchsetcomment \\\n     --message "Review findings: ..." \\\n     <change_id> current',
-                'addpatchsetcomment \\\n     --change <change_id> --revision current \\\n     --message "Review findings: ..."'
-            )
-
-            # setlabel
-            c = c.replace(
-                'setlabel \\\n    --label "Code-Review" \\\n    --value 1 \\\n    <change_id>',
-                'setlabel \\\n    --change <change_id> \\\n    --label Code-Review 1'
-            )
-            c = c.replace(
-                'setlabel \\\n     --label "Code-Review" \\\n     --value 1 \\\n     <change_id>',
-                'setlabel \\\n     --change <change_id> \\\n     --label Code-Review 1'
-            )
-
-            # submitchange
-            c = c.replace("submitchange \\\n    <change_id>",
-                          "submitchange \\\n    --change <change_id>")
-            c = c.replace("submitchange \\\n     <change_id>",
-                          "submitchange \\\n     --change <change_id>")
-
-            # abandon
-            c = c.replace(
-                'abandon \\\n    --message "<reason>" \\\n    <change_id>',
-                'abandon \\\n    --change <change_id> \\\n    --message "<reason>"'
-            )
-
-            # restore
-            c = c.replace(
-                'restore \\\n    --message "<reason>" \\\n    <change_id>',
-                'restore \\\n    --change <change_id> \\\n    --message "<reason>"'
-            )
+            c = re.sub(r'(?:v)?python3\s+agents/shared/skills/gerrit-cli/',
+                       'vpython3 .agents/skills/gerrit-cli/', c)
 
             ref_path.write_text(c)
             print(f"  - Adapted references/{filename}")
 
 
+def validate_gerrit_client_wrapper(skill_dir: Path):
+    print("Validating gerrit_client_wrapper.py...")
+    import json, subprocess, tempfile
+    wrapper = skill_dir / "scripts" / "gerrit_client_wrapper.py"
+    with tempfile.TemporaryDirectory() as tmp:
+        json_file = Path(tmp) / "out.json"
+        try:
+            subprocess.run([
+                "vpython3",
+                str(wrapper), "changes", "--query", "change:8147179", "--host",
+                "https://chromium-review.googlesource.com", "--json_file",
+                str(json_file)
+            ],
+                           check=True,
+                           capture_output=True)
+            data = json.loads(json_file.read_text())
+            if not data or data[0].get("_number") != 8147179:
+                raise ValueError(f"Invalid response: {data}")
+            print("  - Validation passed successfully!")
+        except Exception as e:
+            stderr = getattr(e, "stderr", b"").decode(errors="replace")
+            print(f"Validation FAILED: {e}\n{stderr}")
+            sys.exit(1)
+
+
+
 def main():
     skill_dir = Path(__file__).parent.parent.resolve()
     fetch_upstream_skill(skill_dir)
     apply_devtools_revisions(skill_dir)
+    validate_gerrit_client_wrapper(skill_dir)
     print("Upstream sync completed successfully!")
 
 

package/config/typescript/tsconfig.eslint.json

@@ -13,7 +13,7 @@
       "webworker",
       "webworker.iterable"
     ],
-    "outDir": "ignored-for-vscode"
+    "noEmit": true
   },
   "include": [
     "../../front_end/**/*.ts",

package/docs/contributing/settings-experiments-features.md

@@ -78,12 +78,12 @@ This step is optional. If you want the `base::Feature` to be controllable via th
 
 Prerequisite: The `base::Feature` needs to be have been added to `chrome://flags`.
 
-#### Step 1: Create a HostExperiment in the DevTools repository
+#### Step 1: Create an Experiment in the DevTools repository
 
 Register the experiment in [`MainImpl.ts`](https://crsrc.org/c/third_party/devtools-frontend/src/front_end/entrypoints/main/MainImpl.ts;l=343)
 
 ```ts
-Root.Runtime.experiments.registerHostExperiment({
+Root.Runtime.experiments.register({
   name: Root.ExperimentNames.ExperimentName.DURABLE_MESSAGES,
   // Short description of the experiment, shown to users
   title: 'Durable Messages',
@@ -147,12 +147,6 @@ in the DevTools repository. The label can be anything you like but make sure it
 
 [Example CL](https://crrev.com/c/4915777)
 
-## Deprecated: DevTools experiments
-
-Previously, DevTools experiments that lacked a Chrome component were managed separately. This
-system is now deprecated. All legacy experiments are being migrated to the `base::Feature`
-framework to streamline development.
-
 ## A/B Testing with Finch and base::Feature
 
 `base::Feature` flags can be used with Finch to conduct A/B testing by toggling feature flags for a defined percentage of users. A/B testing can be a good way of testing the waters. However, since the time to get meaningful metrics may take a long time, it shouldn't be used to get feedback on options quickly.

package/docs/ecosystem/automatic_workspace_folders.md

@@ -66,25 +66,6 @@ An example `com.chrome.devtools.json` would look like this:
 Chromium DevTools will only attempt to load the `com.chrome.devtools.json` when
 the origin of the inspected page is `localhost`.
 
-## Setup
-
-In M-136, which is in Canary channel at the time of this writing, the relevant
-flags have been enabled by default (as of 2025-03-16). In earlier versions of
-M-136 and in M-135, this feature is disabled by default. To use it, you need to
-turn on two feature flags in `about:flags`:
-
--   [chrome://flags#devtools-project-settings](chrome://flags#devtools-project-settings)
--   [chrome://flags#devtools-automatic-workspace-folders](chrome://flags#devtools-automatic-workspace-folders)
-
-![](./images/automatic_workspace_folders_flags.png)
-
-Instead of enabling the feature via `about:flags`, you can instead also enable
-them from the command line:
-
-```bash
-google-chrome-canary --enable-features=DevToolsWellKnown,DevToolsAutomaticFileSystems
-```
-
 ## Usage
 
 To check if your setup is correct, you can try out Benedikt’s

package/eslint.config.mjs

@@ -29,7 +29,7 @@ export default defineConfig([
     'front_end/diff/diff_match_patch.js',
     'front_end/models/javascript_metadata/NativeFunctions.js',
     // All of these scripts are auto-generated so don't lint them.
-    'front_end/generated/ARIAProperties.js',
+    'front_end/generated/ARIAProperties.ts',
     'front_end/generated/Deprecation.ts',
     'front_end/generated/InspectorBackendCommands.ts',
     'front_end/generated/protocol-mapping.d.ts',
@@ -197,7 +197,7 @@ export default defineConfig([
       radix: 'error',
       'valid-typeof': 'error',
       'no-return-assign': ['error', 'always'],
-      'no-implicit-coercion': ['error', { allow: ['!!'] }],
+      'no-implicit-coercion': ['error', {allow: ['!!']}],
 
       'no-array-constructor': 'error',
 
@@ -693,8 +693,8 @@ export default defineConfig([
     },
   },
   {
-    name: 'Front-end core files',
-    files: ['front_end/core/**/*.ts'],
+    name: 'Front-end core and models files',
+    files: ['front_end/core/**/*.ts', 'front_end/models/**/*.ts'],
     rules: {
       '@devtools/no-instance-of-migrated-singletons': 'error',
     },
@@ -833,7 +833,7 @@ export default defineConfig([
   },
   {
     name: 'Supported CSS properties rules',
-    files: ['front_end/generated/SupportedCSSProperties.js'],
+    files: ['front_end/generated/SupportedCSSProperties.ts'],
     rules: {
       '@devtools/jslog-context-list': 'error',
     },

package/front_end/core/common/Lazy.ts

@@ -8,11 +8,11 @@ const ERROR_STATE = Symbol('error');
 /**
  * Very basic memoizer. Will only invoke its callback the first time, returning the cached value all subsequent calls.
  */
-export function lazy<T>(producer: () => T): () => symbol | T {
+export function lazy<T, A extends unknown[] = []>(producer: (...args: A) => T): (...args: A) => T {
   let value: T|typeof ERROR_STATE|typeof UNINITIALIZED = UNINITIALIZED;
   let error: Error = new Error('Initial');
 
-  return (): symbol|T => {
+  return (...args: A): T => {
     if (value === ERROR_STATE) {
       throw error;
     } else if (value !== UNINITIALIZED) {
@@ -20,7 +20,7 @@ export function lazy<T>(producer: () => T): () => symbol | T {
     }
 
     try {
-      value = producer();
+      value = producer(...args);
       return value;
     } catch (err) {
       error = err instanceof Error ? err : new Error(err);

package/front_end/core/common/SettingRegistration.ts

@@ -282,13 +282,6 @@ export interface SettingRegistration {
    */
   disabledCondition?: (config?: Root.Runtime.HostConfig) => DisabledConditionResult;
 
-  /**
-   * If a setting is deprecated, define this notice to show an appropriate warning according to the `warning` property.
-   * If `disabled` is set, the setting will be disabled in the settings UI. In that case, `experiment` optionally can be
-   * set to link to an experiment (by experiment name). The information icon in the settings UI can then be clicked to
-   * jump to the experiment. If a setting is not disabled, the experiment entry will be ignored.
-   */
-  deprecationNotice?: {disabled: boolean, warning: () => Platform.UIString.LocalizedString, experiment?: string};
   /**
    * See {@link LearnMore} for more info.
    */

package/front_end/core/common/Settings.ts

@@ -494,23 +494,6 @@ export class SettingsStorage {
   }
 }
 
-export class Deprecation {
-  readonly disabled: boolean;
-  readonly warning: Platform.UIString.LocalizedString;
-  readonly experiment?: Root.Runtime.Experiment|Root.Runtime.HostExperiment;
-
-  constructor({deprecationNotice}: SettingRegistration) {
-    if (!deprecationNotice) {
-      throw new Error('Cannot create deprecation info for a non-deprecated setting');
-    }
-    this.disabled = deprecationNotice.disabled;
-    this.warning = deprecationNotice.warning();
-    this.experiment = deprecationNotice.experiment ?
-        Root.Runtime.experiments.allConfigurableExperiments().find(e => e.name === deprecationNotice.experiment) :
-        undefined;
-  }
-}
-
 export class Setting<V> {
   #registration: SettingRegistration|null = null;
   #type: SettingType|null = null;
@@ -520,7 +503,6 @@ export class Setting<V> {
   #serializer: Serializer<unknown, V> = JSON;
   #hadUserAction?: boolean;
   #disabled?: boolean;
-  #deprecation: Deprecation|null = null;
   #loggedInitialAccess = false;
   #logSettingAccess?: (name: string, value: number|string|boolean) => Promise<void>;
   readonly #console: Console;
@@ -691,16 +673,6 @@ export class Setting<V> {
     if (registration.settingType) {
       this.#type = registration.settingType;
     }
-    const {deprecationNotice} = registration;
-    if (deprecationNotice?.disabled) {
-      const experiment = deprecationNotice.experiment ?
-          Root.Runtime.experiments.allConfigurableExperiments().find(e => e.name === deprecationNotice.experiment) :
-          undefined;
-      if ((!experiment || experiment.isEnabled())) {
-        this.set(this.defaultValue);
-        this.setDisabled(true);
-      }
-    }
   }
 
   type(): SettingType|null {
@@ -758,16 +730,6 @@ export class Setting<V> {
     return this.#registration?.learnMore ?? null;
   }
 
-  get deprecation(): Deprecation|null {
-    if (!this.#registration || !this.#registration.deprecationNotice) {
-      return null;
-    }
-    if (!this.#deprecation) {
-      this.#deprecation = new Deprecation(this.#registration);
-    }
-    return this.#deprecation;
-  }
-
   private printSettingsSavingError(message: string, value: string): void {
     const errorMessage =
         'Error saving setting with name: ' + this.name + ', value length: ' + value.length + '. Error: ' + message;