chrome-devtools-frontend 1.0.1650232 → 1.0.1651641

package/front_end/third_party/puppeteer/package/src/node/ChromeLauncher.ts

@@ -107,20 +107,28 @@ export class ChromeLauncher extends BrowserLauncher {
 
     // Check for the user data dir argument, which will always be set even
     // with a custom directory specified via the userDataDir option.
-    let userDataDirIndex = chromeArguments.findIndex(arg => {
+    const userDataDirIndex = chromeArguments.findIndex(arg => {
       return arg.startsWith('--user-data-dir');
     });
+
+    let userDataDir: string;
     if (userDataDirIndex < 0) {
       isTempUserDataDir = true;
-      chromeArguments.push(
-        `--user-data-dir=${await mkdtemp(await this.getProfilePath())}`,
+      const profilePath = await this.getProfilePath();
+      userDataDir = await mkdtemp(profilePath);
+      chromeArguments.push(`--user-data-dir=${userDataDir}`);
+    } else {
+      const parsedUserDataDir = chromeArguments[userDataDirIndex]!.split(
+        '=',
+        2,
+      )[1];
+      assert(
+        typeof parsedUserDataDir === 'string',
+        '`--user-data-dir` is malformed',
       );
-      userDataDirIndex = chromeArguments.length - 1;
+      userDataDir = parsedUserDataDir;
     }
 
-    const userDataDir = chromeArguments[userDataDirIndex]!.split('=', 2)[1];
-    assert(typeof userDataDir === 'string', '`--user-data-dir` is malformed');
-
     let chromeExecutable = executablePath;
     if (!chromeExecutable) {
       assert(
@@ -151,7 +159,7 @@ export class ChromeLauncher extends BrowserLauncher {
       try {
         await rm(path);
       } catch (error) {
-        debugError(error);
+        debugError?.(error);
         throw error;
       }
     }
@@ -273,11 +281,9 @@ export class ChromeLauncher extends BrowserLauncher {
         '--mute-audio',
       );
     }
-    chromeArguments.push(
-      enableExtensions
-        ? '--enable-unsafe-extension-debugging'
-        : '--disable-extensions',
-    );
+    if (!enableExtensions) {
+      chromeArguments.push('--disable-extensions');
+    }
     if (
       args.every(arg => {
         return arg.startsWith('-');

package/front_end/third_party/puppeteer/package/src/node/FirefoxLauncher.ts

@@ -141,7 +141,7 @@ export class FirefoxLauncher extends BrowserLauncher {
       try {
         await rm(userDataDir);
       } catch (error) {
-        debugError(error);
+        debugError?.(error);
         throw error;
       }
     } else {
@@ -165,7 +165,7 @@ export class FirefoxLauncher extends BrowserLauncher {
           }
         }
       } catch (error) {
-        debugError(error);
+        debugError?.(error);
       }
     }
   }

package/front_end/third_party/puppeteer/package/src/node/NodeWebSocketTransport.ts

@@ -6,7 +6,7 @@
 import NodeWebSocket from 'ws';
 
 import type {ConnectionTransport} from '../common/ConnectionTransport.js';
-import {debugError} from '../common/util.js';
+import {debugCatchError} from '../common/util.js';
 import {packageVersion} from '../util/version.js';
 
 /**
@@ -53,7 +53,7 @@ export class NodeWebSocketTransport implements ConnectionTransport {
       }
     });
     // Silently log all errors - we don't know what to do with them.
-    this.#ws.addEventListener('error', debugError);
+    this.#ws.addEventListener('error', debugCatchError);
   }
 
   send(message: string): void {

package/front_end/third_party/puppeteer/package/src/node/PipeTransport.ts

@@ -5,7 +5,7 @@
  */
 import type {ConnectionTransport} from '../common/ConnectionTransport.js';
 import {EventEmitter} from '../common/EventEmitter.js';
-import {debugError} from '../common/util.js';
+import {debugCatchError} from '../common/util.js';
 import {assert} from '../util/assert.js';
 import {DisposableStack} from '../util/disposable.js';
 
@@ -42,7 +42,7 @@ export class PipeTransport implements ConnectionTransport {
         this.onclose.call(null);
       }
     });
-    pipeReadEmitter.on('error', debugError);
+    pipeReadEmitter.on('error', debugCatchError);
     const pipeWriteEmitter = this.#subscriptions.use(
       // NodeJS event emitters don't support `*` so we need to typecast
       // As long as we don't use it we should be OK.
@@ -50,7 +50,7 @@ export class PipeTransport implements ConnectionTransport {
         pipeWrite as unknown as EventEmitter<Record<string, any>>,
       ),
     );
-    pipeWriteEmitter.on('error', debugError);
+    pipeWriteEmitter.on('error', debugCatchError);
   }
 
   send(message: string): void {

package/front_end/third_party/puppeteer/package/src/node/ScreenRecorder.ts

@@ -27,7 +27,7 @@ import {CDPSessionEvent} from '../api/CDPSession.js';
 import type {BoundingBox} from '../api/ElementHandle.js';
 import type {Page, VideoFormat} from '../api/Page.js';
 import {debug} from '../common/Debug.js';
-import {debugError, fromEmitterEvent} from '../common/util.js';
+import {fromEmitterEvent, debugCatchError} from '../common/util.js';
 import {guarded} from '../util/decorators.js';
 import {asyncDisposeSymbol} from '../util/disposable.js';
 
@@ -36,6 +36,36 @@ const DEFAULT_FPS = 30;
 
 const debugFfmpeg = debug('puppeteer:ffmpeg');
 
+/**
+ * Computes how many encoder frames to emit for a captured frame that spans
+ * `[previousTimestamp, timestamp]`, so that the cumulative number of emitted
+ * frames tracks a constant-`fps` grid anchored at `startTimestamp`.
+ *
+ * Counting each interval independently with
+ * `Math.round(fps * (timestamp - previousTimestamp))` is wrong when frames are
+ * captured faster than `fps`: every sub-`1/fps` interval still rounds up to a
+ * whole frame, so the emitted frame count grows with the capture rate instead
+ * of staying at `fps * duration`, which stretches playback (and, for very high
+ * capture rates, the per-interval value rounds down to 0 and frames are
+ * dropped). Differencing the rounded cumulative position keeps the total at
+ * `Math.round(fps * (lastTimestamp - startTimestamp))`, independent of the
+ * capture rate.
+ *
+ * Timestamps are in seconds (CDP `Page.screencastFrame` metadata timestamps).
+ *
+ * @internal
+ */
+export function countFrames(
+  startTimestamp: number,
+  previousTimestamp: number,
+  timestamp: number,
+  fps: number,
+): number {
+  const end = Math.round((timestamp - startTimestamp) * fps);
+  const start = Math.round((previousTimestamp - startTimestamp) * fps);
+  return Math.max(0, end - start);
+}
+
 /**
  * @internal
  */
@@ -160,15 +190,17 @@ export class ScreenRecorder extends PassThrough {
           'nobuffer',
         ],
         // Forces input to be read from standard input, and forces png input
-        // image format.
-        ['-f', 'image2pipe', '-vcodec', 'png', '-i', 'pipe:0'],
+        // image format. `-framerate` is an input option and must appear before
+        // `-i`; otherwise ffmpeg ignores it and the image2pipe demuxer falls
+        // back to its default 25fps, stretching the output timeline relative to
+        // the frames we feed it at `fps`.
+        // prettier-ignore
+        ['-framerate', `${fps}`, '-f', 'image2pipe', '-vcodec', 'png', '-i', 'pipe:0'],
         // No audio
         ['-an'],
         // This drastically reduces stalling when cpu is overbooked. By default
         // VP9 tries to use all available threads?
         ['-threads', '1'],
-        // Specifies the frame rate we are giving ffmpeg.
-        ['-framerate', `${fps}`],
         // Disable bitrate.
         ['-b:v', '0'],
         // Specifies the encoding and format we are using.
@@ -184,16 +216,18 @@ export class ScreenRecorder extends PassThrough {
     );
     this.#process.stdout.pipe(this);
     this.#process.stderr.on('data', (data: Buffer) => {
-      debugFfmpeg(data.toString('utf8'));
+      debugFfmpeg?.(data.toString('utf8'));
     });
 
     this.#page = page;
 
     const {client} = this.#page.mainFrame();
     client.once(CDPSessionEvent.Disconnected, () => {
-      void this.stop().catch(debugError);
+      void this.stop().catch(debugCatchError);
     });
 
+    // Anchor for the constant-fps grid; set to the first frame's timestamp.
+    let startTimestamp: number | undefined;
     this.#lastFrame = lastValueFrom(
       fromEmitterEvent(client, 'Page.screencastFrame').pipe(
         tap(event => {
@@ -218,9 +252,10 @@ export class ScreenRecorder extends PassThrough {
           ]
         >,
         concatMap(([{timestamp: previousTimestamp, buffer}, {timestamp}]) => {
+          startTimestamp ??= previousTimestamp;
           return from(
             Array<Buffer>(
-              Math.round(fps * Math.max(timestamp - previousTimestamp, 0)),
+              countFrames(startTimestamp, previousTimestamp, timestamp, fps),
             ).fill(buffer),
           );
         }),
@@ -316,7 +351,7 @@ export class ScreenRecorder extends PassThrough {
       return;
     }
     // Stopping the screencast will flush the frames.
-    await this.#page._stopScreencast().catch(debugError);
+    await this.#page._stopScreencast().catch(debugCatchError);
 
     this.#controller.abort();
 

package/front_end/third_party/puppeteer/package/src/node-env-setup.ts

@@ -0,0 +1,18 @@
+/**
+ * @license
+ * Copyright 2026 Google Inc.
+ * SPDX-License-Identifier: Apache-2.0
+ */
+
+import fs from 'node:fs';
+import path from 'node:path';
+import {debuglog} from 'node:util';
+
+import {environment} from './environment.js';
+
+environment.value = {
+  fs,
+  path,
+  debuglog,
+  ScreenRecorder: environment.value.ScreenRecorder,
+};

package/front_end/third_party/puppeteer/package/src/puppeteer-core.ts

@@ -4,21 +4,17 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
-export * from './index.js';
+// Set up Node-specific environment dependencies before importing other modules.
+import './node-env-setup.js';
 
-import fs from 'node:fs';
-import path from 'node:path';
+export * from './index.js';
 
 import {environment} from './environment.js';
 
 import * as Puppeteer from './index.js';
 
-// Set up Node-specific environment dependencies.
-environment.value = {
-  fs,
-  path,
-  ScreenRecorder: Puppeteer.ScreenRecorder,
-};
+environment.value.ScreenRecorder = Puppeteer.ScreenRecorder;
+
 /**
  * @public
  */

package/front_end/third_party/puppeteer/package/src/revisions.ts

@@ -8,7 +8,7 @@
  * @internal
  */
 export const PUPPETEER_REVISIONS = Object.freeze({
-  chrome: '149.0.7827.22',
-  'chrome-headless-shell': '149.0.7827.22',
-  firefox: 'stable_151.0',
+  chrome: '150.0.7871.24',
+  'chrome-headless-shell': '150.0.7871.24',
+  firefox: 'stable_152.0.2',
 });

package/front_end/third_party/puppeteer/package/src/util/version.ts

@@ -6,5 +6,5 @@
 
 // If moved update release-please config
 // x-release-please-start-version
-export const packageVersion = '25.1.0';
+export const packageVersion = '25.2.1';
 // x-release-please-end

package/front_end/third_party/puppeteer/puppeteer-tsconfig.json

@@ -156,6 +156,7 @@
     "package/lib/puppeteer/injected/XPathQuerySelector.js",
     "package/lib/puppeteer/injected/injected.js",
     "package/lib/puppeteer/injected/util.js",
+    "package/lib/puppeteer/node-env-setup.js",
     "package/lib/puppeteer/node/BrowserLauncher.js",
     "package/lib/puppeteer/node/ChromeLauncher.js",
     "package/lib/puppeteer/node/FirefoxLauncher.js",

package/front_end/tsconfig.json

@@ -1,7 +1,6 @@
 {
   "extends": "../config/typescript/tsconfig.base.json",
   "compilerOptions": {
-    "allowUmdGlobalAccess": true,
     "outDir": "ignored",
     "rootDir": ".",
     "target": "ES2023",
@@ -28,7 +27,7 @@
         }
       }
     ],
-    "types": ["mocha", "sinon"]
+    "types": ["mocha"]
   },
   "exclude": ["devtools_compatibility.js"],
   "references": [{ "path": "./tsconfig.compatibility.json" }]

package/inspector_overlay/tsconfig.json

@@ -1,14 +1,7 @@
 {
   "extends": "../config/typescript/tsconfig.base.json",
   "compilerOptions": {
-    "allowUmdGlobalAccess": true,
-    "lib": [
-      "esnext",
-      "dom",
-      "dom.iterable",
-      "webworker",
-      "webworker.iterable"
-    ],
-    "outDir": "ignored-for-vscode",
-  },
+    "lib": ["esnext", "dom", "dom.iterable", "webworker", "webworker.iterable"],
+    "outDir": "ignored-for-vscode"
+  }
 }

package/mcp/tsconfig.json

@@ -1,7 +1,6 @@
 {
   "extends": "../config/typescript/tsconfig.base.json",
   "compilerOptions": {
-    "allowUmdGlobalAccess": true,
     "outDir": "ignored",
     "target": "ES2023",
     "lib": [
@@ -11,10 +10,7 @@
       "ESNext.Collection",
       "ESNext.Array"
     ],
-    "typeRoots": [
-      "../node_modules/@types",
-      "../node_modules",
-    ],
+    "typeRoots": ["../node_modules/@types", "../node_modules"],
     "types": ["node", "undici-types"]
   },
   "references": [{ "path": "../front_end/tsconfig.json" }]

package/package.json

@@ -68,7 +68,6 @@
     "karma-coverage": "2.2.1",
     "karma-mocha": "2.0.1",
     "karma-mocha-reporter": "2.2.5",
-    "karma-sinon": "1.0.5",
     "karma-sourcemap-loader": "0.4.0",
     "karma-spec-reporter": "0.0.36",
     "license-checker": "25.0.1",
@@ -92,5 +91,5 @@
     "webidl2": "24.5.0",
     "yargs": "17.7.2"
   },
-  "version": "1.0.1650232"
+  "version": "1.0.1651641"
 }