chrome-devtools-frontend 1.0.1650232 → 1.0.1651641

package/front_end/third_party/puppeteer/package/src/api/JSHandle.ts

@@ -7,7 +7,7 @@
 import type Protocol from 'devtools-protocol';
 
 import type {EvaluateFuncWith, HandleFor, HandleOr} from '../common/types.js';
-import {debugError, withSourcePuppeteerURLIfNone} from '../common/util.js';
+import {withSourcePuppeteerURLIfNone, debugCatchError} from '../common/util.js';
 import {moveable, throwIfDisposed} from '../util/decorators.js';
 import {disposeSymbol, asyncDisposeSymbol} from '../util/disposable.js';
 
@@ -135,14 +135,7 @@ export abstract class JSHandle<T = unknown> {
   @throwIfDisposed()
   async getProperties(): Promise<Map<string, JSHandle>> {
     const propertyNames = await this.evaluate(object => {
-      const enumerableProperties = [];
-      const descriptors = Object.getOwnPropertyDescriptors(object);
-      for (const propertyName in descriptors) {
-        if (descriptors[propertyName]?.enumerable) {
-          enumerableProperties.push(propertyName);
-        }
-      }
-      return enumerableProperties;
+      return Object.keys(object ?? {});
     });
     const map = new Map<string, JSHandle>();
     const results = await Promise.all(
@@ -202,7 +195,7 @@ export abstract class JSHandle<T = unknown> {
 
   /** @internal */
   [disposeSymbol](): void {
-    return void this[asyncDisposeSymbol]().catch(debugError);
+    return void this[asyncDisposeSymbol]().catch(debugCatchError);
   }
 
   /** @internal */

package/front_end/third_party/puppeteer/package/src/api/Page.ts

@@ -61,7 +61,6 @@ import type {
   NodeFor,
 } from '../common/types.js';
 import {
-  debugError,
   fromEmitterEvent,
   filterAsync,
   isString,
@@ -69,6 +68,7 @@ import {
   timeout,
   withSourcePuppeteerURLIfNone,
   fromAbortSignal,
+  debugCatchError,
 } from '../common/util.js';
 import type {Viewport} from '../common/Viewport.js';
 import {environment} from '../environment.js';
@@ -910,7 +910,8 @@ export abstract class Page extends EventEmitter<PageEvents> {
   /**
    * A target this page was created from.
    *
-   * @deprecated Use {@link Page.createCDPSession} directly.
+   * @deprecated To create CDP session use {@link Page.createCDPSession} directly. To
+   * identify pages spawned by this one, use {@link PageEvent.Popup} event instead.
    */
   abstract target(): Target;
 
@@ -955,9 +956,8 @@ export abstract class Page extends EventEmitter<PageEvents> {
   abstract get tracing(): Tracing;
 
   /**
-   * Experimental API for {@link https://github.com/webmachinelearning/webmcp
-   * | WebMCP}. Requires Chrome 149+ with the
-   * `--enable-features=WebMCPTesting,DevToolsWebMCPSupport` flags enabled.
+   * Experimental API for {@link https://github.com/webmachinelearning/webmcp| WebMCP}.
+   * Requires Chrome 150+ with the `--enable-features=WebMCP` flag enabled.
    *
    * @experimental
    */
@@ -2220,6 +2220,12 @@ export abstract class Page extends EventEmitter<PageEvents> {
    */
   abstract emulateMediaFeatures(features?: MediaFeature[]): Promise<void>;
 
+  /**
+   * @param locale - Locale to emulate on the page. Passing no locale disables
+   * locale emulation.
+   */
+  abstract emulateLocale(locale?: string): Promise<void>;
+
   /**
    * @param timezoneId - Changes the timezone of the page. See
    * {@link https://source.chromium.org/chromium/chromium/deps/icu.git/+/faee8bc70570192d82d2978a71e2a615788597d1:source/data/misc/metaZones.txt | ICU’s metaZones.txt}
@@ -2614,7 +2620,7 @@ export abstract class Page extends EventEmitter<PageEvents> {
     if (viewport && viewport.deviceScaleFactor !== 0) {
       await this.setViewport({...viewport, deviceScaleFactor: 0});
       stack.defer(() => {
-        void this.setViewport(viewport).catch(debugError);
+        void this.setViewport(viewport).catch(debugCatchError);
       });
     }
     return await this.mainFrame()
@@ -2738,7 +2744,7 @@ export abstract class Page extends EventEmitter<PageEvents> {
             ...scrollDimensions,
           });
           stack.defer(async () => {
-            await this.setViewport(viewport).catch(debugError);
+            await this.setViewport(viewport).catch(debugCatchError);
           });
         }
       } else {
@@ -3228,7 +3234,7 @@ export abstract class Page extends EventEmitter<PageEvents> {
 
   /** @internal */
   override [disposeSymbol](): void {
-    return void this[asyncDisposeSymbol]().catch(debugError);
+    return void this[asyncDisposeSymbol]().catch(debugCatchError);
   }
 
   /** @internal */

package/front_end/third_party/puppeteer/package/src/api/WebWorker.ts

@@ -155,6 +155,36 @@ export abstract class WebWorker extends EventEmitter<WebWorkerEvents> {
     return await this.mainRealm().evaluateHandle(func, ...args);
   }
 
+  /**
+   * Waits for the provided function, `workerFunction`, to return a truthy value when
+   * evaluated in the page's context.
+   *
+   * @param workerFunction - Function to be evaluated in browser context until it
+   * returns a truthy value.
+   * @param options - Options for configuring waiting behavior.
+   */
+  waitForFunction<
+    Params extends unknown[],
+    Func extends EvaluateFunc<Params> = EvaluateFunc<Params>,
+  >(
+    workerFunction: Func | string,
+    options: {
+      polling?: number;
+      timeout?: number;
+      signal?: AbortSignal;
+    } = {},
+    ...args: Params
+  ): Promise<HandleFor<Awaited<ReturnType<Func>>>> {
+    return this.mainRealm().waitForFunction(
+      workerFunction,
+      {
+        polling: 100,
+        ...options,
+      },
+      ...args,
+    );
+  }
+
   async close(): Promise<void> {
     throw new UnsupportedOperation('WebWorker.close() is not supported');
   }

package/front_end/third_party/puppeteer/package/src/api/locators/locators.ts

@@ -33,7 +33,7 @@ import {
 import type {EventType} from '../../common/EventEmitter.js';
 import {EventEmitter} from '../../common/EventEmitter.js';
 import type {Awaitable, HandleFor, NodeFor} from '../../common/types.js';
-import {debugError, fromAbortSignal, timeout} from '../../common/util.js';
+import {fromAbortSignal, timeout, debugCatchError} from '../../common/util.js';
 import type {
   BoundingBox,
   ClickOptions,
@@ -400,7 +400,7 @@ export abstract class Locator<T> extends EventEmitter<LocatorEvents> {
       mergeMap(handle => {
         return from(handle.click(options)).pipe(
           catchError(err => {
-            void handle.dispose().catch(debugError);
+            void handle.dispose().catch(debugCatchError);
             throw err;
           }),
         );
@@ -595,7 +595,7 @@ export abstract class Locator<T> extends EventEmitter<LocatorEvents> {
           )
           .pipe(
             catchError(err => {
-              void handle.dispose().catch(debugError);
+              void handle.dispose().catch(debugCatchError);
               throw err;
             }),
           );
@@ -624,7 +624,7 @@ export abstract class Locator<T> extends EventEmitter<LocatorEvents> {
       mergeMap(handle => {
         return from(handle.hover()).pipe(
           catchError(err => {
-            void handle.dispose().catch(debugError);
+            void handle.dispose().catch(debugCatchError);
             throw err;
           }),
         );
@@ -666,7 +666,7 @@ export abstract class Locator<T> extends EventEmitter<LocatorEvents> {
           ),
         ).pipe(
           catchError(err => {
-            void handle.dispose().catch(debugError);
+            void handle.dispose().catch(debugCatchError);
             throw err;
           }),
         );

package/front_end/third_party/puppeteer/package/src/bidi/BidiOverCdp.ts

@@ -4,7 +4,7 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
-import * as BidiMapper from 'chromium-bidi/lib/bidiMapper/BidiMapper.js';
+import {BidiMapper} from 'chromium-bidi';
 import type {ProtocolMapping} from 'devtools-protocol/types/protocol-mapping.js';
 
 import type {CDPEvents, CDPSession} from '../api/CDPSession.js';
@@ -16,7 +16,7 @@ import type {Handler} from '../common/EventEmitter.js';
 import {BidiConnection} from './Connection.js';
 
 const bidiServerLogger = (prefix: string, ...args: unknown[]): void => {
-  debug(`bidi:${prefix}`)(args);
+  debug(`bidi:${prefix}`)?.(args);
 };
 
 /**

package/front_end/third_party/puppeteer/package/src/bidi/Browser.ts

@@ -130,7 +130,7 @@ export class BidiBrowser extends Browser {
             });
           } catch (err) {
             if (err instanceof ProtocolError) {
-              debugError(err);
+              debugError?.(err);
             } else {
               throw err;
             }
@@ -250,7 +250,7 @@ export class BidiBrowser extends Browser {
       await this.#closeCallback?.call(null);
     } catch (error) {
       // Fail silently.
-      debugError(error);
+      debugError?.(error);
     } finally {
       this.connection.dispose();
     }
@@ -364,7 +364,7 @@ export class BidiBrowser extends Browser {
       await this.#browserCore.session.end();
     } catch (error) {
       // Fail silently.
-      debugError(error);
+      debugError?.(error);
     } finally {
       this.connection.dispose();
     }

package/front_end/third_party/puppeteer/package/src/bidi/BrowserConnector.ts

@@ -9,7 +9,7 @@ import {Connection} from '../cdp/Connection.js';
 import type {ConnectionTransport} from '../common/ConnectionTransport.js';
 import type {ConnectOptions} from '../common/ConnectOptions.js';
 import {ProtocolError, UnsupportedOperation} from '../common/Errors.js';
-import {debugError, DEFAULT_VIEWPORT} from '../common/util.js';
+import {DEFAULT_VIEWPORT, debugCatchError} from '../common/util.js';
 import {createIncrementalIdGenerator} from '../util/incremental-id-generator.js';
 
 import type {BidiBrowser} from './Browser.js';
@@ -90,7 +90,9 @@ async function getBiDiConnection(
       return {
         bidiConnection: pureBidiConnection,
         closeCallback: async () => {
-          await pureBidiConnection.send('browser.close', {}).catch(debugError);
+          await pureBidiConnection
+            .send('browser.close', {})
+            .catch(debugCatchError);
         },
       };
     }
@@ -126,7 +128,7 @@ async function getBiDiConnection(
     bidiConnection: bidiOverCdpConnection,
     closeCallback: async () => {
       // In case of BiDi over CDP, we need to close browser via CDP.
-      await cdpConnection.send('Browser.close').catch(debugError);
+      await cdpConnection.send('Browser.close').catch(debugCatchError);
     },
   };
 }

package/front_end/third_party/puppeteer/package/src/bidi/BrowserContext.ts

@@ -20,7 +20,7 @@ import type {Target} from '../api/Target.js';
 import type {Cookie, CookieData} from '../common/Cookie.js';
 import {UnsupportedOperation} from '../common/Errors.js';
 import {EventEmitter} from '../common/EventEmitter.js';
-import {debugError} from '../common/util.js';
+import {debugError, debugCatchError} from '../common/util.js';
 import type {Viewport} from '../common/Viewport.js';
 import {assert} from '../util/assert.js';
 import {bubble} from '../util/decorators.js';
@@ -214,7 +214,7 @@ export class BidiBrowserContext extends BrowserContext {
         await page.setViewport(this.#defaultViewport);
       } catch (error) {
         // Tolerate not supporting `browsingContext.setViewport`. Only log it.
-        debugError(error);
+        debugError?.(error);
       }
     }
     if (options?.type === 'window' && options?.windowBounds !== undefined) {
@@ -225,7 +225,7 @@ export class BidiBrowserContext extends BrowserContext {
         );
       } catch (error) {
         // Tolerate not supporting `browser.setClientWindowState`. Only log it.
-        debugError(error);
+        debugError?.(error);
       }
     }
 
@@ -241,7 +241,7 @@ export class BidiBrowserContext extends BrowserContext {
     try {
       await this.userContext.remove();
     } catch (error) {
-      debugError(error);
+      debugError?.(error);
     }
 
     this.#targets.clear();
@@ -287,7 +287,7 @@ export class BidiBrowserContext extends BrowserContext {
           // TODO: some permissions are outdated and setting them to denied does
           // not work.
           if (!permissionsSet.has(permission)) {
-            return result.catch(debugError);
+            return result.catch(debugCatchError);
           }
           return result;
         },
@@ -345,7 +345,7 @@ export class BidiBrowserContext extends BrowserContext {
           },
           Bidi.Permissions.PermissionState.Prompt,
         )
-        .catch(debugError);
+        .catch(debugCatchError);
     });
     this.#overrides = [];
     await Promise.all(promises);

package/front_end/third_party/puppeteer/package/src/bidi/Connection.ts

@@ -4,7 +4,7 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
-import type * as ChromiumBidi from 'chromium-bidi/lib/protocol/protocol.js';
+import type {Protocol as ChromiumBidi} from 'chromium-bidi';
 import type * as Bidi from 'webdriver-bidi-protocol';
 
 import {CallbackRegistry} from '../common/CallbackRegistry.js';
@@ -131,7 +131,7 @@ export class BidiConnection
         method,
         params,
       } as Bidi.Command);
-      debugProtocolSend(stringifiedMessage);
+      debugProtocolSend?.(stringifiedMessage);
       this.#transport.send(stringifiedMessage);
     }) as Promise<{result: Commands[T]['returnType']}>;
   }
@@ -145,7 +145,7 @@ export class BidiConnection
         return setTimeout(f, this.#delay);
       });
     }
-    debugProtocolReceive(message);
+    debugProtocolReceive?.(message);
     const object: Bidi.Message | CdpEvent = JSON.parse(message);
     if ('type' in object) {
       switch (object.type) {
@@ -183,7 +183,7 @@ export class BidiConnection
         object.message,
       );
     }
-    debugError(object);
+    debugError?.(object);
   }
 
   /**

package/front_end/third_party/puppeteer/package/src/bidi/Deserializer.ts

@@ -14,7 +14,7 @@ import {debugError} from '../common/util.js';
 export class BidiDeserializer {
   static deserialize(result: Bidi.Script.RemoteValue): any {
     if (!result) {
-      debugError('Service did not produce a result.');
+      debugError?.('Service did not produce a result.');
       return undefined;
     }
 
@@ -58,7 +58,7 @@ export class BidiDeserializer {
         return result.value;
     }
 
-    debugError(`Deserialization of type ${result.type} not supported.`);
+    debugError?.(`Deserialization of type ${result.type} not supported.`);
     return undefined;
   }
 

package/front_end/third_party/puppeteer/package/src/bidi/ExposedFunction.ts

@@ -8,7 +8,7 @@ import * as Bidi from 'webdriver-bidi-protocol';
 
 import {EventEmitter} from '../common/EventEmitter.js';
 import type {Awaitable, FlattenHandle} from '../common/types.js';
-import {debugError} from '../common/util.js';
+import {debugError, debugCatchError} from '../common/util.js';
 import {DisposableStack} from '../util/disposable.js';
 import {interpolateFunction, stringifyFunction} from '../util/Function.js';
 
@@ -119,7 +119,7 @@ export class ExposableFunction<Args extends unknown[], Ret> {
         } catch (error) {
           // If it errors, the frame probably doesn't support call function. We
           // fail gracefully.
-          debugError(error);
+          debugError?.(error);
         }
       }),
     );
@@ -192,7 +192,7 @@ export class ExposableFunction<Args extends unknown[], Ret> {
           }, error);
         }
       } catch (error) {
-        debugError(error);
+        debugError?.(error);
       }
       return;
     }
@@ -202,7 +202,7 @@ export class ExposableFunction<Args extends unknown[], Ret> {
         resolve(result);
       }, result);
     } catch (error) {
-      debugError(error);
+      debugError?.(error);
     }
   };
 
@@ -227,7 +227,7 @@ export class ExposableFunction<Args extends unknown[], Ret> {
   }
 
   [Symbol.dispose](): void {
-    void this[Symbol.asyncDispose]().catch(debugError);
+    void this[Symbol.asyncDispose]().catch(debugCatchError);
   }
 
   async [Symbol.asyncDispose](): Promise<void> {
@@ -248,7 +248,7 @@ export class ExposableFunction<Args extends unknown[], Ret> {
             frame.browsingContext.removePreloadScript(script),
           ]);
         } catch (error) {
-          debugError(error);
+          debugError?.(error);
         }
       }),
     );

package/front_end/third_party/puppeteer/package/src/bidi/Frame.ts

@@ -198,7 +198,7 @@ export class BidiFrame extends Frame {
         error.stack = [...messageLines, ...stackLines].join('\n');
         this.page().trustedEmitter.emit(PageEvent.PageError, error);
       } else {
-        debugError(
+        debugError?.(
           `Unhandled LogEntry with type "${entry.type}", text "${entry.text}" and level "${entry.level}"`,
         );
       }

package/front_end/third_party/puppeteer/package/src/bidi/Page.ts

@@ -382,6 +382,10 @@ export class BidiPage extends Page {
     return await this.#frame.browsingContext.setTimezoneOverride(timezoneId);
   }
 
+  override async emulateLocale(locale?: string): Promise<void> {
+    return await this.#frame.browsingContext.setLocaleOverride(locale);
+  }
+
   override async emulateIdleState(overrides?: {
     isUserActive: boolean;
     isScreenUnlocked: boolean;

package/front_end/third_party/puppeteer/package/src/bidi/Realm.ts

@@ -269,7 +269,7 @@ export abstract class BidiRealm extends Realm {
     await this.realm.disown(handleIds).catch(error => {
       // Exceptions might happen in case of a page been navigated or closed.
       // Swallow these since they are harmless and we don't leak anything in this case.
-      debugError(error);
+      debugError?.(error);
     });
   }
 

package/front_end/third_party/puppeteer/package/src/bidi/core/BrowsingContext.ts

@@ -606,6 +606,17 @@ export class BrowsingContext extends EventEmitter<{
     );
   }
 
+  @throwIfDisposed<BrowsingContext>(context => {
+    // SAFETY: Disposal implies this exists.
+    return context.#reason!;
+  })
+  async setLocaleOverride(locale?: string): Promise<void> {
+    await this.userContext.browser.session.send('emulation.setLocaleOverride', {
+      locale: locale ?? null,
+      contexts: [this.id],
+    });
+  }
+
   @throwIfDisposed<BrowsingContext>(context => {
     // SAFETY: Disposal implies this exists.
     return context.#reason!;

package/front_end/third_party/puppeteer/package/src/cdp/Accessibility.ts

@@ -281,12 +281,14 @@ export class Accessibility {
           root.iframeSnapshot = iframeSnapshot ?? undefined;
         } catch (error) {
           // Frames can get detached at any time resulting in errors.
-          debugError(error);
+          debugError?.(error);
         }
       }
-      for (const child of root.children) {
-        await populateIframes(child);
-      }
+      await Promise.all(
+        root.children.map(child => {
+          return populateIframes(child);
+        }),
+      );
     };
 
     let needle: AXNode | null = defaultRoot;

package/front_end/third_party/puppeteer/package/src/cdp/Binding.ts

@@ -4,7 +4,7 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 import {JSHandle} from '../api/JSHandle.js';
-import {debugError} from '../common/util.js';
+import {debugCatchError} from '../common/util.js';
 import {DisposableStack} from '../util/disposable.js';
 import {isErrorLike} from '../util/ErrorLike.js';
 
@@ -112,7 +112,7 @@ export class Binding {
             error.message,
             error.stack,
           )
-          .catch(debugError);
+          .catch(debugCatchError);
       } else {
         await context
           .evaluate(
@@ -126,7 +126,7 @@ export class Binding {
             id,
             error,
           )
-          .catch(debugError);
+          .catch(debugCatchError);
       }
     }
   }

package/front_end/third_party/puppeteer/package/src/cdp/Browser.ts

@@ -28,6 +28,7 @@ import type {Page} from '../api/Page.js';
 import type {Target} from '../api/Target.js';
 import type {DownloadBehavior} from '../common/DownloadBehavior.js';
 import type {Viewport} from '../common/Viewport.js';
+import {Deferred} from '../util/Deferred.js';
 
 import {CdpBrowserContext} from './BrowserContext.js';
 import type {CdpCDPSession} from './CdpSession.js';
@@ -121,6 +122,7 @@ export class CdpBrowser extends BrowserBase {
   #targetManager: TargetManager;
   #handleDevToolsAsPage = false;
   #extensions = new Map<string, Extension>();
+  #version?: Deferred<Protocol.Browser.GetVersionResponse>;
 
   constructor(
     connection: Connection,
@@ -601,8 +603,18 @@ export class CdpBrowser extends BrowserBase {
     return !this.#connection._closed;
   }
 
-  #getVersion(): Promise<Protocol.Browser.GetVersionResponse> {
-    return this.#connection.send('Browser.getVersion');
+  async #getVersion(): Promise<Protocol.Browser.GetVersionResponse> {
+    if (!this.#version) {
+      this.#version = Deferred.create<Protocol.Browser.GetVersionResponse>();
+      try {
+        this.#version.resolve(
+          await this.#connection.send('Browser.getVersion'),
+        );
+      } catch (error) {
+        this.#version.reject(error as Error);
+      }
+    }
+    return await this.#version.valueOrThrow();
   }
 
   override get debugInfo(): DebugInfo {

package/front_end/third_party/puppeteer/package/src/cdp/BrowserConnector.ts

@@ -6,7 +6,7 @@
 
 import type {ConnectionTransport} from '../common/ConnectionTransport.js';
 import type {ConnectOptions} from '../common/ConnectOptions.js';
-import {debugError, DEFAULT_VIEWPORT} from '../common/util.js';
+import {DEFAULT_VIEWPORT, debugCatchError} from '../common/util.js';
 import {createIncrementalIdGenerator} from '../util/incremental-id-generator.js';
 
 import {CdpBrowser} from './Browser.js';
@@ -59,7 +59,7 @@ export async function _connectToCdpBrowser(
     downloadBehavior,
     undefined,
     () => {
-      return connection.send('Browser.close').catch(debugError);
+      return connection.send('Browser.close').catch(debugCatchError);
     },
     targetFilter,
     isPageTarget,

package/front_end/third_party/puppeteer/package/src/cdp/Connection.ts

@@ -176,7 +176,7 @@ export class Connection extends EventEmitter<CDPSessionEvents> {
         id,
         sessionId,
       });
-      debugProtocolSend(stringifiedMessage);
+      debugProtocolSend?.(stringifiedMessage);
       this.#transport.send(stringifiedMessage);
     }) as Promise<ProtocolMapping.Commands[T]['returnType']>;
   }
@@ -197,7 +197,7 @@ export class Connection extends EventEmitter<CDPSessionEvents> {
         return setTimeout(r, this.#delay);
       });
     }
-    debugProtocolReceive(message);
+    debugProtocolReceive?.(message);
     const object = JSON.parse(message);
     if (object.method === 'Target.attachedToTarget') {
       const sessionId = object.params.sessionId;

package/front_end/third_party/puppeteer/package/src/cdp/Coverage.ts

@@ -281,7 +281,7 @@ export class JSCoverage {
       this.#scriptSources.set(event.scriptId, response.scriptSource);
     } catch (error) {
       // This might happen if the page has already navigated away.
-      debugError(error);
+      debugError?.(error);
     }
   }
 
@@ -393,7 +393,7 @@ export class CSSCoverage {
       this.#stylesheetSources.set(header.styleSheetId, response.text);
     } catch (error) {
       // This might happen if the page has already navigated away.
-      debugError(error);
+      debugError?.(error);
     }
   }
 

package/front_end/third_party/puppeteer/package/src/cdp/ElementHandle.ts

@@ -92,7 +92,7 @@ export class CdpElementHandle<
         objectId: this.id,
       });
     } catch (error) {
-      debugError(error);
+      debugError?.(error);
       // Fallback to Element.scrollIntoView if DOM.scrollIntoViewIfNeeded is not supported
       await super.scrollIntoView();
     }