chrome-devtools-frontend 1.0.1642845 → 1.0.1643099

package/front_end/panels/elements/StylePropertyTreeElement.ts

@@ -2661,10 +2661,11 @@ export class StylePropertyTreeElement extends UI.TreeOutline.TreeElement {
     return container;
   }
 
-  #getLinkableFunction(functionName: string, matchedStyles: SDK.CSSMatchedStyles.CSSMatchedStyles):
-      InlineEditor.LinkSwatch.LinkSwatch {
+  #getLinkableFunction(
+      functionName: string, matchedStyles: SDK.CSSMatchedStyles.CSSMatchedStyles,
+      property: SDK.CSSProperty.CSSProperty): InlineEditor.LinkSwatch.LinkSwatch {
     const swatch = new InlineEditor.LinkSwatch.LinkSwatch();
-    const registeredFunction = matchedStyles.getRegisteredFunction(functionName);
+    const {registeredFunction, treeScopeDistance} = matchedStyles.getRegisteredFunction(functionName, property);
     const isDefined = Boolean(registeredFunction);
     swatch.data = {
       jslogContext: 'css-function',
@@ -2675,7 +2676,7 @@ export class StylePropertyTreeElement extends UI.TreeOutline.TreeElement {
         if (!registeredFunction) {
           return;
         }
-        this.#stylesContainer.jumpToFunctionDefinition(registeredFunction);
+        this.#stylesContainer.jumpToFunctionDefinition(registeredFunction, treeScopeDistance);
       },
     };
     return swatch;
@@ -2696,7 +2697,7 @@ export class StylePropertyTreeElement extends UI.TreeOutline.TreeElement {
     const tooltipId = this.getTooltipId(`${functionName}-trace`);
     // clang-format off
     return html`
-        <span tabIndex=-1 class=tracing-anchor aria-details=${tooltipId}>${functionName.startsWith('--') ? this.#getLinkableFunction(functionName, matchedStyles) : functionName}</span>
+        <span tabIndex=-1 class=tracing-anchor aria-details=${tooltipId}>${functionName.startsWith('--') ? this.#getLinkableFunction(functionName, matchedStyles, context.property) : functionName}</span>
         <devtools-tooltip
             id=${tooltipId}
             use-hotkey

package/front_end/panels/elements/StylesContainer.ts

@@ -37,7 +37,7 @@ export interface StylesContainer {
       computedValue: string|null): ElementsComponents.CSSVariableValueView.CSSVariableValueView;
   getVariableParserError(matchedStyles: SDK.CSSMatchedStyles.CSSMatchedStyles, variableName: string):
       ElementsComponents.CSSVariableValueView.CSSVariableParserError|null;
-  jumpToFunctionDefinition(functionName: string): void;
+  jumpToFunctionDefinition(functionName: string, treeScopeDistance: number): void;
   continueEditingElement(sectionIndex: number, propertyIndex: number): void;
   revealProperty(cssProperty: SDK.CSSProperty.CSSProperty): void;
   resetFocus(): void;

package/front_end/panels/elements/StylesSidebarPane.ts

@@ -344,16 +344,16 @@ export class StylesSidebarPane extends Common.ObjectWrapper.eventMixin<EventType
     }
   }
 
-  jumpToSection(sectionName: string, blockName: string): void {
-    this.decorator.findAndHighlightSection(sectionName, blockName);
+  jumpToSection(sectionName: string, blockName: string, treeScopeDistance?: number): void {
+    this.decorator.findAndHighlightSection(sectionName, blockName, treeScopeDistance);
   }
 
   jumpToSectionBlock(section: string): void {
     this.decorator.findAndHighlightSectionBlock(section);
   }
 
-  jumpToFunctionDefinition(functionName: string): void {
-    this.jumpToSection(functionName, FUNCTION_SECTION_NAME);
+  jumpToFunctionDefinition(functionName: string, treeScopeDistance: number): void {
+    this.jumpToSection(functionName, FUNCTION_SECTION_NAME, treeScopeDistance);
   }
 
   jumpToFontPaletteDefinition(paletteName: string): void {

package/front_end/panels/layer_viewer/PaintProfilerView.ts

@@ -11,9 +11,13 @@ import type * as SDK from '../../core/sdk/sdk.js';
 import type * as Protocol from '../../generated/protocol.js';
 import * as PerfUI from '../../ui/legacy/components/perf_ui/perf_ui.js';
 import * as UI from '../../ui/legacy/legacy.js';
+import * as Lit from '../../ui/lit/lit.js';
 
 import paintProfilerStyles from './paintProfiler.css.js';
 
+const {html, render, nothing} = Lit;
+const {repeat} = Lit.Directives;
+
 const UIStrings = {
   /**
    * @description Text to indicate the progress of a profile
@@ -397,161 +401,131 @@ export interface EventTypes {
   [Events.WINDOW_CHANGED]: void;
 }
 
-export class PaintProfilerCommandLogView extends UI.Widget.VBox {
-  private readonly treeOutline: UI.TreeOutline.TreeOutlineInShadow;
-  private log: SDK.PaintProfiler.PaintProfilerLogItem[];
-  private readonly treeItemCache: Map<SDK.PaintProfiler.PaintProfilerLogItem, LogTreeElement>;
-  private selectionWindow?: {left: number, right: number}|null;
-  constructor() {
-    super();
-    this.setMinimumSize(100, 25);
-    this.element.classList.add('overflow-auto');
-
-    this.treeOutline = new UI.TreeOutline.TreeOutlineInShadow();
-    UI.ARIAUtils.setLabel(this.treeOutline.contentElement, i18nString(UIStrings.commandLog));
-    this.element.appendChild(this.treeOutline.element);
-    this.setDefaultFocusedElement(this.treeOutline.contentElement);
-
-    this.log = [];
-    this.treeItemCache = new Map();
-  }
-
-  setCommandLog(log: SDK.PaintProfiler.PaintProfilerLogItem[]): void {
-    this.log = log;
+export interface CommandLogViewInput {
+  visibleLogItems: SDK.PaintProfiler.PaintProfilerLogItem[];
+}
 
-    this.updateWindow({left: 0, right: this.log.length});
+function paramToString(param: SDK.PaintProfiler.RawPaintProfilerLogItemParamValue, name: string): string {
+  if (typeof param !== 'object') {
+    return typeof param === 'string' && param.length > 100 ? name : JSON.stringify(param);
   }
-
-  private appendLogItem(logItem: SDK.PaintProfiler.PaintProfilerLogItem): void {
-    let treeElement = this.treeItemCache.get(logItem);
-    if (!treeElement) {
-      treeElement = new LogTreeElement(logItem);
-      this.treeItemCache.set(logItem, treeElement);
-    } else if (treeElement.parent) {
-      return;
+  let str = '';
+  let keyCount = 0;
+  for (const key in param) {
+    const paramKey = param[key];
+    if (++keyCount > 4 || typeof paramKey === 'object' || (typeof paramKey === 'string' && paramKey.length > 100)) {
+      return name;
+    }
+    if (str) {
+      str += ', ';
     }
-    this.treeOutline.appendChild(treeElement);
+    str += paramKey;
   }
+  return str;
+}
 
-  updateWindow(selectionWindow: {left: number, right: number}|null): void {
-    this.selectionWindow = selectionWindow;
-    this.requestUpdate();
+function paramsToString(params: SDK.PaintProfiler.RawPaintProfilerLogItemParams|null): string {
+  let str = '';
+  for (const key in params) {
+    if (str) {
+      str += ', ';
+    }
+    str += paramToString(params[key], key);
   }
+  return str;
+}
 
-  override performUpdate(): Promise<void> {
-    if (!this.selectionWindow || !this.log.length) {
-      this.treeOutline.removeChildren();
-      return Promise.resolve();
-    }
-    const root = this.treeOutline.rootElement();
-    for (;;) {
-      const child = root.firstChild() as LogTreeElement;
-      if (!child || child.logItem.commandIndex >= this.selectionWindow.left) {
-        break;
+function renderProperty(name: string, value: SDK.PaintProfiler.RawPaintProfilerLogItemParamValue): Lit.LitTemplate {
+  const isObject = value !== null && typeof value === 'object';
+
+  // clang-format off
+  return html`
+    <li role="treeitem">
+      <span>${name}: </span>${
+        isObject ? html`
+          <ul role="group">
+            ${Object.entries(value).map(([key, val]) => renderProperty(key, val))}
+          </ul>` : html`
+          <span>${JSON.stringify(value)}</span>`
       }
-      root.removeChildAtIndex(0);
-    }
-    for (;;) {
-      const child = root.lastChild() as LogTreeElement;
-      if (!child || child.logItem.commandIndex < this.selectionWindow.right) {
-        break;
-      }
-      root.removeChildAtIndex(root.children().length - 1);
-    }
-    for (let i = this.selectionWindow.left, right = this.selectionWindow.right; i < right; ++i) {
-      this.appendLogItem(this.log[i]);
-    }
-    return Promise.resolve();
-  }
+    </li>
+  `;
+  // clang-format on
 }
 
-export class LogTreeElement extends UI.TreeOutline.TreeElement {
-  readonly logItem: SDK.PaintProfiler.PaintProfilerLogItem;
+function renderLogItem(logItem: SDK.PaintProfiler.PaintProfilerLogItem): Lit.LitTemplate {
+  const hasParams = Boolean(logItem.params && Object.keys(logItem.params).length > 0);
+  const titleText = logItem.method + '(' + paramsToString(logItem.params) + ')';
+
+  // clang-format off
+  return html`
+    <li role="treeitem">
+      ${titleText}
+      ${hasParams ? html`
+        <ul role="group">
+          ${Object.entries(logItem.params || {}).map(([key, val]) => renderProperty(key, val))}
+        </ul>` : nothing}
+    </li>
+  `;
+  // clang-format on
+}
 
-  constructor(logItem: SDK.PaintProfiler.PaintProfilerLogItem) {
-    super('', Boolean(logItem.params));
-    this.logItem = logItem;
-  }
+// clang-format off
+export const COMMAND_LOG_DEFAULT_VIEW = (input: CommandLogViewInput, _output: undefined, target: HTMLElement): void => {
+  render(html`
+    <div class="overflow-auto flex-auto vbox">
+      <devtools-tree
+          autofocus
+          aria-label=${i18nString(UIStrings.commandLog)}
+          .template=${html`
+        <ul role="tree">
+          ${repeat(input.visibleLogItems,
+               item => item.commandIndex,
+               item => renderLogItem(item))}
+        </ul>`}>
+      </devtools-tree>
+    </div>`,
+    target);
+};
+// clang-format on
+
+type CommandLogView = typeof COMMAND_LOG_DEFAULT_VIEW;
 
-  override onattach(): void {
-    this.update();
-  }
+export class PaintProfilerCommandLogView extends UI.Widget.VBox {
+  private log: SDK.PaintProfiler.PaintProfilerLogItem[];
+  private selectionWindow?: {left: number, right: number}|null;
+  readonly #view: CommandLogView;
 
-  override async onpopulate(): Promise<void> {
-    for (const param in this.logItem.params) {
-      LogPropertyTreeElement.appendLogPropertyItem(this, param, this.logItem.params[param]);
-    }
-  }
+  constructor(element?: HTMLElement, view: CommandLogView = COMMAND_LOG_DEFAULT_VIEW) {
+    super(element);
+    this.#view = view;
+    this.setMinimumSize(100, 25);
 
-  private paramToString(param: SDK.PaintProfiler.RawPaintProfilerLogItemParamValue, name: string): string {
-    if (typeof param !== 'object') {
-      return typeof param === 'string' && param.length > 100 ? name : JSON.stringify(param);
-    }
-    let str = '';
-    let keyCount = 0;
-    for (const key in param) {
-      const paramKey = param[key];
-      if (++keyCount > 4 || paramKey === 'object' || (paramKey === 'string' && paramKey.length > 100)) {
-        return name;
-      }
-      if (str) {
-        str += ', ';
-      }
-      str += paramKey;
-    }
-    return str;
+    this.log = [];
   }
 
-  private paramsToString(params: SDK.PaintProfiler.RawPaintProfilerLogItemParams|null): string {
-    let str = '';
-    for (const key in params) {
-      if (str) {
-        str += ', ';
-      }
-      str += this.paramToString(params[key], key);
-    }
-    return str;
+  override wasShown(): void {
+    super.wasShown();
+    this.requestUpdate();
   }
 
-  private update(): void {
-    const title = document.createDocumentFragment();
-    UI.UIUtils.createTextChild(title, this.logItem.method + '(' + this.paramsToString(this.logItem.params) + ')');
-    this.title = title;
+  setCommandLog(log: SDK.PaintProfiler.PaintProfilerLogItem[]): void {
+    this.log = log;
+    this.updateWindow({left: 0, right: this.log.length});
   }
-}
-
-export class LogPropertyTreeElement extends UI.TreeOutline.TreeElement {
-  private property: {name: string, value: SDK.PaintProfiler.RawPaintProfilerLogItemParamValue};
 
-  constructor(property: {name: string, value: SDK.PaintProfiler.RawPaintProfilerLogItemParamValue}) {
-    super();
-    this.property = property;
+  updateWindow(selectionWindow: {left: number, right: number}|null): void {
+    this.selectionWindow = selectionWindow;
+    this.requestUpdate();
   }
 
-  static appendLogPropertyItem(
-      element: UI.TreeOutline.TreeElement, name: string,
-      value: SDK.PaintProfiler.RawPaintProfilerLogItemParamValue): void {
-    const treeElement = new LogPropertyTreeElement({name, value});
-    element.appendChild(treeElement);
-    if (value && typeof value === 'object') {
-      for (const property in value) {
-        LogPropertyTreeElement.appendLogPropertyItem(treeElement, property, value[property]);
-      }
-    }
-  }
+  override performUpdate(): Promise<void> {
+    const visibleLogItems = this.selectionWindow && this.log.length ?
+        this.log.slice(this.selectionWindow.left, this.selectionWindow.right) :
+        [];
 
-  override onattach(): void {
-    const title = document.createDocumentFragment();
-    const nameElement = title.createChild('span', 'name');
-    nameElement.textContent = this.property.name;
-    const separatorElement = title.createChild('span', 'separator');
-    separatorElement.textContent = ': ';
-    if (this.property.value === null || typeof this.property.value !== 'object') {
-      const valueElement = title.createChild('span', 'value');
-      valueElement.textContent = JSON.stringify(this.property.value);
-      valueElement.classList.add('cm-js-' + (this.property.value === null ? 'null' : typeof this.property.value));
-    }
-    this.title = title;
+    this.#view({visibleLogItems}, undefined, this.contentElement);
+    return Promise.resolve();
   }
 }
 

package/front_end/panels/lighthouse/LighthousePanel.ts

@@ -374,11 +374,12 @@ export class LighthousePanel extends UI.Panel.Panel {
   }
 
   private loadedFromFile(report: string): void {
-    const data = JSON.parse(report);
-    if (!data['lighthouseVersion']) {
+    const data = JSON.parse(report) as LighthouseModel.ReporterTypes.ReportJSON;
+    if (!data.lighthouseVersion) {
       return;
     }
-    this.buildReportUI(data as LighthouseModel.ReporterTypes.ReportJSON);
+    data.isImported = true;
+    this.buildReportUI(data);
   }
 
   override elementsToRestoreScrollPositionsFor(): Element[] {

package/front_end/panels/network/NetworkLogView.ts

@@ -54,6 +54,8 @@ import * as Adorners from '../../ui/components/adorners/adorners.js';
 import * as Buttons from '../../ui/components/buttons/buttons.js';
 import * as RenderCoordinator from '../../ui/components/render_coordinator/render_coordinator.js';
 import * as DataGrid from '../../ui/legacy/components/data_grid/data_grid.js';
+// eslint-disable-next-line @devtools/es-modules-import
+import dataGridAiButtonStyles from '../../ui/legacy/components/data_grid/dataGridAiButton.css.js';
 import * as PerfUI from '../../ui/legacy/components/perf_ui/perf_ui.js';
 import * as Components from '../../ui/legacy/components/utils/utils.js';
 import * as UI from '../../ui/legacy/legacy.js';
@@ -560,6 +562,7 @@ export class NetworkLogView extends Common.ObjectWrapper.eventMixin<EventTypes,
       networkLogLargeRowsSetting: Common.Settings.Setting<boolean>) {
     super();
     this.registerRequiredCSS(networkLogViewStyles);
+    this.registerRequiredCSS(dataGridAiButtonStyles);
     this.setMinimumSize(50, 64);
 
     this.element.id = 'network-container';
@@ -2504,7 +2507,11 @@ export class NetworkLogView extends Common.ObjectWrapper.eventMixin<EventTypes,
     // (it may be different from the inspected page platform).
     const escapeString = platform === 'win' ? escapeStringWin : escapeStringPosix;
 
-    command.push(escapeString(request.url()).replace(/[[{}\]]/g, '\\$&'));
+    // The shell escaping above protects the *shell* parser, but not curl's own
+    // argv parser: if the (HAR-imported) URL begins with '-', curl will parse
+    // it as an option (e.g. "-K//host/share/file" -> --config UNC path).
+    // Passing the URL via --url forces curl to treat it as a URL operand.
+    command.push('--url ' + escapeString(request.url()).replace(/[[{}\]]/g, '\\$&'));
 
     let inferredMethod = 'GET';
     const data = [];

package/front_end/panels/network/networkLogView.css

@@ -268,21 +268,6 @@ td.time-column {
   vertical-align: sub;
 }
 
-.data-grid-data-grid-node .ai-button-container {
-  display: none;
-  float: right;
-
-  devtools-floating-button {
-    position: absolute;
-    z-index: 999;
-    margin-left: -17px;
-  }
-}
-
-.data-grid-data-grid-node:hover .ai-button-container {
-  display: inline-flex;
-}
-
 .image-network-icon-preview {
   inset: 0;
   margin: auto;

package/front_end/panels/timeline/overlays/components/EntryLabelOverlay.ts

@@ -194,7 +194,7 @@ export class EntryLabelOverlay extends HTMLElement {
   #callTree: AiAssistanceModels.AICallTree.AICallTree|null = null;
   // Creates or gets the setting if it exists.
   #aiAnnotationsEnabledSetting = Common.Settings.Settings.instance().createSetting('ai-annotations-enabled', false);
-  #agent = new AiAssistanceModels.PerformanceAnnotationsAgent.PerformanceAnnotationsAgent({
+  #performanceAnnotations = new AiAssistanceModels.PerformanceAnnotations.PerformanceAnnotations({
     aidaClient: new Host.AidaClient.AidaClient(),
     serverSideLoggingEnabled: isAiAssistanceServerSideLoggingEnabled(),
   });
@@ -254,8 +254,9 @@ export class EntryLabelOverlay extends HTMLElement {
   /**
    * So we can provide a mocked agent in tests. Do not call this method outside of a test!
    */
-  overrideAIAgentForTest(agent: AiAssistanceModels.PerformanceAnnotationsAgent.PerformanceAnnotationsAgent): void {
-    this.#agent = agent;
+  overridePerformanceAnnotationsForTest(performanceAnnotations:
+                                            AiAssistanceModels.PerformanceAnnotations.PerformanceAnnotations): void {
+    this.#performanceAnnotations = performanceAnnotations;
   }
 
   entryHighlightWrapper(): HTMLElement|null {
@@ -534,7 +535,7 @@ export class EntryLabelOverlay extends HTMLElement {
         this.#focusInputBox();
         void ComponentHelpers.ScheduledRender.scheduleRender(this, this.#render);
 
-        this.#label = await this.#agent.generateAIEntryLabel(this.#callTree);
+        this.#label = await this.#performanceAnnotations.generateAIEntryLabel(this.#callTree);
         this.dispatchEvent(new EntryLabelChangeEvent(this.#label));
         this.#inputField.innerText = this.#label;
         this.#placeCursorAtInputEnd();

package/front_end/third_party/chromium/README.chromium

@@ -1,7 +1,7 @@
 Name: Dependencies sourced from the upstream `chromium` repository
 URL: Internal
 Version: N/A
-Revision: 2d046db188ecad76b2859f8baeb9685cb8fe9c08
+Revision: e1605f15bac37245745e5fb8327995ededbe2337
 Update Mechanism: Manual (https://crbug.com/428069060)
 License: BSD-3-Clause
 License File: LICENSE

package/front_end/third_party/lighthouse/README.chromium

@@ -1,7 +1,7 @@
 Name: Lighthouse
 Short Name: lighthouse
-Version: 13.3.0
-Revision: 7d8dcf5004950cad3faa20664e4a7cf2817bd653
+Version: 13.4.0
+Revision: cb79bea56c4668fd7a338f2f421f87754ee927a2
 Update Mechanism: Manual
 URL: https://github.com/GoogleChrome/lighthouse
 License: Apache-2.0