chrome-devtools-frontend 1.0.1601661 → 1.0.1602543

package/front_end/panels/profiler/HeapProfileView.ts

@@ -457,11 +457,15 @@ export class SamplingHeapProfileHeader extends WritableProfileHeader {
     nodes: never[],
   };
   constructor(
-      heapProfilerModel: SDK.HeapProfilerModel.HeapProfilerModel|null, type: SamplingHeapProfileTypeBase,
-      title?: string) {
+      heapProfilerModel: SDK.HeapProfilerModel.HeapProfilerModel|null,
+      type: SamplingHeapProfileTypeBase,
+      title?: string,
+  ) {
     super(
-        heapProfilerModel?.debuggerModel() ?? null, type,
-        title || i18nString(UIStrings.profileD, {PH1: type.nextProfileUid()}));
+        heapProfilerModel?.debuggerModel() ?? null,
+        type,
+        title || i18nString(UIStrings.profileD, {PH1: type.nextProfileUid()}),
+    );
     this.heapProfilerModelInternal = heapProfilerModel;
     this.protocolProfileInternal = {
       head: {

package/front_end/panels/profiler/HeapSnapshotDataGrids.ts

@@ -622,28 +622,27 @@ export class HeapSnapshotContainmentDataGrid extends HeapSnapshotSortableDataGri
   constructor(
       heapProfilerModel: SDK.HeapProfilerModel.HeapProfilerModel|null, dataDisplayDelegate: DataDisplayDelegate,
       displayName: string, columns?: DataGrid.DataGrid.ColumnDescriptor[]) {
-    columns =
-        columns || ([
-          {id: 'object', title: i18nString(UIStrings.object), disclosure: true, sortable: true},
-          {id: 'distance', title: i18nString(UIStrings.distance), width: '70px', sortable: true, fixedWidth: true},
-          {
-            id: 'shallowSize',
-            title: i18nString(UIStrings.shallowSize),
-            width: '110px',
-            sortable: true,
-            fixedWidth: true,
-          },
-          {
-            id: 'retainedSize',
-            title: i18nString(UIStrings.retainedSize),
-            width: '110px',
-            sortable: true,
-            fixedWidth: true,
-            sort: DataGrid.DataGrid.Order.Descending,
-          },
-        ] as DataGrid.DataGrid.ColumnDescriptor[]);
-    const dataGridParameters = ({displayName, columns} as DataGrid.DataGrid.Parameters);
-    super(heapProfilerModel, dataDisplayDelegate, dataGridParameters);
+    const defaultColumns: DataGrid.DataGrid.ColumnDescriptor[] = [
+      {id: 'object', title: i18nString(UIStrings.object), disclosure: true, sortable: true},
+      {id: 'distance', title: i18nString(UIStrings.distance), width: '70px', sortable: true, fixedWidth: true},
+      {
+        id: 'shallowSize',
+        title: i18nString(UIStrings.shallowSize),
+        width: '110px',
+        sortable: true,
+        fixedWidth: true,
+      },
+      {
+        id: 'retainedSize',
+        title: i18nString(UIStrings.retainedSize),
+        width: '110px',
+        sortable: true,
+        fixedWidth: true,
+        sort: DataGrid.DataGrid.Order.Descending,
+      },
+    ];
+    columns = columns || defaultColumns;
+    super(heapProfilerModel, dataDisplayDelegate, {displayName, columns});
   }
 
   override async setDataSource(snapshot: HeapSnapshotProxy, nodeIndex: number, nodeId?: number): Promise<void> {
@@ -671,7 +670,7 @@ export class HeapSnapshotRetainmentDataGrid extends HeapSnapshotContainmentDataG
   resetRetainersButton: UI.Toolbar.ToolbarButton|undefined;
   constructor(
       heapProfilerModel: SDK.HeapProfilerModel.HeapProfilerModel|null, dataDisplayDelegate: DataDisplayDelegate) {
-    const columns = ([
+    const columns: DataGrid.DataGrid.ColumnDescriptor[] = [
       {id: 'object', title: i18nString(UIStrings.object), disclosure: true, sortable: true},
       {
         id: 'distance',
@@ -683,7 +682,7 @@ export class HeapSnapshotRetainmentDataGrid extends HeapSnapshotContainmentDataG
       },
       {id: 'shallowSize', title: i18nString(UIStrings.shallowSize), width: '110px', sortable: true, fixedWidth: true},
       {id: 'retainedSize', title: i18nString(UIStrings.retainedSize), width: '110px', sortable: true, fixedWidth: true},
-    ] as DataGrid.DataGrid.ColumnDescriptor[]);
+    ];
     super(heapProfilerModel, dataDisplayDelegate, i18nString(UIStrings.heapSnapshotRetainment), columns);
   }
 
@@ -751,11 +750,19 @@ export class HeapSnapshotConstructorsDataGrid extends HeapSnapshotViewportDataGr
   filterInProgress?: HeapSnapshotModel.HeapSnapshotModel.NodeFilter|null;
 
   constructor(
-      heapProfilerModel: SDK.HeapProfilerModel.HeapProfilerModel|null, dataDisplayDelegate: DataDisplayDelegate) {
-    const columns = ([
+      heapProfilerModel: SDK.HeapProfilerModel.HeapProfilerModel|null,
+      dataDisplayDelegate: DataDisplayDelegate,
+  ) {
+    const columns: DataGrid.DataGrid.ColumnDescriptor[] = [
       {id: 'object', title: i18nString(UIStrings.constructorString), disclosure: true, sortable: true},
       {id: 'distance', title: i18nString(UIStrings.distance), width: '70px', sortable: true, fixedWidth: true},
-      {id: 'shallowSize', title: i18nString(UIStrings.shallowSize), width: '110px', sortable: true, fixedWidth: true},
+      {
+        id: 'shallowSize',
+        title: i18nString(UIStrings.shallowSize),
+        width: '110px',
+        sortable: true,
+        fixedWidth: true,
+      },
       {
         id: 'retainedSize',
         title: i18nString(UIStrings.retainedSize),
@@ -764,7 +771,7 @@ export class HeapSnapshotConstructorsDataGrid extends HeapSnapshotViewportDataGr
         sortable: true,
         fixedWidth: true,
       },
-    ] as DataGrid.DataGrid.ColumnDescriptor[]);
+    ];
     super(
         heapProfilerModel, dataDisplayDelegate,
         ({displayName: i18nString(UIStrings.heapSnapshotConstructors).toString(), columns} as
@@ -845,7 +852,7 @@ export class HeapSnapshotConstructorsDataGrid extends HeapSnapshotViewportDataGr
 
   aggregatesReceived(
       nodeFilter: HeapSnapshotModel.HeapSnapshotModel.NodeFilter,
-      aggregates: Record<string, HeapSnapshotModel.HeapSnapshotModel.Aggregate>,
+      aggregates: Record<string, HeapSnapshotModel.HeapSnapshotModel.AggregatedInfo>,
       ): void {
     this.filterInProgress = null;
     if (this.nextRequestedFilter && this.snapshot) {
@@ -904,7 +911,7 @@ export class HeapSnapshotDiffDataGrid extends HeapSnapshotViewportDataGrid {
 
   constructor(
       heapProfilerModel: SDK.HeapProfilerModel.HeapProfilerModel|null, dataDisplayDelegate: DataDisplayDelegate) {
-    const columns = ([
+    const columns: DataGrid.DataGrid.ColumnDescriptor[] = [
       {id: 'object', title: i18nString(UIStrings.constructorString), disclosure: true, sortable: true},
       {id: 'addedCount', title: i18nString(UIStrings.New), width: '75px', sortable: true, fixedWidth: true},
       {id: 'removedCount', title: i18nString(UIStrings.Deleted), width: '75px', sortable: true, fixedWidth: true},
@@ -919,7 +926,7 @@ export class HeapSnapshotDiffDataGrid extends HeapSnapshotViewportDataGrid {
       },
       {id: 'removedSize', title: i18nString(UIStrings.freedSize), width: '75px', sortable: true, fixedWidth: true},
       {id: 'sizeDelta', title: i18nString(UIStrings.sizeDelta), width: '75px', sortable: true, fixedWidth: true},
-    ] as DataGrid.DataGrid.ColumnDescriptor[]);
+    ];
     super(
         heapProfilerModel, dataDisplayDelegate,
         ({displayName: i18nString(UIStrings.heapSnapshotDiff).toString(), columns} as DataGrid.DataGrid.Parameters));
@@ -991,7 +998,7 @@ export class AllocationDataGrid extends HeapSnapshotViewportDataGrid {
 
   constructor(
       heapProfilerModel: SDK.HeapProfilerModel.HeapProfilerModel|null, dataDisplayDelegate: DataDisplayDelegate) {
-    const columns = ([
+    const columns: DataGrid.DataGrid.ColumnDescriptor[] = [
       {id: 'liveCount', title: i18nString(UIStrings.liveCount), width: '75px', sortable: true, fixedWidth: true},
       {id: 'count', title: i18nString(UIStrings.count), width: '65px', sortable: true, fixedWidth: true},
       {id: 'liveSize', title: i18nString(UIStrings.liveSize), width: '75px', sortable: true, fixedWidth: true},
@@ -1004,7 +1011,7 @@ export class AllocationDataGrid extends HeapSnapshotViewportDataGrid {
         sort: DataGrid.DataGrid.Order.Descending,
       },
       {id: 'name', title: i18nString(UIStrings.function), disclosure: true, sortable: true},
-    ] as DataGrid.DataGrid.ColumnDescriptor[]);
+    ];
     super(
         heapProfilerModel, dataDisplayDelegate,
         ({displayName: i18nString(UIStrings.allocation).toString(), columns} as DataGrid.DataGrid.Parameters));

package/front_end/panels/profiler/HeapSnapshotGridNodes.ts

@@ -1120,7 +1120,7 @@ export class HeapSnapshotConstructorNode extends HeapSnapshotGridNode {
 
   constructor(
       dataGrid: HeapSnapshotConstructorsDataGrid, classKey: string,
-      aggregate: HeapSnapshotModel.HeapSnapshotModel.Aggregate,
+      aggregate: HeapSnapshotModel.HeapSnapshotModel.AggregatedInfo,
       nodeFilter: HeapSnapshotModel.HeapSnapshotModel.NodeFilter) {
     super(dataGrid, aggregate.count > 0);
     this.nameInternal = aggregate.name;

package/front_end/panels/profiler/HeapSnapshotProxy.ts

@@ -290,7 +290,7 @@ export class HeapSnapshotProxy extends HeapSnapshotProxyObject {
   }
 
   aggregatesWithFilter(filter: HeapSnapshotModel.HeapSnapshotModel.NodeFilter):
-      Promise<Record<string, HeapSnapshotModel.HeapSnapshotModel.Aggregate>> {
+      Promise<Record<string, HeapSnapshotModel.HeapSnapshotModel.AggregatedInfo>> {
     return this.callMethodPromise('aggregatesWithFilter', filter);
   }
 

package/front_end/panels/profiler/HeapSnapshotView.ts

@@ -964,8 +964,6 @@ export class HeapSnapshotView extends UI.View.SimpleView implements DataDisplayD
     }
     let objectPopoverHelper: ObjectUI.ObjectPopoverHelper.ObjectPopoverHelper|null;
     return {
-      // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration)
-      // @ts-expect-error
       box: span.boxInWindow(),
       show: async (popover: UI.GlassPane.GlassPane) => {
         if (!heapProfilerModel) {
@@ -1364,7 +1362,7 @@ export class HeapSnapshotProfileType extends
       return;
     }
 
-    let profile: HeapProfileHeader = new HeapProfileHeader(heapProfilerModel, this);
+    let profile = new HeapProfileHeader(heapProfilerModel, this);
     this.setProfileBeingRecorded(profile);
     this.addProfile(profile);
     profile.updateStatus(i18nString(UIStrings.snapshotting));
@@ -1649,33 +1647,29 @@ export interface TrackingHeapSnapshotProfileTypeEventTypes {
 
 export class HeapProfileHeader extends ProfileHeader {
   readonly heapProfilerModelInternal: SDK.HeapProfilerModel.HeapProfilerModel|null;
-  maxJSObjectId: number;
-  workerProxy: HeapSnapshotWorkerProxy|null;
-  receiver: Common.StringOutputStream.OutputStream|null;
-  snapshotProxy: HeapSnapshotProxy|null;
+  maxJSObjectId = -1;
+  workerProxy: HeapSnapshotWorkerProxy|null = null;
+  receiver: Common.StringOutputStream.OutputStream|null = null;
+  snapshotProxy: HeapSnapshotProxy|null = null;
   readonly loadPromise: Promise<HeapSnapshotProxy>;
   fulfillLoad: (value: HeapSnapshotProxy|PromiseLike<HeapSnapshotProxy>) => void;
-  totalNumberOfChunks: number;
-  bufferedWriter: Bindings.TempFile.TempFile|null;
-  onTempFileReady: (() => void)|null;
+  totalNumberOfChunks = 0;
+  bufferedWriter: Bindings.TempFile.TempFile|null = null;
+  onTempFileReady: (() => void)|null = null;
   failedToCreateTempFile?: boolean;
   wasDisposed?: boolean;
   fileName?: Platform.DevToolsPath.RawPathString;
 
   constructor(
-      heapProfilerModel: SDK.HeapProfilerModel.HeapProfilerModel|null, type: HeapSnapshotProfileType, title?: string) {
+      heapProfilerModel: SDK.HeapProfilerModel.HeapProfilerModel|null,
+      type: HeapSnapshotProfileType,
+      title?: string,
+  ) {
     super(type, title || i18nString(UIStrings.snapshotD, {PH1: type.nextProfileUid()}));
     this.heapProfilerModelInternal = heapProfilerModel;
-    this.maxJSObjectId = -1;
-    this.workerProxy = null;
-    this.receiver = null;
-    this.snapshotProxy = null;
     const {promise, resolve} = Promise.withResolvers<HeapSnapshotProxy>();
     this.loadPromise = promise;
     this.fulfillLoad = resolve;
-    this.totalNumberOfChunks = 0;
-    this.bufferedWriter = null;
-    this.onTempFileReady = null;
   }
 
   heapProfilerModel(): SDK.HeapProfilerModel.HeapProfilerModel|null {

package/front_end/panels/profiler/LiveHeapProfileView.ts

@@ -103,15 +103,14 @@ export class LiveHeapProfileView extends UI.Widget.VBox {
   }
 
   createDataGrid(): DataGrid.SortableDataGrid.SortableDataGrid<GridNode> {
-    const defaultColumnConfig: DataGrid.DataGrid.ColumnDescriptor = {
-      id: '',
+    const defaultColumnConfig = {
       title: Common.UIString.LocalizedEmptyString,
       fixedWidth: true,
       sortable: true,
       align: DataGrid.DataGrid.Align.RIGHT,
       sort: DataGrid.DataGrid.Order.Descending,
     };
-    const columns = [
+    const columns: Array<{tooltip: Common.UIString.LocalizedString}&DataGrid.DataGrid.ColumnDescriptor> = [
       {
         ...defaultColumnConfig,
         id: 'size',
@@ -140,7 +139,7 @@ export class LiveHeapProfileView extends UI.Widget.VBox {
         sortable: true,
         tooltip: i18nString(UIStrings.urlOfTheScriptSource),
       },
-    ] as Array<{tooltip: Common.UIString.LocalizedString}&DataGrid.DataGrid.ColumnDescriptor>;
+    ];
     const dataGrid = new DataGrid.SortableDataGrid.SortableDataGrid({
       displayName: i18nString(UIStrings.heapProfile),
       columns,

package/front_end/panels/profiler/ProfileHeader.ts

@@ -11,17 +11,14 @@ export class ProfileHeader extends Common.ObjectWrapper.ObjectWrapper<EventTypes
   readonly #profileType: ProfileType;
   title: string;
   uid: number;
-  #fromFile: boolean;
-  tempFile: Bindings.TempFile.TempFile|null;
+  #fromFile = false;
+  tempFile: Bindings.TempFile.TempFile|null = null;
 
   constructor(profileType: ProfileType, title: string) {
     super();
     this.#profileType = profileType;
     this.title = title;
     this.uid = profileType.incrementProfileUid();
-    this.#fromFile = false;
-
-    this.tempFile = null;
   }
 
   setTitle(title: string): void {
@@ -103,17 +100,14 @@ export interface EventTypes {
 export class ProfileType extends Common.ObjectWrapper.ObjectWrapper<ProfileEventTypes> {
   readonly #id: string;
   readonly #name: string;
-  profiles: ProfileHeader[];
-  #profileBeingRecorded: ProfileHeader|null;
-  #nextProfileUid: number;
+  profiles: ProfileHeader[] = [];
+  #profileBeingRecorded: ProfileHeader|null = null;
+  #nextProfileUid = 1;
 
   constructor(id: string, name: string) {
     super();
     this.#id = id;
     this.#name = name;
-    this.profiles = [];
-    this.#profileBeingRecorded = null;
-    this.#nextProfileUid = 1;
 
     if (!window.opener) {
       window.addEventListener('pagehide', this.clearTempStorage.bind(this), false);

package/front_end/panels/profiler/ProfileView.ts

@@ -138,7 +138,7 @@ export class ProfileView extends UI.View.SimpleView implements UI.SearchableView
     this.searchableViewInternal.setPlaceholder(i18nString(UIStrings.findByCostMsNameOrFile));
     this.searchableViewInternal.show(this.element);
 
-    const columns = ([] as DataGrid.DataGrid.ColumnDescriptor[]);
+    const columns: DataGrid.DataGrid.ColumnDescriptor[] = [];
     columns.push({
       id: 'self',
       title: this.columnHeader('self'),

package/front_end/panels/recorder/RecorderController.ts

@@ -151,6 +151,7 @@ const UIStrings = {
 } as const;
 const str_ = i18n.i18n.registerUIStrings('panels/recorder/RecorderController.ts', UIStrings);
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
+const {widget} = UI.Widget;
 
 const GET_EXTENSIONS_MENU_ITEM = 'get-extensions-link';
 const GET_EXTENSIONS_URL = 'https://goo.gle/recorder-extension-list' as Platform.DevToolsPath.UrlString;
@@ -1203,7 +1204,7 @@ export class RecorderController extends LitElement {
     // clang-format off
     return html`
       <devtools-widget
-        .widgetConfig=${UI.Widget.widgetConfig(Components.RecordingListView.RecordingListView, {
+        ${widget(Components.RecordingListView.RecordingListView, {
           recordings: recordings.map(recording => ({
             storageName: recording.storageName,
             name: recording.flow.title,
@@ -1244,7 +1245,7 @@ export class RecorderController extends LitElement {
     return html`
       <devtools-widget
           class="recording-view"
-          .widgetConfig=${UI.Widget.widgetConfig(Components.RecordingView.RecordingView, {
+          ${widget(Components.RecordingView.RecordingView, {
             recording: this.currentRecording?.flow ?? {title: '', steps: []},
             replayState: this.#replayState,
             isRecording: this.isRecording,
@@ -1291,7 +1292,7 @@ export class RecorderController extends LitElement {
     return html`
       <devtools-widget
         class="recording-view"
-        .widgetConfig=${UI.Widget.widgetConfig(Components.CreateRecordingView.CreateRecordingView, {
+        ${widget(Components.CreateRecordingView.CreateRecordingView, {
           recorderSettings: this.#recorderSettings,
           onRecordingStarted: this.#onRecordingStarted.bind(this),
           onRecordingCancelled: this.onRecordingCancelled.bind(this),

package/front_end/panels/recorder/components/CreateRecordingView.ts

@@ -101,6 +101,7 @@ const str_ = i18n.i18n.registerUIStrings(
     UIStrings,
 );
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
+const {widget} = UI.Widget;
 
 export interface ViewInput {
   name: string;
@@ -269,7 +270,7 @@ export const DEFAULT_VIEW = (input: ViewInput, output: ViewOutput, target: HTMLE
         <div class="controls">
           <devtools-widget
             class="control-button"
-            .widgetConfig=${UI.Widget.widgetConfig(ControlButton, {
+            ${widget(ControlButton, {
               label: i18nString(UIStrings.startRecording),
               shape: 'circle',
               onClick: onRecordingStarted,

package/front_end/panels/recorder/components/RecordingView.ts

@@ -597,7 +597,7 @@ function renderSections(input: ViewInput): Lit.LitTemplate {
                     return html`
                       <devtools-widget
                       @copystep=${input.onCopyStep}
-                      .widgetConfig=${UI.Widget.widgetConfig(StepView, {
+                      ${widget(StepView, {
                         step,
                         state: input.getStepState(step),
                         error: input.currentStep === step ? (input.currentError ?? undefined) : undefined,
@@ -812,7 +812,7 @@ export const DEFAULT_VIEW = (input: ViewInput, output: ViewOutput, target: HTMLE
           <div class="controls">
             <devtools-widget
               class="control-button"
-              .widgetConfig=${UI.Widget.widgetConfig(ControlButton, {
+              ${widget(ControlButton, {
                 label: footerButtonTitle,
                 shape: 'square',
                 disabled: input.recordingTogglingInProgress,

package/front_end/panels/recorder/models/RecordingPlayer.ts

@@ -2,6 +2,9 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+// Clang-formatter and EsLint have a mismatch due to the naming of `puppeteer-replay`
+/* eslint-disable import/order */
+
 import * as Common from '../../../core/common/common.js';
 import type * as Platform from '../../../core/platform/platform.js';
 import * as SDK from '../../../core/sdk/sdk.js';

package/front_end/panels/security/SecurityPanel.ts

@@ -29,7 +29,7 @@ import {
 } from './SecurityModel.js';
 import {SecurityPanelSidebar} from './SecurityPanelSidebar.js';
 
-const {widgetConfig} = UI.Widget;
+const {widget, widgetRef} = UI.Widget;
 
 const UIStrings = {
   /**
@@ -552,8 +552,8 @@ const DEFAULT_VIEW: View = (input: ViewInput, output: ViewOutput, target: HTMLEl
       ${UI.Widget.widgetRef(UI.SplitWidget.SplitWidget, e => {output.splitWidget = e;})}>
       <devtools-widget
         slot="sidebar"
-        .widgetConfig=${widgetConfig(SecurityPanelSidebar)}
-        ${UI.Widget.widgetRef(SecurityPanelSidebar, e => {output.sidebar = e;})}>
+        ${widget(SecurityPanelSidebar)}
+        ${widgetRef(SecurityPanelSidebar, e => {output.sidebar = e;})}>
       </devtools-widget>
   </devtools-split-view>`,
     target);