chrome-devtools-frontend 1.0.1601661 → 1.0.1602543

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (119) hide show
  1. package/.agents/skills/version-control/SKILL.md +71 -0
  2. package/AUTHORS +1 -0
  3. package/front_end/core/common/Settings.ts +1 -871
  4. package/front_end/core/common/VersionController.ts +880 -0
  5. package/front_end/core/common/common.ts +2 -0
  6. package/front_end/core/host/InspectorFrontendHostStub.ts +0 -5
  7. package/front_end/core/platform/HostRuntime.ts +9 -3
  8. package/front_end/core/protocol_client/InspectorBackend.ts +8 -0
  9. package/front_end/core/root/Runtime.ts +5 -8
  10. package/front_end/core/sdk/DOMModel.ts +5 -4
  11. package/front_end/core/sdk/Target.ts +5 -0
  12. package/front_end/core/sdk/WebMCPModel.ts +98 -0
  13. package/front_end/core/sdk/sdk.ts +2 -0
  14. package/front_end/entrypoints/heap_snapshot_worker/HeapSnapshot.ts +13 -19
  15. package/front_end/entrypoints/inspector_main/InspectorMain.ts +1 -1
  16. package/front_end/entrypoints/main/GlobalAiButton.ts +1 -1
  17. package/front_end/generated/InspectorBackendCommands.ts +6 -5
  18. package/front_end/generated/protocol.ts +36 -3
  19. package/front_end/models/ai_assistance/AiConversation.ts +3 -3
  20. package/front_end/models/ai_assistance/agents/AccessibilityAgent.ts +217 -9
  21. package/front_end/models/ai_assistance/agents/AiAgent.ts +14 -1
  22. package/front_end/models/ai_assistance/agents/ContextSelectionAgent.ts +19 -4
  23. package/front_end/models/ai_assistance/agents/NetworkAgent.ts +7 -1
  24. package/front_end/models/ai_assistance/agents/PerformanceAgent.ts +14 -2
  25. package/front_end/models/ai_assistance/agents/StylingAgent.ts +0 -23
  26. package/front_end/models/heap_snapshot_model/HeapSnapshotModel.ts +7 -7
  27. package/front_end/models/javascript_metadata/NativeFunctions.js +4 -0
  28. package/front_end/models/lighthouse/RunTypes.ts +3 -1
  29. package/front_end/models/live-metrics/LiveMetrics.ts +51 -31
  30. package/front_end/panels/accessibility/ARIAAttributesView.ts +2 -2
  31. package/front_end/panels/ai_assistance/AiAssistancePanel.ts +9 -2
  32. package/front_end/panels/ai_assistance/components/ChatInput.ts +3 -2
  33. package/front_end/panels/ai_assistance/components/ChatMessage.ts +84 -27
  34. package/front_end/panels/ai_assistance/components/chatMessage.css +31 -2
  35. package/front_end/panels/application/AppManifestView.ts +2 -2
  36. package/front_end/panels/application/BackgroundServiceView.ts +9 -9
  37. package/front_end/panels/application/FrameDetailsView.ts +4 -13
  38. package/front_end/panels/application/IndexedDBViews.ts +1 -1
  39. package/front_end/panels/application/KeyValueStorageItemsView.ts +4 -4
  40. package/front_end/panels/application/ServiceWorkerCacheViews.ts +3 -3
  41. package/front_end/panels/application/components/PermissionsPolicySection.ts +1 -1
  42. package/front_end/panels/application/components/permissionsPolicySection.css +54 -52
  43. package/front_end/panels/application/frameDetailsReportView.css +13 -1
  44. package/front_end/panels/common/AiCodeCompletionSummaryToolbar.ts +2 -1
  45. package/front_end/panels/console_counters/WarningErrorCounter.ts +7 -14
  46. package/front_end/panels/elements/CSSValueTraceView.ts +9 -1
  47. package/front_end/panels/elements/NodeStackTraceWidget.ts +2 -1
  48. package/front_end/panels/elements/PropertiesWidget.ts +14 -13
  49. package/front_end/panels/elements/PropertyRenderer.ts +10 -9
  50. package/front_end/panels/elements/StandaloneStylesContainer.ts +15 -2
  51. package/front_end/panels/elements/StylePropertyTreeElement.ts +22 -1
  52. package/front_end/panels/elements/StylesSidebarPane.ts +34 -25
  53. package/front_end/panels/elements/stylePropertiesTreeOutline.css +5 -0
  54. package/front_end/panels/issues/AffectedSelectivePermissionsInterventionView.ts +2 -2
  55. package/front_end/panels/lighthouse/LighthouseController.ts +4 -1
  56. package/front_end/panels/media/EventDisplayTable.ts +3 -2
  57. package/front_end/panels/network/EventSourceMessagesView.ts +2 -2
  58. package/front_end/panels/network/RequestPayloadView.ts +2 -2
  59. package/front_end/panels/network/ResourceChunkView.ts +1 -1
  60. package/front_end/panels/profiler/HeapDetachedElementsView.ts +9 -4
  61. package/front_end/panels/profiler/HeapProfileView.ts +8 -4
  62. package/front_end/panels/profiler/HeapSnapshotDataGrids.ts +40 -33
  63. package/front_end/panels/profiler/HeapSnapshotGridNodes.ts +1 -1
  64. package/front_end/panels/profiler/HeapSnapshotProxy.ts +1 -1
  65. package/front_end/panels/profiler/HeapSnapshotView.ts +12 -18
  66. package/front_end/panels/profiler/LiveHeapProfileView.ts +3 -4
  67. package/front_end/panels/profiler/ProfileHeader.ts +5 -11
  68. package/front_end/panels/profiler/ProfileView.ts +1 -1
  69. package/front_end/panels/recorder/RecorderController.ts +4 -3
  70. package/front_end/panels/recorder/components/CreateRecordingView.ts +2 -1
  71. package/front_end/panels/recorder/components/RecordingView.ts +2 -2
  72. package/front_end/panels/recorder/models/RecordingPlayer.ts +3 -0
  73. package/front_end/panels/security/SecurityPanel.ts +3 -3
  74. package/front_end/panels/sensors/SensorsView.ts +149 -125
  75. package/front_end/panels/timeline/EventsTimelineTreeView.ts +2 -2
  76. package/front_end/panels/timeline/TimelineDetailsView.ts +6 -37
  77. package/front_end/panels/timeline/TimelineTreeView.ts +19 -17
  78. package/front_end/panels/timeline/TimelineUIUtils.ts +0 -118
  79. package/front_end/panels/timeline/components/IgnoreListSetting.ts +1 -1
  80. package/front_end/panels/timeline/components/SidebarInsightsTab.ts +2 -2
  81. package/front_end/panels/timeline/components/TimelineRangeSummaryView.ts +162 -9
  82. package/front_end/panels/timeline/components/timelineRangeSummaryView.css +22 -8
  83. package/front_end/panels/webauthn/WebauthnPane.ts +52 -0
  84. package/front_end/panels/whats_new/ReleaseNoteText.ts +10 -10
  85. package/front_end/panels/whats_new/resources/WNDT.md +6 -6
  86. package/front_end/third_party/chromium/README.chromium +1 -1
  87. package/front_end/third_party/puppeteer/README.chromium +2 -2
  88. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/node/ChromeLauncher.d.ts.map +1 -1
  89. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/node/ChromeLauncher.js +4 -0
  90. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/node/ChromeLauncher.js.map +1 -1
  91. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/revisions.d.ts +2 -2
  92. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/revisions.js +2 -2
  93. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/revisions.js.map +1 -1
  94. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/util/version.d.ts +1 -1
  95. package/front_end/third_party/puppeteer/package/lib/cjs/puppeteer/util/version.js +1 -1
  96. package/front_end/third_party/puppeteer/package/lib/es5-iife/puppeteer-core-browser.js +3 -3
  97. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/node/ChromeLauncher.d.ts.map +1 -1
  98. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/node/ChromeLauncher.js +4 -0
  99. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/node/ChromeLauncher.js.map +1 -1
  100. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/revisions.d.ts +2 -2
  101. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/revisions.js +2 -2
  102. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/revisions.js.map +1 -1
  103. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/util/version.d.ts +1 -1
  104. package/front_end/third_party/puppeteer/package/lib/esm/puppeteer/util/version.js +1 -1
  105. package/front_end/third_party/puppeteer/package/package.json +1 -1
  106. package/front_end/third_party/puppeteer/package/src/node/ChromeLauncher.ts +8 -0
  107. package/front_end/third_party/puppeteer/package/src/revisions.ts +2 -2
  108. package/front_end/third_party/puppeteer/package/src/util/version.ts +1 -1
  109. package/front_end/ui/legacy/Toolbar.ts +25 -3
  110. package/front_end/ui/legacy/Treeoutline.ts +7 -3
  111. package/front_end/ui/legacy/UIUtils.ts +13 -11
  112. package/front_end/ui/legacy/Widget.ts +40 -40
  113. package/front_end/ui/legacy/components/data_grid/DataGrid.ts +1 -1
  114. package/front_end/ui/legacy/components/data_grid/SortableDataGrid.ts +2 -2
  115. package/front_end/ui/legacy/components/object_ui/ObjectPropertiesSection.ts +39 -23
  116. package/front_end/ui/legacy/components/perf_ui/GCActionDelegate.ts +20 -4
  117. package/front_end/ui/legacy/treeoutline.css +4 -0
  118. package/front_end/ui/visual_logging/KnownContextValues.ts +2 -0
  119. package/package.json +1 -1
@@ -888,8 +888,12 @@ export class AiAssistancePanel extends UI.Panel.Panel {
888
888
  return await TimelinePanel.TimelinePanel.TimelinePanel.executeRecordAndReload();
889
889
  }
890
890
 
891
- async #handleLighthouseRun(): Promise<LHModel.ReporterTypes.ReportJSON|null> {
892
- return await LighthousePanel.LighthousePanel.LighthousePanel.executeLighthouseRecording({isAIControlled: true});
891
+ async #handleLighthouseRun(overrides?: LHModel.RunTypes.RunOverrides):
892
+ Promise<LHModel.ReporterTypes.ReportJSON|null> {
893
+ return await LighthousePanel.LighthousePanel.LighthousePanel.executeLighthouseRecording({
894
+ isAIControlled: true,
895
+ ...overrides,
896
+ });
893
897
  }
894
898
 
895
899
  #getDefaultConversationType(): AiAssistanceModel.AiHistoryStorage.ConversationType|undefined {
@@ -988,6 +992,7 @@ export class AiAssistancePanel extends UI.Panel.Panel {
988
992
  performanceRecordAndReload: this.#handlePerformanceRecordAndReload.bind(this),
989
993
  onInspectElement: this.#handleInspectElement.bind(this),
990
994
  networkTimeCalculator: NetworkPanel.NetworkPanel.NetworkPanel.instance().networkLogView.timeCalculator(),
995
+ lighthouseRecording: this.#handleLighthouseRun.bind(this),
991
996
  });
992
997
  }
993
998
  }
@@ -1026,6 +1031,7 @@ export class AiAssistancePanel extends UI.Panel.Panel {
1026
1031
  performanceRecordAndReload: this.#handlePerformanceRecordAndReload.bind(this),
1027
1032
  onInspectElement: this.#handleInspectElement.bind(this),
1028
1033
  networkTimeCalculator: NetworkPanel.NetworkPanel.NetworkPanel.instance().networkLogView.timeCalculator(),
1034
+ lighthouseRecording: this.#handleLighthouseRun.bind(this),
1029
1035
  });
1030
1036
  this.#updateConversationState(conversation);
1031
1037
  this.#conversation?.setContext(context);
@@ -1501,6 +1507,7 @@ export class AiAssistancePanel extends UI.Panel.Panel {
1501
1507
  performanceRecordAndReload: this.#handlePerformanceRecordAndReload.bind(this),
1502
1508
  onInspectElement: this.#handleInspectElement.bind(this),
1503
1509
  networkTimeCalculator: NetworkPanel.NetworkPanel.NetworkPanel.instance().networkLogView.timeCalculator(),
1510
+ lighthouseRecording: this.#handleLighthouseRun.bind(this),
1504
1511
  });
1505
1512
  }
1506
1513
  this.#updateConversationState(conversation);
@@ -22,6 +22,7 @@ import * as VisualLogging from '../../../ui/visual_logging/visual_logging.js';
22
22
  import chatInputStyles from './chatInput.css.js';
23
23
 
24
24
  const {html, Directives: {createRef, ref}} = Lit;
25
+ const {widget} = UI.Widget;
25
26
 
26
27
  const UIStrings = {
27
28
  /**
@@ -332,7 +333,7 @@ export const DEFAULT_VIEW = (input: ViewInput, _output: ViewOutput, target: HTML
332
333
  html`
333
334
  <devtools-widget
334
335
  class="title"
335
- .widgetConfig=${UI.Widget.widgetConfig(PanelsCommon.DOMLinkifier.DOMNodeLink, {
336
+ ${widget(PanelsCommon.DOMLinkifier.DOMNodeLink, {
336
337
  node: input.context.getItem(),
337
338
  options: {
338
339
  disabled: !input.isContextSelected,
@@ -352,7 +353,7 @@ export const DEFAULT_VIEW = (input: ViewInput, _output: ViewOutput, target: HTML
352
353
  input.context instanceof AiAssistanceModel.PerformanceAgent.PerformanceTraceContext ?
353
354
  html`<devtools-icon class="icon" name="performance" title="Performance"></devtools-icon>` :
354
355
  Lit.nothing}
355
- <span
356
+ <span
356
357
  role="button"
357
358
  class="title"
358
359
  tabindex="0"
@@ -14,9 +14,10 @@ import * as SDK from '../../../core/sdk/sdk.js';
14
14
  import type * as Protocol from '../../../generated/protocol.js';
15
15
  import type {
16
16
  AiWidget, ComputedStyleAiWidget, CoreVitalsAiWidget, DomTreeAiWidget, LcpBreakdownAiWidget, PerformanceTraceAiWidget,
17
- StylePropertiesAiWidget} from '../../../models/ai_assistance/agents/AiAgent.js';
17
+ StylePropertiesAiWidget, TimelineRangeSummaryAiWidget} from '../../../models/ai_assistance/agents/AiAgent.js';
18
18
  import * as AiAssistanceModel from '../../../models/ai_assistance/ai_assistance.js';
19
19
  import * as ComputedStyle from '../../../models/computed_style/computed_style.js';
20
+ import * as Trace from '../../../models/trace/trace.js';
20
21
  import * as Marked from '../../../third_party/marked/marked.js';
21
22
  import * as Buttons from '../../../ui/components/buttons/buttons.js';
22
23
  import * as Input from '../../../ui/components/input/input.js';
@@ -656,6 +657,7 @@ interface WidgetMakerResponse {
656
657
  renderedWidget: Lit.LitTemplate|null;
657
658
  revealable: unknown;
658
659
  customRevealTitle?: Platform.UIString.LocalizedString;
660
+ widgetName?: string;
659
661
  }
660
662
 
661
663
  const nodeCache = new Map<Protocol.DOM.BackendNodeId, SDK.DOMModel.DOMNode>();
@@ -736,15 +738,13 @@ async function makeLcpBreakdownWidget(widgetData: LcpBreakdownAiWidget): Promise
736
738
  return null;
737
739
  }
738
740
 
739
- const widgetConfig = UI.Widget.widgetConfig(TimelineInsights.LCPBreakdown.LCPBreakdown, {
740
- model: insight,
741
- minimal: true,
742
- });
743
-
744
741
  // clang-format off
745
742
  const renderedWidget = html`<devtools-widget
746
743
  class="lcp-breakdown-widget"
747
- .widgetConfig=${widgetConfig}></devtools-widget>`;
744
+ ${widget(TimelineInsights.LCPBreakdown.LCPBreakdown, {
745
+ model: insight,
746
+ minimal: true,
747
+ })}></devtools-widget>`;
748
748
  // clang-format on
749
749
 
750
750
  return {renderedWidget, revealable: new TimelineUtils.Helpers.RevealableInsight(insight)};
@@ -766,21 +766,36 @@ function renderWidgetResponse(response: WidgetMakerResponse|null): Lit.LitTempla
766
766
  'widget-and-revealer-container': true,
767
767
  'revealer-only': response.renderedWidget === null,
768
768
  });
769
+
770
+ const revealButton = html`
771
+ <devtools-button class="widget-reveal"
772
+ .iconName=${'tab-move'}
773
+ .variant=${Buttons.Button.Variant.TEXT}
774
+ @click=${onReveal}
775
+ >${response.customRevealTitle ?? lockedString(UIStringsNotTranslate.reveal)}</devtools-button>
776
+ `;
777
+
769
778
  // clang-format off
770
779
  return html`
771
780
  <div class=${classes}>
781
+ ${response.widgetName ? html`
782
+ <div class="widget-header">
783
+ <div class="widget-name">${response.widgetName}</div>
784
+ <div class="widget-reveal-container">
785
+ ${revealButton}
786
+ </div>
787
+ </div>
788
+ ` : Lit.nothing}
772
789
  ${response.renderedWidget ? html`
773
790
  <div class="widget-content-container">
774
791
  ${response.renderedWidget}
775
792
  </div>` : Lit.nothing
776
793
  }
777
- <div class="widget-reveal-container">
778
- <devtools-button class="widget-reveal"
779
- .iconName=${'tab-move'}
780
- .variant=${Buttons.Button.Variant.TEXT}
781
- @click=${onReveal}
782
- >${response.customRevealTitle ?? lockedString(UIStringsNotTranslate.reveal)}</devtools-button>
783
- </div>
794
+ ${!response.widgetName ? html`
795
+ <div class="widget-reveal-container">
796
+ ${revealButton}
797
+ </div>
798
+ ` : Lit.nothing}
784
799
  </div>
785
800
  `;
786
801
  // clang-format on
@@ -826,30 +841,29 @@ async function makeDomTreeWidget(widgetData: DomTreeAiWidget): Promise<WidgetMak
826
841
  return null;
827
842
  }
828
843
 
829
- const widgetConfig = UI.Widget.widgetConfig(Elements.ElementsTreeOutline.DOMTreeWidget, {
830
- maxTreeDepth: 2,
831
- enableContextMenu: false,
832
- showComments: false,
833
- showAIButton: false,
834
- disableEdits: true,
835
- expandRoot: true,
836
- rootDOMNode: root,
837
- visibleWidth: 400,
838
- wrap: true,
839
- });
840
-
841
844
  const networkRequest = widgetData.data.networkRequest;
842
845
 
843
846
  // clang-format off
844
847
  const renderedWidget = html`
845
848
  ${networkRequest ? renderNetworkRequestPreview(networkRequest) : Lit.nothing}
846
- <devtools-widget class="dom-tree-widget" .widgetConfig=${widgetConfig}></devtools-widget>
849
+ <devtools-widget class="dom-tree-widget" ${widget(Elements.ElementsTreeOutline.DOMTreeWidget, {
850
+ maxTreeDepth: 2,
851
+ enableContextMenu: false,
852
+ showComments: false,
853
+ showAIButton: false,
854
+ disableEdits: true,
855
+ expandRoot: true,
856
+ rootDOMNode: root,
857
+ visibleWidth: 400,
858
+ wrap: true,
859
+ })}></devtools-widget>
847
860
  `;
848
861
  // clang-format on
849
862
 
850
863
  return {
851
864
  renderedWidget,
852
865
  revealable: new SDK.DOMModel.DeferredDOMNode(root.domModel().target(), root.backendNodeId()),
866
+ widgetName: 'LCP element',
853
867
  };
854
868
  }
855
869
 
@@ -896,6 +910,9 @@ async function renderWidgets(
896
910
  case 'LCP_BREAKDOWN':
897
911
  response = await makeLcpBreakdownWidget(widgetData);
898
912
  break;
913
+ case 'TIMELINE_RANGE_SUMMARY':
914
+ response = await makeTimelineRangeSummaryWidget(widgetData);
915
+ break;
899
916
  default:
900
917
  Platform.assertNever(widgetData, 'Unknown AiWidget name');
901
918
  }
@@ -1322,3 +1339,43 @@ export class ChatMessage extends UI.Widget.Widget {
1322
1339
  void this.performUpdate();
1323
1340
  }
1324
1341
  }
1342
+
1343
+ async function makeTimelineRangeSummaryWidget(widgetData: TimelineRangeSummaryAiWidget):
1344
+ Promise<WidgetMakerResponse|null> {
1345
+ const {bounds, parsedTrace, track} = widgetData.data;
1346
+ let events: readonly Trace.Types.Events.Event[] = [];
1347
+ if (track === 'main') {
1348
+ const flameChartView = Timeline.TimelinePanel.TimelinePanel.instance().getFlameChart();
1349
+ const mainDataProvider = flameChartView.getMainDataProvider();
1350
+ const mainTrack =
1351
+ mainDataProvider.timelineData().groups.find((group: {name: string}) => group.name.startsWith('Main \u2014 '));
1352
+ if (mainTrack) {
1353
+ events = mainDataProvider.groupTreeEvents(mainTrack) ?? [];
1354
+ }
1355
+ }
1356
+ const eventsArray = Array.from(events);
1357
+ eventsArray.sort((a, b) => a.ts - b.ts);
1358
+
1359
+ const thirdPartyTree = new Timeline.ThirdPartyTreeView.ThirdPartyTreeViewWidget();
1360
+ const mapper = new Trace.EntityMapper.EntityMapper(parsedTrace);
1361
+ thirdPartyTree.setModelWithEvents(eventsArray, parsedTrace, mapper);
1362
+ thirdPartyTree.refreshTree(true);
1363
+
1364
+ // clang-format off
1365
+ const template = html`
1366
+ <devtools-widget
1367
+ ${widget(TimelineComponents.TimelineRangeSummaryView.TimelineRangeSummaryView, {
1368
+ data: {
1369
+ parsedTrace,
1370
+ events,
1371
+ startTime: Trace.Helpers.Timing.microToMilli(bounds.min),
1372
+ endTime: Trace.Helpers.Timing.microToMilli(bounds.max),
1373
+ thirdPartyTreeTemplate: html`<devtools-performance-third-party-tree-view
1374
+ .treeView=${thirdPartyTree}></devtools-performance-third-party-tree-view>`,
1375
+ } as TimelineComponents.TimelineRangeSummaryView.TimelineRangeSummaryViewData,
1376
+ })}
1377
+ ></devtools-widget>`;
1378
+ // clang-format on
1379
+
1380
+ return {renderedWidget: template, revealable: null};
1381
+ }
@@ -372,8 +372,25 @@
372
372
  gap: var(--sys-size-5);
373
373
  }
374
374
 
375
- .widget-and-revealer-container {
376
- width: 100%;
375
+
376
+ .widget-header {
377
+ display: flex;
378
+ justify-content: space-between;
379
+ align-items: center;
380
+ background: var(--sys-color-surface5);
381
+ padding: var(--sys-size-2) var(--sys-size-4);
382
+ border-top-left-radius: var(--sys-shape-corner-medium);
383
+ border-top-right-radius: var(--sys-shape-corner-medium);
384
+
385
+ .widget-name {
386
+ font: var(--sys-typescale-body3-regular);
387
+ }
388
+
389
+ .widget-reveal-container {
390
+ padding: 0;
391
+ background: none;
392
+ border-radius: 0;
393
+ }
377
394
  }
378
395
 
379
396
  .widget-reveal-container {
@@ -396,6 +413,18 @@
396
413
  background-color: var(--sys-color-surface3);
397
414
 
398
415
  --override-computed-style-property-white-space: normal;
416
+
417
+ /* When header is present, content follows it and shouldn't have top radii */
418
+ .widget-header+& {
419
+ border-top-left-radius: 0;
420
+ border-top-right-radius: 0;
421
+ }
422
+
423
+ /* When header is present, content is the last child and needs bottom radii */
424
+ .widget-header+&:last-child {
425
+ border-bottom-left-radius: var(--sys-shape-corner-medium);
426
+ border-bottom-right-radius: var(--sys-shape-corner-medium);
427
+ }
399
428
  }
400
429
 
401
430
  .network-request-preview {
@@ -1106,8 +1106,8 @@ export const DEFAULT_VIEW: View = (input, output, target) => {
1106
1106
  ${identityData && onCopyId ? renderIdentity(identityData, onCopyId, output) : nothing}
1107
1107
  ${presentationData ? renderPresentation(presentationData, output) : nothing}
1108
1108
  ${protocolHandlersData ? renderProtocolHandlers(protocolHandlersData, output) : nothing}
1109
- ${iconsData && onToggleIconMasked && maskedIcons ?
1110
- renderIcons(iconsData, maskedIcons, onToggleIconMasked, output) : nothing}
1109
+ ${iconsData && onToggleIconMasked ?
1110
+ renderIcons(iconsData, Boolean(maskedIcons), onToggleIconMasked, output) : nothing}
1111
1111
  ${windowControlsData && output ? renderWindowControlsSection(
1112
1112
  windowControlsData, selectedPlatform, onSelectOs, onToggleWcoToolbar, output) : nothing}
1113
1113
  ${shortcutsData ? renderShortcuts(shortcutsData) : nothing}
@@ -384,15 +384,15 @@ export class BackgroundServiceView extends UI.Widget.VBox {
384
384
  }
385
385
 
386
386
  private createDataGrid(): DataGrid.DataGrid.DataGridImpl<EventData> {
387
- const columns = ([
388
- {id: 'id', title: '#', weight: 1},
389
- {id: 'timestamp', title: i18nString(UIStrings.timestamp), weight: 7},
390
- {id: 'event-name', title: i18nString(UIStrings.event), weight: 8},
391
- {id: 'origin', title: i18nString(UIStrings.origin), weight: 8},
392
- {id: 'storage-key', title: i18nString(UIStrings.storageKey), weight: 8},
393
- {id: 'sw-scope', title: i18nString(UIStrings.swScope), weight: 4},
394
- {id: 'instance-id', title: i18nString(UIStrings.instanceId), weight: 8},
395
- ] as DataGrid.DataGrid.ColumnDescriptor[]);
387
+ const columns: DataGrid.DataGrid.ColumnDescriptor[] = [
388
+ {id: 'id', title: '#' as Common.UIString.LocalizedString, weight: 1, sortable: false},
389
+ {id: 'timestamp', title: i18nString(UIStrings.timestamp), weight: 7, sortable: false},
390
+ {id: 'event-name', title: i18nString(UIStrings.event), weight: 8, sortable: false},
391
+ {id: 'origin', title: i18nString(UIStrings.origin), weight: 8, sortable: false},
392
+ {id: 'storage-key', title: i18nString(UIStrings.storageKey), weight: 8, sortable: false},
393
+ {id: 'sw-scope', title: i18nString(UIStrings.swScope), weight: 4, sortable: false},
394
+ {id: 'instance-id', title: i18nString(UIStrings.instanceId), weight: 8, sortable: false},
395
+ ];
396
396
  const dataGrid = new DataGrid.DataGrid.DataGridImpl({
397
397
  displayName: i18nString(UIStrings.backgroundServices),
398
398
  columns,
@@ -268,7 +268,7 @@ export interface FrameDetailsReportViewData {
268
268
  adScriptAncestry: Protocol.Network.AdAncestry|null;
269
269
  }
270
270
 
271
- interface FrameDetailsViewInput {
271
+ export interface FrameDetailsViewInput {
272
272
  frame: SDK.ResourceTreeModel.ResourceTreeFrame;
273
273
  target: SDK.Target.Target|null;
274
274
  creationStackTrace: StackTrace.StackTrace.StackTrace|null;
@@ -282,9 +282,9 @@ interface FrameDetailsViewInput {
282
282
  onRevealInSources: () => void;
283
283
  }
284
284
 
285
- type View = (input: FrameDetailsViewInput, output: undefined, target: HTMLElement) => void;
285
+ export type View = (input: FrameDetailsViewInput, output: undefined, target: HTMLElement) => void;
286
286
 
287
- const DEFAULT_VIEW: View = (input, _output, target) => {
287
+ export const DEFAULT_VIEW: View = (input, _output, target) => {
288
288
  if (!input.frame) {
289
289
  return;
290
290
  }
@@ -892,16 +892,7 @@ export class FrameDetailsReportView extends UI.Widget.Widget {
892
892
  const result = await this.#frame?.parentFrame()?.getAdScriptAncestry(this.#frame?.id);
893
893
  if (result && result.ancestryChain.length > 0) {
894
894
  this.#adScriptAncestry = result;
895
-
896
- // Obtain the Target associated with the first ad script, because in most scenarios all
897
- // scripts share the same debuggerId. However, discrepancies might arise when content scripts
898
- // from browser extensions are involved. We will monitor the debugging experiences and revisit
899
- // this approach if it proves problematic.
900
- const firstScript = this.#adScriptAncestry.ancestryChain[0];
901
- const debuggerModel = firstScript?.debuggerId ?
902
- await SDK.DebuggerModel.DebuggerModel.modelForDebuggerId(firstScript.debuggerId) :
903
- null;
904
- this.#target = debuggerModel?.target() ?? null;
895
+ this.#target = this.#frame?.resourceTreeModel().target() ?? null;
905
896
  }
906
897
 
907
898
  const frame = this.#frame;
@@ -320,7 +320,7 @@ export class IDBDataView extends UI.View.SimpleView {
320
320
  private createDataGrid(): DataGrid.DataGrid.DataGridImpl<unknown> {
321
321
  const keyPath = this.isIndex && this.index ? this.index.keyPath : this.objectStore.keyPath;
322
322
 
323
- const columns = ([] as DataGrid.DataGrid.ColumnDescriptor[]);
323
+ const columns: DataGrid.DataGrid.ColumnDescriptor[] = [];
324
324
 
325
325
  // Create column defaults so that we avoid repetition below.
326
326
  const columnDefaults: Partial<DataGrid.DataGrid.ColumnDescriptor> = {
@@ -40,7 +40,7 @@ import {StorageItemsToolbar} from './StorageItemsToolbar.js';
40
40
 
41
41
  const {ARIAUtils} = UI;
42
42
  const {EmptyWidget} = UI.EmptyWidget;
43
- const {VBox, widgetConfig} = UI.Widget;
43
+ const {VBox, widget} = UI.Widget;
44
44
  const {Size} = Geometry;
45
45
  const {repeat} = LitDirectives;
46
46
 
@@ -118,14 +118,14 @@ export abstract class KeyValueStorageItemsView extends UI.Widget.VBox {
118
118
  // clang-format off
119
119
  render(html `
120
120
  <devtools-widget
121
- .widgetConfig=${widgetConfig(StorageItemsToolbar, {metadataView})}
121
+ ${widget(StorageItemsToolbar, {metadataView})}
122
122
  class=flex-none
123
123
  ${UI.Widget.widgetRef(StorageItemsToolbar, view => {output.toolbar = view;})}
124
124
  ></devtools-widget>
125
125
  <devtools-split-view sidebar-position="second" name="${id}-split-view-state">
126
126
  <devtools-widget
127
127
  slot="main"
128
- .widgetConfig=${widgetConfig(VBox, {minimumSize: new Size(0, 50)})}>
128
+ ${widget(VBox, {minimumSize: new Size(0, 50)})}>
129
129
  <devtools-data-grid
130
130
  .name=${`${id}-datagrid-with-preview`}
131
131
  striped
@@ -160,7 +160,7 @@ export abstract class KeyValueStorageItemsView extends UI.Widget.VBox {
160
160
  </devtools-widget>
161
161
  <devtools-widget
162
162
  slot="sidebar"
163
- .widgetConfig=${widgetConfig(VBox, {minimumSize: new Size(0, 50)})}
163
+ ${widget(VBox, {minimumSize: new Size(0, 50)})}
164
164
  jslog=${VisualLogging.pane('preview').track({resize: true})}>
165
165
  ${input.preview?.element}
166
166
  </devtools-widget>
@@ -210,8 +210,8 @@ export class ServiceWorkerCacheView extends UI.View.SimpleView {
210
210
  }
211
211
 
212
212
  private createDataGrid(): DataGrid.DataGrid.DataGridImpl<DataGridNode> {
213
- const columns = ([
214
- {id: 'number', title: '#', sortable: false, width: '3px'},
213
+ const columns: DataGrid.DataGrid.ColumnDescriptor[] = [
214
+ {id: 'number', title: '#' as Common.UIString.LocalizedString, sortable: false, width: '3px'},
215
215
  {id: 'name', title: i18nString(UIStrings.name), weight: 4, sortable: true},
216
216
  {
217
217
  id: 'response-type',
@@ -237,7 +237,7 @@ export class ServiceWorkerCacheView extends UI.View.SimpleView {
237
237
  sortable: true,
238
238
  },
239
239
  {id: 'vary-header', title: i18n.i18n.lockedString('Vary Header'), weight: 1, sortable: true},
240
- ] as DataGrid.DataGrid.ColumnDescriptor[]);
240
+ ];
241
241
  const dataGrid = new DataGrid.DataGrid.DataGridImpl({
242
242
  displayName: i18nString(UIStrings.serviceWorkerCache),
243
243
  columns,
@@ -219,7 +219,7 @@ export class PermissionsPolicySection extends UI.Widget.Widget {
219
219
  #view: View;
220
220
 
221
221
  constructor(element?: HTMLElement, view = DEFAULT_VIEW) {
222
- super(element, {useShadowDom: true});
222
+ super(element, {useShadowDom: false});
223
223
  this.#view = view;
224
224
  }
225
225
 
@@ -4,56 +4,58 @@
4
4
  * found in the LICENSE file.
5
5
  */
6
6
 
7
- :host {
8
- display: contents;
9
- }
10
-
11
- .text-ellipsis {
12
- overflow: hidden;
13
- text-overflow: ellipsis;
14
- white-space: nowrap;
15
- }
16
-
17
- .link,
18
- .devtools-link {
19
- color: var(--sys-color-primary);
20
- text-decoration: underline;
21
- cursor: pointer;
22
- outline-offset: 2px;
23
- }
24
-
25
- button.link {
26
- border: none;
27
- background: none;
28
- font-family: inherit;
29
- font-size: inherit;
30
- }
31
-
32
- .policies-list {
33
- padding-top: 3px;
34
- }
35
-
36
- .permissions-row {
37
- display: flex;
38
- line-height: 22px;
39
- }
40
-
41
- .permissions-row div {
42
- padding-right: 5px;
43
- }
44
-
45
- .feature-name {
46
- width: 135px;
47
- }
48
-
49
- .allowed-icon {
50
- vertical-align: sub;
51
- }
52
-
53
- .block-reason {
54
- width: 215px;
55
- }
56
-
57
- .disabled-features-button {
58
- padding-left: var(--sys-size-3);
7
+ @scope to (devtools-widget > *) {
8
+ :scope {
9
+ display: contents;
10
+ }
11
+
12
+ .text-ellipsis {
13
+ overflow: hidden;
14
+ text-overflow: ellipsis;
15
+ white-space: nowrap;
16
+ }
17
+
18
+ .link,
19
+ .devtools-link {
20
+ color: var(--sys-color-primary);
21
+ text-decoration: underline;
22
+ cursor: pointer;
23
+ outline-offset: 2px;
24
+ }
25
+
26
+ button.link {
27
+ border: none;
28
+ background: none;
29
+ font-family: inherit;
30
+ font-size: inherit;
31
+ }
32
+
33
+ .policies-list {
34
+ padding-top: 3px;
35
+ }
36
+
37
+ .permissions-row {
38
+ display: flex;
39
+ line-height: 22px;
40
+ }
41
+
42
+ .permissions-row div {
43
+ padding-right: 5px;
44
+ }
45
+
46
+ .feature-name {
47
+ width: 135px;
48
+ }
49
+
50
+ .allowed-icon {
51
+ vertical-align: sub;
52
+ }
53
+
54
+ .block-reason {
55
+ width: 215px;
56
+ }
57
+
58
+ .disabled-features-button {
59
+ padding-left: var(--sys-size-3);
60
+ }
59
61
  }
@@ -79,6 +79,18 @@ button.text-link {
79
79
  display: flex;
80
80
  }
81
81
 
82
+ .inline-items devtools-button {
83
+ flex: 0 0 20px;
84
+ width: 20px;
85
+ height: 20px;
86
+ }
87
+
88
+ .inline-items .text-ellipsis {
89
+ flex: 0 1 auto;
90
+ min-width: 0;
91
+ padding-left: 2px;
92
+ }
93
+
82
94
  .span-cols {
83
95
  grid-column-start: span 2;
84
96
  margin-left: var(--sys-size-9);
@@ -115,4 +127,4 @@ button.text-link {
115
127
  color: linktext;
116
128
  text-decoration-color: linktext;
117
129
  }
118
- }
130
+ }
@@ -27,6 +27,7 @@ const UIStringsNotTranslate = {
27
27
  } as const;
28
28
 
29
29
  const lockedString = i18n.i18n.lockedString;
30
+ const {widget} = UI.Widget;
30
31
 
31
32
  export interface AiCodeCompletionSummaryToolbarProps {
32
33
  citationsTooltipId: string;
@@ -64,7 +65,7 @@ export const DEFAULT_SUMMARY_TOOLBAR_VIEW: View = (input, _output, target) => {
64
65
  // clang-format off
65
66
  const disclaimer = input.disclaimerTooltipId && input.spinnerTooltipId ?
66
67
  html`<devtools-widget
67
- .widgetConfig=${UI.Widget.widgetConfig(AiCodeCompletionDisclaimer, {
68
+ ${widget(AiCodeCompletionDisclaimer, {
68
69
  disclaimerTooltipId: input.disclaimerTooltipId,
69
70
  spinnerTooltipId: input.spinnerTooltipId,
70
71
  loading: input.loading,
@@ -72,14 +72,8 @@ const DEFAULT_VIEW: View = (input, _output, target) => {
72
72
  accessibleName: consoleTitle,
73
73
  compact,
74
74
  groups: [
75
- {
76
- iconName: 'cross-circle-filled',
77
- text: countToText(errors)
78
- },
79
- {
80
- iconName: 'warning-filled',
81
- text: countToText(warnings)
82
- },
75
+ {iconName: 'cross-circle-filled', text: countToText(errors)},
76
+ {iconName: 'warning-filled', text: countToText(warnings)},
83
77
  ],
84
78
  };
85
79
 
@@ -201,12 +195,11 @@ export class WarningErrorCounter implements UI.Toolbar.Provider {
201
195
  document.createElement('devtools-widget') as UI.Widget.WidgetElement<WarningErrorCounterWidget>;
202
196
  const toolbarItem = new UI.Toolbar.ToolbarItemWithCompactLayout(widgetElement);
203
197
  toolbarItem.setVisible(false);
204
- widgetElement.widgetConfig = UI.Widget.widgetConfig(e => {
205
- const widget = new WarningErrorCounterWidget(e, toolbarItem.setVisible.bind(toolbarItem));
206
- toolbarItem.addEventListener(
207
- UI.Toolbar.ToolbarItemWithCompactLayoutEvents.COMPACT_LAYOUT_UPDATED, widget.onSetCompactLayout, widget);
208
- return widget;
209
- });
198
+
199
+ const widget = new WarningErrorCounterWidget(widgetElement, toolbarItem.setVisible.bind(toolbarItem));
200
+ toolbarItem.addEventListener(
201
+ UI.Toolbar.ToolbarItemWithCompactLayoutEvents.COMPACT_LAYOUT_UPDATED, widget.onSetCompactLayout, widget);
202
+
210
203
  this.toolbarItem = toolbarItem;
211
204
  }
212
205