chrome-devtools-frontend 1.0.1572937 → 1.0.1574367

package/front_end/third_party/puppeteer/package/src/bidi/Page.ts

@@ -43,7 +43,7 @@ import type {
   CookieSameSite,
   DeleteCookiesRequest,
 } from '../common/Cookie.js';
-import {UnsupportedOperation} from '../common/Errors.js';
+import {ProtocolError, UnsupportedOperation} from '../common/Errors.js';
 import {EventEmitter} from '../common/EventEmitter.js';
 import {FileChooser} from '../common/FileChooser.js';
 import type {PDFOptions} from '../common/PDFOptions.js';
@@ -136,7 +136,6 @@ export class BidiPage extends Page {
   /**
    * @internal
    */
-  #overrideNavigatorPropertiesPreloadScript?: string;
   override async setUserAgent(
     userAgentOrOptions:
       | string
@@ -147,79 +146,40 @@ export class BidiPage extends Page {
         },
     userAgentMetadata?: Protocol.Emulation.UserAgentMetadata,
   ): Promise<void> {
-    let userAgent: string;
-    let metadata: Protocol.Emulation.UserAgentMetadata | undefined;
+    let userAgent: string | null;
+    let clientHints:
+      | Bidi.BidiUaClientHints.Emulation.ClientHintsMetadata
+      | undefined;
     let platform: string | undefined;
 
     if (typeof userAgentOrOptions === 'string') {
       userAgent = userAgentOrOptions;
-      metadata = userAgentMetadata;
+      clientHints = userAgentMetadata;
     } else {
-      userAgent =
-        userAgentOrOptions.userAgent ??
-        (await this.#browserContext.browser().userAgent());
-      metadata = userAgentOrOptions.userAgentMetadata;
-      platform = userAgentOrOptions.platform;
+      userAgent = userAgentOrOptions.userAgent ?? null;
+      clientHints = userAgentOrOptions.userAgentMetadata;
+      // Empty string platform should be interpreted as "no override".
+      platform =
+        userAgentOrOptions.platform === ''
+          ? undefined
+          : userAgentOrOptions.platform;
     }
-
-    if (
-      !this.#browserContext.browser().cdpSupported &&
-      (metadata || platform)
-    ) {
-      throw new UnsupportedOperation(
-        'Current Browser does not support `userAgentMetadata` or `platform`',
-      );
-    } else if (
-      this.#browserContext.browser().cdpSupported &&
-      (metadata || platform)
-    ) {
-      return await this._client().send('Network.setUserAgentOverride', {
-        userAgent: userAgent,
-        userAgentMetadata: metadata,
-        platform: platform,
-      });
+    if (userAgent === '') {
+      // In WebDriver BiDi null is used to restore the original user agent.
+      userAgent = null;
     }
-    const enable = userAgent !== '';
-    userAgent = userAgent ?? (await this.#browserContext.browser().userAgent());
+    await this.#frame.browsingContext.setUserAgent(userAgent);
 
-    await this.#frame.browsingContext.setUserAgent(enable ? userAgent : null);
-
-    const overrideNavigatorProperties = (platform: string | undefined) => {
-      if (platform) {
-        Object.defineProperty(navigator, 'platform', {
-          value: platform,
-          configurable: true,
-        });
-      }
-    };
-
-    const frames = [this.#frame];
-    for (const frame of frames) {
-      frames.push(...frame.childFrames());
+    if (platform && platform !== '') {
+      // Work-around until https://github.com/w3c/webdriver-bidi/issues/1065 is resolved.
+      // Set platform via client hints override.
+      clientHints = clientHints ?? {};
+      clientHints.platform = platform;
     }
 
-    if (this.#overrideNavigatorPropertiesPreloadScript) {
-      await this.removeScriptToEvaluateOnNewDocument(
-        this.#overrideNavigatorPropertiesPreloadScript,
-      );
-    }
-    const [evaluateToken] = await Promise.all([
-      enable
-        ? this.evaluateOnNewDocument(
-            overrideNavigatorProperties,
-            platform || undefined,
-          )
-        : undefined,
-      // When we disable the UserAgent we want to
-      // evaluate the original value in all Browsing Contexts
-      ...frames.map(frame => {
-        return frame.evaluate(
-          overrideNavigatorProperties,
-          platform || undefined,
-        );
-      }),
-    ]);
-    this.#overrideNavigatorPropertiesPreloadScript = evaluateToken?.identifier;
+    await this.#frame.browsingContext.setClientHintsOverride(
+      clientHints ?? null,
+    );
   }
 
   override async setBypassCSP(enabled: boolean): Promise<void> {
@@ -420,6 +380,7 @@ export class BidiPage extends Page {
   }
 
   override async setViewport(viewport: Viewport | null): Promise<void> {
+    let needsReload = false;
     if (!this.browser().cdpSupported) {
       const viewportSize =
         viewport?.width && viewport?.height
@@ -447,7 +408,7 @@ export class BidiPage extends Page {
               }
           : null;
 
-      await Promise.all([
+      const commands = [
         this.#frame.browsingContext.setViewport({
           viewport: viewportSize,
           devicePixelRatio,
@@ -455,13 +416,39 @@ export class BidiPage extends Page {
         this.#frame.browsingContext.setScreenOrientationOverride(
           screenOrientation,
         ),
-      ]);
+      ];
 
-      this.#viewport = viewport;
-      return;
+      if (
+        (this.#viewport?.hasTouch ?? false) !== (viewport?.hasTouch ?? false)
+      ) {
+        // The requested touch override state is different from the current one, meaning
+        // the reload is needed.
+        needsReload = true;
+        // 1 touch point if touch is enabled, null otherwise.
+        const maxTouchPoints = viewport?.hasTouch ? 1 : null;
+
+        commands.push(
+          this.#frame.browsingContext
+            .setTouchOverride(maxTouchPoints)
+            .catch(error => {
+              if (
+                error instanceof ProtocolError &&
+                (error.message.includes('unknown command') ||
+                  error.message.includes('unsupported operation'))
+              ) {
+                // Tolerate not implemented or not supported commands. At least until
+                // the `emulation.setTouchOverride` is supported by all the supported
+                // browsers.
+                return;
+              }
+              throw error;
+            }),
+        );
+      }
+      await Promise.all(commands);
+    } else {
+      needsReload = await this.#cdpEmulationManager.emulateViewport(viewport);
     }
-    const needsReload =
-      await this.#cdpEmulationManager.emulateViewport(viewport);
     this.#viewport = viewport;
     if (needsReload) {
       await this.reload();
@@ -1139,6 +1126,10 @@ function cdpSpecificCookiePropertiesFromBidiToPuppeteer(
       result[property] = bidiCookie[CDP_SPECIFIC_PREFIX + property];
     }
   }
+  // TODO: remove once deprecated sameParty attribute is dropped.
+  if (!result.sameParty) {
+    result.sameParty = false;
+  }
   return result;
 }
 

package/front_end/third_party/puppeteer/package/src/bidi/core/BrowsingContext.ts

@@ -155,6 +155,8 @@ export class BrowsingContext extends EventEmitter<{
   #navigation: Navigation | undefined;
   #reason?: string;
   #url: string;
+  // Indicated whether client hints have been set to non-default.
+  #clientHintsAreSet = false;
   readonly #children = new Map<string, BrowsingContext>();
   readonly #disposables = new DisposableStack();
   readonly #realms = new Map<string, WindowRealm>();
@@ -508,6 +510,17 @@ export class BrowsingContext extends EventEmitter<{
     });
   }
 
+  @throwIfDisposed<BrowsingContext>(context => {
+    // SAFETY: Disposal implies this exists.
+    return context.#reason!;
+  })
+  async setTouchOverride(maxTouchPoints: number | null): Promise<void> {
+    await this.#session.send('emulation.setTouchOverride', {
+      contexts: [this.id],
+      maxTouchPoints,
+    });
+  }
+
   @throwIfDisposed<BrowsingContext>(context => {
     // SAFETY: Disposal implies this exists.
     return context.#reason!;
@@ -761,6 +774,22 @@ export class BrowsingContext extends EventEmitter<{
     });
   }
 
+  async setClientHintsOverride(
+    clientHints: Bidi.BidiUaClientHints.Emulation.ClientHintsMetadata | null,
+  ): Promise<void> {
+    if (clientHints === null && !this.#clientHintsAreSet) {
+      // Ignore the call, as the client hints are not supposed to be changed. Required to
+      // avoid breakage with browsers that don't support client hints emulation.
+      return;
+    }
+    this.#clientHintsAreSet = true;
+
+    await this.#session.send('emulation.setClientHintsOverride', {
+      clientHints,
+      contexts: [this.id],
+    });
+  }
+
   async setOfflineMode(enabled: boolean): Promise<void> {
     await this.#session.send('emulation.setNetworkConditions', {
       networkConditions: enabled

package/front_end/third_party/puppeteer/package/src/cdp/Accessibility.ts

@@ -8,6 +8,7 @@ import type {Protocol} from 'devtools-protocol';
 
 import type {ElementHandle} from '../api/ElementHandle.js';
 import type {Realm} from '../api/Realm.js';
+import type {CdpFrame} from '../cdp/Frame.js';
 import {debugError} from '../common/util.js';
 
 /**
@@ -88,12 +89,19 @@ export interface SerializedAXNode {
   children?: SerializedAXNode[];
 
   /**
-   * CDP-specifc ID to reference the DOM node.
+   * CDP-specific ID to reference the DOM node.
    *
    * @internal
    */
   backendNodeId?: number;
 
+  /**
+   * CDP-specific documentId.
+   *
+   * @internal
+   */
+  loaderId: string;
+
   /**
    * Get an ElementHandle for this AXNode if available.
    *
@@ -553,6 +561,9 @@ class AXNode {
         })) as ElementHandle<Element>;
       },
       backendNodeId: this.payload.backendDOMNodeId,
+      // LoaderId is an experimental mechanism to establish unique IDs across
+      // navigations.
+      loaderId: (this.#realm.environment as CdpFrame)._loaderId,
     };
 
     type UserStringProperty =

package/front_end/third_party/puppeteer/package/src/cdp/BrowserContext.ts

@@ -116,6 +116,8 @@ export class CdpBrowserContext extends BrowserContext {
               hasCrossSiteAncestor: cookie.partitionKey.hasCrossSiteAncestor,
             }
           : undefined,
+        // TODO: remove sameParty as it is removed from Chrome.
+        sameParty: cookie.sameParty ?? false,
       };
     });
   }

package/front_end/third_party/puppeteer/package/src/cdp/Page.ts

@@ -650,6 +650,8 @@ export class CdpPage extends Page {
         partitionKey: cookie.partitionKey
           ? cookie.partitionKey.topLevelSite
           : undefined,
+        // TODO: remove sameParty as it is removed from Chrome.
+        sameParty: cookie.sameParty ?? false,
       };
     });
   }

package/front_end/third_party/puppeteer/package/src/revisions.ts

@@ -8,7 +8,7 @@
  * @internal
  */
 export const PUPPETEER_REVISIONS = Object.freeze({
-  chrome: '143.0.7499.192',
-  'chrome-headless-shell': '143.0.7499.192',
-  firefox: 'stable_146.0.1',
+  chrome: '144.0.7559.96',
+  'chrome-headless-shell': '144.0.7559.96',
+  firefox: 'stable_147.0.1',
 });

package/front_end/third_party/puppeteer/package/src/util/version.ts

@@ -6,5 +6,5 @@
 
 // If moved update release-please config
 // x-release-please-start-version
-export const packageVersion = '24.35.0';
+export const packageVersion = '24.36.0';
 // x-release-please-end

package/front_end/ui/components/buttons/Button.ts

@@ -56,17 +56,12 @@ interface ButtonState {
   spinner?: boolean;
   type: ButtonType;
   value?: string;
-  title?: string;
   iconName?: string;
   toggledIconName?: string;
   toggleType?: ToggleType;
   jslogContext?: string;
   longClickable?: boolean;
   inverseColorTheme?: boolean;
-  /**
-   * Sets aria-label on the internal <button> element.
-   */
-  accessibleLabel?: string;
 }
 
 interface CommonButtonData {
@@ -151,9 +146,6 @@ export class Button extends HTMLElement {
     if ('size' in data && data.size) {
       this.#props.size = data.size;
     }
-    if (data.accessibleLabel) {
-      this.#props.accessibleLabel = data.accessibleLabel;
-    }
 
     this.#props.active = Boolean(data.active);
     this.#props.spinner = Boolean('spinner' in data ? data.spinner : false);
@@ -166,7 +158,14 @@ export class Button extends HTMLElement {
     this.#props.toggleType = data.toggleType;
     this.#props.checked = data.checked;
     this.#props.disabled = Boolean(data.disabled);
-    this.#props.title = data.title;
+    if (data.title) {
+      this.title = data.title;
+    }
+
+    if (data.accessibleLabel) {
+      this.accessibleLabel = data.accessibleLabel;
+    }
+
     this.#props.jslogContext = data.jslogContext;
     this.#props.longClickable = data.longClickable;
     this.#props.inverseColorTheme = data.inverseColorTheme;
@@ -198,11 +197,20 @@ export class Button extends HTMLElement {
     this.#render();
   }
 
-  set accessibleLabel(label: string) {
-    this.#props.accessibleLabel = label;
+  set accessibleLabel(label: string|undefined) {
+    if (label) {
+      this.setAttribute('accessibleLabel', label);
+    } else {
+      this.removeAttribute('accessibleLabel');
+    }
+
     this.#render();
   }
 
+  get accessibleLabel(): string|undefined {
+    return this.getAttribute('accessibleLabel') || undefined;
+  }
+
   set reducedFocusRing(reducedFocusRing: boolean) {
     this.#props.reducedFocusRing = reducedFocusRing;
     this.#render();
@@ -213,8 +221,12 @@ export class Button extends HTMLElement {
     this.#render();
   }
 
+  override get title(): string {
+    return super.title;
+  }
+
   override set title(title: string) {
-    this.#props.title = title;
+    super.title = title;
     this.#render();
   }
 
@@ -369,11 +381,11 @@ export class Button extends HTMLElement {
     Lit.render(
       html`
         <style>${buttonStyles}</style>
-        <button title=${ifDefined(this.#props.title)}
+        <button title=${ifDefined(this.title || undefined)}
                 ?disabled=${this.#props.disabled}
                 class=${classMap(classes)}
                 aria-pressed=${ifDefined(this.#props.toggled)}
-                aria-label=${ifDefined(this.#props.accessibleLabel)}
+                aria-label=${ifDefined(this.accessibleLabel || this.title || undefined)}
                 jslog=${ifDefined(jslog)}>
           ${hasIcon ? html`
             <devtools-icon name=${ifDefined(this.#props.toggled ? this.#props.toggledIconName : this.#props.iconName)}>

package/front_end/ui/components/buttons/FloatingButton.ts

@@ -9,7 +9,7 @@ import * as Lit from '../../lit/lit.js';
 
 import floatingButtonStyles from './floatingButton.css.js';
 
-const {html} = Lit;
+const {html, Directives: {classMap}} = Lit;
 
 /**
  * A simple floating button component, primarily used to display the 'Ask AI!'
@@ -19,7 +19,7 @@ const {html} = Lit;
  *
  * ```js
  * // Instantiate programmatically via the `create()` helper:
- * const button = Buttons.FloatingButton.create('smart-assistant', 'Ask AI!');
+ * const button = Buttons.FloatingButton.create(AiAssistance.AiUtils.getIconName(), 'Ask AI!');
  *
  * // Use within a template:
  * html`
@@ -96,10 +96,14 @@ export class FloatingButton extends HTMLElement {
   }
 
   #render(): void {
+    const classes = classMap({
+      gemini: this.iconName === 'spark',
+    });
+
     // clang-format off
     Lit.render(html`
         <style>${floatingButtonStyles}</style>
-        <button><devtools-icon .name=${this.iconName}></devtools-icon></button>`,
+        <button class=${classes}><devtools-icon .name=${this.iconName}></devtools-icon></button>`,
         this.#shadow, {host: this});
     // clang-format on
   }

package/front_end/ui/components/buttons/floatingButton.css

@@ -72,3 +72,47 @@ button {
     color: var(--sys-color-state-disabled);
   }
 }
+
+.gemini {
+  display: flex;
+  justify-content: center;
+  align-items: center;
+  width: var(--sys-size-9);
+  height: var(--sys-size-9);
+  border-radius: var(--sys-shape-corner-full);
+  background-image: var(--app-gradient-google-ai);
+  font: var(--sys-typescale-body4-medium);
+  color: var(--ref-palette-neutral100);
+  transition: width 1s, padding 1s;
+  margin-left: auto;
+  overflow: hidden;
+  position: relative;
+  border: 0;
+
+  &:focus-visible {
+    outline: var(--sys-size-2) solid var(--sys-color-state-focus-ring);
+  }
+
+  &:hover::after,
+  &:active::after {
+    content: "";
+    height: 100%;
+    width: 100%;
+    border-radius: inherit;
+    position: absolute;
+    top: 0;
+    left: 0;
+  }
+
+  &:hover::after {
+    background-color: var(--sys-color-state-hover-on-prominent);
+  }
+
+  &:active::after {
+    background-color: var(--sys-color-state-ripple-primary);
+  }
+
+  devtools-icon {
+    color: var(--ref-palette-neutral100) !important; /* stylelint-disable-line declaration-no-important */
+  }
+}

package/front_end/ui/components/markdown_view/CodeBlock.ts

@@ -204,7 +204,7 @@ export class CodeBlock extends HTMLElement {
   #renderNotice(): Lit.TemplateResult {
     // clang-format off
     return html`<p class="notice">
-      <devtools-link class="link" href="https://support.google.com/legal/answer/13505487" .jslogContext=${'code-disclaimer'}>
+      <devtools-link class="link" href="https://support.google.com/legal/answer/13505487" jslogcontext="code-disclaimer">
         ${i18nString(UIStrings.disclaimer)}
       </devtools-link>
     </p>`;

package/front_end/ui/components/panel_feedback/PanelFeedback.ts

@@ -74,7 +74,7 @@ export class PanelFeedback extends HTMLElement {
           </div>
           <div class="video-description">
             <h3>${i18nString(UIStrings.videoAndDocumentation)}</h3>
-            <devtools-link class="quick-start-link" href=${this.#props.quickStartUrl} .jslogContext=${'css-overview.quick-start'}>${this.#props.quickStartLinkText}</devtools-link>
+            <devtools-link class="quick-start-link" href=${this.#props.quickStartUrl} jslogcontext="css-overview.quick-start">${this.#props.quickStartLinkText}</devtools-link>
           </div>
         </div>
       </div>

package/front_end/ui/components/text_editor/AutocompleteHistory.ts

@@ -20,6 +20,12 @@ export class AutocompleteHistory {
   #historyOffset = 1;
   #uncommittedIsTop = false;
 
+  /**
+   * Tracks session-local edits made to history entries during navigation.
+   * Maps history index to edited text. Cleared when a new command is committed.
+   */
+  #editedEntries = new Map<number, string>();
+
   /**
    * Creates a new settings-backed history. The class assumes it has sole
    * ownership of the setting.
@@ -33,6 +39,7 @@ export class AutocompleteHistory {
     this.#data = [];
     this.#setting.set([]);
     this.#historyOffset = 1;
+    this.#editedEntries.clear();
   }
 
   length(): number {
@@ -49,6 +56,7 @@ export class AutocompleteHistory {
     }
 
     this.#historyOffset = 1;
+    this.#editedEntries.clear();
     if (text !== this.#currentHistoryItem()) {
       this.#data.push(text);
     }
@@ -72,11 +80,33 @@ export class AutocompleteHistory {
     }
     if (this.#historyOffset === 1) {
       this.#pushCurrentText(currentText);
+    } else {
+      this.#saveCurrentEdit(currentText);
     }
     ++this.#historyOffset;
     return this.#currentHistoryItem();
   }
 
+  /**
+   * Saves the current text as an edit if it differs from the current history item
+   * (which may already have edits from a previous navigation).
+   * Only saves non-empty edits to avoid issues with navigation-only calls.
+   */
+  #saveCurrentEdit(text: string): void {
+    const index = this.#data.length - this.#historyOffset;
+    const currentValue = this.#currentHistoryItem();
+    if (text === currentValue) {
+      return;
+    }
+    const original = this.#data[index];
+    if (text !== original && text.length > 0) {
+      this.#editedEntries.set(index, text);
+    } else {
+      // Remove edit if text was restored to original (or emptied)
+      this.#editedEntries.delete(index);
+    }
+  }
+
   next(): string|undefined {
     if (this.#historyOffset === 1) {
       return undefined;
@@ -98,7 +128,9 @@ export class AutocompleteHistory {
   }
 
   #currentHistoryItem(): string|undefined {
-    return this.#data[this.#data.length - this.#historyOffset];
+    const index = this.#data.length - this.#historyOffset;
+    // Return edited version if available, otherwise return original
+    return this.#editedEntries.get(index) ?? this.#data[index];
   }
 
   #store(): void {

package/front_end/ui/visual_logging/KnownContextValues.ts

@@ -4201,6 +4201,7 @@ export const knownContextValues = new Set([
   'view-transition-class',
   'view-transition-group',
   'view-transition-name',
+  'view-transition-scope',
   'views-location-override',
   'virtual-authenticators',
   'visibility',

package/package.json

@@ -93,7 +93,8 @@
     "typescript-eslint": "8.47.0",
     "uuid": "13.0.0",
     "webidl2": "24.5.0",
-    "yargs": "17.7.2"
+    "yargs": "17.7.2",
+    "js-rouge": "3.2.0"
   },
   "overrides": {
     "@typescript-eslint/types": "8.47.0",
@@ -104,5 +105,5 @@
       "flat-cache": "6.1.12"
     }
   },
-  "version": "1.0.1572937"
+  "version": "1.0.1574367"
 }