chrome-devtools-frontend 1.0.1572937 → 1.0.1574367

package/front_end/panels/application/DeviceBoundSessionsTreeElement.ts

@@ -120,8 +120,20 @@ export class RootTreeElement extends ApplicationPanelTreeElement {
     }
   }
 
-  #updateTerminatedSessionDisplay(site: string, sessionId: string|undefined): void {
+  #updateElementIconAndStyling(
+      sessionElement: ApplicationPanelTreeElement, isSessionTerminated: boolean, sessionHasErrors: boolean): void {
+    if (isSessionTerminated) {
+      sessionElement.listItemElement.classList.add('device-bound-session-terminated');
+      sessionElement.setLeadingIcons([createIcon('database-off')]);
+      return;
+    }
+    sessionElement.listItemElement.classList.remove('device-bound-session-terminated');
+    sessionElement.setLeadingIcons([createIcon(sessionHasErrors ? 'warning' : 'database')]);
+  }
+
+  #updateIconAndStyling(site: string, sessionId: string|undefined): void {
     const isSessionTerminated = this.#model.isSessionTerminated(site, sessionId);
+    const sessionHasErrors = this.#model.sessionHasErrors(site, sessionId);
     const siteMapEntry = this.#sites.get(site);
     if (!siteMapEntry) {
       return;
@@ -130,12 +142,21 @@ export class RootTreeElement extends ApplicationPanelTreeElement {
     if (!sessionElement) {
       return;
     }
-    if (isSessionTerminated) {
-      sessionElement.listItemElement.classList.add('device-bound-session-terminated');
-      sessionElement.setLeadingIcons([createIcon('database-off')]);
-    } else {
-      sessionElement.listItemElement.classList.remove('device-bound-session-terminated');
-      sessionElement.setLeadingIcons([createIcon('database')]);
+    this.#updateElementIconAndStyling(sessionElement, isSessionTerminated, sessionHasErrors);
+  }
+
+  #removeWarningIcons(noLongerFailedSessions: Map<string, Array<string|undefined>>): void {
+    for (const [site, noLongerFailedSessionIds] of noLongerFailedSessions) {
+      const siteData = this.#sites.get(site);
+      if (siteData) {
+        for (const noLongerFailedSessionId of noLongerFailedSessionIds) {
+          const sessionElement = siteData.sessions.get(noLongerFailedSessionId);
+          if (sessionElement) {
+            const isSessionTerminated = this.#model.isSessionTerminated(site, noLongerFailedSessionId);
+            this.#updateElementIconAndStyling(sessionElement, isSessionTerminated, /* sessionHasErrors=*/ false);
+          }
+        }
+      }
     }
   }
 
@@ -231,12 +252,13 @@ export class RootTreeElement extends ApplicationPanelTreeElement {
       {data: {site, sessionId}}: Common.EventTarget
           .EventTargetEvent<DeviceBoundSessionModelEventTypes[DeviceBoundSessionModelEvents.EVENT_OCCURRED]>): void {
     this.#addSiteSessionIfMissing(site, sessionId);
-    this.#updateTerminatedSessionDisplay(site, sessionId);
+    this.#updateIconAndStyling(site, sessionId);
   }
 
-  #onClearEvents({data: {emptySessions, emptySites}}: Common.EventTarget
+  #onClearEvents({data: {emptySessions, emptySites, noLongerFailedSessions}}: Common.EventTarget
                      .EventTargetEvent<DeviceBoundSessionModelEventTypes[DeviceBoundSessionModelEvents.CLEAR_EVENTS]>):
       void {
     this.#removeEmptyElements(emptySessions, emptySites);
+    this.#removeWarningIcons(noLongerFailedSessions);
   }
 }

package/front_end/panels/application/FrameDetailsView.ts

@@ -324,7 +324,7 @@ function renderOriginTrial(trials: Protocol.Page.OriginTrial[]|null): LitTemplat
       <span class="report-section">
         ${i18nString(UIStrings.originTrialsExplanation)}
         <devtools-link href="https://developer.chrome.com/docs/web-platform/origin-trials/" class="link"
-                .jslogContext=${'learn-more.origin-trials'}>
+                jslogcontext="learn-more.origin-trials">
           ${i18nString(UIStrings.learnMore)}
         </devtools-link>
       </span>
@@ -738,7 +738,7 @@ function renderApiAvailabilitySection(frame: SDK.ResourceTreeModel.ResourceTreeF
           ${i18nString(UIStrings.availabilityOfCertainApisDepends)}
           <devtools-link
             href="https://web.dev/why-coop-coep/" class="link"
-            .jslogContext=${'learn-more.coop-coep'}>
+            jslogcontext="learn-more.coop-coep">
             ${i18nString(UIStrings.learnMore)}
           </devtools-link>
         </span>
@@ -815,8 +815,7 @@ function renderMeasureMemoryAvailability(frame: SDK.ResourceTreeModel.ResourceTr
         <devtools-report-key>${i18nString(UIStrings.measureMemory)}</devtools-report-key>
         <devtools-report-value>
           <span title=${tooltipText}>${
-        availabilityText}</span>\xA0<devtools-link class="link" href="https://web.dev/monitor-total-page-memory-usage/" .jslogContext=${
-                                                                  'learn-more.monitor-memory-usage'}>${
+        availabilityText}</span>\xA0<devtools-link class="link" href="https://web.dev/monitor-total-page-memory-usage/" jslogcontext="learn-more.monitor-memory-usage">${
         i18nString(UIStrings.learnMore)}</devtools-link>
         </devtools-report-value>
       `;

package/front_end/panels/application/components/BounceTrackingMitigationsView.ts

@@ -159,7 +159,7 @@ const renderMainFrameInformation = (input: ViewInput): Lit.LitTemplate => {
     </devtools-report-divider>
     <devtools-report-section>
       <devtools-link href="https://privacycg.github.io/nav-tracking-mitigations/#bounce-tracking-mitigations" class="link"
-      .jslogContext=${'learn-more'}>
+      jslogcontext="learn-more">
         ${i18nString(UIStrings.learnMore)}
       </devtools-link>
     </devtools-report-section>

package/front_end/panels/application/components/ProtocolHandlersView.ts

@@ -82,7 +82,7 @@ function renderStatusMessage(
                      name=${protocolHandlers.length > 0 ? 'check-circle' : 'info'}>
       </devtools-icon>
       ${uiI18n.getFormatLocalizedStringTemplate(str_, statusString, {PH1: html`
-        <devtools-link href=${manifestLink} .jslogContext=${'manifest'}>${i18nString(UIStrings.manifest)}</devtools-link>
+        <devtools-link href=${manifestLink} jslogcontext="manifest">${i18nString(UIStrings.manifest)}</devtools-link>
         ` })}
     </div>`;
   // clang-format on
@@ -144,7 +144,7 @@ const DEFAULT_VIEW: View = (input, _output, target) => {
     ${renderStatusMessage(input.protocolHandler, input.manifestLink)}
     <div class="protocol-handlers-row">
       ${i18nTemplate(UIStrings.needHelpReadOur, {PH1: html`
-        <devtools-link href=${PROTOCOL_DOCUMENT_URL} class="devtools-link" autofocus .jslogContext=${'learn-more'}>
+        <devtools-link href=${PROTOCOL_DOCUMENT_URL} class="devtools-link" autofocus jslogcontext="learn-more">
           ${i18nString(UIStrings.protocolHandlerRegistrations)}
         </devtools-link>`})}
     </div>

package/front_end/panels/application/components/ReportsGrid.ts

@@ -82,7 +82,7 @@ export const DEFAULT_VIEW = (input: ViewInput, output: undefined, target: HTMLEl
                 <style>${reportsGridStyles}</style>
                 <span class="status-header">${i18nString(UIStrings.status)}</span>
                 <devtools-link href="https://web.dev/reporting-api/#report-status"
-                .jslogContext=${'report-status'}>
+                jslogcontext="report-status">
                   <devtools-icon class="inline-icon medium" name="help" style="color: var(--icon-link);"
                   ></devtools-icon>
                 </devtools-link>
@@ -112,7 +112,7 @@ export const DEFAULT_VIEW = (input: ViewInput, output: undefined, target: HTMLEl
             <devtools-link
               class="devtools-link"
               href=${REPORTING_API_EXPLANATION_URL}
-              .jslogContext=${'learn-more'}
+              jslogcontext="learn-more"
             >${i18nString(UIStrings.learnMore)}</devtools-link>
           </div>
         </div>

package/front_end/panels/application/preloading/PreloadingView.ts

@@ -257,7 +257,7 @@ export class PreloadingRuleSetView extends UI.Widget.VBox {
             <devtools-link
               class="devtools-link"
               href=${SPECULATION_EXPLANATION_URL}
-              .jslogContext=${'learn-more'}
+              jslogcontext="learn-more"
             >${i18nString(UIStrings.learnMore)}</devtools-link>
           </div>
         </div>
@@ -434,7 +434,7 @@ export class PreloadingAttemptView extends UI.Widget.VBox {
             <devtools-link
               class="devtools-link"
               href=${SPECULATION_EXPLANATION_URL}
-              .jslogContext=${'learn-more'}
+              jslogcontext="learn-more"
             >${i18nString(UIStrings.learnMore)}</devtools-link>
           </div>
         </div>

package/front_end/panels/application/preloading/components/UsedPreloadingView.ts

@@ -262,7 +262,7 @@ function renderMismatchedSections(data: MismatchedData): LitTemplate {
       <devtools-link
         class="link devtools-link"
         href=${data.pageURL}
-        .jslogContext=${'current-url'}
+        jslogcontext="current-url"
       >${data.pageURL}</devtools-link>
     </devtools-report-section>
 
@@ -412,7 +412,7 @@ const DEFAULT_VIEW: View = (input, _output, target) => {
         <devtools-link
           class="link devtools-link"
           href=${'https://developer.chrome.com/blog/prerender-pages/'}
-          .jslogContext=${'learn-more'}
+          jslogcontext="learn-more"
         >${i18nString(UIStrings.learnMore)}</devtools-link>
       </devtools-report-section>
     </devtools-report>`, target);

package/front_end/panels/autofill/AutofillView.ts

@@ -238,14 +238,14 @@ const DEFAULT_VIEW: View = (input: ViewInput, _output: ViewOutput, target: HTMLE
                 jslog=${VisualLogging.toggle(input.autoOpenViewSetting.name).track({ change: true })}>
               ${i18nString(UIStrings.autoShow)}
             </devtools-checkbox>
-            <devtools-link href=${AUTOFILL_FEEDBACK_URL} class="feedback link" .jslogContext=${'feedback'}>${i18nString(UIStrings.sendFeedback)}</devtools-link>
+            <devtools-link href=${AUTOFILL_FEEDBACK_URL} class="feedback link" jslogcontext="feedback">${i18nString(UIStrings.sendFeedback)}</devtools-link>
           </div>
           <div class="placeholder-container" jslog=${VisualLogging.pane('autofill-empty')}>
             <div class="empty-state">
               <span class="empty-state-header">${i18nString(UIStrings.noAutofill)}</span>
               <div class="empty-state-description">
                 <span>${i18nString(UIStrings.toStartDebugging)}</span>
-                <devtools-link href=${AUTOFILL_INFO_URL} class="link" .jslogContext=${'learn-more'}>${i18nString(UIStrings.learnMore)}</devtools-link>
+                <devtools-link href=${AUTOFILL_INFO_URL} class="link" jslogcontext="learn-more">${i18nString(UIStrings.learnMore)}</devtools-link>
               </div>
             </div>
           </div>
@@ -280,7 +280,7 @@ const DEFAULT_VIEW: View = (input: ViewInput, _output: ViewOutput, target: HTMLE
                   ${i18nString(UIStrings.autoShow)}
                 </devtools-checkbox>
               </div>
-              <devtools-link href=${AUTOFILL_FEEDBACK_URL} class="feedback link" .jslogContext=${'feedback'}>${i18nString(UIStrings.sendFeedback)}</devtools-link>
+              <devtools-link href=${AUTOFILL_FEEDBACK_URL} class="feedback link" jslogcontext="feedback">${i18nString(UIStrings.sendFeedback)}</devtools-link>
             </div>
             ${renderAddress()}
           </div>

package/front_end/panels/common/AiCodeCompletionSummaryToolbar.ts

@@ -89,7 +89,7 @@ export const DEFAULT_SUMMARY_TOOLBAR_VIEW: View = (input, _output, target) => {
                     ${Directives.repeat(input.citations, citation => html`<devtools-link
                         tabIndex="0"
                         href=${citation}
-                        .jslogContext=${'ai-code-completion-citations.citation-link'}>${citation}</devtools-link>`)}</div></devtools-tooltip>
+                        jslogcontext="ai-code-completion-citations.citation-link">${citation}</devtools-link>`)}</div></devtools-tooltip>
             </div>` : nothing;
 
   render(

package/front_end/panels/common/AiCodeCompletionTeaser.ts

@@ -8,6 +8,7 @@ import * as Common from '../../core/common/common.js';
 import * as Host from '../../core/host/host.js';
 import * as i18n from '../../core/i18n/i18n.js';
 import * as Root from '../../core/root/root.js';
+import * as AIAssistance from '../../models/ai_assistance/ai_assistance.js';
 import * as AiCodeGeneration from '../../models/ai_code_generation/ai_code_generation.js';
 import * as Snackbars from '../../ui/components/snackbars/snackbars.js';
 import * as UI from '../../ui/legacy/legacy.js';
@@ -249,7 +250,7 @@ export class AiCodeCompletionTeaser extends UI.Widget.Widget {
           content: html`<devtools-link
             href=${CODE_SNIPPET_WARNING_URL}
             class="link devtools-link"
-            .jslogContext=${'code-snippets-explainer.ai-code-completion-teaser'}
+            jslogcontext="code-snippets-explainer.ai-code-completion-teaser"
           >${lockedString(UIStringsNotTranslate.freDisclaimerTextUseWithCaution)}</devtools-link>`,
           // clang-format on
         });
@@ -259,8 +260,9 @@ export class AiCodeCompletionTeaser extends UI.Widget.Widget {
   onAction = async(event: Event): Promise<void> => {
     event.preventDefault();
 
+    const iconName = AIAssistance.AiUtils.getIconName();
     const result = await FreDialog.show({
-      header: {iconName: 'smart-assistant', text: lockedString(UIStringsNotTranslate.freDisclaimerHeader)},
+      header: {iconName, text: lockedString(UIStringsNotTranslate.freDisclaimerHeader)},
       reminderItems: this.#createReminderItems(),
       onLearnMoreClick: () => {
         void UI.ViewManager.ViewManager.instance().showView('chrome-ai');

package/front_end/panels/common/AiCodeGenerationUpgradeDialog.ts

@@ -82,7 +82,7 @@ export class AiCodeGenerationUpgradeDialog {
               @click=${() => {
                 void UI.ViewManager.ViewManager.instance().showView('chrome-ai');
                 }}
-              .jslogContext=${'ai-code-generation-upgrade-dialog.manage-in-settings'}
+              jslogcontext="ai-code-generation-upgrade-dialog.manage-in-settings"
               .variant=${Buttons.Button.Variant.OUTLINED}
               aria-label=${lockedString(UIStringsNotTranslate.manageInSettings)}>
               ${lockedString(UIStringsNotTranslate.manageInSettings)}
@@ -91,7 +91,7 @@ export class AiCodeGenerationUpgradeDialog {
               @click=${() => {
                   dialog.hide();
                 }}
-              .jslogContext=${'ai-code-generation-upgrade-dialog.continue'}
+              jslogcontext="ai-code-generation-upgrade-dialog.continue"
               .variant=${Buttons.Button.Variant.PRIMARY}>
               ${lockedString(UIStringsNotTranslate.gotIt)}
             </devtools-button>

package/front_end/panels/common/BadgeNotification.ts

@@ -204,8 +204,9 @@ export class BadgeNotification extends UI.Widget.Widget {
     this.#show({
       message: i18nFormatStringTemplate(UIStrings.starterBadgeAwardMessageSettingDisabled, {
         PH1: badge.title,
-        PH2: html`<devtools-link class="badge-link" href="https://developers.google.com/program" .jslogContext=${
-                 'program-link'}>${lockedString('Google Developer Program')}</devtools-link>`
+        PH2:
+            html`<devtools-link class="badge-link" href="https://developers.google.com/program" jslogcontext="program-link">${
+                lockedString('Google Developer Program')}</devtools-link>`
       }),
       jslogContext: badge.jslogContext,
       actions: [

package/front_end/panels/common/GdpSignUpDialog.ts

@@ -154,9 +154,9 @@ export const DEFAULT_VIEW: View = (input, _output, target): void => {
             <div class="section-text">
               <div>${i18nString(UIStrings.tailorProfileBody)}</div><br/>
               <div>${uiI18n.getFormatLocalizedStringTemplate(str_, UIStrings.tailorProfileBodyDisclaimer, {
-      PH1: html`<devtools-link href=${CONTENT_POLICY_URL} class="link" .jslogContext=${'content-policy'}>${i18nString(UIStrings.contentPolicy)}</devtools-link>`,
-      PH2: html`<devtools-link href=${TERMS_OF_SERVICE_URL} class="link" .jslogContext=${'terms-of-service'}>${i18nString(UIStrings.termsOfService)}</devtools-link>`,
-      PH3: html`<devtools-link href=${PRIVACY_POLICY_URL} class="link" .jslogContext=${'privacy-policy'}>${i18nString(UIStrings.privacyPolicy)}</devtools-link>`,
+      PH1: html`<devtools-link href=${CONTENT_POLICY_URL} class="link" jslogcontext="content-policy">${i18nString(UIStrings.contentPolicy)}</devtools-link>`,
+      PH2: html`<devtools-link href=${TERMS_OF_SERVICE_URL} class="link" jslogcontext="terms-of-service">${i18nString(UIStrings.termsOfService)}</devtools-link>`,
+      PH3: html`<devtools-link href=${PRIVACY_POLICY_URL} class="link" jslogcontext="privacy-policy">${i18nString(UIStrings.privacyPolicy)}</devtools-link>`,
     })}</div>
             </div>
           </div>

package/front_end/panels/common/GeminiRebrandPromoDialog.ts

@@ -82,7 +82,7 @@ export const DEFAULT_VIEW: View = (input, _output, target): void => {
             .size=${Buttons.Button.Size.REGULAR}
             .title=${i18nString(UIStrings.dismiss)}
             jslog=${VisualLogging.close().track({click: true})}
-            @click=${() => {}}
+            @click=${() => input.onCancelClick()}
           ></devtools-button>
         </div>
       </div>

package/front_end/panels/console/ConsoleInsightTeaser.ts

@@ -169,7 +169,7 @@ function renderNoModel(input: ViewInput): Lit.TemplateResult {
           lockedString(UIStringsNotTranslate.getHelpForError)}
         </h2>
         <div>You can get quick answers from <devtools-link
-            .jslogContext=${'insights-teaser-built-in-ai-documentation'}
+            jslogcontext="insights-teaser-built-in-ai-documentation"
             class="link"
             href=${BUILT_IN_AI_DOCUMENTATION}
           >
@@ -329,7 +329,7 @@ function renderFooter(input: ViewInput): Lit.TemplateResult {
             class="devtools-link"
             title=${lockedString(UIStringsNotTranslate.learnMoreAboutAiSummaries)}
             href=${DATA_USAGE_URL}
-            .jslogContext=${'explain.teaser.learn-more'}
+            jslogcontext="explain.teaser.learn-more"
           >${lockedString(UIStringsNotTranslate.learnMoreAboutAiSummaries)}</devtools-link>
         </div>
       </devtools-tooltip>
@@ -495,8 +495,9 @@ export class ConsoleInsightTeaser extends UI.Widget.Widget {
   async #showFreDialog(): Promise<void> {
     const noLogging = Root.Runtime.hostConfig.aidaAvailability?.enterprisePolicyValue ===
         Root.Runtime.GenAiEnterprisePolicyValue.ALLOW_WITHOUT_LOGGING;
+    const iconName = AiAssistanceModel.AiUtils.getIconName();
     const result = await PanelCommon.FreDialog.show({
-      header: {iconName: 'smart-assistant', text: lockedString(UIStringsNotTranslate.freDisclaimerHeader)},
+      header: {iconName, text: lockedString(UIStringsNotTranslate.freDisclaimerHeader)},
       reminderItems: [
         {
           iconName: 'psychiatry',
@@ -513,7 +514,7 @@ export class ConsoleInsightTeaser extends UI.Widget.Widget {
           content: html`<devtools-link
             href=${CODE_SNIPPET_WARNING_URL}
             class="link devtools-link"
-            .jslogContext=${'explain.teaser.code-snippets-explainer'}
+            jslogcontext="explain.teaser.code-snippets-explainer"
           >${lockedString(UIStringsNotTranslate.freDisclaimerTextUseWithCaution)}</devtools-link>`,
           // clang-format on
         }

package/front_end/panels/elements/ElementsTreeElement.ts

@@ -42,6 +42,7 @@ import * as Platform from '../../core/platform/platform.js';
 import * as Root from '../../core/root/root.js';
 import * as SDK from '../../core/sdk/sdk.js';
 import * as Protocol from '../../generated/protocol.js';
+import * as AIAssistance from '../../models/ai_assistance/ai_assistance.js';
 import * as Badges from '../../models/badges/badges.js';
 import type * as Elements from '../../models/elements/elements.js';
 import type * as IssuesManager from '../../models/issues_manager/issues_manager.js';
@@ -1076,7 +1077,8 @@ export class ElementsTreeElement extends UI.TreeOutline.TreeElement {
     const action = UI.ActionRegistry.ActionRegistry.instance().getAction('freestyler.elements-floating-button');
     if (this.contentElement && !this.aiButtonContainer) {
       this.aiButtonContainer = this.contentElement.createChild('span', 'ai-button-container');
-      const floatingButton = Buttons.FloatingButton.create('smart-assistant', action.title(), 'ask-ai');
+      const floatingButton =
+          Buttons.FloatingButton.create(AIAssistance.AiUtils.getIconName(), action.title(), 'ask-ai');
       floatingButton.addEventListener('click', ev => {
         ev.stopPropagation();
         this.select(true, false);

package/front_end/panels/explain/components/ConsoleInsight.ts

@@ -300,7 +300,7 @@ function renderSearchButton(onSearch: ViewInput['callbacks']['onSearch']): Lit.T
 
 function renderLearnMoreAboutInsights(): Lit.TemplateResult {
   // clang-format off
-  return html`<devtools-link href=${LEARN_MORE_URL} class="link" .jslogContext=${'learn-more'}>
+  return html`<devtools-link href=${LEARN_MORE_URL} class="link" jslogcontext="learn-more">
     ${i18nString(UIStrings.learnMore)}
   </devtools-link>`;
   // clang-format on
@@ -321,7 +321,7 @@ function maybeRenderSources(
           <devtools-link
             href=${url}
             class=${Directives.classMap({link: true, highlighted: index === highlightedCitationIndex})}
-            .jslogContext=${'references.console-insights'}
+            jslogcontext="references.console-insights"
             ${Directives.ref(e => { output.citationLinks[index] = e as HTMLElement; })}
             @animationend=${onCitationAnimationEnd}
           >
@@ -347,7 +347,7 @@ function maybeRenderRelatedContent(relatedUrls: string[], directCitationUrls: st
           <devtools-link
             href=${relatedUrl}
             class="link"
-            .jslogContext=${'references.console-insights'}
+            jslogcontext="references.console-insights"
           >
             ${relatedUrl}
           </devtools-link>
@@ -454,12 +454,12 @@ function renderConsentReminder(noLogging: boolean): Lit.TemplateResult {
       <div>Use of this feature is subject to the <devtools-link
           href=${TERMS_OF_SERVICE_URL}
           class="link"
-          .jslogContext=${'terms-of-service.console-insights'}>
+          jslogcontext="terms-of-service.console-insights">
         Google Terms of Service
         </devtools-link> and <devtools-link
           href=${PRIVACY_POLICY_URL}
           class="link"
-          .jslogContext=${'privacy-policy.console-insights'}>
+          jslogcontext="privacy-policy.console-insights">
         Google Privacy Policy
         </devtools-link>
       </div>
@@ -471,7 +471,7 @@ function renderConsentReminder(noLogging: boolean): Lit.TemplateResult {
         <devtools-link
           href=${CODE_SNIPPET_WARNING_URL}
           class="link"
-          .jslogContext=${'code-snippets-explainer.console-insights'}
+          jslogcontext="code-snippets-explainer.console-insights"
         >Use generated code snippets with caution</devtools-link>
       </div>
     </div>`;
@@ -515,7 +515,7 @@ function renderDisclaimer(noLogging: boolean, onDisclaimerSettingsLink: () => vo
               jslog=${VisualLogging.action('open-ai-settings').track({click: true})}>
       Open settings
     </button> or <devtools-link href=${LEARN_MORE_URL}
-        class="link" .jslogContext=${'learn-more'}>
+        class="link" jslogcontext="learn-more">
       learn more
     </devtools-link>
   </span>`;

package/front_end/panels/issues/CorsIssueDetailsView.ts

@@ -181,20 +181,6 @@ export class CorsIssueDetailsView extends AffectedResourcesView {
         this.appendColumnTitle(header, i18nString(UIStrings.initiatorAddressSpace));
         this.appendColumnTitle(header, i18nString(UIStrings.initiatorContext));
         break;
-      case IssuesManager.CorsIssue.IssueCode.PREFLIGHT_ALLOW_PRIVATE_NETWORK_ERROR:
-        this.appendColumnTitle(header, i18nString(UIStrings.preflightRequest));
-        this.appendColumnTitle(header, i18nString(UIStrings.invalidValue));
-        this.appendColumnTitle(header, i18nString(UIStrings.initiatorAddressSpace));
-        this.appendColumnTitle(header, i18nString(UIStrings.initiatorContext));
-        break;
-      case IssuesManager.CorsIssue.IssueCode.PREFLIGHT_MISSING_PRIVATE_NETWORK_ACCESS_ID:
-      case IssuesManager.CorsIssue.IssueCode.PREFLIGHT_MISSING_PRIVATE_NETWORK_ACCESS_NAME:
-        this.appendColumnTitle(header, i18nString(UIStrings.preflightRequest));
-        this.appendColumnTitle(header, i18nString(UIStrings.invalidValue));
-        this.appendColumnTitle(header, i18nString(UIStrings.resourceAddressSpace));
-        this.appendColumnTitle(header, i18nString(UIStrings.initiatorAddressSpace));
-        this.appendColumnTitle(header, i18nString(UIStrings.initiatorContext));
-        break;
       case IssuesManager.CorsIssue.IssueCode.METHOD_DISALLOWED_BY_PREFLIGHT_RESPONSE:
         this.appendColumnTitle(header, i18nString(UIStrings.preflightRequest));
         this.appendColumnTitle(header, i18nString(UIStrings.disallowedRequestMethod));
@@ -222,9 +208,6 @@ export class CorsIssueDetailsView extends AffectedResourcesView {
         Platform.assertUnhandled<IssuesManager.CorsIssue.IssueCode.PREFLIGHT_MISSING_ALLOW_EXTERNAL|
                                  IssuesManager.CorsIssue.IssueCode.PREFLIGHT_INVALID_ALLOW_EXTERNAL|
                                  IssuesManager.CorsIssue.IssueCode.INVALID_PRIVATE_NETWORK_ACCESS|
-                                 IssuesManager.CorsIssue.IssueCode.UNEXPECTED_PRIVATE_NETWORK_ACCESS|IssuesManager
-                                     .CorsIssue.IssueCode.PRIVATE_NETWORK_ACCESS_PERMISSION_UNAVAILABLE|IssuesManager
-                                     .CorsIssue.IssueCode.PRIVATE_NETWORK_ACCESS_PERMISSION_DENIED|
                                  IssuesManager.CorsIssue.IssueCode.LOCAL_NETWORK_ACCESS_PERMISSION_DENIED>(issueCode);
     }
 
@@ -267,18 +250,11 @@ export class CorsIssueDetailsView extends AffectedResourcesView {
       case Protocol.Network.CorsError.InvalidAllowCredentials:
       case Protocol.Network.CorsError.PreflightInvalidAllowCredentials:
         return 'Access-Control-Allow-Credentials';
-      case Protocol.Network.CorsError.PreflightMissingAllowPrivateNetwork:
-      case Protocol.Network.CorsError.PreflightInvalidAllowPrivateNetwork:
-        return 'Access-Control-Allow-Private-Network';
       case Protocol.Network.CorsError.RedirectContainsCredentials:
       case Protocol.Network.CorsError.PreflightDisallowedRedirect:
         return 'Location';
       case Protocol.Network.CorsError.PreflightInvalidStatus:
         return 'Status-Code';
-      case Protocol.Network.CorsError.PreflightMissingPrivateNetworkAccessId:
-        return 'Private-Network-Access-Id';
-      case Protocol.Network.CorsError.PreflightMissingPrivateNetworkAccessName:
-        return 'Private-Network-Access-Name';
     }
     return '';
   }
@@ -393,15 +369,6 @@ export class CorsIssueDetailsView extends AffectedResourcesView {
         this.appendIssueDetailCell(element, details.clientSecurityState?.initiatorIPAddressSpace ?? '');
         this.#appendSecureContextCell(element, details.clientSecurityState?.initiatorIsSecureContext);
         break;
-      case IssuesManager.CorsIssue.IssueCode.PREFLIGHT_ALLOW_PRIVATE_NETWORK_ERROR: {
-        element.appendChild(this.createRequestCell(details.request, opts));
-        this.#appendStatus(element, details.isWarning);
-        element.appendChild(this.createRequestCell(details.request, {...opts, linkToPreflight: true, highlightHeader}));
-        this.appendIssueDetailCell(element, details.corsErrorStatus.failedParameter, 'code-example');
-        this.appendIssueDetailCell(element, details.clientSecurityState?.initiatorIPAddressSpace ?? '');
-        this.#appendSecureContextCell(element, details.clientSecurityState?.initiatorIsSecureContext);
-        break;
-      }
       case IssuesManager.CorsIssue.IssueCode.METHOD_DISALLOWED_BY_PREFLIGHT_RESPONSE:
         element.appendChild(this.createRequestCell(details.request, opts));
         this.#appendStatus(element, details.isWarning);
@@ -461,25 +428,12 @@ export class CorsIssueDetailsView extends AffectedResourcesView {
         this.#appendStatus(element, details.isWarning);
         this.appendSourceLocation(element, details.location, issue.model()?.getTargetIfNotDisposed());
         break;
-      case IssuesManager.CorsIssue.IssueCode.PREFLIGHT_MISSING_PRIVATE_NETWORK_ACCESS_ID:
-      case IssuesManager.CorsIssue.IssueCode.PREFLIGHT_MISSING_PRIVATE_NETWORK_ACCESS_NAME:
-        element.appendChild(this.createRequestCell(details.request, opts));
-        this.#appendStatus(element, details.isWarning);
-        element.appendChild(this.createRequestCell(details.request, {...opts, linkToPreflight: true, highlightHeader}));
-        this.appendIssueDetailCell(element, CorsIssueDetailsView.getHeaderFromError(corsError));
-        this.appendIssueDetailCell(element, details.resourceIPAddressSpace ?? '');
-        this.appendIssueDetailCell(element, details.clientSecurityState?.initiatorIPAddressSpace ?? '');
-        this.#appendSecureContextCell(element, details.clientSecurityState?.initiatorIsSecureContext);
-        break;
       default:
         element.appendChild(this.createRequestCell(details.request, opts));
         this.#appendStatus(element, details.isWarning);
         Platform.assertUnhandled<IssuesManager.CorsIssue.IssueCode.PREFLIGHT_MISSING_ALLOW_EXTERNAL|
                                  IssuesManager.CorsIssue.IssueCode.PREFLIGHT_INVALID_ALLOW_EXTERNAL|
                                  IssuesManager.CorsIssue.IssueCode.INVALID_PRIVATE_NETWORK_ACCESS|
-                                 IssuesManager.CorsIssue.IssueCode.UNEXPECTED_PRIVATE_NETWORK_ACCESS|IssuesManager
-                                     .CorsIssue.IssueCode.PRIVATE_NETWORK_ACCESS_PERMISSION_UNAVAILABLE|IssuesManager
-                                     .CorsIssue.IssueCode.PRIVATE_NETWORK_ACCESS_PERMISSION_DENIED|
                                  IssuesManager.CorsIssue.IssueCode.LOCAL_NETWORK_ACCESS_PERMISSION_DENIED>(issueCode);
         break;
     }

package/front_end/panels/issues/IssueView.ts

@@ -455,7 +455,7 @@ export class IssueView extends UI.TreeOutline.TreeElement {
       const linkListItem = linkList.createChild('li');
       // eslint-disable-next-line @devtools/no-lit-render-outside-of-view
       render(
-          html`<devtools-link class="link devtools-link" href=${description.link} .jslogContext=${'learn-more'}>${
+          html`<devtools-link class="link devtools-link" href=${description.link} jslogcontext="learn-more">${
               i18nString(UIStrings.learnMoreS, {PH1: description.linkTitle})}</devtools-link>`,
           linkListItem);
     }

package/front_end/panels/network/NetworkDataGridNode.ts

@@ -42,6 +42,7 @@ import * as i18n from '../../core/i18n/i18n.js';
 import * as Platform from '../../core/platform/platform.js';
 import * as SDK from '../../core/sdk/sdk.js';
 import * as Protocol from '../../generated/protocol.js';
+import * as AiAssistance from '../../models/ai_assistance/ai_assistance.js';
 import * as Bindings from '../../models/bindings/bindings.js';
 import type * as HAR from '../../models/har/har.js';
 import * as Logs from '../../models/logs/logs.js';
@@ -1621,7 +1622,8 @@ export class NetworkRequestNode extends NetworkNode {
       const action = UI.ActionRegistry.ActionRegistry.instance().getAction('drjones.network-floating-button');
       const aiButtonContainer = document.createElement('span');
       aiButtonContainer.classList.add('ai-button-container');
-      const floatingButton = Buttons.FloatingButton.create('smart-assistant', action.title(), 'ask-ai');
+      const icon = AiAssistance.AiUtils.getIconName();
+      const floatingButton = Buttons.FloatingButton.create(icon, action.title(), 'ask-ai');
       floatingButton.addEventListener('click', ev => {
         ev.stopPropagation();
         this.select();

package/front_end/panels/network/RequestConditionsDrawer.ts

@@ -24,7 +24,7 @@ import * as PanelUtils from '../utils/utils.js';
 
 import requestConditionsDrawerStyles from './requestConditionsDrawer.css.js';
 
-const {ref} = Directives;
+const {ref, live} = Directives;
 const {widgetConfig} = UI.Widget;
 
 const UIStrings = {
@@ -439,10 +439,10 @@ export class RequestConditionsDrawer extends UI.Widget.VBox implements
           // clang-format off
         html`
     <input class=blocked-url-checkbox
-      @click=${toggle}
+      @change=${toggle}
       type=checkbox
       title=${i18nString(UIStrings.enableThrottlingToggleLabel, {PH1: constructorStringOrWildcardURL})}
-      .checked=${enabled}
+      .checked=${live(enabled)}
       .disabled=${!editable || !originalOrUpgradedURLPattern}
       jslog=${VisualLogging.toggle().track({ change: true })}>
     <devtools-button
@@ -519,7 +519,7 @@ export class RequestConditionsDrawer extends UI.Widget.VBox implements
           // clang-format off
         html`
     <input class=blocked-url-checkbox
-      @click=${toggle}
+      @change=${toggle}
       type=checkbox
       .checked=${condition.enabled}
       .disabled=${!editable}

package/front_end/panels/network/RequestTimingView.ts

@@ -504,7 +504,7 @@ export const DEFAULT_VIEW: View = (input, output, target) => {
            <devtools-link
              href="https://developer.chrome.com/docs/devtools/network/reference/#timing-explanation"
              class=devtools-link
-             .jslogContext=${'explanation'}>
+             jslogcontext="explanation">
                ${i18nString(UIStrings.explanation)}
            </devtools-link>
          <td></td>

package/front_end/panels/network/components/RequestHeadersView.ts

@@ -310,7 +310,7 @@ export class RequestHeadersView extends LegacyWrapper.LegacyWrapper.WrappableCom
       <devtools-link
           href="https://goo.gle/devtools-override"
           class="link devtools-link"
-          .jslogContext=${'devtools-override'}
+          jslogcontext="devtools-override"
       >
         <devtools-icon name="help" class="inline-icon medium">
         </devtools-icon>
@@ -319,7 +319,7 @@ export class RequestHeadersView extends LegacyWrapper.LegacyWrapper.WrappableCom
           @click=${revealHeadersFile}
           class="link devtools-link"
           title=${UIStrings.revealHeaderOverrides}
-          .jslogContext=${'reveal-header-overrides'}
+          jslogcontext="reveal-header-overrides"
       >
         ${fileIcon}${Persistence.NetworkPersistenceManager.HEADERS_FILENAME}
       </devtools-link>

package/front_end/panels/profiler/HeapDetachedElementsView.ts

@@ -126,11 +126,6 @@ export class DetachedElementsProfileType extends
       return;
     }
 
-    const animationModel = target?.model(SDK.AnimationModel.AnimationModel);
-    if (animationModel) {
-      // TODO(b/406904348): Remove this once we correctly release animations on the backend.
-      await animationModel.releaseAllAnimations();
-    }
     const data = await domModel.getDetachedDOMNodes();
 
     const profile: DetachedElementsProfileHeader = new DetachedElementsProfileHeader(heapProfilerModel, this, data);

package/front_end/panels/profiler/HeapProfileView.ts

@@ -283,12 +283,6 @@ export class SamplingHeapProfileTypeBase extends
     UI.InspectorView.InspectorView.instance().setPanelWarnings('heap-profiler', warnings);
 
     this.recording = true;
-    const target = heapProfilerModel.target();
-    const animationModel = target.model(SDK.AnimationModel.AnimationModel);
-    if (animationModel) {
-      // TODO(b/406904348): Remove this once we correctly release animations on the backend.
-      await animationModel.releaseAllAnimations();
-    }
     this.startSampling();
   }