chrome-devtools-frontend 1.0.1541552 → 1.0.1543082

package/front_end/panels/ai_assistance/AiAssistancePanel.ts

@@ -302,11 +302,17 @@ export const enum ViewState {
   EXPLORE_VIEW = 'explore-view'
 }
 
-interface PanelViewProps {
-  state: ViewState;
-}
-
-export type ViewInput = ChatViewProps&ToolbarViewInput&PanelViewProps;
+type PanelViewInput = {
+  state: ViewState.CHAT_VIEW,
+  props: ChatViewProps,
+}|{
+  state: ViewState.DISABLED_VIEW,
+  props: {aidaAvailability: Host.AidaClient.AidaAccessPreconditions},
+}|{
+  state: ViewState.EXPLORE_VIEW,
+};
+
+export type ViewInput = ToolbarViewInput&PanelViewInput;
 export interface PanelViewOutput {
   chatView?: ChatView;
 }
@@ -389,7 +395,7 @@ function defaultView(input: ViewInput, output: PanelViewOutput, target: HTMLElem
     switch (input.state) {
       case ViewState.CHAT_VIEW:
         return html`<devtools-ai-chat-view
-          .props=${input}
+          .props=${input.props}
           ${Lit.Directives.ref((el: Element | undefined) => {
             if (!el || !(el instanceof ChatView)) {
               return;
@@ -407,9 +413,7 @@ function defaultView(input: ViewInput, output: PanelViewOutput, target: HTMLElem
       case ViewState.DISABLED_VIEW:
         return html`<devtools-widget
           class="fill-panel"
-          .widgetConfig=${UI.Widget.widgetConfig(DisabledWidget, {
-            aidaAvailability: input.aidaAvailability,
-          })}
+          .widgetConfig=${UI.Widget.widgetConfig(DisabledWidget, input.props)}
         ></devtools-widget>`;
     }
   }
@@ -551,19 +555,73 @@ export class AiAssistancePanel extends UI.Panel.Panel {
         AiAssistanceModel.AiHistoryStorage.Events.HISTORY_DELETED, this.#onHistoryDeleted, this);
   }
 
-  #getChatUiState(): ViewState {
+  async #getPanelViewInput(): Promise<PanelViewInput> {
     const blockedByAge = Root.Runtime.hostConfig.aidaAvailability?.blockedByAge === true;
 
     if (this.#aidaAvailability !== Host.AidaClient.AidaAccessPreconditions.AVAILABLE ||
         !this.#aiAssistanceEnabledSetting?.getIfNotDisabled() || blockedByAge) {
-      return ViewState.DISABLED_VIEW;
+      return {
+        state: ViewState.DISABLED_VIEW,
+        props: {
+          aidaAvailability: this.#aidaAvailability,
+        },
+      };
     }
 
     if (this.#conversation?.type) {
-      return ViewState.CHAT_VIEW;
+      const emptyStateSuggestions = await getEmptyStateSuggestions(this.#selectedContext, this.#conversation);
+      const markdownRenderer = getMarkdownRenderer(this.#selectedContext, this.#conversation);
+      return {
+        state: ViewState.CHAT_VIEW,
+        props: {
+          blockedByCrossOrigin: this.#blockedByCrossOrigin,
+          isLoading: this.#isLoading,
+          messages: this.#messages,
+          selectedContext: this.#selectedContext,
+          conversationType: this.#conversation.type,
+          isReadOnly: this.#conversation.isReadOnly ?? false,
+          changeSummary: this.#getChangeSummary(),
+          inspectElementToggled: this.#toggleSearchElementAction?.toggled() ?? false,
+          userInfo: this.#userInfo,
+          canShowFeedbackForm: this.#serverSideLoggingEnabled,
+          multimodalInputEnabled: isAiAssistanceMultimodalInputEnabled() &&
+              this.#conversation.type === AiAssistanceModel.AiHistoryStorage.ConversationType.STYLING,
+          imageInput: this.#imageInput,
+          isTextInputDisabled: this.#isTextInputDisabled(),
+          emptyStateSuggestions,
+          inputPlaceholder: this.#getChatInputPlaceholder(),
+          disclaimerText: this.#getDisclaimerText(),
+          isTextInputEmpty: this.#isTextInputEmpty,
+          changeManager: this.#changeManager,
+          uploadImageInputEnabled: isAiAssistanceMultimodalUploadInputEnabled() &&
+              this.#conversation.type === AiAssistanceModel.AiHistoryStorage.ConversationType.STYLING,
+          markdownRenderer,
+          onTextSubmit: async (
+              text: string, imageInput?: Host.AidaClient.Part,
+              multimodalInputType?: AiAssistanceModel.AiAgent.MultimodalInputType) => {
+            this.#imageInput = undefined;
+            this.#isTextInputEmpty = true;
+            Host.userMetrics.actionTaken(Host.UserMetrics.Action.AiAssistanceQuerySubmitted);
+            await this.#startConversation(text, imageInput, multimodalInputType);
+          },
+          onInspectElementClick: this.#handleSelectElementClick.bind(this),
+          onFeedbackSubmit: this.#handleFeedbackSubmit.bind(this),
+          onCancelClick: this.#cancel.bind(this),
+          onContextClick: this.#handleContextClick.bind(this),
+          onNewConversation: this.#handleNewChatRequest.bind(this),
+          onTakeScreenshot: isAiAssistanceMultimodalInputEnabled() ? this.#handleTakeScreenshot.bind(this) : undefined,
+          onRemoveImageInput: isAiAssistanceMultimodalInputEnabled() ? this.#handleRemoveImageInput.bind(this) :
+                                                                       undefined,
+          onCopyResponseClick: this.#onCopyResponseClick.bind(this),
+          onTextInputChange: this.#handleTextInputChange.bind(this),
+          onLoadImage: isAiAssistanceMultimodalUploadInputEnabled() ? this.#handleLoadImage.bind(this) : undefined,
+        }
+      };
     }
 
-    return ViewState.EXPLORE_VIEW;
+    return {
+      state: ViewState.EXPLORE_VIEW,
+    };
   }
 
   #getAiAssistanceEnabledSetting(): Common.Settings.Setting<boolean>|undefined {
@@ -616,15 +674,7 @@ export class AiAssistancePanel extends UI.Panel.Panel {
     }
   }
 
-  // We select the default agent based on the open panels if
-  // there isn't any active conversation.
-  #selectDefaultAgentIfNeeded(): void {
-    // If there already is an agent and if it is not empty,
-    // we don't automatically change the agent. In addition to this,
-    // we don't change the current agent when there is a message in flight.
-    if ((this.#conversationAgent && this.#conversation && !this.#conversation.isEmpty) || this.#isLoading) {
-      return;
-    }
+  #getDefaultConversationType(): AiAssistanceModel.AiHistoryStorage.ConversationType|undefined {
     const {hostConfig} = Root.Runtime;
     const viewManager = UI.ViewManager.ViewManager.instance();
     const isElementsPanelVisible = viewManager.isViewVisible('elements');
@@ -643,12 +693,24 @@ export class AiAssistancePanel extends UI.Panel.Panel {
       targetConversationType = AiAssistanceModel.AiHistoryStorage.ConversationType.PERFORMANCE;
     }
 
+    return targetConversationType;
+  }
+
+  // We select the default agent based on the open panels if
+  // there isn't any active conversation.
+  #selectDefaultAgentIfNeeded(): void {
+    // If there already is an agent and if it is not empty,
+    // we don't automatically change the agent. In addition to this,
+    // we don't change the current agent when there is a message in flight.
+    if ((this.#conversationAgent && this.#conversation && !this.#conversation.isEmpty) || this.#isLoading) {
+      return;
+    }
+    const targetConversationType = this.#getDefaultConversationType();
     if (this.#conversation?.type === targetConversationType) {
       // The above if makes sure even if we have an active agent it's empty
       // So we can just reuse it
       return;
     }
-
     const agent = targetConversationType ?
         this.#conversationHandler.createAgent(targetConversationType, this.#changeManager) :
         undefined;
@@ -671,9 +733,9 @@ export class AiAssistancePanel extends UI.Panel.Panel {
       // create a new conversation along side it
       if (opts?.agent) {
         this.#conversation = new AiAssistanceModel.AiHistoryStorage.Conversation(
-            agentToConversationType(opts?.agent),
+            agentToConversationType(opts.agent),
             [],
-            opts?.agent.id,
+            opts.agent.id,
             false,
         );
       }
@@ -687,15 +749,21 @@ export class AiAssistancePanel extends UI.Panel.Panel {
       // but conversation is
       // update with history conversation
       if (opts?.conversation) {
-        this.#conversation = opts?.conversation;
+        this.#conversation = opts.conversation;
       }
     }
 
     if (!this.#conversationAgent && !this.#conversation) {
-      this.#selectDefaultAgentIfNeeded();
+      const conversationType = this.#getDefaultConversationType();
+      if (conversationType) {
+        const agent = this.#conversationHandler.createAgent(conversationType, this.#changeManager);
+        this.#updateConversationState({agent});
+        return;
+      }
     }
 
     this.#onContextSelectionChanged();
+
     this.requestUpdate();
   }
 
@@ -879,67 +947,29 @@ export class AiAssistancePanel extends UI.Panel.Panel {
     return this.#changeManager.formatChangesForPatching(this.#conversationAgent.id, /* includeSourceLocation= */ true);
   }
 
-  override async performUpdate(): Promise<void> {
-    const emptyStateSuggestions = await getEmptyStateSuggestions(this.#selectedContext, this.#conversation);
-    const markdownRenderer = getMarkdownRenderer(this.#selectedContext, this.#conversation);
+  #getToolbarInput(): ToolbarViewInput {
+    return {
+      isLoading: this.#isLoading,
+      showChatActions: this.#shouldShowChatActions(),
+      showActiveConversationActions: Boolean(this.#conversation && !this.#conversation.isEmpty),
+      onNewChatClick: this.#handleNewChatRequest.bind(this),
+      populateHistoryMenu: this.#populateHistoryMenu.bind(this),
+      onDeleteClick: this.#onDeleteClicked.bind(this),
+      onExportConversationClick: this.#onExportConversationClick.bind(this),
+      onHelpClick: () => {
+        UI.UIUtils.openInNewTab(AI_ASSISTANCE_HELP);
+      },
+      onSettingsClick: () => {
+        void UI.ViewManager.ViewManager.instance().showView('chrome-ai');
+      },
+    };
+  }
 
+  override async performUpdate(): Promise<void> {
     this.view(
         {
-          state: this.#getChatUiState(),
-          blockedByCrossOrigin: this.#blockedByCrossOrigin,
-          aidaAvailability: this.#aidaAvailability,
-          isLoading: this.#isLoading,
-          messages: this.#messages,
-          selectedContext: this.#selectedContext,
-          conversationType: this.#conversation?.type,
-          isReadOnly: this.#conversation?.isReadOnly ?? false,
-          changeSummary: this.#getChangeSummary(),
-          inspectElementToggled: this.#toggleSearchElementAction?.toggled() ?? false,
-          userInfo: this.#userInfo,
-          canShowFeedbackForm: this.#serverSideLoggingEnabled,
-          multimodalInputEnabled: isAiAssistanceMultimodalInputEnabled() &&
-              this.#conversation?.type === AiAssistanceModel.AiHistoryStorage.ConversationType.STYLING,
-          imageInput: this.#imageInput,
-          showChatActions: this.#shouldShowChatActions(),
-          showActiveConversationActions: Boolean(this.#conversation && !this.#conversation.isEmpty),
-          isTextInputDisabled: this.#isTextInputDisabled(),
-          emptyStateSuggestions,
-          inputPlaceholder: this.#getChatInputPlaceholder(),
-          disclaimerText: this.#getDisclaimerText(),
-          isTextInputEmpty: this.#isTextInputEmpty,
-          changeManager: this.#changeManager,
-          uploadImageInputEnabled: isAiAssistanceMultimodalUploadInputEnabled() &&
-              this.#conversation?.type === AiAssistanceModel.AiHistoryStorage.ConversationType.STYLING,
-          markdownRenderer,
-          onNewChatClick: this.#handleNewChatRequest.bind(this),
-          populateHistoryMenu: this.#populateHistoryMenu.bind(this),
-          onDeleteClick: this.#onDeleteClicked.bind(this),
-          onExportConversationClick: this.#onExportConversationClick.bind(this),
-          onHelpClick: () => {
-            UI.UIUtils.openInNewTab(AI_ASSISTANCE_HELP);
-          },
-          onSettingsClick: () => {
-            void UI.ViewManager.ViewManager.instance().showView('chrome-ai');
-          },
-          onTextSubmit: async (
-              text: string, imageInput?: Host.AidaClient.Part,
-              multimodalInputType?: AiAssistanceModel.AiAgent.MultimodalInputType) => {
-            this.#imageInput = undefined;
-            this.#isTextInputEmpty = true;
-            Host.userMetrics.actionTaken(Host.UserMetrics.Action.AiAssistanceQuerySubmitted);
-            await this.#startConversation(text, imageInput, multimodalInputType);
-          },
-          onInspectElementClick: this.#handleSelectElementClick.bind(this),
-          onFeedbackSubmit: this.#handleFeedbackSubmit.bind(this),
-          onCancelClick: this.#cancel.bind(this),
-          onContextClick: this.#handleContextClick.bind(this),
-          onNewConversation: this.#handleNewChatRequest.bind(this),
-          onTakeScreenshot: isAiAssistanceMultimodalInputEnabled() ? this.#handleTakeScreenshot.bind(this) : undefined,
-          onRemoveImageInput: isAiAssistanceMultimodalInputEnabled() ? this.#handleRemoveImageInput.bind(this) :
-                                                                       undefined,
-          onCopyResponseClick: this.#onCopyResponseClick.bind(this),
-          onTextInputChange: this.#handleTextInputChange.bind(this),
-          onLoadImage: isAiAssistanceMultimodalUploadInputEnabled() ? this.#handleLoadImage.bind(this) : undefined,
+          ...this.#getToolbarInput(),
+          ...await this.#getPanelViewInput(),
         },
         this.#viewOutput, this.contentElement);
   }
@@ -961,20 +991,6 @@ export class AiAssistancePanel extends UI.Panel.Panel {
   }
 
   #isTextInputDisabled(): boolean {
-    // If the `aiAssistanceSetting` is not enabled
-    // or if the user is blocked by age, the text input is disabled.
-    const aiAssistanceSetting = this.#aiAssistanceEnabledSetting?.getIfNotDisabled();
-    const isBlockedByAge = Root.Runtime.hostConfig.aidaAvailability?.blockedByAge === true;
-    if (!aiAssistanceSetting || isBlockedByAge) {
-      return true;
-    }
-
-    // If the Aida is not available, the text input is disabled.
-    const isAidaAvailable = this.#aidaAvailability === Host.AidaClient.AidaAccessPreconditions.AVAILABLE;
-    if (!isAidaAvailable) {
-      return true;
-    }
-
     // If sending a new message is blocked by cross origin context
     // the text input is disabled.
     if (this.#blockedByCrossOrigin) {
@@ -1004,8 +1020,7 @@ export class AiAssistancePanel extends UI.Panel.Panel {
   }
 
   #getChatInputPlaceholder(): Platform.UIString.LocalizedString {
-    const state = this.#getChatUiState();
-    if (state === ViewState.DISABLED_VIEW || !this.#conversation) {
+    if (!this.#conversation) {
       return i18nString(UIStrings.followTheSteps);
     }
 
@@ -1037,8 +1052,7 @@ export class AiAssistancePanel extends UI.Panel.Panel {
   }
 
   #getDisclaimerText(): Platform.UIString.LocalizedString {
-    const state = this.#getChatUiState();
-    if (state === ViewState.DISABLED_VIEW || !this.#conversation || this.#conversation.isReadOnly) {
+    if (!this.#conversation || this.#conversation.isReadOnly) {
       return i18nString(UIStrings.inputDisclaimerForEmptyState);
     }
 

package/front_end/panels/ai_assistance/components/ChatView.ts

@@ -236,13 +236,12 @@ export interface Props {
   onLoadImage?: (file: File) => Promise<void>;
   changeManager: AiAssistanceModel.ChangeManager.ChangeManager;
   inspectElementToggled: boolean;
-  aidaAvailability: Host.AidaClient.AidaAccessPreconditions;
   messages: ChatMessage[];
   selectedContext: AiAssistanceModel.AiAgent.ConversationContext<unknown>|null;
   isLoading: boolean;
   canShowFeedbackForm: boolean;
   userInfo: Pick<Host.InspectorFrontendHostAPI.SyncInformation, 'accountImage'|'accountFullName'>;
-  conversationType?: AiAssistanceModel.AiHistoryStorage.ConversationType;
+  conversationType: AiAssistanceModel.AiHistoryStorage.ConversationType;
   isReadOnly: boolean;
   blockedByCrossOrigin: boolean;
   changeSummary?: string;
@@ -469,7 +468,6 @@ export class ChatView extends HTMLElement {
     const renderFooter = (): Lit.LitTemplate => {
       const classes = Lit.Directives.classMap({
         'chat-view-footer': true,
-        'has-conversation': !!this.#props.conversationType,
         'is-read-only': this.#props.isReadOnly,
       });
 
@@ -488,9 +486,8 @@ export class ChatView extends HTMLElement {
     };
 
     const renderInputOrReadOnlySection = (): Lit.LitTemplate => {
-      if (this.#props.conversationType && this.#props.isReadOnly) {
+      if (this.#props.isReadOnly) {
         return renderReadOnlySection({
-          conversationType: this.#props.conversationType,
           onNewConversation: this.#props.onNewConversation,
         });
       }
@@ -506,7 +503,6 @@ export class ChatView extends HTMLElement {
         multimodalInputEnabled: this.#props.multimodalInputEnabled,
         conversationType: this.#props.conversationType,
         imageInput: this.#props.imageInput,
-        aidaAvailability: this.#props.aidaAvailability,
         isTextInputEmpty: this.#props.isTextInputEmpty,
         uploadImageInputEnabled: this.#props.uploadImageInputEnabled,
         onContextClick: this.#props.onContextClick,
@@ -957,12 +953,8 @@ function renderSelection({
   isTextInputDisabled: boolean,
   onContextClick: () => void | Promise<void>,
   onInspectElementClick: () => void,
-  conversationType?: AiAssistanceModel.AiHistoryStorage.ConversationType,
+  conversationType: AiAssistanceModel.AiHistoryStorage.ConversationType,
 }): Lit.LitTemplate {
-  if (!conversationType) {
-    return Lit.nothing;
-  }
-
   // TODO: currently the picker behavior is SDKNode specific.
   const hasPickerBehavior = conversationType === AiAssistanceModel.AiHistoryStorage.ConversationType.STYLING;
 
@@ -1119,14 +1111,9 @@ function renderEmptyState({isTextInputDisabled, suggestions, onSuggestionClick}:
   // clang-format on
 }
 
-function renderReadOnlySection({onNewConversation, conversationType}: {
+function renderReadOnlySection({onNewConversation}: {
   onNewConversation: () => void,
-  conversationType?: AiAssistanceModel.AiHistoryStorage.ConversationType,
 }): Lit.LitTemplate {
-  if (!conversationType) {
-    return Lit.nothing;
-  }
-
   // clang-format off
   return html`<div
     class="chat-readonly-container"
@@ -1355,7 +1342,6 @@ function renderChatInput({
   imageInput,
   isTextInputEmpty,
   uploadImageInputEnabled,
-  aidaAvailability,
   disclaimerText,
   onContextClick,
   onInspectElementClick,
@@ -1375,7 +1361,6 @@ function renderChatInput({
   selectedContext: AiAssistanceModel.AiAgent.ConversationContext<unknown>|null,
   inspectElementToggled: boolean,
   isTextInputEmpty: boolean,
-  aidaAvailability: Host.AidaClient.AidaAccessPreconditions,
   disclaimerText: string,
   onContextClick: () => void,
   onInspectElementClick: () => void,
@@ -1384,19 +1369,15 @@ function renderChatInput({
   onCancel: (ev: SubmitEvent) => void,
   onNewConversation: () => void,
   onTextInputChange: (input: string) => void,
+  conversationType: AiAssistanceModel.AiHistoryStorage.ConversationType,
   multimodalInputEnabled?: boolean,
-  conversationType?: AiAssistanceModel.AiHistoryStorage.ConversationType,
   imageInput?: ImageInputData,
   uploadImageInputEnabled?: boolean,
   onTakeScreenshot?: () => void,
   onRemoveImageInput?: () => void,
   onImageUpload?: (ev: Event) => void,
 }): Lit.LitTemplate {
-  if (!conversationType) {
-    return Lit.nothing;
-  }
-
-  const shouldShowMultiLine = aidaAvailability === Host.AidaClient.AidaAccessPreconditions.AVAILABLE && selectedContext;
+  const shouldShowMultiLine = selectedContext;
   const chatInputContainerCls = Lit.Directives.classMap({
     'chat-input-container': true,
     'single-line-layout': !shouldShowMultiLine,
@@ -1457,7 +1438,6 @@ function renderMainContents({
   suggestions,
   userInfo,
   markdownRenderer,
-  conversationType,
   changeSummary,
   changeManager,
   onSuggestionClick,
@@ -1478,13 +1458,9 @@ function renderMainContents({
   onFeedbackSubmit: (rpcId: Host.AidaClient.RpcGlobalId, rate: Host.AidaClient.Rating, feedback?: string) => void,
   onCopyResponseClick: (message: ModelChatMessage) => void,
   onMessageContainerRef: (el: Element|undefined) => void,
-  conversationType?: AiAssistanceModel.AiHistoryStorage.ConversationType,
+  conversationType: AiAssistanceModel.AiHistoryStorage.ConversationType,
   changeSummary?: string,
 }): Lit.LitTemplate {
-  if (!conversationType) {
-    return Lit.nothing;
-  }
-
   if (messages.length > 0) {
     return renderMessages({
       messages,

package/front_end/panels/ai_assistance/components/chatView.css

@@ -294,7 +294,7 @@ footer.chat-view-footer {
     The footer (for active conversations) is hidden by default on wider screens
     because the disclaimer is shown inline within the chat input actions. Show it only on narrow widths (< 400px).
   */
-  &.has-conversation:not(.is-read-only) {
+  &:not(.is-read-only) {
     display: none;
     border: none;
 

package/front_end/panels/application/components/BackForwardCacheView.ts

@@ -147,6 +147,7 @@ const UIStrings = {
 
 const str_ = i18n.i18n.registerUIStrings('panels/application/components/BackForwardCacheView.ts', UIStrings);
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
+const {widgetConfig} = UI.Widget;
 
 const enum ScreenStatusType {
   RUNNING = 'Running',
@@ -384,16 +385,18 @@ function maybeRenderJavaScriptDetails(details: Protocol.Page.BackForwardCacheBlo
     return nothing;
   }
   const maxLengthForDisplayedURLs = 50;
-  const linkifier = new Components.Linkifier.Linkifier(maxLengthForDisplayedURLs);
   const rows = [html`<div>${i18nString(UIStrings.filesPerIssue, {n: details.length})}</div>`];
-  rows.push(...details.map(
-      detail => html`${
-          linkifier.linkifyScriptLocation(
-              null, null, detail.url as Platform.DevToolsPath.UrlString, detail.lineNumber, {
-                columnNumber: detail.columnNumber,
-                showColumnNumber: true,
-                inlineFrameIndex: 0,
-              })}`));
+  rows.push(...details.map(detail => html`
+          <devtools-widget .widgetConfig=${widgetConfig(Components.Linkifier.ScriptLocationLink, {
+                             sourceURL: detail.url as Platform.DevToolsPath.UrlString,
+                             lineNumber: detail.lineNumber,
+                             options: {
+                               columnNumber: detail.columnNumber,
+                               showColumnNumber: true,
+                               inlineFrameIndex: 0,
+                               maxLength: maxLengthForDisplayedURLs,
+                             }
+                           })}></devtools-widget>`));
   return html`
       <div class="details-list">
         <devtools-expandable-list .data=${

package/front_end/panels/console/ConsoleInsightTeaser.ts

@@ -357,11 +357,16 @@ export class ConsoleInsightTeaser extends UI.Widget.Widget {
     this.#timeoutId = setTimeout(this.#setSlow.bind(this), SLOW_GENERATION_CUTOFF_MILLISECONDS);
     const startTime = performance.now();
     let teaserText = '';
+    let firstChunkReceived = false;
     try {
       for await (const chunk of this.#getOnDeviceInsight()) {
         teaserText += chunk;
         this.#mainText = teaserText;
         this.requestUpdate();
+        if (!firstChunkReceived) {
+          firstChunkReceived = true;
+          Host.userMetrics.consoleInsightTeaserFirstChunkGenerated(performance.now() - startTime);
+        }
       }
     } catch (err) {
       // Ignore `AbortError` errors, which are thrown on mouse leave.

package/front_end/panels/console/ConsolePrompt.ts

@@ -75,7 +75,7 @@ export class ConsolePrompt extends Common.ObjectWrapper.eventMixin<EventTypes, t
   private aidaAvailability?: Host.AidaClient.AidaAccessPreconditions;
   private boundOnAidaAvailabilityChange?: () => Promise<void>;
   private aiCodeCompletion?: AiCodeCompletion.AiCodeCompletion.AiCodeCompletion;
-  private teaser?: PanelCommon.AiCodeCompletionTeaser;
+  teaser?: PanelCommon.AiCodeCompletionTeaser;
   private placeholderCompartment: CodeMirror.Compartment = new CodeMirror.Compartment();
   private aiCodeCompletionSetting =
       Common.Settings.Settings.instance().createSetting('ai-code-completion-enabled', false);
@@ -554,7 +554,14 @@ export class ConsolePrompt extends Common.ObjectWrapper.eventMixin<EventTypes, t
       this.teaser = undefined;
     }
     this.aiCodeCompletion = new AiCodeCompletion.AiCodeCompletion.AiCodeCompletion(
-        {aidaClient: this.aidaClient}, this.editor, AiCodeCompletion.AiCodeCompletion.ContextFlavor.CONSOLE, ['\n\n']);
+        {aidaClient: this.aidaClient}, AiCodeCompletion.AiCodeCompletion.ContextFlavor.CONSOLE, {
+          getSelectionHead: () => this.editor.editor.state.selection.main.head,
+          getCompletionHint: () => this.editor.editor.plugin(TextEditor.Config.showCompletionHint)?.currentHint,
+          setAiAutoCompletion: (suggestion: TextEditor.Config.ActiveSuggestion|null) => {
+            this.editor.dispatch({effects: TextEditor.Config.setAiAutoCompleteSuggestion.of(suggestion)});
+          }
+        },
+        ['\n\n']);
     this.aiCodeCompletion.addEventListener(AiCodeCompletion.AiCodeCompletion.Events.RESPONSE_RECEIVED, event => {
       this.aiCodeCompletionCitations = event.data.citations;
       this.dispatchEventToListeners(Events.AI_CODE_COMPLETION_RESPONSE_RECEIVED, event.data);

package/front_end/panels/console/ConsoleView.ts

@@ -1457,6 +1457,9 @@ export class ConsoleView extends UI.Widget.VBox implements
   }
 
   private async keyDown(event: Event): Promise<void> {
+    if (!this.prompt.teaser?.isShowing()) {
+      return;
+    }
     const keyboardEvent = (event as KeyboardEvent);
     if (UI.KeyboardShortcut.KeyboardShortcut.eventHasCtrlEquivalentKey(keyboardEvent)) {
       if (keyboardEvent.key === 'i') {

package/front_end/panels/network/NetworkDataGridNode.ts

@@ -325,7 +325,6 @@ const UIStrings = {
   /**
    * @description Tooltip to explain why the request has an IPP icon
    */
-  responseIsIpProtectedToolTip: 'This request was sent through IP Protection proxies.',
 } as const;
 const str_ = i18n.i18n.registerUIStrings('panels/network/NetworkDataGridNode.ts', UIStrings);
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
@@ -1175,12 +1174,6 @@ export class NetworkRequestNode extends NetworkNode {
       cell.addEventListener('focus', () => this.parentView().resetFocus());
 
       // render icons
-      if (this.requestInternal.isIpProtectionUsed()) {
-        const ippIcon = IconButton.Icon.create('shield', 'icon');
-        ippIcon.title = i18nString(UIStrings.responseIsIpProtectedToolTip);
-        ippIcon.style.color = 'var(--sys-color-on-surface-subtle);';
-        cell.appendChild(ippIcon);
-      }
 
       const iconElement = PanelUtils.getIconForNetworkRequest(this.requestInternal);
       // eslint-disable-next-line @devtools/no-lit-render-outside-of-view