chrome-devtools-frontend 1.0.1541552 → 1.0.1543082

package/docs/get_the_code.md

@@ -368,6 +368,15 @@ out/Default/chrome --custom-devtools-frontend=file://$(realpath out/Default/gen/
 afterwards, which can be quite a bit faster than building and linking the full
 Chromium binary.
 
+Alternatively you can use `npm start` from the DevTools sub folder (`third_party/devtools-frontend/src/`) with the browser set to `chromium`.
+This will tell the command that you are in a Chromium checkout and try to find the correct browser executable path to resolve.
+Or alternately you can use a `.env` file, see [set up here](#using-a-env-file-for-default-script-options).
+
+```bash
+cd third_party/devtools-frontend/src/
+npm start -- --browser=chromium
+```
+
 ### Testing
 
 To run the test suite, use `npm test` from within the DevTools front-end folder:

package/front_end/Tests.js

@@ -955,6 +955,7 @@
       Common.Settings.Settings.instance({
         forceNew: true,
         ...Main.Main.instanceForTest.createSettingsStorage(prefs),
+        settingRegistrations: Common.SettingRegistration.getRegisteredSettings(),
         runSettingsMigration: false,
       });
 

package/front_end/core/common/Settings.ts

@@ -10,7 +10,6 @@ import type {EventDescriptor, EventTargetEvent, GenericEvents} from './EventTarg
 import {ObjectWrapper} from './Object.js';
 import {
   getLocalizedSettingsCategory,
-  getRegisteredSettings as getRegisteredSettingsInternal,
   type LearnMore,
   maybeRemoveSettingExtension,
   type RegExpSettingItem,
@@ -25,7 +24,21 @@ import {
 
 let settingsInstance: Settings|undefined;
 
+export interface SettingsCreationOptions {
+  syncedStorage: SettingsStorage;
+  globalStorage: SettingsStorage;
+  localStorage: SettingsStorage;
+  settingRegistrations: SettingRegistration[];
+  logSettingAccess?: (name: string, value: number|string|boolean) => Promise<void>;
+  runSettingsMigration?: boolean;
+}
+
 export class Settings {
+  readonly syncedStorage: SettingsStorage;
+  readonly globalStorage: SettingsStorage;
+  readonly localStorage: SettingsStorage;
+
+  readonly #settingRegistrations: SettingRegistration[];
   readonly #sessionStorage = new SettingsStorage({});
   settingNameSet = new Set<string>();
   orderValuesBySettingCategory = new Map<SettingCategory, Set<number>>();
@@ -34,16 +47,16 @@ export class Settings {
   readonly moduleSettings = new Map<string, Setting<unknown>>();
   #logSettingAccess?: (name: string, value: number|string|boolean) => Promise<void>;
 
-  private constructor(
-      readonly syncedStorage: SettingsStorage,
-      readonly globalStorage: SettingsStorage,
-      readonly localStorage: SettingsStorage,
-      logSettingAccess?: (name: string, value: number|string|boolean) => Promise<void>,
-      runSettingsMigration?: boolean,
-  ) {
+  constructor(
+      {syncedStorage, globalStorage, localStorage, settingRegistrations, logSettingAccess, runSettingsMigration}:
+          SettingsCreationOptions) {
+    this.syncedStorage = syncedStorage;
+    this.globalStorage = globalStorage;
+    this.localStorage = localStorage;
+    this.#settingRegistrations = settingRegistrations;
     this.#logSettingAccess = logSettingAccess;
 
-    for (const registration of this.getRegisteredSettings()) {
+    for (const registration of this.#settingRegistrations) {
       const {settingName, defaultValue, storageType} = registration;
       const isRegex = registration.settingType === SettingType.REGEX;
 
@@ -68,7 +81,7 @@ export class Settings {
   }
 
   getRegisteredSettings(): SettingRegistration[] {
-    return getRegisteredSettingsInternal();
+    return this.#settingRegistrations;
   }
 
   static hasInstance(): boolean {
@@ -80,17 +93,27 @@ export class Settings {
     syncedStorage: SettingsStorage|null,
     globalStorage: SettingsStorage|null,
     localStorage: SettingsStorage|null,
+    settingRegistrations: SettingRegistration[]|null,
     logSettingAccess?: (name: string, value: number|string|boolean) => Promise<void>,
     runSettingsMigration?: boolean,
-  } = {forceNew: null, syncedStorage: null, globalStorage: null, localStorage: null}): Settings {
-    const {forceNew, syncedStorage, globalStorage, localStorage, logSettingAccess, runSettingsMigration} = opts;
+  } = {forceNew: null, syncedStorage: null, globalStorage: null, localStorage: null, settingRegistrations: null}):
+      Settings {
+    const {
+      forceNew,
+      syncedStorage,
+      globalStorage,
+      localStorage,
+      settingRegistrations,
+      logSettingAccess,
+      runSettingsMigration
+    } = opts;
     if (!settingsInstance || forceNew) {
-      if (!syncedStorage || !globalStorage || !localStorage) {
+      if (!syncedStorage || !globalStorage || !localStorage || !settingRegistrations) {
         throw new Error(`Unable to create settings: global and local storage must be provided: ${new Error().stack}`);
       }
 
-      settingsInstance =
-          new Settings(syncedStorage, globalStorage, localStorage, logSettingAccess, runSettingsMigration);
+      settingsInstance = new Settings(
+          {syncedStorage, globalStorage, localStorage, settingRegistrations, logSettingAccess, runSettingsMigration});
     }
 
     return settingsInstance;

package/front_end/core/host/InspectorFrontendHost.ts

@@ -395,9 +395,6 @@ export class InspectorFrontendHostStub implements InspectorFrontendHostAPI {
         thirdPartyCookieHeuristicsEnabled: true,
         managedBlockThirdPartyCookies: 'Unset',
       },
-      devToolsIpProtectionPanelInDevTools: {
-        enabled: false,
-      },
       devToolsFlexibleLayout: {
         verticalDrawerEnabled: true,
       },

package/front_end/core/host/UserMetrics.ts

@@ -317,6 +317,11 @@ export class UserMetrics {
     InspectorFrontendHostInstance.recordPerformanceHistogram(
         'DevTools.Insights.TeaserGenerationTime', timeInMilliseconds);
   }
+
+  consoleInsightTeaserFirstChunkGenerated(timeInMilliseconds: number): void {
+    InspectorFrontendHostInstance.recordPerformanceHistogram(
+        'DevTools.Insights.TeaserFirstChunkGenerationTime', timeInMilliseconds);
+  }
 }
 
 /**

package/front_end/core/root/Runtime.ts

@@ -465,10 +465,6 @@ export interface HostConfigThirdPartyCookieControls {
   managedBlockThirdPartyCookies: string|boolean;
 }
 
-export interface HostConfigIPProtection {
-  enabled: boolean;
-}
-
 interface AiGeneratedTimelineLabels {
   enabled: boolean;
 }
@@ -482,10 +478,6 @@ interface AiSubmenuPrompts {
   featureName?: string;
 }
 
-interface IpProtectionInDevTools {
-  enabled: boolean;
-}
-
 interface AiDebugWithAi {
   enabled: boolean;
   featureName?: string;
@@ -568,7 +560,6 @@ export type HostConfig = Platform.TypeScriptUtilities.RecursivePartial<{
   devToolsWellKnown: HostConfigWellKnown,
   devToolsPrivacyUI: HostConfigPrivacyUI,
   devToolsIndividualRequestThrottling: DevToolsIndividualRequestThrottling,
-  devToolsIpProtectionPanelInDevTools: HostConfigIPProtection,
   /**
    * OffTheRecord here indicates that the user's profile is either incognito,
    * or guest mode, rather than a "normal" profile.
@@ -580,7 +571,6 @@ export type HostConfig = Platform.TypeScriptUtilities.RecursivePartial<{
   devToolsAiGeneratedTimelineLabels: AiGeneratedTimelineLabels,
   devToolsAllowPopoverForcing: AllowPopoverForcing,
   devToolsAiSubmenuPrompts: AiSubmenuPrompts,
-  devToolsIpProtectionInDevTools: IpProtectionInDevTools,
   devToolsGlobalAiButton: GlobalAiButton,
   devToolsGdpProfiles: GdpProfiles,
   devToolsGdpProfilesAvailability: GdpProfilesAvailability,

package/front_end/core/sdk/IOModel.ts

@@ -25,10 +25,7 @@ export class IOModel extends SDKModel<void> {
   }
 
   async close(handle: Protocol.IO.StreamHandle): Promise<void> {
-    const result = await this.target().ioAgent().invoke_close({handle});
-    if (result.getError()) {
-      console.error('Could not close stream.');
-    }
+    await this.target().ioAgent().invoke_close({handle});
   }
 
   async resolveBlob(objectOrObjectId: Protocol.Runtime.RemoteObjectId|RemoteObject): Promise<string> {

package/front_end/core/sdk/NetworkManager.ts

@@ -689,13 +689,6 @@ export class NetworkDispatcher implements ProtocolProxyApi.NetworkDispatcher {
       networkRequest.setSecurityDetails(response.securityDetails);
     }
 
-    // TODO(crbug.com/425645896): Remove this guard once IP Protection is fully launched.
-    if (Root.Runtime.hostConfig.devToolsIpProtectionInDevTools?.enabled) {
-      if (response.isIpProtectionUsed) {
-        networkRequest.setIsIpProtectionUsed(response.isIpProtectionUsed);
-      }
-    }
-
     const newResourceType = Common.ResourceType.ResourceType.fromMimeTypeOverride(networkRequest.mimeType);
     if (newResourceType) {
       networkRequest.setResourceType(newResourceType);

package/front_end/core/sdk/NetworkRequest.ts

@@ -317,7 +317,6 @@ export class NetworkRequest extends Common.ObjectWrapper.ObjectWrapper<EventType
   responseReceivedPromiseResolve?: () => void;
   directSocketInfo?: DirectSocketInfo;
   readonly #directSocketChunks: DirectSocketChunk[] = [];
-  #isIpProtectionUsed: boolean;
   #isAdRelated: boolean;
   #appliedNetworkConditionsId?: string;
 
@@ -341,7 +340,6 @@ export class NetworkRequest extends Common.ObjectWrapper.ObjectWrapper<EventType
     this.#loaderId = loaderId;
     this.#initiator = initiator;
     this.#hasUserGesture = hasUserGesture;
-    this.#isIpProtectionUsed = false;
     this.#isAdRelated = false;
   }
 
@@ -1832,14 +1830,6 @@ export class NetworkRequest extends Common.ObjectWrapper.ObjectWrapper<EventType
     return this.#isSameSite;
   }
 
-  setIsIpProtectionUsed(isIpProtectionUsed: boolean): void {
-    this.#isIpProtectionUsed = isIpProtectionUsed;
-  }
-
-  isIpProtectionUsed(): boolean|null {
-    return this.#isIpProtectionUsed;
-  }
-
   setIsAdRelated(isAdRelated: boolean): void {
     this.#isAdRelated = isAdRelated;
   }

package/front_end/core/sdk/ServerSentEventsProtocol.ts

@@ -35,6 +35,10 @@ export class ServerSentEventsParser {
     await this.#decoder.addBase64Chunk(raw);
   }
 
+  addTextChunk(chunk: string): void {
+    this.#onTextChunk(chunk);
+  }
+
   #onTextChunk(chunk: string): void {
     // A line consists of "this.#line" plus a slice of "chunk[start:<next new cr/lf>]".
     let start = 0;

package/front_end/entrypoints/inspector_main/RenderingOptions.ts

@@ -66,13 +66,13 @@ const UIStrings = {
       'Highlights elements (teal) that can slow down scrolling, including touch & wheel event handlers and other main-thread scrolling situations.',
   /**
    * @description The name of a checkbox setting in the Rendering tool. This setting highlights the
-   * rendering frames for ads that are found on the page.
+   * rendering elements for ads that are found on the page.
    */
-  highlightAdFrames: 'Highlight ad frames',
+  highlightAds: 'Highlight ads',
   /**
-   * @description Explanation text for the 'Highlight ad frames' setting in the Rendering tool.
+   * @description Explanation text for the 'Highlight ads' setting in the Rendering tool.
    */
-  highlightsFramesRedDetectedToBe: 'Highlights frames (red) detected to be ads.',
+  highlightsElementsRedDetectedToBe: 'Highlights elements (red) detected to be ads.',
   /**
    * @description The name of a checkbox setting in the Rendering tool. This setting prevents the
    * webpage from loading 'local' fonts. Local fonts are fonts that are installed on the user's
@@ -207,7 +207,7 @@ export class RenderingOptionsView extends UI.Widget.VBox {
         i18nString(UIStrings.scrollingPerformanceIssues), i18nString(UIStrings.highlightsElementsTealThatCan),
         Common.Settings.Settings.instance().moduleSetting('show-scroll-bottleneck-rects'));
     this.#appendCheckbox(
-        i18nString(UIStrings.highlightAdFrames), i18nString(UIStrings.highlightsFramesRedDetectedToBe),
+        i18nString(UIStrings.highlightAds), i18nString(UIStrings.highlightsElementsRedDetectedToBe),
         Common.Settings.Settings.instance().moduleSetting('show-ad-highlights'));
     this.#appendCheckbox(
         i18nString(UIStrings.disableLocalFonts), i18nString(UIStrings.disablesLocalSourcesInFontface),

package/front_end/entrypoints/main/MainImpl.ts

@@ -168,9 +168,12 @@ export class MainImpl {
     Object.assign(Root.Runtime.hostConfig, config);
 
     const creationOptions: Foundation.Universe.CreationOptions = {
-      ...this.createSettingsStorage(prefs),
-      logSettingAccess: VisualLogging.logSettingAccess,
-      runSettingsMigration: !Host.InspectorFrontendHost.isUnderTest(),
+      settingsCreationOptions: {
+        ...this.createSettingsStorage(prefs),
+        settingRegistrations: Common.SettingRegistration.getRegisteredSettings(),
+        logSettingAccess: VisualLogging.logSettingAccess,
+        runSettingsMigration: !Host.InspectorFrontendHost.isUnderTest(),
+      },
     };
     new Foundation.Universe.Universe(creationOptions);
 

package/front_end/entrypoints/main/main-meta.ts

@@ -910,13 +910,9 @@ UI.Toolbar.registerToolbarItem({
   condition(config) {
     const isFlagEnabled = config?.devToolsGlobalAiButton?.enabled;
 
-    const devtoolsLocale = i18n.DevToolsLocale.DevToolsLocale.instance();
-    const isLocaleRestricted = !devtoolsLocale.locale.startsWith('en-');
-
     const isGeoRestricted = config?.aidaAvailability?.blockedByGeo === true;
     const isPolicyRestricted = config?.aidaAvailability?.blockedByEnterprisePolicy === true;
-    const isAgeRestricted = Boolean(config?.aidaAvailability?.blockedByAge);
-    return Boolean(isFlagEnabled && !isLocaleRestricted && !isGeoRestricted && !isPolicyRestricted && !isAgeRestricted);
+    return Boolean(isFlagEnabled && !isGeoRestricted && !isPolicyRestricted);
   },
   async loadItem() {
     const Main = await loadMainModule();

package/front_end/foundation/Universe.ts

@@ -6,11 +6,7 @@ import * as Common from '../core/common/common.js';
 
 export interface CreationOptions {
   // Settings things
-  syncedStorage: Common.Settings.SettingsStorage;
-  globalStorage: Common.Settings.SettingsStorage;
-  localStorage: Common.Settings.SettingsStorage;
-  logSettingAccess?: (name: string, value: number|string|boolean) => Promise<void>;
-  runSettingsMigration?: boolean;
+  settingsCreationOptions: Common.Settings.SettingsCreationOptions;
 }
 
 export class Universe {
@@ -19,11 +15,7 @@ export class Universe {
     //                            For now the global is fine as we don't anticipate the MCP server to change settings.
     Common.Settings.Settings.instance({
       forceNew: true,
-      syncedStorage: options.syncedStorage,
-      globalStorage: options.globalStorage,
-      localStorage: options.localStorage,
-      logSettingAccess: options.logSettingAccess,
-      runSettingsMigration: options.runSettingsMigration,
+      ...options.settingsCreationOptions,
     });
   }
 }

package/front_end/generated/Deprecation.ts

@@ -90,14 +90,6 @@ export const UIStrings = {
    * @description This warning occurs when a stylesheet loaded from a local file directive does not end in the file type `.css`.
    */
   LocalCSSFileExtensionRejected: "CSS cannot be loaded from `file:` URLs unless they end in a `.css` file extension.",
-  /**
-   * @description This is a deprecation warning to developers that occurs when the script attempts to use the Media Source Extensions API in a way that is no longer supported by the specification for the API. The usage that is problematic is when the script calls the `SourceBuffer.abort()` method at a time when there is still processing happening in response to a previous `SourceBuffer.remove()` call for the same SourceBuffer object. More precisely, we show this warning to developers when script calls the SourceBuffer abort() method while the asynchronous processing of a remove() call on that SourceBuffer is not yet complete. Early versions of the Media Source Extensions specification allowed such aborts, but standardization of the specification resulted in disallowing the aborts. The script should instead wait for the asynchronous remove() operation to complete, which is observable by listening for the associated 'updateend' event from the SourceBuffer. A note is also included in the warning, describing when abort() is meaningful and allowed by the specification for purposes other than interrupting a remove() operation's asynchronous steps. Those supported purposes include using abort() to interrupt processing that may still be happening in response to a previous appendBuffer() call on that SourceBuffer, or using abort() to clear the internal of any unprocessed data remaining from previous appendBuffer() calls. See https://www.w3.org/TR/media-source-2/#dom-sourcebuffer-abort for the currently specified behavior, which would throw an exception once the deprecated removal abort is no longer supported. See https://github.com/w3c/media-source/issues/19 for the discussion that led to the specification change.
-   */
-  MediaSourceAbortRemove: "Using `SourceBuffer.abort()` to abort `remove()`'s asynchronous range removal is deprecated due to specification change. Support will be removed in the future. You should listen to the `updateend` event instead. `abort()` is intended to only abort an asynchronous media append or reset parser state.",
-  /**
-   * @description This is a deprecation warning to developers that occurs when the script attempts to use the Media Source Extensions API in a way that is no longer supported by the specification for the API. The usage that is problematic is when the script sets the duration attribute of a MediaSource object too low. The duration attribute of a MediaSource must be longer than the actual duration of any media (audio or video) already in the MediaSource. When set too low, the MediaSource must remove audio and video content that is beyond the time indicated by the new duration. Content removal that is caused by setting the duration attribute too low is no longer allowed by the specification. The message describes the minimum allowable duration value as the 'highest presentation timestamp of any buffered coded frames' as a more precise way of describing the duration of content already in the MediaSource: 'coded frames' are the specification's way of describing compressed audio frames or compressed video frames, and they each have a 'presentation timestamp' that describes precisely when that frame's playback occurs in the overall media presentation. Early versions of the Media Source Extensions specification allowed this to happen, but standardization of the specification resulted in disallowing this behavior. The underlying issue leading to this specification change was that setting the duration attribute should be synchronous, but setting it lower than the timestamp of something currently buffered would cause confusing removal of media between that new duration and the previous, larger, duration. The script should instead explicitly remove that range of media first, before lowering the duration. See https://www.w3.org/TR/media-source-2/#dom-mediasource-duration and https://www.w3.org/TR/media-source-2/#dom-mediasource-duration for the currently specified behavior, which would throw an exception once support is removed for deprecated implicit asynchronous range removal when duration is truncated. See both https://github.com/w3c/media-source/issues/20 and https://github.com/w3c/media-source/issues/26 for the discussion that led to the specification change.
-   */
-  MediaSourceDurationTruncatingBuffered: "Setting `MediaSource.duration` below the highest presentation timestamp of any buffered coded frames is deprecated due to specification change. Support for implicit removal of truncated buffered media will be removed in the future. You should instead perform explicit `remove(newDuration, oldDuration)` on all `sourceBuffers`, where `newDuration < oldDuration`.",
   /**
    * @description This warning occurs when the browser requests Web MIDI access as sysex (system exclusive messages) can be allowed via prompt even if the browser did not specifically request it.
    */
@@ -283,12 +275,6 @@ export const DEPRECATIONS_METADATA: Partial<Record<string, DeprecationDescriptor
   "LocalCSSFileExtensionRejected": {
     "milestone": 64
   },
-  "MediaSourceAbortRemove": {
-    "chromeStatusFeature": 6107495151960064
-  },
-  "MediaSourceDurationTruncatingBuffered": {
-    "chromeStatusFeature": 6107495151960064
-  },
   "NoSysexWebMIDIWithoutPermission": {
     "chromeStatusFeature": 5138066234671104,
     "milestone": 82

package/front_end/generated/InspectorBackendCommands.ts

@@ -983,7 +983,7 @@ inspectorBackend.registerEnum("Page.AdFrameExplanation", {ParentIsAd: "ParentIsA
 inspectorBackend.registerEnum("Page.SecureContextType", {Secure: "Secure", SecureLocalhost: "SecureLocalhost", InsecureScheme: "InsecureScheme", InsecureAncestor: "InsecureAncestor"});
 inspectorBackend.registerEnum("Page.CrossOriginIsolatedContextType", {Isolated: "Isolated", NotIsolated: "NotIsolated", NotIsolatedFeatureDisabled: "NotIsolatedFeatureDisabled"});
 inspectorBackend.registerEnum("Page.GatedAPIFeatures", {SharedArrayBuffers: "SharedArrayBuffers", SharedArrayBuffersTransferAllowed: "SharedArrayBuffersTransferAllowed", PerformanceMeasureMemory: "PerformanceMeasureMemory", PerformanceProfile: "PerformanceProfile"});
-inspectorBackend.registerEnum("Page.PermissionsPolicyFeature", {Accelerometer: "accelerometer", AllScreensCapture: "all-screens-capture", AmbientLightSensor: "ambient-light-sensor", AriaNotify: "aria-notify", AttributionReporting: "attribution-reporting", Autoplay: "autoplay", Bluetooth: "bluetooth", BrowsingTopics: "browsing-topics", Camera: "camera", CapturedSurfaceControl: "captured-surface-control", ChDpr: "ch-dpr", ChDeviceMemory: "ch-device-memory", ChDownlink: "ch-downlink", ChEct: "ch-ect", ChPrefersColorScheme: "ch-prefers-color-scheme", ChPrefersReducedMotion: "ch-prefers-reduced-motion", ChPrefersReducedTransparency: "ch-prefers-reduced-transparency", ChRtt: "ch-rtt", ChSaveData: "ch-save-data", ChUa: "ch-ua", ChUaArch: "ch-ua-arch", ChUaBitness: "ch-ua-bitness", ChUaHighEntropyValues: "ch-ua-high-entropy-values", ChUaPlatform: "ch-ua-platform", ChUaModel: "ch-ua-model", ChUaMobile: "ch-ua-mobile", ChUaFormFactors: "ch-ua-form-factors", ChUaFullVersion: "ch-ua-full-version", ChUaFullVersionList: "ch-ua-full-version-list", ChUaPlatformVersion: "ch-ua-platform-version", ChUaWow64: "ch-ua-wow64", ChViewportHeight: "ch-viewport-height", ChViewportWidth: "ch-viewport-width", ChWidth: "ch-width", ClipboardRead: "clipboard-read", ClipboardWrite: "clipboard-write", ComputePressure: "compute-pressure", ControlledFrame: "controlled-frame", CrossOriginIsolated: "cross-origin-isolated", DeferredFetch: "deferred-fetch", DeferredFetchMinimal: "deferred-fetch-minimal", DeviceAttributes: "device-attributes", DigitalCredentialsCreate: "digital-credentials-create", DigitalCredentialsGet: "digital-credentials-get", DirectSockets: "direct-sockets", DirectSocketsMulticast: "direct-sockets-multicast", DirectSocketsPrivate: "direct-sockets-private", DisplayCapture: "display-capture", DocumentDomain: "document-domain", EncryptedMedia: "encrypted-media", ExecutionWhileOutOfViewport: "execution-while-out-of-viewport", ExecutionWhileNotRendered: "execution-while-not-rendered", FencedUnpartitionedStorageRead: "fenced-unpartitioned-storage-read", FocusWithoutUserActivation: "focus-without-user-activation", Fullscreen: "fullscreen", Frobulate: "frobulate", Gamepad: "gamepad", Geolocation: "geolocation", Gyroscope: "gyroscope", Hid: "hid", IdentityCredentialsGet: "identity-credentials-get", IdleDetection: "idle-detection", InterestCohort: "interest-cohort", JoinAdInterestGroup: "join-ad-interest-group", KeyboardMap: "keyboard-map", LanguageDetector: "language-detector", LanguageModel: "language-model", LocalFonts: "local-fonts", LocalNetworkAccess: "local-network-access", Magnetometer: "magnetometer", MediaPlaybackWhileNotVisible: "media-playback-while-not-visible", Microphone: "microphone", Midi: "midi", OnDeviceSpeechRecognition: "on-device-speech-recognition", OtpCredentials: "otp-credentials", Payment: "payment", PictureInPicture: "picture-in-picture", Popins: "popins", PrivateAggregation: "private-aggregation", PrivateStateTokenIssuance: "private-state-token-issuance", PrivateStateTokenRedemption: "private-state-token-redemption", PublickeyCredentialsCreate: "publickey-credentials-create", PublickeyCredentialsGet: "publickey-credentials-get", RecordAdAuctionEvents: "record-ad-auction-events", Rewriter: "rewriter", RunAdAuction: "run-ad-auction", ScreenWakeLock: "screen-wake-lock", Serial: "serial", SharedAutofill: "shared-autofill", SharedStorage: "shared-storage", SharedStorageSelectUrl: "shared-storage-select-url", SmartCard: "smart-card", SpeakerSelection: "speaker-selection", StorageAccess: "storage-access", SubApps: "sub-apps", Summarizer: "summarizer", SyncXhr: "sync-xhr", Translator: "translator", Unload: "unload", Usb: "usb", UsbUnrestricted: "usb-unrestricted", VerticalScroll: "vertical-scroll", WebAppInstallation: "web-app-installation", WebPrinting: "web-printing", WebShare: "web-share", WindowManagement: "window-management", Writer: "writer", XrSpatialTracking: "xr-spatial-tracking"});
+inspectorBackend.registerEnum("Page.PermissionsPolicyFeature", {Accelerometer: "accelerometer", AllScreensCapture: "all-screens-capture", AmbientLightSensor: "ambient-light-sensor", AriaNotify: "aria-notify", AttributionReporting: "attribution-reporting", Autoplay: "autoplay", Bluetooth: "bluetooth", BrowsingTopics: "browsing-topics", Camera: "camera", CapturedSurfaceControl: "captured-surface-control", ChDpr: "ch-dpr", ChDeviceMemory: "ch-device-memory", ChDownlink: "ch-downlink", ChEct: "ch-ect", ChPrefersColorScheme: "ch-prefers-color-scheme", ChPrefersReducedMotion: "ch-prefers-reduced-motion", ChPrefersReducedTransparency: "ch-prefers-reduced-transparency", ChRtt: "ch-rtt", ChSaveData: "ch-save-data", ChUa: "ch-ua", ChUaArch: "ch-ua-arch", ChUaBitness: "ch-ua-bitness", ChUaHighEntropyValues: "ch-ua-high-entropy-values", ChUaPlatform: "ch-ua-platform", ChUaModel: "ch-ua-model", ChUaMobile: "ch-ua-mobile", ChUaFormFactors: "ch-ua-form-factors", ChUaFullVersion: "ch-ua-full-version", ChUaFullVersionList: "ch-ua-full-version-list", ChUaPlatformVersion: "ch-ua-platform-version", ChUaWow64: "ch-ua-wow64", ChViewportHeight: "ch-viewport-height", ChViewportWidth: "ch-viewport-width", ChWidth: "ch-width", ClipboardRead: "clipboard-read", ClipboardWrite: "clipboard-write", ComputePressure: "compute-pressure", ControlledFrame: "controlled-frame", CrossOriginIsolated: "cross-origin-isolated", DeferredFetch: "deferred-fetch", DeferredFetchMinimal: "deferred-fetch-minimal", DeviceAttributes: "device-attributes", DigitalCredentialsCreate: "digital-credentials-create", DigitalCredentialsGet: "digital-credentials-get", DirectSockets: "direct-sockets", DirectSocketsMulticast: "direct-sockets-multicast", DirectSocketsPrivate: "direct-sockets-private", DisplayCapture: "display-capture", DocumentDomain: "document-domain", EncryptedMedia: "encrypted-media", ExecutionWhileOutOfViewport: "execution-while-out-of-viewport", ExecutionWhileNotRendered: "execution-while-not-rendered", FencedUnpartitionedStorageRead: "fenced-unpartitioned-storage-read", FocusWithoutUserActivation: "focus-without-user-activation", Fullscreen: "fullscreen", Frobulate: "frobulate", Gamepad: "gamepad", Geolocation: "geolocation", Gyroscope: "gyroscope", Hid: "hid", IdentityCredentialsGet: "identity-credentials-get", IdleDetection: "idle-detection", InterestCohort: "interest-cohort", JoinAdInterestGroup: "join-ad-interest-group", KeyboardMap: "keyboard-map", LanguageDetector: "language-detector", LanguageModel: "language-model", LocalFonts: "local-fonts", LocalNetworkAccess: "local-network-access", Magnetometer: "magnetometer", MediaPlaybackWhileNotVisible: "media-playback-while-not-visible", Microphone: "microphone", Midi: "midi", OnDeviceSpeechRecognition: "on-device-speech-recognition", OtpCredentials: "otp-credentials", Payment: "payment", PictureInPicture: "picture-in-picture", PrivateAggregation: "private-aggregation", PrivateStateTokenIssuance: "private-state-token-issuance", PrivateStateTokenRedemption: "private-state-token-redemption", PublickeyCredentialsCreate: "publickey-credentials-create", PublickeyCredentialsGet: "publickey-credentials-get", RecordAdAuctionEvents: "record-ad-auction-events", Rewriter: "rewriter", RunAdAuction: "run-ad-auction", ScreenWakeLock: "screen-wake-lock", Serial: "serial", SharedAutofill: "shared-autofill", SharedStorage: "shared-storage", SharedStorageSelectUrl: "shared-storage-select-url", SmartCard: "smart-card", SpeakerSelection: "speaker-selection", StorageAccess: "storage-access", SubApps: "sub-apps", Summarizer: "summarizer", SyncXhr: "sync-xhr", Translator: "translator", Unload: "unload", Usb: "usb", UsbUnrestricted: "usb-unrestricted", VerticalScroll: "vertical-scroll", WebAppInstallation: "web-app-installation", WebPrinting: "web-printing", WebShare: "web-share", WindowManagement: "window-management", Writer: "writer", XrSpatialTracking: "xr-spatial-tracking"});
 inspectorBackend.registerEnum("Page.PermissionsPolicyBlockReason", {Header: "Header", IframeAttribute: "IframeAttribute", InFencedFrameTree: "InFencedFrameTree", InIsolatedApp: "InIsolatedApp"});
 inspectorBackend.registerEnum("Page.OriginTrialTokenStatus", {Success: "Success", NotSupported: "NotSupported", Insecure: "Insecure", Expired: "Expired", WrongOrigin: "WrongOrigin", InvalidSignature: "InvalidSignature", Malformed: "Malformed", WrongVersion: "WrongVersion", FeatureDisabled: "FeatureDisabled", TokenDisabled: "TokenDisabled", FeatureDisabledForUser: "FeatureDisabledForUser", UnknownTrial: "UnknownTrial"});
 inspectorBackend.registerEnum("Page.OriginTrialStatus", {Enabled: "Enabled", ValidTokenNotProvided: "ValidTokenNotProvided", OSNotSupported: "OSNotSupported", TrialNotAllowed: "TrialNotAllowed"});

package/front_end/generated/SupportedCSSProperties.js

@@ -419,10 +419,10 @@ export const generatedProperties = [
    "column-height",
    "column-rule-break",
    "column-rule-color",
-   "column-rule-edge-end-outset",
-   "column-rule-edge-start-outset",
-   "column-rule-interior-end-outset",
-   "column-rule-interior-start-outset",
+   "column-rule-edge-end-inset",
+   "column-rule-edge-start-inset",
+   "column-rule-interior-end-inset",
+   "column-rule-interior-start-inset",
    "column-rule-style",
    "column-rule-visibility-items",
    "column-rule-width",
@@ -642,10 +642,10 @@ export const generatedProperties = [
    "row-gap",
    "row-rule-break",
    "row-rule-color",
-   "row-rule-edge-end-outset",
-   "row-rule-edge-start-outset",
-   "row-rule-interior-end-outset",
-   "row-rule-interior-start-outset",
+   "row-rule-edge-end-inset",
+   "row-rule-edge-start-inset",
+   "row-rule-interior-end-inset",
+   "row-rule-interior-start-inset",
    "row-rule-style",
    "row-rule-visibility-items",
    "row-rule-width",
@@ -1729,28 +1729,28 @@ export const generatedProperties = [
  },
  {
   "inherited": false,
-  "name": "column-rule-edge-end-outset"
+  "name": "column-rule-edge-end-inset"
  },
  {
   "inherited": false,
-  "name": "column-rule-edge-start-outset"
+  "name": "column-rule-edge-start-inset"
  },
  {
-  "inherited": false,
-  "name": "column-rule-interior-end-outset"
+  "longhands": [
+   "column-rule-edge-start-inset",
+   "column-rule-edge-end-inset",
+   "column-rule-interior-start-inset",
+   "column-rule-interior-end-inset"
+  ],
+  "name": "column-rule-inset"
  },
  {
   "inherited": false,
-  "name": "column-rule-interior-start-outset"
+  "name": "column-rule-interior-end-inset"
  },
  {
-  "longhands": [
-   "column-rule-edge-start-outset",
-   "column-rule-edge-end-outset",
-   "column-rule-interior-start-outset",
-   "column-rule-interior-end-outset"
-  ],
-  "name": "column-rule-outset"
+  "inherited": false,
+  "name": "column-rule-interior-start-inset"
  },
  {
   "keywords": [
@@ -3738,28 +3738,28 @@ export const generatedProperties = [
  },
  {
   "inherited": false,
-  "name": "row-rule-edge-end-outset"
+  "name": "row-rule-edge-end-inset"
  },
  {
   "inherited": false,
-  "name": "row-rule-edge-start-outset"
+  "name": "row-rule-edge-start-inset"
  },
  {
-  "inherited": false,
-  "name": "row-rule-interior-end-outset"
+  "longhands": [
+   "row-rule-edge-start-inset",
+   "row-rule-edge-end-inset",
+   "row-rule-interior-start-inset",
+   "row-rule-interior-end-inset"
+  ],
+  "name": "row-rule-inset"
  },
  {
   "inherited": false,
-  "name": "row-rule-interior-start-outset"
+  "name": "row-rule-interior-end-inset"
  },
  {
-  "longhands": [
-   "row-rule-edge-start-outset",
-   "row-rule-edge-end-outset",
-   "row-rule-interior-start-outset",
-   "row-rule-interior-end-outset"
-  ],
-  "name": "row-rule-outset"
+  "inherited": false,
+  "name": "row-rule-interior-start-inset"
  },
  {
   "keywords": [
@@ -3847,16 +3847,16 @@ export const generatedProperties = [
  },
  {
   "longhands": [
-   "row-rule-edge-start-outset",
-   "row-rule-edge-end-outset",
-   "row-rule-interior-start-outset",
-   "row-rule-interior-end-outset",
-   "column-rule-edge-start-outset",
-   "column-rule-edge-end-outset",
-   "column-rule-interior-start-outset",
-   "column-rule-interior-end-outset"
-  ],
-  "name": "rule-outset"
+   "row-rule-edge-start-inset",
+   "row-rule-edge-end-inset",
+   "row-rule-interior-start-inset",
+   "row-rule-interior-end-inset",
+   "column-rule-edge-start-inset",
+   "column-rule-edge-end-inset",
+   "column-rule-interior-start-inset",
+   "column-rule-interior-end-inset"
+  ],
+  "name": "rule-inset"
  },
  {
   "longhands": [

package/front_end/generated/protocol.ts

@@ -13705,7 +13705,6 @@ export namespace Page {
     OtpCredentials = 'otp-credentials',
     Payment = 'payment',
     PictureInPicture = 'picture-in-picture',
-    Popins = 'popins',
     PrivateAggregation = 'private-aggregation',
     PrivateStateTokenIssuance = 'private-state-token-issuance',
     PrivateStateTokenRedemption = 'private-state-token-redemption',

package/front_end/models/ai_assistance/BuiltInAi.ts

@@ -185,13 +185,19 @@ export class BuiltInAi {
   async * getConsoleInsight(prompt: string, abortController: AbortController): AsyncGenerator<string> {
     // Clone the session to start a fresh conversation for each answer. Otherwise
     // previous dialog would pollute the context resulting in worse answers.
-    const session = await this.#consoleInsightsSession.clone();
-    const stream = session.promptStreaming(prompt, {
-      signal: abortController.signal,
-    });
-    for await (const chunk of stream) {
-      yield chunk;
+    let session: LanguageModel|null = null;
+    try {
+      session = await this.#consoleInsightsSession.clone();
+      const stream = session.promptStreaming(prompt, {
+        signal: abortController.signal,
+      });
+      for await (const chunk of stream) {
+        yield chunk;
+      }
+    } finally {
+      if (session) {
+        session.destroy();
+      }
     }
-    session.destroy();
   }
 }