chrome-devtools-frontend 1.0.1519267 → 1.0.1520535

package/front_end/core/host/GdpClient.ts

@@ -23,7 +23,7 @@ export enum SubscriptionTier {
   PRO_MONTHLY = 'SUBSCRIPTION_TIER_PRO_MONTHLY',
 }
 
-enum EligibilityStatus {
+export enum EligibilityStatus {
   ELIGIBLE = 'ELIGIBLE',
   NOT_ELIGIBLE = 'NOT_ELIGIBLE',
 }
@@ -68,6 +68,11 @@ export interface Profile {
   };
 }
 
+interface InitializeResult {
+  hasProfile: boolean;
+  isEligible: boolean;
+}
+
 // The `batchGet` awards endpoint returns badge names with an
 // obfuscated user ID (e.g., `profiles/12345/awards/badge-name`).
 // This function normalizes them to use `me` instead of the ID
@@ -114,9 +119,20 @@ export class GdpClient {
     return gdpClientInstance;
   }
 
-  async initialize(): Promise<void> {
-    void this.getProfile();
-    void this.checkEligibility();
+  async initialize(): Promise<InitializeResult> {
+    const profile = await this.getProfile();
+    if (profile) {
+      return {
+        hasProfile: true,
+        isEligible: true,
+      };
+    }
+
+    const isEligible = await this.isEligibleToCreateProfile();
+    return {
+      hasProfile: false,
+      isEligible,
+    };
   }
 
   async getProfile(): Promise<Profile|null> {
@@ -129,7 +145,12 @@ export class GdpClient {
       path: '/v1beta1/profile:get',
       method: 'GET',
     });
-    return await this.#cachedProfilePromise;
+
+    const profile = await this.#cachedProfilePromise;
+    if (profile) {
+      this.#cachedEligibilityPromise = Promise.resolve({createProfile: EligibilityStatus.ELIGIBLE});
+    }
+    return profile;
   }
 
   async checkEligibility(): Promise<CheckElibigilityResponse|null> {

package/front_end/core/sdk/NetworkManager.ts

@@ -597,6 +597,7 @@ export class NetworkDispatcher implements ProtocolProxyApi.NetworkDispatcher {
     networkRequest.mixedContentType = request.mixedContentType || Protocol.Security.MixedContentType.None;
     networkRequest.setReferrerPolicy(request.referrerPolicy);
     networkRequest.setIsSameSite(request.isSameSite || false);
+    networkRequest.setIsAdRelated(request.isAdRelated || false);
   }
 
   private updateNetworkRequestWithResponse(networkRequest: NetworkRequest, response: Protocol.Network.Response): void {

package/front_end/core/sdk/NetworkRequest.ts

@@ -320,6 +320,7 @@ export class NetworkRequest extends Common.ObjectWrapper.ObjectWrapper<EventType
   directSocketInfo?: DirectSocketInfo;
   readonly #directSocketChunks: DirectSocketChunk[] = [];
   #isIpProtectionUsed: boolean;
+  #isAdRelated: boolean;
 
   constructor(
       requestId: string,
@@ -342,6 +343,7 @@ export class NetworkRequest extends Common.ObjectWrapper.ObjectWrapper<EventType
     this.#initiator = initiator;
     this.#hasUserGesture = hasUserGesture;
     this.#isIpProtectionUsed = false;
+    this.#isAdRelated = false;
   }
 
   static create(
@@ -1850,6 +1852,14 @@ export class NetworkRequest extends Common.ObjectWrapper.ObjectWrapper<EventType
     return this.#isIpProtectionUsed;
   }
 
+  setIsAdRelated(isAdRelated: boolean): void {
+    this.#isAdRelated = isAdRelated;
+  }
+
+  isAdRelated(): boolean {
+    return this.#isAdRelated;
+  }
+
   getAssociatedData(key: string): object|null {
     return this.#associatedData.get(key) || null;
   }

package/front_end/entrypoints/main/MainImpl.ts

@@ -519,7 +519,12 @@ export class MainImpl {
 
     // Initialize `GDPClient` and `UserBadges` for Google Developer Program integration
     if (Host.GdpClient.isGdpProfilesAvailable()) {
-      void Host.GdpClient.GdpClient.instance().initialize();
+      void Host.GdpClient.GdpClient.instance().initialize().then(({hasProfile, isEligible}) => {
+        const contextString = hasProfile ? 'has-profile' :
+            isEligible                   ? 'no-profile-and-eligible' :
+                                           'no-profile-and-not-eligible';
+        void VisualLogging.logFunctionCall('gdp-client-initialize', contextString);
+      });
       void Badges.UserBadges.instance().initialize();
       Badges.UserBadges.instance().addEventListener(Badges.Events.BADGE_TRIGGERED, async ev => {
         loadedPanelCommonModule ??= await import('../../panels/common/common.js') as typeof PanelCommon;

package/front_end/entrypoints/main/main-meta.ts

@@ -188,9 +188,9 @@ const UIStrings = {
   browserLanguage: 'Browser UI language',
   /**
    * @description Label for a checkbox in the settings UI. Allows developers to opt-in/opt-out
-   * of syncing DevTools settings via Chrome Sync.
+   * of saving settings to their Google account.
    */
-  enableSync: 'Enable settings sync',
+  saveSettings: 'Save `DevTools` settings to your `Google` account',
   /**
    * @description Label for a checkbox in the settings UI. Allows developers to opt-in/opt-out
    * of receiving Google Developer Program (GDP) badges based on their activity in Chrome DevTools.
@@ -789,7 +789,7 @@ Common.Settings.registerSettingExtension({
   // This name must be kept in sync with DevToolsSettings::kSyncDevToolsPreferencesFrontendName.
   settingName: 'sync-preferences',
   settingType: Common.Settings.SettingType.BOOLEAN,
-  title: i18nLazyString(UIStrings.enableSync),
+  title: i18nLazyString(UIStrings.saveSettings),
   defaultValue: false,
   reloadRequired: true,
 });

package/front_end/models/ai_assistance/agents/PerformanceAgent.ts

@@ -136,27 +136,13 @@ When referring to a trace event that has a corresponding \`eventKey\`, annotate
 When asking the user to make a choice between multiple options, output a list of choices at the end of your text response. The format is \`SUGGESTIONS: ["suggestion1", "suggestion2", "suggestion3"]\`. This MUST start on a newline, and be a single line.
 `;
 
-const callFrameDataFormatDescription = `Each call frame is presented in the following format:
+const extraPreambleWhenFreshTrace = `Additional notes:
 
-'id;name;duration;selfTime;urlIndex;childRange;[S]'
-
-Key definitions:
-
-* id: A unique numerical identifier for the call frame. Never mention this id in the output to the user.
-* name: A concise string describing the call frame (e.g., 'Evaluate Script', 'render', 'fetchData').
-* duration: The total execution time of the call frame, including its children.
-* selfTime: The time spent directly within the call frame, excluding its children's execution.
-* urlIndex: Index referencing the "All URLs" list. Empty if no specific script URL is associated.
-* childRange: Specifies the direct children of this node using their IDs. If empty ('' or 'S' at the end), the node has no children. If a single number (e.g., '4'), the node has one child with that ID. If in the format 'firstId-lastId' (e.g., '4-5'), it indicates a consecutive range of child IDs from 'firstId' to 'lastId', inclusive.
-* S: _Optional_. The letter 'S' terminates the line if that call frame was selected by the user.
-
-Example Call Tree:
-
-1;main;500;100;;
-2;update;200;50;;3
-3;animate;150;20;0;4-5;S
-4;calculatePosition;80;80;;
-5;applyStyles;50;50;;
+When referring to an element for which you know the nodeId, annotate your output using markdown link syntax:
+- For example, if nodeId is 23: [LCP element](#node-23)
+- This link will reveal the element in the Elements panel
+- Never mention node or nodeId when referring to the element, and especially not in the link text.
+- When referring to the LCP, it's useful to also mention what the LCP element is via its nodeId. Use the markdown link syntax to do so.
 `;
 
 enum ScorePriority {
@@ -188,7 +174,7 @@ export class PerformanceTraceContext extends ConversationContext<AgentFocus> {
   }
 
   override getOrigin(): string {
-    const {min, max} = this.#focus.data.parsedTrace.data.Meta.traceBounds;
+    const {min, max} = this.#focus.parsedTrace.data.Meta.traceBounds;
     return `trace-${min}-${max}`;
   }
 
@@ -197,7 +183,7 @@ export class PerformanceTraceContext extends ConversationContext<AgentFocus> {
   }
 
   override getTitle(): string {
-    const focus = this.#focus.data;
+    const focus = this.#focus;
 
     let url = focus.insightSet?.url;
     if (!url) {
@@ -208,6 +194,9 @@ export class PerformanceTraceContext extends ConversationContext<AgentFocus> {
     if (focus.insight) {
       parts.push(focus.insight.title);
     }
+    if (focus.event) {
+      parts.push(Trace.Name.forEntry(focus.event));
+    }
     if (focus.callTree) {
       const node = focus.callTree.selectedNode ?? focus.callTree.rootNode;
       parts.push(Trace.Name.forEntry(node.event));
@@ -220,9 +209,9 @@ export class PerformanceTraceContext extends ConversationContext<AgentFocus> {
    * "Ask AI".
    */
   override async getSuggestions(): Promise<ConversationSuggestions|undefined> {
-    const data = this.#focus.data;
+    const focus = this.#focus;
 
-    if (data.callTree) {
+    if (focus.callTree) {
       return [
         {title: 'What\'s the purpose of this work?', jslogContext: 'performance-default'},
         {title: 'Where is time being spent?', jslogContext: 'performance-default'},
@@ -230,17 +219,17 @@ export class PerformanceTraceContext extends ConversationContext<AgentFocus> {
       ];
     }
 
-    if (data.insight) {
-      return new PerformanceInsightFormatter(this.#focus, data.insight).getSuggestions();
+    if (focus.insight) {
+      return new PerformanceInsightFormatter(focus, focus.insight).getSuggestions();
     }
 
     const suggestions: ConversationSuggestions =
         [{title: 'What performance issues exist with my page?', jslogContext: 'performance-default'}];
 
-    if (data.insightSet) {
-      const lcp = data.insightSet ? Trace.Insights.Common.getLCP(data.insightSet) : null;
-      const cls = data.insightSet ? Trace.Insights.Common.getCLS(data.insightSet) : null;
-      const inp = data.insightSet ? Trace.Insights.Common.getINP(data.insightSet) : null;
+    if (focus.insightSet) {
+      const lcp = focus.insightSet ? Trace.Insights.Common.getLCP(focus.insightSet) : null;
+      const cls = focus.insightSet ? Trace.Insights.Common.getCLS(focus.insightSet) : null;
+      const inp = focus.insightSet ? Trace.Insights.Common.getINP(focus.insightSet) : null;
 
       const ModelHandlers = Trace.Handlers.ModelHandlers;
       const GOOD = Trace.Handlers.ModelHandlers.PageLoadMetrics.ScoreClassification.GOOD;
@@ -257,9 +246,9 @@ export class PerformanceTraceContext extends ConversationContext<AgentFocus> {
 
       // Add up to 3 suggestions from the top failing insights.
       const top3FailingInsightSuggestions =
-          Object.values(data.insightSet.model)
+          Object.values(focus.insightSet.model)
               .filter(model => model.state !== 'pass')
-              .map(model => new PerformanceInsightFormatter(this.#focus, model).getSuggestions().at(-1))
+              .map(model => new PerformanceInsightFormatter(focus, model).getSuggestions().at(-1))
               .filter(suggestion => !!suggestion)
               .slice(0, 3);
       suggestions.push(...top3FailingInsightSuggestions);
@@ -278,6 +267,7 @@ const MAX_FUNCTION_RESULT_BYTE_LENGTH = 16384 * 4;
  */
 export class PerformanceAgent extends AiAgent<AgentFocus> {
   #formatter: PerformanceTraceFormatter|null = null;
+  #lastEventForEnhancedQuery: Trace.Types.Events.Event|undefined;
   #lastInsightForEnhancedQuery: Trace.Insights.Types.InsightModel|undefined;
   #hasShownAnalyzeTraceContext = false;
 
@@ -298,12 +288,16 @@ export class PerformanceAgent extends AiAgent<AgentFocus> {
     text: extraPreambleWhenNotExternal,
     metadata: {source: 'devtools', score: ScorePriority.CRITICAL}
   };
+  #freshTraceExtraPreambleFact: Host.AidaClient.RequestFact = {
+    text: extraPreambleWhenFreshTrace,
+    metadata: {source: 'devtools', score: ScorePriority.CRITICAL}
+  };
   #networkDataDescriptionFact: Host.AidaClient.RequestFact = {
     text: PerformanceTraceFormatter.networkDataFormatDescription,
     metadata: {source: 'devtools', score: ScorePriority.CRITICAL}
   };
   #callFrameDataDescriptionFact: Host.AidaClient.RequestFact = {
-    text: callFrameDataFormatDescription,
+    text: PerformanceTraceFormatter.callFrameDataFormatDescription,
     metadata: {source: 'devtools', score: ScorePriority.CRITICAL}
   };
   #traceFacts: Host.AidaClient.RequestFact[] = [];
@@ -371,10 +365,6 @@ export class PerformanceAgent extends AiAgent<AgentFocus> {
    *   1. go to paulirish.com, record a trace
    *   2. say "What performance issues exist with my page?"
    *   3. then say "images"
-   *
-   * TODO(cjamcl): reduce the reliance on this by making sure all URL references
-   * (such as the insight formatters) add the "eventKey" as a suffix, just like all
-   * other events.
    */
   #parseForKnownUrls(response: string): string {
     const focus = this.context?.getItem();
@@ -403,8 +393,7 @@ export class PerformanceAgent extends AiAgent<AgentFocus> {
         return match;
       }
 
-      const request =
-          focus.data.parsedTrace.data.NetworkRequests.byTime.find(request => request.args.data.url === urlText);
+      const request = focus.parsedTrace.data.NetworkRequests.byTime.find(request => request.args.data.url === urlText);
       if (!request) {
         return match;
       }
@@ -451,13 +440,21 @@ export class PerformanceAgent extends AiAgent<AgentFocus> {
     const focus = context.getItem();
     const selected: string[] = [];
 
-    if (focus.data.callTree) {
+    if (focus.event) {
+      const includeEventInfo = focus.event !== this.#lastEventForEnhancedQuery;
+      this.#lastEventForEnhancedQuery = focus.event;
+      if (includeEventInfo) {
+        selected.push(`User selected an event ${this.#formatter?.serializeEvent(focus.event)}.\n\n`);
+      }
+    }
+
+    if (focus.callTree) {
       // If this is a followup chat about the same call tree, don't include the call tree serialization again.
       // We don't need to repeat it and we'd rather have more the context window space.
       let contextString = '';
-      if (!this.#callTreeContextSet.has(focus.data.callTree)) {
-        contextString = focus.data.callTree.serialize();
-        this.#callTreeContextSet.add(focus.data.callTree);
+      if (!this.#callTreeContextSet.has(focus.callTree)) {
+        contextString = focus.callTree.serialize();
+        this.#callTreeContextSet.add(focus.callTree);
       }
 
       if (contextString) {
@@ -465,17 +462,17 @@ export class PerformanceAgent extends AiAgent<AgentFocus> {
       }
     }
 
-    if (focus.data.insight) {
+    if (focus.insight) {
       // We only need to add Insight info to a prompt when the context changes. For example:
       // User clicks Insight A. We need to send info on Insight A with the prompt.
       // User asks follow up question. We do not need to resend Insight A with the prompt.
       // User clicks Insight B. We now need to send info on Insight B with the prompt.
       // User clicks Insight A. We should resend the Insight info with the prompt.
-      const includeInsightInfo = focus.data.insight !== this.#lastInsightForEnhancedQuery;
-      this.#lastInsightForEnhancedQuery = focus.data.insight;
+      const includeInsightInfo = focus.insight !== this.#lastInsightForEnhancedQuery;
+      this.#lastInsightForEnhancedQuery = focus.insight;
 
       if (includeInsightInfo) {
-        selected.push(`User selected the ${focus.data.insight.insightKey} insight.\n\n`);
+        selected.push(`User selected the ${focus.insight.insightKey} insight.\n\n`);
       }
     }
 
@@ -587,6 +584,11 @@ export class PerformanceAgent extends AiAgent<AgentFocus> {
       this.addFact(this.#notExternalExtraPreambleFact);
     }
 
+    const isFresh = Tracing.FreshRecording.Tracker.instance().recordingIsFresh(focus.parsedTrace);
+    if (isFresh) {
+      this.addFact(this.#freshTraceExtraPreambleFact);
+    }
+
     this.addFact(this.#callFrameDataDescriptionFact);
     this.addFact(this.#networkDataDescriptionFact);
 
@@ -623,7 +625,7 @@ export class PerformanceAgent extends AiAgent<AgentFocus> {
 
   #declareFunctions(context: PerformanceTraceContext): void {
     const focus = context.getItem();
-    const {parsedTrace, insightSet} = focus.data;
+    const {parsedTrace, insightSet} = focus;
 
     this.declareFunction<{insightName: string}, {details: string}>('getInsightDetails', {
       description:

package/front_end/models/ai_assistance/agents/PerformanceAnnotationsAgent.ts

@@ -116,11 +116,11 @@ export class PerformanceAnnotationsAgent extends AiAgent<AgentFocus> {
     }
 
     const focus = context.getItem();
-    if (!focus.data.callTree) {
+    if (!focus.callTree) {
       throw new Error('unexpected context');
     }
 
-    const callTree = focus.data.callTree;
+    const callTree = focus.callTree;
 
     yield {
       type: ResponseType.CONTEXT,
@@ -140,11 +140,11 @@ export class PerformanceAnnotationsAgent extends AiAgent<AgentFocus> {
     }
 
     const focus = context.getItem();
-    if (!focus.data.callTree) {
+    if (!focus.callTree) {
       throw new Error('unexpected context');
     }
 
-    const callTree = focus.data.callTree;
+    const callTree = focus.callTree;
     const contextString = callTree.serialize();
     return `${contextString}\n\n# User request\n\n${query}`;
   }