chrome-devtools-frontend 1.0.1519267 → 1.0.1520535

package/front_end/third_party/puppeteer/package/src/util/Function.ts

@@ -30,7 +30,7 @@ export const createFunction = (
 export function stringifyFunction(fn: (...args: never) => unknown): string {
   let value = fn.toString();
   if (
-    value.match(/^(async )*function /) ||
+    value.match(/^(async )*function(\(|\s)/) ||
     value.match(/^(async )*function\s*\*\s*/)
   ) {
     return value;

package/front_end/tsconfig.json

@@ -3,7 +3,18 @@
   "compilerOptions": {
     "allowUmdGlobalAccess": true,
     "outDir": "ignored",
-    "lib": ["esnext", "dom", "dom.iterable", "webworker", "webworker.iterable"],
+    "target": "ES2023",
+    "lib": [
+      "ES2023",
+      "ES2024.Promise",
+      "ESNext.Iterator",
+      "ESNext.Collection",
+      "ESNext.Array",
+      "dom",
+      "dom.iterable",
+      "webworker",
+      "webworker.iterable"
+    ],
     "plugins": [
       {
         "name": "ts-lit-plugin",

package/front_end/ui/legacy/InspectorView.ts

@@ -18,7 +18,7 @@ import * as ARIAUtils from './ARIAUtils.js';
 import type {Context} from './Context.js';
 import type {ContextMenu} from './ContextMenu.js';
 import {Dialog} from './Dialog.js';
-import {DockController, DockState} from './DockController.js';
+import {DockController, DockState, Events as DockControllerEvents} from './DockController.js';
 import {GlassPane} from './GlassPane.js';
 import {Infobar, Type as InfobarType} from './Infobar.js';
 import {KeyboardShortcut} from './KeyboardShortcut.js';
@@ -127,8 +127,20 @@ export enum DrawerOrientation {
   UNSET = 'unset',
 }
 
+export enum DockMode {
+  BOTTOM = 'bottom',
+  SIDE = 'side',  // For LEFT and RIGHT
+  UNDOCKED = 'undocked',
+}
+
+export interface DrawerOrientationByDockMode {
+  [DockMode.BOTTOM]: DrawerOrientation;
+  [DockMode.SIDE]: DrawerOrientation;
+  [DockMode.UNDOCKED]: DrawerOrientation;
+}
+
 export class InspectorView extends VBox implements ViewLocationResolver {
-  private readonly drawerOrientationSetting: Common.Settings.Setting<DrawerOrientation>;
+  private readonly drawerOrientationByDockSetting: Common.Settings.Setting<DrawerOrientationByDockMode>;
   private readonly drawerSplitWidget: SplitWidget;
   private readonly tabDelegate: InspectorViewTabDelegate;
   private readonly drawerTabbedLocation: TabbedViewLocation;
@@ -151,9 +163,14 @@ export class InspectorView extends VBox implements ViewLocationResolver {
     this.setMinimumSize(MIN_INSPECTOR_WIDTH_HORIZONTAL_DRAWER, MIN_INSPECTOR_HEIGHT);
 
     // DevTools sidebar is a vertical split of main tab bar panels and a drawer.
-    this.drawerOrientationSetting =
-        Common.Settings.Settings.instance().createSetting('inspector.drawer-orientation', DrawerOrientation.UNSET);
-    const isVertical = this.drawerOrientationSetting.get() === DrawerOrientation.VERTICAL;
+    this.drawerOrientationByDockSetting =
+        Common.Settings.Settings.instance().createSetting('inspector.drawer-orientation-by-dock-mode', {
+          [DockMode.BOTTOM]: DrawerOrientation.UNSET,
+          [DockMode.SIDE]: DrawerOrientation.UNSET,
+          [DockMode.UNDOCKED]: DrawerOrientation.UNSET,
+        });
+    const initialOrientation = this.#getOrientationForDockMode();
+    const isVertical = initialOrientation === DrawerOrientation.VERTICAL;
     this.drawerSplitWidget = new SplitWidget(isVertical, true, 'inspector.drawer-split-view-state', 200, 200);
     this.drawerSplitWidget.hideSidebar();
     this.drawerSplitWidget.enableShowModeSaving();
@@ -285,6 +302,50 @@ export class InspectorView extends VBox implements ViewLocationResolver {
     inspectorViewInstance = null;
   }
 
+  onDockSideChangedHandledForTest(): void {
+  }
+
+  #onDockSideChanged(): void {
+    if (!this.drawerVisible()) {
+      this.onDockSideChangedHandledForTest();
+      return;
+    }
+    const newOrientation = this.#getOrientationForDockMode();
+    this.#applyOrientation(newOrientation);
+    this.onDockSideChangedHandledForTest();
+  }
+
+  #getDockMode(): DockMode {
+    const dockSide = DockController.instance().dockSide();
+    if (dockSide === DockState.BOTTOM) {
+      return DockMode.BOTTOM;
+    }
+    if (dockSide === DockState.UNDOCKED) {
+      return DockMode.UNDOCKED;
+    }
+
+    return DockMode.SIDE;
+  }
+
+  #getOrientationForDockMode(): Omit<DrawerOrientation, DrawerOrientation.UNSET> {
+    const dockMode = this.#getDockMode();
+    const orientationSetting = this.drawerOrientationByDockSetting.get();
+
+    let orientation = orientationSetting[dockMode];
+    if (orientation === DrawerOrientation.UNSET) {
+      // Apply defaults: horizontal for side-dock, vertical for bottom-dock.
+      orientation = dockMode === DockMode.BOTTOM ? DrawerOrientation.VERTICAL : DrawerOrientation.HORIZONTAL;
+    }
+    return orientation;
+  }
+
+  #applyOrientation(orientation: Omit<DrawerOrientation, DrawerOrientation.UNSET>): void {
+    const isVertical = orientation === DrawerOrientation.VERTICAL;
+    this.#toggleOrientationButton.setGlyph(isVertical ? 'dock-bottom' : 'dock-right');
+    this.drawerSplitWidget.setVertical(isVertical);
+    this.setDrawerRelatedMinimumSizes();
+  }
+
   #observedResize(): void {
     const rect = this.element.getBoundingClientRect();
     this.element.style.setProperty('--devtools-window-left', `${rect.left}px`);
@@ -299,11 +360,15 @@ export class InspectorView extends VBox implements ViewLocationResolver {
     this.#resizeObserver.observe(this.element);
     this.#observedResize();
     this.element.ownerDocument.addEventListener('keydown', this.keyDownBound, false);
+    DockController.instance().addEventListener(DockControllerEvents.DOCK_SIDE_CHANGED, this.#onDockSideChanged, this);
+    this.#onDockSideChanged();
   }
 
   override willHide(): void {
     this.#resizeObserver.unobserve(this.element);
     this.element.ownerDocument.removeEventListener('keydown', this.keyDownBound, false);
+    DockController.instance().removeEventListener(
+        DockControllerEvents.DOCK_SIDE_CHANGED, this.#onDockSideChanged, this);
   }
 
   resolveLocation(locationName: string): ViewLocation|null {
@@ -421,21 +486,29 @@ export class InspectorView extends VBox implements ViewLocationResolver {
     if (!this.drawerTabbedPane.isShowing()) {
       return;
     }
-    let drawerWillBeVertical: boolean;
+
+    const dockMode = this.#getDockMode();
+    const currentSettings = this.drawerOrientationByDockSetting.get();
+
+    let newOrientation: Omit<DrawerOrientation, DrawerOrientation.UNSET>;
     if (force) {
-      drawerWillBeVertical = force === DrawerOrientation.VERTICAL;
+      newOrientation = force;
     } else {
-      drawerWillBeVertical = !this.drawerSplitWidget.isVertical();
+      const currentOrientation = this.#getOrientationForDockMode();
+      newOrientation =
+          currentOrientation === DrawerOrientation.VERTICAL ? DrawerOrientation.HORIZONTAL : DrawerOrientation.VERTICAL;
     }
 
-    this.drawerOrientationSetting.set(drawerWillBeVertical ? DrawerOrientation.VERTICAL : DrawerOrientation.HORIZONTAL);
-    this.#toggleOrientationButton.setGlyph(drawerWillBeVertical ? 'dock-bottom' : 'dock-right');
-    this.drawerSplitWidget.setVertical(drawerWillBeVertical);
-    this.setDrawerRelatedMinimumSizes();
+    currentSettings[dockMode] = newOrientation as DrawerOrientation;
+    this.drawerOrientationByDockSetting.set(currentSettings);
+
+    this.#applyOrientation(newOrientation);
   }
 
   isUserExplicitlyUpdatedDrawerOrientation(): boolean {
-    return this.drawerOrientationSetting.get() !== DrawerOrientation.UNSET;
+    const orientationSetting = this.drawerOrientationByDockSetting.get();
+    const dockMode = this.#getDockMode();
+    return orientationSetting[dockMode] !== DrawerOrientation.UNSET;
   }
 
   setDrawerRelatedMinimumSizes(): void {

package/front_end/ui/legacy/TabbedPane.ts

@@ -326,6 +326,8 @@ export class TabbedPane extends Common.ObjectWrapper.eventMixin<EventTypes, type
       return false;
     }
 
+    this.lastSelectedOverflowTab = tab;
+
     const eventData: EventData = {
       prevTabId: this.currentTab ? this.currentTab.id : undefined,
       tabId: id,
@@ -676,7 +678,6 @@ export class TabbedPane extends Common.ObjectWrapper.eventMixin<EventTypes, type
   }
 
   private dropDownMenuItemSelected(tab: TabbedPaneTab): void {
-    this.lastSelectedOverflowTab = tab;
     this.selectTab(tab.id, true, true);
   }
 

package/front_end/ui/visual_logging/KnownContextValues.ts

@@ -1700,6 +1700,7 @@ export const knownContextValues = new Set([
   'gap-rule-overlap',
   'gap-rule-paint-order',
   'garamond',
+  'gdp-client-initialize',
   'gdp-profile',
   'gdp-sign-up-dialog',
   'gdp.ai-conversation-count',
@@ -1754,6 +1755,7 @@ export const knownContextValues = new Set([
   'hardware-concurrency-toggle',
   'has-cross-site-ancestor',
   'has-overrides',
+  'has-profile',
   'has-touch',
   'hashchange',
   'he',
@@ -1901,6 +1903,7 @@ export const knownContextValues = new Set([
   'inspector-main.reload',
   'inspector-stylesheet',
   'inspector.drawer-orientation',
+  'inspector.drawer-orientation-by-dock-mode',
   'installability',
   'installing-entry-inspect',
   'instance-id',
@@ -1932,6 +1935,7 @@ export const knownContextValues = new Set([
   'invert-filter',
   'ip-protection',
   'is',
+  'is-ad-related',
   'is-landscape',
   'is-mobile',
   'is-resident-credential',
@@ -2643,6 +2647,8 @@ export const knownContextValues = new Set([
   'no',
   'no-agent-entrypoint',
   'no-override',
+  'no-profile-and-eligible',
+  'no-profile-and-not-eligible',
   'no-throttling',
   'node',
   'node-connection',

package/front_end/ui/visual_logging/LoggingEvents.ts

@@ -61,7 +61,7 @@ export const logClick = (throttler: Common.Throttler.Throttler) => (
     Host.InspectorFrontendHost.InspectorFrontendHostInstance.recordClick(clickEvent);
     processEventForDebugging(
         'Click', loggingState, {mouseButton: clickEvent.mouseButton, doubleClick: clickEvent.doubleClick});
-  });
+  }, Common.Throttler.Scheduling.DELAYED);
 };
 
 export const logHover = (throttler: Common.Throttler.Throttler) => async (event: Event) => {

package/package.json

@@ -102,5 +102,5 @@
       "@eslint/core": "0.15.1"
     }
   },
-  "version": "1.0.1519267"
+  "version": "1.0.1520535"
 }