chrome-devtools-frontend 1.0.1514545 → 1.0.1515796

package/front_end/panels/common/GdpSignUpDialog.ts

@@ -19,10 +19,6 @@ import * as VisualLogging from '../../ui/visual_logging/visual_logging.js';
 import styles from './gdpSignUpDialog.css.js';
 
 const UIStrings = {
-  /**
-   * @description Heading of the Google Developer Program sign up dialog.
-   */
-  gdpSignUp: 'Google Developer Program',
   /**
    * @description Aria label for the Google Developer Program sign up dialog
    */
@@ -43,8 +39,7 @@ const UIStrings = {
   /**
    * @description Body for the first section of the GDP sign up dialog.
    */
-  designedForSuccessBody:
-      'Grow your skills, build with AI, and receive badges you can showcase in your developer profile',
+  designedForSuccessBody: 'Grow your skills, build with AI, and earn badges you can showcase in your developer profile',
   /**
    * @description Title for the second section of the GDP sign up dialog.
    */
@@ -52,23 +47,32 @@ const UIStrings = {
   /**
    * @description Body for the second section of the GDP sign up dialog.
    */
-  keepUpdatedBody: 'The latest DevTools features, event invites, and tailored insights directly in your inbox',
+  keepUpdatedBody: 'The latest DevTools features, event invites, and tailored insights land directly in your inbox',
   /**
    * @description Title for the third section of the GDP sign up dialog.
    */
-  thingsToConsider: 'Things to consider',
+  tailorProfile: 'Tailor your profile',
+  /**
+   * @description Body for the third section of the GDP sign up dialog.
+   */
+  tailorProfileBody:
+      'The name on your Google Account and your interests will be used in your Google Developer Profile. Your name may appear where you contribute and can be changed at any time.',
   /**
    * @description Body for the third section of the GDP sign up dialog.
    * @example {Content Policy} PH1
    * @example {Terms of Service} PH2
    * @example {Privacy Policy} PH3
    */
-  thingsToConsiderBody:
-      'By creating a Developer Profile, you agree to the {PH1}. Google’s {PH2} and {PH3} apply to your use of this service. The name on your Google Account and your interests will be used in your Google Developer Profile. Your name may appear where you contribute and can be changed at any time.',
+  tailorProfileBodyDisclaimer:
+      'By creating a Developer Profile, you agree to the {PH1}. Google’s {PH2} and {PH3} apply to your use of this service.',
   /**
    * @description Button text for learning more about the Google Developer Program.
    */
   learnMore: 'Learn more',
+  /**
+   * @description Accessible text for learning more about the Google Developer Program.
+   */
+  learnMoreAccessibleText: 'Learn more about the Google Developer Program',
   /**
    * @description Link text for Content Policy.
    */
@@ -110,14 +114,14 @@ export const DEFAULT_VIEW: View = (input, _output, target): void => {
   render(
     html`
       <style>${styles}</style>
-      <h2 class="gdp-sign-up-dialog-header">${i18nString(UIStrings.gdpSignUp)}</h2>
+      <div class="gdp-sign-up-dialog-header" role="img" tabindex="0" aria-label="Google Developer Program"></div>
       <div class="main-content">
         <div class="section">
           <div class="icon-container">
             <devtools-icon name="trophy"></devtools-icon>
           </div>
           <div class="text-container">
-            <h3 class="section-title">${i18nString(UIStrings.designedForSuccess)}</h3>
+            <h2 class="section-title">${i18nString(UIStrings.designedForSuccess)}</h2>
             <div class="section-text">${i18nString(UIStrings.designedForSuccessBody)}</div>
           </div>
         </div>
@@ -126,7 +130,7 @@ export const DEFAULT_VIEW: View = (input, _output, target): void => {
             <devtools-icon name="mark-email-unread"></devtools-icon>
           </div>
           <div class="text-container">
-            <h3 class="section-title">${i18nString(UIStrings.keepUpdated)}</h3>
+            <h2 class="section-title">${i18nString(UIStrings.keepUpdated)}</h2>
             <div class="section-text">${i18nString(UIStrings.keepUpdatedBody)}</div>
           </div>
           <div class="switch-container">
@@ -144,19 +148,24 @@ export const DEFAULT_VIEW: View = (input, _output, target): void => {
             <devtools-icon name="google"></devtools-icon>
           </div>
           <div class="text-container">
-            <h3 class="section-title">${i18nString(UIStrings.thingsToConsider)}</h3>
-            <div class="section-text">${i18n.i18n.getFormatLocalizedString(str_, UIStrings.thingsToConsiderBody, {
+            <h2 class="section-title">${i18nString(UIStrings.tailorProfile)}</h2>
+            <div class="section-text">
+              <div>${i18nString(UIStrings.tailorProfileBody)}</div><br/>
+              <div>${i18n.i18n.getFormatLocalizedString(str_, UIStrings.tailorProfileBodyDisclaimer, {
       PH1: UI.XLink.XLink.create(CONTENT_POLICY_URL, i18nString(UIStrings.contentPolicy), 'link', undefined, 'gdp.content-policy'),
       PH2: UI.XLink.XLink.create(TERMS_OF_SERVICE_URL, i18nString(UIStrings.termsOfService), 'link',
         undefined, 'gdp.terms-of-service'),
       PH3: UI.XLink.XLink.create(PRIVACY_POLICY_URL, i18nString(UIStrings.privacyPolicy), 'link',
         undefined, 'gdp.privacy-policy'),
     })}</div>
+            </div>
           </div>
         </div>
       </div>
       <div class="buttons">
         <devtools-button
+          aria-label=${i18nString(UIStrings.learnMoreAccessibleText)}
+          .title=${i18nString(UIStrings.learnMoreAccessibleText)}
           .variant=${Buttons.Button.Variant.OUTLINED}
           .jslogContext=${'learn-more'}
           @click=${() => UI.UIUtils.openInNewTab(GDP_PROGRAM_URL as Platform.DevToolsPath.UrlString)}>${i18nString(UIStrings.learnMore)}</devtools-button>
@@ -239,6 +248,6 @@ export class GdpSignUpDialog extends UI.Widget.VBox {
     dialog.setDimmed(true);
 
     new GdpSignUpDialog({dialog}).show(dialog.contentElement);
-    dialog.show();
+    dialog.show(undefined, /* stack */ true);
   }
 }

package/front_end/panels/common/gdpSignUpDialog.css

@@ -12,23 +12,19 @@
     }
 
     .gdp-sign-up-dialog-header {
-        font: var(--sys-typescale-headline5);
-        color: var(--sys-color-on-surface);
-        display: flex;
-        align-items: center;
+        background-image: var(--image-file-gdp-logo-light);
+        height: 20px;
+        background-repeat: no-repeat;
+        background-size: contain;
         margin: 0;
+
+        &:focus-visible {
+            outline: 2px solid var(--sys-color-state-focus-ring);
+        }
     }
 
-    .gdp-sign-up-dialog-header::before {
-        content: '';
-        background-image: var(--image-file-gdp-logo-standalone);
-        display: inline-block;
-        width: 34px;
-        height: 15px;
-        background-size: contain;
-        background-repeat: no-repeat;
-        background-position: center;
-        margin-right: var(--sys-size-6);
+    :host-context(.theme-with-dark-background) & .gdp-sign-up-dialog-header {
+        background-image: var(--image-file-gdp-logo-dark);
     }
 
     .main-content {

package/front_end/panels/console/ConsoleView.ts

@@ -1592,6 +1592,10 @@ export class ConsoleView extends UI.Widget.VBox implements
     return true;
   }
 
+  supportsWholeWordSearch(): boolean {
+    return true;
+  }
+
   supportsRegexSearch(): boolean {
     return true;
   }

package/front_end/panels/elements/ElementsPanel.ts

@@ -713,6 +713,10 @@ export class ElementsPanel extends UI.Panel.Panel implements UI.SearchableView.S
     return false;
   }
 
+  supportsWholeWordSearch(): boolean {
+    return false;
+  }
+
   supportsRegexSearch(): boolean {
     return false;
   }

package/front_end/panels/elements/StylePropertiesSection.ts

@@ -544,8 +544,8 @@ export class StylePropertiesSection {
     }
   }
 
-  private onKeyDown(event: Event): void {
-    const keyboardEvent = (event as KeyboardEvent);
+  private onKeyDown(event: KeyboardEvent): void {
+    const keyboardEvent = event;
     if (UI.UIUtils.isEditing() || !this.editable || keyboardEvent.altKey || keyboardEvent.ctrlKey ||
         keyboardEvent.metaKey) {
       return;
@@ -1367,12 +1367,12 @@ export class StylePropertiesSection {
   private editingMediaTextCommittedForTest(): void {
   }
 
-  private handleSelectorClick(event: Event): void {
+  private handleSelectorClick(event: MouseEvent): void {
     const target = (event.target as Element | null);
     if (!target) {
       return;
     }
-    if (UI.KeyboardShortcut.KeyboardShortcut.eventHasCtrlEquivalentKey((event as MouseEvent)) && this.navigable &&
+    if (UI.KeyboardShortcut.KeyboardShortcut.eventHasCtrlEquivalentKey(event) && this.navigable &&
         target.classList.contains('simple-selector')) {
       const selectorIndex = this.elementToSelectorIndex.get(target);
       if (selectorIndex) {

package/front_end/panels/network/NetworkConfigView.ts

@@ -274,7 +274,7 @@ export class NetworkConfigView extends UI.Widget.VBox {
       userAgentUpdateButtonStatusText.textContent = '';
     });
 
-    clientHints.addEventListener('clienthintssubmit', (event: Event) => {
+    clientHints.addEventListener('clienthintssubmit', event => {
       const metaData: Protocol.Emulation.UserAgentMetadata = (event as CustomEvent).detail.value;
       const customUA = customUserAgentSetting.get();
       userAgentMetadataSetting.set(metaData);

package/front_end/panels/network/NetworkLogView.ts

@@ -1166,8 +1166,8 @@ export class NetworkLogView extends Common.ObjectWrapper.eventMixin<EventTypes,
     return this.dataGrid;
   }
 
-  private dataGridMouseMove(event: Event): void {
-    const mouseEvent = (event as MouseEvent);
+  private dataGridMouseMove(event: MouseEvent): void {
+    const mouseEvent = event;
     const node = (this.dataGrid.dataGridNodeFromNode((mouseEvent.target as Node)));
     const highlightInitiatorChain = mouseEvent.shiftKey;
     this.setHoveredNode(node as NetworkNode, highlightInitiatorChain);

package/front_end/panels/network/components/HeaderSectionRow.ts

@@ -400,10 +400,9 @@ export class HeaderSectionRow extends HTMLElement {
     this.dispatchEvent(new HeaderRemovedEvent(this.#header.name, this.#header.value || ''));
   }
 
-  #onKeyDown(event: Event): void {
-    const keyboardEvent = event as KeyboardEvent;
+  #onKeyDown(event: KeyboardEvent): void {
     const target = event.target as EditableSpan;
-    if (keyboardEvent.key === 'Escape') {
+    if (event.key === 'Escape') {
       event.consume();
       if (target.matches('.header-name devtools-editable-span')) {
         target.value = this.#header?.name || '';

package/front_end/panels/profiler/HeapProfileView.ts

@@ -303,9 +303,7 @@ export class SamplingHeapProfileTypeBase extends
     const profile = await this.stopSampling();
     if (recordedProfile) {
       console.assert(profile !== undefined);
-      // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration)
-      // eslint-disable-next-line @typescript-eslint/no-explicit-any
-      recordedProfile.setProtocolProfile((profile as any));
+      recordedProfile.setProtocolProfile(profile as unknown as Protocol.Profiler.Profile);
       recordedProfile.updateStatus('');
       this.setProfileBeingRecorded(null);
     }

package/front_end/panels/profiler/HeapSnapshotView.ts

@@ -622,6 +622,10 @@ export class HeapSnapshotView extends UI.View.SimpleView implements DataDisplayD
     return true;
   }
 
+  supportsWholeWordSearch(): boolean {
+    return false;
+  }
+
   supportsRegexSearch(): boolean {
     return false;
   }
@@ -639,7 +643,7 @@ export class HeapSnapshotView extends UI.View.SimpleView implements DataDisplayD
 
   performSearch(searchConfig: UI.SearchableView.SearchConfig, shouldJump: boolean, jumpBackwards?: boolean): void {
     const nextQuery = new HeapSnapshotModel.HeapSnapshotModel.SearchConfig(
-        searchConfig.query.trim(), searchConfig.caseSensitive, searchConfig.isRegex, shouldJump,
+        searchConfig.query.trim(), searchConfig.caseSensitive, searchConfig.wholeWord, searchConfig.isRegex, shouldJump,
         jumpBackwards || false);
 
     void this.searchThrottler.schedule(this.performSearchInternal.bind(this, nextQuery));

package/front_end/panels/profiler/ProfileDataGrid.ts

@@ -641,6 +641,10 @@ export class ProfileDataGridTree implements UI.SearchableView.Searchable {
     return true;
   }
 
+  supportsWholeWordSearch(): boolean {
+    return false;
+  }
+
   supportsRegexSearch(): boolean {
     return false;
   }

package/front_end/panels/profiler/ProfileFlameChartDataProvider.ts

@@ -1,32 +1,6 @@
-/**
- * Copyright (C) 2014 Google Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions are
- * met:
- *
- *     * Redistributions of source code must retain the above copyright
- * notice, this list of conditions and the following disclaimer.
- *     * Redistributions in binary form must reproduce the above
- * copyright notice, this list of conditions and the following disclaimer
- * in the documentation and/or other materials provided with the
- * distribution.
- *     * Neither the name of Google Inc. nor the names of its
- * contributors may be used to endorse or promote products derived from
- * this software without specific prior written permission.
- *
- * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
- * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
- * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
- * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
- * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
- * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
- * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
- */
+// Copyright 2014 The Chromium Authors
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
 /* eslint-disable rulesdir/no-imperative-dom-api */
 
 import * as Common from '../../core/common/common.js';
@@ -262,6 +236,10 @@ export class ProfileFlameChart extends
     return true;
   }
 
+  supportsWholeWordSearch(): boolean {
+    return false;
+  }
+
   supportsRegexSearch(): boolean {
     return false;
   }

package/front_end/panels/profiler/ProfileView.ts

@@ -367,6 +367,10 @@ export class ProfileView extends UI.View.SimpleView implements UI.SearchableView
     return true;
   }
 
+  supportsWholeWordSearch(): boolean {
+    return false;
+  }
+
   supportsRegexSearch(): boolean {
     return false;
   }

package/front_end/panels/recorder/components/CreateRecordingView.ts

@@ -162,13 +162,13 @@ export class CreateRecordingView extends HTMLElement {
     this.#defaultRecordingName = this.#recorderSettings.defaultTitle;
   }
 
-  #onKeyDown(event: Event): void {
+  #onKeyDown(event: KeyboardEvent): void {
     if (this.#error) {
       this.#error = undefined;
       this.#render();
     }
 
-    const keyboardEvent = event as KeyboardEvent;
+    const keyboardEvent = event;
     if (keyboardEvent.key === 'Enter') {
       this.startRecording();
       event.stopPropagation();