chrome-devtools-frontend 1.0.1514545 → 1.0.1515796

package/front_end/ui/legacy/SearchableView.ts

@@ -76,21 +76,17 @@ const UIStrings = {
    */
   searchNext: 'Show next result',
   /**
-   * @description Tooltip text on a toggle to enable search by matching case of the input
+   * @description Tooltip text on a toggle to enable/disable search by matching the exact case.
    */
-  enableCaseSensitive: 'Enable case sensitive search',
+  matchCase: 'Match case',
   /**
-   * @description Tooltip text on a toggle to disable search by matching case of the input
+   * @description Tooltip text on a toggle to enable/disable search by matching the exact word.
    */
-  disableCaseSensitive: 'Disable case sensitive search',
+  matchWholeWord: 'Match whole word',
   /**
-   * @description Tooltip text on a toggle to enable searching with regular expression
+   * @description Tooltip text on a toggle to enable/disable searching with regular expression.
    */
-  enableRegularExpression: 'Enable regular expressions',
-  /**
-   * @description Tooltip text on a toggle to disable searching with regular expression
-   */
-  disableRegularExpression: 'Disable regular expressions',
+  useRegularExpression: 'Use regular expression',
   /**
    * @description Tooltip text on a button to close the search bar
    */
@@ -158,6 +154,7 @@ export class SearchableView extends VBox {
   private searchNavigationNextElement: ToolbarButton;
   private readonly replaceInputElement: HTMLInputElement;
   private caseSensitiveButton: Buttons.Button.Button|undefined;
+  private wholeWordButton: Buttons.Button.Button|undefined;
   private regexButton: Buttons.Button.Button|undefined;
   private replaceButtonElement: Buttons.Button.Button;
   private replaceAllButtonElement: Buttons.Button.Button;
@@ -228,38 +225,64 @@ export class SearchableView extends VBox {
       this.searchInputElement.focus();
     });
     searchConfigButtons.appendChild(clearButton);
-    if (this.searchProvider.supportsRegexSearch()) {
-      const iconName = 'regular-expression';
-      this.regexButton = new Buttons.Button.Button();
-      this.regexButton.data = {
+
+    const saveSettingAndPerformSearch = (): void => {
+      this.saveSetting();
+      this.performSearch(false, true);
+    };
+
+    if (this.searchProvider.supportsCaseSensitiveSearch()) {
+      const iconName = 'match-case';
+      this.caseSensitiveButton = new Buttons.Button.Button();
+      this.caseSensitiveButton.data = {
         variant: Buttons.Button.Variant.ICON_TOGGLE,
         size: Buttons.Button.Size.SMALL,
         iconName,
         toggledIconName: iconName,
-        toggleType: Buttons.Button.ToggleType.PRIMARY,
         toggled: false,
+        toggleType: Buttons.Button.ToggleType.PRIMARY,
+        title: i18nString(UIStrings.matchCase),
         jslogContext: iconName,
-        title: i18nString(UIStrings.enableCaseSensitive),
       };
-      this.regexButton.addEventListener('click', () => this.toggleRegexSearch());
-      searchConfigButtons.appendChild(this.regexButton);
+      ARIAUtils.setLabel(this.caseSensitiveButton, i18nString(UIStrings.matchCase));
+      this.caseSensitiveButton.addEventListener('click', saveSettingAndPerformSearch);
+      searchConfigButtons.appendChild(this.caseSensitiveButton);
     }
 
-    if (this.searchProvider.supportsCaseSensitiveSearch()) {
-      const iconName = 'match-case';
-      this.caseSensitiveButton = new Buttons.Button.Button();
-      this.caseSensitiveButton.data = {
+    if (this.searchProvider.supportsWholeWordSearch()) {
+      const iconName = 'match-whole-word';
+      this.wholeWordButton = new Buttons.Button.Button();
+      this.wholeWordButton.data = {
         variant: Buttons.Button.Variant.ICON_TOGGLE,
         size: Buttons.Button.Size.SMALL,
         iconName,
         toggledIconName: iconName,
         toggled: false,
         toggleType: Buttons.Button.ToggleType.PRIMARY,
-        title: i18nString(UIStrings.enableCaseSensitive),
+        title: i18nString(UIStrings.matchWholeWord),
         jslogContext: iconName,
       };
-      this.caseSensitiveButton.addEventListener('click', () => this.toggleCaseSensitiveSearch());
-      searchConfigButtons.appendChild(this.caseSensitiveButton);
+      ARIAUtils.setLabel(this.wholeWordButton, i18nString(UIStrings.matchWholeWord));
+      this.wholeWordButton.addEventListener('click', saveSettingAndPerformSearch);
+      searchConfigButtons.appendChild(this.wholeWordButton);
+    }
+
+    if (this.searchProvider.supportsRegexSearch()) {
+      const iconName = 'regular-expression';
+      this.regexButton = new Buttons.Button.Button();
+      this.regexButton.data = {
+        variant: Buttons.Button.Variant.ICON_TOGGLE,
+        size: Buttons.Button.Size.SMALL,
+        iconName,
+        toggledIconName: iconName,
+        toggleType: Buttons.Button.ToggleType.PRIMARY,
+        toggled: false,
+        jslogContext: iconName,
+        title: i18nString(UIStrings.useRegularExpression),
+      };
+      ARIAUtils.setLabel(this.regexButton, i18nString(UIStrings.useRegularExpression));
+      this.regexButton.addEventListener('click', saveSettingAndPerformSearch);
+      searchConfigButtons.appendChild(this.regexButton);
     }
 
     // Introduce a separate element for the background of the `Find` input line (instead of
@@ -336,24 +359,6 @@ export class SearchableView extends VBox {
     return view;
   }
 
-  private toggleCaseSensitiveSearch(): void {
-    if (this.caseSensitiveButton) {
-      this.caseSensitiveButton.title = this.caseSensitiveButton.toggled ? i18nString(UIStrings.disableCaseSensitive) :
-                                                                          i18nString(UIStrings.enableCaseSensitive);
-    }
-    this.saveSetting();
-    this.performSearch(false, true);
-  }
-
-  private toggleRegexSearch(): void {
-    if (this.regexButton) {
-      this.regexButton.title = this.regexButton.toggled ? i18nString(UIStrings.disableRegularExpression) :
-                                                          i18nString(UIStrings.enableRegularExpression);
-    }
-    this.saveSetting();
-    this.performSearch(false, true);
-  }
-
   private toggleReplace(): void {
     const replaceEnabled = this.replaceToggleButton.isToggled();
     const label =
@@ -371,6 +376,9 @@ export class SearchableView extends VBox {
     if (this.caseSensitiveButton) {
       settingValue.caseSensitive = this.caseSensitiveButton.toggled;
     }
+    if (this.wholeWordButton) {
+      settingValue.wholeWord = this.wholeWordButton.toggled;
+    }
     if (this.regexButton) {
       settingValue.isRegex = this.regexButton.toggled;
     }
@@ -379,19 +387,14 @@ export class SearchableView extends VBox {
 
   private loadSetting(): void {
     const settingValue = this.setting ? (this.setting.get() || {}) : {};
-    if (this.searchProvider.supportsCaseSensitiveSearch() && this.caseSensitiveButton) {
+    if (this.caseSensitiveButton) {
       this.caseSensitiveButton.toggled = Boolean(settingValue.caseSensitive);
-      const label = settingValue.caseSensitive ? i18nString(UIStrings.disableCaseSensitive) :
-                                                 i18nString(UIStrings.enableCaseSensitive);
-      this.caseSensitiveButton.title = label;
-      ARIAUtils.setLabel(this.caseSensitiveButton, label);
     }
-    if (this.searchProvider.supportsRegexSearch() && this.regexButton) {
+    if (this.wholeWordButton) {
+      this.wholeWordButton.toggled = Boolean(settingValue.wholeWord);
+    }
+    if (this.regexButton) {
       this.regexButton.toggled = Boolean(settingValue.isRegex);
-      const label = settingValue.regular ? i18nString(UIStrings.disableRegularExpression) :
-                                           i18nString(UIStrings.enableRegularExpression);
-      this.regexButton.title = label;
-      ARIAUtils.setLabel(this.regexButton, label);
     }
   }
 
@@ -622,8 +625,9 @@ export class SearchableView extends VBox {
   private currentSearchConfig(): SearchConfig {
     const query = this.searchInputElement.value;
     const caseSensitive = this.caseSensitiveButton ? this.caseSensitiveButton.toggled : false;
+    const wholeWord = this.wholeWordButton ? this.wholeWordButton.toggled : false;
     const isRegex = this.regexButton ? this.regexButton.toggled : false;
-    return new SearchConfig(query, caseSensitive, isRegex);
+    return new SearchConfig(query, caseSensitive, wholeWord, isRegex);
   }
 
   private updateSecondRowVisibility(): void {
@@ -688,6 +692,7 @@ export interface Searchable {
   jumpToNextSearchResult(): void;
   jumpToPreviousSearchResult(): void;
   supportsCaseSensitiveSearch(): boolean;
+  supportsWholeWordSearch(): boolean;
   supportsRegexSearch(): boolean;
 }
 
@@ -704,11 +709,13 @@ export interface SearchRegexResult {
 export class SearchConfig {
   query: string;
   caseSensitive: boolean;
+  wholeWord: boolean;
   isRegex: boolean;
 
-  constructor(query: string, caseSensitive: boolean, isRegex: boolean) {
+  constructor(query: string, caseSensitive: boolean, wholeWord: boolean, isRegex: boolean) {
     this.query = query;
     this.caseSensitive = caseSensitive;
+    this.wholeWord = wholeWord;
     this.isRegex = isRegex;
   }
 
@@ -739,6 +746,17 @@ export class SearchConfig {
       regex = Platform.StringUtilities.createPlainTextSearchRegex(query, modifiers);
     }
 
+    if (this.wholeWord) {
+      let {source} = regex;
+      if (!source.startsWith('^') && !source.startsWith('\\b')) {
+        source = '\\b' + source;
+      }
+      if (!source.endsWith('$') && !source.endsWith('\\b')) {
+        source = source + '\\b';
+      }
+      regex = new RegExp(source, regex.flags);
+    }
+
     return {
       regex,
       fromQuery,

package/front_end/ui/legacy/SettingsUI.ts

@@ -103,18 +103,18 @@ const createSettingSelect = function(
 };
 
 export const bindToSetting =
-    (setting: string|Common.Settings.Setting<boolean|string>|Common.Settings.RegExpSetting,
+    (settingOrName: string|Common.Settings.Setting<boolean|string>|Common.Settings.RegExpSetting,
      stringValidator?: (newSettingValue: string) => boolean): ReturnType<typeof Directives.ref> => {
-      if (typeof setting === 'string') {
-        setting = Common.Settings.Settings.instance().moduleSetting(setting);
-      }
+      const setting = typeof settingOrName === 'string' ?
+          Common.Settings.Settings.instance().moduleSetting(settingOrName) :
+          settingOrName;
 
       // We can't use `setValue` as the change listener directly, otherwise we won't
       // be able to remove it again.
       // eslint-disable-next-line @typescript-eslint/no-explicit-any
       let setValue: (value: any) => void;
       function settingChanged(): void {
-        setValue((setting as Common.Settings.Setting<unknown>| Common.Settings.RegExpSetting).get());
+        setValue(setting.get());
       }
 
       if (setting.type() === Common.Settings.SettingType.BOOLEAN || typeof setting.defaultValue === 'boolean') {

package/front_end/ui/legacy/components/color_picker/Spectrum.ts

@@ -1419,10 +1419,7 @@ export class Spectrum extends Common.ObjectWrapper.eventMixin<EventTypes, typeof
     } else if (IS_NATIVE_EYE_DROPPER_AVAILABLE && enabled) {
       // Use EyeDropper API, can pick up colors outside the browser window,
       // Note: The current EyeDropper API is not designed to pick up colors continuously.
-      // Wait for TypeScript to support the definition of EyeDropper API:
-      // https://github.com/microsoft/TypeScript/issues/48638
-      /* eslint-disable  @typescript-eslint/no-explicit-any */
-      const eyeDropper = new (window as any).EyeDropper();
+      const eyeDropper = new window.EyeDropper();
       this.eyeDropperAbortController = new AbortController();
 
       try {

package/front_end/ui/legacy/components/data_grid/DataGrid.ts

@@ -140,7 +140,7 @@ export class DataGridImpl<T> extends Common.ObjectWrapper.ObjectWrapper<EventTyp
   private dataTableHeaders: Record<string, Element>;
   scrollContainerInternal: Element;
   #dataContainer: Element;
-  private readonly dataTable: Element;
+  private readonly dataTable: HTMLTableElement;
   protected inline: boolean;
   private columnsArray: ColumnDescriptor[];
   columns: Record<string, ColumnDescriptor>;
@@ -1516,19 +1516,19 @@ export class DataGridImpl<T> extends Common.ObjectWrapper.ObjectWrapper<EventTyp
     void contextMenu.show();
   }
 
-  private clickInDataTable(event: Event): void {
+  private clickInDataTable(event: MouseEvent): void {
     const gridNode = this.dataGridNodeFromNode((event.target as Node));
-    if (!gridNode || !gridNode.hasChildren() || !gridNode.isEventWithinDisclosureTriangle((event as MouseEvent))) {
+    if (!gridNode || !gridNode.hasChildren() || !gridNode.isEventWithinDisclosureTriangle(event)) {
       return;
     }
 
     if (gridNode.expanded) {
-      if ((event as MouseEvent).altKey) {
+      if (event.altKey) {
         gridNode.collapseRecursively();
       } else {
         gridNode.collapse();
       }
-    } else if ((event as MouseEvent).altKey) {
+    } else if (event.altKey) {
       gridNode.expandRecursively();
     } else {
       gridNode.expand();

package/front_end/ui/legacy/components/data_grid/DataGridElement.ts

@@ -399,7 +399,7 @@ class DataGridElementNode extends SortableDataGridNode<DataGridElementNode> {
       const cell = cells[i];
       const column = this.#dataGridElement.columns[i];
       if (column.dataType === DataType.BOOLEAN) {
-        this.data[column.id] = hasBooleanAttribute(cell, 'data-value');
+        this.data[column.id] = hasBooleanAttribute(cell, 'data-value') || cell.textContent === 'true';
       } else {
         this.data[column.id] = cell.dataset.value ?? cell.textContent ?? '';
       }
@@ -472,7 +472,9 @@ class DataGridElementNode extends SortableDataGridNode<DataGridElementNode> {
   override createCell(columnId: string): HTMLElement {
     const index = this.#dataGridElement.columns.findIndex(({id}) => id === columnId);
     if (this.#dataGridElement.columns[index].dataType === DataType.BOOLEAN) {
-      return super.createCell(columnId);
+      const cell = super.createCell(columnId);
+      cell.setAttribute('part', `${columnId}-column`);
+      return cell;
     }
     const cell = this.createTD(columnId);
     cell.setAttribute('part', `${columnId}-column`);

package/front_end/ui/legacy/components/perf_ui/ChartViewport.ts

@@ -325,8 +325,8 @@ export class ChartViewport extends UI.Widget.VBox {
     this.delegate.updateRangeSelection(this.rangeSelectionStart, this.rangeSelectionEnd);
   }
 
-  onClick(event: Event): void {
-    const mouseEvent = (event as MouseEvent);
+  onClick(event: MouseEvent): void {
+    const mouseEvent = event;
     const time = this.pixelToTime(mouseEvent.offsetX);
     if (this.rangeSelectionStart !== null && this.rangeSelectionEnd !== null && time >= this.rangeSelectionStart &&
         time <= this.rangeSelectionEnd) {

package/front_end/ui/legacy/components/perf_ui/FilmStripView.ts

@@ -217,8 +217,8 @@ export class Dialog {
     this.dialog.setSizeBehavior(UI.GlassPane.SizeBehavior.MEASURE_CONTENT);
   }
 
-  private keyDown(event: Event): void {
-    const keyboardEvent = (event as KeyboardEvent);
+  private keyDown(event: KeyboardEvent): void {
+    const keyboardEvent = event;
     switch (keyboardEvent.key) {
       case 'ArrowLeft':
         if (Host.Platform.isMac() && keyboardEvent.metaKey) {

package/front_end/ui/legacy/components/perf_ui/LineLevelProfile.ts

@@ -39,10 +39,7 @@ export class Performance {
     const nodesToGo: CPUProfile.CPUProfileDataModel.CPUProfileNode[] = [profile.profileHead];
     const sampleDuration = (profile.profileEndTime - profile.profileStartTime) / profile.totalHitCount;
     while (nodesToGo.length) {
-      const nodes: CPUProfile.CPUProfileDataModel.CPUProfileNode[] =
-          // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration)
-          // eslint-disable-next-line @typescript-eslint/no-explicit-any
-          (nodesToGo.pop() as any).children;  // Cast to any because runtime checks assert the props.
+      const nodes: CPUProfile.CPUProfileDataModel.CPUProfileNode[] = nodesToGo.pop()?.children ?? [];
       for (let i = 0; i < nodes.length; ++i) {
         const node = nodes[i];
         nodesToGo.push(node);

package/front_end/ui/legacy/components/perf_ui/OverviewGrid.ts

@@ -128,7 +128,7 @@ const ResizerOffset = 5;
 const OffsetFromWindowEnds = 10;
 
 export class Window extends Common.ObjectWrapper.ObjectWrapper<EventTypes> {
-  private parentElement: Element;
+  private parentElement: HTMLElement;
   private calculator: NetworkTimeCalculator.Calculator|undefined;
   private leftResizeElement: HTMLElement;
   private rightResizeElement: HTMLElement;
@@ -618,8 +618,8 @@ export class Window extends Common.ObjectWrapper.ObjectWrapper<EventTypes> {
     this.setWindowRatio(windowLeft || 0, windowRight || 0);
   }
 
-  private onMouseWheel(event: Event): void {
-    const wheelEvent = (event as WheelEvent);
+  private onMouseWheel(event: WheelEvent): void {
+    const wheelEvent = event;
     if (!this.resizeEnabled) {
       return;
     }

package/front_end/ui/legacy/components/perf_ui/TimelineOverviewPane.ts

@@ -91,11 +91,11 @@ export class TimelineOverviewPane extends Common.ObjectWrapper.eventMixin<EventT
     this.hasPointer = false;
   }
 
-  private onMouseMove(event: Event): void {
+  private onMouseMove(event: MouseEvent): void {
     if (!this.cursorEnabled) {
       return;
     }
-    const mouseEvent = (event as MouseEvent);
+    const mouseEvent = event;
     const target = (event.target as HTMLElement);
     const offsetLeftRelativeToCursorArea =
         target.getBoundingClientRect().left - this.cursorArea.getBoundingClientRect().left;

package/front_end/ui/legacy/components/source_frame/JSONView.ts

@@ -68,9 +68,9 @@ export class JSONView extends UI.Widget.VBox implements UI.SearchableView.Search
   }
 
   private static parseJSON(text: string|null): Promise<ParsedJSON|null> {
-    let returnObj: (ParsedJSON|null)|null = null;
+    let returnObj: ParsedJSON<string>|null = null;
     if (text) {
-      returnObj = JSONView.extractJSON((text));
+      returnObj = JSONView.extractJSON(text);
     }
     if (!returnObj) {
       return Promise.resolve(null);
@@ -88,7 +88,7 @@ export class JSONView extends UI.Widget.VBox implements UI.SearchableView.Search
     return Promise.resolve(returnObj);
   }
 
-  private static extractJSON(text: string): ParsedJSON|null {
+  private static extractJSON(text: string): ParsedJSON<string>|null {
     // Do not treat HTML as JSON.
     if (text.startsWith('<')) {
       return null;
@@ -260,21 +260,21 @@ export class JSONView extends UI.Widget.VBox implements UI.SearchableView.Search
     return true;
   }
 
+  supportsWholeWordSearch(): boolean {
+    return true;
+  }
+
   supportsRegexSearch(): boolean {
     return true;
   }
 }
 
-export class ParsedJSON {
-  // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration)
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  data: any;
+export class ParsedJSON<T extends unknown = unknown> {
+  data: T;
   prefix: string;
   suffix: string;
 
-  // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration)
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  constructor(data: any, prefix: string, suffix: string) {
+  constructor(data: T, prefix: string, suffix: string) {
     this.data = data;
     this.prefix = prefix;
     this.suffix = suffix;

package/front_end/ui/legacy/components/source_frame/SourceFrame.ts

@@ -862,6 +862,10 @@ export class SourceFrameImpl extends Common.ObjectWrapper.eventMixin<EventTypes,
     return true;
   }
 
+  supportsWholeWordSearch(): boolean {
+    return true;
+  }
+
   supportsRegexSearch(): boolean {
     return true;
   }

package/front_end/ui/legacy/components/source_frame/XMLView.ts

@@ -342,6 +342,10 @@ export class XMLView extends UI.Widget.Widget implements UI.SearchableView.Searc
     return true;
   }
 
+  supportsWholeWordSearch(): boolean {
+    return true;
+  }
+
   supportsRegexSearch(): boolean {
     return true;
   }

package/front_end/ui/legacy/components/utils/Linkifier.ts

@@ -974,10 +974,7 @@ function listenForNewComponentLinkifierEvents(): void {
   listeningToNewEvents = true;
 
   window.addEventListener('linkifieractivated', function(event: Event) {
-    // TODO(crbug.com/1172300) Ignored during the jsdoc to ts migration
-    // eslint-disable-next-line @typescript-eslint/no-explicit-any
-    const unknownEvent = (event as any);
-    const eventWithData = (unknownEvent as {
+    const eventWithData = (event as unknown as {
       data: LinkInfo,
     });
     Linkifier.handleClickFromNewComponentLand(eventWithData.data);

package/front_end/ui/legacy/searchableView.css

@@ -160,7 +160,3 @@
 :host-context(#sources-panel-sources-view) .search-bar {
   flex-basis: auto;
 }
-
-:host-context(#sources-panel-sources-view) .toolbar-search {
-  flex-wrap: wrap;
-}

package/front_end/ui/visual_logging/Debugging.ts

@@ -731,7 +731,7 @@ function compareVeEvents(actual: TestLogEntry, expected: TestLogEntry): boolean
 interface PendingEventExpectation {
   expectedEvents: TestLogEntry[];
   missingEvents?: TestLogEntry[];
-  unmatchingEvents: TestLogEntry[];
+  unmatchedEvents: TestLogEntry[];
   success: () => void;
   fail: (arg0: Error) => void;
 }
@@ -785,20 +785,33 @@ export async function expectVeEvents(expectedEvents: TestLogEntry[]): Promise<vo
     throw new Error('VE events expectation already set. Cannot set another one until the previous is resolved');
   }
   const {promise, resolve: success, reject: fail} = Promise.withResolvers<void>();
-  pendingEventExpectation = {expectedEvents, success, fail, unmatchingEvents: []};
+  pendingEventExpectation = {expectedEvents, success, fail, unmatchedEvents: []};
   checkPendingEventExpectation();
 
   const timeout = setTimeout(() => {
     if (pendingEventExpectation?.missingEvents) {
-      pendingEventExpectation.fail(new Error(
-          '\nMissing VE Events:\n' + formatVeEvents(pendingEventExpectation.missingEvents) +
-          '\nUnmatched VE Events:\n' + formatVeEvents(pendingEventExpectation.unmatchingEvents) + '\nAll events:\n' +
-          JSON.stringify(veDebugEventsLog, null, 2)));
+      const allLogs = veDebugEventsLog.filter(ve => {
+        if ('interaction' in ve) {
+          // Very noisy in the error and not providing context
+          return ve.interaction !== 'SettingAccess';
+        }
+
+        return true;
+      });
+      pendingEventExpectation.fail(new Error(`
+Missing VE Events:
+${formatVeEvents(pendingEventExpectation.missingEvents)}
+Unmatched VE Events:
+${formatVeEvents(pendingEventExpectation.unmatchedEvents)}
+All events:
+${JSON.stringify(allLogs, null, 2)}
+`));
     }
   }, EVENT_EXPECTATION_TIMEOUT);
 
   return await promise.finally(() => {
     clearTimeout(timeout);
+    pendingEventExpectation = null;
   });
 }
 
@@ -811,7 +824,7 @@ function checkPendingEventExpectation(): void {
   const actualEvents = [...veDebugEventsLog] as TestLogEntry[];
   let partialMatch = false;
   const matchedImpressions = new Set<string>();
-  pendingEventExpectation.unmatchingEvents = [];
+  pendingEventExpectation.unmatchedEvents = [];
   for (let i = 0; i < pendingEventExpectation.expectedEvents.length; ++i) {
     const expectedEvent = pendingEventExpectation.expectedEvents[i];
     while (true) {
@@ -826,9 +839,9 @@ function checkPendingEventExpectation(): void {
       }
       if (!compareVeEvents(actualEvents[i], expectedEvent)) {
         if (partialMatch) {
-          const unmatching = {...actualEvents[i]};
-          if ('impressions' in unmatching && 'impressions' in expectedEvent) {
-            unmatching.impressions = unmatching.impressions.filter(impression => {
+          const unmatched = {...actualEvents[i]};
+          if ('impressions' in unmatched && 'impressions' in expectedEvent) {
+            unmatched.impressions = unmatched.impressions.filter(impression => {
               const matched = expectedEvent.impressions.includes(impression);
               if (matched) {
                 matchedImpressions.add(impression);
@@ -836,7 +849,7 @@ function checkPendingEventExpectation(): void {
               return !matched;
             });
           }
-          pendingEventExpectation.unmatchingEvents.push(unmatching);
+          pendingEventExpectation.unmatchedEvents.push(unmatched);
         }
         actualEvents.splice(i, 1);
       } else {
@@ -847,7 +860,6 @@ function checkPendingEventExpectation(): void {
   }
   numMatchedEvents = veDebugEventsLog.length - actualEvents.length + pendingEventExpectation.expectedEvents.length;
   pendingEventExpectation.success();
-  pendingEventExpectation = null;
 }
 
 function getUnmatchedVeEvents(): string {

package/front_end/ui/visual_logging/KnownContextValues.ts

@@ -2739,6 +2739,7 @@ export const knownContextValues = new Set([
   'overscroll-behavior-inline',
   'overscroll-behavior-x',
   'overscroll-behavior-y',
+  'overscroll-position',
   'p3',
   'pa',
   'packetLoss',

package/package.json

@@ -23,8 +23,8 @@
     "collect-strings": "vpython3 third_party/node/node.py --output third_party/i18n/collect-strings.js front_end",
     "components-server": "vpython3 third_party/node/node.py --output scripts/component_server/server.js",
     "debug-webtest": "vpython3 third_party/node/node.py --output scripts/npm_test.js --debug-devtools",
-    "generate-protocol-resources": "scripts/deps/generate_protocol_resources.py && git cl format --js",
-    "install-deps": "scripts/deps/manage_node_deps.py",
+    "generate-protocol-resources": "vpython3 scripts/deps/generate_protocol_resources.py && git cl format --js",
+    "install-deps": "vpython3 scripts/deps/manage_node_deps.py",
     "lint": "vpython3 third_party/node/node.py --output --experimental-strip-types --no-warnings=ExperimentalWarning scripts/test/run_lint_check.mjs",
     "prebuild": "gn gen out/Default",
     "rdb": "rdb stream -new -realm chromium:public --",
@@ -102,5 +102,5 @@
       "@eslint/core": "0.15.1"
     }
   },
-  "version": "1.0.1514545"
+  "version": "1.0.1515796"
 }

package/front_end/Images/src/gdp-logo-standalone.svg

@@ -1,9 +0,0 @@
-<svg width="57" height="26" viewBox="0 0 57 26" fill="none" xmlns="http://www.w3.org/2000/svg">
-<path d="M37.8354 6.97422L34.9026 10.6776L33.0631 13.0009L29.9954 9.12688C29.521 8.56621 28.9209 8.48183 28.6022 8.48183C28.2834 8.48183 27.6833 8.56621 27.2089 9.12688L24.1412 13.0009L22.3429 15.2736L22.3035 15.3242L22.2623 15.3767L19.3708 19.0277L18.047 20.7003C18.0188 20.7359 17.9907 20.7697 17.9626 20.8034C16.0912 23.0498 13.4247 24.2668 10.6476 24.2668C9.55629 24.2668 8.44808 24.0793 7.36425 23.6911C3.49769 22.3035 1 18.7501 1 14.6361V11.3639C1 13.4303 2.67451 15.1048 4.74092 15.1048C6.80733 15.1048 8.48183 13.4303 8.48183 11.3639V14.6361C8.48183 15.9955 9.46441 16.4943 9.88819 16.6462C10.3063 16.7962 11.3677 17.0325 12.2171 16.0087L14.6004 13.0009L16.4118 10.7133L16.44 10.6776L16.4606 10.6514L19.3727 6.97422L21.3753 4.44652C21.3903 4.42777 21.4053 4.40902 21.4203 4.39214C23.1942 2.23572 25.8138 1 28.6059 1C31.398 1 34.0176 2.23572 35.7915 4.39214C35.8065 4.41089 35.8215 4.42777 35.8365 4.44652L37.8391 6.97422H37.8354Z" fill="#4285F4" stroke="#202124" stroke-width="0.853016" stroke-miterlimit="10"/>
-<path d="M18.0451 5.3041L19.3689 6.97673L16.4568 10.6539L16.4362 10.6801L16.4081 10.7158L14.5967 13.0035L12.2152 9.99572C11.3658 8.97189 10.3045 9.20816 9.88632 9.35817C9.46441 9.51005 8.47996 10.0088 8.47996 11.3683C8.47996 13.4347 6.80545 15.1092 4.73904 15.1092C2.67263 15.1092 1 13.431 1 11.3646C1 7.2505 3.49769 3.6971 7.36424 2.31137C11.2027 0.935011 15.3542 2.06947 17.9607 5.19722C17.9888 5.23097 18.0188 5.2666 18.047 5.30035L18.0451 5.3041Z" fill="#EA4335" stroke="#202124" stroke-width="0.853016" stroke-miterlimit="10"/>
-<path d="M22.3424 15.2715L22.303 15.3221L22.2617 15.3746C22.2898 15.3409 22.3161 15.3071 22.3424 15.2734V15.2715Z" fill="#EA4335" stroke="#202124" stroke-width="0.853016" stroke-miterlimit="10"/>
-<path d="M16.4102 10.7132C16.4254 10.6922 16.4425 10.6713 16.4596 10.6504L16.4387 10.677L16.4102 10.7132Z" fill="#34A853" stroke="#202124" stroke-width="0.853016" stroke-miterlimit="10"/>
-<path d="M56.2064 11.3638V14.6359C56.2064 12.5695 54.5319 10.895 52.4655 10.895C50.3991 10.895 48.7246 12.5695 48.7246 14.6359V11.3638C48.7246 10.0043 47.742 9.50549 47.3182 9.3536C46.9 9.20359 45.8387 8.96732 44.9893 9.99115L42.6078 12.9989L40.7964 15.2866L40.7683 15.3222L40.7477 15.3484L37.8356 19.0256L35.8329 21.5533C35.8179 21.572 35.8029 21.5908 35.7879 21.6077C34.014 23.7622 31.3945 24.9998 28.6024 24.9998C25.8103 24.9998 23.1907 23.7641 21.4168 21.6077C21.4018 21.5889 21.3868 21.572 21.3718 21.5533L19.3691 19.0237L22.2606 15.3728C22.2887 15.3391 22.315 15.3053 22.3412 15.2716L24.1395 12.9989L27.2073 16.8729C27.6817 17.4336 28.2817 17.518 28.6005 17.518C28.9193 17.518 29.5193 17.4336 29.9918 16.8729L33.0596 12.9989L34.8691 10.7131L34.8972 10.6775L34.9235 10.6437L37.83 6.97404L39.1538 5.30141C39.1819 5.26578 39.2119 5.23015 39.2401 5.1964C41.8465 2.06866 45.9981 0.936069 49.8365 2.31055C53.7012 3.69628 56.2008 7.24969 56.2008 11.3638H56.2064Z" fill="#34A853" stroke="#202124" stroke-width="0.853016" stroke-miterlimit="10"/>
-<path d="M34.8721 10.7149C34.8892 10.6921 34.9082 10.6674 34.9272 10.6445L34.9006 10.6788L34.8721 10.7149Z" fill="#FBBC04" stroke="#202124" stroke-width="0.853016" stroke-miterlimit="10"/>
-<path d="M56.2058 14.6353C56.2058 18.7494 53.7081 22.3028 49.8415 23.6885C48.7577 24.0767 47.6495 24.2642 46.5581 24.2642C43.7829 24.2642 41.1165 23.0472 39.2451 20.8008C39.2151 20.767 39.1869 20.7314 39.1588 20.6958L37.835 19.0231L40.7471 15.346L40.7677 15.3197L40.7958 15.2841L42.6072 12.9964L44.9886 16.0041C45.8381 17.028 46.9013 16.7917 47.3176 16.6417C47.7395 16.4898 48.7239 15.991 48.7239 14.6315C48.7239 12.5651 50.3984 10.8906 52.4648 10.8906C54.5313 10.8906 56.2058 12.5651 56.2058 14.6315V14.6353Z" fill="#FBBC04" stroke="#202124" stroke-width="0.853016" stroke-miterlimit="10"/>
-</svg>