chrome-devtools-frontend 1.0.1473514 → 1.0.1506453

package/front_end/panels/network/NetworkDataGridNode.ts

@@ -59,28 +59,28 @@ import type {NetworkTimeCalculator} from './NetworkTimeCalculator.js';
 
 const UIStrings = {
   /**
-   *@description Text in Network Data Grid Node of the Network panel
+   * @description Text in Network Data Grid Node of the Network panel
    */
   redirect: 'Redirect',
   /**
-   *@description Content of the request method column in the network log view. Some requests require an additional request to check permissions, and this additional request is called 'Preflight Request', see https://developer.mozilla.org/en-US/docs/Glossary/Preflight_request. In the request method column we use, for example, 'POST + Preflight' to indicate that the request method was 'POST' and the request was accompanied by a preflight request. Since the column is short, the translation for Preflight in this context should ideally also be short.
-   *@example {GET} PH1
+   * @description Content of the request method column in the network log view. Some requests require an additional request to check permissions, and this additional request is called 'Preflight Request', see https://developer.mozilla.org/en-US/docs/Glossary/Preflight_request. In the request method column we use, for example, 'POST + Preflight' to indicate that the request method was 'POST' and the request was accompanied by a preflight request. Since the column is short, the translation for Preflight in this context should ideally also be short.
+   * @example {GET} PH1
    */
   sPreflight: '{PH1} + Preflight',
   /**
-   *@description Name of a network initiator type
+   * @description Name of a network initiator type
    */
   preflight: 'Preflight',
   /**
-   *@description Title for a link element in the network log view
+   * @description Title for a link element in the network log view
    */
   selectPreflightRequest: 'Select preflight request',
   /**
-   *@description Text in Network Data Grid Node of the Network panel
+   * @description Text in Network Data Grid Node of the Network panel
    */
   failed: '(failed)',
   /**
-   *@description Text in Network Data Grid Node of the Network panel
+   * @description Text in Network Data Grid Node of the Network panel
    */
   data: '(data)',
   /**
@@ -89,45 +89,65 @@ const UIStrings = {
    */
   canceled: '(canceled)',
   /**
-   *@description Reason in Network Data Grid Node of the Network panel
+   * @description Reason in Network Data Grid Node of the Network panel
    */
   other: 'other',
   /**
-   *@description Reason in Network Data Grid Node of the Network panel
+   * @description Reason in Network Data Grid Node of the Network panel
    */
   csp: 'csp',
   /**
-   *@description Reason in Network Data Grid Node of the Network panel
+   * @description Reason in Network Data Grid Node of the Network panel
    */
   origin: 'origin',
   /**
-   *@description Noun. Shown in a table cell as the reason why a network request failed. "integrity" here refers to the integrity of the network request itself in a cryptographic sense: signature verification might have failed, for instance.
+   * @description Reason why a request was blocked shown in the Network panel
+   */
+  coepFrameResourceNeedsCoepHeader: 'COEP-framed resource needs COEP header',
+  /**
+   * @description Reason why a request was blocked shown in the Network panel
+   */
+  coopSandboxedIframeCannotNavigateToCoopPage: 'Sandboxed iframe\'s popup cannot navigate to COOP page',
+  /**
+   * @description Reason why a request was blocked shown in the Network panel
+   */
+  corpNotSameOrigin: 'CORP not "same-origin"',
+  /**
+   * @description Reason why a request was blocked shown in the Network panel
+   */
+  corpNotSameSite: 'CORP not "same-site"',
+  /**
+   * @description Reason why a request was blocked shown in the Network panel
+   */
+  corpNotSameOriginAfterDefaultedToSameOriginByCoep: 'CORP not "same-origin" after defaulted to "same-origin" by COEP',
+  /**
+   * @description Noun. Shown in a table cell as the reason why a network request failed. "integrity" here refers to the integrity of the network request itself in a cryptographic sense: signature verification might have failed, for instance.
    */
   integrity: 'integrity',
   /**
-   *@description Reason in Network Data Grid Node of the Network panel
+   * @description Reason in Network Data Grid Node of the Network panel
    */
   devtools: 'devtools',
   /**
-   *@description Text in Network Data Grid Node of the Network panel
-   *@example {mixed-content} PH1
+   * @description Text in Network Data Grid Node of the Network panel
+   * @example {mixed-content} PH1
    */
   blockeds: '(blocked:{PH1})',
   /**
-   *@description Text in Network Data Grid Node of the Network panel
+   * @description Text in Network Data Grid Node of the Network panel
    */
   blockedTooltip: 'This request was blocked due to misconfigured response headers, click to view the headers',
   /**
-   *@description Text in Network Data Grid Node of the Network panel
+   * @description Text in Network Data Grid Node of the Network panel
    */
   corsError: 'CORS error',
   /**
-   *@description Tooltip providing the cors error code
-   *@example {PreflightDisallowedRedirect} PH1
+   * @description Tooltip providing the cors error code
+   * @example {PreflightDisallowedRedirect} PH1
    */
   crossoriginResourceSharingErrorS: 'Cross-Origin Resource Sharing error: {PH1}',
   /**
-   *@description Text in Network Data Grid Node of the Network panel
+   * @description Text in Network Data Grid Node of the Network panel
    */
   finished: 'Finished',
   /**
@@ -150,172 +170,176 @@ const UIStrings = {
    */
   push: 'Push / ',
   /**
-   *@description Text in Network Data Grid Node of the Network panel
+   * @description Text in Network Data Grid Node of the Network panel
    */
   parser: 'Parser',
   /**
-   *@description Label for a group of JavaScript files
+   * @description Label for a group of JavaScript files
    */
   script: 'Script',
   /**
-   *@description Cell title in Network Data Grid Node of the Network panel
+   * @description Cell title in Network Data Grid Node of the Network panel
    */
   preload: 'Preload',
   /**
-   *@description Cell title in Network Data Grid Node of the Network panel
+   * @description Cell title in Network Data Grid Node of the Network panel
    */
   earlyHints: 'early-hints',
   /**
-   *@description Text in Network Data Grid Node of the Network panel
+   * @description Text in Network Data Grid Node of the Network panel
    */
   signedexchange: 'signed-exchange',
   /**
-   *@description Title for a link element in the network log view
+   * @description Title for a link element in the network log view
    */
   selectTheRequestThatTriggered: 'Select the request that triggered this preflight',
   /**
-   *@description Text for other types of items
+   * @description Text for other types of items
    */
   otherC: 'Other',
   /**
-   *@description Text of a DOM element in Network Data Grid Node of the Network panel
+   * @description Text of a DOM element in Network Data Grid Node of the Network panel
    */
   memoryCache: '(memory cache)',
   /**
-   *@description Cell title in Network Data Grid Node of the Network panel. Indicates that the response came from memory cache.
-   *@example {50 B} PH1
+   * @description Cell title in Network Data Grid Node of the Network panel. Indicates that the response came from memory cache.
+   * @example {50 B} PH1
    */
   servedFromMemoryCacheResource: 'Served from memory cache, resource size: {PH1}',
   /**
-   *@description Text of a DOM element in Network Data Grid Node of the Network panel
+   * @description Text of a DOM element in Network Data Grid Node of the Network panel
    */
   serviceWorker: '(`ServiceWorker`)',
   /**
-   *@description Cell title in Network Data Grid Node of the Network panel
-   *@example {4 B} PH1
-   *@example {10 B} PH2
+   * @description Cell title in Network Data Grid Node of the Network panel
+   * @example {4 B} PH1
+   * @example {10 B} PH2
    */
   servedFromNetwork: '{PH1} transferred over network, resource size: {PH2}',
   /**
-   *@description Cell title in Network Data Grid Node of the Network panel
-   *@example {4 B} PH1
-   *@example {10 B} PH2
+   * @description Cell title in Network Data Grid Node of the Network panel
+   * @example {4 B} PH1
+   * @example {10 B} PH2
    */
   servedFromNetworkMissingServiceWorkerRoute:
       '{PH1} transferred over network, resource size: {PH2}, no matching ServiceWorker routes',
   /**
-   *@description Cell title in Network Data Grid Node of the Network panel
-   *@example {4 B} PH1
+   * @description Cell title in Network Data Grid Node of the Network panel
+   * @example {4 B} PH1
    */
   servedFromServiceWorkerResource: 'Served from `ServiceWorker`, resource size: {PH1}',
   /**
-   *@description Cell title in Network Data Grid Node of the Network panel
-   *@example {4 B} PH1
+   * @description Cell title in Network Data Grid Node of the Network panel
+   * @example {4 B} PH1
    */
   servedFromSignedHttpExchange: 'Served from Signed HTTP Exchange, resource size: {PH1}',
   /**
-   *@description Cell title in Network Data Grid Node of the Network panel. Indicates that the response came from preloaded web bundle. See https://web.dev/web-bundles/
-   *@example {4 B} PH1
+   * @description Cell title in Network Data Grid Node of the Network panel. Indicates that the response came from preloaded web bundle. See https://web.dev/web-bundles/
+   * @example {4 B} PH1
    */
   servedFromWebBundle: 'Served from Web Bundle, resource size: {PH1}',
   /**
-   *@description Text of a DOM element in Network Data Grid Node of the Network panel
+   * @description Text of a DOM element in Network Data Grid Node of the Network panel
    */
   prefetchCache: '(prefetch cache)',
   /**
-   *@description Cell title in Network Data Grid Node of the Network panel
-   *@example {4 B} PH1
+   * @description Cell title in Network Data Grid Node of the Network panel
+   * @example {4 B} PH1
    */
   servedFromPrefetchCacheResource: 'Served from prefetch cache, resource size: {PH1}',
   /**
-   *@description Text of a DOM element in Network Data Grid Node of the Network panel
+   * @description Text of a DOM element in Network Data Grid Node of the Network panel
    */
   diskCache: '(disk cache)',
   /**
-   *@description Cell title in Network Data Grid Node of the Network panel
-   *@example {10 B} PH1
+   * @description Cell title in Network Data Grid Node of the Network panel
+   * @example {10 B} PH1
    */
   servedFromDiskCacheResourceSizeS: 'Served from disk cache, resource size: {PH1}',
   /**
-   *@description Cell title in Network Data Grid Node of the Network panel
-   *@example {1} PH1
-   *@example {4 B} PH2
+   * @description Cell title in Network Data Grid Node of the Network panel
+   * @example {1} PH1
+   * @example {4 B} PH2
    */
   matchedToServiceWorkerRouter: 'Matched to `ServiceWorker router`#{PH1}, resource size: {PH2}',
 
   /**
-   *@description Cell title in Network Data Grid Node of the Network panel
-   *@example {1} PH1
-   *@example {4 B} PH2
-   *@example {12 B} PH3
+   * @description Cell title in Network Data Grid Node of the Network panel
+   * @example {1} PH1
+   * @example {4 B} PH2
+   * @example {12 B} PH3
    */
   matchedToServiceWorkerRouterWithNetworkSource:
       'Matched to `ServiceWorker router`#{PH1}, {PH2} transferred over network, resource size: {PH3}',
   /**
-   *@description Text in Network Data Grid Node of the Network panel
+   * @description Text in Network Data Grid Node of the Network panel
    */
   pending: 'Pending',
   /**
-   *@description Text describing the depth of a top level node in the network datagrid
+   * @description Text describing the depth of a top level node in the network datagrid
    */
   level: 'level 1',
   /**
-   *@description Text in Network Data Grid Node of the Network panel
+   * @description Text in Network Data Grid Node of the Network panel
    */
   webBundleError: 'Web Bundle error',
   /**
-   *@description Alternative text for the web bundle inner request icon in Network Data Grid Node of the Network panel
+   * @description Alternative text for the web bundle inner request icon in Network Data Grid Node of the Network panel
    * Indicates that the response came from preloaded web bundle. See https://web.dev/web-bundles/
    */
   webBundleInnerRequest: 'Served from Web Bundle',
   /**
-   *@description Text in Network Data Grid Node of the Network panel
+   * @description Text in Network Data Grid Node of the Network panel
    */
   webBundle: '(Web Bundle)',
   /**
-   *@description Tooltip text for subtitles of Time cells in Network request rows. Latency is the time difference
+   * @description Tooltip text for subtitles of Time cells in Network request rows. Latency is the time difference
    * between the time a response to a network request is received and the time the request is started.
    */
   timeSubtitleTooltipText: 'Latency (response received time - start time)',
   /**
-   *@description Tooltip text giving the reason why a specific HTTP transport protocol has been used
+   * @description Tooltip text giving the reason why a specific HTTP transport protocol has been used
    */
   alternativeJobWonWithoutRace:
       '`Chrome` used a `HTTP/3` connection induced by an \'`Alt-Svc`\' header without racing against establishing a connection using a different `HTTP` version.',
   /**
-   *@description Tooltip text giving the reason why a specific HTTP transport protocol has been used
+   * @description Tooltip text giving the reason why a specific HTTP transport protocol has been used
    */
   alternativeJobWonRace:
       '`Chrome` used a `HTTP/3` connection induced by an \'`Alt-Svc`\' header because it won a race against establishing a connection using a different `HTTP` version.',
   /**
-   *@description Tooltip text giving the reason why a specific HTTP transport protocol has been used
+   * @description Tooltip text giving the reason why a specific HTTP transport protocol has been used
    */
   mainJobWonRace: '`Chrome` used this protocol because it won a race against establishing a `HTTP/3` connection.',
   /**
-   *@description Tooltip text giving the reason why a specific HTTP transport protocol has been used
+   * @description Tooltip text giving the reason why a specific HTTP transport protocol has been used
    */
   mappingMissing:
       '`Chrome` did not use an alternative `HTTP` version because no alternative protocol information was available when the request was issued, but an \'`Alt-Svc`\' header was present in the response.',
   /**
-   *@description Tooltip text giving the reason why a specific HTTP transport protocol has been used
+   * @description Tooltip text giving the reason why a specific HTTP transport protocol has been used
    */
   broken: '`Chrome` did not try to establish a `HTTP/3` connection because it was marked as broken.',
   /**
-   *@description Tooltip text giving the reason why a specific HTTP transport protocol has been used
+   * @description Tooltip text giving the reason why a specific HTTP transport protocol has been used
    */
   dnsAlpnH3JobWonWithoutRace:
       '`Chrome` used a `HTTP/3` connection due to the `DNS record` indicating `HTTP/3` support. There was no race against establishing a connection using a different `HTTP` version.',
   /**
-   *@description Tooltip text giving the reason why a specific HTTP transport protocol has been used
+   * @description Tooltip text giving the reason why a specific HTTP transport protocol has been used
    */
   dnsAlpnH3JobWonRace:
       '`Chrome` used a `HTTP/3` connection due to the `DNS record` indicating `HTTP/3` support, which won a race against establishing a connection using a different `HTTP` version.',
   /**
-   *@description Tooltip to explain the resource's initial priority
-   *@example {High} PH1
-   *@example {Low} PH2
+   * @description Tooltip to explain the resource's initial priority
+   * @example {High} PH1
+   * @example {Low} PH2
    */
   initialPriorityToolTip: '{PH1}, Initial priority: {PH2}',
+  /**
+   * @description Tooltip to explain why the request has an IPP icon
+   */
+  responseIsIpProtectedToolTip: 'This request was sent through IP Protection proxies.',
 } as const;
 const str_ = i18n.i18n.registerUIStrings('panels/network/NetworkDataGridNode.ts', UIStrings);
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
@@ -326,8 +350,14 @@ export const enum Events {
   RequestActivated = 'RequestActivated',
 }
 
+export const enum RequestPanelBehavior {
+  ShowPanel = 'ShowPanel',
+  HidePanel = 'HidePanel',
+  Unchanged = 'Unchanged',
+}
+
 export interface RequestActivatedEvent {
-  showPanel: boolean;
+  showPanel: RequestPanelBehavior;
   takeFocus?: boolean;
   tab?: NetworkForward.UIRequestLocation.UIRequestTabs;
 }
@@ -458,14 +488,14 @@ export class NetworkNode extends DataGrid.SortableDataGrid.SortableDataGridNode<
     this.updateBackgroundColor();
   }
 
-  override select(supressSelectedEvent?: boolean): void {
-    super.select(supressSelectedEvent);
+  override select(suppressSelectedEvent?: boolean): void {
+    super.select(suppressSelectedEvent);
     this.updateBackgroundColor();
     this.parentViewInternal.updateNodeSelectedClass(/* isSelected */ true);
   }
 
-  override deselect(supressSelectedEvent?: boolean): void {
-    super.deselect(supressSelectedEvent);
+  override deselect(suppressSelectedEvent?: boolean): void {
+    super.deselect(suppressSelectedEvent);
     this.updateBackgroundColor();
     this.parentViewInternal.updateNodeSelectedClass(/* isSelected */ false);
   }
@@ -1100,8 +1130,8 @@ export class NetworkRequestNode extends NetworkNode {
     return array ? String(array.length) : '';
   }
 
-  override select(supressSelectedEvent?: boolean): void {
-    super.select(supressSelectedEvent);
+  override select(suppressSelectedEvent?: boolean): void {
+    super.select(suppressSelectedEvent);
     this.parentView().dispatchEventToListeners(Events.RequestSelected, this.requestInternal);
   }
 
@@ -1121,15 +1151,24 @@ export class NetworkRequestNode extends NetworkNode {
       cell.style.setProperty('padding-left', leftPadding);
       cell.tabIndex = -1;
       cell.addEventListener('dblclick', this.openInNewTab.bind(this), false);
-      cell.addEventListener('mousedown', () => {
+      cell.addEventListener('mousedown', (event: MouseEvent) => {
         // When the request panel isn't visible yet, firing the RequestActivated event
         // doesn't make it visible if no request is selected. So we'll select it first.
         this.select();
-        this.parentView().dispatchEventToListeners(Events.RequestActivated, {showPanel: true});
+        // Only open panel on mousedown with left mouse button.
+        const showPanel = event.button ? RequestPanelBehavior.Unchanged : RequestPanelBehavior.ShowPanel;
+        this.parentView().dispatchEventToListeners(Events.RequestActivated, {showPanel});
       });
       cell.addEventListener('focus', () => this.parentView().resetFocus());
 
       // render icons
+      if (this.requestInternal.isIpProtectionUsed()) {
+        const ippIcon = IconButton.Icon.create('shield', 'icon');
+        ippIcon.title = i18nString(UIStrings.responseIsIpProtectedToolTip);
+        ippIcon.style.color = 'var(--sys-color-on-surface-subtle);';
+        cell.appendChild(ippIcon);
+      }
+
       const iconElement = PanelUtils.getIconForNetworkRequest(this.requestInternal);
       // eslint-disable-next-line rulesdir/no-lit-render-outside-of-view
       render(iconElement, cell);
@@ -1227,23 +1266,23 @@ export class NetworkRequestNode extends NetworkNode {
           break;
         case Protocol.Network.BlockedReason.CoepFrameResourceNeedsCoepHeader:
           displayShowHeadersLink = true;
-          reason = i18n.i18n.lockedString('CoepFrameResourceNeedsCoepHeader');
+          reason = i18nString(UIStrings.coepFrameResourceNeedsCoepHeader);
           break;
         case Protocol.Network.BlockedReason.CoopSandboxedIframeCannotNavigateToCoopPage:
           displayShowHeadersLink = true;
-          reason = i18n.i18n.lockedString('CoopSandboxedIframeCannotNavigateToCoopPage');
+          reason = i18nString(UIStrings.coopSandboxedIframeCannotNavigateToCoopPage);
           break;
         case Protocol.Network.BlockedReason.CorpNotSameOrigin:
           displayShowHeadersLink = true;
-          reason = i18n.i18n.lockedString('NotSameOrigin');
+          reason = i18nString(UIStrings.corpNotSameOrigin);
           break;
         case Protocol.Network.BlockedReason.CorpNotSameSite:
           displayShowHeadersLink = true;
-          reason = i18n.i18n.lockedString('NotSameSite');
+          reason = i18nString(UIStrings.corpNotSameSite);
           break;
         case Protocol.Network.BlockedReason.CorpNotSameOriginAfterDefaultedToSameOriginByCoep:
           displayShowHeadersLink = true;
-          reason = i18n.i18n.lockedString('NotSameOriginAfterDefaultedToSameOriginByCoep');
+          reason = i18nString(UIStrings.corpNotSameOriginAfterDefaultedToSameOriginByCoep);
           break;
         case Protocol.Network.BlockedReason.SriMessageSignatureMismatch:
           displayShowHeadersLink = true;
@@ -1254,7 +1293,7 @@ export class NetworkRequestNode extends NetworkNode {
         this.setTextAndTitleAsLink(
             cell, i18nString(UIStrings.blockeds, {PH1: reason}), i18nString(UIStrings.blockedTooltip), () => {
               this.parentView().dispatchEventToListeners(Events.RequestActivated, {
-                showPanel: true,
+                showPanel: RequestPanelBehavior.ShowPanel,
                 tab: NetworkForward.UIRequestLocation.UIRequestTabs.HEADERS_COMPONENT,
               });
             });
@@ -1373,7 +1412,7 @@ export class NetworkRequestNode extends NetworkNode {
       case SDK.NetworkRequest.InitiatorType.SCRIPT: {
         const target = SDK.NetworkManager.NetworkManager.forRequest(request)?.target() || null;
         const linkifier = this.parentView().linkifier();
-        if (initiator.stack) {
+        if (initiator.stack?.callFrames.length) {
           this.linkifiedInitiatorAnchor = linkifier.linkifyStackTraceTopFrame(target, initiator.stack);
         } else {
           this.linkifiedInitiatorAnchor = linkifier.linkifyScriptLocation(
@@ -1518,7 +1557,7 @@ export class NetworkRequestNode extends NetworkNode {
       const action = UI.ActionRegistry.ActionRegistry.instance().getAction('drjones.network-floating-button');
       const aiButtonContainer = document.createElement('span');
       aiButtonContainer.classList.add('ai-button-container');
-      const floatingButton = Buttons.FloatingButton.create('smart-assistant', action.title());
+      const floatingButton = Buttons.FloatingButton.create('smart-assistant', action.title(), 'ask-ai');
       floatingButton.addEventListener('click', ev => {
         ev.stopPropagation();
         this.select();
@@ -1554,8 +1593,8 @@ export class NetworkGroupNode extends NetworkNode {
     }
   }
 
-  override select(supressSelectedEvent?: boolean): void {
-    super.select(supressSelectedEvent);
+  override select(suppressSelectedEvent?: boolean): void {
+    super.select(suppressSelectedEvent);
     const firstChildNode = (this.traverseNextNode(false, undefined, true) as NetworkNode);
     const request = firstChildNode?.request();
     if (request) {

package/front_end/panels/network/NetworkItemView.test.ts

@@ -76,7 +76,7 @@ describeWithEnvironment('NetworkItemView', () => {
     request.statusCode = 200;
   });
 
-  it('shows indicator for overriden headers and responses', () => {
+  it('shows indicator for overridden headers and responses', () => {
     request.setWasIntercepted(true);
     request.hasOverriddenContent = true;
     request.responseHeaders = [{name: 'foo', value: 'overridden'}];
@@ -92,7 +92,7 @@ describeWithEnvironment('NetworkItemView', () => {
     assert.isNotNull(responseIndicator);
   });
 
-  it('shows indicator for overriden headers', () => {
+  it('shows indicator for overridden headers', () => {
     request.setWasIntercepted(true);
     request.responseHeaders = [{name: 'foo', value: 'overridden'}];
     request.originalResponseHeaders = [{name: 'foo', value: 'original'}];
@@ -107,7 +107,7 @@ describeWithEnvironment('NetworkItemView', () => {
     assert.isNull(responseIndicator);
   });
 
-  it('shows indicator for overriden content', () => {
+  it('shows indicator for overridden content', () => {
     request.setWasIntercepted(true);
     request.hasOverriddenContent = true;