chrome-devtools-frontend 1.0.1473514 → 1.0.1506453

package/front_end/core/sdk/CompilerSourceMappingContentProvider.ts

@@ -37,9 +37,9 @@ import {PageResourceLoader, type PageResourceLoadInitiator} from './PageResource
 
 const UIStrings = {
   /**
-   *@description Error message when failing to fetch a resource referenced in a source map
-   *@example {https://example.com/sourcemap.map} PH1
-   *@example {An error occurred} PH2
+   * @description Error message when failing to fetch a resource referenced in a source map
+   * @example {https://example.com/sourcemap.map} PH1
+   * @example {An error occurred} PH2
    */
   couldNotLoadContentForSS: 'Could not load content for {PH1} ({PH2})',
 } as const;
@@ -68,11 +68,6 @@ export class CompilerSourceMappingContentProvider implements TextUtils.ContentPr
     return this.#contentTypeInternal;
   }
 
-  async requestContent(): Promise<TextUtils.ContentProvider.DeferredContent> {
-    const contentData = await this.requestContentData();
-    return TextUtils.ContentData.ContentData.asDeferredContent(contentData);
-  }
-
   async requestContentData(): Promise<TextUtils.ContentData.ContentDataOrError> {
     try {
       const {content} = await PageResourceLoader.instance().loadResource(this.#sourceURL, this.#initiator);

package/front_end/core/sdk/Connections.ts

@@ -13,23 +13,19 @@ import {RehydratingConnection} from './RehydratingConnection.js';
 
 const UIStrings = {
   /**
-   *@description Text on the remote debugging window to indicate the connection is lost
+   * @description Text on the remote debugging window to indicate the connection is lost
    */
   websocketDisconnected: 'WebSocket disconnected',
 } as const;
 const str_ = i18n.i18n.registerUIStrings('core/sdk/Connections.ts', UIStrings);
 const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 export class MainConnection implements ProtocolClient.InspectorBackend.Connection {
-  onMessage: ((arg0: (Object|string)) => void)|null;
-  #onDisconnect: ((arg0: string) => void)|null;
-  #messageBuffer: string;
-  #messageSize: number;
+  onMessage: ((arg0: Object|string) => void)|null = null;
+  #onDisconnect: ((arg0: string) => void)|null = null;
+  #messageBuffer = '';
+  #messageSize = 0;
   readonly #eventListeners: Common.EventTarget.EventDescriptor[];
   constructor() {
-    this.onMessage = null;
-    this.#onDisconnect = null;
-    this.#messageBuffer = '';
-    this.#messageSize = 0;
     this.#eventListeners = [
       Host.InspectorFrontendHost.InspectorFrontendHostInstance.events.addEventListener(
           Host.InspectorFrontendHostAPI.Events.DispatchMessage, this.dispatchMessage, this),
@@ -38,7 +34,7 @@ export class MainConnection implements ProtocolClient.InspectorBackend.Connectio
     ];
   }
 
-  setOnMessage(onMessage: (arg0: (Object|string)) => void): void {
+  setOnMessage(onMessage: (arg0: Object|string) => void): void {
     this.onMessage = onMessage;
   }
 
@@ -87,11 +83,11 @@ export class MainConnection implements ProtocolClient.InspectorBackend.Connectio
 
 export class WebSocketConnection implements ProtocolClient.InspectorBackend.Connection {
   #socket: WebSocket|null;
-  onMessage: ((arg0: (Object|string)) => void)|null;
-  #onDisconnect: ((arg0: string) => void)|null;
+  onMessage: ((arg0: Object|string) => void)|null = null;
+  #onDisconnect: ((arg0: string) => void)|null = null;
   #onWebSocketDisconnect: ((message: Platform.UIString.LocalizedString) => void)|null;
-  #connected: boolean;
-  #messages: string[];
+  #connected = false;
+  #messages: string[] = [];
   constructor(
       url: Platform.DevToolsPath.UrlString,
       onWebSocketDisconnect: (message: Platform.UIString.LocalizedString) => void) {
@@ -105,14 +101,10 @@ export class WebSocketConnection implements ProtocolClient.InspectorBackend.Conn
     };
     this.#socket.onclose = this.onClose.bind(this);
 
-    this.onMessage = null;
-    this.#onDisconnect = null;
     this.#onWebSocketDisconnect = onWebSocketDisconnect;
-    this.#connected = false;
-    this.#messages = [];
   }
 
-  setOnMessage(onMessage: (arg0: (Object|string)) => void): void {
+  setOnMessage(onMessage: (arg0: Object|string) => void): void {
     this.onMessage = onMessage;
   }
 
@@ -185,14 +177,10 @@ export class WebSocketConnection implements ProtocolClient.InspectorBackend.Conn
 }
 
 export class StubConnection implements ProtocolClient.InspectorBackend.Connection {
-  onMessage: ((arg0: (Object|string)) => void)|null;
-  #onDisconnect: ((arg0: string) => void)|null;
-  constructor() {
-    this.onMessage = null;
-    this.#onDisconnect = null;
-  }
+  onMessage: ((arg0: Object|string) => void)|null = null;
+  #onDisconnect: ((arg0: string) => void)|null = null;
 
-  setOnMessage(onMessage: (arg0: (Object|string)) => void): void {
+  setOnMessage(onMessage: (arg0: Object|string) => void): void {
     this.onMessage = onMessage;
   }
 
@@ -233,13 +221,11 @@ export interface ParallelConnectionInterface extends ProtocolClient.InspectorBac
 export class ParallelConnection implements ParallelConnectionInterface {
   readonly #connection: ProtocolClient.InspectorBackend.Connection;
   #sessionId: string;
-  onMessage: ((arg0: Object) => void)|null;
-  #onDisconnect: ((arg0: string) => void)|null;
+  onMessage: ((arg0: Object) => void)|null = null;
+  #onDisconnect: ((arg0: string) => void)|null = null;
   constructor(connection: ProtocolClient.InspectorBackend.Connection, sessionId: string) {
     this.#connection = connection;
     this.#sessionId = sessionId;
-    this.onMessage = null;
-    this.#onDisconnect = null;
   }
 
   setOnMessage(onMessage: (arg0: Object) => void): void {
@@ -296,6 +282,7 @@ function createMainConnection(onConnectionLost: (message: Platform.UIString.Loca
     return new WebSocketConnection(ws, onConnectionLost);
   }
   if (Host.InspectorFrontendHost.InspectorFrontendHostInstance.isHostedMode()) {
+    // Hosted mode (e.g. `http://localhost:9222/devtools/inspector.html`) but no WebSocket URL.
     return new StubConnection();
   }
 

package/front_end/core/sdk/ConsoleModel.ts

@@ -67,28 +67,28 @@ export {FrontendMessageType} from './ConsoleModelTypes.js';
 
 const UIStrings = {
   /**
-   *@description Text shown when the main frame (page) of the website was navigated to a different URL.
-   *@example {https://example.com} PH1
+   * @description Text shown when the main frame (page) of the website was navigated to a different URL.
+   * @example {https://example.com} PH1
    */
   navigatedToS: 'Navigated to {PH1}',
   /**
-   *@description Text shown when the main frame (page) of the website was navigated to a different URL
+   * @description Text shown when the main frame (page) of the website was navigated to a different URL
    * and the page was restored from back/forward cache (https://web.dev/bfcache/).
-   *@example {https://example.com} PH1
+   * @example {https://example.com} PH1
    */
   bfcacheNavigation: 'Navigation to {PH1} was restored from back/forward cache (see https://web.dev/bfcache/)',
   /**
-   *@description Text shown in the console when a performance profile (with the given name) was started.
-   *@example {title} PH1
+   * @description Text shown in the console when a performance profile (with the given name) was started.
+   * @example {title} PH1
    */
   profileSStarted: 'Profile \'\'{PH1}\'\' started.',
   /**
-   *@description Text shown in the console when a performance profile (with the given name) was stopped.
-   *@example {name} PH1
+   * @description Text shown in the console when a performance profile (with the given name) was stopped.
+   * @example {name} PH1
    */
   profileSFinished: 'Profile \'\'{PH1}\'\' finished.',
   /**
-   *@description Error message shown in the console after the user tries to save a JavaScript value to a temporary variable.
+   * @description Error message shown in the console after the user tries to save a JavaScript value to a temporary variable.
    */
   failedToSaveToTempVariable: 'Failed to save to temp variable.',
 } as const;

package/front_end/core/sdk/DOMModel.ts

@@ -92,20 +92,32 @@ export class DOMNode {
   internalSubset?: string;
   name?: string;
   value?: string;
+  /**
+   * Set when a DOMNode is retained in a detached sub-tree.
+   */
+  retained = false;
+  /**
+   * Set if a DOMNode is a root of a detached sub-tree.
+   */
+  detached = false;
+  #retainedNodes?: Set<Protocol.DOM.BackendNodeId>;
 
   constructor(domModel: DOMModel) {
     this.#domModelInternal = domModel;
     this.#agent = this.#domModelInternal.getAgent();
   }
 
-  static create(domModel: DOMModel, doc: DOMDocument|null, isInShadowTree: boolean, payload: Protocol.DOM.Node):
-      DOMNode {
+  static create(
+      domModel: DOMModel, doc: DOMDocument|null, isInShadowTree: boolean, payload: Protocol.DOM.Node,
+      retainedNodes?: Set<Protocol.DOM.BackendNodeId>): DOMNode {
     const node = new DOMNode(domModel);
-    node.init(doc, isInShadowTree, payload);
+    node.init(doc, isInShadowTree, payload, retainedNodes);
     return node;
   }
 
-  init(doc: DOMDocument|null, isInShadowTree: boolean, payload: Protocol.DOM.Node): void {
+  init(
+      doc: DOMDocument|null, isInShadowTree: boolean, payload: Protocol.DOM.Node,
+      retainedNodes?: Set<Protocol.DOM.BackendNodeId>): void {
     this.#agent = this.#domModelInternal.getAgent();
     this.ownerDocument = doc;
     this.#isInShadowTreeInternal = isInShadowTree;
@@ -124,6 +136,11 @@ export class DOMNode {
     this.#xmlVersion = payload.xmlVersion;
     this.#isSVGNodeInternal = Boolean(payload.isSVG);
     this.#isScrollableInternal = Boolean(payload.isScrollable);
+    this.#retainedNodes = retainedNodes;
+
+    if (this.#retainedNodes?.has(this.backendNodeId())) {
+      this.retained = true;
+    }
 
     if (payload.attributes) {
       this.setAttributesPayload(payload.attributes);
@@ -133,7 +150,7 @@ export class DOMNode {
     if (payload.shadowRoots) {
       for (let i = 0; i < payload.shadowRoots.length; ++i) {
         const root = payload.shadowRoots[i];
-        const node = DOMNode.create(this.#domModelInternal, this.ownerDocument, true, root);
+        const node = DOMNode.create(this.#domModelInternal, this.ownerDocument, true, root, retainedNodes);
         this.shadowRootsInternal.push(node);
         node.parentNode = this;
       }
@@ -141,7 +158,7 @@ export class DOMNode {
 
     if (payload.templateContent) {
       this.templateContentInternal =
-          DOMNode.create(this.#domModelInternal, this.ownerDocument, true, payload.templateContent);
+          DOMNode.create(this.#domModelInternal, this.ownerDocument, true, payload.templateContent, retainedNodes);
       this.templateContentInternal.parentNode = this;
       this.childrenInternal = [];
     }
@@ -159,7 +176,7 @@ export class DOMNode {
 
     if (payload.importedDocument) {
       this.#importedDocumentInternal =
-          DOMNode.create(this.#domModelInternal, this.ownerDocument, true, payload.importedDocument);
+          DOMNode.create(this.#domModelInternal, this.ownerDocument, true, payload.importedDocument, retainedNodes);
       this.#importedDocumentInternal.parentNode = this;
       this.childrenInternal = [];
     }
@@ -233,6 +250,7 @@ export class DOMNode {
     return [
       Protocol.DOM.PseudoType.ViewTransition,
       Protocol.DOM.PseudoType.ViewTransitionGroup,
+      Protocol.DOM.PseudoType.ViewTransitionGroupChildren,
       Protocol.DOM.PseudoType.ViewTransitionImagePair,
       Protocol.DOM.PseudoType.ViewTransitionOld,
       Protocol.DOM.PseudoType.ViewTransitionNew,
@@ -361,6 +379,7 @@ export class DOMNode {
     return [
       ...this.#pseudoElements.get(Protocol.DOM.PseudoType.ViewTransition) || [],
       ...this.#pseudoElements.get(Protocol.DOM.PseudoType.ViewTransitionGroup) || [],
+      ...this.#pseudoElements.get(Protocol.DOM.PseudoType.ViewTransitionGroupChildren) || [],
       ...this.#pseudoElements.get(Protocol.DOM.PseudoType.ViewTransitionImagePair) || [],
       ...this.#pseudoElements.get(Protocol.DOM.PseudoType.ViewTransitionOld) || [],
       ...this.#pseudoElements.get(Protocol.DOM.PseudoType.ViewTransitionNew) || [],
@@ -546,8 +565,8 @@ export class DOMNode {
     return response.getError() ? null : this.childrenInternal;
   }
 
-  async getOuterHTML(): Promise<string|null> {
-    const {outerHTML} = await this.#agent.invoke_getOuterHTML({nodeId: this.id});
+  async getOuterHTML(includeShadowDOM = false): Promise<string|null> {
+    const {outerHTML} = await this.#agent.invoke_getOuterHTML({nodeId: this.id, includeShadowDOM});
     return outerHTML;
   }
 
@@ -667,7 +686,8 @@ export class DOMNode {
     if (!this.childrenInternal) {
       throw new Error('DOMNode._children is expected to not be null.');
     }
-    const node = DOMNode.create(this.#domModelInternal, this.ownerDocument, this.#isInShadowTreeInternal, payload);
+    const node = DOMNode.create(
+        this.#domModelInternal, this.ownerDocument, this.#isInShadowTreeInternal, payload, this.#retainedNodes);
     this.childrenInternal.splice(prev ? this.childrenInternal.indexOf(prev) + 1 : 0, 0, node);
     this.renumber();
     return node;
@@ -708,7 +728,8 @@ export class DOMNode {
     this.childrenInternal = [];
     for (let i = 0; i < payloads.length; ++i) {
       const payload = payloads[i];
-      const node = DOMNode.create(this.#domModelInternal, this.ownerDocument, this.#isInShadowTreeInternal, payload);
+      const node = DOMNode.create(
+          this.#domModelInternal, this.ownerDocument, this.#isInShadowTreeInternal, payload, this.#retainedNodes);
       this.childrenInternal.push(node);
     }
     this.renumber();
@@ -720,8 +741,8 @@ export class DOMNode {
     }
 
     for (let i = 0; i < payloads.length; ++i) {
-      const node =
-          DOMNode.create(this.#domModelInternal, this.ownerDocument, this.#isInShadowTreeInternal, payloads[i]);
+      const node = DOMNode.create(
+          this.#domModelInternal, this.ownerDocument, this.#isInShadowTreeInternal, payloads[i], this.#retainedNodes);
       node.parentNode = this;
       const pseudoType = node.pseudoType();
       if (!pseudoType) {
@@ -797,8 +818,15 @@ export class DOMNode {
           if (!response.getError()) {
             this.#domModelInternal.markUndoableState();
           }
+          const pastedNode = this.#domModelInternal.nodeForId(response.nodeId);
+          if (pastedNode) {
+            // For every marker in this.#markers, set a marker in the copied node.
+            for (const [name, value] of this.#markers) {
+              pastedNode.setMarker(name, value);
+            }
+          }
           if (callback) {
-            callback(response.getError() || null, this.#domModelInternal.nodeForId(response.nodeId));
+            callback(response.getError() || null, pastedNode);
           }
         });
   }
@@ -1614,9 +1642,10 @@ export class DOMModel extends SDKModel<EventTypes> {
 
   async getContainerForNode(
       nodeId: Protocol.DOM.NodeId, containerName?: string, physicalAxes?: Protocol.DOM.PhysicalAxes,
-      logicalAxes?: Protocol.DOM.LogicalAxes, queriesScrollState?: boolean): Promise<DOMNode|null> {
+      logicalAxes?: Protocol.DOM.LogicalAxes, queriesScrollState?: boolean,
+      queriesAnchored?: boolean): Promise<DOMNode|null> {
     const {nodeId: containerNodeId} = await this.agent.invoke_getContainerForNode(
-        {nodeId, containerName, physicalAxes, logicalAxes, queriesScrollState});
+        {nodeId, containerName, physicalAxes, logicalAxes, queriesScrollState, queriesAnchored});
     if (!containerNodeId) {
       return null;
     }

package/front_end/core/sdk/DebuggerModel.test.ts

@@ -275,17 +275,20 @@ describeWithMockConnection('DebuggerModel', () => {
   describe('pause', () => {
     let target: SDK.Target.Target;
     let backend: MockProtocolBackend;
-    let debuggerWorkspaceBinding: Bindings.DebuggerWorkspaceBinding.DebuggerWorkspaceBinding;
 
     beforeEach(() => {
       target = createTarget({id: 'main' as Protocol.Target.TargetID, name: 'main', type: SDK.Target.Type.FRAME});
       const targetManager = target.targetManager();
       const workspace = Workspace.Workspace.WorkspaceImpl.instance();
       const resourceMapping = new Bindings.ResourceMapping.ResourceMapping(targetManager, workspace);
-      debuggerWorkspaceBinding = Bindings.DebuggerWorkspaceBinding.DebuggerWorkspaceBinding.instance(
-          {forceNew: false, resourceMapping, targetManager});
+      const ignoreListManager = Workspace.IgnoreListManager.IgnoreListManager.instance({forceNew: true});
+      Bindings.DebuggerWorkspaceBinding.DebuggerWorkspaceBinding.instance({
+        forceNew: true,
+        resourceMapping,
+        targetManager,
+        ignoreListManager,
+      });
       backend = new MockProtocolBackend();
-      Bindings.IgnoreListManager.IgnoreListManager.instance({forceNew: false, debuggerWorkspaceBinding});
     });
 
     it('with empty call frame list will invoke plain step-into', async () => {

package/front_end/core/sdk/DebuggerModel.ts

@@ -51,51 +51,51 @@ import {Capability, type Target, Type} from './Target.js';
 
 const UIStrings = {
   /**
-   *@description Title of a section in the debugger showing local JavaScript variables.
+   * @description Title of a section in the debugger showing local JavaScript variables.
    */
   local: 'Local',
   /**
-   *@description Text that refers to closure as a programming term
+   * @description Text that refers to closure as a programming term
    */
   closure: 'Closure',
   /**
-   *@description Noun that represents a section or block of code in the Debugger Model. Shown in the Sources tab, while paused on a breakpoint.
+   * @description Noun that represents a section or block of code in the Debugger Model. Shown in the Sources tab, while paused on a breakpoint.
    */
   block: 'Block',
   /**
-   *@description Label for a group of JavaScript files
+   * @description Label for a group of JavaScript files
    */
   script: 'Script',
   /**
-   *@description Title of a section in the debugger showing JavaScript variables from the a 'with'
+   * @description Title of a section in the debugger showing JavaScript variables from the a 'with'
    *block. Block here means section of code, 'with' refers to a JavaScript programming concept and
    *is a fixed term.
    */
   withBlock: '`With` block',
   /**
-   *@description Title of a section in the debugger showing JavaScript variables from the a 'catch'
+   * @description Title of a section in the debugger showing JavaScript variables from the a 'catch'
    *block. Block here means section of code, 'catch' refers to a JavaScript programming concept and
    *is a fixed term.
    */
   catchBlock: '`Catch` block',
   /**
-   *@description Title of a section in the debugger showing JavaScript variables from the global scope.
+   * @description Title of a section in the debugger showing JavaScript variables from the global scope.
    */
   global: 'Global',
   /**
-   *@description Text for a JavaScript module, the programming concept
+   * @description Text for a JavaScript module, the programming concept
    */
   module: 'Module',
   /**
-   *@description Text describing the expression scope in WebAssembly
+   * @description Text describing the expression scope in WebAssembly
    */
   expression: 'Expression',
   /**
-   *@description Text in Scope Chain Sidebar Pane of the Sources panel
+   * @description Text in Scope Chain Sidebar Pane of the Sources panel
    */
   exception: 'Exception',
   /**
-   *@description Text in Scope Chain Sidebar Pane of the Sources panel
+   * @description Text in Scope Chain Sidebar Pane of the Sources panel
    */
   returnValue: 'Return value',
 } as const;
@@ -972,6 +972,50 @@ export class DebuggerModel extends SDKModel<EventTypes> {
       ((arg0: CallFrame, arg1: EvaluationOptions) => Promise<EvaluationResult|null>)|null {
     return this.evaluateOnCallFrameCallback;
   }
+
+  /**
+   * Iterates the async stack trace parents.
+   *
+   * Retrieving cross-target async stack fragments requires CDP interaction, so this is an async generator.
+   *
+   * Important: This iterator will not yield the "synchronous" part of the stack trace, only the async parent chain.
+   */
+  async *
+      iterateAsyncParents(stackTraceOrPausedDetails: Protocol.Runtime.StackTrace|DebuggerPausedDetails):
+          AsyncGenerator<{stackTrace: Protocol.Runtime.StackTrace, target: Target}> {
+    // We make `DebuggerPausedDetails` look like a stack trace. We are only interested in `parent` and `parentId` in any case.
+    let stackTrace: Protocol.Runtime.StackTrace = stackTraceOrPausedDetails instanceof DebuggerPausedDetails ?
+        {
+          callFrames: [],
+          parent: stackTraceOrPausedDetails.asyncStackTrace,
+          parentId: stackTraceOrPausedDetails.asyncStackTraceId
+        } :
+        stackTraceOrPausedDetails;
+    let target = this.target();
+
+    while (true) {
+      if (stackTrace.parent) {
+        stackTrace = stackTrace.parent;
+      } else if (stackTrace.parentId) {
+        const model: DebuggerModel|null = stackTrace.parentId.debuggerId ?
+            await DebuggerModel.modelForDebuggerId(stackTrace.parentId.debuggerId) :
+            this;
+        if (!model) {
+          return;
+        }
+        const maybeStackTrace = await model.fetchAsyncStackTrace(stackTrace.parentId);
+        if (!maybeStackTrace) {
+          return;
+        }
+        stackTrace = maybeStackTrace;
+        target = model.target();
+      } else {
+        return;
+      }
+
+      yield {stackTrace, target};
+    }
+  }
 }
 
 const debuggerIdToModel = new Map<string, DebuggerModel>();

package/front_end/core/sdk/EmulationModel.ts

@@ -12,6 +12,12 @@ import {Events, OverlayModel} from './OverlayModel.js';
 import {SDKModel} from './SDKModel.js';
 import {Capability, type Target} from './Target.js';
 
+export const enum DataSaverOverride {
+  UNSET = 'unset',
+  ENABLED = 'enabled',
+  DISABLED = 'disabled',
+}
+
 export class EmulationModel extends SDKModel<void> {
   readonly #emulationAgent: ProtocolProxyApi.EmulationApi;
   readonly #deviceOrientationAgent: ProtocolProxyApi.DeviceOrientationApi;
@@ -369,6 +375,13 @@ export class EmulationModel extends SDKModel<void> {
     void this.#emulationAgent.invoke_setDisabledImageTypes({imageTypes});
   }
 
+  async setDataSaverOverride(dataSaverOverride: DataSaverOverride): Promise<void> {
+    const dataSaverEnabled = dataSaverOverride === DataSaverOverride.UNSET ? undefined :
+        dataSaverOverride === DataSaverOverride.ENABLED                    ? true :
+                                                                             false;
+    await this.#emulationAgent.invoke_setDataSaverOverride({dataSaverEnabled});
+  }
+
   async setCPUThrottlingRate(rate: number): Promise<void> {
     await this.#emulationAgent.invoke_setCPUThrottlingRate({rate});
   }

package/front_end/core/sdk/EventBreakpointsModel.ts

@@ -33,7 +33,7 @@ export const enum InstrumentationNames {
   CANVAS_CONTEXT_CREATED = 'canvasContextCreated',
   GEOLOCATION_GET_CURRENT_POSITION = 'Geolocation.getCurrentPosition',
   GEOLOCATION_WATCH_POSITION = 'Geolocation.watchPosition',
-  NOTIFCATION_REQUEST_PERMISSION = 'Notification.requestPermission',
+  NOTIFICATION_REQUEST_PERMISSION = 'Notification.requestPermission',
   DOM_WINDOW_CLOSE = 'DOMWindow.close',
   DOCUMENT_WRITE = 'Document.write',
   AUDIO_CONTEXT_CREATED = 'audioContextCreated',
@@ -102,7 +102,7 @@ export class EventBreakpointsManager implements SDKModelObserver<EventBreakpoint
       InstrumentationNames.GEOLOCATION_WATCH_POSITION,
     ]);
     this.createInstrumentationBreakpoints(Category.NOTIFICATION, [
-      InstrumentationNames.NOTIFCATION_REQUEST_PERMISSION,
+      InstrumentationNames.NOTIFICATION_REQUEST_PERMISSION,
     ]);
     this.createInstrumentationBreakpoints(Category.PARSE, [
       InstrumentationNames.ELEMENT_SET_INNER_HTML,

package/front_end/core/sdk/IOModel.ts

@@ -10,7 +10,7 @@ import {SDKModel} from './SDKModel.js';
 import {Capability} from './Target.js';
 
 export class IOModel extends SDKModel<void> {
-  async read(handle: Protocol.IO.StreamHandle, size?: number, offset?: number): Promise<string|ArrayBuffer|null> {
+  async read(handle: Protocol.IO.StreamHandle, size?: number, offset?: number): Promise<string|Uint8Array|null> {
     const result = await this.target().ioAgent().invoke_read({handle, offset, size});
     if (result.getError()) {
       throw new Error(result.getError());
@@ -52,7 +52,7 @@ export class IOModel extends SDKModel<void> {
         strings.push(decoder.decode());
         break;
       }
-      if (data instanceof ArrayBuffer) {
+      if (data instanceof Uint8Array) {
         strings.push(decoder.decode(data, {stream: true}));
       } else {
         strings.push(data);
@@ -60,6 +60,32 @@ export class IOModel extends SDKModel<void> {
     }
     return strings.join('');
   }
+
+  async readToBuffer(handle: Protocol.IO.StreamHandle): Promise<Uint8Array<ArrayBuffer>> {
+    const items: Uint8Array[] = [];
+    for (;;) {
+      const data = await this.read(handle, 1024 * 1024);
+      if (data === null) {
+        break;
+      }
+      if (data instanceof Uint8Array) {
+        items.push(data);
+      } else {
+        throw new Error('Unexpected stream data type: expected binary, got a string');
+      }
+    }
+    let length = 0;
+    for (const item of items) {
+      length += item.length;
+    }
+    const result = new Uint8Array(length);
+    let offset = 0;
+    for (const item of items) {
+      result.set(item, offset);
+      offset += item.length;
+    }
+    return result;
+  }
 }
 
 SDKModel.register(IOModel, {capabilities: Capability.IO, autostart: true});

package/front_end/core/sdk/NetworkManager.test.ts

@@ -21,33 +21,6 @@ const LONG_URL_PART =
     'LoremIpsumDolorSitAmetConsecteturAdipiscingElitPhasellusVitaeOrciInAugueCondimentumTinciduntUtEgetDolorQuisqueEfficiturUltricesTinciduntVivamusVelitPurusCommodoQuisErosSitAmetTemporMalesuadaNislNullamTtempusVulputateAugueEgetScelerisqueLacusVestibulumNon/index.html';
 
 describeWithMockConnection('NetworkManager', () => {
-  describe('ConditionsSerializer', () => {
-    it('can serialize a condition', async () => {
-      const serializer = new SDK.NetworkManager.ConditionsSerializer();
-      const string = serializer.stringify(SDK.NetworkManager.Fast4GConditions);
-      assert.deepEqual(string, JSON.stringify({
-        title: 'Fast 4G',
-        i18nTitleKey: 'Fast 4G',
-        download: 1012500,
-        upload: 168750,
-        latency: 165,
-        targetLatency: 60
-      }));
-    });
-
-    it('falls back to the "No throttling" if parsing a condition goes wrong', async () => {
-      const serializer = new SDK.NetworkManager.ConditionsSerializer();
-      const broken = {
-        ...SDK.NetworkManager.Fast4GConditions,
-        title: () => {
-          throw new Error('emulate a broken title i18n lookup');
-        }
-      };
-      const string = serializer.stringify(broken);
-      assert.deepEqual(string, serializer.stringify(SDK.NetworkManager.NoThrottlingConditions));
-    });
-  });
-
   describe('Direct TCP socket handling', () => {
     it('on CDP created event creates request ', () => {
       const networkManager = new SDK.NetworkManager.NetworkManager(createTarget());