chrome-devtools-frontend 1.0.1033423 → 1.0.1034802

package/front_end/panels/elements/StylesSidebarPane.ts

@@ -218,6 +218,7 @@ export class StylesSidebarPane extends Common.ObjectWrapper.eventMixin<EventType
   #urlToChangeTracker: Map<Platform.DevToolsPath.UrlString, ChangeTracker> = new Map();
   #copyChangesButton?: UI.Toolbar.ToolbarButton;
   #updateAbortController?: AbortController;
+  #updateComputedStylesAbortController?: AbortController;
 
   static instance(): StylesSidebarPane {
     if (!stylesSidebarPaneInstance) {
@@ -753,10 +754,12 @@ export class StylesSidebarPane extends Common.ObjectWrapper.eventMixin<EventType
       for (const section of this.allSections()) {
         section.styleSheetEdited(edit);
       }
+      void this.refreshComputedStyles();
       return;
     }
 
     if (this.userOperation || this.isEditingStyle) {
+      void this.refreshComputedStyles();
       return;
     }
 
@@ -764,6 +767,27 @@ export class StylesSidebarPane extends Common.ObjectWrapper.eventMixin<EventType
     this.update();
   }
 
+  async refreshComputedStyles(): Promise<void> {
+    this.#updateComputedStylesAbortController?.abort();
+    this.#updateAbortController = new AbortController();
+    const signal = this.#updateAbortController.signal;
+    const matchedStyles = await this.fetchMatchedCascade();
+    const nodeId = this.node()?.id;
+    const parentNodeId = matchedStyles?.getParentLayoutNodeId();
+
+    const [computedStyles, parentsComputedStyles] =
+        await Promise.all([this.fetchComputedStylesFor(nodeId), this.fetchComputedStylesFor(parentNodeId)]);
+
+    if (signal.aborted) {
+      return;
+    }
+
+    for (const section of this.allSections()) {
+      section.setComputedStyles(computedStyles);
+      section.setParentsComputedStyles(parentsComputedStyles);
+    }
+  }
+
   focusedSectionIndex(): number {
     let index = 0;
     for (const block of this.sectionBlocks) {

package/front_end/panels/elements/components/CSSHintDetailsView.ts

@@ -20,10 +20,10 @@ const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);
 const {render, html, Directives} = LitHtml;
 
 interface Hint {
-    getHintPrefix(): string;
-    getHintMessage(): string;
-    getPossibleFixMessage(): string|null;
-    getLearnMoreLink(): string|undefined;
+  getPrefix(): string;
+  getMessage(): string;
+  getPossibleFixMessage(): string|null;
+  getLearnMoreLink(): string|undefined;
 }
 
 export class CSSHintDetailsView extends HTMLElement {
@@ -44,7 +44,7 @@ export class CSSHintDetailsView extends HTMLElement {
       render(html`
         <div class="hint-popup-wrapper">
           <div class="hint-popup-reason">
-              <strong>${this.#authoringHint.getHintPrefix()}:</strong> ${Directives.unsafeHTML(this.#authoringHint.getHintMessage())}
+              <strong>${this.#authoringHint.getPrefix()}:</strong> ${Directives.unsafeHTML(this.#authoringHint.getMessage())}
           </div>
           ${this.#authoringHint.getPossibleFixMessage() ? html`
               <div class="hint-popup-possible-fix">

package/front_end/panels/elements/components/LayoutPane.ts

@@ -267,7 +267,7 @@ export class LayoutPane extends HTMLElement {
           } as NodeText.NodeText.NodeTextData}></${NodeText.NodeText.NodeText.litTagName}>
         </span>
       </label>
-      <label @keyup=${onColorLabelKeyUp} @keydown=${onColorLabelKeyDown} tabindex="0" title=${i18nString(UIStrings.chooseElementOverlayColor)} class="color-picker-label" style="background: ${element.color};">
+      <label @keyup=${onColorLabelKeyUp} @keydown=${onColorLabelKeyDown} tabindex="0" title=${i18nString(UIStrings.chooseElementOverlayColor)} aria-label=${i18nString(UIStrings.chooseElementOverlayColor)} class="color-picker-label" style="background: ${element.color};">
         <input @change=${onColorChange} @input=${onColorChange} tabindex="-1" class="color-picker" type="color" value=${element.color} />
       </label>
       <button tabindex="0" @click=${onElementClick} title=${i18nString(UIStrings.showElementInTheElementsPanel)} class="show-element"></button>

package/front_end/panels/issues/AttributionReportingIssueDetailsView.ts

@@ -62,6 +62,8 @@ export class AttributionReportingIssueDetailsView extends AffectedResourcesView
       case IssuesManager.AttributionReportingIssue.IssueCode.InvalidRegisterSourceHeader:
       case IssuesManager.AttributionReportingIssue.IssueCode.InvalidRegisterTriggerHeader:
       case IssuesManager.AttributionReportingIssue.IssueCode.InvalidEligibleHeader:
+      case IssuesManager.AttributionReportingIssue.IssueCode.SourceIgnored:
+      case IssuesManager.AttributionReportingIssue.IssueCode.TriggerIgnored:
         this.appendColumnTitle(header, i18nString(UIStrings.request));
         this.appendColumnTitle(header, i18nString(UIStrings.invalidHeaderValue));
         break;
@@ -79,6 +81,9 @@ export class AttributionReportingIssueDetailsView extends AffectedResourcesView
         this.appendColumnTitle(header, i18nString(UIStrings.element));
         this.appendColumnTitle(header, i18nString(UIStrings.maximumConcurrentRegistrations));
         break;
+      case IssuesManager.AttributionReportingIssue.IssueCode.SourceAndTriggerHeaders:
+        this.appendColumnTitle(header, i18nString(UIStrings.request));
+        break;
     }
 
     this.affectedResources.appendChild(header);
@@ -102,6 +107,8 @@ export class AttributionReportingIssueDetailsView extends AffectedResourcesView
       case IssuesManager.AttributionReportingIssue.IssueCode.InvalidRegisterSourceHeader:
       case IssuesManager.AttributionReportingIssue.IssueCode.InvalidRegisterTriggerHeader:
       case IssuesManager.AttributionReportingIssue.IssueCode.InvalidEligibleHeader:
+      case IssuesManager.AttributionReportingIssue.IssueCode.SourceIgnored:
+      case IssuesManager.AttributionReportingIssue.IssueCode.TriggerIgnored:
         this.#appendRequestOrEmptyCell(element, details.request);
         this.appendIssueDetailCell(element, details.invalidParameter || '');
         break;
@@ -119,6 +126,9 @@ export class AttributionReportingIssueDetailsView extends AffectedResourcesView
         await this.#appendElementOrEmptyCell(element, issue);
         this.appendIssueDetailCell(element, details.invalidParameter || '');
         break;
+      case IssuesManager.AttributionReportingIssue.IssueCode.SourceAndTriggerHeaders:
+        this.#appendRequestOrEmptyCell(element, details.request);
+        break;
     }
 
     this.affectedResources.appendChild(element);

package/front_end/panels/lighthouse/LighthouseProtocolService.ts

@@ -63,6 +63,7 @@ export class ProtocolService {
   private parallelConnection?: ProtocolClient.InspectorBackend.Connection;
   private lighthouseWorkerPromise?: Promise<Worker>;
   private lighthouseMessageUpdateCallback?: ((arg0: string) => void);
+  private configForTesting?: Object;
 
   async attach(): Promise<void> {
     await SDK.TargetManager.TargetManager.instance().suspendAllTargets();
@@ -113,6 +114,7 @@ export class ProtocolService {
       url: inspectedURL,
       categoryIDs,
       flags,
+      config: this.configForTesting,
       locales: this.getLocales(),
       target: this.targetInfo,
     });
@@ -134,6 +136,7 @@ export class ProtocolService {
       url: inspectedURL,
       categoryIDs,
       flags,
+      config: this.configForTesting,
       locales: this.getLocales(),
       target: this.targetInfo,
     });
@@ -178,7 +181,7 @@ export class ProtocolService {
       method?: string,
     };
     if (protocolMessage.sessionId || (protocolMessage.method && protocolMessage.method.startsWith('Target'))) {
-      void this.send('dispatchProtocolMessage', {message: JSON.stringify(message)});
+      void this.send('dispatchProtocolMessage', {message});
     }
   }
 
@@ -215,7 +218,7 @@ export class ProtocolService {
   }
 
   private onWorkerMessage(event: MessageEvent): void {
-    const lighthouseMessage = JSON.parse(event.data);
+    const lighthouseMessage = event.data;
 
     if (lighthouseMessage.action === 'statusUpdate') {
       if (this.lighthouseMessageUpdateCallback && lighthouseMessage.args && 'message' in lighthouseMessage.args) {
@@ -237,17 +240,17 @@ export class ProtocolService {
   private async send(action: string, args: {[x: string]: string|string[]|Object} = {}): Promise<void> {
     const worker = await this.ensureWorkerExists();
     const messageId = lastId++;
-    worker.postMessage(JSON.stringify({id: messageId, action, args: {...args, id: messageId}}));
+    worker.postMessage({id: messageId, action, args: {...args, id: messageId}});
   }
 
   /** sendWithResponse currently only handles the original startLighthouse request and LHR-filled response. */
-  private async sendWithResponse(action: string, args: {[x: string]: string|string[]|Object} = {}):
+  private async sendWithResponse(action: string, args: {[x: string]: string|string[]|Object|undefined} = {}):
       Promise<ReportRenderer.RunnerResult> {
     const worker = await this.ensureWorkerExists();
     const messageId = lastId++;
     const messageResult = new Promise<ReportRenderer.RunnerResult>(resolve => {
       const workerListener = (event: MessageEvent): void => {
-        const lighthouseMessage = JSON.parse(event.data);
+        const lighthouseMessage = event.data;
 
         if (lighthouseMessage.id === messageId) {
           worker.removeEventListener('message', workerListener);
@@ -256,7 +259,7 @@ export class ProtocolService {
       };
       worker.addEventListener('message', workerListener);
     });
-    worker.postMessage(JSON.stringify({id: messageId, action, args: {...args, id: messageId}}));
+    worker.postMessage({id: messageId, action, args: {...args, id: messageId}});
 
     return messageResult;
   }

package/front_end/ui/components/linear_memory_inspector/LinearMemoryInspectorController.ts

@@ -307,6 +307,22 @@ export class LinearMemoryInspectorController extends SDK.TargetManager.SDKModelO
     return objType.slice(0, objType.length - 1);
   }
 
+  // When inspecting a pointer variable, we indicate that we display the pointed-to object in the viewer
+  // by prepending an asterisk to the pointer expression's name (mimicking C++ dereferencing).
+  // If the object isn't a pointer, we return the expression unchanged.
+  //
+  // Examples:
+  // (int *) myNumber -> (int) *myNumber
+  // (int[]) numbers -> (int[]) numbers
+  static extractObjectName(obj: Bindings.DebuggerLanguagePlugins.ValueNode, expression: string): string {
+    const lastChar = obj.description?.charAt(obj.description.length - 1);
+    const isPointerType = lastChar === '*';
+    if (isPointerType) {
+      return '*' + expression;
+    }
+    return expression;
+  }
+
   async openInspectorView(obj: SDK.RemoteObject.RemoteObject, address?: number, expression?: string): Promise<void> {
     const response = await LinearMemoryInspectorController.retrieveDWARFMemoryObjectAndAddress(obj);
     let memoryObj = obj;
@@ -368,7 +384,7 @@ export class LinearMemoryInspectorController extends SDK.TargetManager.SDKModelO
       highlightInfo = {
         startAddress: obj.inspectableAddress || 0,
         size: LinearMemoryInspectorController.extractObjectSize(obj),
-        name: expression,
+        name: expression ? LinearMemoryInspectorController.extractObjectName(obj, expression) : expression,
         type: LinearMemoryInspectorController.extractObjectTypeDescription(obj),
       };
     } catch (err) {

package/front_end/ui/components/markdown_view/MarkdownLinksMap.ts

@@ -27,6 +27,7 @@ export const markdownLinks = new Map<string, string>([
   ],
   ['issueQuirksModeDoctype', 'https://web.dev/doctype/'],
   ['sameSiteAndSameOrigin', 'https://web.dev/same-site-same-origin/'],
+  ['punycodeReference', 'https://wikipedia.org/wiki/Punycode'],
   // Link URLs for deprecation issues (see blink::Deprecation)
   ['https://xhr.spec.whatwg.org/', 'https://xhr.spec.whatwg.org/'],
   ['https://goo.gle/chrome-insecure-origins', 'https://goo.gle/chrome-insecure-origins'],

package/front_end/ui/legacy/components/object_ui/JavaScriptREPL.ts

@@ -36,7 +36,7 @@ export class JavaScriptREPL {
 
   static async evaluateAndBuildPreview(
       text: string, throwOnSideEffect: boolean, replMode: boolean, timeout?: number, allowErrors?: boolean,
-      objectGroup?: string, awaitPromise: boolean = false): Promise<{
+      objectGroup?: string, awaitPromise: boolean = false, silent: boolean = false): Promise<{
     preview: DocumentFragment,
     result: SDK.RuntimeModel.EvaluationResult|null,
   }> {
@@ -56,7 +56,7 @@ export class JavaScriptREPL {
       objectGroup: objectGroup,
       disableBreaks: true,
       replMode: replMode,
-      silent: undefined,
+      silent: silent,
       returnByValue: undefined,
       allowUnsafeEvalBlockedByCSP: undefined,
     };

package/package.json

@@ -56,5 +56,5 @@
     "unittest": "scripts/test/run_unittests.py --no-text-coverage",
     "watch": "vpython third_party/node/node.py --output scripts/watch_build.js"
   },
-  "version": "1.0.1033423"
+  "version": "1.0.1034802"
 }