chrome-devtools-frontend 1.0.1033423 → 1.0.1034802

package/config/gni/devtools_grd_files.gni

@@ -286,9 +286,14 @@ grd_files_release_sources = [
   "front_end/models/issues_manager/descriptions/arInvalidRegisterSourceHeader.md",
   "front_end/models/issues_manager/descriptions/arInvalidRegisterTriggerHeader.md",
   "front_end/models/issues_manager/descriptions/arPermissionPolicyDisabled.md",
+  "front_end/models/issues_manager/descriptions/arSourceAndTriggerHeaders.md",
+  "front_end/models/issues_manager/descriptions/arSourceIgnored.md",
+  "front_end/models/issues_manager/descriptions/arTriggerIgnored.md",
   "front_end/models/issues_manager/descriptions/arUntrustworthyReportingOrigin.md",
   "front_end/models/issues_manager/descriptions/clientHintMetaTagAllowListInvalidOrigin.md",
   "front_end/models/issues_manager/descriptions/clientHintMetaTagModifiedHTML.md",
+  "front_end/models/issues_manager/descriptions/cookieExcludeDomainNonAscii.md",
+  "front_end/models/issues_manager/descriptions/cookieWarnDomainNonAscii.md",
   "front_end/models/issues_manager/descriptions/corsAllowCredentialsRequired.md",
   "front_end/models/issues_manager/descriptions/corsDisabledScheme.md",
   "front_end/models/issues_manager/descriptions/corsDisallowedByMode.md",

package/front_end/core/host/InspectorFrontendHostAPI.ts

@@ -377,4 +377,5 @@ export enum EnumeratedHistogram {
   RecordingToggled = 'DevTools.RecordingToggled',
   StyleTextCopied = 'DevTools.StyleTextCopied',
   ManifestSectionSelected = 'DevTools.ManifestSectionSelected',
+  CSSHintShown = 'DevTools.CSSHintShown',
 }

package/front_end/core/host/UserMetrics.ts

@@ -277,6 +277,11 @@ export class UserMetrics {
     InspectorFrontendHostInstance.recordEnumeratedHistogram(
         EnumeratedHistogram.ManifestSectionSelected, code, ManifestSectionCodes.MaxValue);
   }
+
+  cssHintShown(type: CSSHintType): void {
+    InspectorFrontendHostInstance.recordEnumeratedHistogram(
+        EnumeratedHistogram.CSSHintShown, type, CSSHintType.MaxValue);
+  }
 }
 
 /**
@@ -993,4 +998,22 @@ export enum ManifestSectionCodes {
   MaxValue = 5,
 }
 
+// The names here match the CSSRuleValidator names in CSSRuleValidator.ts.
+// TODO(crbug.com/1167717): Make this a const enum again
+// eslint-disable-next-line rulesdir/const_enum
+export enum CSSHintType {
+  Other = 0,
+  AlignContent = 1,
+  FlexItem = 2,
+  FlexContainer = 3,
+  GridContainer = 4,
+  GridItem = 5,
+  FlexGrid = 6,
+  MulticolFlexGrid = 7,
+  Padding = 8,
+  Position = 9,
+  ZIndex = 10,
+  MaxValue = 11,
+}
+
 /* eslint-enable @typescript-eslint/naming-convention */

package/front_end/core/root/Runtime.ts

@@ -120,18 +120,21 @@ export class ExperimentsSupport {
   #enabledTransiently: Set<string>;
   readonly #enabledByDefault: Set<string>;
   readonly #serverEnabled: Set<string>;
+  // Experiments in this set won't be shown to the user
+  readonly #nonConfigurable: Set<string>;
   constructor() {
     this.#experiments = [];
     this.#experimentNames = new Set();
     this.#enabledTransiently = new Set();
     this.#enabledByDefault = new Set();
     this.#serverEnabled = new Set();
+    this.#nonConfigurable = new Set();
   }
 
   allConfigurableExperiments(): Experiment[] {
     const result = [];
     for (const experiment of this.#experiments) {
-      if (!this.#enabledTransiently.has(experiment.name)) {
+      if (!this.#enabledTransiently.has(experiment.name) && !this.#nonConfigurable.has(experiment.name)) {
         result.push(experiment);
       }
     }
@@ -203,6 +206,13 @@ export class ExperimentsSupport {
     }
   }
 
+  setNonConfigurableExperiments(experimentNames: string[]): void {
+    for (const experiment of experimentNames) {
+      this.checkExperiment(experiment);
+      this.#nonConfigurable.add(experiment);
+    }
+  }
+
   enableForTest(experimentName: string): void {
     this.checkExperiment(experimentName);
     this.#enabledTransiently.add(experimentName);

package/front_end/core/sdk/NetworkManager.ts

@@ -465,10 +465,10 @@ export class NetworkDispatcher implements ProtocolProxyApi.NetworkDispatcher {
       networkRequest.setUrl(response.url as Platform.DevToolsPath.UrlString);
     }
     networkRequest.mimeType = (response.mimeType as MIME_TYPE);
-    if (!networkRequest.statusCode) {
+    if (!networkRequest.statusCode || networkRequest.wasIntercepted()) {
       networkRequest.statusCode = response.status;
     }
-    if (!networkRequest.statusText) {
+    if (!networkRequest.statusText || networkRequest.wasIntercepted()) {
       networkRequest.statusText = response.statusText;
     }
     if (!networkRequest.hasExtraResponseInfo() || networkRequest.wasIntercepted()) {
@@ -1170,6 +1170,10 @@ export class MultitargetNetworkManager extends Common.ObjectWrapper.ObjectWrappe
     return multiTargetNetworkManagerInstance;
   }
 
+  static dispose(): void {
+    multiTargetNetworkManagerInstance = null;
+  }
+
   static getChromeVersion(): string {
     const chromeRegex = /(?:^|\W)(?:Chrome|HeadlessChrome)\/(\S+)/;
     const chromeMatch = navigator.userAgent.match(chromeRegex);
@@ -1523,6 +1527,7 @@ export namespace MultitargetNetworkManager {
     InterceptorsChanged = 'InterceptorsChanged',
     AcceptedEncodingsChanged = 'AcceptedEncodingsChanged',
     RequestIntercepted = 'RequestIntercepted',
+    RequestFulfilled = 'RequestFulfilled',
   }
 
   export type EventTypes = {
@@ -1532,6 +1537,7 @@ export namespace MultitargetNetworkManager {
     [Events.InterceptorsChanged]: void,
     [Events.AcceptedEncodingsChanged]: void,
     [Events.RequestIntercepted]: Platform.DevToolsPath.UrlString,
+    [Events.RequestFulfilled]: Platform.DevToolsPath.UrlString,
   };
 }
 
@@ -1565,11 +1571,15 @@ export class InterceptedRequest {
     return this.#hasRespondedInternal;
   }
 
-  async continueRequestWithContent(contentBlob: Blob, encoded: boolean, responseHeaders: Protocol.Fetch.HeaderEntry[]):
-      Promise<void> {
+  async continueRequestWithContent(
+      contentBlob: Blob, encoded: boolean, responseHeaders: Protocol.Fetch.HeaderEntry[],
+      isBodyOverridden: boolean): Promise<void> {
     this.#hasRespondedInternal = true;
     const body = encoded ? await contentBlob.text() : await blobToBase64(contentBlob);
-    void this.#fetchAgent.invoke_fulfillRequest({requestId: this.requestId, responseCode: 200, body, responseHeaders});
+    const responseCode = isBodyOverridden ? 200 : (this.responseStatusCode || 200);
+    void this.#fetchAgent.invoke_fulfillRequest({requestId: this.requestId, responseCode, body, responseHeaders});
+    MultitargetNetworkManager.instance().dispatchEventToListeners(
+        MultitargetNetworkManager.Events.RequestFulfilled, this.request.url as Platform.DevToolsPath.UrlString);
 
     async function blobToBase64(blob: Blob): Promise<string> {
       const reader = new FileReader();
@@ -1608,6 +1618,10 @@ export class InterceptedRequest {
     const error = response.getError() || null;
     return {error: error, content: error ? null : response.body, encoded: response.base64Encoded};
   }
+
+  isRedirect(): boolean {
+    return this.responseStatusCode !== undefined && this.responseStatusCode >= 300 && this.responseStatusCode < 400;
+  }
 }
 
 /**

package/front_end/entrypoints/lighthouse_worker/LighthouseWorkerService.ts

@@ -125,7 +125,7 @@ async function invokeLH(action: string, args: any): Promise<unknown> {
     }
 
     // @ts-expect-error https://github.com/GoogleChrome/lighthouse/issues/11628
-    const config = self.createConfig(args.categoryIDs, flags.emulatedFormFactor);
+    const config = args.config || self.createConfig(args.categoryIDs, flags.emulatedFormFactor);
     const url = args.url;
 
     // Handle legacy Lighthouse runner path.
@@ -222,25 +222,36 @@ async function fetchLocaleData(locales: string[]): Promise<string|void> {
  */
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
 function notifyFrontendViaWorkerMessage(action: string, args: any): void {
-  self.postMessage(JSON.stringify({action, args}));
+  self.postMessage({action, args});
 }
 
 async function onFrontendMessage(event: MessageEvent): Promise<void> {
-  const messageFromFrontend = JSON.parse(event.data);
+  const messageFromFrontend = event.data;
   switch (messageFromFrontend.action) {
     case 'startTimespan':
     case 'endTimespan':
     case 'snapshot':
     case 'navigation': {
       const result = await invokeLH(messageFromFrontend.action, messageFromFrontend.args);
-      self.postMessage(JSON.stringify({id: messageFromFrontend.id, result}));
+      if (result && typeof result === 'object') {
+        // Report isn't used upstream.
+        if ('report' in result) {
+          // @ts-expect-error
+          delete result.report;
+        }
+
+        // Logger PerformanceTiming objects cannot be cloned by this worker's `postMessage` function.
+        if ('artifacts' in result) {
+          // @ts-expect-error
+          result.artifacts.Timing = JSON.parse(JSON.stringify(result.artifacts.Timing));
+        }
+      }
+      self.postMessage({id: messageFromFrontend.id, result});
       break;
     }
     case 'dispatchProtocolMessage': {
-      cdpConnection?.onMessage?.(
-          JSON.parse(messageFromFrontend.args.message),
-      );
-      legacyPort.onMessage?.(messageFromFrontend.args.message);
+      cdpConnection?.onMessage?.(messageFromFrontend.args.message);
+      legacyPort.onMessage?.(JSON.stringify(messageFromFrontend.args.message));
       break;
     }
     default: {

package/front_end/entrypoints/main/MainImpl.ts

@@ -426,10 +426,14 @@ export class MainImpl {
       'reportingApiDebugging',
       Root.Runtime.ExperimentName.SYNC_SETTINGS,
       Root.Runtime.ExperimentName.CSS_LAYERS,
-      Root.Runtime.ExperimentName.EYEDROPPER_COLOR_PICKER,
+      ...('EyeDropper' in window ? [Root.Runtime.ExperimentName.EYEDROPPER_COLOR_PICKER] : []),
       'lighthousePanelFR',
     ]);
 
+    Root.Runtime.experiments.setNonConfigurableExperiments([
+      ...(!('EyeDropper' in window) ? [Root.Runtime.ExperimentName.EYEDROPPER_COLOR_PICKER] : []),
+    ]);
+
     Root.Runtime.experiments.cleanUpStaleExperiments();
     const enabledExperiments = Root.Runtime.Runtime.queryParam('enabledExperiments');
     if (enabledExperiments) {

package/front_end/models/issues_manager/AttributionReportingIssue.ts

@@ -16,6 +16,9 @@ export const enum IssueCode {
   InvalidRegisterTriggerHeader = 'AttributionReportingIssue::InvalidRegisterTriggerHeader',
   InvalidEligibleHeader = 'AttributionReportingIssue::InvalidEligibleHeader',
   TooManyConcurrentRequests = 'AttributionReportingIssue::TooManyConcurrentRequests',
+  SourceAndTriggerHeaders = 'AttributionReportingIssue::SourceAndTriggerHeaders',
+  SourceIgnored = 'AttributionReportingIssue::SourceIgnored',
+  TriggerIgnored = 'AttributionReportingIssue::TriggerIgnored',
   // TODO(apaseltiner): Remove this once old issue types are removed from
   // protocol.
   Unknown = 'AttributionReportingIssue::Unknown',
@@ -37,11 +40,22 @@ function getIssueCode(details: Protocol.Audits.AttributionReportingIssueDetails)
       return IssueCode.InvalidEligibleHeader;
     case Protocol.Audits.AttributionReportingIssueType.TooManyConcurrentRequests:
       return IssueCode.TooManyConcurrentRequests;
+    case Protocol.Audits.AttributionReportingIssueType.SourceAndTriggerHeaders:
+      return IssueCode.SourceAndTriggerHeaders;
+    case Protocol.Audits.AttributionReportingIssueType.SourceIgnored:
+      return IssueCode.SourceIgnored;
+    case Protocol.Audits.AttributionReportingIssueType.TriggerIgnored:
+      return IssueCode.TriggerIgnored;
     default:
       return IssueCode.Unknown;
   }
 }
 
+const structuredHeaderLink = {
+  link: 'https://tools.ietf.org/id/draft-ietf-httpbis-header-structure-15.html#rfc.section.4.2.2',
+  linkTitle: 'Structured Headers RFC',
+};
+
 export class AttributionReportingIssue extends Issue<IssueCode> {
   issueDetails: Readonly<Protocol.Audits.AttributionReportingIssueDetails>;
 
@@ -85,16 +99,28 @@ export class AttributionReportingIssue extends Issue<IssueCode> {
       case IssueCode.InvalidEligibleHeader:
         return {
           file: 'arInvalidEligibleHeader.md',
-          links: [{
-            link: 'https://tools.ietf.org/id/draft-ietf-httpbis-header-structure-15.html#rfc.section.4.2.2',
-            linkTitle: 'Structured Headers RFC',
-          }],
+          links: [structuredHeaderLink],
         };
       case IssueCode.TooManyConcurrentRequests:
         return {
           file: 'arTooManyConcurrentRequests.md',
           links: [],
         };
+      case IssueCode.SourceAndTriggerHeaders:
+        return {
+          file: 'arSourceAndTriggerHeaders.md',
+          links: [],
+        };
+      case IssueCode.SourceIgnored:
+        return {
+          file: 'arSourceIgnored.md',
+          links: [structuredHeaderLink],
+        };
+      case IssueCode.TriggerIgnored:
+        return {
+          file: 'arTriggerIgnored.md',
+          links: [structuredHeaderLink],
+        };
       case IssueCode.Unknown:
         return null;
     }

package/front_end/models/issues_manager/CookieIssue.ts

@@ -435,6 +435,16 @@ const attributeValueExceedsMaxSize: LazyMarkdownIssueDescription = {
   links: [],
 };
 
+const warnDomainNonAscii: LazyMarkdownIssueDescription = {
+  file: 'cookieWarnDomainNonAscii.md',
+  links: [],
+};
+
+const excludeDomainNonAscii: LazyMarkdownIssueDescription = {
+  file: 'cookieExcludeDomainNonAscii.md',
+  links: [],
+};
+
 const issueDescriptions: Map<string, LazyMarkdownIssueDescription> = new Map([
   ['CookieIssue::ExcludeSameSiteUnspecifiedTreatedAsLax::ReadCookie', sameSiteUnspecifiedErrorRead],
   ['CookieIssue::ExcludeSameSiteUnspecifiedTreatedAsLax::SetCookie', sameSiteUnspecifiedErrorSet],
@@ -466,4 +476,8 @@ const issueDescriptions: Map<string, LazyMarkdownIssueDescription> = new Map([
   ['CookieIssue::ExcludeSamePartyCrossPartyContext::SetCookie', samePartyCrossPartyContextSet],
   ['CookieIssue::WarnAttributeValueExceedsMaxSize::ReadCookie', attributeValueExceedsMaxSize],
   ['CookieIssue::WarnAttributeValueExceedsMaxSize::SetCookie', attributeValueExceedsMaxSize],
+  ['CookieIssue::WarnDomainNonASCII::ReadCookie', warnDomainNonAscii],
+  ['CookieIssue::WarnDomainNonASCII::SetCookie', warnDomainNonAscii],
+  ['CookieIssue::ExcludeDomainNonASCII::ReadCookie', excludeDomainNonAscii],
+  ['CookieIssue::ExcludeDomainNonASCII::SetCookie', excludeDomainNonAscii],
 ]);

package/front_end/models/issues_manager/descriptions/arSourceAndTriggerHeaders.md

@@ -0,0 +1,9 @@
+# Ensure that attribution responses contain either source or trigger, not both
+
+This page tried to register a source and a trigger in the same HTTP response
+using the Attribution Reporting API, which is prohibited.
+
+The corresponding request was eligible to register either a source or a
+trigger, but the response may only set either the
+`Attribution-Reporting-Register-Source` header or the
+`Attribution-Reporting-Register-Trigger` header, not both.

package/front_end/models/issues_manager/descriptions/arSourceIgnored.md

@@ -0,0 +1,13 @@
+# An attribution source registration was ignored because the request was ineligible
+
+This page tried to register a source using the Attribution Reporting API, but
+the request was ineligible to do so, so the source registration was ignored.
+
+A request is eligible for source registration if it has an
+`Attribution-Reporting-Eligible` header whose value is a structured dictionary
+that contains the key `navigation-source` or `event-source`. If the header is
+absent or does not contain one of those keys, any
+`Attribution-Reporting-Register-Source` response header will be ignored.
+
+Additionally, a single HTTP redirect chain may register only all sources or all
+triggers, not a combination of both.

package/front_end/models/issues_manager/descriptions/arTriggerIgnored.md

@@ -0,0 +1,12 @@
+# An attribution trigger registration was ignored because the request was ineligible
+
+This page tried to register a trigger using the Attribution Reporting API, but
+the request was ineligible to do so, so the trigger registration was ignored.
+
+A request is eligible for trigger registration if it has an
+`Attribution-Reporting-Eligible` header whose value is a structured dictionary
+that contains the key `trigger`, or if the header is absent. Otherwise, any
+`Attribution-Reporting-Register-Trigger` response header will be ignored.
+
+Additionally, a single HTTP redirect chain may register only all sources or all
+triggers, not a combination of both.

package/front_end/models/issues_manager/descriptions/cookieExcludeDomainNonAscii.md

@@ -0,0 +1,11 @@
+# Ensure cookie `Domain` attribute values only contain ASCII characters
+
+`Domain` attributes in cookies are restricted to the ASCII character set. Any
+cookies that contain characters outside of the ASCII range in their `Domain`
+attribute will be ignored.
+
+To resolve this issue, you need to remove all non-ASCII characters from the
+`Domain` attribute of the affected cookies.
+
+If your site has an internationalized domain name (IDN), you should use
+[punycode](punycodeReference) representation for the `Domain` attribute instead.

package/front_end/models/issues_manager/descriptions/cookieWarnDomainNonAscii.md

@@ -0,0 +1,11 @@
+# Ensure cookie `Domain` attribute values only contain ASCII characters
+
+`Domain` attributes in cookies are restricted to the ASCII character set. Any
+cookies that contain characters outside of the ASCII range in their `Domain`
+attribute will be ignored in the future.
+
+To resolve this issue, you need to remove all non-ASCII characters from the
+`Domain` attribute of the affected cookies.
+
+If your site has an internationalized domain name (IDN), you should use
+[punycode](punycodeReference) representation for the `Domain` attribute instead.

package/front_end/models/persistence/NetworkPersistenceManager.ts

@@ -731,13 +731,17 @@ export class NetworkPersistenceManager extends Common.ObjectWrapper.ObjectWrappe
       const blob = await project.requestFileBlob(fileSystemUISourceCode);
       if (blob) {
         void interceptedRequest.continueRequestWithContent(
-            new Blob([blob], {type: mimeType}), /* encoded */ false, responseHeaders);
+            new Blob([blob], {type: mimeType}), /* encoded */ false, responseHeaders, /* isBodyOverridden */ true);
       }
+    } else if (interceptedRequest.isRedirect()) {
+      void interceptedRequest.continueRequestWithContent(
+          new Blob([], {type: mimeType}), /* encoded */ true, responseHeaders, /* isBodyOverridden */ false);
     } else {
       const responseBody = await interceptedRequest.responseBody();
       if (!responseBody.error && responseBody.content) {
         void interceptedRequest.continueRequestWithContent(
-            new Blob([responseBody.content], {type: mimeType}), /* encoded */ true, responseHeaders);
+            new Blob([responseBody.content], {type: mimeType}), /* encoded */ true, responseHeaders,
+            /* isBodyOverridden */ false);
       }
     }
   }

package/front_end/panels/console/ConsolePinPane.ts

@@ -329,8 +329,8 @@ export class ConsolePin {
     const executionContext = UI.Context.Context.instance().flavor(SDK.RuntimeModel.ExecutionContext);
     const preprocessedExpression = ObjectUI.JavaScriptREPL.JavaScriptREPL.preprocessExpression(text);
     const {preview, result} = await ObjectUI.JavaScriptREPL.JavaScriptREPL.evaluateAndBuildPreview(
-        preprocessedExpression, throwOnSideEffect, false /* replMode */, timeout, !isEditing /* allowErrors */,
-        'console', true /* awaitPromise */);
+        preprocessedExpression, throwOnSideEffect, true /* replMode */, timeout, !isEditing /* allowErrors */,
+        'console', true /* awaitPromise */, true /* silent */);
     if (this.lastResult && this.lastExecutionContext) {
       this.lastExecutionContext.runtimeModel.releaseEvaluationResult(this.lastResult);
     }